Repository navigation
[backport cloud/1.58] fix: refuse remote DynamicGroup row counts above max - #21444
Conversation
A remote write to a DynamicGroup row count goes straight through the controller setter, which normalizes to `Math.max(min, trunc(value))` and never applies `max`. So `rows = 25` on a `max: 20` group quietly creates 25 rows, and a very large value can freeze the tab adding rows one at a time. The remote apply path now refuses a row count that would grow the group past `max` before touching the setter. Nothing changes on the node, the apply counts as a failure, and the existing remote mismatch report fires. A group restored with more rows than `max` can still re-apply its own count or shrink; only growth past `max(max, current rows, rows the document carries values for)` is refused, so a rollback or undo can bring back rows the doc still holds. The shared setter is left alone on purpose: restoring a saved workflow must keep rows it already has beyond `max`. - Fixes #21095 | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: cover remote DynamicGroup row counts above max` (c76a686) | :red_circle: [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39096366190) | Proves the test catches the bug | | `fix: refuse remote DynamicGroup row counts above max` (a54e8b3) | :green_circle: [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39098010935) | Proves the fix resolves the bug | | `test: cover a remote row count above max on a restored DynamicGroup` (dcf95ae) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39100669923) | A restored group already above `max` still counted the refused write as a success | | `fix: report a refused remote row count even when the group already holds it` (7457a8c) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39101290723) | Above-max requests are always reported as refused | | `test: accept remote row counts that do not grow a restored DynamicGroup` (b027386) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39107083689) | Re-applying or shrinking a restored above-max group was reported as a refusal | | `fix: refuse only remote row counts that grow a DynamicGroup past max` (15db48a) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39107937126) | Only growth past `max(max, current rows)` is refused | | `test: restore rows a remote rollback still documents above max` (32c99ae) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39117022789) | A rollback to rows the doc still holds was refused after a local remove | | `fix: count documented DynamicGroup rows toward the remote row ceiling` (bc77798) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39117879853) | The ceiling also counts rows the document carries values for | - [x] CI red on test-only commit (only the two new above-max cases fail) - [x] CI green on fix commit - Unit coverage for a remote count at `max` (applies), `max + 1` and `1e9` (refused, no row allocated, mismatch reported), a saved workflow with rows above `max` (restored as is), and on such a restored group: re-applying the same count or shrinking applies, growing further is refused, and growing back to rows the doc still carries values for applies. The large-value case spies on `addCustomWidget` so the red commit fails fast instead of hanging. - No E2E: the remote apply path is covered at the `LiveGraphApplier` level with a followed Y.Doc, which is where the refusal lives. (cherry picked from commit f66a36f)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-20T10:59:20.469Z",
"gitSha": "91e279c13bbfb757940790fd3314c34b767af040",
"branch": "backport-21264-to-cloud-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2020.5729999999562,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.948,
"layouts": 9,
"layoutDurationMs": 2.8780000000000006,
"taskDurationMs": 555.4639999999999,
"heapDeltaBytes": 4187460,
"heapUsedBytes": 103460740,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.807999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2017.466000000013,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.32,
"layouts": 9,
"layoutDurationMs": 3.3049999999999997,
"taskDurationMs": 403.583,
"heapDeltaBytes": 3585096,
"heapUsedBytes": 95088916,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.693,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.8769999999759,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.248,
"layouts": 10,
"layoutDurationMs": 2.8659999999999997,
"taskDurationMs": 823.3009999999999,
"heapDeltaBytes": -13630884,
"heapUsedBytes": 90604636,
"domNodes": -200,
"jsHeapTotalBytes": 3575808,
"scriptDurationMs": 171.892,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2040.0960000000623,
"styleRecalcs": 86,
"styleRecalcDurationMs": 14.646999999999998,
"layouts": 9,
"layoutDurationMs": 3.0030000000000006,
"taskDurationMs": 1160.014,
"heapDeltaBytes": -18972152,
"heapUsedBytes": 84911472,
"domNodes": -180,
"jsHeapTotalBytes": 2801664,
"scriptDurationMs": 168.543,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.3639999999805,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.284,
"layouts": 13,
"layoutDurationMs": 4.146000000000001,
"taskDurationMs": 350.092,
"heapDeltaBytes": 1798052,
"heapUsedBytes": 105519352,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 14.944000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1771.5640000000121,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.6049999999999995,
"layouts": 11,
"layoutDurationMs": 3.167,
"taskDurationMs": 443.373,
"heapDeltaBytes": 1849664,
"heapUsedBytes": 105628608,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 14.218000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 683.4119999999757,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.4669999999999996,
"layouts": 10,
"layoutDurationMs": 3.3629999999999995,
"taskDurationMs": 492.77700000000004,
"heapDeltaBytes": 4771976,
"heapUsedBytes": 102829848,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 165.442,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 619.5069999999987,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.9890000000000003,
"layouts": 9,
"layoutDurationMs": 2.7750000000000004,
"taskDurationMs": 456.952,
"heapDeltaBytes": 6510764,
"heapUsedBytes": 110718328,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 174.35,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1200.0899999999888,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 850.315,
"heapDeltaBytes": 15335800,
"heapUsedBytes": 124917488,
"domNodes": -211,
"jsHeapTotalBytes": 6361088,
"scriptDurationMs": 64.65799999999999,
"eventListeners": -168,
"totalBlockingTimeMs": 539,
"frameDurationMs": 34.80294117647057,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1238.6889999999084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 946.345,
"heapDeltaBytes": -11986824,
"heapUsedBytes": 101936172,
"domNodes": -210,
"jsHeapTotalBytes": 13086720,
"scriptDurationMs": 66.54099999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 553,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.1979999999921,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.7420000000005,
"heapDeltaBytes": -4178624,
"heapUsedBytes": 97110780,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.99399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.99999999999997,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.5510000000668,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.5610000000003,
"heapDeltaBytes": -3973764,
"heapUsedBytes": 96231512,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.96000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9872.157000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9043.613,
"heapDeltaBytes": 16084580,
"heapUsedBytes": 137632736,
"domNodes": -276,
"jsHeapTotalBytes": 28479488,
"scriptDurationMs": 7456.582,
"eventListeners": -130,
"totalBlockingTimeMs": 1074,
"frameDurationMs": 32.778073089700996,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11476.627000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10658.667000000001,
"heapDeltaBytes": 27069208,
"heapUsedBytes": 148504916,
"domNodes": -276,
"jsHeapTotalBytes": 51548160,
"scriptDurationMs": 8690.532999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 1485,
"frameDurationMs": 31.674861878453036,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10600.820999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9771.350999999999,
"heapDeltaBytes": 29262044,
"heapUsedBytes": 141562568,
"domNodes": -276,
"jsHeapTotalBytes": 28020736,
"scriptDurationMs": 7808.035999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 872,
"frameDurationMs": 31.546130952380953,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9890.623000000005,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06999999999999976,
"layouts": 1,
"layoutDurationMs": 0.30500000000000016,
"taskDurationMs": 9051.818000000001,
"heapDeltaBytes": 14314724,
"heapUsedBytes": 119922716,
"domNodes": -296,
"jsHeapTotalBytes": 19107840,
"scriptDurationMs": 7155.753,
"eventListeners": -130,
"totalBlockingTimeMs": 814,
"frameDurationMs": 30.648916408668725,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 227.03599999999824,
"styleRecalcs": 22,
"styleRecalcDurationMs": 15.925999999999998,
"layouts": 11,
"layoutDurationMs": 3.4960000000000004,
"taskDurationMs": 174.911,
"heapDeltaBytes": 13259448,
"heapUsedBytes": 118111884,
"domNodes": 917,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 8.479000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 1,
"frameDurationMs": 27.77777777777778,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 222.73199999995086,
"styleRecalcs": 23,
"styleRecalcDurationMs": 15.583000000000002,
"layouts": 11,
"layoutDurationMs": 3.6079999999999997,
"taskDurationMs": 176.735,
"heapDeltaBytes": 13246044,
"heapUsedBytes": 118192600,
"domNodes": 917,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 8.386000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 4,
"frameDurationMs": 25.922222222222242,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2038.5799999999676,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1799999999999997,
"layouts": 7,
"layoutDurationMs": 1.9699999999999995,
"taskDurationMs": 515.832,
"heapDeltaBytes": -1589364,
"heapUsedBytes": 101284328,
"domNodes": -276,
"jsHeapTotalBytes": -2387968,
"scriptDurationMs": 34.433,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2033.0779999999322,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.0439999999999996,
"layouts": 7,
"layoutDurationMs": 2.037,
"taskDurationMs": 666.705,
"heapDeltaBytes": -3574420,
"heapUsedBytes": 100092944,
"domNodes": -296,
"jsHeapTotalBytes": -2912256,
"scriptDurationMs": 31.108000000000004,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2923.9150000000222,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.747000000000002,
"layouts": 6,
"layoutDurationMs": 1.9830000000000003,
"taskDurationMs": 1770.267,
"heapDeltaBytes": 22711252,
"heapUsedBytes": 128730496,
"domNodes": -296,
"jsHeapTotalBytes": 5177344,
"scriptDurationMs": 834.936,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.858959537572257,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2743.5090000000173,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.032000000000002,
"layouts": 6,
"layoutDurationMs": 1.622,
"taskDurationMs": 1782.301,
"heapDeltaBytes": -12980880,
"heapUsedBytes": 99414308,
"domNodes": -296,
"jsHeapTotalBytes": 196608,
"scriptDurationMs": 844.765,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.87160493827161,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3565.9689999999955,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.051,
"layouts": 65,
"layoutDurationMs": 11.350999999999999,
"taskDurationMs": 1634.144,
"heapDeltaBytes": -36239004,
"heapUsedBytes": 86663684,
"domNodes": -272,
"jsHeapTotalBytes": -647168,
"scriptDurationMs": 777.411,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74460093896714,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3932.91899999997,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.516,
"layouts": 63,
"layoutDurationMs": 10.351,
"taskDurationMs": 1851.5220000000002,
"heapDeltaBytes": 5228792,
"heapUsedBytes": 110236116,
"domNodes": -272,
"jsHeapTotalBytes": -1273856,
"scriptDurationMs": 799.504,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665677966101693,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2795.1830000000086,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.141999999999999,
"layouts": 4,
"layoutDurationMs": 0.98,
"taskDurationMs": 1807.927,
"heapDeltaBytes": 20045096,
"heapUsedBytes": 126899964,
"domNodes": 0,
"jsHeapTotalBytes": 6189056,
"scriptDurationMs": 968.7040000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.867878787878787,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3004.142999999999,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.551,
"layouts": 5,
"layoutDurationMs": 1.7369999999999999,
"taskDurationMs": 1825.2710000000004,
"heapDeltaBytes": 19993500,
"heapUsedBytes": 125915244,
"domNodes": 0,
"jsHeapTotalBytes": 8548352,
"scriptDurationMs": 972.559,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.852513966480444,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2025.244999999984,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.446,
"layouts": 7,
"layoutDurationMs": 2.231,
"taskDurationMs": 508.3269999999999,
"heapDeltaBytes": 2415896,
"heapUsedBytes": 105648408,
"domNodes": -296,
"jsHeapTotalBytes": -5861376,
"scriptDurationMs": 34.674,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.1800000001012,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5849999999999995,
"layouts": 7,
"layoutDurationMs": 2.3429999999999995,
"taskDurationMs": 728.434,
"heapDeltaBytes": -529980,
"heapUsedBytes": 102571488,
"domNodes": -296,
"jsHeapTotalBytes": -6123520,
"scriptDurationMs": 38.571,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 567.0979999999872,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.33,
"layouts": 9,
"layoutDurationMs": 2.466,
"taskDurationMs": 393.471,
"heapDeltaBytes": 2748872,
"heapUsedBytes": 108472424,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 145.206,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 550.9739999999965,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.3740000000000006,
"layouts": 9,
"layoutDurationMs": 2.5919999999999996,
"taskDurationMs": 398.45300000000003,
"heapDeltaBytes": 2719628,
"heapUsedBytes": 108954284,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 149.65,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636382,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2039.4110000000296,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.7230000000000003,
"layouts": 11,
"layoutDurationMs": 3.2520000000000007,
"taskDurationMs": 545.456,
"heapDeltaBytes": 4820772,
"heapUsedBytes": 106161852,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.23,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.234999999976,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6039999999999996,
"layouts": 8,
"layoutDurationMs": 2.442,
"taskDurationMs": 427.83700000000005,
"heapDeltaBytes": 5506180,
"heapUsedBytes": 95879424,
"domNodes": -219,
"jsHeapTotalBytes": -2191360,
"scriptDurationMs": 9.481,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1992.6779999999553,
"styleRecalcs": 87,
"styleRecalcDurationMs": 15.475000000000001,
"layouts": 10,
"layoutDurationMs": 3.012,
"taskDurationMs": 982.032,
"heapDeltaBytes": -15541484,
"heapUsedBytes": 90570540,
"domNodes": -210,
"jsHeapTotalBytes": 3575808,
"scriptDurationMs": 115.04899999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665000000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1994.350000000054,
"styleRecalcs": 87,
"styleRecalcDurationMs": 15.781,
"layouts": 9,
"layoutDurationMs": 2.803,
"taskDurationMs": 1001.348,
"heapDeltaBytes": -16125036,
"heapUsedBytes": 90108832,
"domNodes": -210,
"jsHeapTotalBytes": 3313664,
"scriptDurationMs": 117.95000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333333,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1436.8600000000242,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.533,
"layouts": 5,
"layoutDurationMs": 16.439,
"taskDurationMs": 1064.939,
"heapDeltaBytes": 4666764,
"heapUsedBytes": 122973128,
"domNodes": 16030,
"jsHeapTotalBytes": 18227200,
"scriptDurationMs": 29.237000000000005,
"eventListeners": 3244,
"totalBlockingTimeMs": 158,
"frameDurationMs": 19.331999999999994,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8387.985000000015,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.69,
"layouts": 8,
"layoutDurationMs": 2.007,
"taskDurationMs": 5270.303,
"heapDeltaBytes": 689240,
"heapUsedBytes": 103150596,
"domNodes": -296,
"jsHeapTotalBytes": -131072,
"scriptDurationMs": 2712.264,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7328,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 11055.454999999938,
"styleRecalcs": 250,
"styleRecalcDurationMs": 30.537,
"layouts": 7,
"layoutDurationMs": 2.024,
"taskDurationMs": 6369.205,
"heapDeltaBytes": -16977636,
"heapUsedBytes": 103237508,
"domNodes": -296,
"jsHeapTotalBytes": -847872,
"scriptDurationMs": 2845.8959999999997,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.71631419939577,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23048.535999999956,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22370.991,
"heapDeltaBytes": -37772120,
"heapUsedBytes": 273140980,
"domNodes": -3344,
"jsHeapTotalBytes": -1323008,
"scriptDurationMs": 325.579,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.877335640138405,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 23193.43200000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22639.303,
"heapDeltaBytes": -53156160,
"heapUsedBytes": 276679872,
"domNodes": -3344,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 319.15500000000003,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.56040955631399,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 19294.27899999996,
"styleRecalcs": 159,
"styleRecalcDurationMs": 16.111999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18923.345999999998,
"heapDeltaBytes": -29422888,
"heapUsedBytes": 300944044,
"domNodes": -3344,
"jsHeapTotalBytes": 23318528,
"scriptDurationMs": 842.576,
"eventListeners": -651,
"totalBlockingTimeMs": 16,
"frameDurationMs": 35.41155963302752,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 28070.515999999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 24.174,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27692.579999999998,
"heapDeltaBytes": -28438368,
"heapUsedBytes": 282971044,
"domNodes": -3344,
"jsHeapTotalBytes": 5754880,
"scriptDurationMs": 992.726,
"eventListeners": -651,
"totalBlockingTimeMs": 160,
"frameDurationMs": 51.65561694290977,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8220.168000000058,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.15900000000002,
"layouts": 20,
"layoutDurationMs": 29.089000000000016,
"taskDurationMs": 8069.9310000000005,
"heapDeltaBytes": -28019464,
"heapUsedBytes": 291529780,
"domNodes": -3344,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 129.468,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.646111111111104,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 8356.475000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.305,
"layouts": 20,
"layoutDurationMs": 24.390000000000008,
"taskDurationMs": 8213.636,
"heapDeltaBytes": -46584996,
"heapUsedBytes": 278220368,
"domNodes": -3344,
"jsHeapTotalBytes": 4444160,
"scriptDurationMs": 127.31700000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.969230769230755,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11402.503000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11006.438000000002,
"heapDeltaBytes": 8982808,
"heapUsedBytes": 299125568,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.67499999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.90648464163822,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11439.569000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11234.925000000001,
"heapDeltaBytes": 14781916,
"heapUsedBytes": 284962436,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 162.644,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.34570446735396,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 138.88199999996687,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.634,
"layouts": 9,
"layoutDurationMs": 4.002999999999999,
"taskDurationMs": 104.18900000000001,
"heapDeltaBytes": 4855608,
"heapUsedBytes": 96485696,
"domNodes": 120,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.136999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67777777777782,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 487.88200000001325,
"styleRecalcs": 18,
"styleRecalcDurationMs": 10.038000000000002,
"layouts": 8,
"layoutDurationMs": 3.4299999999999993,
"taskDurationMs": 129.671,
"heapDeltaBytes": 7036512,
"heapUsedBytes": 98732072,
"domNodes": 121,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 11.779,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 526.5880000000607,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7020000000000001,
"layouts": 76,
"layoutDurationMs": 17.214,
"taskDurationMs": 473.69100000000003,
"heapDeltaBytes": -14126960,
"heapUsedBytes": 79973096,
"domNodes": 4,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 225.411,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668750000000017,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 488.98399999995945,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.67,
"layouts": 76,
"layoutDurationMs": 15.594999999999999,
"taskDurationMs": 433.905,
"heapDeltaBytes": 12043120,
"heapUsedBytes": 81241468,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 204.454,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 575.8240000000114,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.402,
"layouts": 76,
"layoutDurationMs": 15.459,
"taskDurationMs": 543.044,
"heapDeltaBytes": 903644,
"heapUsedBytes": 121240296,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 216.28,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 619.9020000000246,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.331,
"layouts": 76,
"layoutDurationMs": 15.188,
"taskDurationMs": 571.144,
"heapDeltaBytes": 1268388,
"heapUsedBytes": 118365680,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 232.083,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567588,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge. Fix the failing shards and re-run coverage before using these totals for comparison. Line coverage: 63.9% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2950 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b168d1b61d1ac6a80a6ec2f5d246ffe1d57a05d9
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (111)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.58 #21444 +/- ##
=============================================
Coverage ? 87.04%
=============================================
Files ? 2732
Lines ? 151461
Branches ? 39174
=============================================
Hits ? 131839
Misses ? 19232
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
🔗 Commit SHA: 2556b8c | Docs | View more details | Give us feedback! |
Manual backport of #21264 to
cloud/1.58.The cherry-pick conflicted in
dynamicGroupWidget.test.tsbecause #21246 is not on this branch. The testrejects an unsupported saved row count stored as a numeric stringis left out: it depends on #21246 converting numeric strings, and without that change a numeric string is never read as a row count, so there is nothing for the guard to refuse.dynamicGroupWidget.test.tsanddynamicGroupDiagnostics.test.tspass (73 tests), andpnpm typecheckpasses.