Skip to content

[backport cloud/1.58] fix: refuse remote DynamicGroup row counts above max - #21444

Merged
jaeone94 merged 1 commit into
cloud/1.58from
backport-21264-to-cloud-1.58
Oct 21, 2026
Merged

jaeone94 merged 1 commit into
cloud/1.58from
backport-21264-to-cloud-1.58

Conversation

@jaeone94

Copy link
Copy Markdown
Collaborator

Manual backport of #21264 to cloud/1.58.

The cherry-pick conflicted in dynamicGroupWidget.test.ts because #21246 is not on this branch. The test rejects an unsupported saved row count stored as a numeric string is left out: it depends on #21246 converting numeric strings, and without that change a numeric string is never read as a row count, so there is nothing for the guard to refuse.

dynamicGroupWidget.test.ts and dynamicGroupDiagnostics.test.ts pass (73 tests), and pnpm typecheck passes.

A remote write to a DynamicGroup row count goes straight through the
controller setter, which normalizes to `Math.max(min, trunc(value))` and
never applies `max`. So `rows = 25` on a `max: 20` group quietly creates
25 rows, and a very large value can freeze the tab adding rows one at a
time.

The remote apply path now refuses a row count that would grow the group
past `max` before touching the setter. Nothing changes on the node, the
apply counts as a failure, and the existing remote mismatch report
fires. A group restored with more rows than `max` can still re-apply its
own count or shrink; only growth past `max(max, current rows, rows the
document carries values for)` is refused, so a rollback or undo can
bring back rows the doc still holds. The shared setter is left alone on
purpose: restoring a saved workflow must keep rows it already has beyond
`max`.

- Fixes #21095

| Commit | CI Status | Purpose |
|--------|-----------|---------|
| `test: cover remote DynamicGroup row counts above max` (c76a686) |
:red_circle:
[Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39096366190)
| Proves the test catches the bug |
| `fix: refuse remote DynamicGroup row counts above max` (a54e8b3) |
:green_circle:
[Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39098010935)
| Proves the fix resolves the bug |
| `test: cover a remote row count above max on a restored DynamicGroup`
(dcf95ae) | 🔴
[Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39100669923)
| A restored group already above `max` still counted the refused write
as a success |
| `fix: report a refused remote row count even when the group already
holds it` (7457a8c) | 🟢
[Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39101290723)
| Above-max requests are always reported as refused |
| `test: accept remote row counts that do not grow a restored
DynamicGroup` (b027386) | 🔴
[Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39107083689)
| Re-applying or shrinking a restored above-max group was reported as a
refusal |
| `fix: refuse only remote row counts that grow a DynamicGroup past max`
(15db48a) | 🟢
[Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39107937126)
| Only growth past `max(max, current rows)` is refused |
| `test: restore rows a remote rollback still documents above max`
(32c99ae) | 🔴
[Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39117022789)
| A rollback to rows the doc still holds was refused after a local
remove |
| `fix: count documented DynamicGroup rows toward the remote row
ceiling` (bc77798) | 🟢
[Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39117879853)
| The ceiling also counts rows the document carries values for |

- [x] CI red on test-only commit (only the two new above-max cases fail)
- [x] CI green on fix commit
- Unit coverage for a remote count at `max` (applies), `max + 1` and
`1e9` (refused, no row allocated, mismatch reported), a saved workflow
with rows above `max` (restored as is), and on such a restored group:
re-applying the same count or shrinking applies, growing further is
refused, and growing back to rows the doc still carries values for
applies. The large-value case spies on `addCustomWidget` so the red
commit fails fast instead of hanging.
- No E2E: the remote apply path is covered at the `LiveGraphApplier`
level with a followed Y.Doc, which is where the refusal lives.

(cherry picked from commit f66a36f)
@jaeone94
jaeone94 requested a review from a team as a code owner October 20, 2026 10:45
@jaeone94 jaeone94 added the backport Backporting a PR onto a release candidate label Oct 20, 2026
@jaeone94
jaeone94 requested review from a team as code owners October 20, 2026 10:45
@jaeone94 jaeone94 self-assigned this Oct 20, 2026
@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords: 2
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 8d0a44c9-6cd2-40dd-9f5a-04ba7b3efb1e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

❌ 7 scenarios below the ≥52 P5 FPS target. Expand the scenario timings below and profile the affected scenarios before merging.

Scenario timings

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 94.7 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 100.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 101.8 MB heap
dom-widget-order-dense-n200-w200-i120: · 29.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 546ms TBT · 108.2 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 40.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 220ms TBT · 92.2 MB heap
extension-clean-combined-draw: · 31.0 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1280ms TBT · 136.4 MB heap
extension-rgthree-prototype-draw: · 32.2 avg FPS · 20.0 P5 FPS ❌ (target: ≥52) · 843ms TBT · 124.7 MB heap
large-combo-open: · 37.2 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 3ms TBT · 112.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 96.0 MB heap
large-graph-pan: · 59.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 108.8 MB heap
large-graph-zoom: · 59.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 93.9 MB heap
legacy-node-drag: · 59.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 120.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.3 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 103.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 96.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.2 MB heap
subgraph-transition-enter: · 51.7 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 158ms TBT · 117.3 MB heap
viewport-pan-sweep: · 59.8 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 98.4 MB heap
vue-large-graph-idle: · 25.2 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 262.2 MB heap
vue-large-graph-pan: · 23.0 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 88ms TBT · 278.4 MB heap
vue-node-resize-workload: · 21.8 avg FPS · 10.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 271.7 MB heap
vue-zoom-out-idle: · 25.6 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 278.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 93.1 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.9 MB heap
agent-composer-long-conversation-typing: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 114.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 3ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 9
canvas-idle: style recalc count 10
canvas-idle: task duration 480ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 94.7 MB
canvas-idle: DOM nodes 0
canvas-idle: event listeners 0
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 14ms
canvas-mouse-sweep: layout count 10
canvas-mouse-sweep: style recalc count 81
canvas-mouse-sweep: task duration 992ms
canvas-mouse-sweep: script duration 170ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 83.7 MB
canvas-mouse-sweep: DOM nodes -190
canvas-mouse-sweep: event listeners -130
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 4ms
canvas-zoom-sweep: style recalc duration 6ms
canvas-zoom-sweep: layout count 12
canvas-zoom-sweep: style recalc count 20
canvas-zoom-sweep: task duration 397ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 100.7 MB
canvas-zoom-sweep: DOM nodes 47
canvas-zoom-sweep: event listeners 37
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 3ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 10
dom-widget-clipping: style recalc count 14
dom-widget-clipping: task duration 475ms
dom-widget-clipping: script duration 170ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 101.8 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 34ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 898ms
dom-widget-order-dense-n200-w200-i120: script duration 66ms
dom-widget-order-dense-n200-w200-i120: TBT 546ms
dom-widget-order-dense-n200-w200-i120: heap used 108.2 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes -211
dom-widget-order-dense-n200-w200-i120: event listeners -168
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 481ms
dom-widget-order-sparse-n1000-w20-i120: script duration 164ms
dom-widget-order-sparse-n1000-w20-i120: TBT 220ms
dom-widget-order-sparse-n1000-w20-i120: heap used 92.2 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 32ms
extension-clean-combined-draw: p95 frame time 67ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9851ms
extension-clean-combined-draw: script duration 8074ms
extension-clean-combined-draw: TBT 1280ms
extension-clean-combined-draw: heap used 136.4 MB
extension-clean-combined-draw: DOM nodes -276
extension-clean-combined-draw: event listeners -130
extension-rgthree-prototype-draw: avg frame time 31ms
extension-rgthree-prototype-draw: p95 frame time 50ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 1
extension-rgthree-prototype-draw: style recalc count 1
extension-rgthree-prototype-draw: task duration 9412ms
extension-rgthree-prototype-draw: script duration 7482ms
extension-rgthree-prototype-draw: TBT 843ms
extension-rgthree-prototype-draw: heap used 124.7 MB
extension-rgthree-prototype-draw: DOM nodes -286
extension-rgthree-prototype-draw: event listeners -130
large-combo-open: avg frame time 27ms
large-combo-open: p95 frame time 83ms
large-combo-open: layout duration 4ms
large-combo-open: style recalc duration 16ms
large-combo-open: layout count 11
large-combo-open: style recalc count 23
large-combo-open: task duration 176ms
large-combo-open: script duration 8ms
large-combo-open: TBT 3ms
large-combo-open: heap used 112.7 MB
large-combo-open: DOM nodes 917
large-combo-open: event listeners 196
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 2ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 7
large-graph-idle: style recalc count 7
large-graph-idle: task duration 591ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 96.0 MB
large-graph-idle: DOM nodes -286
large-graph-idle: event listeners -130
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 2ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 6
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1776ms
large-graph-pan: script duration 840ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 108.8 MB
large-graph-pan: DOM nodes -296
large-graph-pan: event listeners -128
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 11ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 64
large-graph-zoom: style recalc count 70
large-graph-zoom: task duration 1743ms
large-graph-zoom: script duration 788ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 93.9 MB
large-graph-zoom: DOM nodes -272
large-graph-zoom: event listeners -130
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 1ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 5
legacy-node-drag: style recalc count 44
legacy-node-drag: task duration 1817ms
legacy-node-drag: script duration 971ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 120.6 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 182
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 2ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 7
minimap-idle: style recalc count 8
minimap-idle: task duration 618ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 99.3 MB
minimap-idle: DOM nodes -296
minimap-idle: event listeners -130
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 3ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 9
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 396ms
subgraph-dom-widget-clipping: script duration 147ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 103.7 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 46
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 3ms
subgraph-idle: style recalc duration 3ms
subgraph-idle: layout count 10
subgraph-idle: style recalc count 10
subgraph-idle: task duration 487ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 96.3 MB
subgraph-idle: DOM nodes -110
subgraph-idle: event listeners -88
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 3ms
subgraph-mouse-sweep: style recalc duration 16ms
subgraph-mouse-sweep: layout count 10
subgraph-mouse-sweep: style recalc count 87
subgraph-mouse-sweep: task duration 992ms
subgraph-mouse-sweep: script duration 116ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 86.2 MB
subgraph-mouse-sweep: DOM nodes -210
subgraph-mouse-sweep: event listeners -174
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1065ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 158ms
subgraph-transition-enter: heap used 117.3 MB
subgraph-transition-enter: DOM nodes 16030
subgraph-transition-enter: event listeners 3244
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 2ms
viewport-pan-sweep: style recalc duration 30ms
viewport-pan-sweep: layout count 8
viewport-pan-sweep: style recalc count 250
viewport-pan-sweep: task duration 5820ms
viewport-pan-sweep: script duration 2779ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 98.4 MB
viewport-pan-sweep: DOM nodes -296
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 40ms
vue-large-graph-idle: p95 frame time 83ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 22505ms
vue-large-graph-idle: script duration 322ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 262.2 MB
vue-large-graph-idle: DOM nodes -3344
vue-large-graph-idle: event listeners -653
vue-large-graph-pan: avg frame time 44ms
vue-large-graph-pan: p95 frame time 83ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 170
vue-large-graph-pan: task duration 23308ms
vue-large-graph-pan: script duration 918ms
vue-large-graph-pan: TBT 88ms
vue-large-graph-pan: heap used 278.4 MB
vue-large-graph-pan: DOM nodes -3344
vue-large-graph-pan: event listeners -651
vue-node-resize-workload: avg frame time 46ms
vue-node-resize-workload: p95 frame time 92ms
vue-node-resize-workload: layout duration 27ms
vue-node-resize-workload: style recalc duration 76ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 8142ms
vue-node-resize-workload: script duration 128ms
vue-node-resize-workload: TBT 0ms
vue-node-resize-workload: heap used 271.7 MB
vue-node-resize-workload: DOM nodes -3344
vue-node-resize-workload: event listeners -653
vue-zoom-out-idle: avg frame time 39ms
vue-zoom-out-idle: p95 frame time 83ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 11121ms
vue-zoom-out-idle: script duration 160ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 278.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners 0
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 4ms
workflow-execution: style recalc duration 10ms
workflow-execution: layout count 9
workflow-execution: style recalc count 14
workflow-execution: task duration 117ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 93.1 MB
workflow-execution: DOM nodes 121
workflow-execution: event listeners 1
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 16ms
agent-composer-empty-conversation-typing: style recalc duration 1ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 5
agent-composer-empty-conversation-typing: task duration 454ms
agent-composer-empty-conversation-typing: script duration 215ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 76.9 MB
agent-composer-empty-conversation-typing: DOM nodes 4
agent-composer-empty-conversation-typing: event listeners 292
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 15ms
agent-composer-long-conversation-typing: style recalc duration 2ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 5
agent-composer-long-conversation-typing: task duration 557ms
agent-composer-long-conversation-typing: script duration 224ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 114.3 MB
agent-composer-long-conversation-typing: DOM nodes 4
agent-composer-long-conversation-typing: event listeners 294
Raw data
{
  "timestamp": "2026-10-20T10:59:20.469Z",
  "gitSha": "91e279c13bbfb757940790fd3314c34b767af040",
  "branch": "backport-21264-to-cloud-1.58",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2020.5729999999562,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.948,
      "layouts": 9,
      "layoutDurationMs": 2.8780000000000006,
      "taskDurationMs": 555.4639999999999,
      "heapDeltaBytes": 4187460,
      "heapUsedBytes": 103460740,
      "domNodes": 0,
      "jsHeapTotalBytes": 7340032,
      "scriptDurationMs": 10.807999999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2017.466000000013,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 3.32,
      "layouts": 9,
      "layoutDurationMs": 3.3049999999999997,
      "taskDurationMs": 403.583,
      "heapDeltaBytes": 3585096,
      "heapUsedBytes": 95088916,
      "domNodes": 0,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 9.693,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66557377049181,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1792.8769999999759,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 13.248,
      "layouts": 10,
      "layoutDurationMs": 2.8659999999999997,
      "taskDurationMs": 823.3009999999999,
      "heapDeltaBytes": -13630884,
      "heapUsedBytes": 90604636,
      "domNodes": -200,
      "jsHeapTotalBytes": 3575808,
      "scriptDurationMs": 171.892,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665740740740738,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2040.0960000000623,
      "styleRecalcs": 86,
      "styleRecalcDurationMs": 14.646999999999998,
      "layouts": 9,
      "layoutDurationMs": 3.0030000000000006,
      "taskDurationMs": 1160.014,
      "heapDeltaBytes": -18972152,
      "heapUsedBytes": 84911472,
      "domNodes": -180,
      "jsHeapTotalBytes": 2801664,
      "scriptDurationMs": 168.543,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1736.3639999999805,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 6.284,
      "layouts": 13,
      "layoutDurationMs": 4.146000000000001,
      "taskDurationMs": 350.092,
      "heapDeltaBytes": 1798052,
      "heapUsedBytes": 105519352,
      "domNodes": 47,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 14.944000000000003,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384614,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1771.5640000000121,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 5.6049999999999995,
      "layouts": 11,
      "layoutDurationMs": 3.167,
      "taskDurationMs": 443.373,
      "heapDeltaBytes": 1849664,
      "heapUsedBytes": 105628608,
      "domNodes": 47,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 14.218000000000002,
      "eventListeners": 37,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66509433962264,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 683.4119999999757,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 3.4669999999999996,
      "layouts": 10,
      "layoutDurationMs": 3.3629999999999995,
      "taskDurationMs": 492.77700000000004,
      "heapDeltaBytes": 4771976,
      "heapUsedBytes": 102829848,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 165.442,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66585365853659,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 619.5069999999987,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 2.9890000000000003,
      "layouts": 9,
      "layoutDurationMs": 2.7750000000000004,
      "taskDurationMs": 456.952,
      "heapDeltaBytes": 6510764,
      "heapUsedBytes": 110718328,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 174.35,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664864864864864,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1200.0899999999888,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 850.315,
      "heapDeltaBytes": 15335800,
      "heapUsedBytes": 124917488,
      "domNodes": -211,
      "jsHeapTotalBytes": 6361088,
      "scriptDurationMs": 64.65799999999999,
      "eventListeners": -168,
      "totalBlockingTimeMs": 539,
      "frameDurationMs": 34.80294117647057,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1238.6889999999084,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 946.345,
      "heapDeltaBytes": -11986824,
      "heapUsedBytes": 101936172,
      "domNodes": -210,
      "jsHeapTotalBytes": 13086720,
      "scriptDurationMs": 66.54099999999998,
      "eventListeners": -168,
      "totalBlockingTimeMs": 553,
      "frameDurationMs": 33.33243243243244,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 859.1979999999921,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 514.7420000000005,
      "heapDeltaBytes": -4178624,
      "heapUsedBytes": 97110780,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 165.99399999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 225,
      "frameDurationMs": 24.99999999999997,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 847.5510000000668,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.5610000000003,
      "heapDeltaBytes": -3973764,
      "heapUsedBytes": 96231512,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 162.96000000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 215,
      "frameDurationMs": 25,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9872.157000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9043.613,
      "heapDeltaBytes": 16084580,
      "heapUsedBytes": 137632736,
      "domNodes": -276,
      "jsHeapTotalBytes": 28479488,
      "scriptDurationMs": 7456.582,
      "eventListeners": -130,
      "totalBlockingTimeMs": 1074,
      "frameDurationMs": 32.778073089700996,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 11476.627000000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10658.667000000001,
      "heapDeltaBytes": 27069208,
      "heapUsedBytes": 148504916,
      "domNodes": -276,
      "jsHeapTotalBytes": 51548160,
      "scriptDurationMs": 8690.532999999998,
      "eventListeners": -130,
      "totalBlockingTimeMs": 1485,
      "frameDurationMs": 31.674861878453036,
      "p95FrameDurationMs": 66.60000000000036
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10600.820999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9771.350999999999,
      "heapDeltaBytes": 29262044,
      "heapUsedBytes": 141562568,
      "domNodes": -276,
      "jsHeapTotalBytes": 28020736,
      "scriptDurationMs": 7808.035999999999,
      "eventListeners": -130,
      "totalBlockingTimeMs": 872,
      "frameDurationMs": 31.546130952380953,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 9890.623000000005,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.06999999999999976,
      "layouts": 1,
      "layoutDurationMs": 0.30500000000000016,
      "taskDurationMs": 9051.818000000001,
      "heapDeltaBytes": 14314724,
      "heapUsedBytes": 119922716,
      "domNodes": -296,
      "jsHeapTotalBytes": 19107840,
      "scriptDurationMs": 7155.753,
      "eventListeners": -130,
      "totalBlockingTimeMs": 814,
      "frameDurationMs": 30.648916408668725,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-combo-open",
      "durationMs": 227.03599999999824,
      "styleRecalcs": 22,
      "styleRecalcDurationMs": 15.925999999999998,
      "layouts": 11,
      "layoutDurationMs": 3.4960000000000004,
      "taskDurationMs": 174.911,
      "heapDeltaBytes": 13259448,
      "heapUsedBytes": 118111884,
      "domNodes": 917,
      "jsHeapTotalBytes": 2097152,
      "scriptDurationMs": 8.479000000000001,
      "eventListeners": 196,
      "totalBlockingTimeMs": 1,
      "frameDurationMs": 27.77777777777778,
      "p95FrameDurationMs": 100
    },
    {
      "name": "large-combo-open",
      "durationMs": 222.73199999995086,
      "styleRecalcs": 23,
      "styleRecalcDurationMs": 15.583000000000002,
      "layouts": 11,
      "layoutDurationMs": 3.6079999999999997,
      "taskDurationMs": 176.735,
      "heapDeltaBytes": 13246044,
      "heapUsedBytes": 118192600,
      "domNodes": 917,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 8.386000000000001,
      "eventListeners": 196,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 25.922222222222242,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.5799999999676,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.1799999999999997,
      "layouts": 7,
      "layoutDurationMs": 1.9699999999999995,
      "taskDurationMs": 515.832,
      "heapDeltaBytes": -1589364,
      "heapUsedBytes": 101284328,
      "domNodes": -276,
      "jsHeapTotalBytes": -2387968,
      "scriptDurationMs": 34.433,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2033.0779999999322,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.0439999999999996,
      "layouts": 7,
      "layoutDurationMs": 2.037,
      "taskDurationMs": 666.705,
      "heapDeltaBytes": -3574420,
      "heapUsedBytes": 100092944,
      "domNodes": -296,
      "jsHeapTotalBytes": -2912256,
      "scriptDurationMs": 31.108000000000004,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2923.9150000000222,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 8.747000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.9830000000000003,
      "taskDurationMs": 1770.267,
      "heapDeltaBytes": 22711252,
      "heapUsedBytes": 128730496,
      "domNodes": -296,
      "jsHeapTotalBytes": 5177344,
      "scriptDurationMs": 834.936,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.858959537572257,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2743.5090000000173,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 9.032000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.622,
      "taskDurationMs": 1782.301,
      "heapDeltaBytes": -12980880,
      "heapUsedBytes": 99414308,
      "domNodes": -296,
      "jsHeapTotalBytes": 196608,
      "scriptDurationMs": 844.765,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.87160493827161,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3565.9689999999955,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 10.051,
      "layouts": 65,
      "layoutDurationMs": 11.350999999999999,
      "taskDurationMs": 1634.144,
      "heapDeltaBytes": -36239004,
      "heapUsedBytes": 86663684,
      "domNodes": -272,
      "jsHeapTotalBytes": -647168,
      "scriptDurationMs": 777.411,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.74460093896714,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3932.91899999997,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 9.516,
      "layouts": 63,
      "layoutDurationMs": 10.351,
      "taskDurationMs": 1851.5220000000002,
      "heapDeltaBytes": 5228792,
      "heapUsedBytes": 110236116,
      "domNodes": -272,
      "jsHeapTotalBytes": -1273856,
      "scriptDurationMs": 799.504,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665677966101693,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2795.1830000000086,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 5.141999999999999,
      "layouts": 4,
      "layoutDurationMs": 0.98,
      "taskDurationMs": 1807.927,
      "heapDeltaBytes": 20045096,
      "heapUsedBytes": 126899964,
      "domNodes": 0,
      "jsHeapTotalBytes": 6189056,
      "scriptDurationMs": 968.7040000000001,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.867878787878787,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3004.142999999999,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 5.551,
      "layouts": 5,
      "layoutDurationMs": 1.7369999999999999,
      "taskDurationMs": 1825.2710000000004,
      "heapDeltaBytes": 19993500,
      "heapUsedBytes": 125915244,
      "domNodes": 0,
      "jsHeapTotalBytes": 8548352,
      "scriptDurationMs": 972.559,
      "eventListeners": 182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.852513966480444,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2025.244999999984,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.446,
      "layouts": 7,
      "layoutDurationMs": 2.231,
      "taskDurationMs": 508.3269999999999,
      "heapDeltaBytes": 2415896,
      "heapUsedBytes": 105648408,
      "domNodes": -296,
      "jsHeapTotalBytes": -5861376,
      "scriptDurationMs": 34.674,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66557377049181,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2039.1800000001012,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 2.5849999999999995,
      "layouts": 7,
      "layoutDurationMs": 2.3429999999999995,
      "taskDurationMs": 728.434,
      "heapDeltaBytes": -529980,
      "heapUsedBytes": 102571488,
      "domNodes": -296,
      "jsHeapTotalBytes": -6123520,
      "scriptDurationMs": 38.571,
      "eventListeners": -130,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66557377049181,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 567.0979999999872,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.33,
      "layouts": 9,
      "layoutDurationMs": 2.466,
      "taskDurationMs": 393.471,
      "heapDeltaBytes": 2748872,
      "heapUsedBytes": 108472424,
      "domNodes": 0,
      "jsHeapTotalBytes": 8650752,
      "scriptDurationMs": 145.206,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664705882352937,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 550.9739999999965,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 5.3740000000000006,
      "layouts": 9,
      "layoutDurationMs": 2.5919999999999996,
      "taskDurationMs": 398.45300000000003,
      "heapDeltaBytes": 2719628,
      "heapUsedBytes": 108954284,
      "domNodes": 0,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 149.65,
      "eventListeners": 46,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663636363636382,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2039.4110000000296,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.7230000000000003,
      "layouts": 11,
      "layoutDurationMs": 3.2520000000000007,
      "taskDurationMs": 545.456,
      "heapDeltaBytes": 4820772,
      "heapUsedBytes": 106161852,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 9.23,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2024.234999999976,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 2.6039999999999996,
      "layouts": 8,
      "layoutDurationMs": 2.442,
      "taskDurationMs": 427.83700000000005,
      "heapDeltaBytes": 5506180,
      "heapUsedBytes": 95879424,
      "domNodes": -219,
      "jsHeapTotalBytes": -2191360,
      "scriptDurationMs": 9.481,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1992.6779999999553,
      "styleRecalcs": 87,
      "styleRecalcDurationMs": 15.475000000000001,
      "layouts": 10,
      "layoutDurationMs": 3.012,
      "taskDurationMs": 982.032,
      "heapDeltaBytes": -15541484,
      "heapUsedBytes": 90570540,
      "domNodes": -210,
      "jsHeapTotalBytes": 3575808,
      "scriptDurationMs": 115.04899999999999,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665000000000003,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1994.350000000054,
      "styleRecalcs": 87,
      "styleRecalcDurationMs": 15.781,
      "layouts": 9,
      "layoutDurationMs": 2.803,
      "taskDurationMs": 1001.348,
      "heapDeltaBytes": -16125036,
      "heapUsedBytes": 90108832,
      "domNodes": -210,
      "jsHeapTotalBytes": 3313664,
      "scriptDurationMs": 117.95000000000002,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66583333333333,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1436.8600000000242,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 25.533,
      "layouts": 5,
      "layoutDurationMs": 16.439,
      "taskDurationMs": 1064.939,
      "heapDeltaBytes": 4666764,
      "heapUsedBytes": 122973128,
      "domNodes": 16030,
      "jsHeapTotalBytes": 18227200,
      "scriptDurationMs": 29.237000000000005,
      "eventListeners": 3244,
      "totalBlockingTimeMs": 158,
      "frameDurationMs": 19.331999999999994,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8387.985000000015,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 28.69,
      "layouts": 8,
      "layoutDurationMs": 2.007,
      "taskDurationMs": 5270.303,
      "heapDeltaBytes": 689240,
      "heapUsedBytes": 103150596,
      "domNodes": -296,
      "jsHeapTotalBytes": -131072,
      "scriptDurationMs": 2712.264,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.7328,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 11055.454999999938,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 30.537,
      "layouts": 7,
      "layoutDurationMs": 2.024,
      "taskDurationMs": 6369.205,
      "heapDeltaBytes": -16977636,
      "heapUsedBytes": 103237508,
      "domNodes": -296,
      "jsHeapTotalBytes": -847872,
      "scriptDurationMs": 2845.8959999999997,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.71631419939577,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 23048.535999999956,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22370.991,
      "heapDeltaBytes": -37772120,
      "heapUsedBytes": 273140980,
      "domNodes": -3344,
      "jsHeapTotalBytes": -1323008,
      "scriptDurationMs": 325.579,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 39.877335640138405,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 23193.43200000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22639.303,
      "heapDeltaBytes": -53156160,
      "heapUsedBytes": 276679872,
      "domNodes": -3344,
      "jsHeapTotalBytes": 9949184,
      "scriptDurationMs": 319.15500000000003,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 39.56040955631399,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19294.27899999996,
      "styleRecalcs": 159,
      "styleRecalcDurationMs": 16.111999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18923.345999999998,
      "heapDeltaBytes": -29422888,
      "heapUsedBytes": 300944044,
      "domNodes": -3344,
      "jsHeapTotalBytes": 23318528,
      "scriptDurationMs": 842.576,
      "eventListeners": -651,
      "totalBlockingTimeMs": 16,
      "frameDurationMs": 35.41155963302752,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 28070.515999999996,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 24.174,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 27692.579999999998,
      "heapDeltaBytes": -28438368,
      "heapUsedBytes": 282971044,
      "domNodes": -3344,
      "jsHeapTotalBytes": 5754880,
      "scriptDurationMs": 992.726,
      "eventListeners": -651,
      "totalBlockingTimeMs": 160,
      "frameDurationMs": 51.65561694290977,
      "p95FrameDurationMs": 100.10000000000218
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8220.168000000058,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 87.15900000000002,
      "layouts": 20,
      "layoutDurationMs": 29.089000000000016,
      "taskDurationMs": 8069.9310000000005,
      "heapDeltaBytes": -28019464,
      "heapUsedBytes": 291529780,
      "domNodes": -3344,
      "jsHeapTotalBytes": 14143488,
      "scriptDurationMs": 129.468,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 45.646111111111104,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 8356.475000000046,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 65.305,
      "layouts": 20,
      "layoutDurationMs": 24.390000000000008,
      "taskDurationMs": 8213.636,
      "heapDeltaBytes": -46584996,
      "heapUsedBytes": 278220368,
      "domNodes": -3344,
      "jsHeapTotalBytes": 4444160,
      "scriptDurationMs": 127.31700000000001,
      "eventListeners": -653,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 45.969230769230755,
      "p95FrameDurationMs": 100
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11402.503000000024,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11006.438000000002,
      "heapDeltaBytes": 8982808,
      "heapUsedBytes": 299125568,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 157.67499999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 38.90648464163822,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 11439.569000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11234.925000000001,
      "heapDeltaBytes": 14781916,
      "heapUsedBytes": 284962436,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 162.644,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 39.34570446735396,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "workflow-execution",
      "durationMs": 138.88199999996687,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.634,
      "layouts": 9,
      "layoutDurationMs": 4.002999999999999,
      "taskDurationMs": 104.18900000000001,
      "heapDeltaBytes": 4855608,
      "heapUsedBytes": 96485696,
      "domNodes": 120,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 9.136999999999999,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.67777777777782,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 487.88200000001325,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 10.038000000000002,
      "layouts": 8,
      "layoutDurationMs": 3.4299999999999993,
      "taskDurationMs": 129.671,
      "heapDeltaBytes": 7036512,
      "heapUsedBytes": 98732072,
      "domNodes": 121,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 11.779,
      "eventListeners": 1,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665517241379316,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 526.5880000000607,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.7020000000000001,
      "layouts": 76,
      "layoutDurationMs": 17.214,
      "taskDurationMs": 473.69100000000003,
      "heapDeltaBytes": -14126960,
      "heapUsedBytes": 79973096,
      "domNodes": 4,
      "jsHeapTotalBytes": 2097152,
      "scriptDurationMs": 225.411,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668750000000017,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 488.98399999995945,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 0.67,
      "layouts": 76,
      "layoutDurationMs": 15.594999999999999,
      "taskDurationMs": 433.905,
      "heapDeltaBytes": 12043120,
      "heapUsedBytes": 81241468,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 204.454,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665517241379316,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 575.8240000000114,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.402,
      "layouts": 76,
      "layoutDurationMs": 15.459,
      "taskDurationMs": 543.044,
      "heapDeltaBytes": 903644,
      "heapUsedBytes": 121240296,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 216.28,
      "eventListeners": 292,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 619.9020000000246,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 2.331,
      "layouts": 76,
      "layoutDurationMs": 15.188,
      "taskDurationMs": 571.144,
      "heapDeltaBytes": 1268388,
      "heapUsedBytes": 118365680,
      "domNodes": 4,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 232.083,
      "eventListeners": 296,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667567567567588,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge. Fix the failing shards and re-run coverage before using these totals for comparison.

Line coverage: 63.9%

Coverage totals
Metric Covered Total Pct
Lines 56854 88935 63.9% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.5% 1166
src/LGraphNode.ts 70.6% 388
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.2% 313
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 78.9% 274
src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue 1.1% 266
src/workbench/extensions/agent/crdt/docOpMinter.ts 0.0% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 46.6% 252
src/core/webSessionIdentity.ts 3.3% 231

🎭 Playwright: ✅ 2950 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2275 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • cloud: View Report (✅ 646 / ❌ 0 / ⚠️ 3 / ⏭️ 0)
  • desktop: View Report (✅ 4 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 19 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-safari: View Report (✅ 3 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/20/2026, 10:47:37 AM UTC

Links

🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measure

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

No verdict is available. Open the workflow run to confirm the check was intentionally skipped, or fix the collection failure and re-run it.

Findings and check details

The matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Findings and check details

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since b168d1b61d1ac6a80a6ec2f5d246ffe1d57a05d9

Full docs: ADR-DEVEX-LINT-0015

🏛️ Architecture: ✅ Passed

Findings and check details

Warnings (111)

  • src/components/graph/selectionToolbox/LinkSelectionActions.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/searchbox/v2/filterChip.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/Card.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardFooter.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardHeader.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/CardTitle.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/ui/card/card.variants.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/components/widgetHistory/WidgetHistoryButtons.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/billing/useSubscriptionPaywall.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/graph/menuOption.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/useWidgetValueHistory.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/composables/widgetHistoryScope.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/litegraphServiceAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/nodeDef/ComfyNodeDefImpl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/graph/widgets/dynamicGroupDiagnostics.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/core/selection/selectionIntent.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/cameraInfo.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/extensions/core/load3d/load3dInstances.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/i18n.literalMessages.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/canvasClassAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/lib/litegraph/src/canvas/linkSelection.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/authStoreAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/currentUserAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionCookieAccess.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/sessionRevokedError.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/session/webSessionFetch.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/auth/sso/ssoRequiredContext.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/missingModel/releaseModelOptions.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/billingActionNames.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/telemetry/extensionLoadTelemetry.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/__fixtures__/deploymentListing.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/api/deploymentListingTimeouts.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingRefresh.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/billingTab.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/billing/topupCheckoutReturnUrl.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.stories.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.test.ts is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • src/platform/workspace/components/DeploymentSwitcher.vue is not claimed by any domain. Add it to a module in docs/architecture/domains/records.
  • …and 61 more
Reproduce locally
pnpm architecture:check

Full docs: Frontend domain catalog

@github-actions
github-actions Bot requested a review from thedatalife October 20, 2026 10:46
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.58   #21444   +/-   ##
=============================================
  Coverage              ?   87.04%           
=============================================
  Files                 ?     2732           
  Lines                 ?   151461           
  Branches              ?    39174           
=============================================
  Hits                  ?   131839           
  Misses                ?    19232           
  Partials              ?      390           
Flag Coverage Δ
e2e 64.04% <ø> (?)
unit 85.72% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...orkbench/extensions/agent/crdt/liveGraphApplier.ts 96.14% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

datadog-official Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2556b8c | Docs | View more details | Give us feedback!

@jaeone94
jaeone94 enabled auto-merge (squash) October 21, 2026 03:23
@jaeone94
jaeone94 merged commit e749314 into cloud/1.58 Oct 21, 2026
191 of 193 checks passed
@jaeone94
jaeone94 deleted the backport-21264-to-cloud-1.58 branch October 21, 2026 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants