Repository navigation
[backport core/1.58] fix: refuse remote DynamicGroup row counts above max - #21443
Conversation
A remote write to a DynamicGroup row count goes straight through the controller setter, which normalizes to `Math.max(min, trunc(value))` and never applies `max`. So `rows = 25` on a `max: 20` group quietly creates 25 rows, and a very large value can freeze the tab adding rows one at a time. The remote apply path now refuses a row count that would grow the group past `max` before touching the setter. Nothing changes on the node, the apply counts as a failure, and the existing remote mismatch report fires. A group restored with more rows than `max` can still re-apply its own count or shrink; only growth past `max(max, current rows, rows the document carries values for)` is refused, so a rollback or undo can bring back rows the doc still holds. The shared setter is left alone on purpose: restoring a saved workflow must keep rows it already has beyond `max`. - Fixes #21095 | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: cover remote DynamicGroup row counts above max` (c76a686) | :red_circle: [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39096366190) | Proves the test catches the bug | | `fix: refuse remote DynamicGroup row counts above max` (a54e8b3) | :green_circle: [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39098010935) | Proves the fix resolves the bug | | `test: cover a remote row count above max on a restored DynamicGroup` (dcf95ae) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39100669923) | A restored group already above `max` still counted the refused write as a success | | `fix: report a refused remote row count even when the group already holds it` (7457a8c) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39101290723) | Above-max requests are always reported as refused | | `test: accept remote row counts that do not grow a restored DynamicGroup` (b027386) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39107083689) | Re-applying or shrinking a restored above-max group was reported as a refusal | | `fix: refuse only remote row counts that grow a DynamicGroup past max` (15db48a) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39107937126) | Only growth past `max(max, current rows)` is refused | | `test: restore rows a remote rollback still documents above max` (32c99ae) | 🔴 [Red](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39117022789) | A rollback to rows the doc still holds was refused after a local remove | | `fix: count documented DynamicGroup rows toward the remote row ceiling` (bc77798) | 🟢 [Green](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39117879853) | The ceiling also counts rows the document carries values for | - [x] CI red on test-only commit (only the two new above-max cases fail) - [x] CI green on fix commit - Unit coverage for a remote count at `max` (applies), `max + 1` and `1e9` (refused, no row allocated, mismatch reported), a saved workflow with rows above `max` (restored as is), and on such a restored group: re-applying the same count or shrinking applies, growing further is refused, and growing back to rows the doc still carries values for applies. The large-value case spies on `addCustomWidget` so the red commit fails fast instead of hanging. - No E2E: the remote apply path is covered at the `LiveGraphApplier` level with a followed Y.Doc, which is where the refusal lives. (cherry picked from commit f66a36f)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords: 2
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-20T10:58:40.044Z",
"gitSha": "2740d7aababbef60ce3a9b8afab73721a5d523c5",
"branch": "backport-21264-to-core-1.58",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2073.970999999972,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.526,
"layouts": 10,
"layoutDurationMs": 3.2460000000000004,
"taskDurationMs": 693.808,
"heapDeltaBytes": -17589540,
"heapUsedBytes": 86603244,
"domNodes": -200,
"jsHeapTotalBytes": 2990080,
"scriptDurationMs": 13.262999999999996,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2072.9259999999385,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8130000000000006,
"layouts": 9,
"layoutDurationMs": 2.671,
"taskDurationMs": 601.891,
"heapDeltaBytes": -11475164,
"heapUsedBytes": 92343580,
"domNodes": -180,
"jsHeapTotalBytes": 1941504,
"scriptDurationMs": 9.868000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1872.916000000032,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.345,
"layouts": 10,
"layoutDurationMs": 2.878,
"taskDurationMs": 952.592,
"heapDeltaBytes": -2834080,
"heapUsedBytes": 95546648,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 172.86599999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1792.1890000000076,
"styleRecalcs": 77,
"styleRecalcDurationMs": 13.424999999999999,
"layouts": 9,
"layoutDurationMs": 2.8169999999999997,
"taskDurationMs": 812.8810000000001,
"heapDeltaBytes": -8567348,
"heapUsedBytes": 95281928,
"domNodes": -180,
"jsHeapTotalBytes": 2990080,
"scriptDurationMs": 170.29699999999997,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.05999999997,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.176000000000001,
"layouts": 11,
"layoutDurationMs": 3.154,
"taskDurationMs": 347.58299999999997,
"heapDeltaBytes": 1861104,
"heapUsedBytes": 105956524,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 13.629000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.6470000000045,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.285999999999999,
"layouts": 11,
"layoutDurationMs": 2.836,
"taskDurationMs": 418.331,
"heapDeltaBytes": 1834464,
"heapUsedBytes": 105595320,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.129,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 762.06499999995,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.1209999999999996,
"layouts": 9,
"layoutDurationMs": 2.5119999999999996,
"taskDurationMs": 512.4720000000001,
"heapDeltaBytes": 6921544,
"heapUsedBytes": 110640940,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 168.937,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444456,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 618.671000000063,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.3019999999999996,
"layouts": 10,
"layoutDurationMs": 3.202,
"taskDurationMs": 467.456,
"heapDeltaBytes": 6892156,
"heapUsedBytes": 111124588,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 177.808,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864864,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1245.0469999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 927.7350000000001,
"heapDeltaBytes": -8002296,
"heapUsedBytes": 102225184,
"domNodes": -210,
"jsHeapTotalBytes": 8765440,
"scriptDurationMs": 71.519,
"eventListeners": -168,
"totalBlockingTimeMs": 566,
"frameDurationMs": 33.78378378378378,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1260.9340000000202,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 998.1929999999999,
"heapDeltaBytes": -8243612,
"heapUsedBytes": 102415280,
"domNodes": -230,
"jsHeapTotalBytes": 9027584,
"scriptDurationMs": 73.746,
"eventListeners": -168,
"totalBlockingTimeMs": 553,
"frameDurationMs": 32.89210526315789,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.0439999999539,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.32799999999975,
"heapDeltaBytes": -3684660,
"heapUsedBytes": 96525888,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.85099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 24.997058823529454,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.5070000000642,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.008,
"heapDeltaBytes": -4587904,
"heapUsedBytes": 96399392,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.40400000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11605.441999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10756.686,
"heapDeltaBytes": 39084324,
"heapUsedBytes": 152904172,
"domNodes": -282,
"jsHeapTotalBytes": 40771584,
"scriptDurationMs": 8615.57,
"eventListeners": -130,
"totalBlockingTimeMs": 1381,
"frameDurationMs": 32.131578947368425,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10498.373000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9713.466,
"heapDeltaBytes": 29517500,
"heapUsedBytes": 143068644,
"domNodes": -276,
"jsHeapTotalBytes": 30285824,
"scriptDurationMs": 7766.978,
"eventListeners": -130,
"totalBlockingTimeMs": 912,
"frameDurationMs": 31.248809523809523,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10340.07600000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9551.565999999999,
"heapDeltaBytes": 25201384,
"heapUsedBytes": 131103916,
"domNodes": -276,
"jsHeapTotalBytes": 30023680,
"scriptDurationMs": 7868.750999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 1094,
"frameDurationMs": 31.990712074303406,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10571.265999999923,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9750.743999999999,
"heapDeltaBytes": -1035676,
"heapUsedBytes": 120157964,
"domNodes": -276,
"jsHeapTotalBytes": -155648,
"scriptDurationMs": 7858.03,
"eventListeners": -130,
"totalBlockingTimeMs": 934,
"frameDurationMs": 31.260946745562126,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 273.74800000001187,
"styleRecalcs": 27,
"styleRecalcDurationMs": 17.09,
"layouts": 12,
"layoutDurationMs": 3.6629999999999994,
"taskDurationMs": 227.12800000000001,
"heapDeltaBytes": 13243884,
"heapUsedBytes": 117712936,
"domNodes": 917,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 9.792000000000002,
"eventListeners": 196,
"totalBlockingTimeMs": 3,
"frameDurationMs": 20.507692307692334,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 223.8720000000285,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.305,
"layouts": 11,
"layoutDurationMs": 3.2159999999999997,
"taskDurationMs": 174.12099999999998,
"heapDeltaBytes": 13203520,
"heapUsedBytes": 120186500,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.717,
"eventListeners": 196,
"totalBlockingTimeMs": 5,
"frameDurationMs": 25.922222222222242,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2056.892000000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5629999999999993,
"layouts": 8,
"layoutDurationMs": 2.34,
"taskDurationMs": 728.5920000000001,
"heapDeltaBytes": -15449688,
"heapUsedBytes": 95546872,
"domNodes": -276,
"jsHeapTotalBytes": -2220032,
"scriptDurationMs": 37.266000000000005,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.5590000000302,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.548,
"layouts": 8,
"layoutDurationMs": 2.346,
"taskDurationMs": 494.6989999999999,
"heapDeltaBytes": 1090328,
"heapUsedBytes": 103326144,
"domNodes": -296,
"jsHeapTotalBytes": -4349952,
"scriptDurationMs": 32.181,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2264.754000000039,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.657,
"layouts": 6,
"layoutDurationMs": 1.7249999999999999,
"taskDurationMs": 1605.42,
"heapDeltaBytes": 1449264,
"heapUsedBytes": 104766036,
"domNodes": -296,
"jsHeapTotalBytes": -192512,
"scriptDurationMs": 868.618,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.789629629629626,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2322.016000000076,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.015,
"layouts": 6,
"layoutDurationMs": 1.8369999999999997,
"taskDurationMs": 1597.7540000000001,
"heapDeltaBytes": 4667120,
"heapUsedBytes": 107722560,
"domNodes": -276,
"jsHeapTotalBytes": -4648960,
"scriptDurationMs": 825.614,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.91176470588235,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3847.285999999997,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.831,
"layouts": 64,
"layoutDurationMs": 10.546,
"taskDurationMs": 1837.6009999999999,
"heapDeltaBytes": 7950656,
"heapUsedBytes": 121770972,
"domNodes": 24,
"jsHeapTotalBytes": 5246976,
"scriptDurationMs": 800.859,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.738695652173913,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3573.0859999999893,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.157,
"layouts": 63,
"layoutDurationMs": 9.907,
"taskDurationMs": 1673.04,
"heapDeltaBytes": -14845220,
"heapUsedBytes": 90408956,
"domNodes": -272,
"jsHeapTotalBytes": -811008,
"scriptDurationMs": 805.932,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.74460093896714,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3171.5489999999704,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.271000000000001,
"layouts": 5,
"layoutDurationMs": 1.2440000000000002,
"taskDurationMs": 1904.3769999999997,
"heapDeltaBytes": -17086904,
"heapUsedBytes": 98802456,
"domNodes": 0,
"jsHeapTotalBytes": 2068480,
"scriptDurationMs": 1056.4550000000002,
"eventListeners": 182,
"totalBlockingTimeMs": 47,
"frameDurationMs": 17.111764705882354,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2920.410000000061,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.083000000000001,
"layouts": 4,
"layoutDurationMs": 1.4150000000000005,
"taskDurationMs": 1837.45,
"heapDeltaBytes": -10011620,
"heapUsedBytes": 105775244,
"domNodes": 0,
"jsHeapTotalBytes": 6557696,
"scriptDurationMs": 976.1629999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.858045977011496,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.7249999999617,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9649999999999996,
"layouts": 6,
"layoutDurationMs": 2.1449999999999996,
"taskDurationMs": 500.0349999999999,
"heapDeltaBytes": 3693576,
"heapUsedBytes": 106743192,
"domNodes": -296,
"jsHeapTotalBytes": -6184960,
"scriptDurationMs": 33.471999999999994,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2050.1970000000256,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.326,
"layouts": 7,
"layoutDurationMs": 2.278,
"taskDurationMs": 505.938,
"heapDeltaBytes": -26130804,
"heapUsedBytes": 97185576,
"domNodes": -296,
"jsHeapTotalBytes": -2445312,
"scriptDurationMs": 34.961000000000006,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 699.0669999999568,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.150999999999999,
"layouts": 8,
"layoutDurationMs": 2.584,
"taskDurationMs": 488.051,
"heapDeltaBytes": -46396,
"heapUsedBytes": 100351832,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 146.741,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 681.0090000000173,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.321999999999999,
"layouts": 9,
"layoutDurationMs": 2.712,
"taskDurationMs": 481.472,
"heapDeltaBytes": 22523804,
"heapUsedBytes": 112455276,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 154.194,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.4179999999924,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0610000000000004,
"layouts": 10,
"layoutDurationMs": 3.3759999999999994,
"taskDurationMs": 562.008,
"heapDeltaBytes": 3512656,
"heapUsedBytes": 96264604,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 8.571,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2073.6630000000105,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.064,
"layouts": 9,
"layoutDurationMs": 2.7509999999999994,
"taskDurationMs": 621.369,
"heapDeltaBytes": -11556664,
"heapUsedBytes": 96950664,
"domNodes": -198,
"jsHeapTotalBytes": 5644288,
"scriptDurationMs": 8.632,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666935483870965,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1841.8600000000538,
"styleRecalcs": 58,
"styleRecalcDurationMs": 14.030000000000001,
"layouts": 9,
"layoutDurationMs": 2.8939999999999997,
"taskDurationMs": 1039.8780000000002,
"heapDeltaBytes": -20151964,
"heapUsedBytes": 85578628,
"domNodes": -190,
"jsHeapTotalBytes": 2506752,
"scriptDurationMs": 120.876,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665454545454544,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2017.202999999995,
"styleRecalcs": 87,
"styleRecalcDurationMs": 15.339000000000002,
"layouts": 9,
"layoutDurationMs": 2.7289999999999996,
"taskDurationMs": 1148.248,
"heapDeltaBytes": -15228268,
"heapUsedBytes": 90623652,
"domNodes": -190,
"jsHeapTotalBytes": 3514368,
"scriptDurationMs": 120.145,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1484.9919999999202,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.087999999999994,
"layouts": 5,
"layoutDurationMs": 17.043000000000003,
"taskDurationMs": 1087.9750000000001,
"heapDeltaBytes": 7058136,
"heapUsedBytes": 124930880,
"domNodes": 16030,
"jsHeapTotalBytes": 17440768,
"scriptDurationMs": 33.293000000000006,
"eventListeners": 3244,
"totalBlockingTimeMs": 176,
"frameDurationMs": 20,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8339.624999999956,
"styleRecalcs": 250,
"styleRecalcDurationMs": 29.325999999999997,
"layouts": 8,
"layoutDurationMs": 2.3459999999999996,
"taskDurationMs": 5389.241,
"heapDeltaBytes": 960260,
"heapUsedBytes": 103335920,
"domNodes": -296,
"jsHeapTotalBytes": -978944,
"scriptDurationMs": 2730.791,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73293172690763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8308.320999999978,
"styleRecalcs": 249,
"styleRecalcDurationMs": 28.724,
"layouts": 7,
"layoutDurationMs": 1.7759999999999998,
"taskDurationMs": 5431.910999999999,
"heapDeltaBytes": 5662792,
"heapUsedBytes": 108766744,
"domNodes": -276,
"jsHeapTotalBytes": -1732608,
"scriptDurationMs": 2743.803,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73326612903226,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23077.657999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22271.165,
"heapDeltaBytes": -20112652,
"heapUsedBytes": 284877340,
"domNodes": -3344,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 311.71900000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.83730569948187,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 22867.231999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22198.476,
"heapDeltaBytes": -14027044,
"heapUsedBytes": 295966084,
"domNodes": -3344,
"jsHeapTotalBytes": 9687040,
"scriptDurationMs": 311.348,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.086837606837605,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 19206.365000000005,
"styleRecalcs": 156,
"styleRecalcDurationMs": 16.194999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18751.715,
"heapDeltaBytes": -15144940,
"heapUsedBytes": 305040468,
"domNodes": -3344,
"jsHeapTotalBytes": 20434944,
"scriptDurationMs": 832.8109999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 15,
"frameDurationMs": 35.22435897435897,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 28249.557000000095,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.922999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27843.478,
"heapDeltaBytes": -25848016,
"heapUsedBytes": 293850960,
"domNodes": -3344,
"jsHeapTotalBytes": 12046336,
"scriptDurationMs": 935.0350000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 78,
"frameDurationMs": 52.60484171322161,
"p95FrameDurationMs": 116.69999999999709
},
{
"name": "vue-node-resize-workload",
"durationMs": 6091.116,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.09399999999997,
"layouts": 20,
"layoutDurationMs": 31.640999999999988,
"taskDurationMs": 5977.279,
"heapDeltaBytes": -35324456,
"heapUsedBytes": 284285304,
"domNodes": -3344,
"jsHeapTotalBytes": 4968448,
"scriptDurationMs": 105.607,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.056321839080454,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5937.4259999999595,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.660999999999994,
"layouts": 20,
"layoutDurationMs": 22.941000000000003,
"taskDurationMs": 5768.717000000001,
"heapDeltaBytes": -40988960,
"heapUsedBytes": 289601124,
"domNodes": -3344,
"jsHeapTotalBytes": 13357056,
"scriptDurationMs": 94.88,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.49476744186047,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8120.2999999999865,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7522.089000000001,
"heapDeltaBytes": 92020,
"heapUsedBytes": 276889056,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.57000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.141868512110726,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11401.920999999902,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11123.605,
"heapDeltaBytes": 3389172,
"heapUsedBytes": 272748136,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.8369999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.19788732394367,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "workflow-execution",
"durationMs": 507.70699999998214,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.190999999999999,
"layouts": 11,
"layoutDurationMs": 4.788,
"taskDurationMs": 156.27599999999998,
"heapDeltaBytes": -12663720,
"heapUsedBytes": 91538304,
"domNodes": 124,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 16.558999999999997,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 138.12499999994543,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.556000000000001,
"layouts": 9,
"layoutDurationMs": 4.481,
"taskDurationMs": 92.37299999999999,
"heapDeltaBytes": 4687936,
"heapUsedBytes": 101138208,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.269000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.04285714285717,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 448.17199999999957,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.671,
"layouts": 76,
"layoutDurationMs": 16.587,
"taskDurationMs": 398.97200000000004,
"heapDeltaBytes": -14967604,
"heapUsedBytes": 80774840,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 185.60800000000003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 464.9499999999307,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.741,
"layouts": 76,
"layoutDurationMs": 16.206000000000003,
"taskDurationMs": 418.74500000000006,
"heapDeltaBytes": 11761516,
"heapUsedBytes": 80814840,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 194.486,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285717,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 598.7660000000687,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.881,
"layouts": 76,
"layoutDurationMs": 15.546000000000001,
"taskDurationMs": 562.425,
"heapDeltaBytes": 1139040,
"heapUsedBytes": 118062132,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 231.608,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.127777777777787,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 584.5980000000282,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.02,
"layouts": 76,
"layoutDurationMs": 15.594999999999999,
"taskDurationMs": 545.2549999999999,
"heapDeltaBytes": 1171048,
"heapUsedBytes": 115956020,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 224.424,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2950 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 743f52d80caee2df07d2f6ef246dd95581f459b3
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (111)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.58 #21443 +/- ##
============================================
Coverage 87.04% 87.04%
============================================
Files 2732 2732
Lines 151449 151461 +12
Branches 41288 39163 -2125
============================================
+ Hits 131824 131842 +18
+ Misses 19235 19229 -6
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Manual backport of #21264 to
core/1.58.The cherry-pick conflicted in
dynamicGroupWidget.test.tsbecause #21246 is not on this branch. The testrejects an unsupported saved row count stored as a numeric stringis left out: it depends on #21246 converting numeric strings, and without that change a numeric string is never read as a row count, so there is nothing for the guard to refuse.dynamicGroupWidget.test.tsanddynamicGroupDiagnostics.test.tspass (73 tests), andpnpm typecheckpasses.