Repository navigation
refactor: restore saved widget values through widgetValueStore - #21378
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
📦 Bundle: 11.8 MB gzip 🔴 +194 BDetailsSummary
Category Glance App Entry Points — 7.04 kB (baseline 7.04 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.59 MB (baseline 3.59 MB) • 🟢 -510 BGraph editor runtime, canvas, workflow orchestration
Status: 3 added / 3 removed / 1 unchanged Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 6 unchanged Panels & Settings — 870 kB (baseline 871 kB) • 🟢 -490 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 21 unchanged User & Accounts — 149 kB (baseline 149 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 9 unchanged Editors & Dialogs — 271 kB (baseline 271 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 10 added / 10 removed / 5 unchanged UI Components — 333 kB (baseline 330 kB) • 🔴 +3.21 kBReusable component library chunks
Status: 10 added / 10 removed / 20 unchanged Data & Services — 1.88 MB (baseline 1.88 MB) • 🟢 -774 BStores, services, APIs, and repositories
Status: 32 added / 32 removed / 9 unchanged Utilities & Hooks — 1.23 MB (baseline 1.23 MB) • 🟢 -26 BHelpers, composables, and utility bundles
Status: 34 added / 34 removed / 40 unchanged Vendor & Third-Party — 10.2 MB (baseline 10.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.1 MB (baseline 34.1 MB) • 🟢 -1.87 kBBundles that do not match a named category
Status: 107 added / 107 removed / 643 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T00:41:50.299Z",
"gitSha": "977df2d731b86baee3737b17b26fa9143f92f7e8",
"branch": "drjkl/consolidate-widget-value-restore",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2019.8129999999992,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0559999999999996,
"layouts": 9,
"layoutDurationMs": 2.9330000000000003,
"taskDurationMs": 611.208,
"heapDeltaBytes": 3515720,
"heapUsedBytes": 80718796,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.288,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.153000000003,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.953,
"layouts": 9,
"layoutDurationMs": 2.8040000000000003,
"taskDurationMs": 598.761,
"heapDeltaBytes": 3667788,
"heapUsedBytes": 80397356,
"domNodes": 0,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 12.169999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2060.2910000000065,
"styleRecalcs": 86,
"styleRecalcDurationMs": 15.276000000000002,
"layouts": 9,
"layoutDurationMs": 2.817,
"taskDurationMs": 1152.036,
"heapDeltaBytes": -4410120,
"heapUsedBytes": 72686924,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 172.97700000000003,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2026.7039999999952,
"styleRecalcs": 84,
"styleRecalcDurationMs": 15.983999999999998,
"layouts": 9,
"layoutDurationMs": 2.9559999999999995,
"taskDurationMs": 1145.44,
"heapDeltaBytes": -4209468,
"heapUsedBytes": 73040980,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 172.52499999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1822.8709999999637,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.738999999999999,
"layouts": 11,
"layoutDurationMs": 2.96,
"taskDurationMs": 558.513,
"heapDeltaBytes": -1997460,
"heapUsedBytes": 74892708,
"domNodes": 56,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 16.511000000000003,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871556,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1791.4590000000317,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.590999999999999,
"layouts": 10,
"layoutDurationMs": 3.07,
"taskDurationMs": 515.841,
"heapDeltaBytes": -2438116,
"heapUsedBytes": 74892312,
"domNodes": 56,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.410999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 777.2070000000326,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.962,
"layouts": 9,
"layoutDurationMs": 2.8270000000000004,
"taskDurationMs": 557.8890000000001,
"heapDeltaBytes": 2666048,
"heapUsedBytes": 79883444,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 178.758,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 709.6030000000155,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.925,
"layouts": 9,
"layoutDurationMs": 2.4979999999999998,
"taskDurationMs": 503.42300000000006,
"heapDeltaBytes": 1785252,
"heapUsedBytes": 79145776,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.846,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1236.0889999999927,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 966.2719999999999,
"heapDeltaBytes": 23554344,
"heapUsedBytes": 105496516,
"domNodes": 0,
"jsHeapTotalBytes": 19824640,
"scriptDurationMs": 69.14099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 598,
"frameDurationMs": 36.276470588235284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1172.9289999999537,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 891.1179999999998,
"heapDeltaBytes": 23615212,
"heapUsedBytes": 104768944,
"domNodes": 0,
"jsHeapTotalBytes": 19824640,
"scriptDurationMs": 66.54199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 544,
"frameDurationMs": 35.35151515151514,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 869.6840000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.4129999999996,
"heapDeltaBytes": -4636956,
"heapUsedBytes": 88791496,
"domNodes": 0,
"jsHeapTotalBytes": 4198400,
"scriptDurationMs": 173.41,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 25.488235294117658,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 873.6669999999549,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 552.4220000000004,
"heapDeltaBytes": -3496020,
"heapUsedBytes": 88894032,
"domNodes": 0,
"jsHeapTotalBytes": 4460544,
"scriptDurationMs": 176.22099999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 239,
"frameDurationMs": 25.491176470588258,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11969.025000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11085.234,
"heapDeltaBytes": 7659128,
"heapUsedBytes": 100175520,
"domNodes": -141,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 8982.228000000001,
"eventListeners": -53,
"totalBlockingTimeMs": 1746,
"frameDurationMs": 32.516576086956526,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10452.044000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9579.056999999999,
"heapDeltaBytes": 1158480,
"heapUsedBytes": 93639848,
"domNodes": -141,
"jsHeapTotalBytes": 6942720,
"scriptDurationMs": 7694.458,
"eventListeners": -53,
"totalBlockingTimeMs": 909,
"frameDurationMs": 30.915680473372788,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11228.032999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10359.812,
"heapDeltaBytes": 2588856,
"heapUsedBytes": 95104452,
"domNodes": -141,
"jsHeapTotalBytes": 8515584,
"scriptDurationMs": 8412.049,
"eventListeners": -49,
"totalBlockingTimeMs": 1341,
"frameDurationMs": 31.330167597765364,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10314.508999999929,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9457.830000000002,
"heapDeltaBytes": -14753240,
"heapUsedBytes": 77429716,
"domNodes": -141,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 7557.778,
"eventListeners": -49,
"totalBlockingTimeMs": 905,
"frameDurationMs": 30.795223880597014,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 245.17399999996314,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.974,
"layouts": 8,
"layoutDurationMs": 2.5820000000000003,
"taskDurationMs": 189.557,
"heapDeltaBytes": 14566152,
"heapUsedBytes": 91349876,
"domNodes": 936,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.673,
"eventListeners": 205,
"totalBlockingTimeMs": 13,
"frameDurationMs": 25,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 244.04600000002574,
"styleRecalcs": 22,
"styleRecalcDurationMs": 15.690999999999997,
"layouts": 11,
"layoutDurationMs": 3.4619999999999997,
"taskDurationMs": 183.874,
"heapDeltaBytes": 14613916,
"heapUsedBytes": 91448048,
"domNodes": 936,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.614,
"eventListeners": 205,
"totalBlockingTimeMs": 16,
"frameDurationMs": 29.162500000000023,
"p95FrameDurationMs": 116.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2022.941000000003,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8059999999999996,
"layouts": 8,
"layoutDurationMs": 2.5940000000000003,
"taskDurationMs": 745.4939999999999,
"heapDeltaBytes": -7679768,
"heapUsedBytes": 86765788,
"domNodes": 0,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 42.278999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2014.5679999999402,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.511000000000001,
"layouts": 7,
"layoutDurationMs": 2.215,
"taskDurationMs": 685.106,
"heapDeltaBytes": -6750584,
"heapUsedBytes": 87923408,
"domNodes": 0,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 36.14000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2891.3540000000353,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.413000000000002,
"layouts": 5,
"layoutDurationMs": 1.4730000000000003,
"taskDurationMs": 1859.4890000000003,
"heapDeltaBytes": -4975104,
"heapUsedBytes": 90742032,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 890.5770000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.762209302325584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2764.923999999951,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.216999999999999,
"layouts": 6,
"layoutDurationMs": 1.3489999999999995,
"taskDurationMs": 1715.853,
"heapDeltaBytes": 16861176,
"heapUsedBytes": 91053736,
"domNodes": 0,
"jsHeapTotalBytes": 2846720,
"scriptDurationMs": 827.8800000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.766666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4076.4290000000187,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.457999999999998,
"layouts": 64,
"layoutDurationMs": 11.438,
"taskDurationMs": 1887.6820000000002,
"heapDeltaBytes": 6736024,
"heapUsedBytes": 80696096,
"domNodes": 24,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 829.704,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7344262295082,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3950.711999999953,
"styleRecalcs": 70,
"styleRecalcDurationMs": 10.020000000000001,
"layouts": 64,
"layoutDurationMs": 10.783000000000001,
"taskDurationMs": 1812.1680000000001,
"heapDeltaBytes": 6430188,
"heapUsedBytes": 80710900,
"domNodes": 24,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 796.4979999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665677966101697,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3189.0580000000455,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.617000000000001,
"layouts": 4,
"layoutDurationMs": 1.1389999999999998,
"taskDurationMs": 2114.396,
"heapDeltaBytes": 22021096,
"heapUsedBytes": 97528712,
"domNodes": 0,
"jsHeapTotalBytes": 4874240,
"scriptDurationMs": 1021.7760000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.931914893617027,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3280.9179999999287,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.916,
"layouts": 3,
"layoutDurationMs": 1.0170000000000006,
"taskDurationMs": 2125.845,
"heapDeltaBytes": 23840460,
"heapUsedBytes": 99553568,
"domNodes": 0,
"jsHeapTotalBytes": 6184960,
"scriptDurationMs": 1057.373,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.92538860103627,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2022.81499999998,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6820000000000013,
"layouts": 7,
"layoutDurationMs": 2.4469999999999996,
"taskDurationMs": 689.3470000000001,
"heapDeltaBytes": -6002396,
"heapUsedBytes": 90347000,
"domNodes": 0,
"jsHeapTotalBytes": 4493312,
"scriptDurationMs": 35.501999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2020.7080000000133,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1539999999999995,
"layouts": 7,
"layoutDurationMs": 2.0020000000000002,
"taskDurationMs": 656.1499999999999,
"heapDeltaBytes": 15719056,
"heapUsedBytes": 90015488,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 35.565,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 728.2630000000268,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.687,
"layouts": 9,
"layoutDurationMs": 3.124,
"taskDurationMs": 503.023,
"heapDeltaBytes": -476920,
"heapUsedBytes": 78695944,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 150.73499999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667441860465132,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 724.1670000000795,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.446,
"layouts": 9,
"layoutDurationMs": 2.6510000000000002,
"taskDurationMs": 507.45399999999995,
"heapDeltaBytes": -948856,
"heapUsedBytes": 78240476,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 148.361,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665116279069775,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.1819999999675,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4479999999999995,
"layouts": 8,
"layoutDurationMs": 2.2979999999999996,
"taskDurationMs": 593.143,
"heapDeltaBytes": 3615580,
"heapUsedBytes": 83020540,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 11.983,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2022.9120000000194,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.162,
"layouts": 10,
"layoutDurationMs": 2.795,
"taskDurationMs": 584.5480000000001,
"heapDeltaBytes": 4050196,
"heapUsedBytes": 83150208,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 10.800999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1977.3570000000404,
"styleRecalcs": 87,
"styleRecalcDurationMs": 16.509,
"layouts": 11,
"layoutDurationMs": 3.346,
"taskDurationMs": 1156.871,
"heapDeltaBytes": -7857236,
"heapUsedBytes": 71306292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 123.36699999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1977.1520000000464,
"styleRecalcs": 88,
"styleRecalcDurationMs": 15.900999999999998,
"layouts": 10,
"layoutDurationMs": 2.852,
"taskDurationMs": 1126.555,
"heapDeltaBytes": -7842408,
"heapUsedBytes": 71473388,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 117.795,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665546218487393,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1468.4890000000905,
"styleRecalcs": 17,
"styleRecalcDurationMs": 26.301,
"layouts": 5,
"layoutDurationMs": 16.471999999999998,
"taskDurationMs": 1138.712,
"heapDeltaBytes": 11183332,
"heapUsedBytes": 114139752,
"domNodes": 16030,
"jsHeapTotalBytes": 16125952,
"scriptDurationMs": 34.677,
"eventListeners": 3246,
"totalBlockingTimeMs": 174,
"frameDurationMs": 20.319178082191797,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 11436.433000000023,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.618,
"layouts": 8,
"layoutDurationMs": 2.253,
"taskDurationMs": 6567.455,
"heapDeltaBytes": -18973492,
"heapUsedBytes": 75795720,
"domNodes": 0,
"jsHeapTotalBytes": 6590464,
"scriptDurationMs": 2958.8740000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.714766081871346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11285.740999999916,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.512999999999998,
"layouts": 7,
"layoutDurationMs": 2.229,
"taskDurationMs": 6263.921000000001,
"heapDeltaBytes": 10488828,
"heapUsedBytes": 105220188,
"domNodes": 0,
"jsHeapTotalBytes": 6520832,
"scriptDurationMs": 2833.548,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69068047337278,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23463.266999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22820.395,
"heapDeltaBytes": -4594192,
"heapUsedBytes": 277677680,
"domNodes": -3245,
"jsHeapTotalBytes": 19922944,
"scriptDurationMs": 335.235,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.35972461273667,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 23800.421000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23122.185,
"heapDeltaBytes": -22115944,
"heapUsedBytes": 279423232,
"domNodes": -3245,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 344.628,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.544543828264764,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 28376.754999999946,
"styleRecalcs": 181,
"styleRecalcDurationMs": 23.01800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28047.699,
"heapDeltaBytes": -3348956,
"heapUsedBytes": 285267964,
"domNodes": -3245,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 951.366,
"eventListeners": -651,
"totalBlockingTimeMs": 23,
"frameDurationMs": 52.46247689463955,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27797.18600000001,
"styleRecalcs": 181,
"styleRecalcDurationMs": 20.58299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27473.088,
"heapDeltaBytes": -6874904,
"heapUsedBytes": 280968816,
"domNodes": -3245,
"jsHeapTotalBytes": 25690112,
"scriptDurationMs": 870.842,
"eventListeners": -651,
"totalBlockingTimeMs": 46,
"frameDurationMs": 51.79813780260708,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8490.97599999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.51499999999996,
"layouts": 20,
"layoutDurationMs": 22.69299999999999,
"taskDurationMs": 8358.742,
"heapDeltaBytes": 1123468,
"heapUsedBytes": 283740988,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 124.40899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 51.613939393939404,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8196.280000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.04999999999997,
"layouts": 20,
"layoutDurationMs": 21.894,
"taskDurationMs": 8074.791000000001,
"heapDeltaBytes": 28768400,
"heapUsedBytes": 307621856,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 128.101,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.85542857142857,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11820.777999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11565.513000000003,
"heapDeltaBytes": -44336036,
"heapUsedBytes": 268981624,
"domNodes": -3245,
"jsHeapTotalBytes": 22282240,
"scriptDurationMs": 171.60600000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.66288659793815,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11837.293000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11548.199,
"heapDeltaBytes": -14238936,
"heapUsedBytes": 294510700,
"domNodes": -3245,
"jsHeapTotalBytes": 23592960,
"scriptDurationMs": 163.27100000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.24795918367347,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 155.91199999994387,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.309000000000001,
"layouts": 8,
"layoutDurationMs": 3.2610000000000006,
"taskDurationMs": 110.49300000000001,
"heapDeltaBytes": 4895008,
"heapUsedBytes": 79454828,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.013000000000002,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.428571428571427,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "workflow-execution",
"durationMs": 111.51800000004641,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.403999999999999,
"layouts": 8,
"layoutDurationMs": 3.217,
"taskDurationMs": 78.9,
"heapDeltaBytes": 4730708,
"heapUsedBytes": 79365820,
"domNodes": 121,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.712000000000001,
"eventListeners": 5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 462.6499999999396,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.638,
"layouts": 76,
"layoutDurationMs": 14.673,
"taskDurationMs": 418.72200000000004,
"heapDeltaBytes": -4480728,
"heapUsedBytes": 38980424,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 200.05200000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 468.90700000005836,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.64,
"layouts": 76,
"layoutDurationMs": 14.758000000000001,
"taskDurationMs": 418.685,
"heapDeltaBytes": -4642432,
"heapUsedBytes": 38690508,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 206.056,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 601.1509999999589,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.712,
"layouts": 76,
"layoutDurationMs": 15.280999999999999,
"taskDurationMs": 564.8140000000001,
"heapDeltaBytes": 30220216,
"heapUsedBytes": 111825488,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 232.007,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 511.49100000009184,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.366,
"layouts": 76,
"layoutDurationMs": 14.952,
"taskDurationMs": 474.51800000000003,
"heapDeltaBytes": 130048,
"heapUsedBytes": 107086184,
"domNodes": 4,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 182.494,
"eventListeners": 296,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667741935483864,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageLine coverage: 64.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3068 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0d391f69e21c0c016a3d227b02da0b60c7385688
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (155)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21378 +/- ##
==========================================
+ Coverage 86.69% 87.55% +0.86%
==========================================
Files 3903 2780 -1123
Lines 182125 153251 -28874
Branches 47496 42434 -5062
==========================================
- Hits 157890 134181 -23709
+ Misses 21819 18434 -3385
+ Partials 2416 636 -1780
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1232 files with indirect coverage changes 🚀 New features to boost your workflow:
|
PR #21246 added coerceRestoredWidgetValue at six restore call sites plus a re-coercion in the DynamicGroup row-count guard. Move the policy into a pure module (utils/restoredWidgetValue.ts) and apply it in exactly one owner: - getRestoredWidgetValue now takes the widget and returns its saved value already converted, so LGraphNode.configure, addCustomWidget, PrimitiveNode and the DynamicGroup guard read a typed value with no local coercion. - New restoreValue action sets a widget to a saved value through the same policy; promoted-widget restore and both legacy proxyWidgets migration arms use it instead of getWidget + setValue + coerce. - PrimitiveNode reads its saved value after the widget exists, so the store has the widget's type. - The policy module is classified as node-widgets/domain, which removes the boundary warnings #21246 introduced (LGraphNode -> utils/widget, proxyWidgetMigration -> utils/widget). No behavior change: the existing per-path tests pass unchanged, and each one goes red if the store stops converting. Refs FE-3504
5285fe4 to
7d9f3fe
Compare
|
Merged main at a044da8 into this branch. Resolved the import conflict by keeping main’s IWidgetLocator type relocation and this PR’s store-owned widget restoration, without restoring call-site coercion. All 284 targeted tests, formatting, and pre-push checks passed. |
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at a8ec5e05d18dde366b45655f321668a00103acff.
- Restored-value coercion now has one store-owned path while preserving named and positional lookup behavior.
- Primitive widgets are created before type-aware restoration, and the ID-based migration paths preserve registered-state writes.
- Exact-head CI is settled with 96 passing and 27 skipped checks, with no failures, pending checks, or review threads.
Full context for agent readers
The policy move is behavior-preserving, the existing path-specific regressions remain in place, and the focused coercion table moved with the implementation. The diff does not change workspace selection or cross-tab behavior.
Summary
Stacked on #21246. That PR fixed PM-2173 by calling
coerceRestoredWidgetValueat six restore call sites plus a re-coercion in the DynamicGroup guard. This moves the conversion intowidgetValueStore, so it has one production caller:getRestoredWidgetValuetakes the widget and returns its saved value already converted.LGraphNode.configure,addCustomWidget, PrimitiveNode and the DynamicGroup guard drop their local coercion.restoreValue(widgetId, saved)action replacesgetWidget+setValue+ coerce in promoted-widget restore and both legacyproxyWidgetsmigration arms.utils/restoredWidgetValue.ts, classified as node-widgets/domain. This removes the two Fallow boundary warnings fix(widgets): restore numeric and boolean strings as typed widget values (PM-2173) #21246 added. Leaving it inutils/widget.tswould create a type-only import cycle with the store.Not covered: API-format prompt import in
app.tsstill assigns raw values. It is a separate boundary, tracked in FE-3504.Refs FE-3504
Verification
restoredWidgetValue.test.ts.typecheck:app) and pre-push (deps:audit, knip, fallow audit) hooks passed.architecture:checkpassed.