Repository navigation
[backport cloud/1.57] FE-3099 feat(auth): keep local SSO tokens in localStorage, refreshing under a cross-tab lock - #21197
Conversation
… under a cross-tab lock (#21168) ## Summary Resolves D3 (where Local SSO keeps the refresh token) the same way Firebase sign-in already works on a local ComfyUI page: the OAuth tokens persist in `localStorage`. A reload or a new tab now stays signed in instead of going back through the authorize redirect. - Linear: FE-3099 - Decision thread: #proj-sso, D3 (options A sessionStorage / B localStorage / C core httpOnly cookie). This PR implements **B**, matching today's non-SSO Local behavior. ## Why F4 (#20722) kept the tokens in memory until D3 was decided, so every reload or new tab on `127.0.0.1:8188` meant signing in again. Cloud survives a reload through its httpOnly session cookie, and Desktop survives through its main process. A loopback page has neither. Firebase sign-in on Local already keeps its refresh token in browser storage, so Local SSO now matches it. ## How - **`createStorageTokenStore`** - Persists the tokens under `Comfy.LocalWebSignIn.Tokens`. - Validates the stored value with zod; anything malformed reads as signed out. - Returns the same object until the stored string changes. - Reports `storage` events for its key (or a full clear) from other tabs. - **Cross-tab refresh lock.** Ingest rotates refresh tokens and treats reuse as theft, so two tabs refreshing with the same token would revoke the session. - Refresh runs under a Web Lock (`navigator.locks`, always available on loopback because it's a secure context). - Once it holds the lock, it re-reads storage. A tab that waited adopts the rotation another tab already made instead of spending the rotated-away token. - The "did someone sign out mid-refresh" check now compares refresh tokens instead of object identity, which no longer holds across tabs. - **Tab sync.** The bridge subscribes to the store, so signing in or out in one tab re-emits the auth state in the others. - `createMemoryTokenStore` stays as the test double. Risk trade-off, as discussed in the D3 thread: a custom-node frontend extension on the same origin can read `localStorage`. The same is already true for the Firebase refresh token on Local today. Rotation plus reuse detection limit a stolen token. OAuth refresh tokens have no revoke endpoint yet. ### Compared with Firebase sign-in on Local | | Firebase (Local today) | Local SSO OAuth (this PR) | |---|---|---| | Storage | `localStorage` (`browserLocalPersistence` first in `src/platform/auth/firebaseIdentity.ts`) | `localStorage` | | Access token | ID token, 1 h | OAuth access token, refreshed within 60 s of expiry | | Idle expiry of the refresh token | None | 30 days (`OAUTH_REFRESH_TOKEN_TTL`, renewed on each rotation) | | Absolute lifetime | None | None | | Re-checked on refresh | Account state only (deleted, disabled, password or email changed, admin revoke) | User, workspace membership, SSO policy and client (`revalidateOAuthMintState` in ingest) | | Rotation and reuse detection | No | Yes, with a 60 s grace (`OAUTH_REFRESH_REUSE_GRACE`) | Local SSO is as strict as Firebase or stricter on every row. A removed member, an SSO policy change, or a disabled `comfy-local-web` client is cut off at the next refresh, however long the token has been stored. The refresh TTL is a single ingest setting for every OAuth client, so Desktop (`comfy-desktop`) already ships with the same lifetime. Neither has the 7-day absolute cap of the Cloud web session. Adding one would be an ingest policy change, not something the frontend should enforce. ## Verification - `pnpm exec vitest run src/platform/auth`: 521 passed. New tests: - store: round trip across store instances; malformed values read as signed out; clear; storage events only for its key. - bridge: a reload stays signed in without hitting the token endpoint; with two tabs sharing storage and a lock, both expiring tabs end up on the rotated token with a single refresh request (the second tab never spends `refresh-1`); another tab's sign-out reaches this tab's listeners. - Typecheck, oxlint, eslint and knip pass (git hooks). AS IS / TO BE (local ComfyUI on 127.0.0.1 with `local_web_sso` on, signed in through Cloud, then reload / open a second tab): | AS IS | TO BE | |---|---| | _pending_ | _pending_ | ## Plan position (Local SSO, FE-3099 / FE-2170) | Item | PR | State | |---|---|---| | B1–B5, K1 (cloud) | cloud#12827, #12884, #12885, #12886, #12887, #12828, #13131 | merged | | F1–F5 | #20720, #20721, #20722, #20725, #20791 | merged | | **D3: persist tokens (this PR)** | this PR | **in review** | | Decision record (D1, D3 outcome) | #20953 | open | | C1 core renew | Comfy-Org/ComfyUI#16943 | review required | | F6 QA, then K1 off | — | after C1 | ```mermaid graph LR F4["F4: browser auth bridge (PR 20722)"] --> D3["D3: localStorage tokens (this PR)"] D3 --> F6["F6: QA"] C1["C1: core renew (ComfyUI 16943)"] --> F6 F6 --> K1["K1 off: enable mint in prod"] style D3 fill:#f9d71c,stroke:#333,stroke-width:2px ```
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-16T23:12:33.316Z",
"gitSha": "56ada591a685136a9dabeaa231e0f89ef11ff233",
"branch": "backport-21168-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.0110000000204,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.2560000000000002,
"layouts": 11,
"layoutDurationMs": 3.1369999999999996,
"taskDurationMs": 535.5960000000001,
"heapDeltaBytes": -897552,
"heapUsedBytes": 74038640,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 10.572000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2004.9759999999424,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.299,
"layouts": 9,
"layoutDurationMs": 2.351,
"taskDurationMs": 335.208,
"heapDeltaBytes": 22179776,
"heapUsedBytes": 88183496,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.273999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1743.9089999999737,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.272999999999998,
"layouts": 11,
"layoutDurationMs": 3.181,
"taskDurationMs": 834.9660000000001,
"heapDeltaBytes": -8308236,
"heapUsedBytes": 66670196,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 144.491,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.876000000053,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.465,
"layouts": 10,
"layoutDurationMs": 2.9460000000000006,
"taskDurationMs": 845.6590000000001,
"heapDeltaBytes": 15202484,
"heapUsedBytes": 81452232,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 149.72199999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.2560000000162,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.281000000000001,
"layouts": 11,
"layoutDurationMs": 2.8539999999999996,
"taskDurationMs": 277.649,
"heapDeltaBytes": 18758052,
"heapUsedBytes": 84157736,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.025,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.0979999999363,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.662999999999999,
"layouts": 12,
"layoutDurationMs": 3.1620000000000004,
"taskDurationMs": 372.939,
"heapDeltaBytes": 18401000,
"heapUsedBytes": 84731380,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 11.782,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 666.9310000000337,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.726,
"layouts": 10,
"layoutDurationMs": 2.7609999999999997,
"taskDurationMs": 485.837,
"heapDeltaBytes": 2428604,
"heapUsedBytes": 77296812,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 159.62,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667499999999997,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 634.8359999999502,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.0609999999999995,
"layouts": 10,
"layoutDurationMs": 2.9650000000000007,
"taskDurationMs": 479.456,
"heapDeltaBytes": 6507312,
"heapUsedBytes": 81621404,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 161.72699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1178.4759999999892,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 874.181,
"heapDeltaBytes": 697496,
"heapUsedBytes": 81155548,
"domNodes": -192,
"jsHeapTotalBytes": 14163968,
"scriptDurationMs": 58.72300000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 497,
"frameDurationMs": 31.98108108108106,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1164.1369999999824,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 879.2639999999999,
"heapDeltaBytes": 603516,
"heapUsedBytes": 80887728,
"domNodes": -212,
"jsHeapTotalBytes": 13901824,
"scriptDurationMs": 57.65499999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 507,
"frameDurationMs": 32.405555555555566,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.985000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.19800000000004,
"heapDeltaBytes": -4832084,
"heapUsedBytes": 76160208,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 140.87100000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 214,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 849.5700000000852,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.1880000000002,
"heapDeltaBytes": -5498740,
"heapUsedBytes": 75306944,
"domNodes": 0,
"jsHeapTotalBytes": 528384,
"scriptDurationMs": 141.21500000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9800.082999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8800.397,
"heapDeltaBytes": -1303952,
"heapUsedBytes": 95343680,
"domNodes": -258,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 6955.545,
"eventListeners": -68,
"totalBlockingTimeMs": 288,
"frameDurationMs": 28.160057471264366,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9361.363999999923,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8412.253,
"heapDeltaBytes": -16247808,
"heapUsedBytes": 83400260,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 6726.183,
"eventListeners": -63,
"totalBlockingTimeMs": 121,
"frameDurationMs": 27.46715542521994,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9598.687999999982,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.3989999999999992,
"layouts": 1,
"layoutDurationMs": 0.3280000000000002,
"taskDurationMs": 8621.151000000002,
"heapDeltaBytes": -834420,
"heapUsedBytes": 98730712,
"domNodes": -258,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 6790.228999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 258,
"frameDurationMs": 27.744508670520233,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8888.971999999967,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.346,
"layouts": 1,
"layoutDurationMs": 0.3339999999999997,
"taskDurationMs": 8018.700999999998,
"heapDeltaBytes": -24015560,
"heapUsedBytes": 76000272,
"domNodes": -258,
"jsHeapTotalBytes": 10612736,
"scriptDurationMs": 6705.691,
"eventListeners": -68,
"totalBlockingTimeMs": 224,
"frameDurationMs": 29.316831683168317,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 224.28399999995463,
"styleRecalcs": 25,
"styleRecalcDurationMs": 14.854999999999999,
"layouts": 12,
"layoutDurationMs": 3.271,
"taskDurationMs": 164.15,
"heapDeltaBytes": -8377312,
"heapUsedBytes": 79195712,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.608999999999998,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.670000000000027,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 222.37600000005386,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.409,
"layouts": 11,
"layoutDurationMs": 3.531,
"taskDurationMs": 167.08499999999998,
"heapDeltaBytes": -7567484,
"heapUsedBytes": 80132976,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 9.902,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.33000000000002,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2057.1669999999926,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.244,
"layouts": 9,
"layoutDurationMs": 2.5,
"taskDurationMs": 470.02500000000015,
"heapDeltaBytes": -2707560,
"heapUsedBytes": 76422380,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 32.724,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2007.3019999999815,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.436000000000001,
"layouts": 8,
"layoutDurationMs": 2.3169999999999997,
"taskDurationMs": 446.7730000000001,
"heapDeltaBytes": -2830336,
"heapUsedBytes": 76220240,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 30.736,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2422.9690000000232,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.925999999999999,
"layouts": 7,
"layoutDurationMs": 2.0799999999999996,
"taskDurationMs": 1619.8040000000003,
"heapDeltaBytes": -30117076,
"heapUsedBytes": 68172076,
"domNodes": -258,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 785.461,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665753424657538,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2324.2629999999735,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.619999999999999,
"layouts": 7,
"layoutDurationMs": 1.8030000000000004,
"taskDurationMs": 1599.2239999999997,
"heapDeltaBytes": 1017984,
"heapUsedBytes": 78008096,
"domNodes": -258,
"jsHeapTotalBytes": 3760128,
"scriptDurationMs": 757.067,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666428571428572,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3637.5040000000354,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.845,
"layouts": 64,
"layoutDurationMs": 11.68,
"taskDurationMs": 1741.091,
"heapDeltaBytes": -10235564,
"heapUsedBytes": 71645404,
"domNodes": -234,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 779.539,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.742857142857144,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3587.8280000000586,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.529,
"layouts": 63,
"layoutDurationMs": 10.815999999999999,
"taskDurationMs": 1713.466,
"heapDeltaBytes": -32031624,
"heapUsedBytes": 67489684,
"domNodes": -234,
"jsHeapTotalBytes": 5144576,
"scriptDurationMs": 755.466,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.744392523364482,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2830.1250000000095,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.155,
"layouts": 5,
"layoutDurationMs": 1.3220000000000003,
"taskDurationMs": 1873.2420000000002,
"heapDeltaBytes": 2454852,
"heapUsedBytes": 80877344,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 926.8870000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.865269461077844,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2906.174000000078,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.760000000000001,
"layouts": 4,
"layoutDurationMs": 1.1380000000000001,
"taskDurationMs": 1875.8740000000003,
"heapDeltaBytes": 16257664,
"heapUsedBytes": 99353176,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 940.1719999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.86046511627907,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2026.3899999999921,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1519999999999992,
"layouts": 7,
"layoutDurationMs": 2.0559999999999996,
"taskDurationMs": 623.9220000000001,
"heapDeltaBytes": -16951032,
"heapUsedBytes": 81530960,
"domNodes": -258,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 34.214,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2024.1780000000063,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3429999999999995,
"layouts": 8,
"layoutDurationMs": 2.3080000000000003,
"taskDurationMs": 618.7640000000001,
"heapDeltaBytes": -2815724,
"heapUsedBytes": 74646744,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 34.49799999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.8810000000162,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.953,
"layouts": 9,
"layoutDurationMs": 2.553,
"taskDurationMs": 460.413,
"heapDeltaBytes": 21641540,
"heapUsedBytes": 88961720,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 143.194,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.7030000000341,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.151000000000001,
"layouts": 10,
"layoutDurationMs": 2.6830000000000003,
"taskDurationMs": 429.457,
"heapDeltaBytes": -1092360,
"heapUsedBytes": 76255404,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 144.692,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.6810000000341,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4650000000000003,
"layouts": 10,
"layoutDurationMs": 2.561,
"taskDurationMs": 494.055,
"heapDeltaBytes": -254764,
"heapUsedBytes": 76721540,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 9.371,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.1650000000527,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7870000000000004,
"layouts": 10,
"layoutDurationMs": 2.5109999999999992,
"taskDurationMs": 356.33099999999996,
"heapDeltaBytes": 22501452,
"heapUsedBytes": 89371152,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.021,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.1520000000037,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.576999999999998,
"layouts": 10,
"layoutDurationMs": 2.7339999999999995,
"taskDurationMs": 786.246,
"heapDeltaBytes": -11371236,
"heapUsedBytes": 65996564,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 101.437,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1960.0619999999935,
"styleRecalcs": 87,
"styleRecalcDurationMs": 17.4,
"layouts": 9,
"layoutDurationMs": 2.5279999999999996,
"taskDurationMs": 1024.5420000000001,
"heapDeltaBytes": 15297408,
"heapUsedBytes": 91816684,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 107.846,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665254237288135,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1436.411000000021,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.175000000000004,
"layouts": 5,
"layoutDurationMs": 14.947,
"taskDurationMs": 1000.3489999999999,
"heapDeltaBytes": 9674988,
"heapUsedBytes": 105448516,
"domNodes": 15953,
"jsHeapTotalBytes": 18227200,
"scriptDurationMs": 26.74599999999999,
"eventListeners": 3244,
"totalBlockingTimeMs": 139,
"frameDurationMs": 19.594594594594593,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "viewport-pan-sweep",
"durationMs": 8686.717999999984,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.955000000000002,
"layouts": 7,
"layoutDurationMs": 1.8560000000000003,
"taskDurationMs": 5691.718,
"heapDeltaBytes": -5504640,
"heapUsedBytes": 73826084,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 2649.2290000000003,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.730250481695567,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8448.046999999973,
"styleRecalcs": 248,
"styleRecalcDurationMs": 19.239,
"layouts": 5,
"layoutDurationMs": 1.262,
"taskDurationMs": 5475.429,
"heapDeltaBytes": 8736576,
"heapUsedBytes": 88164876,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 2466.6319999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69901185770751,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23384.223999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22985.918,
"heapDeltaBytes": -41796864,
"heapUsedBytes": 263552280,
"domNodes": -3330,
"jsHeapTotalBytes": 11259904,
"scriptDurationMs": 335.567,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.02175438596492,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-large-graph-idle",
"durationMs": 16874.520000000077,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16017.347000000002,
"heapDeltaBytes": -18204140,
"heapUsedBytes": 282465892,
"domNodes": -3330,
"jsHeapTotalBytes": 24109056,
"scriptDurationMs": 248.75799999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.434729493891794,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 20276.584000000013,
"styleRecalcs": 162,
"styleRecalcDurationMs": 14.585000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19845.057,
"heapDeltaBytes": -12981164,
"heapUsedBytes": 263503408,
"domNodes": -3330,
"jsHeapTotalBytes": 17555456,
"scriptDurationMs": 836.4509999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.77001862197393,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 28304.672000000097,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.506999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27955.754999999997,
"heapDeltaBytes": -6047680,
"heapUsedBytes": 284841932,
"domNodes": -3330,
"jsHeapTotalBytes": 6475776,
"scriptDurationMs": 888.027,
"eventListeners": -651,
"totalBlockingTimeMs": 34,
"frameDurationMs": 54.14053537284896,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 6255.356000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.54599999999998,
"layouts": 20,
"layoutDurationMs": 30.223999999999986,
"taskDurationMs": 6122.509000000001,
"heapDeltaBytes": -37158016,
"heapUsedBytes": 253891164,
"domNodes": -3330,
"jsHeapTotalBytes": 22274048,
"scriptDurationMs": 104.753,
"eventListeners": -653,
"totalBlockingTimeMs": 17,
"frameDurationMs": 36.335465116279074,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6117.065000000025,
"styleRecalcs": 20,
"styleRecalcDurationMs": 86.096,
"layouts": 20,
"layoutDurationMs": 34.95300000000001,
"taskDurationMs": 6022.307000000001,
"heapDeltaBytes": -3259004,
"heapUsedBytes": 287869032,
"domNodes": -3330,
"jsHeapTotalBytes": 23846912,
"scriptDurationMs": 97.33,
"eventListeners": -653,
"totalBlockingTimeMs": 16,
"frameDurationMs": 35.56046511627907,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11397.174000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11141.831,
"heapDeltaBytes": 15309160,
"heapUsedBytes": 266731436,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 155.644,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.52395833333334,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11415.495999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11153.571999999998,
"heapDeltaBytes": -5080004,
"heapUsedBytes": 253690740,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.96348122866894,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 497.4040000000173,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.385,
"layouts": 11,
"layoutDurationMs": 4.4559999999999995,
"taskDurationMs": 158.47300000000004,
"heapDeltaBytes": -12947276,
"heapUsedBytes": 70934792,
"domNodes": 126,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 16.543,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24137931034483,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 478.04199999995944,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.993000000000002,
"layouts": 12,
"layoutDurationMs": 3.501,
"taskDurationMs": 132.52,
"heapDeltaBytes": -13371780,
"heapUsedBytes": 70165656,
"domNodes": 95,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 11.582,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 411.9739999999865,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.006,
"layouts": 76,
"layoutDurationMs": 14.768,
"taskDurationMs": 363.42,
"heapDeltaBytes": -19925016,
"heapUsedBytes": 70009932,
"domNodes": 4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 170.06799999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664000000000016,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 476.86400000009144,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.029,
"layouts": 76,
"layoutDurationMs": 15.504999999999999,
"taskDurationMs": 428.22800000000007,
"heapDeltaBytes": 11553488,
"heapUsedBytes": 83011056,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 204.94299999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 482.0439999999735,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.109,
"layouts": 76,
"layoutDurationMs": 14.408000000000001,
"taskDurationMs": 447.947,
"heapDeltaBytes": 27998508,
"heapUsedBytes": 148102152,
"domNodes": 4,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 173.195,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24482758620691,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 534.8339999999325,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.3080000000000003,
"layouts": 76,
"layoutDurationMs": 15.649,
"taskDurationMs": 495.351,
"heapDeltaBytes": -109992,
"heapUsedBytes": 118662212,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 199.059,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.19062500000001,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2279 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9656f9f2b9d15c59274c06a85139801cb470d635
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.57 #21197 +/- ##
=============================================
Coverage ? 87.19%
=============================================
Files ? 2626
Lines ? 147652
Branches ? 40509
=============================================
Hits ? 128739
Misses ? 18523
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21168 to
cloud/1.57Automatically created by backport workflow.