Repository navigation
[backport cloud/1.57] FE-3434 fix(billing): show Add credits from can_top_up alone - #21141
Conversation
## Why The Add credits entry decided between top-up and subscribe by combining `can_top_up || can_subscribe_self_serve`, and `canTopUp` fell back to the owner role when the capability read was unavailable. The backend now answers top-up in one place: `can_top_up` no longer denies `no_subscription`, `free_plan` or `subscription_ended` (BE-20307, deployed 2026-10-15). `payment_past_due` still denies. Linear: https://linear.app/comfyorg/issue/FE-3434 Notion: https://app.notion.com/p/3fa6d73d3650815f8934dc73b2fe65c6 ## Root cause The client derived the top-up decision from two capabilities plus role: `canTopUp || canSubscribeSelfServe` in CreditsTile, the legacy user popover and the top-up dispatchers, and an owner-role fallback in `canTopUp` when the read was unavailable. Per ADR API-SERVER-FACTS-0042 a gate renders one server fact as received. ## How - `canTopUp` on Cloud is `capabilities.can_top_up ?? false`; the owner fallback and its `readUnavailableForCurrentScope` helper are removed. The `!isCloud` branch is untouched (FE-3453). - CreditsTile, both user popovers, `showTopUpCreditsDialog` and `useTopUpUrlLoader` gate on `canTopUp` alone. The "Upgrade to add credits" buttons and the dispatcher's subscribe redirect are removed. - CreditsTile no longer hides Add credits for the zero/inactive-plan states; the server decides. On Cloud without a plan it shows a muted note: "Subscribe to use credits on Cloud." (`subscription_status` of `ended`: "Resubscribe to use credits on Cloud."). The note renders only beside Add credits, never on Local, and never over the existing inactive-plan notes. - Tests that encoded the old behaviour on purpose are updated: owner fallback on unavailable/mismatched/503 reads now expects false; the subscribe-redirect and "Upgrade to add credits" tests now assert the redirect/button is gone; inactive and zero-state tile tests now expect Add credits to follow `can_top_up`. New gate table over `can_top_up` x plan state (active / none / ended) plus the legacy popover table. ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/b5b1ff31-4b6b-4b2d-85d0-ac8a7a8e4616" /> | <img src="https://github.com/user-attachments/assets/35dead32-e76b-4e8b-a160-0d8d8ab1dc76" /> | | main: team workspace with no subscription, Add credits hidden (local main -> testcloud) | FE-3434 branch: same workspace, Add credits shown from can_top_up (local branch -> testcloud) | ## Plan position | Ticket | State | | --- | --- | | FE-3432 | merged-queue | | **FE-3434 (this PR)** | in review | | FE-3433 | planned | | FE-3447 | planned | | FE-3448 | planned | ```mermaid flowchart LR A["FE-3432 (merged-queue)"] --> B["FE-3434 (this PR)"] B --> C["FE-3433"] C --> D["FE-3447"] D --> E["FE-3448"] style B fill:#f9d44a,stroke:#333,stroke-width:3px,color:#000 ``` --------- Co-authored-by: Cursor <cursoragent@cursor.com>
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-16T00:26:44.233Z",
"gitSha": "6eb1a5de265739f805f4e636f39b47ee61a3c68c",
"branch": "backport-21116-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2040.4689999999732,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.4019999999999997,
"layouts": 10,
"layoutDurationMs": 3.2740000000000005,
"taskDurationMs": 561.991,
"heapDeltaBytes": 3486084,
"heapUsedBytes": 78612164,
"domNodes": 0,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 12.669999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.1209999999837,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0690000000000004,
"layouts": 9,
"layoutDurationMs": 2.8059999999999996,
"taskDurationMs": 377.6,
"heapDeltaBytes": 22131848,
"heapUsedBytes": 87981212,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 11.983,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1806.824000000006,
"styleRecalcs": 77,
"styleRecalcDurationMs": 15.754999999999999,
"layouts": 11,
"layoutDurationMs": 3.5540000000000003,
"taskDurationMs": 889.4040000000001,
"heapDeltaBytes": -8353028,
"heapUsedBytes": 66426840,
"domNodes": -162,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 155.669,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1978.6439999999175,
"styleRecalcs": 84,
"styleRecalcDurationMs": 16.338,
"layouts": 9,
"layoutDurationMs": 2.9160000000000004,
"taskDurationMs": 1068.6709999999998,
"heapDeltaBytes": -8272084,
"heapUsedBytes": 66718452,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 164.476,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66638655462185,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.0720000000401,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.245,
"layouts": 11,
"layoutDurationMs": 3.0250000000000004,
"taskDurationMs": 401.18399999999997,
"heapDeltaBytes": 18745040,
"heapUsedBytes": 84058128,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 12.37,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.1360000000113,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.817,
"layouts": 12,
"layoutDurationMs": 3.7620000000000005,
"taskDurationMs": 311.388,
"heapDeltaBytes": 18793244,
"heapUsedBytes": 84227400,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 13.324,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307695,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 670.3730000000405,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.606,
"layouts": 8,
"layoutDurationMs": 2.415,
"taskDurationMs": 507.58899999999994,
"heapDeltaBytes": 26075980,
"heapUsedBytes": 91472064,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 171.74,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66500000000001,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 625.9300000000394,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9980000000000007,
"layouts": 9,
"layoutDurationMs": 2.7369999999999997,
"taskDurationMs": 454.01899999999995,
"heapDeltaBytes": 25142844,
"heapUsedBytes": 91125528,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 175.661,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1198.6079999999788,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 896.1260000000001,
"heapDeltaBytes": -12110052,
"heapUsedBytes": 80895616,
"domNodes": -212,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 68.79699999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 522,
"frameDurationMs": 32.42972972972974,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1211.0450000000128,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 918.0149999999999,
"heapDeltaBytes": -11037996,
"heapUsedBytes": 81655500,
"domNodes": -192,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 70.59499999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 520,
"frameDurationMs": 32.01578947368422,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.877999999961,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.2390000000002,
"heapDeltaBytes": -4888160,
"heapUsedBytes": 76109508,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 154.24699999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 206,
"frameDurationMs": 24.282857142857132,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.9090000000297,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.15399999999977,
"heapDeltaBytes": -4296332,
"heapUsedBytes": 76322660,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 160.43999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11158.513999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10179.837,
"heapDeltaBytes": -9543232,
"heapUsedBytes": 89827544,
"domNodes": -258,
"jsHeapTotalBytes": 12709888,
"scriptDurationMs": 8341.287999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1366,
"frameDurationMs": 31.946991404011463,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10497.099999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9643.524000000001,
"heapDeltaBytes": -13413468,
"heapUsedBytes": 86051752,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 7780.22,
"eventListeners": -68,
"totalBlockingTimeMs": 867,
"frameDurationMs": 31.063905325443788,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8523.947000000022,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.33500000000000024,
"layouts": 1,
"layoutDurationMs": 0.389,
"taskDurationMs": 7784.854000000001,
"heapDeltaBytes": -249820,
"heapUsedBytes": 98894184,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 6514.9839999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 564,
"frameDurationMs": 32.259090909090915,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8699.930999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7923.158,
"heapDeltaBytes": -21194724,
"heapUsedBytes": 78154428,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 6596.652,
"eventListeners": -68,
"totalBlockingTimeMs": 564,
"frameDurationMs": 32.16346863468635,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 244.17499999998427,
"styleRecalcs": 26,
"styleRecalcDurationMs": 15.440999999999999,
"layouts": 12,
"layoutDurationMs": 3.54,
"taskDurationMs": 183.09,
"heapDeltaBytes": -8382472,
"heapUsedBytes": 79615620,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.043000000000003,
"eventListeners": 195,
"totalBlockingTimeMs": 2,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 215.05999999999403,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.57,
"layouts": 11,
"layoutDurationMs": 3.5550000000000006,
"taskDurationMs": 159.18999999999997,
"heapDeltaBytes": -8179808,
"heapUsedBytes": 79182216,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.652,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.660000000000036,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2010.1310000000012,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.822999999999999,
"layouts": 9,
"layoutDurationMs": 2.972,
"taskDurationMs": 455.22799999999995,
"heapDeltaBytes": -2828992,
"heapUsedBytes": 76264116,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 31.205000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.9400000000014,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.418000000000001,
"layouts": 7,
"layoutDurationMs": 2.378,
"taskDurationMs": 514.363,
"heapDeltaBytes": -2795176,
"heapUsedBytes": 76572432,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 36.03699999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6650406504065,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2667.949999999962,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.95,
"layouts": 7,
"layoutDurationMs": 1.841,
"taskDurationMs": 1719.9360000000001,
"heapDeltaBytes": -10603708,
"heapUsedBytes": 69430768,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 829.927,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2296.6730000000553,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.931000000000001,
"layouts": 5,
"layoutDurationMs": 1.7000000000000002,
"taskDurationMs": 1609.553,
"heapDeltaBytes": -8212884,
"heapUsedBytes": 72189448,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 877.2220000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.163432835820892,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3555.3370000000086,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.698,
"layouts": 64,
"layoutDurationMs": 10.46,
"taskDurationMs": 1559.71,
"heapDeltaBytes": 1711280,
"heapUsedBytes": 83880372,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 780.2710000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.744811320754714,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3797.6549999999634,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.727,
"layouts": 64,
"layoutDurationMs": 11.32,
"taskDurationMs": 1760.7330000000002,
"heapDeltaBytes": 4835484,
"heapUsedBytes": 86687704,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 771.991,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3156.587000000002,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.261,
"layouts": 5,
"layoutDurationMs": 1.5890000000000002,
"taskDurationMs": 1994.123,
"heapDeltaBytes": 6903612,
"heapUsedBytes": 84467460,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 977.6139999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84308510638298,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3079.637000000048,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.602,
"layouts": 4,
"layoutDurationMs": 1.1190000000000002,
"taskDurationMs": 1992.0790000000002,
"heapDeltaBytes": 16658028,
"heapUsedBytes": 99770596,
"domNodes": 0,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 963.0300000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.94254143646409,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2024.9580000000265,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.301999999999999,
"layouts": 7,
"layoutDurationMs": 2.248,
"taskDurationMs": 454.4059999999999,
"heapDeltaBytes": -2408964,
"heapUsedBytes": 78517360,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 34.144999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2040.885000000003,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.142000000000001,
"layouts": 6,
"layoutDurationMs": 2.0069999999999997,
"taskDurationMs": 630.1799999999998,
"heapDeltaBytes": -2844004,
"heapUsedBytes": 78535940,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 34.46000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 659.8610000000349,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.966,
"layouts": 9,
"layoutDurationMs": 2.7630000000000003,
"taskDurationMs": 472.35799999999995,
"heapDeltaBytes": -1104056,
"heapUsedBytes": 76274496,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 148.57799999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000005,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 598.7810000000309,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.114,
"layouts": 9,
"layoutDurationMs": 2.8089999999999997,
"taskDurationMs": 445.756,
"heapDeltaBytes": 21666616,
"heapUsedBytes": 88609044,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 148.647,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669444444444455,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.1720000000023,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.8660000000000005,
"layouts": 9,
"layoutDurationMs": 2.8240000000000003,
"taskDurationMs": 357.7629999999999,
"heapDeltaBytes": 22488384,
"heapUsedBytes": 89452524,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.848999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.2989999999518,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.1200000000000006,
"layouts": 9,
"layoutDurationMs": 2.7880000000000007,
"taskDurationMs": 525.42,
"heapDeltaBytes": -252900,
"heapUsedBytes": 77150200,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 9.911,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.8300000000245,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.432999999999998,
"layouts": 9,
"layoutDurationMs": 2.5720000000000005,
"taskDurationMs": 676.8670000000001,
"heapDeltaBytes": 10309728,
"heapUsedBytes": 76887128,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 111.634,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.1139999999523,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.296000000000003,
"layouts": 9,
"layoutDurationMs": 2.5650000000000004,
"taskDurationMs": 863.65,
"heapDeltaBytes": 11211584,
"heapUsedBytes": 78285036,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 114.60799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1451.6099999999597,
"styleRecalcs": 20,
"styleRecalcDurationMs": 28.678,
"layouts": 5,
"layoutDurationMs": 16.549,
"taskDurationMs": 1129.796,
"heapDeltaBytes": 2489376,
"heapUsedBytes": 99459312,
"domNodes": 15953,
"jsHeapTotalBytes": 18485248,
"scriptDurationMs": 33.459,
"eventListeners": 3244,
"totalBlockingTimeMs": 167,
"frameDurationMs": 19.554666666666673,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9622.03999999997,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.005000000000003,
"layouts": 7,
"layoutDurationMs": 1.8830000000000002,
"taskDurationMs": 5939.942,
"heapDeltaBytes": -7860196,
"heapUsedBytes": 88328428,
"domNodes": -258,
"jsHeapTotalBytes": 5861376,
"scriptDurationMs": 2683.7889999999998,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72378472222222,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8324.231000000054,
"styleRecalcs": 249,
"styleRecalcDurationMs": 18.936,
"layouts": 6,
"layoutDurationMs": 1.6589999999999998,
"taskDurationMs": 5224.018,
"heapDeltaBytes": 6042108,
"heapUsedBytes": 85015408,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 2692.96,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699598393574295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 22975.648999999976,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22000.747,
"heapDeltaBytes": 4684876,
"heapUsedBytes": 280845888,
"domNodes": -3330,
"jsHeapTotalBytes": 15716352,
"scriptDurationMs": 324.377,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.73304498269896,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 23347.075999999903,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22767.032,
"heapDeltaBytes": -43946344,
"heapUsedBytes": 261165580,
"domNodes": -3330,
"jsHeapTotalBytes": 12574720,
"scriptDurationMs": 325.677,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.29775474956822,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 27657.941999999992,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.577000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27205.258000000005,
"heapDeltaBytes": -22389944,
"heapUsedBytes": 273203340,
"domNodes": -3330,
"jsHeapTotalBytes": 3133440,
"scriptDurationMs": 886.909,
"eventListeners": -651,
"totalBlockingTimeMs": 73,
"frameDurationMs": 50.30109090909091,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 27749.91,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.813999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27292.423,
"heapDeltaBytes": -21365168,
"heapUsedBytes": 274365528,
"domNodes": -3334,
"jsHeapTotalBytes": 2871296,
"scriptDurationMs": 860.413,
"eventListeners": -651,
"totalBlockingTimeMs": 14,
"frameDurationMs": 51.03952205882352,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 5871.309999999994,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.75299999999999,
"layouts": 20,
"layoutDurationMs": 22.264000000000006,
"taskDurationMs": 5741.944,
"heapDeltaBytes": 1425412,
"heapUsedBytes": 292236672,
"domNodes": -307,
"jsHeapTotalBytes": 23322624,
"scriptDurationMs": 91.773,
"eventListeners": -7,
"totalBlockingTimeMs": 15,
"frameDurationMs": 34.00635838150289,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5863.425000000007,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.02299999999997,
"layouts": 20,
"layoutDurationMs": 23.329000000000004,
"taskDurationMs": 5683.178,
"heapDeltaBytes": -37894796,
"heapUsedBytes": 261882152,
"domNodes": -3330,
"jsHeapTotalBytes": 20172800,
"scriptDurationMs": 96.15100000000001,
"eventListeners": -657,
"totalBlockingTimeMs": 16,
"frameDurationMs": 33.910404624277454,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11516.933999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11275.522000000003,
"heapDeltaBytes": 9008696,
"heapUsedBytes": 272866104,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.92799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.69328621908127,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8265.283999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7703.4800000000005,
"heapDeltaBytes": 8700568,
"heapUsedBytes": 250070804,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.81399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.83265993265993,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 139.59799999997813,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.282000000000002,
"layouts": 9,
"layoutDurationMs": 3.375,
"taskDurationMs": 100.799,
"heapDeltaBytes": 4623096,
"heapUsedBytes": 77711348,
"domNodes": 120,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.535000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.05714285714287,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "workflow-execution",
"durationMs": 136.16000000001804,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.528,
"layouts": 8,
"layoutDurationMs": 3.224,
"taskDurationMs": 107.602,
"heapDeltaBytes": -15621024,
"heapUsedBytes": 68084212,
"domNodes": 94,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.237000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.73750000000001,
"p95FrameDurationMs": 33.19999999999982
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 495.3500000000304,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.083,
"layouts": 76,
"layoutDurationMs": 15.853,
"taskDurationMs": 444.2660000000001,
"heapDeltaBytes": 11710108,
"heapUsedBytes": 84068136,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 214.671,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 516.132999999968,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.998,
"layouts": 76,
"layoutDurationMs": 15.582,
"taskDurationMs": 464.77299999999997,
"heapDeltaBytes": 12027060,
"heapUsedBytes": 82553604,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 226.616,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 578.420000000051,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.184,
"layouts": 76,
"layoutDurationMs": 14.908,
"taskDurationMs": 545.717,
"heapDeltaBytes": 826940,
"heapUsedBytes": 120338284,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 221.76999999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 618.5749999999643,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.247,
"layouts": 76,
"layoutDurationMs": 20.672,
"taskDurationMs": 564.4559999999999,
"heapDeltaBytes": 238960,
"heapUsedBytes": 118703000,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 226.387,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.591666666666672,
"p95FrameDurationMs": 33.19999999999982
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2276 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 71f15e1c9fb3155be31241cb9a6af4c98adc19e6
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21141 +/- ##
=============================================
Coverage ? 87.19%
=============================================
Files ? 2626
Lines ? 147574
Branches ? 40489
=============================================
Hits ? 128680
Misses ? 18504
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #21116 to
cloud/1.57Automatically created by backport workflow.