Repository navigation
[backport cloud/1.57] FE-3361 feat(server-facts): restrict receiveServerFact to fact providers - #21130
Conversation
…ers (#20918) ## Why FE-3361 (L1, server-fact guardrails), step 7 of the design note. `receiveServerFact` holds the one cast that turns any boolean into a `ServerFact<Field>`. It was importable anywhere, so a gate could launder a derivation through it (`receiveServerFact('can_invite_members', canInvite || isPlanEnded)`) and the type from #20818 would accept the result. #20818 listed this as a known risk. ## How - New rule `comfy/no-stray-server-fact-constructor` in `tools/oxlint-plugins/serverFacts.ts`: reports `receiveServerFact` outside fact providers: a named import (aliased or not), or a member access such as `facts.receiveServerFact` after `import * as facts`. - Allowed: `serverFact.ts` itself, `useBillingCapabilities.ts` (the capability read that decodes the API response), test/spec/stories files, `__mocks__/`, `src/storybook/`. A new provider is added to `FACT_PROVIDERS`, so minting facts in a new module is a reviewed change. - Registered in `serverFacts.oxlintrc.json`, so it runs in the changed-line `lint:server-facts` gate inside the required `lint-and-format` check. - ADR-API-SERVER-FACTS-0042 enforcement list names the rule, and counts an off-Cloud local provider (rule 2) as a fact provider alongside the API decoder. Reporting the import and the member access, rather than resolving calls, covers aliases and namespaces without scope tracking. Every current import is in an allowed file, so the rule has no existing findings. ## AS IS / TO BE Tooling only, no UI change. | A gate file adds `import { receiveServerFact } from '@/platform/serverFacts/serverFact'` | AS IS | TO BE | |---|---|---| | `lint:server-facts` | passes | fails at the import | ## Verification - `vitest run tools/oxlint-plugins/serverFacts.test.ts`: 68 passed (allowed: 4 providers and a reading gate; reported: a minting gate, a namespace member in dotted and bracketed form, an aliased import). - Mutation: inverting the name check fails 3 rows; removing the member-access visitor fails the namespace row. - `scripts/server-fact-gate.test.ts`: a `lintSnapshot` case runs the gate config on a real `<script setup lang="ts">` SFC and expects the finding on line 3. - End to end through `lintSnapshot` with the gate config: the import is reported in `src/platform/workspace/composables/useX.ts` and not in `useBillingCapabilities.ts`. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3360. | Item | Ticket | PR | Status | |---|---|---|---| | L1 `ServerFact` type (members panel) | FE-3361 | #20818 | Merged | | L2 members panel: drop off-Cloud branches | FE-3362 | #20917 | In review | | **L1 restrict `receiveServerFact`** | **FE-3361** | **this PR** | **In review** | | L1 lifecycle, seats, top-up, subscribe | FE-3361 | — | Waiting on backend facts (FE-3366 C list) | ```mermaid graph LR L1["L1 ServerFact type (PR 20818, merged)"] --> R["L1 restrict constructor (this PR)"]:::current L1 --> L2["L2 members panel (PR 20917)"] BE["Backend facts (C list)"] -. blocks .-> M["L1 remaining surfaces"] R --> M classDef current fill:#f9d71c,stroke:#333,stroke-width:2px ```
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-15T21:28:15.378Z",
"gitSha": "833bfae4a2828ce749b50c85816013f34f06073a",
"branch": "backport-20918-to-cloud-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.5779999999959,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.7439999999999998,
"layouts": 9,
"layoutDurationMs": 2.843,
"taskDurationMs": 395.784,
"heapDeltaBytes": 1089632,
"heapUsedBytes": 67101632,
"domNodes": -162,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.645999999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.403999999994,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.688,
"layouts": 9,
"layoutDurationMs": 2.746,
"taskDurationMs": 357.248,
"heapDeltaBytes": 21703584,
"heapUsedBytes": 88196884,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 9.787,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.721999999997,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.926000000000002,
"layouts": 9,
"layoutDurationMs": 2.5709999999999997,
"taskDurationMs": 819.047,
"heapDeltaBytes": -7273796,
"heapUsedBytes": 68452296,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 157.306,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66509433962264,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1975.8319999999685,
"styleRecalcs": 84,
"styleRecalcDurationMs": 15.782999999999998,
"layouts": 9,
"layoutDurationMs": 2.6420000000000003,
"taskDurationMs": 1037.4170000000001,
"heapDeltaBytes": 15622496,
"heapUsedBytes": 81894488,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 162.88,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.173000000002,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.67,
"layouts": 12,
"layoutDurationMs": 3.6220000000000003,
"taskDurationMs": 385.146,
"heapDeltaBytes": -4115836,
"heapUsedBytes": 71264484,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.768,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1793.2839999999715,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.5120000000000005,
"layouts": 11,
"layoutDurationMs": 2.4330000000000003,
"taskDurationMs": 317.25899999999996,
"heapDeltaBytes": 19072700,
"heapUsedBytes": 85428160,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 10.842,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 675.8429999999862,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.881,
"layouts": 10,
"layoutDurationMs": 2.658,
"taskDurationMs": 499.73499999999996,
"heapDeltaBytes": 2860456,
"heapUsedBytes": 77317520,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 165.269,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414635,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 711.5300000000389,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.900000000000001,
"layouts": 10,
"layoutDurationMs": 3.1159999999999997,
"taskDurationMs": 499.096,
"heapDeltaBytes": 25716424,
"heapUsedBytes": 91586936,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 169.47699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1187.749999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 825.6320000000002,
"heapDeltaBytes": -11435820,
"heapUsedBytes": 81195104,
"domNodes": -192,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 64.89000000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 515,
"frameDurationMs": 32.86944444444445,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1198.075000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 886.212,
"heapDeltaBytes": -11394700,
"heapUsedBytes": 81371928,
"domNodes": -192,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 67.83900000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 517,
"frameDurationMs": 32.42972972972974,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.2130000000107,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 478.72400000000016,
"heapDeltaBytes": -4769780,
"heapUsedBytes": 75968696,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 152.777,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.9970588235294,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 843.7149999999747,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.3870000000002,
"heapDeltaBytes": -5048668,
"heapUsedBytes": 75626968,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 163.221,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 25.00294117647057,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10543.37700000002,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05199999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9623.457999999999,
"heapDeltaBytes": -3428692,
"heapUsedBytes": 83697520,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 7780.476000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 984,
"frameDurationMs": 31.91787878787879,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9749.082999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8896.170999999998,
"heapDeltaBytes": -2861100,
"heapUsedBytes": 96760404,
"domNodes": -258,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 7198.501,
"eventListeners": -68,
"totalBlockingTimeMs": 676,
"frameDurationMs": 31.450645161290325,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10015.60999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9164.934,
"heapDeltaBytes": -15056444,
"heapUsedBytes": 81551828,
"domNodes": -258,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 7421.729,
"eventListeners": -68,
"totalBlockingTimeMs": 650,
"frameDurationMs": 31.79746031746032,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9784.756000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9007.118,
"heapDeltaBytes": -16435116,
"heapUsedBytes": 82653300,
"domNodes": -258,
"jsHeapTotalBytes": 5107712,
"scriptDurationMs": 7293.3060000000005,
"eventListeners": -68,
"totalBlockingTimeMs": 755,
"frameDurationMs": 31.45594855305466,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "large-combo-open",
"durationMs": 235.19499999997606,
"styleRecalcs": 26,
"styleRecalcDurationMs": 15.649,
"layouts": 12,
"layoutDurationMs": 3.595,
"taskDurationMs": 177.371,
"heapDeltaBytes": -8048716,
"heapUsedBytes": 79186396,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.049000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 1,
"frameDurationMs": 21.209090909090925,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 208.57999999998356,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.555000000000001,
"layouts": 11,
"layoutDurationMs": 3.447,
"taskDurationMs": 154.27899999999997,
"heapDeltaBytes": -7780972,
"heapUsedBytes": 80156480,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.248999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.077777777777758,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2041.4729999999963,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6390000000000007,
"layouts": 8,
"layoutDurationMs": 2.653,
"taskDurationMs": 628.8969999999999,
"heapDeltaBytes": -1693012,
"heapUsedBytes": 76875412,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 33.120999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.748000000055,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.483000000000001,
"layouts": 8,
"layoutDurationMs": 2.4549999999999996,
"taskDurationMs": 626.4479999999999,
"heapDeltaBytes": -18115268,
"heapUsedBytes": 78552216,
"domNodes": -258,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 33.71900000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2191.8280000000436,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.535000000000001,
"layouts": 5,
"layoutDurationMs": 1.2789999999999997,
"taskDurationMs": 1451.2580000000003,
"heapDeltaBytes": -11607068,
"heapUsedBytes": 68371224,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 796.904,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.79384615384616,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2449.887999999987,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.595999999999999,
"layouts": 5,
"layoutDurationMs": 1.373,
"taskDurationMs": 1725.6460000000002,
"heapDeltaBytes": -29138792,
"heapUsedBytes": 69226656,
"domNodes": -278,
"jsHeapTotalBytes": 5406720,
"scriptDurationMs": 867.07,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.78013698630137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3636.139999999955,
"styleRecalcs": 70,
"styleRecalcDurationMs": 6.996,
"layouts": 64,
"layoutDurationMs": 10.509,
"taskDurationMs": 1726.1009999999999,
"heapDeltaBytes": -9398588,
"heapUsedBytes": 72199236,
"domNodes": -234,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 763.63,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66559633027523,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3683.2050000000436,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.282,
"layouts": 64,
"layoutDurationMs": 10.634999999999998,
"taskDurationMs": 1762.17,
"heapDeltaBytes": -10255444,
"heapUsedBytes": 72288964,
"domNodes": -254,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 783.006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.741363636363637,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2956.422000000032,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.685,
"layouts": 4,
"layoutDurationMs": 1.105,
"taskDurationMs": 1927.1919999999998,
"heapDeltaBytes": 3160604,
"heapUsedBytes": 81136924,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 944.842,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.855113636363637,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2973.873000000026,
"styleRecalcs": 44,
"styleRecalcDurationMs": 4.845999999999999,
"layouts": 5,
"layoutDurationMs": 1.2209999999999999,
"taskDurationMs": 1926.898,
"heapDeltaBytes": 2558008,
"heapUsedBytes": 80982856,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 956.7370000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.854237288135593,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2056.0769999999593,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.249000000000001,
"layouts": 7,
"layoutDurationMs": 1.9220000000000002,
"taskDurationMs": 604.4690000000002,
"heapDeltaBytes": -17606796,
"heapUsedBytes": 81173024,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 29.403,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.731000000027,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.1659999999999995,
"layouts": 7,
"layoutDurationMs": 2.145,
"taskDurationMs": 451.4419999999999,
"heapDeltaBytes": -2022048,
"heapUsedBytes": 79635388,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 30.822000000000003,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 662.2429999999895,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.831,
"layouts": 9,
"layoutDurationMs": 2.4380000000000006,
"taskDurationMs": 470.271,
"heapDeltaBytes": 3263464,
"heapUsedBytes": 80539456,
"domNodes": 0,
"jsHeapTotalBytes": 12320768,
"scriptDurationMs": 147.701,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923078,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.7979999999925,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.0489999999999995,
"layouts": 10,
"layoutDurationMs": 2.672,
"taskDurationMs": 382.403,
"heapDeltaBytes": 21646388,
"heapUsedBytes": 89008380,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 150.528,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66388888888889,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-idle",
"durationMs": 2039.4019999999955,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6190000000000007,
"layouts": 9,
"layoutDurationMs": 2.922,
"taskDurationMs": 500.235,
"heapDeltaBytes": -251456,
"heapUsedBytes": 77319596,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 8.394,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.7740000000404,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1609999999999996,
"layouts": 10,
"layoutDurationMs": 2.8949999999999996,
"taskDurationMs": 357.537,
"heapDeltaBytes": 22509940,
"heapUsedBytes": 89520420,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.823999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1969.0260000000421,
"styleRecalcs": 86,
"styleRecalcDurationMs": 16.195,
"layouts": 9,
"layoutDurationMs": 2.3620000000000005,
"taskDurationMs": 1018.6429999999999,
"heapDeltaBytes": 11655656,
"heapUsedBytes": 78587336,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 113.02499999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491525,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1961.5760000000364,
"styleRecalcs": 86,
"styleRecalcDurationMs": 17.644,
"layouts": 10,
"layoutDurationMs": 2.868,
"taskDurationMs": 891.622,
"heapDeltaBytes": 11581884,
"heapUsedBytes": 78993440,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 110.661,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.1629999999927,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.375999999999998,
"layouts": 5,
"layoutDurationMs": 16.489000000000004,
"taskDurationMs": 1017.6260000000001,
"heapDeltaBytes": 7246856,
"heapUsedBytes": 103010012,
"domNodes": 15953,
"jsHeapTotalBytes": 18227200,
"scriptDurationMs": 28.729999999999997,
"eventListeners": 3244,
"totalBlockingTimeMs": 157,
"frameDurationMs": 19.905555555555566,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8344.07200000004,
"styleRecalcs": 250,
"styleRecalcDurationMs": 18.008,
"layouts": 7,
"layoutDurationMs": 2.006,
"taskDurationMs": 5216.0109999999995,
"heapDeltaBytes": 6874180,
"heapUsedBytes": 85754924,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 2809.12,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.732865731462923,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9324.155000000019,
"styleRecalcs": 250,
"styleRecalcDurationMs": 18.543,
"layouts": 7,
"layoutDurationMs": 1.771,
"taskDurationMs": 5827.317,
"heapDeltaBytes": -13572576,
"heapUsedBytes": 83118988,
"domNodes": -258,
"jsHeapTotalBytes": 5599232,
"scriptDurationMs": 2685.585,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72585278276481,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23047.288000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22059.219999999998,
"heapDeltaBytes": -16552376,
"heapUsedBytes": 259582984,
"domNodes": -3330,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 325.52099999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.46763698630137,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 16820.35899999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15990.722,
"heapDeltaBytes": -22346500,
"heapUsedBytes": 268948432,
"domNodes": -3330,
"jsHeapTotalBytes": 15192064,
"scriptDurationMs": 250.22,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.420665499124343,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27959.001,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.16400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27556.093,
"heapDeltaBytes": -12801684,
"heapUsedBytes": 263560952,
"domNodes": -3330,
"jsHeapTotalBytes": 8900608,
"scriptDurationMs": 916.669,
"eventListeners": -651,
"totalBlockingTimeMs": 6,
"frameDurationMs": 52.63446327683615,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27959.82200000003,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.800999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27501.865,
"heapDeltaBytes": -24642548,
"heapUsedBytes": 275994632,
"domNodes": -3334,
"jsHeapTotalBytes": 9949184,
"scriptDurationMs": 883.795,
"eventListeners": -651,
"totalBlockingTimeMs": 13,
"frameDurationMs": 51.12541133455209,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 8356.199000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 72.75399999999999,
"layouts": 20,
"layoutDurationMs": 22.882000000000012,
"taskDurationMs": 8183.152,
"heapDeltaBytes": -12095192,
"heapUsedBytes": 278665500,
"domNodes": -3330,
"jsHeapTotalBytes": 18341888,
"scriptDurationMs": 147.00900000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.38722222222223,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8303.418999999962,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.781,
"layouts": 20,
"layoutDurationMs": 21.275000000000016,
"taskDurationMs": 8167.808999999998,
"heapDeltaBytes": -22472448,
"heapUsedBytes": 272866104,
"domNodes": -3330,
"jsHeapTotalBytes": 22007808,
"scriptDurationMs": 125.256,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.854696132596686,
"p95FrameDurationMs": 99.89999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7861.453999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7435.808000000002,
"heapDeltaBytes": 10110704,
"heapUsedBytes": 255383512,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.062,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.432989690721648,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11360.990000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11107.665999999997,
"heapDeltaBytes": -20270832,
"heapUsedBytes": 252217924,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 149.59599999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.660544217687075,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 465.12599999999793,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.718000000000002,
"layouts": 10,
"layoutDurationMs": 3.292,
"taskDurationMs": 129.671,
"heapDeltaBytes": 6786704,
"heapUsedBytes": 79447536,
"domNodes": 98,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.717,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 502.36599999993814,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.192,
"layouts": 12,
"layoutDurationMs": 4.909,
"taskDurationMs": 156.159,
"heapDeltaBytes": -13157972,
"heapUsedBytes": 70325996,
"domNodes": 121,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 12.015999999999998,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 470.7610000000386,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.014,
"layouts": 76,
"layoutDurationMs": 14.65,
"taskDurationMs": 423.884,
"heapDeltaBytes": 11478916,
"heapUsedBytes": 82643564,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 203.57899999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 453.34300000001804,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.331,
"layouts": 76,
"layoutDurationMs": 14.713000000000001,
"taskDurationMs": 402.899,
"heapDeltaBytes": 11083520,
"heapUsedBytes": 91242516,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 194.40200000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 490.805000000023,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.8370000000000002,
"layouts": 76,
"layoutDurationMs": 14.262,
"taskDurationMs": 455.677,
"heapDeltaBytes": -5221276,
"heapUsedBytes": 106472168,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 180.96699999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 575.0469999999268,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.712,
"layouts": 76,
"layoutDurationMs": 16.044,
"taskDurationMs": 518.815,
"heapDeltaBytes": 530436,
"heapUsedBytes": 126656148,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 209.66,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.675757575757583,
"p95FrameDurationMs": 33.30000000000018
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2278 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7c6870235487b418b4f79ebd2192ab5f450aa3b9
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.57 #21130 +/- ##
=============================================
Coverage ? 87.19%
=============================================
Files ? 2626
Lines ? 147598
Branches ? 40499
=============================================
Hits ? 128695
Misses ? 18513
Partials ? 390
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #20918 to
cloud/1.57Automatically created by backport workflow.