Repository navigation
[backport core/1.57] FE-3366 refactor(workspace): read only is_original_owner when downgrading to personal - #21119
Conversation
…ding to personal (#21031) ## Why FE-3366 (L6 A2, server-fact guardrails). `useDowngradeToPersonal.removableMembers` decided who to remove during a Team-to-personal downgrade with a client rule when no member carried `is_original_owner`: keep every `role === 'owner'` member and the current user (matched by email). That is a role-derived stand-in for a server fact (ADR-API-SERVER-FACTS-0042 rule 1). ## Root cause The fallback guarded a roster shape the backend never returns. Wei confirmed in #proj-billing (2026-10-14): a personal workspace's creator is always in `GET /api/workspace/members` with `is_original_owner: true`, and cannot be removed, demoted or leave; all 2.2M personal workspaces in prod match, with no exceptions. ## How - `removableMembers` is now every member without `is_original_owner`. The role and email fallback, and the `useCurrentUser` read it needed, are gone. - If no member is flagged, `downgradeToPersonal` refuses with the existing "not allowed" error before previewing, removing anyone or subscribing. Guessing from role would be the old derivation; removing everyone would include the caller. - The two "not allowed" throws share `rejectDowngrade()`, so the file adds no new `throw` site. - Legacy-rail role fallbacks elsewhere are untouched: Wei asked to keep those until the rail migration reaches zero workspaces. ## AS IS / TO BE No UI change for any roster the backend returns (the creator is always flagged). | Roster | AS IS | TO BE | |---|---|---| | Creator flagged (all prod personal workspaces) | removes everyone except the creator | same | | No member flagged (not produced by the backend) | removes non-owners except the caller, by role and email | refuses the downgrade; removes no one | ## Verification - `vitest run src/platform/workspace src/components/dialog src/composables/billing`: 3174 passed; the 1 failure (`SignUpForm` password schema error after blur) is unrelated to this diff. - New case: no flagged member rejects before `previewSubscribe`, `removeMember` and `subscribe`. Removing the guard fails it. - `billingSdkTelemetryOwnership.test.ts` drove the downgrade with an empty roster; it now seeds the flagged creator, matching real data. - Pre-commit `lint:server-facts`, oxlint and typecheck pass. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3360. | Item | Ticket | PR | Status | |---|---|---|---| | L6 A1 render capability reads | FE-3366 | #20805 | Merged | | **L6 A2 original owner from the server flag** | **FE-3366** | **this PR** | **In review** | | L1 restrict `receiveServerFact` | FE-3361 | #20918 | In review | | Legacy-rail role fallbacks | FE-3366 | — | After the rail migration reaches zero | ```mermaid graph LR A1["L6 A1 (PR 20805, merged)"] --> A2["L6 A2 original owner (this PR)"]:::current W["Wei: creator always flagged"] --> A2 M["Rail migration reaches zero"] -. unblocks .-> LR["Drop legacy-rail role fallbacks"] classDef current fill:#f9d71c,stroke:#333,stroke-width:2px ```
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T22:56:00.889Z",
"gitSha": "e32c4b7c97f412a252e3c8b876e33b2802d5c390",
"branch": "backport-21031-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.1780000000012,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.424000000000001,
"layouts": 9,
"layoutDurationMs": 2.6950000000000003,
"taskDurationMs": 365.40700000000004,
"heapDeltaBytes": 22148204,
"heapUsedBytes": 87590664,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.790999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2012.1749999999565,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.542,
"layouts": 9,
"layoutDurationMs": 2.544,
"taskDurationMs": 351.916,
"heapDeltaBytes": 22125856,
"heapUsedBytes": 88120516,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.427000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1967.595000000017,
"styleRecalcs": 82,
"styleRecalcDurationMs": 14.761,
"layouts": 9,
"layoutDurationMs": 2.7140000000000004,
"taskDurationMs": 931.8179999999999,
"heapDeltaBytes": 15568964,
"heapUsedBytes": 81091136,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 166.457,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.3880000000345,
"styleRecalcs": 74,
"styleRecalcDurationMs": 14.525,
"layouts": 9,
"layoutDurationMs": 2.508,
"taskDurationMs": 846.4540000000001,
"heapDeltaBytes": -7286056,
"heapUsedBytes": 68246088,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 162.24899999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.1530000000207,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.2490000000000006,
"layouts": 12,
"layoutDurationMs": 3.3569999999999998,
"taskDurationMs": 416.67900000000003,
"heapDeltaBytes": -4545036,
"heapUsedBytes": 70542352,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.183,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.4199999999619,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.75,
"layouts": 11,
"layoutDurationMs": 3.12,
"taskDurationMs": 289.816,
"heapDeltaBytes": 18766512,
"heapUsedBytes": 85086436,
"domNodes": 47,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.636000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 669.1099999999892,
"styleRecalcs": 12,
"styleRecalcDurationMs": 2.3750000000000004,
"layouts": 8,
"layoutDurationMs": 2.265,
"taskDurationMs": 504.50300000000004,
"heapDeltaBytes": 26117040,
"heapUsedBytes": 91905156,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 166.783,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 662.631000000033,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7479999999999998,
"layouts": 9,
"layoutDurationMs": 2.598,
"taskDurationMs": 483.04200000000003,
"heapDeltaBytes": 25654708,
"heapUsedBytes": 91591332,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 170.717,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1230.8480000000372,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 903.8069999999999,
"heapDeltaBytes": -13754804,
"heapUsedBytes": 81093788,
"domNodes": -212,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 73.76500000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 551,
"frameDurationMs": 33.33243243243244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1193.877999999927,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 896.777,
"heapDeltaBytes": 1255752,
"heapUsedBytes": 81459788,
"domNodes": -192,
"jsHeapTotalBytes": 13901824,
"scriptDurationMs": 72.23,
"eventListeners": -106,
"totalBlockingTimeMs": 522,
"frameDurationMs": 32.42972972972972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 859.7829999999931,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.6139999999995,
"heapDeltaBytes": -4794224,
"heapUsedBytes": 75999920,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 165.41300000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 24.759999999999984,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 865.6029999999646,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.69899999999996,
"heapDeltaBytes": -4335904,
"heapUsedBytes": 76501488,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 170.772,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11022.295999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10084.35,
"heapDeltaBytes": -3228088,
"heapUsedBytes": 84451800,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 8131.231,
"eventListeners": -68,
"totalBlockingTimeMs": 1244,
"frameDurationMs": 31.565042979942696,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9987.337999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9206.212000000001,
"heapDeltaBytes": -12843196,
"heapUsedBytes": 87234184,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 7481.964,
"eventListeners": -68,
"totalBlockingTimeMs": 834,
"frameDurationMs": 31.3528125,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8976.539000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8215.762,
"heapDeltaBytes": -24166136,
"heapUsedBytes": 75483000,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 6883.859,
"eventListeners": -68,
"totalBlockingTimeMs": 733,
"frameDurationMs": 32.252877697841726,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10102.032000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9327.79,
"heapDeltaBytes": 721792,
"heapUsedBytes": 88300260,
"domNodes": -258,
"jsHeapTotalBytes": 2486272,
"scriptDurationMs": 7565.798,
"eventListeners": -68,
"totalBlockingTimeMs": 928,
"frameDurationMs": 31.46292834890966,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 232.3030000000017,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.454999999999998,
"layouts": 12,
"layoutDurationMs": 3.4949999999999997,
"taskDurationMs": 174.22600000000003,
"heapDeltaBytes": -8198728,
"heapUsedBytes": 79485408,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 9.546,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.329999999999927,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-combo-open",
"durationMs": 229.14400000001933,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.354,
"layouts": 11,
"layoutDurationMs": 3.13,
"taskDurationMs": 172.401,
"heapDeltaBytes": -8111756,
"heapUsedBytes": 79266208,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.703000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181787,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2057.4890000000323,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4820000000000007,
"layouts": 8,
"layoutDurationMs": 2.4450000000000003,
"taskDurationMs": 655.9100000000001,
"heapDeltaBytes": -5861064,
"heapUsedBytes": 74002412,
"domNodes": -278,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 32.501999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.1919999999864,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6439999999999997,
"layouts": 8,
"layoutDurationMs": 2.489,
"taskDurationMs": 682.4540000000001,
"heapDeltaBytes": -21231176,
"heapUsedBytes": 75785296,
"domNodes": -258,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 36.371,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2456.262000000038,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5.43,
"layouts": 5,
"layoutDurationMs": 1.3020000000000003,
"taskDurationMs": 1702.4189999999999,
"heapDeltaBytes": -11511412,
"heapUsedBytes": 68163816,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 808.105,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.89452054794521,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2485.352999999918,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.0569999999999995,
"layouts": 7,
"layoutDurationMs": 1.9770000000000005,
"taskDurationMs": 1696.5970000000002,
"heapDeltaBytes": -11504724,
"heapUsedBytes": 68460240,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 834.4730000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66621621621622,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3696.401000000037,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.438,
"layouts": 64,
"layoutDurationMs": 10.612,
"taskDurationMs": 1766.6360000000002,
"heapDeltaBytes": -4668660,
"heapUsedBytes": 72274180,
"domNodes": -234,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 775.097,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66651583710407,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3557.568999999944,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.2459999999999996,
"layouts": 65,
"layoutDurationMs": 10.597999999999999,
"taskDurationMs": 1684.319,
"heapDeltaBytes": 1139924,
"heapUsedBytes": 82617604,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 755.7570000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665727699530517,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3091.8150000000537,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.581999999999999,
"layouts": 4,
"layoutDurationMs": 1.0369999999999997,
"taskDurationMs": 1974.4440000000002,
"heapDeltaBytes": 18782096,
"heapUsedBytes": 102065144,
"domNodes": 0,
"jsHeapTotalBytes": 6971392,
"scriptDurationMs": 991.593,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.033701657458565,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3066.3099999999304,
"styleRecalcs": 42,
"styleRecalcDurationMs": 4.247000000000001,
"layouts": 3,
"layoutDurationMs": 0.9650000000000002,
"taskDurationMs": 1946.8790000000001,
"heapDeltaBytes": 2900080,
"heapUsedBytes": 81599480,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 978.366,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.941988950276244,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2042.7829999999858,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.9159999999999993,
"layouts": 7,
"layoutDurationMs": 2.005000000000001,
"taskDurationMs": 623.847,
"heapDeltaBytes": -3181660,
"heapUsedBytes": 74961488,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 36.367,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.4809999999761,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.7940000000000005,
"layouts": 6,
"layoutDurationMs": 1.8380000000000003,
"taskDurationMs": 625.696,
"heapDeltaBytes": -7700888,
"heapUsedBytes": 74378732,
"domNodes": -278,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 34.16000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 661.3360000000057,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.527000000000001,
"layouts": 9,
"layoutDurationMs": 2.3629999999999995,
"taskDurationMs": 470.40700000000004,
"heapDeltaBytes": 21650788,
"heapUsedBytes": 88501104,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 149.067,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664102564102567,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.9039999999995,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.841999999999999,
"layouts": 9,
"layoutDurationMs": 2.406,
"taskDurationMs": 437.562,
"heapDeltaBytes": -1112836,
"heapUsedBytes": 76450724,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 148.84399999999997,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.1350000000111,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.5399999999999996,
"layouts": 9,
"layoutDurationMs": 2.596,
"taskDurationMs": 543.0169999999999,
"heapDeltaBytes": -245588,
"heapUsedBytes": 77104616,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 9.214000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.9450000000397,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.044,
"layouts": 9,
"layoutDurationMs": 2.707,
"taskDurationMs": 367.30699999999996,
"heapDeltaBytes": 22433128,
"heapUsedBytes": 89401900,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.891000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.8470000000111,
"styleRecalcs": 78,
"styleRecalcDurationMs": 15.599000000000002,
"layouts": 9,
"layoutDurationMs": 2.5770000000000004,
"taskDurationMs": 801.9620000000001,
"heapDeltaBytes": -6508608,
"heapUsedBytes": 71048364,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 107.601,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.2029999999922,
"styleRecalcs": 76,
"styleRecalcDurationMs": 15.254,
"layouts": 8,
"layoutDurationMs": 2.0590000000000006,
"taskDurationMs": 665.4259999999999,
"heapDeltaBytes": 10897948,
"heapUsedBytes": 77830704,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 110.292,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 969.4259999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.711,
"layouts": 5,
"layoutDurationMs": 13.706999999999997,
"taskDurationMs": 786.1309999999999,
"heapDeltaBytes": 33293160,
"heapUsedBytes": 113558364,
"domNodes": 15953,
"jsHeapTotalBytes": 11145216,
"scriptDurationMs": 36.13,
"eventListeners": 3244,
"totalBlockingTimeMs": 142,
"frameDurationMs": 20.921276595744686,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9300.358000000017,
"styleRecalcs": 249,
"styleRecalcDurationMs": 17.544,
"layouts": 6,
"layoutDurationMs": 1.8370000000000002,
"taskDurationMs": 5945.517,
"heapDeltaBytes": -29333608,
"heapUsedBytes": 67673908,
"domNodes": -278,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 2715.77,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72589928057554,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8341.110999999955,
"styleRecalcs": 250,
"styleRecalcDurationMs": 17.895,
"layouts": 7,
"layoutDurationMs": 1.9630000000000003,
"taskDurationMs": 5143.591,
"heapDeltaBytes": -10781720,
"heapUsedBytes": 68538736,
"domNodes": -278,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 2706.4759999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73293172690763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16785.71599999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15623.591999999999,
"heapDeltaBytes": -29112412,
"heapUsedBytes": 267324180,
"domNodes": -307,
"jsHeapTotalBytes": 20697088,
"scriptDurationMs": 273.007,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.54183673469388,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 23246.86500000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22813.333,
"heapDeltaBytes": -10438756,
"heapUsedBytes": 280717564,
"domNodes": -3330,
"jsHeapTotalBytes": 6803456,
"scriptDurationMs": 323.57099999999997,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.84991423670669,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27767.64200000002,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.468999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27472.018000000004,
"heapDeltaBytes": -34956796,
"heapUsedBytes": 265969640,
"domNodes": -2264,
"jsHeapTotalBytes": 10473472,
"scriptDurationMs": 862.9870000000001,
"eventListeners": -421,
"totalBlockingTimeMs": 37,
"frameDurationMs": 52.06172607879925,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 19432.592,
"styleRecalcs": 160,
"styleRecalcDurationMs": 12.548000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19040.238,
"heapDeltaBytes": -13894788,
"heapUsedBytes": 282526876,
"domNodes": -3330,
"jsHeapTotalBytes": 19386368,
"scriptDurationMs": 861.517,
"eventListeners": -651,
"totalBlockingTimeMs": 29,
"frameDurationMs": 35.59065934065935,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8191.3319999999885,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.85500000000003,
"layouts": 20,
"layoutDurationMs": 22.752999999999997,
"taskDurationMs": 8095.203000000001,
"heapDeltaBytes": 7162108,
"heapUsedBytes": 283467520,
"domNodes": -3330,
"jsHeapTotalBytes": 17289216,
"scriptDurationMs": 143.85500000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 49,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8269.105999999965,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.39399999999999,
"layouts": 20,
"layoutDurationMs": 22.69299999999999,
"taskDurationMs": 8107.962,
"heapDeltaBytes": -34827228,
"heapUsedBytes": 260232656,
"domNodes": -3330,
"jsHeapTotalBytes": 23318528,
"scriptDurationMs": 129.608,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.670718232044194,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11433.772999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11188.997999999998,
"heapDeltaBytes": 15266524,
"heapUsedBytes": 256067212,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.00300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.28831615120276,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11489.417000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11246.106999999998,
"heapDeltaBytes": -24752988,
"heapUsedBytes": 248094876,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.265,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.46013745704468,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "workflow-execution",
"durationMs": 495.0450000000046,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.244000000000002,
"layouts": 10,
"layoutDurationMs": 3.9490000000000003,
"taskDurationMs": 131.363,
"heapDeltaBytes": 6909672,
"heapUsedBytes": 80482084,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.539,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 129.48599999992894,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.798,
"layouts": 8,
"layoutDurationMs": 3.215,
"taskDurationMs": 96.32099999999998,
"heapDeltaBytes": -15609064,
"heapUsedBytes": 68171216,
"domNodes": 94,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 6.628,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.057142857142804,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 486.362999999983,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.271,
"layouts": 76,
"layoutDurationMs": 15.248,
"taskDurationMs": 428.427,
"heapDeltaBytes": 11386328,
"heapUsedBytes": 89199932,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 203.85500000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 517.7850000000035,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.016,
"layouts": 76,
"layoutDurationMs": 15.501,
"taskDurationMs": 473.587,
"heapDeltaBytes": -20917312,
"heapUsedBytes": 73856012,
"domNodes": 4,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 234.71200000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67096774193546,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 528.1719999999268,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.318,
"layouts": 76,
"layoutDurationMs": 13.48,
"taskDurationMs": 487.55899999999997,
"heapDeltaBytes": 283500,
"heapUsedBytes": 118798000,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 198.92399999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 589.7879999999986,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.182,
"layouts": 76,
"layoutDurationMs": 14.872,
"taskDurationMs": 545.899,
"heapDeltaBytes": 930960,
"heapUsedBytes": 127834608,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 226.603,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.7% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2276 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 07bebc7f81373ffdd7cb27540d3391716631a861
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21119 +/- ##
=============================================
- Coverage 84.12% 84.11% -0.01%
=============================================
Files 2840 2840
Lines 158012 158012
Branches 38427 37995 -432
=============================================
- Hits 132922 132917 -5
- Misses 24701 24706 +5
Partials 389 389
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
dante01yoon
left a comment
There was a problem hiding this comment.
Diff matches #21031 line for line.
|
Taking over the release refresh under program row oploop-936c. I reviewed the actual three-file backport; I will fast-forward the bot-owned branch by merging the current core/1.57 tip only (no semantic edits), then rely on fresh exact-head CI before any merge. |
(cherry picked from commit 32cd329)
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head re-review after CI repair: the product delta remains the previously reviewed three-file FE-3366 backport. The only added delta is the already-landed two-file LCOV packager fix from main (32cd329), with its regression proving line coverage is retained while duplicate function metadata is tolerated. Focused package test passed 11/11; commit and push gates passed. No actionable finding.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 6 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 3 |
| 🟢 Low | 2 |
| ⚪ Nit | 1 |
Panel: 6/6 reviewers contributed findings.
| # check. `corrupt` is paired with `inconsistent` because lcov reports both for | ||
| # this single condition. | ||
| lcov "${ADD_ARGS[@]}" -o "$COVERAGE_DIR/coverage.lcov" \ | ||
| --ignore-errors inconsistent,corrupt |
There was a problem hiding this comment.
🟡 Medium — --ignore-errors inconsistent,corrupt turns off both whole lcov error classes for every shard, not just the duplicate nested-function-name case. A truncated or malformed shard tracefile, such as one from a shard that died partway or a damaged artifact download, would now merge with records silently dropped. If the matrix was green, it would still be published as complete=true and become the Codecov and trend baseline. Scope the workaround instead: pre-filter or normalize the duplicate FN/FNDA records before merging, or compare per-shard SF/LH totals against the merged totals so lost data fails loudly. Raised by 6 of 6 reviewers (claude-opus-5-5-xhigh adversarial, gpt-5.6-sol-xhigh adversarial, kimi-k3-high adversarial, claude-opus-5-5-xhigh edge-case, gpt-5.6-sol-xhigh edge-case, kimi-k3-high edge-case).
| (m) => m.role !== 'owner' && m.email.toLowerCase() !== email | ||
| ) | ||
| }) | ||
| const removableMembers = computed(() => |
There was a problem hiding this comment.
🟡 Medium — With the role/email fallback removed, removableMembers returns every member when none is flagged isOriginalOwner, including owners and the current user, so hasOtherMembers becomes true. Only downgradeToPersonal has the new guard, and previewDowngrade does not. The billing dialog can therefore open the typed remove-members confirmation listing the owner or the user themselves, then reject with notAllowed only after the user confirms. Fail closed in the data instead: return [] or an explicit unresolved state from the computed when no owner is flagged, and/or run the same check in previewDowngrade. Raised by 4 of 6 reviewers (claude-opus-5-5-xhigh adversarial, kimi-k3-high adversarial, claude-opus-5-5-xhigh edge-case, kimi-k3-high edge-case).
| } | ||
|
|
||
| function ensureOriginalOwnerListed(): void { | ||
| if (!members.value.some((m) => m.isOriginalOwner)) rejectDowngrade() |
There was a problem hiding this comment.
🟡 Medium — ensureOriginalOwnerListed needs the raw isOriginalOwner flag on a loaded row. Reviewers note that the team workspace store's originalOwnerId falls back to the earliest-joined owner when the flag is missing, and that fallback drives isCurrentUserOriginalOwner and the non-cloud canDowngradeToPersonal permission. On those payloads, or while members are still empty or only partially loaded, the UI offers the downgrade but every attempt fails with the same subscription.downgrade.notAllowed text as a real authorization denial, so a data problem looks like a permission problem. Resolve the original owner the same way the store does, or surface a distinct error for missing owner data. Raised by 5 of 6 reviewers (claude-opus-5-5-xhigh adversarial, kimi-k3-high adversarial, claude-opus-5-5-xhigh edge-case, gpt-5.6-sol-xhigh edge-case, kimi-k3-high edge-case).
| # check. `corrupt` is paired with `inconsistent` because lcov reports both for | ||
| # this single condition. | ||
| lcov "${ADD_ARGS[@]}" -o "$COVERAGE_DIR/coverage.lcov" \ | ||
| --ignore-errors inconsistent,corrupt |
There was a problem hiding this comment.
🟢 Low — Only the merge call gets the error allowance. The later lcov --remove (which only has --ignore-errors unused) and genhtml re-read the merged tracefile and run the same consistency checks. If lcov writes the duplicate or mismatched function records through to the output, the job will still abort under set -e, just one step later. Confirm against a real affected tracefile, or apply the same allowance to those calls. Raised by 2 of 6 reviewers (claude-opus-5-5-xhigh adversarial, claude-opus-5-5-xhigh edge-case).
| expect(result.output).not.toContain('::warning::') | ||
| }) | ||
|
|
||
| it('preserves line coverage when function metadata is inconsistent', () => { |
There was a problem hiding this comment.
🟢 Low — This test says it covers inconsistent function metadata, but the fixture has no FN/FNDA records, and the fake lcov only checks that the literal --ignore-errors inconsistent,corrupt string is present. That makes it a change detector: it would pass even if real lcov still failed on the duplicate inner_clicked case. It also exits 0 for --remove before checking anything, so the downstream steps are never tested. Add a fixture with a duplicate function name at different lines and assert the merged line data. Raised by 1 of 6 reviewers (claude-opus-5-5-xhigh edge-case).
| confirmedChargeCents?: number | ||
| ): Promise<DowngradeToPersonalResult | null> { | ||
| ensureCanDowngrade() | ||
| ensureOriginalOwnerListed() |
There was a problem hiding this comment.
⚪ Nit — ensureOriginalOwnerListed() throws before the try/catch that clears activeTelemetryAttempt. Consider a retry after ReactivationConfirmationRequiredError where the members list was refreshed without a flag. That throw leaves the earlier started attempt open with no failed event, and the next call reuses its stale data. ensureCanDowngrade already had this gap, and this change adds a second throw path into it. Raised by 1 of 6 reviewers (claude-opus-5-5-xhigh edge-case).
Backport of #21031 to
core/1.57Automatically created by backport workflow.