Repository navigation
feat(website): move model pages to /hub/models with one 308 from every old URL (step B of 2) - #19420
MaanilVerma wants to merge 12 commits into
Conversation
Every redirect now lives in src/config/redirects.ts. vercel.json is generated from it (pnpm --filter @comfyorg/website sync:redirects) and Astro's redirect map is derived from it, so the two can no longer disagree. A test fails when vercel.json drifts, a destination is itself a source, a source repeats, or an internal destination lacks its trailing slash. The Astro-only entries and the 12 supported-models alias pages now answer with a real 308 on Vercel instead of a 200 meta-refresh page, and both slash forms of every source redirect.
/minimax/ had 7.6k clicks in the 90 days before it moved to /minimax-h3/. A 307 is not a canonical signal, so that equity never transferred. The redirects test encoded the temporary status on purpose; it now asserts 308.
- Sources must be plain literal paths, so a generated slug can't smuggle a path-to-regexp pattern into vercel.json. - A row whose slash form is a page stays out of Astro's map, since its stub would overwrite that page. - Both emitters read the marker fields by definedness. - The test derives MiniMax, Enterprise and Pricing paths from routes.ts. - sync:redirects validates vercel.json before rewriting it.
Derives a /hub/models/<model-task>/ slug for each of the 148 model pages and each of the 212 aliases from the display name. Nothing reads the map yet; the switch-over uses it later.
… maanil/fe-2972-hub-url-switch
…' into maanil/fe-2972-hub-url-switch
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌐 Website E2ECaution Some tests failed.
Warning 1 non-screenshot failure — these require manual review. 🎭 Playwright: ❌ 2158 passed, 1 failed❌ Failed Tests📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🔗 Website PreviewWebsite Preview: https://comfy-website-preview-pr-19420.vercel.app Models is built and gated by PostHog (workshop-enabled), using staging Cloud. This commit: https://website-frontend-88o0wmu90-comfyui.vercel.app Last updated: 2026-09-29T13:13:05Z for 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (80 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3eb6982714a3a042de8208e4e225fb3bf66386f0
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T13:23:19.004Z",
"gitSha": "874338387183bac0259667b54d5f6e94b5a0c574",
"branch": "maanil/fe-2972-hub-url-switch",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.4860000000049,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.925,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 281.90999999999997,
"heapDeltaBytes": -22224496,
"heapUsedBytes": 76410404,
"domNodes": -228,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 6.536999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2017.1970000000101,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.733,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.117,
"heapDeltaBytes": -11782344,
"heapUsedBytes": 67375052,
"domNodes": -228,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 7.102,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1769.5019999999886,
"styleRecalcs": 72,
"styleRecalcDurationMs": 17.019,
"layouts": 12,
"layoutDurationMs": 4.348999999999999,
"taskDurationMs": 592.931,
"heapDeltaBytes": -5008200,
"heapUsedBytes": 75008452,
"domNodes": -230,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 125.858,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.8247619047619,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1696.2730000000192,
"styleRecalcs": 71,
"styleRecalcDurationMs": 15.582,
"layouts": 12,
"layoutDurationMs": 4.213,
"taskDurationMs": 525.4590000000001,
"heapDeltaBytes": -5118624,
"heapUsedBytes": 74317484,
"domNodes": -228,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 107.71300000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.029000000011,
"styleRecalcs": 32,
"styleRecalcDurationMs": 7.536999999999999,
"layouts": 6,
"layoutDurationMs": 1.05,
"taskDurationMs": 199.88700000000003,
"heapDeltaBytes": 1793292,
"heapUsedBytes": 81817020,
"domNodes": 53,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 8.175999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.0490000000368,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.411999999999999,
"layouts": 6,
"layoutDurationMs": 1.1049999999999998,
"taskDurationMs": 238.21800000000002,
"heapDeltaBytes": 1841520,
"heapUsedBytes": 81528568,
"domNodes": 53,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.774000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384617,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 434.7190000000296,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.7419999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.72299999999996,
"heapDeltaBytes": 17956940,
"heapUsedBytes": 97379228,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 104.76299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 460.0730000000226,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.483999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 291.851,
"heapDeltaBytes": 18246752,
"heapUsedBytes": 97630900,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 108.048,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 875.6840000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.614,
"heapDeltaBytes": 9549200,
"heapUsedBytes": 86371112,
"domNodes": 0,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 38.90800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 268,
"frameDurationMs": 25.979411764705887,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 875.0070000000392,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.03499999999997,
"heapDeltaBytes": 6497392,
"heapUsedBytes": 83447964,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 39.959,
"eventListeners": 0,
"totalBlockingTimeMs": 267,
"frameDurationMs": 25.976470588235287,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.2539999999822,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 265.12400000000014,
"heapDeltaBytes": 14597552,
"heapUsedBytes": 88626976,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 95.313,
"eventListeners": 0,
"totalBlockingTimeMs": 87,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 689.2100000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 253.069,
"heapDeltaBytes": 15356976,
"heapUsedBytes": 89069204,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 86.76299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 84,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5862.663999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4818.7429999999995,
"heapDeltaBytes": 11568820,
"heapUsedBytes": 92336424,
"domNodes": 0,
"jsHeapTotalBytes": -16777216,
"scriptDurationMs": 3880.096,
"eventListeners": 0,
"totalBlockingTimeMs": 33,
"frameDurationMs": 20.382229965156796,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5896.385000000009,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7629999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5091.572,
"heapDeltaBytes": -453120,
"heapUsedBytes": 80493964,
"domNodes": 0,
"jsHeapTotalBytes": -12058624,
"scriptDurationMs": 4074.0610000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 11,
"frameDurationMs": 22.77915057915058,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5678.465999999986,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.5690000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4631.517000000001,
"heapDeltaBytes": -9264080,
"heapUsedBytes": 71809720,
"domNodes": 0,
"jsHeapTotalBytes": -17039360,
"scriptDurationMs": 3552.5009999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.32993197278911,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5954.229999999996,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.3280000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5106.121,
"heapDeltaBytes": -9074288,
"heapUsedBytes": 72055064,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 3970.8579999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 38,
"frameDurationMs": 21.098226950354608,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2030.2670000000376,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.880000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 350.98600000000005,
"heapDeltaBytes": -37158144,
"heapUsedBytes": 82486488,
"domNodes": -228,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 27.373,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2031.562000000008,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.02,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.50600000000003,
"heapDeltaBytes": -36704424,
"heapUsedBytes": 82903512,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 23.955000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2126.9159999999943,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.313,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1104.5360000000003,
"heapDeltaBytes": -37380496,
"heapUsedBytes": 82840844,
"domNodes": -228,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 554.3939999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665354330708663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2118.346000000031,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.106,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1050.9140000000002,
"heapDeltaBytes": -33107032,
"heapUsedBytes": 86960136,
"domNodes": -228,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 541.912,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666141732283464,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-zoom",
"durationMs": 3094.040000000007,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.67,
"layouts": 60,
"layoutDurationMs": 15.354000000000001,
"taskDurationMs": 1210.564,
"heapDeltaBytes": 8540256,
"heapUsedBytes": 72634108,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 545.9620000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665591397849465,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3123.60799999999,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.559,
"layouts": 60,
"layoutDurationMs": 15.470999999999998,
"taskDurationMs": 1232.1029999999998,
"heapDeltaBytes": 8513060,
"heapUsedBytes": 72337172,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 551.357,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665425531914895,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2204.8149999999964,
"styleRecalcs": 46,
"styleRecalcDurationMs": 7.077000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1302.168,
"heapDeltaBytes": 21382396,
"heapUsedBytes": 85590680,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 650.114,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793129770992362,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "legacy-node-drag",
"durationMs": 2316.8229999999994,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.847999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1362.3919999999998,
"heapDeltaBytes": 21335336,
"heapUsedBytes": 85665884,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 708.496,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.90875912408759,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2018.8190000000077,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.157000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 303.50699999999995,
"heapDeltaBytes": 21350820,
"heapUsedBytes": 83555148,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 19.860000000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.1859999999906,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.12399999999997,
"heapDeltaBytes": 21333508,
"heapUsedBytes": 83710948,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.922,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 431.9409999999948,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 256.59700000000004,
"heapDeltaBytes": 12416044,
"heapUsedBytes": 93353536,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 93.278,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384603,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 430.9690000000046,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.1659999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 275.923,
"heapDeltaBytes": 12378544,
"heapUsedBytes": 93699348,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 99.83600000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2010.3819999999928,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.703,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.09000000000003,
"heapDeltaBytes": -2600924,
"heapUsedBytes": 79269508,
"domNodes": -246,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6.199000000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.1879999999946,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.064000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 264.19,
"heapDeltaBytes": -2348044,
"heapUsedBytes": 79259740,
"domNodes": -244,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 5.121000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.0349999999812,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.950000000000003,
"layouts": 16,
"layoutDurationMs": 5.563999999999999,
"taskDurationMs": 557.514,
"heapDeltaBytes": -18359576,
"heapUsedBytes": 63133352,
"domNodes": -215,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 88.79799999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262138,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.9860000000049,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.016999999999996,
"layouts": 16,
"layoutDurationMs": 5.4479999999999995,
"taskDurationMs": 525.592,
"heapDeltaBytes": -4680912,
"heapUsedBytes": 77128776,
"domNodes": -244,
"jsHeapTotalBytes": -1048576,
"scriptDurationMs": 82.99199999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 841.0650000000146,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.919,
"layouts": 5,
"layoutDurationMs": 8.040000000000003,
"taskDurationMs": 597.6899999999999,
"heapDeltaBytes": 21726648,
"heapUsedBytes": 104063196,
"domNodes": 13667,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 21.365999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 64,
"frameDurationMs": 18.938636363636366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8178.4819999999745,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.829,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3899.9640000000004,
"heapDeltaBytes": -36304268,
"heapUsedBytes": 82944684,
"domNodes": -228,
"jsHeapTotalBytes": -659456,
"scriptDurationMs": 1876.3059999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665918367346936,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8230.829999999969,
"styleRecalcs": 252,
"styleRecalcDurationMs": 41.1,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4157.851,
"heapDeltaBytes": -41336764,
"heapUsedBytes": 78282740,
"domNodes": -228,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 1946.529,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666125760649088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 11618.089999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10924.324999999999,
"heapDeltaBytes": -46437268,
"heapUsedBytes": 182372564,
"domNodes": -3045,
"jsHeapTotalBytes": 5230592,
"scriptDurationMs": 162.712,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.38576449912126,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 11875.65699999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11728.065,
"heapDeltaBytes": -8801788,
"heapUsedBytes": 164636192,
"domNodes": -8049,
"jsHeapTotalBytes": -15204352,
"scriptDurationMs": 164.68,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.827710843373495,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 12924.387999999964,
"styleRecalcs": 65,
"styleRecalcDurationMs": 15.171000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12748.607999999998,
"heapDeltaBytes": -21193652,
"heapUsedBytes": 193380188,
"domNodes": -8053,
"jsHeapTotalBytes": -10088448,
"scriptDurationMs": 659.734,
"eventListeners": -14923,
"totalBlockingTimeMs": 17,
"frameDurationMs": 24.95086705202312,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 13923.555999999962,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.49499999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13765.352000000003,
"heapDeltaBytes": -4620072,
"heapUsedBytes": 191733828,
"domNodes": -3045,
"jsHeapTotalBytes": 15380480,
"scriptDurationMs": 615.756,
"eventListeners": -14906,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.67738095238095,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4581.938999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.76199999999998,
"layouts": 20,
"layoutDurationMs": 24.226999999999997,
"taskDurationMs": 4555.2210000000005,
"heapDeltaBytes": 4137684,
"heapUsedBytes": 190322220,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 76.60700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 78,
"frameDurationMs": 28.615094339622637,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 4586.384000000066,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.273999999999994,
"layouts": 20,
"layoutDurationMs": 26.044000000000004,
"taskDurationMs": 4572.594999999999,
"heapDeltaBytes": -574448,
"heapUsedBytes": 187023032,
"domNodes": -8049,
"jsHeapTotalBytes": 18087936,
"scriptDurationMs": 75.36800000000002,
"eventListeners": -3,
"totalBlockingTimeMs": 73,
"frameDurationMs": 29.568387096774195,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6694.262999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6484.155999999999,
"heapDeltaBytes": -11762680,
"heapUsedBytes": 177817824,
"domNodes": 0,
"jsHeapTotalBytes": -31457280,
"scriptDurationMs": 102.964,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.219245283018875,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6071.636000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5979.73,
"heapDeltaBytes": 1902620,
"heapUsedBytes": 197876732,
"domNodes": 0,
"jsHeapTotalBytes": -24641536,
"scriptDurationMs": 87.55499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.043478260869566,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 131.746000000021,
"styleRecalcs": 9,
"styleRecalcDurationMs": 11.972000000000001,
"layouts": 3,
"layoutDurationMs": 1.4149999999999998,
"taskDurationMs": 116.617,
"heapDeltaBytes": -16979968,
"heapUsedBytes": 80326344,
"domNodes": 115,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 9.742999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67142857142861,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 439.4049999999652,
"styleRecalcs": 17,
"styleRecalcDurationMs": 14.628,
"layouts": 2,
"layoutDurationMs": 0.583,
"taskDurationMs": 166.15000000000003,
"heapDeltaBytes": -43244184,
"heapUsedBytes": 54302176,
"domNodes": -142,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 9.441,
"eventListeners": -52,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 491.8930000000046,
"styleRecalcs": 78,
"styleRecalcDurationMs": 91.08,
"layouts": 76,
"layoutDurationMs": 19.944,
"taskDurationMs": 461.75500000000005,
"heapDeltaBytes": -13609044,
"heapUsedBytes": 73750792,
"domNodes": 76,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 150.221,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 425.01900000002024,
"styleRecalcs": 78,
"styleRecalcDurationMs": 82.677,
"layouts": 76,
"layoutDurationMs": 17.821,
"taskDurationMs": 396.617,
"heapDeltaBytes": 13140092,
"heapUsedBytes": 90126224,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 130.278,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 967.6430000000664,
"styleRecalcs": 78,
"styleRecalcDurationMs": 233.083,
"layouts": 76,
"layoutDurationMs": 24.181,
"taskDurationMs": 955.9909999999999,
"heapDeltaBytes": 4636292,
"heapUsedBytes": 132174924,
"domNodes": -7945,
"jsHeapTotalBytes": -3973120,
"scriptDurationMs": 237.451,
"eventListeners": -1228,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1088.6039999999184,
"styleRecalcs": 78,
"styleRecalcDurationMs": 271.357,
"layouts": 76,
"layoutDurationMs": 26.933,
"taskDurationMs": 1072.768,
"heapDeltaBytes": -2349476,
"heapUsedBytes": 125249812,
"domNodes": -7943,
"jsHeapTotalBytes": -3186688,
"scriptDurationMs": 295.867,
"eventListeners": -1249,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.18593750000001,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageNote The shard matrix did not pass, so these totals cannot be confirmed comparable with a whole merge.
Top 10 files by uncovered lines
|
|
Reduce the counted diff or split the PR, then re-apply the |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## maanil/fe-2986-models-url-registry #19420 +/- ##
======================================================================
- Coverage 84.23% 84.13% -0.11%
======================================================================
Files 3195 3186 -9
Lines 155707 154916 -791
Branches 40377 41912 +1535
======================================================================
- Hits 131167 130334 -833
- Misses 22880 22920 +40
- Partials 1660 1662 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 63 files with indirect coverage changes 🚀 New features to boost your workflow:
|
QA
The Vercel preview serves |
…ry' into maanil/fe-2972-hub-url-switch
Summary
Model pages move from
/models/<old-slug>/to/hub/models/<new-slug>/, using the approved table from #19369. Every old address answers with one 308 straight to its final page.Stacked on #19386; also merges #19369 and #19359, so merge those first.
Fixes FE-2972 (step B of 2): https://linear.app/comfyorg/issue/FE-2972
Changes
/hub/models/. Workflow pages, apps, the showcase and thepage.json/catalogue.jsondata files stay under/models./hub/modelsas the hub, each new slug as a model page, and/models, all 148 old slugs and all 212 aliases asaliasentries that point at their final page.siteRedirectsgets 361 rows built frommodel-urls.ts(722 Vercel rules, both slash forms).vercel.jsonnow has 793 redirects plus 4 headers, well under the 2,048 limit. The old model pages and the 212 meta-refresh alias pages are no longer built.routes.workshop(/hub/models/, used by tags, nav and back links), the platform gallery cards, the/hub/models.mdtwin and llms.txt. Canonicals and the sitemap follow the built path./models/<slug>address.newSlugwhen a display name changes, only new pages get new slugs, and a new page can't take a published slug.model_sluganalytics, the onboardingmodel=value and form drafts still useprovider--model--task.noindexis unchanged.Review Focus
[slug].astrois mounted at both/hub/models/[slug](model pages) and/models/[...slug](workflow pages). It usesroutePatternto choose which paths to build.astro dev/previewreturn 404 at old model URLs. The e2e specs now use the new addresses.