Repository navigation
[backport core/1.54] fix(agent): use a neutral color palette and lighter text in the agent panel - #18793
Conversation
… panel (#18052) ## Summary The agent side panel uses neutral colors and lighter text now. Linear: [DES-1043](https://linear.app/comfyorg/issue/DES-1043/des-use-a-more-neutral-color-palette-in-agent-panel) Taken over from @uytieu with his go-ahead in #agent-eng. Rebased onto main, and three things changed from his version. Details under **Handover changes** below. ## Changes - **What**: - The notice box had a blue line on the left and a blue icon. Both are neutral now. - The welcome screen had a yellow "C" logo in a box with a purple outline. The logo and the box are gone. That removes the panel's only raw-palette usage: `border-plum-600`, `bg-ink-700`, `text-brand-yellow`. - The workflow menu used the same yellow "C" to mark your choice. It uses a standard check mark now. - Hardcoded label weights in the panel drop to normal weight. - One menu did not receive the panel styles. It receives them now. Buttons keep their slightly bold text. That weight comes from `button.variants.ts`, which the whole product uses, not from this panel. [DES-1095](https://linear.app/comfyorg/issue/DES-1095/des-button-base-weight-is-font-medium-revisit-as-design-system-default) recorded that decision and closed it as intentional. ## Handover changes **1. The notice rule uses a background token, not a text token.** It was `before:bg-muted-foreground`. That is the secondary-text role (light `#494a50`, dark `#8a8a8a`), and filling a 4px rule with it inverts the role. `docs/guidance/design-standards.md` asks for the semantic role rather than whichever value lands right. It is `before:bg-muted-background` now, the neutral surface role already used as both a fill and a border elsewhere in `src` (light `#a0a0a0`, dark `#55565e`). No new token: design-standards says not to name one for the first component that wants it. **2. The weight pins are deleted, not restated.** Every one of those sites is a `p`/`span`/`div` with no weight-setting ancestor, so `font-normal` renders identically to no class at all. It only pins the value at the call site. Two `font-medium` labels that main's refactor moved out from under the original sweep are gone the same way, which finishes the DES-1043 checkbox. `font-normal` on a Button or a heading is load-bearing and was left alone: `button.variants.ts` bakes `font-medium` into the base class, and Tailwind Preflight is disabled host-wide so an `h2` still renders UA bold. The panel keeps about twenty of those. **3. Font smoothing is out of this PR, on scope grounds only.** `-webkit-font-smoothing: antialiased` was scoped to `:where(#agent-panel-root, .agent-scope)`. It reads better and should land, but there is no font-smoothing declaration anywhere else in the repo, so panel-scoped would make the agent panel the only surface rendering text differently from the rest of the product. That is a product-wide typography call. Parked in **[DES-1205](https://linear.app/comfyorg/issue/DES-1205)** with two ways to land it, whichever @uytieu and design prefer: a separate PR putting it in `packages/design-system/src/css/base.css` with a visual pass over high-traffic surfaces, or folding it into the design-system work Alex Tov and Alex Brown are running. Nothing is blocked on it. One note for that visual pass: grayscale AA thins strokes and change 2 drops this panel a weight step, so the two stack at `text-xs` and `text-[11px]/4` here. Not an argument against smoothing, just the pairing to look at first. ## Review Focus - `RunNoticeBanner` now has its own story in both themes. That is the surface this PR recolors, and #18693 rewrites the same markup to add a target-following context, so it earns a baseline of its own. - **Chromatic does not run on this PR.** `ci-tests-storybook.yaml` gates `chromatic-deployment` on `startsWith(github.head_ref, 'version-bump-')`, deliberately, since #5167. So no ordinary PR gets a visual diff, and Uy's original version of this change had no visual check either. `storybook-build` passing only means Storybook compiles. The new story starts paying off at the next version bump. ## Verification Chromatic dispatched manually on a throwaway branch came back `Snapshot quota reached`, so it compared nothing. Diffed the two Storybook builds locally instead, Uy's rebased state against this one, across all 42 shared agent stories in both themes. | | | |---|---| | Identical | 78 of 84 comparisons | | Different | the notice rule only, 352 px at a 4x90 box, in all three `AgentPanel` stories, both themes, byte-identical across two runs | Six more stories flagged on the first pass and were ruled out. `AgentMessage` composing/streaming and `ConsentCard` also differ when a build is diffed **against itself**, so they are animation phase. `AttachmentChip Uploading` and `AgentEntryButton Inviting` were stable across runs but come back byte-identical once `animation: none` is injected, and their sources are unchanged between the two commits. Every weight-pin deletion is a pixel-exact no-op. The only thing that moved is the rule. - The welcome screen is 64 pixels shorter. Check that the space above the greeting still looks correct. - Open the workflow menu. Check that the check mark reads as a choice. - The commits are separate on purpose. Any one can be dropped alone. ## Still blue, not in scope here Two `primary-background` usages survive in the panel and are worth a separate design call rather than a silent change: - `components/agent/composer/WorkflowSelectorChip.vue` — the blue dot marking the chosen workflow, the same signal as the check mark this PR de-yellowed. - `components/agent/message/MarkdownStream.vue` — link color in agent replies. (`crdt/CrdtDevPanel.vue` has four more. Dev-only, out of scope.) ## Screenshots The notice rule, cropped from the `AgentPanel` story in both themes with animations frozen. `muted-foreground` on the left, `muted-background` on the right.  Uy's original panel shot, which predates the token change. Accurate for the logo removal and the check mark, not for the rule color.  --------- Co-authored-by: bymyself <cbyrne@comfy.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎭 Playwright: ✅ 1952 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T10:47:35.167Z",
"gitSha": "952981d167b21ad1c0dd06a2b3cb4784b87679dc",
"branch": "backport-18052-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2072.65000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.831,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.416,
"heapDeltaBytes": 2378280,
"heapUsedBytes": 73330288,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.520999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2035.5019999999513,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.313,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.9039999999999,
"heapDeltaBytes": 1169608,
"heapUsedBytes": 71442916,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 9.766,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2123.184999999978,
"styleRecalcs": 79,
"styleRecalcDurationMs": 40.638999999999996,
"layouts": 14,
"layoutDurationMs": 7.45,
"taskDurationMs": 1069.0539999999999,
"heapDeltaBytes": 5718704,
"heapUsedBytes": 76998916,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 189.916,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1892.0840000000112,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.598999999999997,
"layouts": 14,
"layoutDurationMs": 3.6110000000000007,
"taskDurationMs": 897.3370000000001,
"heapDeltaBytes": -7691700,
"heapUsedBytes": 62720204,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 166.05999999999997,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1712.949999999978,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.217000000000002,
"layouts": 6,
"layoutDurationMs": 1.279,
"taskDurationMs": 391.88800000000003,
"heapDeltaBytes": 4389688,
"heapUsedBytes": 74400856,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.412999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1662.9590000000007,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.979000000000001,
"layouts": 6,
"layoutDurationMs": 1.097,
"taskDurationMs": 360.48,
"heapDeltaBytes": 4506552,
"heapUsedBytes": 74979372,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.290000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 645.9370000000035,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.079000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.15799999999996,
"heapDeltaBytes": -7529388,
"heapUsedBytes": 63228316,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 160.28699999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 643.2609999999954,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.975000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.69899999999996,
"heapDeltaBytes": -7814204,
"heapUsedBytes": 63228832,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 160.40699999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2031.4429999999675,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.516999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.5029999999999,
"heapDeltaBytes": 4841456,
"heapUsedBytes": 81516128,
"domNodes": -280,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 33.016000000000005,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.1789999999191,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.491000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.6590000000001,
"heapDeltaBytes": -15790660,
"heapUsedBytes": 87438944,
"domNodes": -271,
"jsHeapTotalBytes": -851968,
"scriptDurationMs": 39.22700000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2351.0329999999726,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.728000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1682.571,
"heapDeltaBytes": 8023620,
"heapUsedBytes": 85451960,
"domNodes": -273,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 827.2239999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2364.8429999999507,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.414999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1746.758,
"heapDeltaBytes": 3275416,
"heapUsedBytes": 80622212,
"domNodes": -278,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 880.51,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3723.2040000000097,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.980999999999996,
"layouts": 60,
"layoutDurationMs": 12.036999999999999,
"taskDurationMs": 1790.3480000000002,
"heapDeltaBytes": 8353996,
"heapUsedBytes": 76414724,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 805.8219999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3500.4450000000134,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.600000000000001,
"layouts": 60,
"layoutDurationMs": 11.544,
"taskDurationMs": 1701.2990000000002,
"heapDeltaBytes": 8035636,
"heapUsedBytes": 76420292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 786.818,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3159.7020000000384,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2080.666,
"heapDeltaBytes": 11738688,
"heapUsedBytes": 93425440,
"domNodes": -282,
"jsHeapTotalBytes": -995328,
"scriptDurationMs": 991.871,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3089.7919999999885,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.7159999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1909.642,
"heapDeltaBytes": 18449044,
"heapUsedBytes": 86726888,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 951.605,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2064.521999999954,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.843999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 647.525,
"heapDeltaBytes": 8497692,
"heapUsedBytes": 85971380,
"domNodes": -276,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 35.31899999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2059.541999999965,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.3889999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 635.0760000000001,
"heapDeltaBytes": 5354032,
"heapUsedBytes": 82838812,
"domNodes": -277,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 36.806000000000004,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 637.9720000000475,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.897,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.945,
"heapDeltaBytes": 14621116,
"heapUsedBytes": 86585896,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 144.90900000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 616.4469999999937,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.335,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.56800000000004,
"heapDeltaBytes": 13863096,
"heapUsedBytes": 86367244,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 146.061,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.795000000021,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.567999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 520.609,
"heapDeltaBytes": 2139184,
"heapUsedBytes": 75379436,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.192000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.139999999969,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.889999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.51400000000007,
"heapDeltaBytes": -12754560,
"heapUsedBytes": 60390264,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.491999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.6979999999803,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.017000000000003,
"layouts": 18,
"layoutDurationMs": 4.4190000000000005,
"taskDurationMs": 827.252,
"heapDeltaBytes": 7611320,
"heapUsedBytes": 80914292,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 110.648,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1726.030000000037,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.830000000000002,
"layouts": 18,
"layoutDurationMs": 4.631,
"taskDurationMs": 832.322,
"heapDeltaBytes": -8290244,
"heapUsedBytes": 64209332,
"domNodes": -296,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 113.72900000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.667999999992,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.461999999999996,
"layouts": 15,
"layoutDurationMs": 16.114,
"taskDurationMs": 973.4820000000002,
"heapDeltaBytes": -5237420,
"heapUsedBytes": 85905124,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 33.120000000000005,
"eventListeners": 2385,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8823.662000000013,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.083000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5968.8189999999995,
"heapDeltaBytes": 23743908,
"heapUsedBytes": 89397012,
"domNodes": -268,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 2782.644,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8993.381999999998,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.001000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6158.251,
"heapDeltaBytes": 14883264,
"heapUsedBytes": 91061068,
"domNodes": -283,
"jsHeapTotalBytes": 3268608,
"scriptDurationMs": 2861.137,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17311.417000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16835.78,
"heapDeltaBytes": -45603984,
"heapUsedBytes": 178623792,
"domNodes": -8068,
"jsHeapTotalBytes": -15269888,
"scriptDurationMs": 280.331,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17260.033999999905,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16730.69,
"heapDeltaBytes": -59188116,
"heapUsedBytes": 179269828,
"domNodes": -8068,
"jsHeapTotalBytes": -17215488,
"scriptDurationMs": 285.877,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20905.703000000016,
"styleRecalcs": 157,
"styleRecalcDurationMs": 17.526000000000042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20620.342,
"heapDeltaBytes": -35499804,
"heapUsedBytes": 182543856,
"domNodes": -8068,
"jsHeapTotalBytes": -9711616,
"scriptDurationMs": 910.9259999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 19,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20720.33399999998,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.41799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20303.991,
"heapDeltaBytes": -49593468,
"heapUsedBytes": 182606656,
"domNodes": -8068,
"jsHeapTotalBytes": -16429056,
"scriptDurationMs": 889.903,
"eventListeners": -14931,
"totalBlockingTimeMs": 180,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6302.864999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.35199999999998,
"layouts": 20,
"layoutDurationMs": 22.38000000000001,
"taskDurationMs": 6215.801999999999,
"heapDeltaBytes": -40891504,
"heapUsedBytes": 184391084,
"domNodes": -8068,
"jsHeapTotalBytes": 10125312,
"scriptDurationMs": 111.74899999999998,
"eventListeners": -14927,
"totalBlockingTimeMs": 447,
"frameDurationMs": 18.33333333333327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6298.22200000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.62199999999997,
"layouts": 20,
"layoutDurationMs": 22.232000000000003,
"taskDurationMs": 6208.267999999999,
"heapDeltaBytes": -29744508,
"heapUsedBytes": 193126248,
"domNodes": -8068,
"jsHeapTotalBytes": 16244736,
"scriptDurationMs": 113.66299999999998,
"eventListeners": -14927,
"totalBlockingTimeMs": 400,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8739.305000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8458.839000000002,
"heapDeltaBytes": 6688784,
"heapUsedBytes": 176662620,
"domNodes": 0,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 171.821,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8757.925,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8485.405999999999,
"heapDeltaBytes": 24655712,
"heapUsedBytes": 182706468,
"domNodes": 0,
"jsHeapTotalBytes": -6815744,
"scriptDurationMs": 140.24200000000008,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 452.3690000000329,
"styleRecalcs": 14,
"styleRecalcDurationMs": 22.84,
"layouts": 3,
"layoutDurationMs": 0.7999999999999999,
"taskDurationMs": 108.19,
"heapDeltaBytes": 4781160,
"heapUsedBytes": 73666592,
"domNodes": 122,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.834999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 152.80799999993633,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.129,
"layouts": 2,
"layoutDurationMs": 1.3059999999999998,
"taskDurationMs": 79.396,
"heapDeltaBytes": 2996372,
"heapUsedBytes": 71401148,
"domNodes": 132,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.179999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
christian-byrne
left a comment
There was a problem hiding this comment.
Clean cherry-pick of #18052 (1e98c37aa), no conflicts, same 15 files.
Verified on this head rather than assuming the file list means the content carried: notice rule is before:bg-muted-background, icon is muted-foreground, no weight pins left in the banner, the comfy-c logo and its plum-600/ink-700 raw-palette wrapper are gone from EmptyState, agent-scope is on the MessageFeedback dropdown, the RunNoticeBanner story carried, and no font-smoothing leaked into agentPanel.css (that stays parked in DES-1205).
Parent was approved with its residual risk stated; nothing changes on core/1.54.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18793 +/- ##
============================================
Coverage 83.77% 83.78%
============================================
Files 2104 2104
Lines 124698 124696 -2
Branches 31573 33436 +1863
============================================
+ Hits 104464 104473 +9
+ Misses 20055 20044 -11
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…or node reference (#18693) (#18836) Backport of #18693 (`facbca7658dd361ff5f5edaf5ff5404d582e0a64`, merged to `main` 2026-09-25T07:11Z) to `core/1.54`. Companion to the `cloud/1.54` carrier #18835. ## Why #18693 fixes the agent editing a different workflow than the one the user is looking at — writes land on a document nobody is watching. `core/1.54` feeds the `comfyui-frontend-package` PyPI train for Desktop/local. ## Cherry-pick adaptations (context only, no behavior change) Same class of drift as the cloud carrier (see #18835), plus four core-specific ones: - `agentNewChatTargetWorkflow.spec.ts` (modify/delete): this spec does not exist on the `core/1.54` train; per the #18810 precedent it was **not introduced**. - `RunNoticeBanner.vue`: core still has the pre-#18052 palette (`bg-primary-background`, `font-medium`; the core backport of #18052 is still open as #18793). #18693's `context`/`showTarget` logic applied onto core's palette classes verbatim; no styling change smuggled in. - Test `retains an explicitly chosen target across panel reopen and New Chat`: core's variant of this test had drifted from main's, so #18693's rewrite hunk missed it. Applied the source's post-change version by hand (`retains an explicitly chosen target across a plain panel reopen`) — New Chat now resumes following, which is exactly the behavior #18693 ships. - Three new tests assert `selection: { node_ids, workflow_id }` in the send payload; `core/1.54` predates #17327 (selection scoping), so its payload has no nested `workflow_id`. Matchers narrowed to `{ node_ids }` on this branch only; top-level `workflow_id` assertions (the target-binding behavior under test) are untouched. - Did not introduce the two `agentGraphActivityStore` tests riding as pre-image context in one hunk — that store is not on this train. ## Local gates on this head (per the #18722 lesson) - `pnpm typecheck` ✅ - `pnpm typecheck:browser` ✅ - `pnpm knip:no-cache` ✅ - `pnpm vitest run` on the five touched suites: 302/302 ✅ ## Red on parent With production files reverted to the parent (`9439d31a3e`) and the new tests kept, `AgentPanelRoot.test.ts -t 'follows the visible workflow'` fails; green with the fix. Note: `Vercel – billing-web-test` fails branch-wide on every `core/1.54` PR (recorded exception in the program's backport policy, sunset 2026-10-09); it is unrelated to this diff. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
Backport of #18052 to
core/1.54Automatically created by backport workflow.