Repository navigation
fix(agent): use a neutral color palette and lighter text in the agent panel - #18052
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2128 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 10 MB gzip 🟢 -5 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • 🟢 -9 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 2 unchanged Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.97 MB (baseline 3.97 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 15 unchanged Utilities & Hooks — 576 kB (baseline 576 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 300 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T03:37:15.378Z",
"gitSha": "694b33108bffb8a6b4eeb43ac58545e20b9d2f1c",
"branch": "uy/DES-1043/agent-panel-neutral-color",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.0380000000032,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2779999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.975,
"heapDeltaBytes": 25064,
"heapUsedBytes": 62361492,
"domNodes": -228,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.536000000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2015.9539999999652,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.256000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.24299999999994,
"heapDeltaBytes": 6250440,
"heapUsedBytes": 67469276,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.544000000000002,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1826.2189999999805,
"styleRecalcs": 71,
"styleRecalcDurationMs": 17.69,
"layouts": 12,
"layoutDurationMs": 4.721,
"taskDurationMs": 821.62,
"heapDeltaBytes": 8293184,
"heapUsedBytes": 70573240,
"domNodes": -228,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 165.119,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1860.1840000000038,
"styleRecalcs": 72,
"styleRecalcDurationMs": 18.117,
"layouts": 12,
"layoutDurationMs": 4.684,
"taskDurationMs": 851.737,
"heapDeltaBytes": -3338840,
"heapUsedBytes": 59179768,
"domNodes": -228,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 172.234,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.0379999999645,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.565000000000001,
"layouts": 6,
"layoutDurationMs": 1.147,
"taskDurationMs": 310.57800000000003,
"heapDeltaBytes": 2163768,
"heapUsedBytes": 64313776,
"domNodes": 53,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.072000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.5860000000312,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.94,
"layouts": 6,
"layoutDurationMs": 1.431,
"taskDurationMs": 316.07699999999994,
"heapDeltaBytes": 2165992,
"heapUsedBytes": 64554784,
"domNodes": 53,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 10.256000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 629.9849999999765,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.6349999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.866,
"heapDeltaBytes": 18840156,
"heapUsedBytes": 79929836,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 166.534,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 631.2060000000201,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.8600000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.46,
"heapDeltaBytes": 18315628,
"heapUsedBytes": 80647360,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 164.2,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1247.0390000000293,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 930.7449999999999,
"heapDeltaBytes": -14203148,
"heapUsedBytes": 73750808,
"domNodes": -259,
"jsHeapTotalBytes": 19791872,
"scriptDurationMs": 73.814,
"eventListeners": -185,
"totalBlockingTimeMs": 580,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1212.0380000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 891.582,
"heapDeltaBytes": -15175828,
"heapUsedBytes": 72637844,
"domNodes": -259,
"jsHeapTotalBytes": 18481152,
"scriptDurationMs": 70.152,
"eventListeners": -207,
"totalBlockingTimeMs": 547,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.280000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.38399999999945,
"heapDeltaBytes": 14375316,
"heapUsedBytes": 91064148,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.00599999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.981999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.6989999999996,
"heapDeltaBytes": 14378432,
"heapUsedBytes": 91144544,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.13500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 220,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11386.032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10486.773,
"heapDeltaBytes": -5792940,
"heapUsedBytes": 76089704,
"domNodes": 0,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 8823.531,
"eventListeners": 0,
"totalBlockingTimeMs": 1947,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9288.750000000051,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8568.069000000001,
"heapDeltaBytes": 3351660,
"heapUsedBytes": 85631988,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 7278.508,
"eventListeners": 0,
"totalBlockingTimeMs": 1015,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11041.920000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10102.254,
"heapDeltaBytes": -8372840,
"heapUsedBytes": 68501124,
"domNodes": -228,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 8435.213,
"eventListeners": -164,
"totalBlockingTimeMs": 1454,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10086.389000000054,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9175.941,
"heapDeltaBytes": 6496272,
"heapUsedBytes": 80704744,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 7574.764,
"eventListeners": 0,
"totalBlockingTimeMs": 1000,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2020.8810000000312,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.7749999999999972,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.131,
"heapDeltaBytes": -6610484,
"heapUsedBytes": 72717576,
"domNodes": -228,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 31.389,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.5339999999796,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.4459999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.888,
"heapDeltaBytes": -3843504,
"heapUsedBytes": 83181524,
"domNodes": -228,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 31.824000000000005,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2350.354999999979,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.278,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1658.029,
"heapDeltaBytes": -16167764,
"heapUsedBytes": 65470180,
"domNodes": -228,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 869.9720000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2412.9480000000285,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.889000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1633.994,
"heapDeltaBytes": 16572160,
"heapUsedBytes": 80829180,
"domNodes": -228,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 866.46,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3555.4970000000026,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.870999999999999,
"layouts": 60,
"layoutDurationMs": 12.953000000000001,
"taskDurationMs": 1635.225,
"heapDeltaBytes": 7794668,
"heapUsedBytes": 74009820,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 772.2189999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3621.469999999931,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.138000000000002,
"layouts": 60,
"layoutDurationMs": 13.018,
"taskDurationMs": 1699.706,
"heapDeltaBytes": 9695008,
"heapUsedBytes": 75556500,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 825.2980000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2957.683999999972,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.037000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1724.942,
"heapDeltaBytes": 22075332,
"heapUsedBytes": 88147700,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 969.3389999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3119.6479999999838,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.266,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1895.724,
"heapDeltaBytes": 17707104,
"heapUsedBytes": 84320676,
"domNodes": -228,
"jsHeapTotalBytes": 2252800,
"scriptDurationMs": 990.7779999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2026.0580000000346,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.644999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 583.3290000000001,
"heapDeltaBytes": -13237268,
"heapUsedBytes": 75079496,
"domNodes": -228,
"jsHeapTotalBytes": 3960832,
"scriptDurationMs": 35.85099999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2020.4640000000609,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.176999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.826,
"heapDeltaBytes": -4958424,
"heapUsedBytes": 83382008,
"domNodes": -228,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 31.993999999999996,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 586.084000000028,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.809000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.899,
"heapDeltaBytes": 13811496,
"heapUsedBytes": 76443468,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.79199999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.113999999975,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.070000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.511,
"heapDeltaBytes": 13403280,
"heapUsedBytes": 76802100,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 146.56399999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2004.995000000008,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.1080000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.88000000000005,
"heapDeltaBytes": 16902224,
"heapUsedBytes": 80190664,
"domNodes": -244,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 6.571000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.6170000000193,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.209999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.923,
"heapDeltaBytes": 5600704,
"heapUsedBytes": 68863036,
"domNodes": -244,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.8119999999999985,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.313999999973,
"styleRecalcs": 73,
"styleRecalcDurationMs": 17.834,
"layouts": 16,
"layoutDurationMs": 6.091,
"taskDurationMs": 759.9060000000001,
"heapDeltaBytes": 10955020,
"heapUsedBytes": 74470480,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 110.723,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.9260000000331,
"styleRecalcs": 59,
"styleRecalcDurationMs": 16.378,
"layouts": 16,
"layoutDurationMs": 5.784999999999999,
"taskDurationMs": 757.919,
"heapDeltaBytes": 6657484,
"heapUsedBytes": 69468296,
"domNodes": -244,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 111.07099999999998,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.9610000000657,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.798,
"layouts": 5,
"layoutDurationMs": 15.071999999999996,
"taskDurationMs": 932.2170000000001,
"heapDeltaBytes": 21376380,
"heapUsedBytes": 101147460,
"domNodes": 13667,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.904000000000003,
"eventListeners": 2383,
"totalBlockingTimeMs": 145,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8368.252999999982,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.014999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5629.867,
"heapDeltaBytes": 12333156,
"heapUsedBytes": 75888300,
"domNodes": -228,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 2758.533,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.975000000079,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.842999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5084.932,
"heapDeltaBytes": 6114468,
"heapUsedBytes": 85219172,
"domNodes": -228,
"jsHeapTotalBytes": 1789952,
"scriptDurationMs": 2755.569,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16647.563999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15918.841999999999,
"heapDeltaBytes": -48201940,
"heapUsedBytes": 193416936,
"domNodes": -8049,
"jsHeapTotalBytes": -12259328,
"scriptDurationMs": 230.70800000000003,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16705.920999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16160.162,
"heapDeltaBytes": -75107064,
"heapUsedBytes": 162611764,
"domNodes": -8049,
"jsHeapTotalBytes": -16973824,
"scriptDurationMs": 249.444,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21025.117000000024,
"styleRecalcs": 165,
"styleRecalcDurationMs": 17.539000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20692.838,
"heapDeltaBytes": -34415800,
"heapUsedBytes": 191455352,
"domNodes": -8049,
"jsHeapTotalBytes": -18497536,
"scriptDurationMs": 905.948,
"eventListeners": -14923,
"totalBlockingTimeMs": 66,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15660.281000000054,
"styleRecalcs": 78,
"styleRecalcDurationMs": 11.285000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15110.060000000001,
"heapDeltaBytes": -53340052,
"heapUsedBytes": 184191472,
"domNodes": -8049,
"jsHeapTotalBytes": -10158080,
"scriptDurationMs": 785.692,
"eventListeners": -14923,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6024.130000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.822,
"layouts": 20,
"layoutDurationMs": 22.829999999999988,
"taskDurationMs": 5929.094999999999,
"heapDeltaBytes": -42704708,
"heapUsedBytes": 182371628,
"domNodes": -8049,
"jsHeapTotalBytes": 14409728,
"scriptDurationMs": 108.70100000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 368,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5984.805000000051,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.69800000000002,
"layouts": 20,
"layoutDurationMs": 23.577,
"taskDurationMs": 5902.018,
"heapDeltaBytes": -64076380,
"heapUsedBytes": 173910540,
"domNodes": -8049,
"jsHeapTotalBytes": 12054528,
"scriptDurationMs": 105.99000000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 468,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8440.645000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8243.864999999998,
"heapDeltaBytes": -2837080,
"heapUsedBytes": 190904164,
"domNodes": 0,
"jsHeapTotalBytes": -25427968,
"scriptDurationMs": 129.96599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8292.326000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8006.260999999999,
"heapDeltaBytes": 7880216,
"heapUsedBytes": 185569288,
"domNodes": 0,
"jsHeapTotalBytes": -12320768,
"scriptDurationMs": 123.67599999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 473.06300000002466,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.849999999999998,
"layouts": 3,
"layoutDurationMs": 1.3580000000000003,
"taskDurationMs": 138.87500000000003,
"heapDeltaBytes": 5109600,
"heapUsedBytes": 67012660,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.048,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 117.35299999998006,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.048999999999998,
"layouts": 4,
"layoutDurationMs": 2.0349999999999997,
"taskDurationMs": 89.84,
"heapDeltaBytes": 3217896,
"heapUsedBytes": 65079272,
"domNodes": 120,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.022000000000002,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (19 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b7827a39f0541aa52caddba2073b14865dbf9964
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (11)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughAgent panel components receive typography, color, icon, and layout updates. The empty state removes the brand icon and changes the greeting layout. The workflow selector changes its selected-item icon. The copy-markdown menu gains the ChangesAgent panel styling
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Possibly related PRs
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change is limited to the agent panel’s visual presentation and a supporting image. No actionable regression is established, so it is mergeable subject to normal checks. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 1 system. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The PR contains bug-fix signals in its title and commit subjects, including
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18052 +/- ##
==========================================
+ Coverage 83.85% 84.88% +1.03%
==========================================
Files 3052 2303 -749
Lines 151005 132213 -18792
Branches 39099 35769 -3330
==========================================
- Hits 126624 112231 -14393
+ Misses 22967 19684 -3283
+ Partials 1414 298 -1116
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 789 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Dismissed at DrJKL's request during the Agent PR survey. This does not mark the findings as fixed or approve the PR.
The run notice's blue left bar and info icon move off the azure primary token onto a neutral one. The empty state's logo tile goes entirely, taking its purple outline with it, and the workflow dropdown's selected indicator becomes a standard check. - Fixes DES-1043
Twelve chrome labels across the panel sat at font-medium, leaving nothing to read as secondary. They drop to font-normal. Headings keep font-semibold for hierarchy, and MarkdownStream's prose rules are untouched since bold is semantic in rendered agent output. Weight is set explicitly rather than by removing the class, because several of these sit under ancestors that set a heavier weight. - Fixes DES-1043
This was the one teleported surface in the panel without .agent-scope, so it missed the thin scrollbar, the Preflight resets that strip UA chrome from buttons and inputs, and now the panel's font smoothing. - Fixes DES-1043
Light and dark, captured from the AgentPanel story.
53bd75f to
5f55989
Compare
The banner had no story, so Chromatic only saw it folded into the AgentPanel shot. It is the one surface this change recolors, and #18693 rewrites the same markup to add a target-following context, so it earns its own baseline. Both themes are covered: the left rule and the icon are the two neutral marks on the card and each has to hold up when base-background flips.
Uy's panel shot predates the token change, so its rule is the darker `muted-foreground` grey. This one is cropped from the `AgentPanel` story in both themes with animations frozen, `muted-foreground` on the left and `muted-background` on the right.
christian-byrne
left a comment
There was a problem hiding this comment.
Approving. Stating the provenance rather than leaving it to the commit log: commits 1-4 are Uy's, handed over in #pillar5-agent-code-review. Commits 5-8 are mine, pushed after the handover, so this approval covers my own work on someone else's PR. Uy has been asked in the thread to look at the handover changes and can dismiss this if he disagrees with any of them.
What backs it:
- oxfmt, stylelint, oxlint, eslint (no cache) and
vue-tsc --noEmitclean. 137 agent test files, 2270 tests passing. - The claim that deleting the weight pins changes nothing is verified, not asserted. Both Storybook builds were compiled locally and pixel-diffed across all 42 shared agent stories in both themes: 78 of 84 comparisons byte-identical, and the only difference is the notice rule itself, a 4x90 box in the three
AgentPanelstories, stable across two runs. Six stories that flagged initially were ruled out with a control (same build diffed against itself) and by re-shooting withanimation: none. - The one genuine near-miss: the original sweep had taken
font-normaloff an<h2>inChatHistoryScreen. Preflight is disabled host-wide so that would have rendered UA bold. Restored, and the ~20 other load-bearingfont-normaluses on Buttons and headings were left alone.
Residual risk, in order:
muted-backgroundvsmuted-foregroundfor the rule is a design call, not an engineering one. It is asked in the thread and is a one-line revert if Pablo or Jo want the stronger stripe.- Chromatic gives this no coverage. It is gated to
version-bump-*branches since #5167, and the account is currently out of snapshots, so even the release-time run compares nothing until it resets. The local diff above is the only visual evidence here. - Two
primary-backgroundblues survive in the panel and are deliberately out of scope, listed in the description.
…or node reference (#18693) (#18836) Backport of #18693 (`facbca7658dd361ff5f5edaf5ff5404d582e0a64`, merged to `main` 2026-09-25T07:11Z) to `core/1.54`. Companion to the `cloud/1.54` carrier #18835. ## Why #18693 fixes the agent editing a different workflow than the one the user is looking at — writes land on a document nobody is watching. `core/1.54` feeds the `comfyui-frontend-package` PyPI train for Desktop/local. ## Cherry-pick adaptations (context only, no behavior change) Same class of drift as the cloud carrier (see #18835), plus four core-specific ones: - `agentNewChatTargetWorkflow.spec.ts` (modify/delete): this spec does not exist on the `core/1.54` train; per the #18810 precedent it was **not introduced**. - `RunNoticeBanner.vue`: core still has the pre-#18052 palette (`bg-primary-background`, `font-medium`; the core backport of #18052 is still open as #18793). #18693's `context`/`showTarget` logic applied onto core's palette classes verbatim; no styling change smuggled in. - Test `retains an explicitly chosen target across panel reopen and New Chat`: core's variant of this test had drifted from main's, so #18693's rewrite hunk missed it. Applied the source's post-change version by hand (`retains an explicitly chosen target across a plain panel reopen`) — New Chat now resumes following, which is exactly the behavior #18693 ships. - Three new tests assert `selection: { node_ids, workflow_id }` in the send payload; `core/1.54` predates #17327 (selection scoping), so its payload has no nested `workflow_id`. Matchers narrowed to `{ node_ids }` on this branch only; top-level `workflow_id` assertions (the target-binding behavior under test) are untouched. - Did not introduce the two `agentGraphActivityStore` tests riding as pre-image context in one hunk — that store is not on this train. ## Local gates on this head (per the #18722 lesson) - `pnpm typecheck` ✅ - `pnpm typecheck:browser` ✅ - `pnpm knip:no-cache` ✅ - `pnpm vitest run` on the five touched suites: 302/302 ✅ ## Red on parent With production files reverted to the parent (`9439d31a3e`) and the new tests kept, `AgentPanelRoot.test.ts -t 'follows the visible workflow'` fails; green with the fix. Note: `Vercel – billing-web-test` fails branch-wide on every `core/1.54` PR (recorded exception in the program's backport policy, sunset 2026-10-09); it is unrelated to this diff. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
## Summary - show the first three cold-start prompt suggestions below the existing 460px panel breakpoint - retain all five suggestions in the DOM and show them at wider panel sizes - cover the rendered behavior on both sides of the breakpoint in the Agent browser harness The other compact-empty-state acceptance item, removing the Comfy logo, is covered by [frontend PR 18052](Comfy-Org#18052), merged 2026-09-25. This PR intentionally avoids duplicating that change. ## Rebased onto current `main` (second time) `5e260d95` was `CONFLICTING`/`DIRTY` again. Rebased onto `d965cd4dbd65b24546c518a0319f0f1edb3d4ada`; new head `35f9d672532a93d678d25424cb1b0d4ab0aaec36`. The branch's earlier `main` merge commit is gone — the four commits are linear on top of `main` now. **One conflict, in `browser_tests/fixtures/components/AgentPanel.ts`.** `main` added a private `toasts: ToastHelper` to the property list where this branch added `public readonly suggestedPrompts`. Both belong, so both are kept, in the list's alphabetical order. Nothing was preferred mechanically and nothing upstream was reverted: `main`'s attachment drop/hand-over helpers, the credit-transition notice locator, the tooltip settle in `selectWorkflow`, `rejectEveryTurn`, and the canvas settle in node-selection mode are all intact. `EmptyState.vue` auto-merged against an upstream class removal on a line this branch does not touch. The net change against `main` is the same four files, +123/−14 before the review fixes below. **No approval was spent.** This PR has never had one — latest non-dismissed review per reviewer is `dante01yoon` CHANGES_REQUESTED, `DrJKL` COMMENTED, `christian-byrne` COMMENTED. `dante01yoon` has no earlier changes-requested to resurrect, so the push could not re-expose a retired verdict. ## Review follow-up at `35f9d672532a93d678d25424cb1b0d4ab0aaec36` The blocking finding was real and is fixed by taking the reviewer's first option. `prompt_count` meant "size of the rendered set" and the starter-prompt set experiment reads it that way; reporting the compact panel's visible count through that same field would have made a narrow panel indistinguishable from a shrunken set in every arm. - `prompt_count` is `prompts.value.length` again, so its existing docblock is accurate. - The width-dependent count moved to a **new** `visible_prompt_count` on `app:agent_starter_prompt_clicked`: 3 in a compact panel, the set size elsewhere. It carries its own docblock stating why the two are separate. - The field is **required**, not optional, so no future emitter can drop it silently. That is what the six fixture updates are. - Two non-blocking test notes also addressed: the compact visibility array is derived from `compactCount` instead of repeating three literals, and both breakpoint phases use `expect.poll` so they keep a web-first retry. The `EmptyState.test.ts` comment names happy-dom, which is the environment `vite.config.mts:843` actually configures. ## Testing At head `35f9d672532a93d678d25424cb1b0d4ab0aaec36`, locally: - `pnpm vitest run src/platform/telemetry src/workbench/extensions/agent` — **209 files, 4444 passed**, 1 expected fail. - `pnpm typecheck` and `pnpm typecheck:browser` — both clean. `oxfmt --check` and type-aware `oxlint` clean on the changed files; full pre-commit hooks ran on both commits, and the pre-push `fallow audit` reports no issues in the 15 changed files. - The whole `@cloud` spec file through the browser harness — **6 passed (16.6s)**, against a local ComfyUI e2e backend with `DISTRIBUTION=cloud` on the dev server. **Regression proofs, all three red without the change:** - Browser: reverting only `EmptyState.vue` to `main` fails the PM-1373 case at the 459px phase — suggestions 4 and 5 resolve visible where the assertion wants them hidden. Restoring it turns the file green. - Unit: restoring the blocked telemetry behaviour (`prompt_count` carrying the visible count) fails the new `EmptyState` case on `promptCount: 5`. - Unit: unwiring `visiblePromptCount()` fails the same case on `visiblePromptCount: 3`. No existing assertion was weakened to go green. Remote checks at this head are running; results are not claimed here until they land. --- <details> <summary>Earlier rebase and review history (head <code>f63a35cc</code> / <code>235cde9c</code>)</summary> ## Rebased onto current `main` This branch was `CONFLICTING` against `main` for nineteen days and has been rebased onto `1697904c9dccce16f50a55d2dfd828bd3aa4e506`. New head: `f63a35ccbf2f03c8f00665b7290fe4f955c46ed0`. The ten review-iteration commits are collapsed into two; the net change is the same three files. Three things moved under the branch and the resolution adapts to them rather than reverting them: - `EmptyState.vue` gained the starter-prompt set experiment ([Comfy-Org#20272](Comfy-Org#20272)) and distribution-specific prompt sets ([Comfy-Org#19283](Comfy-Org#19283)). The click handler is now `onPromptClick(prompt, index)`, so the class edit is reapplied around it. The hidden-overflow rule is index-based, so it holds for the control set, the local set, and the treatment set alike. - `agent.suggestedPrompts` in the locale files is no longer a flat array — it is `{ cloud, local, treatment.cloud }`. The page object therefore resolves suggestion buttons **by position** inside `[data-testid="suggested-prompts"]`, not by prompt text, which would otherwise have broken on whichever set rendered. `includeHidden: true` is load-bearing: the compact state keeps every suggestion in the DOM, so a visible-only locator cannot tell "hidden" from "never rendered". - `main`'s `X-01 / PM-672` already took the `agentPanel.open()` change but kept the inline resize-handle drag. That duplication is removed here as originally reviewed. ## Testing At head `f63a35ccbf2f03c8f00665b7290fe4f955c46ed0`, locally: - `pnpm vitest run src/workbench/extensions/agent/components/agent/EmptyState.test.ts` — 24 passed - `pnpm typecheck` and `pnpm typecheck:browser` — both clean - `oxfmt --check`, `stylelint`, and type-aware `oxlint` on the three changed files — clean. ESLint reports the two `browser_tests/` files as outside its config, which is the repo's configuration, not a change here. Full pre-commit hooks (oxfmt, stylelint, type-aware oxlint, ESLint, `typecheck:app`) ran on both commits; the transcripts are the recorded `lint-staged` output. - The whole `@cloud` spec file through the browser harness — **6 passed (21.6s)**, against a local ComfyUI e2e backend with `DISTRIBUTION=cloud` on the dev server. That is the file's six cases, i.e. the new breakpoint case plus the two X-01 widths and the three neighbor-layout cases that exercise the refactored `resizeTo`. - **Regression proof:** reverting only `EmptyState.vue` and rerunning the new case fails at `suggestions.nth(4)` → `toBeHidden`, resolved to a visible `<button>` at 459px. Restoring the fix turns it green. The pin fails on the parent and passes on the fix. Remote checks at this head are running; results are not claimed here until they land. ## Review follow-up at `235cde9c7ffc790c99ceaeefd30209bd12b13d5a` - Click attribution now reports the number of suggestions visible when clicked (3 in a compact panel), not the full set size. Unit case added; it fails without the change. - The X-01 cases measure the outer dock again, as originally written. `resizeTo` takes the element to size; the PM-1373 case still measures the panel root. - The PM-1373 case no longer pins the set at five suggestions. Locally at this head: `EmptyState.test.ts` 25 passed; `pnpm typecheck` and `typecheck:browser` clean; the whole `@cloud` spec file 6 passed. Reverting only `EmptyState.vue` still fails the new case at `nth(3)` and `nth(4)` → `toBeHidden`. </details> ## Note for the reviewer: backport labels were retargeted This PR carried `needs-backport` + `cloud/1.54`. The 1.54 trains are retired, and `pr-backport.yaml` creates a carrier per train label on merge — so merging as labelled would have opened a `cloud/1.54` carrier. `cloud/1.54` was removed and replaced with `cloud/1.55` + `cloud/1.56`. Correction, since this paragraph had gone stale: `cloud/1.55` was then removed again on 2026-10-11 by the repository owner, so the PR currently carries `needs-backport` + **`cloud/1.56` only**. That removal is left alone deliberately — it reads as a release-line decision, not a mechanical slip. If 1.55 should also receive this change, re-add the label before merging. If no release line should, drop `needs-backport`. Linear: [PM-1370 — compact Agent empty state](https://linear.app/comfyorg/issue/PM-1370), [PM-1373 — reduce narrow-panel suggestions](https://linear.app/comfyorg/issue/PM-1373) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
The agent side panel uses neutral colors and lighter text now.
Linear: DES-1043
Taken over from @uytieu with his go-ahead in #agent-eng. Rebased onto main, and three things changed from his version. Details under Handover changes below.
Changes
border-plum-600,bg-ink-700,text-brand-yellow.Buttons keep their slightly bold text. That weight comes from
button.variants.ts, which the whole product uses, not from this panel. DES-1095 recorded that decision and closed it as intentional.Handover changes
1. The notice rule uses a background token, not a text token.
It was
before:bg-muted-foreground. That is the secondary-text role (light#494a50, dark#8a8a8a), and filling a 4px rule with it inverts the role.docs/guidance/design-standards.mdasks for the semantic role rather than whichever value lands right.It is
before:bg-muted-backgroundnow, the neutral surface role already used as both a fill and a border elsewhere insrc(light#a0a0a0, dark#55565e). No new token: design-standards says not to name one for the first component that wants it.2. The weight pins are deleted, not restated.
Every one of those sites is a
p/span/divwith no weight-setting ancestor, sofont-normalrenders identically to no class at all. It only pins the value at the call site. Twofont-mediumlabels that main's refactor moved out from under the original sweep are gone the same way, which finishes the DES-1043 checkbox.font-normalon a Button or a heading is load-bearing and was left alone:button.variants.tsbakesfont-mediuminto the base class, and Tailwind Preflight is disabled host-wide so anh2still renders UA bold. The panel keeps about twenty of those.3. Font smoothing is out of this PR, on scope grounds only.
-webkit-font-smoothing: antialiasedwas scoped to:where(#agent-panel-root, .agent-scope). It reads better and should land, but there is no font-smoothing declaration anywhere else in the repo, so panel-scoped would make the agent panel the only surface rendering text differently from the rest of the product. That is a product-wide typography call.Parked in DES-1205 with two ways to land it, whichever @uytieu and design prefer: a separate PR putting it in
packages/design-system/src/css/base.csswith a visual pass over high-traffic surfaces, or folding it into the design-system work Alex Tov and Alex Brown are running. Nothing is blocked on it.One note for that visual pass: grayscale AA thins strokes and change 2 drops this panel a weight step, so the two stack at
text-xsandtext-[11px]/4here. Not an argument against smoothing, just the pairing to look at first.Review Focus
RunNoticeBannernow has its own story in both themes. That is the surface this PR recolors, and feat(agent): follow visible workflow until send or node reference #18693 rewrites the same markup to add a target-following context, so it earns a baseline of its own.ci-tests-storybook.yamlgateschromatic-deploymentonstartsWith(github.head_ref, 'version-bump-'), deliberately, since [ci] Restrict chromatic workflow to version-bump-* PRs and manual triggers #5167. So no ordinary PR gets a visual diff, and Uy's original version of this change had no visual check either.storybook-buildpassing only means Storybook compiles. The new story starts paying off at the next version bump.Verification
Chromatic dispatched manually on a throwaway branch came back
Snapshot quota reached, so it compared nothing. Diffed the two Storybook builds locally instead, Uy's rebased state against this one, across all 42 shared agent stories in both themes.AgentPanelstories, both themes, byte-identical across two runsSix more stories flagged on the first pass and were ruled out.
AgentMessagecomposing/streaming andConsentCardalso differ when a build is diffed against itself, so they are animation phase.AttachmentChip UploadingandAgentEntryButton Invitingwere stable across runs but come back byte-identical onceanimation: noneis injected, and their sources are unchanged between the two commits.Every weight-pin deletion is a pixel-exact no-op. The only thing that moved is the rule.
Still blue, not in scope here
Two
primary-backgroundusages survive in the panel and are worth a separate design call rather than a silent change:components/agent/composer/WorkflowSelectorChip.vue— the blue dot marking the chosen workflow, the same signal as the check mark this PR de-yellowed.components/agent/message/MarkdownStream.vue— link color in agent replies.(
crdt/CrdtDevPanel.vuehas four more. Dev-only, out of scope.)Screenshots
The notice rule, cropped from the
AgentPanelstory in both themes with animations frozen.muted-foregroundon the left,muted-backgroundon the right.Uy's original panel shot, which predates the token change. Accurate for the logo removal and the check mark, not for the rule color.