Repository navigation
[Backport cloud/1.54] test: repro agent-CRDT reconcile overwriting live node/title/widget state (#18075) - #18759
Conversation
…ve node/title/widget state (#18075) Manual backport of #18075 to cloud/1.54. Automated backport failed: #18075 (comment) Cherry-picked from 96821ac. Dependency check: the bot flagged a possible stacking conflict with #18728, #18723 (both still open against cloud/1.54). Neither touches graphMutations.ts, graphMutations.test.ts or agentConversationFixture.ts, so they are not the cause. The real causes (same as the core/1.54 backport): - graphMutations.ts: cloud/1.54 predates #18191 ("keep the ghost placement flag out of the document"), which hoisted node flags into a local `flags` variable (`cloneNodeFlags`) reused by `lastSerialization`. #18191 has no needs-backport label and was never backported here. Resolved by keeping cloud/1.54's existing flags handling (`cloneRecord(payload.flags)` / `structuredClone(payload)`) and porting only #18075's actual change: `resolveNodeTitle` plus the new `titleReconcileBaseline` field. - graphMutations.test.ts: pure insertion, no real conflict — accepted the new test cases as-is. - browser_tests/fixtures/agentConversationFixture.ts and the new browser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.ts: this fixture (and the wider main-only agent Playwright test scaffolding it depends on, e.g. agentTabSwitchCatchUp.spec.ts) does not exist on cloud/1.54 at all. Dropped from this backport along with the Topbar.ts#openBlankTabAndReturn() helper added only for that spec, so the branch keeps compiling. The runtime fix ships with its Vitest regression coverage (graphMutations.test.ts, agentNodeMaterializer.test.ts); the e2e visual-proof spec is left for a follow-up once the agent Playwright fixture infrastructure itself is backported. Validation on this branch: - pnpm exec vitest run src/workbench/extensions/agent - pnpm exec eslint / pnpm exec oxfmt --check on touched files - pnpm typecheck
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1951 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T01:38:36.660Z",
"gitSha": "985d69775f7f0ea4439fe2c9f98f09cb8b3ffa25",
"branch": "backport-18075-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2047.879000000023,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.146999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.912,
"heapDeltaBytes": 7816892,
"heapUsedBytes": 78041464,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.814,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2054.61600000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.980000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.146,
"heapDeltaBytes": 9939356,
"heapUsedBytes": 81095280,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.844,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1702.1500000000174,
"styleRecalcs": 73,
"styleRecalcDurationMs": 21.245,
"layouts": 14,
"layoutDurationMs": 3.267,
"taskDurationMs": 673.2560000000001,
"heapDeltaBytes": -13038000,
"heapUsedBytes": 57796656,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 113.52699999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1805.045000000007,
"styleRecalcs": 75,
"styleRecalcDurationMs": 30.531000000000002,
"layouts": 14,
"layoutDurationMs": 4.295999999999999,
"taskDurationMs": 810.5640000000001,
"heapDeltaBytes": -212476,
"heapUsedBytes": 70216756,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 145.896,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.98400000003,
"styleRecalcs": 32,
"styleRecalcDurationMs": 13.279999999999998,
"layouts": 6,
"layoutDurationMs": 1.069,
"taskDurationMs": 299.392,
"heapDeltaBytes": 4588572,
"heapUsedBytes": 75052668,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.386,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.903999999955,
"styleRecalcs": 30,
"styleRecalcDurationMs": 14.695,
"layouts": 6,
"layoutDurationMs": 0.9569999999999997,
"taskDurationMs": 368.83500000000004,
"heapDeltaBytes": 4639148,
"heapUsedBytes": 76049004,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.595,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 529.5529999999644,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.160000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.901,
"heapDeltaBytes": -8131360,
"heapUsedBytes": 62968772,
"domNodes": 22,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 122.82099999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 562.8719999999703,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.195,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.479,
"heapDeltaBytes": -8131192,
"heapUsedBytes": 62876680,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 126.68300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2022.9979999999728,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.180999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.11699999999985,
"heapDeltaBytes": 6234084,
"heapUsedBytes": 82208440,
"domNodes": -274,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 29.88199999999999,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2025.7370000000492,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.337000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.808,
"heapDeltaBytes": 10758396,
"heapUsedBytes": 87513556,
"domNodes": -272,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 29.142000000000003,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2132.4960000000033,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.304999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1300.1290000000001,
"heapDeltaBytes": -9219620,
"heapUsedBytes": 67971032,
"domNodes": -281,
"jsHeapTotalBytes": 684032,
"scriptDurationMs": 620.866,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2398.009000000002,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.404000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1512.7079999999999,
"heapDeltaBytes": -619828,
"heapUsedBytes": 77040628,
"domNodes": -284,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 702.082,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3200.3250000000207,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.033000000000001,
"layouts": 60,
"layoutDurationMs": 11.270000000000001,
"taskDurationMs": 1379.53,
"heapDeltaBytes": 11448156,
"heapUsedBytes": 90018428,
"domNodes": 6,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 640.1869999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3304.683000000068,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.562000000000003,
"layouts": 60,
"layoutDurationMs": 11.802999999999999,
"taskDurationMs": 1438.356,
"heapDeltaBytes": 8481840,
"heapUsedBytes": 76471088,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 626.622,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2435.8290000000125,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1534.024,
"heapDeltaBytes": 18859500,
"heapUsedBytes": 85464928,
"domNodes": -7,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 757.776,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2621.6849999999567,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.463000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1780.7720000000002,
"heapDeltaBytes": 583184,
"heapUsedBytes": 81138812,
"domNodes": -253,
"jsHeapTotalBytes": -471040,
"scriptDurationMs": 842.6680000000001,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2039.3599999999878,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.939,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.8399999999998,
"heapDeltaBytes": 7291300,
"heapUsedBytes": 85804220,
"domNodes": -268,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 29.709,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2048.102999999969,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.295999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.7280000000001,
"heapDeltaBytes": 5635940,
"heapUsedBytes": 83175696,
"domNodes": -274,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 36.534,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 558.6579999999799,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.649,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.204,
"heapDeltaBytes": 14504668,
"heapUsedBytes": 86807984,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 109.02,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 556.7460000000892,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.632000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 368.07599999999996,
"heapDeltaBytes": 14715896,
"heapUsedBytes": 88090808,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 119.95700000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2006.8650000000048,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.228,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.92600000000004,
"heapDeltaBytes": -3969084,
"heapUsedBytes": 68568152,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.922,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1991.267999999991,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.942999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.838,
"heapDeltaBytes": -7015352,
"heapUsedBytes": 66341072,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.811,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.2529999999942,
"styleRecalcs": 78,
"styleRecalcDurationMs": 22.634999999999994,
"layouts": 18,
"layoutDurationMs": 3.6170000000000004,
"taskDurationMs": 646.018,
"heapDeltaBytes": -8782680,
"heapUsedBytes": 64446188,
"domNodes": -297,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 83.913,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.8309999999992,
"styleRecalcs": 78,
"styleRecalcDurationMs": 25.126,
"layouts": 18,
"layoutDurationMs": 4.273,
"taskDurationMs": 739.4549999999999,
"heapDeltaBytes": -9259720,
"heapUsedBytes": 64240472,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 95.375,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1082.5510000000236,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.801000000000005,
"layouts": 15,
"layoutDurationMs": 11.839,
"taskDurationMs": 786.673,
"heapDeltaBytes": 21870436,
"heapUsedBytes": 105727140,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 25.753999999999998,
"eventListeners": 2387,
"totalBlockingTimeMs": 100,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8290.264000000036,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.147,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4689.303000000001,
"heapDeltaBytes": -8215756,
"heapUsedBytes": 68263792,
"domNodes": -277,
"jsHeapTotalBytes": 1732608,
"scriptDurationMs": 2133.049,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9423.802000000023,
"styleRecalcs": 249,
"styleRecalcDurationMs": 40.452000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5320.801,
"heapDeltaBytes": 17747428,
"heapUsedBytes": 93741588,
"domNodes": -266,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 2301.437,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14855.63000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14415.572,
"heapDeltaBytes": -58988480,
"heapUsedBytes": 179277240,
"domNodes": -8068,
"jsHeapTotalBytes": -22835200,
"scriptDurationMs": 221.00799999999998,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15744.133999999918,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15195.997000000001,
"heapDeltaBytes": -61257972,
"heapUsedBytes": 166459988,
"domNodes": -8068,
"jsHeapTotalBytes": -19054592,
"scriptDurationMs": 248.65900000000002,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17701.630000000023,
"styleRecalcs": 136,
"styleRecalcDurationMs": 16.499000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17379.582,
"heapDeltaBytes": -35134796,
"heapUsedBytes": 189304920,
"domNodes": -8068,
"jsHeapTotalBytes": -20140032,
"scriptDurationMs": 807.132,
"eventListeners": -14931,
"totalBlockingTimeMs": 59,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18002.297999999995,
"styleRecalcs": 135,
"styleRecalcDurationMs": 18.257000000000023,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17749.434999999998,
"heapDeltaBytes": -32857512,
"heapUsedBytes": 194748020,
"domNodes": -8068,
"jsHeapTotalBytes": -18145280,
"scriptDurationMs": 757.859,
"eventListeners": -14929,
"totalBlockingTimeMs": 91,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5383.305000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 58.51999999999999,
"layouts": 20,
"layoutDurationMs": 20.911000000000012,
"taskDurationMs": 5332.817,
"heapDeltaBytes": -30249860,
"heapUsedBytes": 193765208,
"domNodes": -8068,
"jsHeapTotalBytes": 8380416,
"scriptDurationMs": 95.73499999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 239,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5643.640000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.71499999999996,
"layouts": 20,
"layoutDurationMs": 28.190999999999995,
"taskDurationMs": 5574.715999999999,
"heapDeltaBytes": -44262796,
"heapUsedBytes": 178508640,
"domNodes": -8068,
"jsHeapTotalBytes": 5914624,
"scriptDurationMs": 145.85,
"eventListeners": -14929,
"totalBlockingTimeMs": 261,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7732.506999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7510.454000000001,
"heapDeltaBytes": 8906176,
"heapUsedBytes": 179025016,
"domNodes": 0,
"jsHeapTotalBytes": -23855104,
"scriptDurationMs": 145.64600000000004,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7655.262999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7523.754999999999,
"heapDeltaBytes": 3510288,
"heapUsedBytes": 180882236,
"domNodes": 0,
"jsHeapTotalBytes": -18874368,
"scriptDurationMs": 129.795,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 445.130000000006,
"styleRecalcs": 16,
"styleRecalcDurationMs": 19.46,
"layouts": 3,
"layoutDurationMs": 1.4360000000000002,
"taskDurationMs": 94.42600000000002,
"heapDeltaBytes": 4935440,
"heapUsedBytes": 73144156,
"domNodes": 145,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.579999999999998,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 440.5420000000504,
"styleRecalcs": 12,
"styleRecalcDurationMs": 16.267,
"layouts": 3,
"layoutDurationMs": 0.7029999999999998,
"taskDurationMs": 89.74900000000001,
"heapDeltaBytes": 4751232,
"heapUsedBytes": 74177076,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.775,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
christian-byrne
left a comment
There was a problem hiding this comment.
reviewed exact head 6edc0cc3a36e836856fc27b20cab5c9c77857fda against cloud/1.54. The conflict resolution keeps the target branch’s existing flag serialization, ports only the title reconcile baseline, and omits the unavailable main-only browser fixture/helper. Focused unit tests pass (160 plus 3 expected failures); target typecheck, type-aware oxlint, and ESLint pass. No unresolved review threads.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18759 +/- ##
=============================================
Coverage ? 83.80%
=============================================
Files ? 2113
Lines ? 125629
Branches ? 31859
=============================================
Hits ? 105287
Misses ? 20163
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
taking over this Claude-authored carrier to refresh it onto the live |
|
exact-head local verification is green at |
|
correction: |
Requested by Christian Byrne · Slack thread
Manual backport of #18075 to
cloud/1.54. The automated backport failed with merge conflicts: #18075 (comment)Cherry-picked from
96821ace03bc81d7a29965751a401fcf1818cae3(git cherry-pick -x -m 1).Dependency check
The bot flagged a possible stacking conflict with #18728, #18723 (both still open against
cloud/1.54). Neither touchesgraphMutations.ts,graphMutations.test.ts, oragentConversationFixture.ts— they are not the cause of this conflict.The real causes (same underlying gap as the
core/1.54backport, #18758):graphMutations.ts—cloud/1.54predates fix(agent-crdt): keep the ghost placement flag out of the document #18191 ("keep the ghost placement flag out of the document"), which hoisted node flags into a localflagsvariable (cloneNodeFlags) thatlastSerializationalso started reusing. fix(agent-crdt): keep the ghost placement flag out of the document #18191 is merged tomainbut carries noneeds-backportlabel and was never backported tocloud/1.54. Resolved by keepingcloud/1.54's existing flags handling (flags: cloneRecord(payload.flags)/lastSerialization: structuredClone(payload)) and porting only test: repro agent-CRDT reconcile overwriting live node/title/widget state #18075's actual change:resolveNodeTitle(payload, incumbent)for the title, plus the newtitleReconcileBaselinefield feeding it.graphMutations.test.ts— pure insertion (no code on theHEADside of the conflict), accepted the new test cases as-is.browser_tests/fixtures/agentConversationFixture.tsand the newbrowser_tests/tests/agent/agentCrdtReconcileOverwrite.spec.ts— this Playwright fixture (and the wider main-only agent-test scaffolding it depends on, e.g.agentTabSwitchCatchUp.spec.ts) does not exist oncloud/1.54at all; it isn't introduced by either PR above. Dropped from this backport, along with theTopbar.ts#openBlankTabAndReturn()helper added only for that spec, so the branch keeps compiling. The runtime fix ships with its Vitest regression coverage (graphMutations.test.ts,agentNodeMaterializer.test.ts); the e2e visual-proof spec is left for a follow-up once the agent Playwright fixture infrastructure itself is backported.Validation
pnpm exec vitest run src/workbench/extensions/agent/crdt— 827 passed, 5 expected-fail (the intentionalit.failscases this PR introduces/carries).pnpm exec eslint/pnpm exec oxfmt --checkclean on all touched files.pnpm typecheckclean.🤖 Generated with Claude Code
https://claude.ai/code/session_01L4WMaCPdk7KSva7vwKfz19
Generated by Claude Code