Repository navigation
[backport core/1.54] fix(agent): wait for open dialogs before offering Agent consent (#18619) - #18670
Conversation
The automatic "Meet Comfy Agent" card opened on top of whatever dialog was already up, including the desktop sign-in approval, so people had to dismiss it before they could approve. It now waits until no dialog is open and shows in the same visit. - **What**: - The automatic consent offer holds while any dialog from the dialog store is open (desktop sign-in approval, sign-in, invite links, errors, the startup template browser) and offers once the last one closes. - It retries once, and only when an offer was actually held, so ordinary dialog closes don't re-read consent. - Once someone has seen the card this visit, from the Agent button or on its own, the automatic offer is done until the next visit. Skipping a card opened from the button no longer brings it straight back. - The Agent button is unchanged and still opens the card right away. - The hold reads `dialogStack.length`, the rule the first-run nudge already uses, not `isModalOpen`. `isModalOpen` also sees modals outside the store, which the retry can't see close, so hold and release would disagree. The trade-off: a lightbox open at the exact moment of the offer won't hold it. - The startup template browser now comes first and the card waits for it to close. That was a product call and it's agreed. - `CONSENT_DIALOG_KEY` is exported from `useAgentConsent` so the extension can tell when the card itself is open. - Unit, `agentPanel.test.ts`: hold, same-session release, a dialog opening mid-offer, a tour ending while a dialog is still open, manual Skip not re-popping, the card seen this visit, and a failing consent read not retried on every dialog close. These fail against the old code. - E2E, `agentConsent.spec.ts` (cloud): boots on a desktop sign-in link; the approval is on top and clickable, and the card appears only after approving. Red 5/5 on the old bundle, green 5/5 on the fix. - Mutation testing on the changed lines: 6/6 killed. - Fixes FE-2808 (cherry picked from commit c10ba49)
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1946 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-24T01:48:03.216Z",
"gitSha": "e866fdb769d97abd314b1260cd199067697accda",
"branch": "backport-18619-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2034.9560000000224,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.174999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.61899999999997,
"heapDeltaBytes": 8473404,
"heapUsedBytes": 78683084,
"domNodes": -283,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.738999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2031.3330000000178,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.5809999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.67499999999995,
"heapDeltaBytes": -7745200,
"heapUsedBytes": 62693664,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.800999999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1979.8439999999573,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.038,
"layouts": 14,
"layoutDurationMs": 4.044,
"taskDurationMs": 990.817,
"heapDeltaBytes": -399332,
"heapUsedBytes": 70545628,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 172.41500000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.0089999999636,
"styleRecalcs": 78,
"styleRecalcDurationMs": 29.435999999999996,
"layouts": 14,
"layoutDurationMs": 4.210999999999999,
"taskDurationMs": 882.3470000000001,
"heapDeltaBytes": -5411740,
"heapUsedBytes": 64818136,
"domNodes": -281,
"jsHeapTotalBytes": 7593984,
"scriptDurationMs": 171.4,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.6750000000184,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.151,
"layouts": 6,
"layoutDurationMs": 1.0340000000000003,
"taskDurationMs": 344.251,
"heapDeltaBytes": 4625488,
"heapUsedBytes": 75603800,
"domNodes": 74,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.604999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1689.3779999999197,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.315,
"layouts": 6,
"layoutDurationMs": 1.0470000000000002,
"taskDurationMs": 351.40700000000004,
"heapDeltaBytes": 4295864,
"heapUsedBytes": 74683916,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.735000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 625.1379999999926,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.404000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.218,
"heapDeltaBytes": 18638732,
"heapUsedBytes": 88755200,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 161.297,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 655.6520000000319,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.052,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 428.47999999999996,
"heapDeltaBytes": 18658432,
"heapUsedBytes": 88742296,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 159.643,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2082.176000000004,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.658,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 610.901,
"heapDeltaBytes": 8183688,
"heapUsedBytes": 84260652,
"domNodes": -277,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 34.95099999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2038.8200000001007,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.055000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.9730000000001,
"heapDeltaBytes": 5636668,
"heapUsedBytes": 82208732,
"domNodes": -278,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 32.16899999999999,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2221.7840000000137,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.944,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1647.923,
"heapDeltaBytes": -10346292,
"heapUsedBytes": 67154796,
"domNodes": -280,
"jsHeapTotalBytes": -102400,
"scriptDurationMs": 820.637,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2179.4760000000224,
"styleRecalcs": 64,
"styleRecalcDurationMs": 8.828,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1570.9930000000002,
"heapDeltaBytes": 18621272,
"heapUsedBytes": 84815144,
"domNodes": -276,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 793.559,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3573.2289999999693,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.451000000000004,
"layouts": 60,
"layoutDurationMs": 11.764,
"taskDurationMs": 1751.5510000000002,
"heapDeltaBytes": -10863996,
"heapUsedBytes": 68058988,
"domNodes": -289,
"jsHeapTotalBytes": 3567616,
"scriptDurationMs": 793.481,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3586.0189999999648,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.615999999999998,
"layouts": 60,
"layoutDurationMs": 11.757,
"taskDurationMs": 1760.319,
"heapDeltaBytes": -8265044,
"heapUsedBytes": 70914940,
"domNodes": -287,
"jsHeapTotalBytes": 4616192,
"scriptDurationMs": 804.2009999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3136.0500000000116,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.7589999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1922.577,
"heapDeltaBytes": 28147616,
"heapUsedBytes": 94209540,
"domNodes": -285,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 963.9230000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3176.65599999998,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.208,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1996.548,
"heapDeltaBytes": 383292,
"heapUsedBytes": 80891124,
"domNodes": -287,
"jsHeapTotalBytes": 839680,
"scriptDurationMs": 992.9010000000002,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2057.4550000000045,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.396999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 607.6669999999999,
"heapDeltaBytes": 5522724,
"heapUsedBytes": 82831872,
"domNodes": -279,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 31.759999999999998,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 1994.1749999999274,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.509,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.9789999999999,
"heapDeltaBytes": 21773512,
"heapUsedBytes": 87843800,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.308,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.1000000000158,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.71000000000004,
"heapDeltaBytes": 15058596,
"heapUsedBytes": 88079336,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 138.124,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.3819999999532,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.055000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.767,
"heapDeltaBytes": 14583860,
"heapUsedBytes": 86837548,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 145.298,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.4800000000064,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.219000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.94100000000003,
"heapDeltaBytes": -15292740,
"heapUsedBytes": 56923484,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.184000000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2016.6390000000547,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.8900000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.3810000000001,
"heapDeltaBytes": -13149788,
"heapUsedBytes": 59655384,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.325999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.3879999999804,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.628000000000004,
"layouts": 18,
"layoutDurationMs": 4.75,
"taskDurationMs": 800.1809999999999,
"heapDeltaBytes": 4689096,
"heapUsedBytes": 77651692,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 108.643,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.534000000076,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.737,
"layouts": 18,
"layoutDurationMs": 4.901,
"taskDurationMs": 808.5260000000001,
"heapDeltaBytes": -9520932,
"heapUsedBytes": 63062784,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.74099999999999,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.7010000000264,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.523999999999997,
"layouts": 15,
"layoutDurationMs": 14.977999999999998,
"taskDurationMs": 886.2209999999999,
"heapDeltaBytes": 20961796,
"heapUsedBytes": 109850104,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 29.848,
"eventListeners": 2385,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8305.740000000014,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.78000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5750.0689999999995,
"heapDeltaBytes": -6493180,
"heapUsedBytes": 69264524,
"domNodes": -280,
"jsHeapTotalBytes": 4616192,
"scriptDurationMs": 2700.619,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8438.490000000002,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.355999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5724.529,
"heapDeltaBytes": 10184232,
"heapUsedBytes": 85829780,
"domNodes": -270,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 2665.7840000000006,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16796.126000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16144.015,
"heapDeltaBytes": -47539560,
"heapUsedBytes": 178286116,
"domNodes": -8068,
"jsHeapTotalBytes": -8167424,
"scriptDurationMs": 264.349,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16693.159000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16102.220000000003,
"heapDeltaBytes": -39267764,
"heapUsedBytes": 178650768,
"domNodes": -8068,
"jsHeapTotalBytes": -10498048,
"scriptDurationMs": 252.09500000000003,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21064.42499999997,
"styleRecalcs": 175,
"styleRecalcDurationMs": 18.25399999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20735.629000000004,
"heapDeltaBytes": -35802560,
"heapUsedBytes": 182878256,
"domNodes": -8068,
"jsHeapTotalBytes": -12349440,
"scriptDurationMs": 961.622,
"eventListeners": -14925,
"totalBlockingTimeMs": 81,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21010.005999999976,
"styleRecalcs": 171,
"styleRecalcDurationMs": 17.31100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20551.365,
"heapDeltaBytes": -49267764,
"heapUsedBytes": 183185580,
"domNodes": -8068,
"jsHeapTotalBytes": -21594112,
"scriptDurationMs": 900.797,
"eventListeners": -14929,
"totalBlockingTimeMs": 94,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6148.505999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 98.17700000000002,
"layouts": 20,
"layoutDurationMs": 34.24199999999998,
"taskDurationMs": 6016.354,
"heapDeltaBytes": -41042344,
"heapUsedBytes": 176889328,
"domNodes": -8068,
"jsHeapTotalBytes": 10735616,
"scriptDurationMs": 107.82900000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 410,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6096.059999999966,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.36299999999997,
"layouts": 20,
"layoutDurationMs": 23.366,
"taskDurationMs": 5978.174,
"heapDeltaBytes": -36029360,
"heapUsedBytes": 181869680,
"domNodes": -8068,
"jsHeapTotalBytes": 12570624,
"scriptDurationMs": 105.427,
"eventListeners": -14929,
"totalBlockingTimeMs": 524,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8504.222000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8244.48,
"heapDeltaBytes": 18270296,
"heapUsedBytes": 178714372,
"domNodes": 0,
"jsHeapTotalBytes": -12582912,
"scriptDurationMs": 133.83800000000002,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8548.755000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8327.111000000003,
"heapDeltaBytes": 1162316,
"heapUsedBytes": 178530300,
"domNodes": 0,
"jsHeapTotalBytes": -17825792,
"scriptDurationMs": 122.65099999999995,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 113.83599999999205,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.658999999999999,
"layouts": 2,
"layoutDurationMs": 0.5810000000000001,
"taskDurationMs": 74.57100000000001,
"heapDeltaBytes": 3116532,
"heapUsedBytes": 71924396,
"domNodes": 112,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.762999999999998,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 455.33899999998084,
"styleRecalcs": 13,
"styleRecalcDurationMs": 18.096,
"layouts": 2,
"layoutDurationMs": 0.566,
"taskDurationMs": 93.97100000000003,
"heapDeltaBytes": 4755728,
"heapUsedBytes": 73186024,
"domNodes": 119,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.422999999999998,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18670 +/- ##
==========================================
Coverage 83.73% 83.73%
==========================================
Files 2103 2103
Lines 124590 124612 +22
Branches 31538 31542 +4
==========================================
+ Hits 104325 104347 +22
Misses 20086 20086
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Manual backport of #18619 to
core/1.54after the label-driven cherry-pick conflicted inagentPanel.test.ts. The branch already carries everything the fix builds on (#18287, #18431 and the #18603 telemetry, through the agent catch-up backports), so the source files applied cleanly.Resolution
agentPanel.test.ts: an import-block conflict only. Keeps the branch'suseExtensionServicetype import and takes the combinedCONSENT_DIALOG_KEY/useAgentConsentimport from the source commit.agentConsent.spec.ts: this branch has noinitialUrlfixture option, so the desktop sign-in test lets the normal boot finish, clears the one-shot key, then opens the?desktop_login_code=link withcomfyPage.gotoand waits for the app. Its read-count anchor now waits for a read after that navigation, so the absence check can't pass on the first boot's read.Verification
pnpm typecheck,pnpm typecheck:browser, eslint, oxlint, pre-pushknipDISTRIBUTION=cloudbuild of this branch: agent consent and onboarding specs 16/16; the desktop sign-in test fails 3/3 on a build ofcore/1.54without the fix, at the approval being covered