Repository navigation
test(agent): 35-case insert_workflow integration suite (widgets, links, subgraphs, templates) - #18607
Conversation
…s, subgraphs, templates) Extends the PM-1562/#18458 (link materialization) and PM-1580/#18598/#18604 (widget rendering) regression coverage with broader integration tests for insert_workflow across widget types, link topologies, subgraph promotion, and representative workflow-template shapes. - agentInsertWorkflow.widgetTypes.test.ts (13 cases): combo/number/text/ toggle/multiline widgets on inserted nodes, partial widgets_values, cross-graph and same-graph id collisions. - agentInsertWorkflow.linkTopology.test.ts (8 cases): fan-out, fan-in, parallel chains, links crossing into/out of a subgraph boundary, a fully interior subgraph link, batch id-collision, incremental inserts. - agentInsertWorkflow.subgraphs.test.ts (7 cases): a promoted widget surviving a later set_widget, multiple widget types promoted together, subgraph-instance id collisions, several instances of one definition in one op, coexistence with a pre-existing instance, multiple definitions in one op. Documents a real gap (not fixed here): a subgraph instance nested as an interior node of another subgraph does not yet materialize through this pipeline. - agentInsertWorkflow.templates.test.ts (7 cases): representative txt2img, img2img, ControlNet, LoRA, video and compound pipelines, plus the same template inserted twice without cross-wiring.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2121 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9f2639671be570170bf283afc836d0fd7674e4d6
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.98 MB gzipDetailsSummary
Category Glance App Entry Points — 3.87 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.44 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 132 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 639 kBConfiguration panels, inspectors, and settings screens
Status: 28 added User & Accounts — 37.9 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 124 kBReusable component library chunks
Status: 16 added Data & Services — 3.95 MBStores, services, APIs, and repositories
Status: 16 added Utilities & Hooks — 577 kBHelpers, composables, and utility bundles
Status: 38 added Vendor & Third-Party — 17.4 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 17.8 MBBundles that do not match a named category
Status: 302 added ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T14:00:53.014Z",
"gitSha": "82241362d737938e5454875b8bc28eb30da2ea1b",
"branch": "claude/insert-workflow-integration-tests",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2005.5449999999837,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.792999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.501,
"heapDeltaBytes": 6820436,
"heapUsedBytes": 74712820,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.143,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2000.6660000000238,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.700000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.49,
"heapDeltaBytes": 10008152,
"heapUsedBytes": 77162356,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.36,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1768.0910000000267,
"styleRecalcs": 44,
"styleRecalcDurationMs": 14.196999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 805.826,
"heapDeltaBytes": -2268304,
"heapUsedBytes": 60099344,
"domNodes": -264,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 161.952,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1753.3989999999449,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.732999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 763.564,
"heapDeltaBytes": 9289228,
"heapUsedBytes": 76891584,
"domNodes": -259,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 170.426,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1665.6789999999546,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.860000000000001,
"layouts": 6,
"layoutDurationMs": 1.051,
"taskDurationMs": 350.367,
"heapDeltaBytes": 3079244,
"heapUsedBytes": 70528384,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.826000000000004,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.1079999999347,
"styleRecalcs": 33,
"styleRecalcDurationMs": 14.71,
"layouts": 6,
"layoutDurationMs": 0.9719999999999999,
"taskDurationMs": 349.403,
"heapDeltaBytes": 3129232,
"heapUsedBytes": 70752512,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.354000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 626.5510000000063,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.104999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 453.793,
"heapDeltaBytes": 18582760,
"heapUsedBytes": 86249196,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 170.438,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 699.8620000000528,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.133,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.04400000000004,
"heapDeltaBytes": 18984608,
"heapUsedBytes": 86579272,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 175.47899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1229.9580000000105,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 916.848,
"heapDeltaBytes": -14518548,
"heapUsedBytes": 73163472,
"domNodes": -294,
"jsHeapTotalBytes": 19005440,
"scriptDurationMs": 67.017,
"eventListeners": -217,
"totalBlockingTimeMs": 571,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1156.836999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 782.742,
"heapDeltaBytes": 38322908,
"heapUsedBytes": 106118968,
"domNodes": 0,
"jsHeapTotalBytes": 18247680,
"scriptDurationMs": 70.062,
"eventListeners": 0,
"totalBlockingTimeMs": 544,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.4419999999677,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.9390000000003,
"heapDeltaBytes": 14982780,
"heapUsedBytes": 91290680,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.51300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 227,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.147999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.93600000000004,
"heapDeltaBytes": 15791872,
"heapUsedBytes": 92439956,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.66,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11535.12900000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10544.573999999999,
"heapDeltaBytes": 2667544,
"heapUsedBytes": 84495756,
"domNodes": -16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 8775.637999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1650,
"frameDurationMs": 18.883333333333333,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11319.615999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10468.246000000001,
"heapDeltaBytes": 13469864,
"heapUsedBytes": 95941472,
"domNodes": -16,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8742.235,
"eventListeners": 0,
"totalBlockingTimeMs": 1657,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11378.480000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10430.755000000001,
"heapDeltaBytes": 2348664,
"heapUsedBytes": 84397728,
"domNodes": -14,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 8688.604,
"eventListeners": 0,
"totalBlockingTimeMs": 1625,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10354.291999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9406.889,
"heapDeltaBytes": -8899036,
"heapUsedBytes": 72993924,
"domNodes": -14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7991.1410000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 1183,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2054.273999999964,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.8520000000001,
"heapDeltaBytes": -3567760,
"heapUsedBytes": 82989780,
"domNodes": -241,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 42.403,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2015.7689999999775,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.9910000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.21099999999996,
"heapDeltaBytes": -4116332,
"heapUsedBytes": 82751748,
"domNodes": -247,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 38.138000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2255.3849999999898,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.684,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1663.8180000000002,
"heapDeltaBytes": -4007740,
"heapUsedBytes": 83593704,
"domNodes": -252,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 864.6,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2427.8769999999668,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.696999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1753.205,
"heapDeltaBytes": -11010268,
"heapUsedBytes": 76480304,
"domNodes": -243,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 880.567,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3587.7849999999967,
"styleRecalcs": 64,
"styleRecalcDurationMs": 13.692000000000002,
"layouts": 60,
"layoutDurationMs": 13.767999999999999,
"taskDurationMs": 1764.1460000000002,
"heapDeltaBytes": 10581636,
"heapUsedBytes": 74522972,
"domNodes": -252,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 805.085,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3640.418000000068,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.939000000000004,
"layouts": 60,
"layoutDurationMs": 14.183000000000002,
"taskDurationMs": 1765.5599999999997,
"heapDeltaBytes": 9100648,
"heapUsedBytes": 74097784,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 822.821,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3175.0690000000077,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.496000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2004.9460000000004,
"heapDeltaBytes": 277312,
"heapUsedBytes": 90899308,
"domNodes": -256,
"jsHeapTotalBytes": 446464,
"scriptDurationMs": 1027.289,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3140.021000000047,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.793000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1962.306,
"heapDeltaBytes": 22446196,
"heapUsedBytes": 88155880,
"domNodes": 6,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 996.758,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2009.5099999999775,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.7769999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.9960000000001,
"heapDeltaBytes": 20191992,
"heapUsedBytes": 84173600,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.467,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2030.255000000011,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.366000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.716,
"heapDeltaBytes": -4218152,
"heapUsedBytes": 84121264,
"domNodes": -246,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 34.422999999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.1679999999542,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.823999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.65799999999996,
"heapDeltaBytes": 13781044,
"heapUsedBytes": 83833772,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 150.853,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.8889999999428,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.168999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.42400000000004,
"heapDeltaBytes": 14129416,
"heapUsedBytes": 84084328,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 150.03,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.6389999999742,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.283999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.27899999999994,
"heapDeltaBytes": 8427828,
"heapUsedBytes": 78308448,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.209999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2022.867999999903,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.137,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.8820000000001,
"heapDeltaBytes": -5369352,
"heapUsedBytes": 57113488,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.027999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.960999999992,
"styleRecalcs": 47,
"styleRecalcDurationMs": 17.024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 756.579,
"heapDeltaBytes": -2733368,
"heapUsedBytes": 66392108,
"domNodes": -273,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 108.35,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.9889999999687,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.724999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 787.815,
"heapDeltaBytes": -5110792,
"heapUsedBytes": 58067792,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 114.63300000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.6810000000005,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.26600000000001,
"layouts": 5,
"layoutDurationMs": 12.978,
"taskDurationMs": 894.0089999999998,
"heapDeltaBytes": 20293836,
"heapUsedBytes": 103727416,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 28.020999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8545.557999999972,
"styleRecalcs": 250,
"styleRecalcDurationMs": 40.006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6138.243,
"heapDeltaBytes": -6405908,
"heapUsedBytes": 80255096,
"domNodes": -246,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 2918.0060000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8452.559999999949,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.69799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6022.272,
"heapDeltaBytes": -6252040,
"heapUsedBytes": 80754964,
"domNodes": -240,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2872.298,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13071.856000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12606.803,
"heapDeltaBytes": -59034128,
"heapUsedBytes": 181261104,
"domNodes": -8062,
"jsHeapTotalBytes": -9330688,
"scriptDurationMs": 228.43099999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16733.82700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16110.924,
"heapDeltaBytes": -63795116,
"heapUsedBytes": 177475448,
"domNodes": -8061,
"jsHeapTotalBytes": -15667200,
"scriptDurationMs": 279.345,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20925.879000000008,
"styleRecalcs": 151,
"styleRecalcDurationMs": 19.162999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20709.361,
"heapDeltaBytes": -71650268,
"heapUsedBytes": 169374032,
"domNodes": -8061,
"jsHeapTotalBytes": -20123648,
"scriptDurationMs": 959.946,
"eventListeners": -14928,
"totalBlockingTimeMs": 75,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 19620.73100000009,
"styleRecalcs": 172,
"styleRecalcDurationMs": 15.71000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19364.742,
"heapDeltaBytes": -2717004,
"heapUsedBytes": 179934532,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 868.7850000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 53,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6202.116000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.725,
"layouts": 20,
"layoutDurationMs": 25.220000000000006,
"taskDurationMs": 6115.341,
"heapDeltaBytes": -53991832,
"heapUsedBytes": 187269732,
"domNodes": -8061,
"jsHeapTotalBytes": 1634304,
"scriptDurationMs": 139.093,
"eventListeners": -14928,
"totalBlockingTimeMs": 380,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5796.308999999951,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.79,
"layouts": 20,
"layoutDurationMs": 22.32300000000001,
"taskDurationMs": 5690.6720000000005,
"heapDeltaBytes": -67057576,
"heapUsedBytes": 174159640,
"domNodes": -8061,
"jsHeapTotalBytes": 2420736,
"scriptDurationMs": 111.55700000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 325,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8700.065999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8427.189999999999,
"heapDeltaBytes": -14672476,
"heapUsedBytes": 174380448,
"domNodes": 0,
"jsHeapTotalBytes": -19922944,
"scriptDurationMs": 134.01400000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8541.683999999917,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8342.726,
"heapDeltaBytes": -16641748,
"heapUsedBytes": 177264144,
"domNodes": 0,
"jsHeapTotalBytes": -26214400,
"scriptDurationMs": 133.87099999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 452.2879999999532,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.872000000000003,
"layouts": 3,
"layoutDurationMs": 1.687,
"taskDurationMs": 134.65700000000004,
"heapDeltaBytes": 5111280,
"heapUsedBytes": 69729876,
"domNodes": 127,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 14.067,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 104.6280000000479,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.671,
"layouts": 4,
"layoutDurationMs": 1.9300000000000002,
"taskDurationMs": 83.21799999999999,
"heapDeltaBytes": 3105540,
"heapUsedBytes": 68635416,
"domNodes": 133,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.599,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
christian-byrne
left a comment
There was a problem hiding this comment.
issue: the four added files are all Vitest-level integration coverage under src/workbench/extensions/agent/crdt/, so this Agent PR does not add the required black-box Playwright or recorded-conversation case under browser_tests/. The program harness policy requires at least one user-visible panel/canvas, accessibility, or persisted-behavior assertion for every Agent PR; would you add a durable case that drives insert_workflow through the public Agent path and proves one representative widget/link/subgraph result on the canvas? The hosted unit suite is useful supporting coverage, but it does not satisfy that acceptance gate by itself.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18607 +/- ##
==========================================
+ Coverage 83.58% 84.56% +0.97%
==========================================
Files 2999 2293 -706
Lines 148402 131078 -17324
Branches 40216 33508 -6708
==========================================
- Hits 124038 110841 -13197
+ Misses 23070 19936 -3134
+ Partials 1294 301 -993
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
CI is fully green (109/109 checks: unit, typecheck, lint, ecosystem-matrix, full Playwright e2e matrix including the 16-shard suite, perf-tests, etc. — all success/skipped, zero failures). Added @christian-byrne this is ready for review whenever you have a chance. |
…alization Adds browser_tests/tests/agent/agentInsertWorkflowCanvasResult.spec.ts, driving insert_workflow through the real Agent panel -> WS -> CRDT follower path (not a raw CRDT unit call) and asserting the result on the live canvas: a promoted widget value, a cross-node link, and a subgraph instance all read back correctly, including on the rendered Vue node DOM. Complements the Vitest-level agentInsertWorkflow.* suites, which cover the op's breadth at the projection layer, with the black-box case the program harness policy requires for an Agent PR touching insert_workflow.
|
Replying to this review comment: Added It drives
It reuses the exact subgraph definition/asset already proven to render correctly in
Generated by Claude Code |
christian-byrne
left a comment
There was a problem hiding this comment.
the current f17947e05f2a38a0760b3f5b3182c5b0ed93b4c3 head closes the black-box acceptance gap from my prior review. agentInsertWorkflowCanvasResult.spec.ts now drives the public Agent panel, receives the live insert_workflow update through the WebSocket/CRDT follower path, and asserts the promoted widget values in the rendered Vue node plus the materialized link and subgraph on the canvas. No review threads are open. Hosted checks are still running, so this is a current-head evidence comment rather than a merge disposition.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
…ph widgets (Comfy-Org#18629) ## Summary Adds one test case to `agentInsertWorkflow.subgraphs.test.ts`: a promoted subgraph widget toggled A -> B -> A via repeated `set_widget` writes through `insert_workflow`'s remap/promotion path. ## Changes - **What**: The 35-case suite added in Comfy-Org#18607 has a case for a promoted widget surviving *one* subsequent `set_widget`, but none exercise a repeated toggle (A -> B -> A) on the same promoted widget through `comfy-multi-player`'s remap path — the exact path touched by the nested-subgraph widget-remap fix in comfy-multi-player Comfy-Org#253 / 0.3.6. This adds that case as a baseline regression guard. - **Before**: no case in the suite toggles the same promoted widget's value back and forth; a remap regression that only shows up on a second/third write (rather than the first) had no coverage. - **After**: `round-trips a promoted widget through alternating set_widget writes (A -> B -> A)` inserts a subgraph host with a promoted `NUMBER` widget (value `5`), writes `42` over it, then writes `5` back, asserting the live widget value and the widget-value-store entry at each step. - **Dependencies**: none — written and passing against the currently-installed `@comfyorg/comfy-multi-player@0.3.5`, and expected to keep passing after the 0.3.6 bump. ## Review Focus - Structural reference: `agentInsertWorkflowLinks.regression.test.ts`'s `removes then reinserts a numeric-id link` case (same insert_workflow harness, same alternating-state style). - Test-only change; no production code touched. ## Testing - `npx vitest run src/workbench/extensions/agent/crdt/agentInsertWorkflow.subgraphs.test.ts` — 8 passed (7 existing + 1 new) - `npx vitest run src/workbench/extensions/agent/crdt/` — 926 passed, 15 expected-fail (pre-existing, unrelated), no regressions - `npx eslint` and `npx oxfmt --check` clean on the changed file 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ Co-authored-by: Claude <noreply@anthropic.com>
…omfy-Org#18607 follow-up) (Comfy-Org#18624) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Summary Add a regression test for an `insert_workflow` containing a subgraph instance nested inside another subgraph definition. The test passes a real LiteGraph serialization through the CRDT pipeline and verifies that the nested instance materializes without errors, with its promoted widget name and value intact. The defect was in `@comfyorg/comfy-multi-player`'s `remapInsertedWorkflowIds()`. LiteGraph serializes all used subgraph definitions into one top-level list, but the old remapper did not resolve an interior node's flat sibling definition ID. [comfy-multi-player#253](Comfy-Org/comfy-multi-player#253) fixed the remapping and shipped in version 0.3.6, which this repository now pins. Both legacy and Vue nodes use the same materialized `SubgraphNode`, so no renderer-specific change is needed. ## Testing - `pnpm vitest run src/workbench/extensions/agent/crdt/agentInsertWorkflow.subgraphs.test.ts`: 8 passed ## Backport Backport this regression test to `core/1.54` and `cloud/1.54`. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Amp <amp@ampcode.com>
…18607 follow-up) (#18624) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Summary Add a regression test for an `insert_workflow` containing a subgraph instance nested inside another subgraph definition. The test passes a real LiteGraph serialization through the CRDT pipeline and verifies that the nested instance materializes without errors, with its promoted widget name and value intact. The defect was in `@comfyorg/comfy-multi-player`'s `remapInsertedWorkflowIds()`. LiteGraph serializes all used subgraph definitions into one top-level list, but the old remapper did not resolve an interior node's flat sibling definition ID. [comfy-multi-player#253](Comfy-Org/comfy-multi-player#253) fixed the remapping and shipped in version 0.3.6, which this repository now pins. Both legacy and Vue nodes use the same materialized `SubgraphNode`, so no renderer-specific change is needed. ## Testing - `pnpm vitest run src/workbench/extensions/agent/crdt/agentInsertWorkflow.subgraphs.test.ts`: 8 passed ## Backport Backport this regression test to `core/1.54` and `cloud/1.54`. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Amp <amp@ampcode.com>
…18607 follow-up) (#18624) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Summary Add a regression test for an `insert_workflow` containing a subgraph instance nested inside another subgraph definition. The test passes a real LiteGraph serialization through the CRDT pipeline and verifies that the nested instance materializes without errors, with its promoted widget name and value intact. The defect was in `@comfyorg/comfy-multi-player`'s `remapInsertedWorkflowIds()`. LiteGraph serializes all used subgraph definitions into one top-level list, but the old remapper did not resolve an interior node's flat sibling definition ID. [comfy-multi-player#253](Comfy-Org/comfy-multi-player#253) fixed the remapping and shipped in version 0.3.6, which this repository now pins. Both legacy and Vue nodes use the same materialized `SubgraphNode`, so no renderer-specific change is needed. ## Testing - `pnpm vitest run src/workbench/extensions/agent/crdt/agentInsertWorkflow.subgraphs.test.ts`: 8 passed ## Backport Backport this regression test to `core/1.54` and `cloud/1.54`. ---------
…18607 follow-up) (#18624) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ ## Summary Add a regression test for an `insert_workflow` containing a subgraph instance nested inside another subgraph definition. The test passes a real LiteGraph serialization through the CRDT pipeline and verifies that the nested instance materializes without errors, with its promoted widget name and value intact. The defect was in `@comfyorg/comfy-multi-player`'s `remapInsertedWorkflowIds()`. LiteGraph serializes all used subgraph definitions into one top-level list, but the old remapper did not resolve an interior node's flat sibling definition ID. [comfy-multi-player#253](Comfy-Org/comfy-multi-player#253) fixed the remapping and shipped in version 0.3.6, which this repository now pins. Both legacy and Vue nodes use the same materialized `SubgraphNode`, so no renderer-specific change is needed. ## Testing - `pnpm vitest run src/workbench/extensions/agent/crdt/agentInsertWorkflow.subgraphs.test.ts`: 8 passed ## Backport Backport this regression test to `core/1.54` and `cloud/1.54`. ---------
Before/After
Before:
insert_workflowregression coverage was two narrow pins — one for the PM-1562 link-materialization bug (agentInsertWorkflowLinks.regression.test.ts) and one for the PM-1580 widget-rendering bug (agentInsertWorkflowWidgets.regression.test.ts), plus a single subgraph-blueprint-paste test. Real-worldinsert_workflowusage (agent-driven template inserts, pastes, multi-node/subgraph batches) had no broader integration coverage: no check that every widget type renders correctly, no coverage of link topologies beyond the exact shapes those two bugs hit, and no coverage of subgraph promotion beyond one happy path.After: 35 new integration test cases across 4 files, all driving the real pipeline (comfy-multi-player's
insert_workflowapplier →AgentCrdtProjection/EcsFollowerAdapter→graphMutations→agentNodeMaterializer), same technique as the existing regression files (either literalWorkflowJSONops, or a real litegraph graph built withcreateTestSubgraph/createTestSubgraphNodeand round-tripped throughserialize()):agentInsertWorkflow.widgetTypes.test.ts(13 cases): combo, number, text, toggle and multiline widgets on inserted nodes; a combo value outside its declared options; a multi-widget node rendering in declared order; a node whosewidgets_valuesis shorter than its widget list; two same-original-id nodes inserted into different graphs; three same-original-id nodes inserted into the same graph (extends the existing 2-way collision test).agentInsertWorkflow.linkTopology.test.ts(8 cases): one output fanning out to two inputs; three independent chains in one batch; a link crossing into a freshly-inserted subgraph's promoted input; a link crossing out of one; a fully interior subgraph link; two batch-inserted ops that collide on node ids without cross-wiring their links; a two-source fan-in; an incrementally-inserted link on an already-open graph.agentInsertWorkflow.subgraphs.test.ts(7 cases): a promoted widget materialized viainsert_workflowsurviving a laterset_widgetop; two different widget types (combo + number) promoted together on one host; two subgraph instances colliding on their original host id in the same graph; several instances of the same definition inserted in one op; a new subgraph insert coexisting with a pre-existing, unrelated instance; two distinct subgraph definitions carried by one op.agentInsertWorkflow.templates.test.ts(7 cases): representative checkpoint txt2img, img2img, ControlNet, LoRA, video and compound (ControlNet+LoRA) pipelines, plus the same template inserted twice with no cross-wiring. This repo vendors no local fixture set for the GCS-hosted templates catalogue, so these are literal graphs built to the same node/widget shapes as the well-known public templates rather than pulled fixtures.Real gap found, not fixed here: while writing the subgraph tests I found that an interior node which is itself a subgraph instance (a subgraph nested inside another subgraph, as opposed to two sibling definitions in one op) does not currently materialize correctly through
insert_workflow— itstypestill names the un-remapped blueprint definition id, which nothing registers on the live side, so it falls back to a plain, widget-less node. That's called out in a comment at the top ofagentInsertWorkflow.subgraphs.test.tsrather than asserted around or silently skipped. Worth its own follow-up ticket.How
bindProjection/insertOphelpers,LiteGraph.registerNodeTypefixture classes,useWidgetValueStore/stripGraphPrefixfor reading rendered widgets the wayLGraphNode.vuedoes).pnpm vitest runon the four new files: 35/35 passing.pnpm vitest run src/workbench/extensions/agent/crdt/: all 64 files in the directory pass (925 passed, 15 pre-existing expected-fails), confirming no regression.pnpm typecheck:app: clean.pnpm exec oxlint --type-aware/eslinton the new files: clean.main(a937e31e, includes fix: render widgets on insert_workflow-materialized nodes #18598's widget-rendering fix). fix: insert_workflow nodes still render no widgets when execId derivation fails (PM-1580 follow-up) #18604 (the PM-1580 follow-up for colon-bearing root-level ids) is still open as of this PR and not included; nothing in this suite specifically re-pins that narrow fallback path, since its own regression test already lives in fix: insert_workflow nodes still render no widgets when execId derivation fails (PM-1580 follow-up) #18604.Requested by Christian Byrne · Slack thread (channel C0BGH348Z0C, thread 1790058330.774449)
🤖 Generated with Claude Code
https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
Generated by Claude Code