Repository navigation
[backport cloud/1.54] fix: insert_workflow nodes still render no widgets when execId derivation fails (PM-1580 follow-up) - #18608
Conversation
…tion fails (PM-1580 follow-up) #18598 fixed stripGraphPrefix's widget-id lookup for comfy-multi-player's insert_workflow remapped ids (insert:<opId>:<scope>:node:<originalId>), but computeProcessedWidgets derives its own nodeExecId separately, via executionIdFromState/createNodeExecutionId. Both reject any node id containing a colon, including the derived id itself, so nodeExecId comes back null for these nodes and computeProcessedWidgets early-returns [] -- the same "zero widget rows" symptom the store-lookup fix addressed, from a different call site the existing regression test never exercised (it only replayed the raw store lookup, not computeProcessedWidgets). Adds createLeafNodeExecutionId, which keeps a root-level node's raw id whole instead of rejecting a colon inside it, and uses it at the two fallback call sites (executionIdFromState, computeProcessedWidgets) that only need a single, ancestor-free segment. Also scopes agentNodeMaterializer's withNamedValuesRestore (added in #18598 to fix ordinary nodes' named widget restore) away from SubgraphNode instances: SubgraphNode.configure() skips _applyPromotedWidgetValues -- the only place a proxyWidgetErrorQuarantine override wins over a stale value -- whenever widgets_values_named is set and namedValuesRestore is on, so forcing the flag for every configure() call would silently drop a quarantined promoted-input value on agent-materialized subgraph instances. Also fixes the insert_workflow regression test's collision case, which put the two colliding-id nodes in separate LGraphs and so never exercised a same-graph collision. Fixes PM-1580.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1943 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T13:28:11.513Z",
"gitSha": "dc61ed7491e104e2d674bb58c95e1a44b253f220",
"branch": "claude/manual-backport-18604-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2060.623000000021,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.697,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.084,
"heapDeltaBytes": -9117324,
"heapUsedBytes": 61693124,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 12.808,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2061.6360000000213,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.443,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 625.138,
"heapDeltaBytes": 9298452,
"heapUsedBytes": 80056184,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 13.421,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2182.4719999999616,
"styleRecalcs": 81,
"styleRecalcDurationMs": 39.139,
"layouts": 14,
"layoutDurationMs": 5.306,
"taskDurationMs": 1169.146,
"heapDeltaBytes": -4295300,
"heapUsedBytes": 66037348,
"domNodes": -278,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 188.41200000000003,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1923.7909999999374,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.831,
"layouts": 14,
"layoutDurationMs": 5.202,
"taskDurationMs": 981.561,
"heapDeltaBytes": -12798392,
"heapUsedBytes": 58316880,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 154.75900000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1677.404000000024,
"styleRecalcs": 30,
"styleRecalcDurationMs": 19.736,
"layouts": 6,
"layoutDurationMs": 1.1250000000000002,
"taskDurationMs": 426.90000000000003,
"heapDeltaBytes": 4670212,
"heapUsedBytes": 75983996,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.059,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.250999999991,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.977,
"layouts": 6,
"layoutDurationMs": 1.3219999999999998,
"taskDurationMs": 421.148,
"heapDeltaBytes": 4494032,
"heapUsedBytes": 75008760,
"domNodes": 74,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 14.046999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 716.1970000000224,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.84,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.594,
"heapDeltaBytes": -7561348,
"heapUsedBytes": 63581324,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 168.77599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 741.952000000083,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.045000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.26099999999997,
"heapDeltaBytes": 18766756,
"heapUsedBytes": 89107648,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 163.25,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2036.12499999997,
"styleRecalcs": 3,
"styleRecalcDurationMs": 5.468000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.278,
"heapDeltaBytes": 11198760,
"heapUsedBytes": 87332388,
"domNodes": -273,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 33.785999999999994,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2051.589999999919,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.833000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 756.2249999999999,
"heapDeltaBytes": 8335668,
"heapUsedBytes": 84910516,
"domNodes": -272,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 35.327999999999996,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 3038.242000000025,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.511999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1861.048,
"heapDeltaBytes": 12636396,
"heapUsedBytes": 89522520,
"domNodes": -252,
"jsHeapTotalBytes": 118784,
"scriptDurationMs": 878.518,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2851.2120000000323,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.847000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1813.4990000000003,
"heapDeltaBytes": 3405752,
"heapUsedBytes": 80149492,
"domNodes": -283,
"jsHeapTotalBytes": 643072,
"scriptDurationMs": 815.122,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3986.829,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.801999999999998,
"layouts": 60,
"layoutDurationMs": 13.368000000000002,
"taskDurationMs": 1921.8259999999998,
"heapDeltaBytes": -3182728,
"heapUsedBytes": 75762876,
"domNodes": -284,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 805.403,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3891.937999999982,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.158000000000003,
"layouts": 60,
"layoutDurationMs": 12.893000000000002,
"taskDurationMs": 1842.1130000000003,
"heapDeltaBytes": 8519464,
"heapUsedBytes": 75950220,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 802.9849999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3188.2380000000126,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.405,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2104.8909999999996,
"heapDeltaBytes": 5284316,
"heapUsedBytes": 85630912,
"domNodes": -286,
"jsHeapTotalBytes": 49152,
"scriptDurationMs": 1015.9050000000001,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3235.2839999999787,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.358,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2133.895,
"heapDeltaBytes": 7331712,
"heapUsedBytes": 88329652,
"domNodes": -286,
"jsHeapTotalBytes": 573440,
"scriptDurationMs": 977.097,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2016.5030000000002,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.846999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.8219999999999,
"heapDeltaBytes": 21886952,
"heapUsedBytes": 88563912,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.349000000000004,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2035.429000000022,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.855999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 722.0360000000001,
"heapDeltaBytes": 10218768,
"heapUsedBytes": 88386800,
"domNodes": -266,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 35.72199999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 646.1509999999748,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.299,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.9489999999999,
"heapDeltaBytes": 15017548,
"heapUsedBytes": 88336920,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 141.65,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 690.1500000000169,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.042,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.125,
"heapDeltaBytes": 15029432,
"heapUsedBytes": 88347896,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 145.44,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2031.7650000000071,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.149999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.507,
"heapDeltaBytes": -8631320,
"heapUsedBytes": 63893548,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.414,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.5340000000033,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.140999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.36,
"heapDeltaBytes": -5658420,
"heapUsedBytes": 67284172,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.384999999999998,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.8410000000044,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.424,
"layouts": 18,
"layoutDurationMs": 5.984,
"taskDurationMs": 961.1279999999998,
"heapDeltaBytes": -15110296,
"heapUsedBytes": 57748048,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 114.53700000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.8240000000033,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.388999999999996,
"layouts": 18,
"layoutDurationMs": 5.365,
"taskDurationMs": 935.1330000000002,
"heapDeltaBytes": -6534564,
"heapUsedBytes": 65689148,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 110.18700000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.002000000025,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.310000000000002,
"layouts": 14,
"layoutDurationMs": 14.412999999999998,
"taskDurationMs": 972.0780000000002,
"heapDeltaBytes": 20798992,
"heapUsedBytes": 103838900,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 32.99,
"eventListeners": 2387,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9826.927000000012,
"styleRecalcs": 248,
"styleRecalcDurationMs": 45.882999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6468.337,
"heapDeltaBytes": 23879780,
"heapUsedBytes": 100477496,
"domNodes": -271,
"jsHeapTotalBytes": -700416,
"scriptDurationMs": 2773.733,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9915.267000000085,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.199000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6499.722999999999,
"heapDeltaBytes": 18547544,
"heapUsedBytes": 94530484,
"domNodes": -247,
"jsHeapTotalBytes": 86016,
"scriptDurationMs": 2861.025,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 15754.141000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15249.64,
"heapDeltaBytes": -15728184,
"heapUsedBytes": 196023860,
"domNodes": -8068,
"jsHeapTotalBytes": -5824512,
"scriptDurationMs": 246.79100000000003,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16163.24899999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15543.947,
"heapDeltaBytes": -59463396,
"heapUsedBytes": 179548428,
"domNodes": -8072,
"jsHeapTotalBytes": -15904768,
"scriptDurationMs": 250.26,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19058.20900000003,
"styleRecalcs": 137,
"styleRecalcDurationMs": 18.547000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18797.572,
"heapDeltaBytes": -39240072,
"heapUsedBytes": 178654232,
"domNodes": -8068,
"jsHeapTotalBytes": -15495168,
"scriptDurationMs": 948.66,
"eventListeners": -14931,
"totalBlockingTimeMs": 52,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19955.52399999997,
"styleRecalcs": 150,
"styleRecalcDurationMs": 20.071000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19619.078999999998,
"heapDeltaBytes": -30117580,
"heapUsedBytes": 188942164,
"domNodes": -8068,
"jsHeapTotalBytes": -10350592,
"scriptDurationMs": 933.4220000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 41,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5802.782999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.43900000000001,
"layouts": 20,
"layoutDurationMs": 26.554999999999996,
"taskDurationMs": 5711.424,
"heapDeltaBytes": -57750236,
"heapUsedBytes": 170339408,
"domNodes": -8068,
"jsHeapTotalBytes": 10530816,
"scriptDurationMs": 108.22300000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 362,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5830.200999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.24399999999997,
"layouts": 20,
"layoutDurationMs": 25.915999999999993,
"taskDurationMs": 5724.791999999999,
"heapDeltaBytes": -40594484,
"heapUsedBytes": 177348176,
"domNodes": -8068,
"jsHeapTotalBytes": 12308480,
"scriptDurationMs": 115.8,
"eventListeners": -14931,
"totalBlockingTimeMs": 289,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8080.225000000041,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7739.776000000001,
"heapDeltaBytes": 11838044,
"heapUsedBytes": 178249452,
"domNodes": 0,
"jsHeapTotalBytes": -12320768,
"scriptDurationMs": 127.641,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8067.532000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7890.108000000001,
"heapDeltaBytes": 2125488,
"heapUsedBytes": 179941680,
"domNodes": 0,
"jsHeapTotalBytes": -17301504,
"scriptDurationMs": 130.251,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 481.50200000009136,
"styleRecalcs": 18,
"styleRecalcDurationMs": 23.171999999999997,
"layouts": 4,
"layoutDurationMs": 2.134,
"taskDurationMs": 133.899,
"heapDeltaBytes": 4890252,
"heapUsedBytes": 73056292,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.475,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 117.31899999995221,
"styleRecalcs": 7,
"styleRecalcDurationMs": 17.444,
"layouts": 2,
"layoutDurationMs": 1.4580000000000002,
"taskDurationMs": 85.95,
"heapDeltaBytes": 2936740,
"heapUsedBytes": 72284788,
"domNodes": 125,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 4.611000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18608 +/- ##
=============================================
Coverage ? 83.67%
=============================================
Files ? 2105
Lines ? 124656
Branches ? 31604
=============================================
Hits ? 104304
Misses ? 20173
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…w node ids in locator/callback path (#18616) (#18618) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ Backport of #18616 to `cloud/1.54`. Manual cherry-pick, same approach as #18608: `cloud/1.54` now has #18604's execution-id fix (via #18608), and #18616 is the follow-up that fixes the *sibling* locator-id path (`createNodeLocatorId`/`locatorIdFromState`/`getNodeByLocatorId`), used to resolve the live `LGraphNode` for widget callback dispatch and navigation, for the same colon-bearing `insert_workflow` node ids. ## Before Moving a widget on an `insert_workflow`-materialized node (comfy-multi-player, PM-1580) updates the widget's stored value, but the underlying node's `widget.callback` — which drives dependent UI, control-after-generate, dynamic input wiring, etc. — never fires, because `createNodeLocatorId` rejected the colon-bearing id and `getHostNode` resolved no live `LGraphNode`. The same path also silently broke "Enter Subgraph" navigation and promoted-widget preview locator ids for these nodes. ## After `createLeafNodeLocatorId` (mirroring `createLeafNodeExecutionId` from #18604) keeps a root-level colon-bearing id whole instead of rejecting it, while a genuinely subgraph-nested id still goes through the strict, delimiter-aware path unchanged. `locatorIdFromState`, `getNodeByLocatorId`, and the promoted-widget preview locator (`widgetNodeLocatorId`) now agree on this leaf-tolerant encoding/decoding, so `getHostNode` resolves the real `LGraphNode` and `live.widget.callback` fires normally. ## Cherry-pick details - Source commit: 5d85b04 (single self-contained commit from #18616, `claude/fix-node-locator-id-colon-rejection`) - `git cherry-pick -m 1` applied cleanly onto `cloud/1.54` (post-#18608) — no conflicts, since `nodeIdentification.ts`, `graphTraversalUtil.ts`, and `processedWidgetRenderModel.ts` already had #18604/#18608's sibling execution-id fix in place. - Committer identity normalized to `claude[bot]` (author was already `claude[bot]`; no AI co-author trailer was present in the original commit body, so none needed stripping). ## Testing - `pnpm vitest run` on `nodeIdentification.test.ts`, `graphTraversalUtil.test.ts`, and `useProcessedWidgets.test.ts` (which exercises `processedWidgetRenderModel.ts`'s `getHostNode`) against `cloud/1.54`'s actual code — 186 tests passed. - `vue-tsc --noEmit` — clean. - `eslint` and `oxfmt --check` on all 6 touched files — clean. Ref: #18616 (source PR, still open on `main` at cherry-pick time but CI-green and single-commit) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…ets when execId derivation fails (PM-1580 follow-up) (#18608) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_ Backport of #18604 to `cloud/1.54`. Opened manually: the `PR Backport` workflow (`pr-backport.yaml`) only runs when the PR carries the `needs-backport` label — `core/1.54` + `cloud/1.54` alone (added manually before merge) don't trigger it, so it never ran at merge time. After adding `needs-backport`, the workflow did run and this target (`cloud/1.54`) cherry-picked `035d9056b0` cleanly, but the run's overall job still failed because the `core/1.54` target hit a real conflict (that target is missing #18598 entirely, since its own backport #18600 is still open/unmerged against `core/1.54`) — and the workflow's "Cleanup stranded backport branches" step then deleted the `cloud/1.54` branch it had just successfully pushed, because it runs on `failure()` for the *job*, not per-target. So this clean backport never got a PR from the bot despite succeeding. Re-cherry-picked `035d9056b0` onto `cloud/1.54` (which already has #18598 via #18601) by hand — clean apply, no conflicts. `core/1.54` is intentionally not backported here: it needs #18600 (the #18598 backport) merged first. --- 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ (cherry picked from commit a55ce3d)
…w node ids in locator/callback path (#18616) (#18618) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_ Backport of #18616 to `cloud/1.54`. Manual cherry-pick, same approach as #18608: `cloud/1.54` now has #18604's execution-id fix (via #18608), and #18616 is the follow-up that fixes the *sibling* locator-id path (`createNodeLocatorId`/`locatorIdFromState`/`getNodeByLocatorId`), used to resolve the live `LGraphNode` for widget callback dispatch and navigation, for the same colon-bearing `insert_workflow` node ids. ## Before Moving a widget on an `insert_workflow`-materialized node (comfy-multi-player, PM-1580) updates the widget's stored value, but the underlying node's `widget.callback` — which drives dependent UI, control-after-generate, dynamic input wiring, etc. — never fires, because `createNodeLocatorId` rejected the colon-bearing id and `getHostNode` resolved no live `LGraphNode`. The same path also silently broke "Enter Subgraph" navigation and promoted-widget preview locator ids for these nodes. ## After `createLeafNodeLocatorId` (mirroring `createLeafNodeExecutionId` from #18604) keeps a root-level colon-bearing id whole instead of rejecting it, while a genuinely subgraph-nested id still goes through the strict, delimiter-aware path unchanged. `locatorIdFromState`, `getNodeByLocatorId`, and the promoted-widget preview locator (`widgetNodeLocatorId`) now agree on this leaf-tolerant encoding/decoding, so `getHostNode` resolves the real `LGraphNode` and `live.widget.callback` fires normally. ## Cherry-pick details - Source commit: 5d85b04 (single self-contained commit from #18616, `claude/fix-node-locator-id-colon-rejection`) - `git cherry-pick -m 1` applied cleanly onto `cloud/1.54` (post-#18608) — no conflicts, since `nodeIdentification.ts`, `graphTraversalUtil.ts`, and `processedWidgetRenderModel.ts` already had #18604/#18608's sibling execution-id fix in place. - Committer identity normalized to `claude[bot]` (author was already `claude[bot]`; no AI co-author trailer was present in the original commit body, so none needed stripping). ## Testing - `pnpm vitest run` on `nodeIdentification.test.ts`, `graphTraversalUtil.test.ts`, and `useProcessedWidgets.test.ts` (which exercises `processedWidgetRenderModel.ts`'s `getHostNode`) against `cloud/1.54`'s actual code — 186 tests passed. - `vue-tsc --noEmit` — clean. - `eslint` and `oxfmt --check` on all 6 touched files — clean. Ref: #18616 (source PR, still open on `main` at cherry-pick time but CI-green and single-commit) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY --- _Generated by [Claude Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_ (cherry picked from commit 0ec045e)
<!-- ccr-slack-attribution -->
Requested by Christian Byrne · Slack thread
Backport of #18604 to
cloud/1.54.Opened manually: the
PR Backportworkflow (pr-backport.yaml) only runs when the PR carries theneeds-backportlabel —core/1.54+cloud/1.54alone (added manually before merge) don't trigger it, so it never ran at merge time. After addingneeds-backport, the workflow did run and this target (cloud/1.54) cherry-picked035d9056b0cleanly, but the run's overall job still failed because thecore/1.54target hit a real conflict (that target is missing #18598 entirely, since its own backport #18600 is still open/unmerged againstcore/1.54) — and the workflow's "Cleanup stranded backport branches" step then deleted thecloud/1.54branch it had just successfully pushed, because it runs onfailure()for the job, not per-target. So this clean backport never got a PR from the bot despite succeeding.Re-cherry-picked
035d9056b0ontocloud/1.54(which already has #18598 via #18601) by hand — clean apply, no conflicts.core/1.54is intentionally not backported here: it needs #18600 (the #18598 backport) merged first.🤖 Generated with Claude Code
https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY
Generated by Claude Code