Skip to content

[backport cloud/1.54] fix: insert_workflow nodes still render no widgets when execId derivation fails (PM-1580 follow-up) - #18608

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
claude/manual-backport-18604-cloud-1.54
Sep 23, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
claude/manual-backport-18604-cloud-1.54

Conversation

@claude

@claude claude Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

<!-- ccr-slack-attribution -->
Requested by Christian Byrne · Slack thread

Backport of #18604 to cloud/1.54.

Opened manually: the PR Backport workflow (pr-backport.yaml) only runs when the PR carries the needs-backport label — core/1.54 + cloud/1.54 alone (added manually before merge) don't trigger it, so it never ran at merge time. After adding needs-backport, the workflow did run and this target (cloud/1.54) cherry-picked 035d9056b0 cleanly, but the run's overall job still failed because the core/1.54 target hit a real conflict (that target is missing #18598 entirely, since its own backport #18600 is still open/unmerged against core/1.54) — and the workflow's "Cleanup stranded backport branches" step then deleted the cloud/1.54 branch it had just successfully pushed, because it runs on failure() for the job, not per-target. So this clean backport never got a PR from the bot despite succeeding.

Re-cherry-picked 035d9056b0 onto cloud/1.54 (which already has #18598 via #18601) by hand — clean apply, no conflicts.

core/1.54 is intentionally not backported here: it needs #18600 (the #18598 backport) merged first.


🤖 Generated with Claude Code

https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY


Generated by Claude Code

…tion fails (PM-1580 follow-up)

#18598 fixed stripGraphPrefix's widget-id lookup for comfy-multi-player's
insert_workflow remapped ids (insert:<opId>:<scope>:node:<originalId>), but
computeProcessedWidgets derives its own nodeExecId separately, via
executionIdFromState/createNodeExecutionId. Both reject any node id
containing a colon, including the derived id itself, so nodeExecId comes
back null for these nodes and computeProcessedWidgets early-returns [] --
the same "zero widget rows" symptom the store-lookup fix addressed, from a
different call site the existing regression test never exercised (it only
replayed the raw store lookup, not computeProcessedWidgets).

Adds createLeafNodeExecutionId, which keeps a root-level node's raw id whole
instead of rejecting a colon inside it, and uses it at the two fallback call
sites (executionIdFromState, computeProcessedWidgets) that only need a
single, ancestor-free segment.

Also scopes agentNodeMaterializer's withNamedValuesRestore (added in #18598
to fix ordinary nodes' named widget restore) away from SubgraphNode
instances: SubgraphNode.configure() skips _applyPromotedWidgetValues -- the
only place a proxyWidgetErrorQuarantine override wins over a stale value --
whenever widgets_values_named is set and namedValuesRestore is on, so
forcing the flag for every configure() call would silently drop a
quarantined promoted-input value on agent-materialized subgraph instances.

Also fixes the insert_workflow regression test's collision case, which put
the two colliding-id nodes in separate LGraphs and so never exercised a
same-graph collision.

Fixes PM-1580.
@claude
claude Bot requested a review from a team as a code owner September 23, 2026 13:17
@vercel

vercel Bot commented Sep 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 1:17pm UTC

Request Review

@claude claude Bot added the backport Backporting a PR onto a release candidate label Sep 23, 2026
@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 01:18:40 PM UTC

Links

🎭 Playwright: ✅ 1943 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1922 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 138ms TBT · 99.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 93.0 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 179.1 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 47ms TBT · 175.3 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 326ms TBT · 165.8 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 612ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.6 MB
canvas-idle: DOM nodes -279
canvas-idle: event listeners -179
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 37ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 80
canvas-mouse-sweep: task duration 1075ms
canvas-mouse-sweep: script duration 172ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 59.3 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 19ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 424ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.0 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 502ms
dom-widget-clipping: script duration 166ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.8 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 720ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.1 MB
large-graph-idle: DOM nodes -273
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1837ms
large-graph-pan: script duration 847ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 80.9 MB
large-graph-pan: DOM nodes -268
large-graph-pan: event listeners -191
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 13ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1882ms
large-graph-zoom: script duration 804ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.3 MB
large-graph-zoom: DOM nodes -142
large-graph-zoom: event listeners -89
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 2119ms
legacy-node-drag: script duration 997ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 83.0 MB
legacy-node-drag: DOM nodes -286
legacy-node-drag: event listeners -10
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 675ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.4 MB
minimap-idle: DOM nodes -270
minimap-idle: event listeners -80
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 438ms
subgraph-dom-widget-clipping: script duration 144ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.2 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 582ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.6 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 31ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 948ms
subgraph-mouse-sweep: script duration 112ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.9 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 972ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 138ms
subgraph-transition-enter: heap used 99.0 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 42ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6484ms
viewport-pan-sweep: script duration 2817ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 93.0 MB
viewport-pan-sweep: DOM nodes -259
viewport-pan-sweep: event listeners -174
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15397ms
vue-large-graph-idle: script duration 249ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 179.1 MB
vue-large-graph-idle: DOM nodes -8070
vue-large-graph-idle: event listeners -14933
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 144
vue-large-graph-pan: task duration 19208ms
vue-large-graph-pan: script duration 941ms
vue-large-graph-pan: TBT 47ms
vue-large-graph-pan: heap used 175.3 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14930
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 26ms
vue-node-resize-workload: style recalc duration 77ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5718ms
vue-node-resize-workload: script duration 112ms
vue-node-resize-workload: TBT 326ms
vue-node-resize-workload: heap used 165.8 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7815ms
vue-zoom-out-idle: script duration 129ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 20ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 110ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.3 MB
workflow-execution: DOM nodes 137
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-09-23T13:28:11.513Z",
  "gitSha": "dc61ed7491e104e2d674bb58c95e1a44b253f220",
  "branch": "claude/manual-backport-18604-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2060.623000000021,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.697,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 598.084,
      "heapDeltaBytes": -9117324,
      "heapUsedBytes": 61693124,
      "domNodes": -278,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 12.808,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2061.6360000000213,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.443,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 625.138,
      "heapDeltaBytes": 9298452,
      "heapUsedBytes": 80056184,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 13.421,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2182.4719999999616,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 39.139,
      "layouts": 14,
      "layoutDurationMs": 5.306,
      "taskDurationMs": 1169.146,
      "heapDeltaBytes": -4295300,
      "heapUsedBytes": 66037348,
      "domNodes": -278,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 188.41200000000003,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1923.7909999999374,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 34.831,
      "layouts": 14,
      "layoutDurationMs": 5.202,
      "taskDurationMs": 981.561,
      "heapDeltaBytes": -12798392,
      "heapUsedBytes": 58316880,
      "domNodes": -279,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 154.75900000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1677.404000000024,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 19.736,
      "layouts": 6,
      "layoutDurationMs": 1.1250000000000002,
      "taskDurationMs": 426.90000000000003,
      "heapDeltaBytes": 4670212,
      "heapUsedBytes": 75983996,
      "domNodes": 78,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 14.059,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1738.250999999991,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.977,
      "layouts": 6,
      "layoutDurationMs": 1.3219999999999998,
      "taskDurationMs": 421.148,
      "heapDeltaBytes": 4494032,
      "heapUsedBytes": 75008760,
      "domNodes": 74,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 14.046999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 716.1970000000224,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.84,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.594,
      "heapDeltaBytes": -7561348,
      "heapUsedBytes": 63581324,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 168.77599999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 741.952000000083,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.045000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 504.26099999999997,
      "heapDeltaBytes": 18766756,
      "heapUsedBytes": 89107648,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 163.25,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2036.12499999997,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 5.468000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 684.278,
      "heapDeltaBytes": 11198760,
      "heapUsedBytes": 87332388,
      "domNodes": -273,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 33.785999999999994,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2051.589999999919,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.833000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 756.2249999999999,
      "heapDeltaBytes": 8335668,
      "heapUsedBytes": 84910516,
      "domNodes": -272,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 35.327999999999996,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3038.242000000025,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.511999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1861.048,
      "heapDeltaBytes": 12636396,
      "heapUsedBytes": 89522520,
      "domNodes": -252,
      "jsHeapTotalBytes": 118784,
      "scriptDurationMs": 878.518,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2851.2120000000323,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.847000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1813.4990000000003,
      "heapDeltaBytes": 3405752,
      "heapUsedBytes": 80149492,
      "domNodes": -283,
      "jsHeapTotalBytes": 643072,
      "scriptDurationMs": 815.122,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3986.829,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 12.801999999999998,
      "layouts": 60,
      "layoutDurationMs": 13.368000000000002,
      "taskDurationMs": 1921.8259999999998,
      "heapDeltaBytes": -3182728,
      "heapUsedBytes": 75762876,
      "domNodes": -284,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 805.403,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3891.937999999982,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.158000000000003,
      "layouts": 60,
      "layoutDurationMs": 12.893000000000002,
      "taskDurationMs": 1842.1130000000003,
      "heapDeltaBytes": 8519464,
      "heapUsedBytes": 75950220,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 802.9849999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3188.2380000000126,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 8.405,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2104.8909999999996,
      "heapDeltaBytes": 5284316,
      "heapUsedBytes": 85630912,
      "domNodes": -286,
      "jsHeapTotalBytes": 49152,
      "scriptDurationMs": 1015.9050000000001,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3235.2839999999787,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 7.358,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2133.895,
      "heapDeltaBytes": 7331712,
      "heapUsedBytes": 88329652,
      "domNodes": -286,
      "jsHeapTotalBytes": 573440,
      "scriptDurationMs": 977.097,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2016.5030000000002,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.846999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 627.8219999999999,
      "heapDeltaBytes": 21886952,
      "heapUsedBytes": 88563912,
      "domNodes": -273,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 32.349000000000004,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2035.429000000022,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 7.855999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 722.0360000000001,
      "heapDeltaBytes": 10218768,
      "heapUsedBytes": 88386800,
      "domNodes": -266,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 35.72199999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 646.1509999999748,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.299,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.9489999999999,
      "heapDeltaBytes": 15017548,
      "heapUsedBytes": 88336920,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 141.65,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 690.1500000000169,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.042,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 444.125,
      "heapDeltaBytes": 15029432,
      "heapUsedBytes": 88347896,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 145.44,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2031.7650000000071,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.149999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 575.507,
      "heapDeltaBytes": -8631320,
      "heapUsedBytes": 63893548,
      "domNodes": -295,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.414,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2039.5340000000033,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.140999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 589.36,
      "heapDeltaBytes": -5658420,
      "heapUsedBytes": 67284172,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.384999999999998,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1773.8410000000044,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 33.424,
      "layouts": 18,
      "layoutDurationMs": 5.984,
      "taskDurationMs": 961.1279999999998,
      "heapDeltaBytes": -15110296,
      "heapUsedBytes": 57748048,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 114.53700000000002,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1734.8240000000033,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 28.388999999999996,
      "layouts": 18,
      "layoutDurationMs": 5.365,
      "taskDurationMs": 935.1330000000002,
      "heapDeltaBytes": -6534564,
      "heapUsedBytes": 65689148,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 110.18700000000001,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.002000000025,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 29.310000000000002,
      "layouts": 14,
      "layoutDurationMs": 14.412999999999998,
      "taskDurationMs": 972.0780000000002,
      "heapDeltaBytes": 20798992,
      "heapUsedBytes": 103838900,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 32.99,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 138,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9826.927000000012,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 45.882999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6468.337,
      "heapDeltaBytes": 23879780,
      "heapUsedBytes": 100477496,
      "domNodes": -271,
      "jsHeapTotalBytes": -700416,
      "scriptDurationMs": 2773.733,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9915.267000000085,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 38.199000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6499.722999999999,
      "heapDeltaBytes": 18547544,
      "heapUsedBytes": 94530484,
      "domNodes": -247,
      "jsHeapTotalBytes": 86016,
      "scriptDurationMs": 2861.025,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15754.141000000003,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15249.64,
      "heapDeltaBytes": -15728184,
      "heapUsedBytes": 196023860,
      "domNodes": -8068,
      "jsHeapTotalBytes": -5824512,
      "scriptDurationMs": 246.79100000000003,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16163.24899999995,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15543.947,
      "heapDeltaBytes": -59463396,
      "heapUsedBytes": 179548428,
      "domNodes": -8072,
      "jsHeapTotalBytes": -15904768,
      "scriptDurationMs": 250.26,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19058.20900000003,
      "styleRecalcs": 137,
      "styleRecalcDurationMs": 18.547000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18797.572,
      "heapDeltaBytes": -39240072,
      "heapUsedBytes": 178654232,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15495168,
      "scriptDurationMs": 948.66,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 52,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19955.52399999997,
      "styleRecalcs": 150,
      "styleRecalcDurationMs": 20.071000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19619.078999999998,
      "heapDeltaBytes": -30117580,
      "heapUsedBytes": 188942164,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10350592,
      "scriptDurationMs": 933.4220000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 41,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5802.782999999977,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.43900000000001,
      "layouts": 20,
      "layoutDurationMs": 26.554999999999996,
      "taskDurationMs": 5711.424,
      "heapDeltaBytes": -57750236,
      "heapUsedBytes": 170339408,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10530816,
      "scriptDurationMs": 108.22300000000001,
      "eventListeners": -14928,
      "totalBlockingTimeMs": 362,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5830.200999999988,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.24399999999997,
      "layouts": 20,
      "layoutDurationMs": 25.915999999999993,
      "taskDurationMs": 5724.791999999999,
      "heapDeltaBytes": -40594484,
      "heapUsedBytes": 177348176,
      "domNodes": -8068,
      "jsHeapTotalBytes": 12308480,
      "scriptDurationMs": 115.8,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 289,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8080.225000000041,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7739.776000000001,
      "heapDeltaBytes": 11838044,
      "heapUsedBytes": 178249452,
      "domNodes": 0,
      "jsHeapTotalBytes": -12320768,
      "scriptDurationMs": 127.641,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8067.532000000028,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7890.108000000001,
      "heapDeltaBytes": 2125488,
      "heapUsedBytes": 179941680,
      "domNodes": 0,
      "jsHeapTotalBytes": -17301504,
      "scriptDurationMs": 130.251,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 481.50200000009136,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 23.171999999999997,
      "layouts": 4,
      "layoutDurationMs": 2.134,
      "taskDurationMs": 133.899,
      "heapDeltaBytes": 4890252,
      "heapUsedBytes": 73056292,
      "domNodes": 149,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 9.475,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 117.31899999995221,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 17.444,
      "layouts": 2,
      "layoutDurationMs": 1.4580000000000002,
      "taskDurationMs": 85.95,
      "heapDeltaBytes": 2936740,
      "heapUsedBytes": 72284788,
      "domNodes": 125,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 4.611000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50402 75602 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18608   +/-   ##
=============================================
  Coverage              ?   83.67%           
=============================================
  Files                 ?     2105           
  Lines                 ?   124656           
  Branches              ?    31604           
=============================================
  Hits                  ?   104304           
  Misses                ?    20173           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.67% <87.50%> (?)
unit 78.71% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...vueNodes/composables/processedWidgetRenderModel.ts 97.14% <100.00%> (ø)
src/types/nodeIdentification.ts 98.82% <100.00%> (ø)
src/utils/graphTraversalUtil.ts 99.38% <100.00%> (ø)
...nch/extensions/agent/crdt/agentNodeMaterializer.ts 98.80% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claude
claude Bot enabled auto-merge (squash) September 23, 2026 13:42
@comfy-pr-bot
comfy-pr-bot merged commit a55ce3d into cloud/1.54 Sep 23, 2026
102 of 106 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the claude/manual-backport-18604-cloud-1.54 branch September 23, 2026 17:31
christian-byrne pushed a commit that referenced this pull request Sep 23, 2026
…w node ids in locator/callback path (#18616) (#18618)

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_

Backport of #18616 to `cloud/1.54`.

Manual cherry-pick, same approach as #18608: `cloud/1.54` now has
#18604's execution-id fix (via #18608), and #18616 is the follow-up that
fixes the *sibling* locator-id path
(`createNodeLocatorId`/`locatorIdFromState`/`getNodeByLocatorId`), used
to resolve the live `LGraphNode` for widget callback dispatch and
navigation, for the same colon-bearing `insert_workflow` node ids.

## Before

Moving a widget on an `insert_workflow`-materialized node
(comfy-multi-player, PM-1580) updates the widget's stored value, but the
underlying node's `widget.callback` — which drives dependent UI,
control-after-generate, dynamic input wiring, etc. — never fires,
because `createNodeLocatorId` rejected the colon-bearing id and
`getHostNode` resolved no live `LGraphNode`. The same path also silently
broke "Enter Subgraph" navigation and promoted-widget preview locator
ids for these nodes.

## After

`createLeafNodeLocatorId` (mirroring `createLeafNodeExecutionId` from
#18604) keeps a root-level colon-bearing id whole instead of rejecting
it, while a genuinely subgraph-nested id still goes through the strict,
delimiter-aware path unchanged. `locatorIdFromState`,
`getNodeByLocatorId`, and the promoted-widget preview locator
(`widgetNodeLocatorId`) now agree on this leaf-tolerant
encoding/decoding, so `getHostNode` resolves the real `LGraphNode` and
`live.widget.callback` fires normally.

## Cherry-pick details

- Source commit: 5d85b04 (single
self-contained commit from #18616,
`claude/fix-node-locator-id-colon-rejection`)
- `git cherry-pick -m 1` applied cleanly onto `cloud/1.54` (post-#18608)
— no conflicts, since `nodeIdentification.ts`, `graphTraversalUtil.ts`,
and `processedWidgetRenderModel.ts` already had #18604/#18608's sibling
execution-id fix in place.
- Committer identity normalized to `claude[bot]` (author was already
`claude[bot]`; no AI co-author trailer was present in the original
commit body, so none needed stripping).

## Testing

- `pnpm vitest run` on `nodeIdentification.test.ts`,
`graphTraversalUtil.test.ts`, and `useProcessedWidgets.test.ts` (which
exercises `processedWidgetRenderModel.ts`'s `getHostNode`) against
`cloud/1.54`'s actual code — 186 tests passed.
- `vue-tsc --noEmit` — clean.
- `eslint` and `oxfmt --check` on all 6 touched files — clean.

Ref: #18616 (source PR, still open on `main` at cherry-pick time but
CI-green and single-commit)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY

---
_Generated by [Claude
Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
CodeJuggernaut pushed a commit that referenced this pull request Sep 23, 2026
…ets when execId derivation fails (PM-1580 follow-up) (#18608)

&lt;!-- ccr-slack-attribution --&gt;
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449?thread_ts=1790058330.774449&cid=C0BGH348Z0C)_

Backport of #18604 to `cloud/1.54`.

Opened manually: the `PR Backport` workflow (`pr-backport.yaml`) only
runs when the PR carries the `needs-backport` label — `core/1.54` +
`cloud/1.54` alone (added manually before merge) don't trigger it, so it
never ran at merge time. After adding `needs-backport`, the workflow did
run and this target (`cloud/1.54`) cherry-picked `035d9056b0` cleanly,
but the run's overall job still failed because the `core/1.54` target
hit a real conflict (that target is missing #18598 entirely, since its
own backport #18600 is still open/unmerged against `core/1.54`) — and
the workflow's "Cleanup stranded backport branches" step then deleted
the `cloud/1.54` branch it had just successfully pushed, because it runs
on `failure()` for the *job*, not per-target. So this clean backport
never got a PR from the bot despite succeeding.

Re-cherry-picked `035d9056b0` onto `cloud/1.54` (which already has
#18598 via #18601) by hand — clean apply, no conflicts.

`core/1.54` is intentionally not backported here: it needs #18600 (the
#18598 backport) merged first.

---
🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY

---
_Generated by [Claude
Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_

(cherry picked from commit a55ce3d)
CodeJuggernaut pushed a commit that referenced this pull request Sep 23, 2026
…w node ids in locator/callback path (#18616) (#18618)

<!-- ccr-slack-attribution -->
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790058330774449)_

Backport of #18616 to `cloud/1.54`.

Manual cherry-pick, same approach as #18608: `cloud/1.54` now has
#18604's execution-id fix (via #18608), and #18616 is the follow-up that
fixes the *sibling* locator-id path
(`createNodeLocatorId`/`locatorIdFromState`/`getNodeByLocatorId`), used
to resolve the live `LGraphNode` for widget callback dispatch and
navigation, for the same colon-bearing `insert_workflow` node ids.

## Before

Moving a widget on an `insert_workflow`-materialized node
(comfy-multi-player, PM-1580) updates the widget's stored value, but the
underlying node's `widget.callback` — which drives dependent UI,
control-after-generate, dynamic input wiring, etc. — never fires,
because `createNodeLocatorId` rejected the colon-bearing id and
`getHostNode` resolved no live `LGraphNode`. The same path also silently
broke "Enter Subgraph" navigation and promoted-widget preview locator
ids for these nodes.

## After

`createLeafNodeLocatorId` (mirroring `createLeafNodeExecutionId` from
#18604) keeps a root-level colon-bearing id whole instead of rejecting
it, while a genuinely subgraph-nested id still goes through the strict,
delimiter-aware path unchanged. `locatorIdFromState`,
`getNodeByLocatorId`, and the promoted-widget preview locator
(`widgetNodeLocatorId`) now agree on this leaf-tolerant
encoding/decoding, so `getHostNode` resolves the real `LGraphNode` and
`live.widget.callback` fires normally.

## Cherry-pick details

- Source commit: 5d85b04 (single
self-contained commit from #18616,
`claude/fix-node-locator-id-colon-rejection`)
- `git cherry-pick -m 1` applied cleanly onto `cloud/1.54` (post-#18608)
— no conflicts, since `nodeIdentification.ts`, `graphTraversalUtil.ts`,
and `processedWidgetRenderModel.ts` already had #18604/#18608's sibling
execution-id fix in place.
- Committer identity normalized to `claude[bot]` (author was already
`claude[bot]`; no AI co-author trailer was present in the original
commit body, so none needed stripping).

## Testing

- `pnpm vitest run` on `nodeIdentification.test.ts`,
`graphTraversalUtil.test.ts`, and `useProcessedWidgets.test.ts` (which
exercises `processedWidgetRenderModel.ts`'s `getHostNode`) against
`cloud/1.54`'s actual code — 186 tests passed.
- `vue-tsc --noEmit` — clean.
- `eslint` and `oxfmt --check` on all 6 touched files — clean.

Ref: #18616 (source PR, still open on `main` at cherry-pick time but
CI-green and single-commit)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY

---
_Generated by [Claude
Code](https://claude.ai/code/session_01UqyourCBfi97xzpBx2W7oY)_

(cherry picked from commit 0ec045e)
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-test-unit Touches Agent-related unit/component tests or their support backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants