Skip to content

[backport cloud/1.54] fix(agent): signal the onboarding overlay only while a coach card is on screen - #18565

Merged
christian-byrne merged 1 commit into
cloud/1.54from
backport-18439-to-cloud-1.54
Sep 23, 2026
Merged

christian-byrne merged 1 commit into
cloud/1.54from
backport-18439-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #18439 to cloud/1.54

Automatically created by backport workflow.

…on screen (#18439)

## Summary

The Agent coach told the What's New popup to stay away from the moment
it mounted, even when its own card was not on screen yet. If a coach
step's target never mounts, that held the popup back for the whole
session with nothing visible to dismiss. The signal now follows the card
itself.

Follow-up to #18287.

## Changes

- `OnboardingCoach.vue` registers its overlay source as `active &&
target !== null`, the same condition the template renders on, through
one `visible` computed used by both.
- `OnboardingCoach.test.ts` pins that the overlay stays clear while the
target is absent and turns on once a late target mounts.

## Review Focus

The popup hides a tick later than before: after the target resolves
rather than at mount. `WhatsNewPopup.vue` gates on a reactive `v-if` and
showing it writes no seen flag, so nothing is burned in that window.

## QA

- [x] Unit: 71 passing across `OnboardingCoach`, `releaseStore` and
`onboardingOverlayStore`
- [x] Revert-red: the tightened target-absent test fails on the previous
source and passes on this one
- [x] Manual: open the Agent panel with the chat history view showing
(no `#agent-composer` on screen), confirm the What's New popup is not
withheld
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 23, 2026
@comfy-pr-bot
comfy-pr-bot enabled auto-merge (squash) September 23, 2026 06:49
@vercel

vercel Bot commented Sep 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 6:49am UTC

Request Review

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 07:12:25 AM UTC

Links

🎭 Playwright: ✅ 1940 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1919 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 145ms TBT · 101.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.0 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 112ms TBT · 158.2 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 402ms TBT · 171.7 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 493ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 58.3 MB
canvas-idle: DOM nodes -132
canvas-idle: event listeners -95
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 33ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 963ms
canvas-mouse-sweep: script duration 177ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.2 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 367ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.2 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 445ms
dom-widget-clipping: script duration 158ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.4 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 634ms
large-graph-idle: script duration 32ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 75.4 MB
large-graph-idle: DOM nodes -278
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1650ms
large-graph-pan: script duration 825ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 79.3 MB
large-graph-pan: DOM nodes -256
large-graph-pan: event listeners -177
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1703ms
large-graph-zoom: script duration 775ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 82.6 MB
large-graph-zoom: DOM nodes 4
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1897ms
legacy-node-drag: script duration 947ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.8 MB
legacy-node-drag: DOM nodes -139
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 8ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 632ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.2 MB
minimap-idle: DOM nodes -277
minimap-idle: event listeners -193
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 410ms
subgraph-dom-widget-clipping: script duration 142ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.9 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 489ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 70.3 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 26ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 816ms
subgraph-mouse-sweep: script duration 108ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 66.9 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 963ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 145ms
subgraph-transition-enter: heap used 101.5 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 33ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5804ms
viewport-pan-sweep: script duration 2649ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.3 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -147
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16186ms
vue-large-graph-idle: script duration 275ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.0 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 16ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 164
vue-large-graph-pan: task duration 19936ms
vue-large-graph-pan: script duration 926ms
vue-large-graph-pan: TBT 112ms
vue-large-graph-pan: heap used 158.2 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 22ms
vue-node-resize-workload: style recalc duration 80ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5975ms
vue-node-resize-workload: script duration 113ms
vue-node-resize-workload: TBT 402ms
vue-node-resize-workload: heap used 171.7 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8270ms
vue-zoom-out-idle: script duration 155ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 168.4 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 3
workflow-execution: style recalc count 19
workflow-execution: task duration 117ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.6 MB
workflow-execution: DOM nodes 146
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-09-23T07:13:53.145Z",
  "gitSha": "f6701a7038f65dd83238398239c68b45179e7c70",
  "branch": "backport-18439-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2007.8550000000064,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.095,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 424.687,
      "heapDeltaBytes": 714756,
      "heapUsedBytes": 64682256,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 7.550000000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2055.2210000000173,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.308000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 561.9860000000001,
      "heapDeltaBytes": -11970812,
      "heapUsedBytes": 57589828,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 11.725000000000003,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2049.9869999999873,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 33.734,
      "layouts": 14,
      "layoutDurationMs": 4.523,
      "taskDurationMs": 1007.219,
      "heapDeltaBytes": -2292364,
      "heapUsedBytes": 66838188,
      "domNodes": -280,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 185.149,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1890.2929999999856,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 31.387999999999998,
      "layouts": 14,
      "layoutDurationMs": 4.571000000000001,
      "taskDurationMs": 919.3280000000001,
      "heapDeltaBytes": -6335540,
      "heapUsedBytes": 63577344,
      "domNodes": -278,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 168.387,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1719.1100000000006,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.224,
      "layouts": 6,
      "layoutDurationMs": 0.9680000000000001,
      "taskDurationMs": 350.942,
      "heapDeltaBytes": 4615924,
      "heapUsedBytes": 75790144,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 9.981,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1682.2910000000775,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.410000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.0710000000000002,
      "taskDurationMs": 384.012,
      "heapDeltaBytes": 4636600,
      "heapUsedBytes": 75700432,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.975,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 631.9270000000188,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.890999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 437.977,
      "heapDeltaBytes": 18717728,
      "heapUsedBytes": 88341672,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 157.12099999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 655.272000000025,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.219,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 451.6479999999999,
      "heapDeltaBytes": 18783284,
      "heapUsedBytes": 88697772,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 158.73,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2089.856999999995,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 8.578,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 607.589,
      "heapDeltaBytes": 8603744,
      "heapUsedBytes": 84561576,
      "domNodes": -273,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 28.673999999999992,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2030.4210000000467,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.759999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 660.1560000000001,
      "heapDeltaBytes": -2914704,
      "heapUsedBytes": 73463328,
      "domNodes": -283,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 35.955,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2207.558000000006,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.419,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1586.0919999999999,
      "heapDeltaBytes": 8199872,
      "heapUsedBytes": 84980968,
      "domNodes": -272,
      "jsHeapTotalBytes": -929792,
      "scriptDurationMs": 793.177,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2406.406000000061,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 15.645,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1713.4799999999998,
      "heapDeltaBytes": 4063732,
      "heapUsedBytes": 81276004,
      "domNodes": -239,
      "jsHeapTotalBytes": 380928,
      "scriptDurationMs": 856.992,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3417.2400000000493,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 8.794,
      "layouts": 60,
      "layoutDurationMs": 11.155,
      "taskDurationMs": 1606.9260000000002,
      "heapDeltaBytes": 11759572,
      "heapUsedBytes": 79820060,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 751.216,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3766.860999999949,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.635000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.357000000000001,
      "taskDurationMs": 1799.134,
      "heapDeltaBytes": 14615212,
      "heapUsedBytes": 93379572,
      "domNodes": 8,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 798.3340000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2986.9070000000306,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.097,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1882.125,
      "heapDeltaBytes": 13774100,
      "heapUsedBytes": 81563236,
      "domNodes": 2,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 956.3219999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3095.2330000000075,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.512,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1911.4429999999998,
      "heapDeltaBytes": 18814128,
      "heapUsedBytes": 85770168,
      "domNodes": -279,
      "jsHeapTotalBytes": 1990656,
      "scriptDurationMs": 937.437,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2071.393999999998,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.062999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 615.1379999999999,
      "heapDeltaBytes": 6634160,
      "heapUsedBytes": 83915484,
      "domNodes": -278,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 29.313000000000006,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2072.5259999999253,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 9.371,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 648.27,
      "heapDeltaBytes": 6774760,
      "heapUsedBytes": 84335408,
      "domNodes": -276,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 37.769999999999996,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 589.4440000000145,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.899,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 400.04699999999997,
      "heapDeltaBytes": 14757756,
      "heapUsedBytes": 88018532,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 141.127,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 591.4450000000215,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.364999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 419.67699999999996,
      "heapDeltaBytes": 15005856,
      "heapUsedBytes": 87917336,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 142.59199999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2002.7300000000423,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.841000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 473.65599999999995,
      "heapDeltaBytes": -6246828,
      "heapUsedBytes": 65744440,
      "domNodes": -297,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.352999999999998,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.8949999999722,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.313,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 503.4799999999999,
      "heapDeltaBytes": 8541948,
      "heapUsedBytes": 81726344,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.719000000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1713.7450000000172,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 24.816000000000003,
      "layouts": 18,
      "layoutDurationMs": 4.944999999999999,
      "taskDurationMs": 790.385,
      "heapDeltaBytes": 4057484,
      "heapUsedBytes": 75683316,
      "domNodes": -298,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 105.03800000000001,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1765.8220000000142,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 27.280000000000005,
      "layouts": 18,
      "layoutDurationMs": 4.626,
      "taskDurationMs": 842.0759999999999,
      "heapDeltaBytes": -7387936,
      "heapUsedBytes": 64575380,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 111.683,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1384.4369999999913,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 33.132999999999996,
      "layouts": 15,
      "layoutDurationMs": 16.172,
      "taskDurationMs": 963.2010000000002,
      "heapDeltaBytes": 21954576,
      "heapUsedBytes": 106403360,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 33.171,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 145,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8314.127999999982,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 32.116,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5596.755,
      "heapDeltaBytes": -13743020,
      "heapUsedBytes": 89192124,
      "domNodes": -270,
      "jsHeapTotalBytes": -368640,
      "scriptDurationMs": 2610.792,
      "eventListeners": -148,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8867.728000000057,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 34.196000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6011.504999999999,
      "heapDeltaBytes": -17830140,
      "heapUsedBytes": 85426324,
      "domNodes": -267,
      "jsHeapTotalBytes": -1187840,
      "scriptDurationMs": 2686.335,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16419.88399999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15596.795,
      "heapDeltaBytes": -41547024,
      "heapUsedBytes": 176347932,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12333056,
      "scriptDurationMs": 266.215,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17379.97400000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16775.443,
      "heapDeltaBytes": -59997696,
      "heapUsedBytes": 178087284,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16932864,
      "scriptDurationMs": 283.149,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 19967.74099999999,
      "styleRecalcs": 165,
      "styleRecalcDurationMs": 15.373999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 19619.840999999997,
      "heapDeltaBytes": -64868396,
      "heapUsedBytes": 166723248,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19050496,
      "scriptDurationMs": 914.969,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 149,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20536.773000000037,
      "styleRecalcs": 163,
      "styleRecalcDurationMs": 17.262,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20252.296000000002,
      "heapDeltaBytes": -54140484,
      "heapUsedBytes": 165134880,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11853824,
      "scriptDurationMs": 936.3050000000001,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 74,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6030.092000000024,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 83.12600000000003,
      "layouts": 20,
      "layoutDurationMs": 22.587999999999983,
      "taskDurationMs": 5924.947,
      "heapDeltaBytes": -40617572,
      "heapUsedBytes": 176968276,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10788864,
      "scriptDurationMs": 119.505,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 405,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6142.951999999923,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.49300000000004,
      "layouts": 20,
      "layoutDurationMs": 21.73499999999999,
      "taskDurationMs": 6024.863000000001,
      "heapDeltaBytes": -43422292,
      "heapUsedBytes": 183166716,
      "domNodes": -8068,
      "jsHeapTotalBytes": 15036416,
      "scriptDurationMs": 106.02799999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 399,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8529.833999999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8284.927,
      "heapDeltaBytes": 16827540,
      "heapUsedBytes": 176568864,
      "domNodes": 0,
      "jsHeapTotalBytes": -14417920,
      "scriptDurationMs": 154.01200000000003,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8426.74700000009,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8255.423999999999,
      "heapDeltaBytes": 13871808,
      "heapUsedBytes": 176607812,
      "domNodes": 0,
      "jsHeapTotalBytes": -17039360,
      "scriptDurationMs": 155.05199999999996,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 493.4379999999692,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 26.352,
      "layouts": 4,
      "layoutDurationMs": 1.625,
      "taskDurationMs": 136.494,
      "heapDeltaBytes": 4980828,
      "heapUsedBytes": 74080132,
      "domNodes": 147,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.548,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 453.3880000000181,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 18.398999999999997,
      "layouts": 2,
      "layoutDurationMs": 0.9310000000000002,
      "taskDurationMs": 98.138,
      "heapDeltaBytes": 4876524,
      "heapUsedBytes": 74016008,
      "domNodes": 144,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.619000000000001,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50311 75509 66.6% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18565   +/-   ##
=============================================
  Coverage              ?   83.66%           
=============================================
  Files                 ?     2100           
  Lines                 ?   124243           
  Branches              ?    33593           
=============================================
  Hits                  ?   103951           
  Misses                ?    20114           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.63% <ø> (?)
unit 78.70% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ensions/agent/components/agent/OnboardingCoach.vue 97.29% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Exact-head CI blocker routed to source owner @MaanilVerma: on head c039ac97070e664656dcd55f33a26039cbf7591e, the cloud project failed tests/agent/agentToolCallHistoryPersistence.spec.ts:24 (keeps a completed turn work summary after a browser refresh) in all four attempts because the Worked button never appeared. The uploaded report records retries 0–3 failing the same getByRole('button', { name: 'Worked', exact: true }) visibility assertion. Job: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35828572470/job/107080348343

The paired core carrier #18564 reproduced the identical four-attempt failure in https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35828561963/job/107080081637. This carrier changes only OnboardingCoach.vue and its unit test, so the shared symptom is precise but causality is not established. Please determine whether the source change can suppress the completed-turn work summary or whether this is a common cloud-fixture failure. No rerun or speculative code change was made.

@datadog-official

datadog-official Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 2 Pipeline jobs failed

CI: Tests E2E | playwright-tests (cloud) — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

CI: Tests E2E | e2e-status

View in Datadog · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c039ac9 | Docs | View more details | Give us feedback!

@christian-byrne
christian-byrne merged commit 22e8424 into cloud/1.54 Sep 23, 2026
152 of 161 checks passed
@christian-byrne
christian-byrne deleted the backport-18439-to-cloud-1.54 branch September 23, 2026 09:40
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-onboarding Agent consent, first-use tour or onboarding gates agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-onboarding Agent consent, first-use tour or onboarding gates agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants