Skip to content

[backport cloud/1.54] fix(agent): dismiss resolved paywalls (#18405) - #18567

Merged
christian-byrne merged 2 commits into
cloud/1.54from
backport-18405-to-cloud-1.54
Sep 23, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
backport-18405-to-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backport of #18405 to cloud/1.54. Resolves stale in-chat paywalls when billing confirms the workspace has funds while preserving later admission paywalls.

Conflict resolution and verification

The carrier preserves the release line's billing-capability readiness fallback, adds the funded-workspace watcher and store transition, reuses existing owner-action coverage, and adapts the new regression to the release line's TurnId fixture.

  • Focused store suite passed.
  • Focused paywall regression passed.
  • Commit hooks passed: oxfmt, Stylelint, type-aware Oxlint, ESLint, and typecheck.
  • Push hook Knip passed.
  • Source merge: d831494ab58e8c80d0450ab84d3b888a45792559.

Preserve the release line's billing-capability readiness behavior while adding funded-workspace paywall resolution. Reuse the release line's existing owner-action coverage and adapt the new regression to its TurnId fixture.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0cc9a-2a62-7798-bf72-f927dbe15973
@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 7:35am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: abbbd195-d953-4695-b4ce-949aa9640aa2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1945 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1924 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 07:47:53 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.1 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.6 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.1 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 89ms TBT · 104.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 166.3 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 7ms TBT · 172.2 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 220ms TBT · 172.1 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 421ms
canvas-idle: script duration 8ms
canvas-idle: TBT 0ms
canvas-idle: heap used 70.1 MB
canvas-idle: DOM nodes -128
canvas-idle: event listeners -96
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 23ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 715ms
canvas-mouse-sweep: script duration 123ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.1 MB
canvas-mouse-sweep: DOM nodes -278
canvas-mouse-sweep: event listeners -179
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 13ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 289ms
canvas-zoom-sweep: script duration 10ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.7 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 366ms
dom-widget-clipping: script duration 126ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.6 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 7ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 8
large-graph-idle: task duration 509ms
large-graph-idle: script duration 30ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.3 MB
large-graph-idle: DOM nodes -267
large-graph-idle: event listeners -176
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 13ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 68
large-graph-pan: task duration 1395ms
large-graph-pan: script duration 648ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 77.6 MB
large-graph-pan: DOM nodes -260
large-graph-pan: event listeners -190
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 64
large-graph-zoom: task duration 1436ms
large-graph-zoom: script duration 634ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 76.5 MB
large-graph-zoom: DOM nodes -283
large-graph-zoom: event listeners -94
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 45
legacy-node-drag: task duration 1625ms
legacy-node-drag: script duration 778ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 78.1 MB
legacy-node-drag: DOM nodes -260
legacy-node-drag: event listeners -11
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 7
minimap-idle: task duration 492ms
minimap-idle: script duration 28ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.7 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -190
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 324ms
subgraph-dom-widget-clipping: script duration 110ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.3 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 398ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 57.8 MB
subgraph-idle: DOM nodes -298
subgraph-idle: event listeners -210
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 24ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 675ms
subgraph-mouse-sweep: script duration 89ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 63.8 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -241
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 25ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 723ms
subgraph-transition-enter: script duration 21ms
subgraph-transition-enter: TBT 89ms
subgraph-transition-enter: heap used 104.5 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 4777ms
viewport-pan-sweep: script duration 2134ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 81.7 MB
viewport-pan-sweep: DOM nodes -255
viewport-pan-sweep: event listeners -159
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14220ms
vue-large-graph-idle: script duration 227ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 166.3 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14933
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 14ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 148
vue-large-graph-pan: task duration 16791ms
vue-large-graph-pan: script duration 706ms
vue-large-graph-pan: TBT 7ms
vue-large-graph-pan: heap used 172.2 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14931
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 21ms
vue-node-resize-workload: style recalc duration 62ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5104ms
vue-node-resize-workload: script duration 84ms
vue-node-resize-workload: TBT 220ms
vue-node-resize-workload: heap used 172.1 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14929
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7198ms
vue-zoom-out-idle: script duration 105ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.5 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -9
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 11ms
workflow-execution: layout count 2
workflow-execution: style recalc count 6
workflow-execution: task duration 53ms
workflow-execution: script duration 4ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.2 MB
workflow-execution: DOM nodes 125
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-09-23T07:53:52.487Z",
  "gitSha": "0af22c7f03c916019ca6daa40803f6ca634347ef",
  "branch": "backport-18405-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2054.989999999975,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.299000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.26900000000006,
      "heapDeltaBytes": 5799164,
      "heapUsedBytes": 76074852,
      "domNodes": -277,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 8.587000000000002,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2000.8809999999926,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.046,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 367.786,
      "heapDeltaBytes": 1507124,
      "heapUsedBytes": 70944468,
      "domNodes": 22,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 7.071000000000001,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1708.800999999994,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 22.816000000000003,
      "layouts": 14,
      "layoutDurationMs": 3.6550000000000002,
      "taskDurationMs": 708.257,
      "heapDeltaBytes": 195204,
      "heapUsedBytes": 71254156,
      "domNodes": -277,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 125.21100000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1706.719000000021,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 22.961000000000002,
      "layouts": 14,
      "layoutDurationMs": 3.569,
      "taskDurationMs": 721.708,
      "heapDeltaBytes": -3788788,
      "heapUsedBytes": 67298296,
      "domNodes": -279,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 120.422,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1673.6250000000155,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.126,
      "layouts": 6,
      "layoutDurationMs": 0.935,
      "taskDurationMs": 298.416,
      "heapDeltaBytes": 4355776,
      "heapUsedBytes": 74548480,
      "domNodes": 77,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.436999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1665.4869999999846,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 12.458,
      "layouts": 6,
      "layoutDurationMs": 0.8490000000000001,
      "taskDurationMs": 278.58900000000006,
      "heapDeltaBytes": 4302984,
      "heapUsedBytes": 73636940,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 9.464,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 513.7419999999793,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.763,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 356.244,
      "heapDeltaBytes": 18409280,
      "heapUsedBytes": 88686032,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 121.43699999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 540.2839999999856,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.546,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 374.902,
      "heapDeltaBytes": 18326504,
      "heapUsedBytes": 88707404,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 130.517,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.799999999999727
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2022.198000000003,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.441,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 518.4449999999998,
      "heapDeltaBytes": 9265668,
      "heapUsedBytes": 85259224,
      "domNodes": -267,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 29.735000000000003,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2019.326000000035,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.085000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.6560000000001,
      "heapDeltaBytes": 10753940,
      "heapUsedBytes": 87293576,
      "domNodes": -266,
      "jsHeapTotalBytes": -2990080,
      "scriptDurationMs": 30.593999999999998,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2242.482999999993,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.227000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1407.845,
      "heapDeltaBytes": 6750460,
      "heapUsedBytes": 84007960,
      "domNodes": -241,
      "jsHeapTotalBytes": -1191936,
      "scriptDurationMs": 651.5799999999999,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2201.9050000000107,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 13.149999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1381.773,
      "heapDeltaBytes": 1451000,
      "heapUsedBytes": 78677548,
      "domNodes": -279,
      "jsHeapTotalBytes": -929792,
      "scriptDurationMs": 645.1600000000001,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3365.534000000025,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 13.173,
      "layouts": 60,
      "layoutDurationMs": 12.118,
      "taskDurationMs": 1502.17,
      "heapDeltaBytes": 4989952,
      "heapUsedBytes": 84087596,
      "domNodes": -288,
      "jsHeapTotalBytes": 4087808,
      "scriptDurationMs": 653.284,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3171.2099999999737,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 11.142000000000003,
      "layouts": 60,
      "layoutDurationMs": 11.276,
      "taskDurationMs": 1370.3529999999998,
      "heapDeltaBytes": 9486668,
      "heapUsedBytes": 76289244,
      "domNodes": -277,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 614.7589999999999,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2392.1020000000226,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.448,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1632.7589999999998,
      "heapDeltaBytes": 1646252,
      "heapUsedBytes": 82046780,
      "domNodes": -246,
      "jsHeapTotalBytes": -737280,
      "scriptDurationMs": 784.8870000000001,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2293.57600000003,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 7.408000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1617.5550000000003,
      "heapDeltaBytes": 638640,
      "heapUsedBytes": 81759192,
      "domNodes": -274,
      "jsHeapTotalBytes": -1523712,
      "scriptDurationMs": 770.597,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.7200000000212,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.215,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.98199999999997,
      "heapDeltaBytes": 4716624,
      "heapUsedBytes": 82933868,
      "domNodes": -271,
      "jsHeapTotalBytes": -892928,
      "scriptDurationMs": 27.053,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2028.9510000000064,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.35,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 488.092,
      "heapDeltaBytes": 8058752,
      "heapUsedBytes": 86340120,
      "domNodes": -272,
      "jsHeapTotalBytes": -2203648,
      "scriptDurationMs": 29.274,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 508.8000000000079,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 9.763,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 330.54699999999997,
      "heapDeltaBytes": 14229784,
      "heapUsedBytes": 86711396,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 110.689,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 507.30799999996634,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 7.817000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 317.77,
      "heapDeltaBytes": 14654280,
      "heapUsedBytes": 88044684,
      "domNodes": 16,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 110.142,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2001.4340000000175,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.103000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 407.2100000000001,
      "heapDeltaBytes": -10223684,
      "heapUsedBytes": 62665648,
      "domNodes": -297,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.386,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2008.7199999999825,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.6000000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 389.529,
      "heapDeltaBytes": -14575760,
      "heapUsedBytes": 58466444,
      "domNodes": -299,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 6.8850000000000025,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1724.786999999992,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 22.641000000000002,
      "layouts": 18,
      "layoutDurationMs": 4.031999999999999,
      "taskDurationMs": 654.071,
      "heapDeltaBytes": -5843676,
      "heapUsedBytes": 67360752,
      "domNodes": -295,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 85.292,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1693.4999999999718,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 24.558000000000003,
      "layouts": 18,
      "layoutDurationMs": 4.682,
      "taskDurationMs": 695.94,
      "heapDeltaBytes": -6805304,
      "heapUsedBytes": 66453236,
      "domNodes": -296,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 92.067,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 916.9949999999858,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 24.623000000000005,
      "layouts": 17,
      "layoutDurationMs": 11.945,
      "taskDurationMs": 722.996,
      "heapDeltaBytes": 21103452,
      "heapUsedBytes": 109589752,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 21.490000000000002,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 89,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8425.675000000012,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 38.024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4868.852,
      "heapDeltaBytes": 6429684,
      "heapUsedBytes": 82518176,
      "domNodes": -241,
      "jsHeapTotalBytes": 2740224,
      "scriptDurationMs": 2147.657,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8303.55099999997,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.054,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4685.399,
      "heapDeltaBytes": 13134560,
      "heapUsedBytes": 88858408,
      "domNodes": -269,
      "jsHeapTotalBytes": -1191936,
      "scriptDurationMs": 2120.3280000000004,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14762.387999999988,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14180.971,
      "heapDeltaBytes": -53683204,
      "heapUsedBytes": 170275524,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16457728,
      "scriptDurationMs": 244.10099999999997,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14640.743000000042,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14259.445,
      "heapDeltaBytes": -39507056,
      "heapUsedBytes": 178539356,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10489856,
      "scriptDurationMs": 209.628,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17020.061999999994,
      "styleRecalcs": 154,
      "styleRecalcDurationMs": 14.346999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16578.986,
      "heapDeltaBytes": -49217872,
      "heapUsedBytes": 168763652,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11792384,
      "scriptDurationMs": 703.769,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17329.221000000074,
      "styleRecalcs": 142,
      "styleRecalcDurationMs": 14.350000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17002.958999999995,
      "heapDeltaBytes": -26063604,
      "heapUsedBytes": 192421836,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9781248,
      "scriptDurationMs": 707.3790000000001,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 11,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5215.944000000036,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 62.361,
      "layouts": 20,
      "layoutDurationMs": 20.791000000000004,
      "taskDurationMs": 5094.582,
      "heapDeltaBytes": -36484716,
      "heapUsedBytes": 182288120,
      "domNodes": -8068,
      "jsHeapTotalBytes": 16818176,
      "scriptDurationMs": 81.20400000000001,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 201,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5191.967999999974,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 61.193000000000026,
      "layouts": 20,
      "layoutDurationMs": 21.061999999999998,
      "taskDurationMs": 5113.8369999999995,
      "heapDeltaBytes": -36465640,
      "heapUsedBytes": 178581032,
      "domNodes": -8068,
      "jsHeapTotalBytes": 15482880,
      "scriptDurationMs": 87.69700000000002,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 239,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7302.57899999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7119.083000000001,
      "heapDeltaBytes": 18526852,
      "heapUsedBytes": 179634332,
      "domNodes": 0,
      "jsHeapTotalBytes": -17825792,
      "scriptDurationMs": 104.57300000000002,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7424.2249999999785,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7277.571,
      "heapDeltaBytes": 21445220,
      "heapUsedBytes": 180125112,
      "domNodes": 0,
      "jsHeapTotalBytes": -9437184,
      "scriptDurationMs": 106.35100000000003,
      "eventListeners": -8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 81.84399999998959,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 11.386000000000001,
      "layouts": 2,
      "layoutDurationMs": 1.165,
      "taskDurationMs": 57.73900000000001,
      "heapDeltaBytes": 3069232,
      "heapUsedBytes": 71391872,
      "domNodes": 127,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.879,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66666666666665,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 69.73100000004706,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 9.616,
      "layouts": 2,
      "layoutDurationMs": 0.9510000000000002,
      "taskDurationMs": 47.94399999999999,
      "heapDeltaBytes": 2985528,
      "heapUsedBytes": 71715704,
      "domNodes": 122,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 3.602000000000001,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Shepherd recovery packet (2026-09-23 07:25 UTC): this open, mergeable carrier remains exact at head 371245fc3791e120f8997eecd8aac829a4a1d2af over unchanged cloud/1.54 tip f738dc12760b8ffa029b638e0089054d9a878c98. It backports source merge d831494ab58e8c80d0450ab84d3b888a45792559; the conflict adaptation and targeted regression passed locally, and commit/push hooks passed.

Hosted qualification currently has 45 passing checks, 25 pending, and no failures. There are zero unresolved review threads; independent review is requested from huang47 and no review has arrived. Do not merge until the same head/base has terminal non-adverse checks; then the pre-existing explicit admin-merge grant for #18405 may be used if review remains the only blocker. No force-push, hook bypass, or merge was performed.

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...sions/agent/stores/agent/agentConversationStore.ts 87.50% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18567   +/-   ##
=============================================
  Coverage              ?   78.70%           
=============================================
  Files                 ?     2010           
  Lines                 ?   111261           
  Branches              ?    31467           
=============================================
  Hits                  ?    87567           
  Misses                ?    23515           
  Partials              ?      179           
Flag Coverage Δ
unit 78.70% <92.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/AgentPanelRoot.vue 93.65% <100.00%> (ø)
...sions/agent/stores/agent/agentConversationStore.ts 98.36% <87.50%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor Author

Shepherd blocker update: exact head 371245fc3791e120f8997eecd8aac829a4a1d2af is not eligible to merge. The cloud Playwright job failed, while unit, lint/format, billing regressions, and all 16 Chromium shards passed. The uploaded report shows tests/agent/agentToolCallHistoryPersistence.spec.ts (“keeps a completed turn work summary after a browser refresh”) failed on all four attempts because the Worked control never appeared.

Five aggregation checks remain pending; review is still requested from huang47, with no reviews or unresolved threads. cloud/1.54 has advanced by one unrelated compatibility backport to 74deecaac3b248ecc9b1c1a3362fb85d3b0eb627 since this PR’s base snapshot. The explicit admin grant cannot be used while this adverse check remains. No merge, rerun, or branch rewrite was performed. Failure: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35829303424/job/107081939406

@datadog-official

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 2 Pipeline jobs failed

CI: Tests E2E | playwright-tests (cloud) — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

CI: Tests E2E | e2e-status

View in Datadog · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 2292698 | Docs | View more details | Give us feedback!

@christian-byrne
christian-byrne merged commit e1e63cf into cloud/1.54 Sep 23, 2026
88 of 90 checks passed
@christian-byrne
christian-byrne deleted the backport-18405-to-cloud-1.54 branch September 23, 2026 08:13

Copy link
Copy Markdown
Contributor Author

Merged the canonical cloud backport at exact refreshed head 2292698382a05e63898b51a45126849e68be0039 into target tip 74deecaac3b248ecc9b1c1a3362fb85d3b0eb627; merge commit is e1e63cf23947ea5dffd9f6dce02b7ec5d5938dc2. Target readback equals that merge commit.

Override basis: all checks were terminal; the only adverse checks were cloud Playwright and its aggregate. The sole unexpected test, keeps a completed turn work summary after a browser refresh, failed all four attempts identically on this head and on unrelated agent backports #18565 and #18564, while the exact cloud target-tip qualification in #18473 passed. There were no review threads or substantive objections. Admin merge used Christian’s explicit authorization.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-billing Agent admission limits, credits, subscriptions or paywalls agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-billing Agent admission limits, credits, subscriptions or paywalls agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants