Repository navigation
fix: drag an asset out of the panel in list view, not only grid (PM-1401) - #18174
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughChangesThe change centralizes asset drag payload creation in Asset drag-and-drop
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant User
participant AssetsSidebarListView
participant startAssetDrag
participant Canvas
User->>AssetsSidebarListView: drag asset row
AssetsSidebarListView->>startAssetDrag: pass drag event and asset
startAssetDrag->>Canvas: publish asset metadata and file URL
Canvas-->>User: load workflow tab and graph nodes
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 3❌ Failed checks (3 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Git: CodeRabbit could not clone the repository, so clone-backed analysis was skipped and this review may be incomplete. Verify repository clone access, such as SSH credentials, before requesting another full review. If clone access is intentionally unavailable, use Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2043 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 2fd052d1a5bfab0baa0f8c9c4e0db18946774979
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle: 9.93 MB gzip 🔴 +694 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • 🔴 +1.08 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 73 added / 73 removed / 227 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T04:46:23.969Z",
"gitSha": "c395e1a1caec42478a093999ca8dbd158e29fc04",
"branch": "fix/asset-list-view-drag-pm-1401",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1991.232000000025,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.248000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 341.04,
"heapDeltaBytes": 356672,
"heapUsedBytes": 62463156,
"domNodes": -260,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.683000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2009.9739999999997,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.490000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.31100000000004,
"heapDeltaBytes": 14912588,
"heapUsedBytes": 76672548,
"domNodes": -260,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 6.438000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1689.8889999999938,
"styleRecalcs": 74,
"styleRecalcDurationMs": 18.231,
"layouts": 14,
"layoutDurationMs": 2.9810000000000003,
"taskDurationMs": 615.4110000000001,
"heapDeltaBytes": 617092,
"heapUsedBytes": 62299496,
"domNodes": -259,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 99.621,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.6699999999973,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.939000000000004,
"layouts": 14,
"layoutDurationMs": 2.868,
"taskDurationMs": 583.021,
"heapDeltaBytes": -2416000,
"heapUsedBytes": 64856668,
"domNodes": -261,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 100.95700000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.7090000000085,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.430000000000001,
"layouts": 6,
"layoutDurationMs": 0.9279999999999999,
"taskDurationMs": 219.007,
"heapDeltaBytes": 2153928,
"heapUsedBytes": 64235092,
"domNodes": 75,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 7.714,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.8969999999886,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.794,
"layouts": 6,
"layoutDurationMs": 0.948,
"taskDurationMs": 231.846,
"heapDeltaBytes": 1900432,
"heapUsedBytes": 64261068,
"domNodes": 75,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 8.336000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 525.9379999999965,
"styleRecalcs": 11,
"styleRecalcDurationMs": 5.235,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.76,
"heapDeltaBytes": 17900152,
"heapUsedBytes": 79976280,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 118.13,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 442.3430000000508,
"styleRecalcs": 13,
"styleRecalcDurationMs": 5.3629999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 285.099,
"heapDeltaBytes": 18343540,
"heapUsedBytes": 79613048,
"domNodes": 21,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 100.339,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2009.4490000000178,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.778,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.351,
"heapDeltaBytes": 2590944,
"heapUsedBytes": 82492160,
"domNodes": -238,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 23.976999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2008.3970000000022,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.714,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.968,
"heapDeltaBytes": 1699228,
"heapUsedBytes": 79641188,
"domNodes": -241,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 23.238000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2059.870999999987,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.66,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1038.204,
"heapDeltaBytes": 17972696,
"heapUsedBytes": 82523352,
"domNodes": 12,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 503.8429999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2089.722999999992,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.188999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1016.7969999999999,
"heapDeltaBytes": -6458284,
"heapUsedBytes": 75382568,
"domNodes": -244,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 484.21599999999995,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3056.3229999999635,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.481,
"layouts": 60,
"layoutDurationMs": 10.512,
"taskDurationMs": 1195.873,
"heapDeltaBytes": -7545632,
"heapUsedBytes": 73820128,
"domNodes": -249,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 512.167,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3044.4249999999897,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.681,
"layouts": 60,
"layoutDurationMs": 9.424,
"taskDurationMs": 1174.0499999999997,
"heapDeltaBytes": -8685064,
"heapUsedBytes": 73536284,
"domNodes": -250,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 484.953,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2169.1319999999905,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.648000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1243.1000000000001,
"heapDeltaBytes": 6992164,
"heapUsedBytes": 72552440,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 601.123,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2155.3910000000087,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.143999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1083.955,
"heapDeltaBytes": 15655264,
"heapUsedBytes": 80385040,
"domNodes": -251,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 566.513,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2014.4260000000145,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.5849999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.5900000000001,
"heapDeltaBytes": 19771180,
"heapUsedBytes": 83356084,
"domNodes": -243,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 20.304000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2020.1070000000527,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.949,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.47799999999995,
"heapDeltaBytes": -6675356,
"heapUsedBytes": 81645224,
"domNodes": -242,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 28.221999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 432.5099999999793,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.215000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 283.354,
"heapDeltaBytes": 13120316,
"heapUsedBytes": 76579820,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 92.916,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 409.9069999999756,
"styleRecalcs": 49,
"styleRecalcDurationMs": 8.068000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 273.404,
"heapDeltaBytes": 13052720,
"heapUsedBytes": 76369048,
"domNodes": 24,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 89.999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 1993.6799999999835,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.279999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.05899999999997,
"heapDeltaBytes": -600528,
"heapUsedBytes": 62177772,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 5.828999999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1993.7489999999798,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.105,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 267.258,
"heapDeltaBytes": -2831056,
"heapUsedBytes": 59813216,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 5.404000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1689.5619999999667,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.739,
"layouts": 18,
"layoutDurationMs": 3.294,
"taskDurationMs": 527.889,
"heapDeltaBytes": 16296132,
"heapUsedBytes": 79632268,
"domNodes": -273,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 66.6,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.2290000000112,
"styleRecalcs": 77,
"styleRecalcDurationMs": 16.317999999999998,
"layouts": 18,
"layoutDurationMs": 3.0680000000000005,
"taskDurationMs": 527.6030000000001,
"heapDeltaBytes": 11370552,
"heapUsedBytes": 74748640,
"domNodes": -274,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 63.434000000000005,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 749.052000000006,
"styleRecalcs": 18,
"styleRecalcDurationMs": 19.037,
"layouts": 5,
"layoutDurationMs": 7.5029999999999974,
"taskDurationMs": 492.7100000000001,
"heapDeltaBytes": 19475964,
"heapUsedBytes": 100420200,
"domNodes": 13587,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 19.314000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 94,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8102.491999999984,
"styleRecalcs": 249,
"styleRecalcDurationMs": 26.47,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3719.7180000000003,
"heapDeltaBytes": -3605780,
"heapUsedBytes": 75167592,
"domNodes": -240,
"jsHeapTotalBytes": 1265664,
"scriptDurationMs": 1684.58,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8206.49199999997,
"styleRecalcs": 251,
"styleRecalcDurationMs": 25.07,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3764.671,
"heapDeltaBytes": -6722764,
"heapUsedBytes": 79137068,
"domNodes": -241,
"jsHeapTotalBytes": 2613248,
"scriptDurationMs": 1734.728,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 10278.847999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9299.021999999999,
"heapDeltaBytes": -50444888,
"heapUsedBytes": 177873916,
"domNodes": -8062,
"jsHeapTotalBytes": -9945088,
"scriptDurationMs": 116.63700000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10577.06900000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9601.782,
"heapDeltaBytes": -50236608,
"heapUsedBytes": 178289612,
"domNodes": -8062,
"jsHeapTotalBytes": -8110080,
"scriptDurationMs": 139.643,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 12821.716999999979,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.038999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12152.522,
"heapDeltaBytes": -20214140,
"heapUsedBytes": 189585256,
"domNodes": -8062,
"jsHeapTotalBytes": -13246464,
"scriptDurationMs": 643.8549999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 34,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 13192.470999999954,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.22899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12611.718,
"heapDeltaBytes": -58017256,
"heapUsedBytes": 163845204,
"domNodes": -8062,
"jsHeapTotalBytes": -25104384,
"scriptDurationMs": 656.841,
"eventListeners": -14928,
"totalBlockingTimeMs": 43,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 3796.904999999981,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.16899999999999,
"layouts": 20,
"layoutDurationMs": 20.938,
"taskDurationMs": 3646.8929999999996,
"heapDeltaBytes": -26913900,
"heapUsedBytes": 195439540,
"domNodes": -8062,
"jsHeapTotalBytes": 13430784,
"scriptDurationMs": 58.44500000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.22666666666664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3603.411000000051,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.13600000000002,
"layouts": 20,
"layoutDurationMs": 20.673000000000005,
"taskDurationMs": 3485.865,
"heapDeltaBytes": -19690256,
"heapUsedBytes": 197065080,
"domNodes": -8062,
"jsHeapTotalBytes": 13955072,
"scriptDurationMs": 53.623000000000005,
"eventListeners": -14928,
"totalBlockingTimeMs": 56,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5157.040999999992,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.10099999999998999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4586.042000000001,
"heapDeltaBytes": -2461964,
"heapUsedBytes": 192641916,
"domNodes": 0,
"jsHeapTotalBytes": -28573696,
"scriptDurationMs": 56.732000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5251.283000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4788.580000000002,
"heapDeltaBytes": -5573000,
"heapUsedBytes": 188406224,
"domNodes": -1,
"jsHeapTotalBytes": -12845056,
"scriptDurationMs": 69.48499999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 444.04300000002195,
"styleRecalcs": 21,
"styleRecalcDurationMs": 16.711000000000002,
"layouts": 5,
"layoutDurationMs": 1.8290000000000002,
"taskDurationMs": 101.056,
"heapDeltaBytes": 5276356,
"heapUsedBytes": 67161672,
"domNodes": 152,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 10.639,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 423.5709999999244,
"styleRecalcs": 14,
"styleRecalcDurationMs": 13.096,
"layouts": 3,
"layoutDurationMs": 0.673,
"taskDurationMs": 72.034,
"heapDeltaBytes": 4846244,
"heapUsedBytes": 66513184,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.64,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
b468ce9 to
af4d5a9
Compare
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18174 +/- ##
==========================================
+ Coverage 82.82% 83.82% +1.00%
==========================================
Files 2949 2254 -695
Lines 145217 128193 -17024
Branches 39276 32653 -6623
==========================================
- Hits 120272 107455 -12817
+ Misses 23680 20449 -3231
+ Partials 1265 289 -976
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 705 files with indirect coverage changes 🚀 New features to boost your workflow:
|
af4d5a9 to
3ee28d2
Compare
A row in the assets sidebar list view sets no `draggable` and no `dragstart`, so dragging an asset onto the agent prompt does nothing while the panel is in list view; the same drag works in grid view, where `MediaAssetCard` publishes MIME_ASSET_INFO and a uri-list flavour. The composer's drop side is view-agnostic (AgentPanelRoot `isAssetDrag` only reads `dataTransfer.types`), so the payload a row must publish is exactly the card's. RED: 5 new cases fail on this parent.
…401) Dragging an asset onto the agent prompt did nothing while the assets panel was in list view, and worked in grid view. `MediaAssetCard` was the only thing that set `draggable` and wrote the drag payload; `AssetsSidebarListView` renders `AssetsListItem`, which set neither, so a list row never started a native drag at all. The drop side is view-agnostic (`AgentPanelRoot` `isAssetDrag` reads `dataTransfer.types`), so a row that advertises nothing is a silent attachment failure. Moves the payload writer out of the card into `startAssetDrag` (`platform/assets/utils/assetDragUtil.ts`), which derives both flavours from the `AssetItem` alone, and calls it from the card and from the list rows. Extends ADR-ASSETS-DRAG-DROP-0035 with the rule that the payload belongs to the asset, not to a view mode. GREEN: the 5 unit cases from the parent commit pass, and a browser case drags a list row onto the canvas and asserts the workflow embedded in the dropped file opens. Verified red on the parent build and green on this one against a cloud dist served by the CI container.
3ee28d2 to
b3f4d31
Compare
…w modes (#18183) ## Summary Nothing exercised **a real drag from the assets panel into the composer**, in either view mode. #18174 (PM-1401, a list row that never started a drag) shipped proved by asserting the **canvas** consumer of the same drag payload — a real but indirect proxy, because it cannot catch a composer-side attach regression. That is the user-visible half of [PM-1402](https://linear.app/comfyorg/issue/PM-1402). **Scope note, corrected after a rebase.** When this branch was opened there was no composer-attachment browser coverage at all. #18104 has since landed `agentBatchOutputAttachment.spec.ts`, which does assert a composer attachment — but it **synthesizes** the `DataTransfer` in `page.evaluateHandle` and dispatches it, so it covers the drop/attach half against a fabricated payload and never exercises a drag source. The two are complements, not duplicates: that spec would still pass if every asset card and list row in the panel stopped publishing a payload, which is exactly the PM-1401 failure. This PR covers the source half, through a real `dragTo` from the panel, in both view modes. Verified together post-rebase: all four cases pass in one run. This is coverage plus the harness affordances it needed. No production behavior changes. ## Changes - **What**: - `browser_tests/tests/agent/agentComposerAssetDrop.spec.ts` (new, `@cloud`): opens the agent panel and the assets sidebar, drags an asset onto the panel, and asserts a composer attachment chip naming that asset appears. Runs for **both** grid and list view. - `src/workbench/extensions/agent/.../AttachmentChip.vue`: adds `data-testid="agent-attachment-chip"` and `data-attachment-name`. Distinct from the existing `asset-reference-chip`, which is the inline `@`-reference chip rendered elsewhere in the composer, not the drop-attachment chip; `AttachmentChip` had no anchor of its own. The visible label truncates at `max-w-32`, so asserting on rendered text cannot distinguish two long filenames — precisely the wrong-asset failure worth catching. Two attributes, no behavior or style change. - `browser_tests/fixtures/components/AgentPanel.ts`: `attachmentChips` and `attachmentChip(name)`. - `browser_tests/fixtures/agentPanelFixture.ts`: `bootAgentApp` gains an `assets` option. The fixture hard-routed `/api/assets` to an empty list, so any asset-flow spec had to re-route after boot and lean on route-precedence order. The route is also narrowed to the list endpoint (`**/api/assets` and `**/api/assets?**`) so a spec can serve `/api/assets/<id>/content` for the file itself; the previous `**/api/assets**` swallowed it. ## Review Focus - **The route narrowing is the one change with reach beyond this spec.** Previously `**/api/assets**` also absorbed content requests for every agent spec; now it does not. No current agent spec seeds assets, so none issues a content request, and the full agent suite passes — but it is the thing to push back on if you know of a spec depending on the broader swallow. - The assertion is `attachmentChip(ASSET_NAME)` plus a count of 1, not a bare "some chip appeared": a drag that attaches the wrong asset would pass the weaker form. - The drop target is `agentPanel.root` (`#agent-panel-root`), which is where `AgentPanelRoot` binds `@drop`. That is deliberately the whole panel, not the composer sub-element — relevant to [PM-1361](https://linear.app/comfyorg/issue/PM-1361)/[PM-1363](https://linear.app/comfyorg/issue/PM-1363), which are about widening the drop footprint. ## Verification - **Sensitivity proven, not assumed.** With the list-view `draggable`/`dragstart` wiring removed from `AssetsSidebarListView.vue` and the dist rebuilt, the **list case fails** on the missing chip (`expect(locator).toBeVisible() failed — element(s) not found`) while the **grid case still passes** — the exact PM-1401 signature. Wiring restored and both pass again. - Both new cases pass against a cloud dist served by `ghcr.io/comfy-org/comfyui-ci-container:0.0.22`, `--project=cloud`. - Rebased onto `main` at `38cc119a21` and re-verified: this spec's two cases pass alongside `agentBatchOutputAttachment` and `agentUploadedImageAttachment`, 4/4 in one run, after `AgentPanelRoot.vue` changed underneath on main. - Full agent browser suite on the pre-rebase build: **78 passed, 1 failed**. The failure is `agentConversationReplay.spec.ts` `@screenshot` (24152 px, ratio 0.01). It fails **identically on clean `main`** with these changes stashed, so it is a local-vs-CI rendering difference, not this change. - `pnpm typecheck` clean; agent unit suite 110 files / 1689 passed, 3 expected-fail; lint-staged (oxfmt, oxlint, eslint, stylelint, typecheck, typecheck:browser) clean on commit. Workspace row: `qaf-78`.
…w modes (#18183) Nothing exercised **a real drag from the assets panel into the composer**, in either view mode. #18174 (PM-1401, a list row that never started a drag) shipped proved by asserting the **canvas** consumer of the same drag payload — a real but indirect proxy, because it cannot catch a composer-side attach regression. That is the user-visible half of [PM-1402](https://linear.app/comfyorg/issue/PM-1402). **Scope note, corrected after a rebase.** When this branch was opened there was no composer-attachment browser coverage at all. #18104 has since landed `agentBatchOutputAttachment.spec.ts`, which does assert a composer attachment — but it **synthesizes** the `DataTransfer` in `page.evaluateHandle` and dispatches it, so it covers the drop/attach half against a fabricated payload and never exercises a drag source. The two are complements, not duplicates: that spec would still pass if every asset card and list row in the panel stopped publishing a payload, which is exactly the PM-1401 failure. This PR covers the source half, through a real `dragTo` from the panel, in both view modes. Verified together post-rebase: all four cases pass in one run. This is coverage plus the harness affordances it needed. No production behavior changes. - **What**: - `browser_tests/tests/agent/agentComposerAssetDrop.spec.ts` (new, `@cloud`): opens the agent panel and the assets sidebar, drags an asset onto the panel, and asserts a composer attachment chip naming that asset appears. Runs for **both** grid and list view. - `src/workbench/extensions/agent/.../AttachmentChip.vue`: adds `data-testid="agent-attachment-chip"` and `data-attachment-name`. Distinct from the existing `asset-reference-chip`, which is the inline `@`-reference chip rendered elsewhere in the composer, not the drop-attachment chip; `AttachmentChip` had no anchor of its own. The visible label truncates at `max-w-32`, so asserting on rendered text cannot distinguish two long filenames — precisely the wrong-asset failure worth catching. Two attributes, no behavior or style change. - `browser_tests/fixtures/components/AgentPanel.ts`: `attachmentChips` and `attachmentChip(name)`. - `browser_tests/fixtures/agentPanelFixture.ts`: `bootAgentApp` gains an `assets` option. The fixture hard-routed `/api/assets` to an empty list, so any asset-flow spec had to re-route after boot and lean on route-precedence order. The route is also narrowed to the list endpoint (`**/api/assets` and `**/api/assets?**`) so a spec can serve `/api/assets/<id>/content` for the file itself; the previous `**/api/assets**` swallowed it. - **The route narrowing is the one change with reach beyond this spec.** Previously `**/api/assets**` also absorbed content requests for every agent spec; now it does not. No current agent spec seeds assets, so none issues a content request, and the full agent suite passes — but it is the thing to push back on if you know of a spec depending on the broader swallow. - The assertion is `attachmentChip(ASSET_NAME)` plus a count of 1, not a bare "some chip appeared": a drag that attaches the wrong asset would pass the weaker form. - The drop target is `agentPanel.root` (`#agent-panel-root`), which is where `AgentPanelRoot` binds `@drop`. That is deliberately the whole panel, not the composer sub-element — relevant to [PM-1361](https://linear.app/comfyorg/issue/PM-1361)/[PM-1363](https://linear.app/comfyorg/issue/PM-1363), which are about widening the drop footprint. - **Sensitivity proven, not assumed.** With the list-view `draggable`/`dragstart` wiring removed from `AssetsSidebarListView.vue` and the dist rebuilt, the **list case fails** on the missing chip (`expect(locator).toBeVisible() failed — element(s) not found`) while the **grid case still passes** — the exact PM-1401 signature. Wiring restored and both pass again. - Both new cases pass against a cloud dist served by `ghcr.io/comfy-org/comfyui-ci-container:0.0.22`, `--project=cloud`. - Rebased onto `main` at `38cc119a21` and re-verified: this spec's two cases pass alongside `agentBatchOutputAttachment` and `agentUploadedImageAttachment`, 4/4 in one run, after `AgentPanelRoot.vue` changed underneath on main. - Full agent browser suite on the pre-rebase build: **78 passed, 1 failed**. The failure is `agentConversationReplay.spec.ts` `@screenshot` (24152 px, ratio 0.01). It fails **identically on clean `main`** with these changes stashed, so it is a local-vs-CI rendering difference, not this change. - `pnpm typecheck` clean; agent unit suite 110 files / 1689 passed, 3 expected-fail; lint-staged (oxfmt, oxlint, eslint, stylelint, typecheck, typecheck:browser) clean on commit. Workspace row: `qaf-78`. (cherry picked from commit b3b0579)
…w modes (#18183) Nothing exercised **a real drag from the assets panel into the composer**, in either view mode. #18174 (PM-1401, a list row that never started a drag) shipped proved by asserting the **canvas** consumer of the same drag payload — a real but indirect proxy, because it cannot catch a composer-side attach regression. That is the user-visible half of [PM-1402](https://linear.app/comfyorg/issue/PM-1402). **Scope note, corrected after a rebase.** When this branch was opened there was no composer-attachment browser coverage at all. #18104 has since landed `agentBatchOutputAttachment.spec.ts`, which does assert a composer attachment — but it **synthesizes** the `DataTransfer` in `page.evaluateHandle` and dispatches it, so it covers the drop/attach half against a fabricated payload and never exercises a drag source. The two are complements, not duplicates: that spec would still pass if every asset card and list row in the panel stopped publishing a payload, which is exactly the PM-1401 failure. This PR covers the source half, through a real `dragTo` from the panel, in both view modes. Verified together post-rebase: all four cases pass in one run. This is coverage plus the harness affordances it needed. No production behavior changes. - **What**: - `browser_tests/tests/agent/agentComposerAssetDrop.spec.ts` (new, `@cloud`): opens the agent panel and the assets sidebar, drags an asset onto the panel, and asserts a composer attachment chip naming that asset appears. Runs for **both** grid and list view. - `src/workbench/extensions/agent/.../AttachmentChip.vue`: adds `data-testid="agent-attachment-chip"` and `data-attachment-name`. Distinct from the existing `asset-reference-chip`, which is the inline `@`-reference chip rendered elsewhere in the composer, not the drop-attachment chip; `AttachmentChip` had no anchor of its own. The visible label truncates at `max-w-32`, so asserting on rendered text cannot distinguish two long filenames — precisely the wrong-asset failure worth catching. Two attributes, no behavior or style change. - `browser_tests/fixtures/components/AgentPanel.ts`: `attachmentChips` and `attachmentChip(name)`. - `browser_tests/fixtures/agentPanelFixture.ts`: `bootAgentApp` gains an `assets` option. The fixture hard-routed `/api/assets` to an empty list, so any asset-flow spec had to re-route after boot and lean on route-precedence order. The route is also narrowed to the list endpoint (`**/api/assets` and `**/api/assets?**`) so a spec can serve `/api/assets/<id>/content` for the file itself; the previous `**/api/assets**` swallowed it. - **The route narrowing is the one change with reach beyond this spec.** Previously `**/api/assets**` also absorbed content requests for every agent spec; now it does not. No current agent spec seeds assets, so none issues a content request, and the full agent suite passes — but it is the thing to push back on if you know of a spec depending on the broader swallow. - The assertion is `attachmentChip(ASSET_NAME)` plus a count of 1, not a bare "some chip appeared": a drag that attaches the wrong asset would pass the weaker form. - The drop target is `agentPanel.root` (`#agent-panel-root`), which is where `AgentPanelRoot` binds `@drop`. That is deliberately the whole panel, not the composer sub-element — relevant to [PM-1361](https://linear.app/comfyorg/issue/PM-1361)/[PM-1363](https://linear.app/comfyorg/issue/PM-1363), which are about widening the drop footprint. - **Sensitivity proven, not assumed.** With the list-view `draggable`/`dragstart` wiring removed from `AssetsSidebarListView.vue` and the dist rebuilt, the **list case fails** on the missing chip (`expect(locator).toBeVisible() failed — element(s) not found`) while the **grid case still passes** — the exact PM-1401 signature. Wiring restored and both pass again. - Both new cases pass against a cloud dist served by `ghcr.io/comfy-org/comfyui-ci-container:0.0.22`, `--project=cloud`. - Rebased onto `main` at `38cc119a21` and re-verified: this spec's two cases pass alongside `agentBatchOutputAttachment` and `agentUploadedImageAttachment`, 4/4 in one run, after `AgentPanelRoot.vue` changed underneath on main. - Full agent browser suite on the pre-rebase build: **78 passed, 1 failed**. The failure is `agentConversationReplay.spec.ts` `@screenshot` (24152 px, ratio 0.01). It fails **identically on clean `main`** with these changes stashed, so it is a local-vs-CI rendering difference, not this change. - `pnpm typecheck` clean; agent unit suite 110 files / 1689 passed, 3 expected-fail; lint-staged (oxfmt, oxlint, eslint, stylelint, typecheck, typecheck:browser) clean on commit. Workspace row: `qaf-78`. (cherry picked from commit b3b0579)
## Summary Seventeen non-billing Agent sources are carried for `core/1.54`. Exact-head hosted checks and target-native replay acceptance pass; review remains. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `2bd4dace2e6207fede11d2ac219d691a811769dc`, verified under Node 25.9.0 and pnpm 11.13.1. - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - ancestor head `bd7da3cffd6dc349e1c48c5a277bc112cabd0e41` passed one zero-retry target-native warning-retention case with an inspected final frame; its [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/7fa0ba4d731f00684388a45f1aeb1d24dc6f2280/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1145-utc-exact-core-native-case-passes-final-warning-frame-inspected) is ancestry evidence, not acceptance of this newer head; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `389a3718bd2f637f704bde349068cbfd87cd9542` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `366e0287095876351377f873688fece88eb90397` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:44:02 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. Exact-head hosted checks and target-native replay acceptance pass. Review and the release-target merge-readiness gate remain required before merge. No deployment or check waiver is authorized. </details> Justification: Authorized Agent 1.54 release backport aggregate merged without standing human approval under the published release-backport authority; exact-head hosted checks, target-native replay acceptance, target-aware merge guard, adaptation review, and absence of unresolved human objections limit risk. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
## Summary Seventeen non-billing Agent sources are carried for `cloud/1.54`. The candidate now contains release `1.54.12`; fresh hosted checks and target-native replay acceptance passed. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`, verified locally under Node 25.9.0 and pnpm 11.13.1. - merged current `cloud/1.54` tip `d2667baf6bdb8664821b4bed7a7f5a1df65f9f49` cleanly; the imported release delta is limited to the package version and locale data; - frozen installation, 174 focused Agent/missing-model tests with 1 expected failure, main and browser typechecks, formatting, full ESLint with zero errors, the Cloud production build, target ancestry, and diff checks pass locally; - fresh exact-head hosted checks and one zero-retry target-native replay passed after the release target changed; - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `dfe99947cffb5f31c5f4750113eb9770720e5eac` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `5ec6c64e9b78b56b12350ae732dc1e1ea20052e0` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:45:15 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. The prior replay receipt remains historical evidence for parent head `516f6b5f71e251b25985fb61715432f05249c4bd`. Fresh hosted checks and the fresh target-native replay passed at current head `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`; adaptation review and the release-target merge-readiness gate also passed. </details> Justification: Author-owned release aggregate merged under the published Agent 1.54 backport grant after exact-head hosted checks, target-native replay, adaptation review, target ancestry, and the target-aware merge guard passed; no independent approval was available. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
A `test.fixme`/`.skip` landed to unblock a red `main` is a promise to come back, and the PR body is the only place that promise survives. #16907 disabled `agentPanelLifecycle.spec.ts` with a completely empty body, so recovering the intent later meant reconstructing the failure direction from commit timestamps. This fails a pull request that newly disables a test unless its body names a tracking issue or follow-up PR, and prints the file and line so the author does not have to hunt for it. Scoped to avoid crying wolf, since a guard that fires on ordinary work gets routed around: - Only DISABLING declarations, matched as a first argument that is a string literal. Playwright's conditional `test.skip(condition, 'reason')` and bare `test.skip()` are runtime controls, not a test taken out of service. - Only lines this PR ADDS. A disable already on the base branch is not this author's debt to justify. - Only test sources, so a doc or changelog mentioning `test.fixme` is inert. Verified against the case that motivated it: replaying #16907's real base and head with its real (empty) body fails and names `agentPanelLifecycle.spec.ts: test.fixme('supports keyboard activation ...`. The same replay over the last six merged spec-touching PRs (#18213, #18201, #18197, #18183, #18159, #18174) passes, as do synthetic cases for conditional skip, bare skip, docs-only mention, and an unrelated edit to a file that already had a disabled test. shellcheck clean.
Summary
Dragging an asset out of the Media Assets panel does nothing while the panel is in list view, and works in grid view (PM-1401, reported on nightly through the feedback survey). The composer's "drag in asset from asset panel" path is therefore unusable from one of the two view modes, with no error shown. Opened RED (
98f7ee82, 5 failing unit cases) and made GREEN byb468ce99.Now based directly on
main: #18096 and #18111 have merged, and this branch was rebuilt on top of them (2fd052d1a5). TheMediaAssetCardpayload writer this PR extracts is #18111's post-fix version, so the file-URLtext/uri-listrule moves intostartAssetDragintact.Before:
MediaAssetCardwas the only asset surface that set:draggable="true"and wrote a drag payload.AssetsSidebarListViewrendersAssetsListItem, which sets neither, so a list row never started a native drag at all. The drop side is view-agnostic -AgentPanelRootisAssetDragaccepts a drop purely ondataTransfer.typescontainingapplication/x-comfy-asset-info- so a row that advertises nothing is a silent attachment failure rather than a rejected drop.After: both flavours are written by one function,
startAssetDrag, which derives everything it needs from theAssetItemalone (getAssetType(asset.tags),getMediaTypeFromFilename(asset.name)), and both the grid card and the list rows call it. A list row now carries exactly the payload a grid card carries, including the file-URLtext/uri-listrule this PR's parent established.Not the marquee:
useAssetGridSelectiononlypreventDefaults a dragstart while it is tracking, and it starts tracking only in a container holding[data-asset-id], which list rows do not set. That attribute is deliberately still not set, so list-view marquee behaviour is unchanged by this PR.Changes
src/platform/assets/utils/assetDragUtil.ts(new):startAssetDrag(event, asset)holds the Ctrl/Meta cancel guard and bothdataTransferflavours, moved verbatim fromMediaAssetCard.dragStart(including theallOutputs[0]branch and the file-URL rule from fix: drag cloud asset cards by file URL so dropped videos keep their workflow #18111). Pure function of the asset, no component state.src/platform/assets/components/MediaAssetCard.vue:dragStartdelegates to it; now-unused imports dropped.src/components/sidebar/tabs/AssetsSidebarListView.vue: rows get:draggable="true"and@dragstart="startAssetDrag($event, item.asset)".AssetsListItemis a single-root component with attribute fallthrough, so no prop plumbing.docs/adr/ASSETS-DRAG-DROP-0035-asset-card-drag-uses-file-url.md: new rule 4, the payload belongs to the asset and not to a view mode, with the PM-1401 failure recorded as the worked example; two consequences added (nothing mechanically forces a new surface throughstartAssetDrag; the Ctrl/Meta branch is grid parity in list view, not a behaviour list view needs today). Rule 1 de-specialised fromMediaAssetCardto the drag side.AssetsSidebarListView.test.ts: rows aredraggable; a row publishes the asset-info payload the composer resolves an attachment from; it publishes the file URL astext/uri-list;it.forover Ctrl and Meta asserts the drag is cancelled with nothing added. All 5 fail on the parent.browser_tests/tests/sidebar/assetListViewDrag.spec.ts(new,@cloud): switches the panel to list view through the settings menu and drags a row onto the canvas, asserting the workflow embedded in the dropped file opens and the tab is named after the asset - the same observable as the grid counterpart inagentVideoAsset.spec.ts, so a regression in either view mode reads as the same failure.Review Focus
startAssetDragis a plain function rather than a composable so a non-setup call site (theVirtualGridslot) can use it; it callsuseFeatureFlags()transitively throughgetAssetFileUrl, which that helper already did at call time before this PR.role="button"andtabindex="0";draggableon the same element does not change its accessibility name or keyboard activation, and the existing keyboard-activation case still passes.startAssetDrag. The ADR records that gap; the practical guard is one case per surface.browser_testshas no agent-composer drop harness at all. This PR asserts the canvas consumer of the same payload instead. Building that harness is a separate PR.Verification
vitest run src/platform/assets src/components/sidebar src/components/queue src/composables/node: 97 files, 1195 passed, 0 failed.ghcr.io/comfy-org/comfyui-ci-container:0.0.22(the CI backend),--project=cloud: red with the list-view wiring reverted (expect(tabName).toContain('agent_generated_video')fails, no workflow loads), green with it restored.main: this PR's list-view case and both of fix: drag cloud asset cards by file URL so dropped videos keep their workflow #18111's grid-card cases pass together in one run, which is the check that matters here - the extraction must not regress the file-URL fix it moved.pnpm typecheckandtypecheck:browserclean;eslint,oxlint,oxfmt,stylelintclean on changed files via lint-staged on both commits; Knip clean on push.