Repository navigation
fix: drag cloud asset cards by file URL so dropped videos keep their workflow - #18111
Conversation
…/playback/metadata bugs Adds two test.fail() Playwright specs that reproduce the reported bug in the Comfy Agent / cloud media panel: a generated video asset with no thumbnail_url/preview_url renders a black tile with an unplayable <video> (MediaAssetCard.vue's src fallback has no case for video, unlike the '3D' kind), and dragging such an asset onto the canvas attaches no workflow metadata to the resulting node. Both tests mock the /api/assets network boundary the same way the existing "Assets sidebar - cloud exports" tests in assets.spec.ts do, and are expected to start passing once the bug is fixed.
MediaAssetCard's src fallback (thumbnail_url || preview_url || '') left video/audio assets with an empty <video>/<audio> src whenever the backend had not populated a preview - which it never does for agent/cloud-generated video or audio outputs. The result was a black, unplayable tile. Mirror the existing '3D' fallback: when no server preview exists for a video or audio asset, point the element at the asset's own real content URL via getAssetFileUrl(), now with an explicit disposition=inline query param so the assets-API content endpoint serves it for in-page playback instead of forcing a download (its default is Content-Disposition: attachment). Existing callers of getAssetFileUrl() (downloads, the 3D viewer) are unaffected since the new disposition option defaults to unset. Video is unmounted while off-screen (VirtualGrid) and already loads with preload="metadata", so this does not turn the grid into an eager full-file video downloader. Flips the corresponding e2e assertion in agentVideoAsset.spec.ts from test.fail() to a passing assertion; the drag-to-canvas workflow-metadata test is left as test.fail() (separate, likely upstream/backend gap).
…t-thumbnail-repro-v2
Records why the Media Assets card must publish the asset's file URL, never its preview URL, as the drag payload, and why drop handlers must reject non-OK fetches. Covers the job-grouped card id, the preview-vs-file split, why images worked by accident, and the rejected alternatives.
MediaAssetCard: replace the case pinning the preview URL as the uri-list payload with a table over image, job-grouped video and 3D-with-thumbnail assets, each expecting the file URL. Drop the getOutputAssetMetadata module mock so the job-grouped row exercises the real assetId resolution. eventUtils: extractFilesFromDragEvent must yield no file when the URI answers with a 404 JSON body instead of wrapping the error as a File. agentVideoAsset e2e: serve the embedded-workflow MP4 only for the asset id and answer every other content URL (including the job id the drag currently publishes) with the backend's ASSET_NOT_FOUND body. Still test.fail() until the fix lands.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2041 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.93 MB gzip 🔴 +250 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 638 kB (baseline 638 kB) • 🟢 -99 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 11 removed / 17 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 4 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • 🔴 +491 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • 🟢 -58 BBundles that do not match a named category
Status: 81 added / 82 removed / 218 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T03:43:24.244Z",
"gitSha": "c080aa77ed74224b00f2054280657c50f96a1647",
"branch": "fix/asset-card-drag-uses-file-url",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1992.7889999999593,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.342,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 293.617,
"heapDeltaBytes": -2797000,
"heapUsedBytes": 59401860,
"domNodes": -260,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.675999999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2008.690999999999,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.840999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 324.93800000000005,
"heapDeltaBytes": -2900052,
"heapUsedBytes": 59181944,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.065999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1760.8190000000263,
"styleRecalcs": 73,
"styleRecalcDurationMs": 22.718000000000004,
"layouts": 14,
"layoutDurationMs": 3.5840000000000005,
"taskDurationMs": 767.927,
"heapDeltaBytes": 1647260,
"heapUsedBytes": 63796908,
"domNodes": -262,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 135.70300000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.9239999999854,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.75,
"layouts": 14,
"layoutDurationMs": 3.9360000000000004,
"taskDurationMs": 646.088,
"heapDeltaBytes": 2143656,
"heapUsedBytes": 64277212,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 126.977,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.1369999999888,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.486,
"layouts": 6,
"layoutDurationMs": 1.2580000000000002,
"taskDurationMs": 295.32499999999993,
"heapDeltaBytes": 2214424,
"heapUsedBytes": 64087264,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.258999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.654999999998,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.196000000000002,
"layouts": 6,
"layoutDurationMs": 1.205,
"taskDurationMs": 286.71000000000004,
"heapDeltaBytes": 2092348,
"heapUsedBytes": 64336500,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.331000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 544.9520000000234,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.8309999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 373.99500000000006,
"heapDeltaBytes": 17956176,
"heapUsedBytes": 80115600,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 138.25,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 533.5549999999785,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.803999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.52699999999993,
"heapDeltaBytes": 17672032,
"heapUsedBytes": 79578560,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 130.408,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.6139999999718,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.236999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.4130000000001,
"heapDeltaBytes": 3011164,
"heapUsedBytes": 82202440,
"domNodes": -246,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 29.339000000000006,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2009.8409999999376,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.195000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.80500000000006,
"heapDeltaBytes": 2495560,
"heapUsedBytes": 82587820,
"domNodes": -247,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 32.379000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2167.2960000000216,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.063,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1373.415,
"heapDeltaBytes": -14893788,
"heapUsedBytes": 67169224,
"domNodes": -219,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 677.933,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2156.001999999944,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.132,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1331.878,
"heapDeltaBytes": 18134964,
"heapUsedBytes": 82621636,
"domNodes": 8,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 663.9200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3183.205999999984,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.696,
"layouts": 60,
"layoutDurationMs": 12.385000000000002,
"taskDurationMs": 1382.589,
"heapDeltaBytes": -9846768,
"heapUsedBytes": 73637092,
"domNodes": -254,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 625.5430000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3203.3400000000256,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.073999999999996,
"layouts": 60,
"layoutDurationMs": 13.049999999999999,
"taskDurationMs": 1455.8029999999999,
"heapDeltaBytes": 7863600,
"heapUsedBytes": 74004236,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 658.128,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2122.9430000000207,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.244999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1403.4120000000003,
"heapDeltaBytes": 14862580,
"heapUsedBytes": 80743848,
"domNodes": 8,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 776.405,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2589.317000000051,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.463999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1633.2139999999997,
"heapDeltaBytes": 14787384,
"heapUsedBytes": 80396276,
"domNodes": 4,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 818.3629999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.487000000031,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.467000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.961,
"heapDeltaBytes": 20129736,
"heapUsedBytes": 84036848,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.283000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.06699999995,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.417,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.8740000000001,
"heapDeltaBytes": -3875076,
"heapUsedBytes": 83844100,
"domNodes": -245,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 33.394000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.8199999999861,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.115,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.61600000000004,
"heapDeltaBytes": 13236672,
"heapUsedBytes": 76601688,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 112.805,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 521.4359999999942,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.219999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 336.81600000000003,
"heapDeltaBytes": 13153988,
"heapUsedBytes": 76595124,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 116.587,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2035.944000000029,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.4,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.80899999999997,
"heapDeltaBytes": -5968528,
"heapUsedBytes": 57275448,
"domNodes": -273,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.065000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.0410000000393,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.729000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.44899999999996,
"heapDeltaBytes": 17184584,
"heapUsedBytes": 80421520,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.429,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.8709999999683,
"styleRecalcs": 77,
"styleRecalcDurationMs": 23.597,
"layouts": 18,
"layoutDurationMs": 4.422000000000001,
"taskDurationMs": 648.1669999999999,
"heapDeltaBytes": -1569288,
"heapUsedBytes": 62141972,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 83.189,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.2959999999994,
"styleRecalcs": 79,
"styleRecalcDurationMs": 24.59,
"layouts": 18,
"layoutDurationMs": 4.52,
"taskDurationMs": 663.548,
"heapDeltaBytes": 11618080,
"heapUsedBytes": 74947124,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 90.242,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1301.4239999999972,
"styleRecalcs": 17,
"styleRecalcDurationMs": 22.808999999999997,
"layouts": 5,
"layoutDurationMs": 9.812000000000001,
"taskDurationMs": 786.0810000000002,
"heapDeltaBytes": 20088444,
"heapUsedBytes": 102754060,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 26.557000000000006,
"eventListeners": 2383,
"totalBlockingTimeMs": 97,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8244.053000000007,
"styleRecalcs": 250,
"styleRecalcDurationMs": 38.147,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4594.023,
"heapDeltaBytes": -6606332,
"heapUsedBytes": 74278796,
"domNodes": -243,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 2157.094,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8369.281,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.638000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5122.414,
"heapDeltaBytes": -4358648,
"heapUsedBytes": 76841744,
"domNodes": -246,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 2378.6130000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15017.375999999957,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14894.702000000001,
"heapDeltaBytes": -43371096,
"heapUsedBytes": 192300480,
"domNodes": -8061,
"jsHeapTotalBytes": -13500416,
"scriptDurationMs": 220.986,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 14827.897000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14521.227,
"heapDeltaBytes": -47501160,
"heapUsedBytes": 194400644,
"domNodes": -8090,
"jsHeapTotalBytes": -17801216,
"scriptDurationMs": 224.21499999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17717.205999999976,
"styleRecalcs": 122,
"styleRecalcDurationMs": 16.55099999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17625.971999999998,
"heapDeltaBytes": -57227956,
"heapUsedBytes": 178799380,
"domNodes": -8061,
"jsHeapTotalBytes": -20066304,
"scriptDurationMs": 746.175,
"eventListeners": -14928,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17465.416000000005,
"styleRecalcs": 124,
"styleRecalcDurationMs": 16.269000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17312.798,
"heapDeltaBytes": -24947192,
"heapUsedBytes": 181172032,
"domNodes": -8065,
"jsHeapTotalBytes": -1798144,
"scriptDurationMs": 765.9090000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5383.382999999981,
"styleRecalcs": 20,
"styleRecalcDurationMs": 61.807,
"layouts": 20,
"layoutDurationMs": 23.895,
"taskDurationMs": 5367.666,
"heapDeltaBytes": -37913984,
"heapUsedBytes": 174177832,
"domNodes": -8061,
"jsHeapTotalBytes": 17842176,
"scriptDurationMs": 90.223,
"eventListeners": -14928,
"totalBlockingTimeMs": 226,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5420.786000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.934999999999995,
"layouts": 20,
"layoutDurationMs": 24.375000000000007,
"taskDurationMs": 5387.1770000000015,
"heapDeltaBytes": -32486584,
"heapUsedBytes": 183575360,
"domNodes": -8061,
"jsHeapTotalBytes": 15847424,
"scriptDurationMs": 94.91100000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 225,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7382.374999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7348.832000000001,
"heapDeltaBytes": -9682100,
"heapUsedBytes": 185825764,
"domNodes": 0,
"jsHeapTotalBytes": -22282240,
"scriptDurationMs": 134.003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7473.818999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7425.252999999998,
"heapDeltaBytes": 19959008,
"heapUsedBytes": 183903232,
"domNodes": 0,
"jsHeapTotalBytes": -18874368,
"scriptDurationMs": 116.26899999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 92.55100000001448,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.971,
"layouts": 4,
"layoutDurationMs": 1.8209999999999997,
"taskDurationMs": 70.98599999999999,
"heapDeltaBytes": 3103392,
"heapUsedBytes": 64761948,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.850999999999997,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 96.85799999999745,
"styleRecalcs": 7,
"styleRecalcDurationMs": 12.957999999999998,
"layouts": 3,
"layoutDurationMs": 1.339,
"taskDurationMs": 66.06700000000001,
"heapDeltaBytes": 3027324,
"heapUsedBytes": 64650348,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.740999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 94a06f55b165fc4adfc1d3c56665f93ce33e3e1b
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18111 +/- ##
==========================================
+ Coverage 82.80% 83.81% +1.01%
==========================================
Files 2948 2252 -696
Lines 145151 128132 -17019
Branches 37393 34519 -2874
==========================================
- Hits 120194 107399 -12795
+ Misses 23691 20444 -3247
+ Partials 1266 289 -977
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 705 files with indirect coverage changes 🚀 New features to boost your workflow:
|
MediaAssetCard publishes getAssetFileUrl(asset) as the text/uri-list drag payload, so a job-grouped video, audio or 3D card hands over its real file instead of a preview or a job-id URL that the backend answers with 404. The asset-info payload keeps preview_url for image previews. fetchDroppedAsset returns no file on a non-OK response instead of wrapping the error body in a File. The canvas drop handler reports and toasts when a drop that carried asset-info yields no file; plain link drops stay silent. useNodeDragAndDrop names a fetched uri-list file after the asset-info filename before falling back to the URL, so a content URL no longer yields a File called "content". resolvePreviewUrl falls back through the shared content-id resolver so no path derives a content URL from a job id. Tests: file-URL table now covers a grouped self-preview image, a grouped video without preview, a 3D model with a persisted thumbnail and the history-backed flag-off path; eventUtils covers 404 JSON, 500 HTML and a 200 success; the e2e drag test is no longer marked as an expected failure and asserts the embedded workflow's node count.
Decision now reads as four rules (file URI, previews stay rendering concerns, names come from the asset-info payload, non-OK is not a file and is surfaced) and Context records why node targets with onResultItemDrop never see the URI and why cloud images self-preview.
- The video E2E serves the MP4 fixture only at the card's own asset-id content URL (every other id gets the backend's 404 body) and asserts the dimensions load and currentTime advances after clicking play, instead of only checking currentSrc is non-empty. - The drag E2E uses the workflow-bearing fixture with the same exact-id routing; it stays an expected failure until #18111 lands. - The component test covers the video and audio fallback as one table and queries the media elements by test id instead of DOM traversal. - Drop the redundant disposition-default case in assetUrlUtil.test.ts.
…et-card-drag-uses-file-url # Conflicts: # browser_tests/tests/sidebar/agentVideoAsset.spec.ts
…/playback/metadata bugs Adds two test.fail() Playwright specs that reproduce the reported bug in the Comfy Agent / cloud media panel: a generated video asset with no thumbnail_url/preview_url renders a black tile with an unplayable <video> (MediaAssetCard.vue's src fallback has no case for video, unlike the '3D' kind), and dragging such an asset onto the canvas attaches no workflow metadata to the resulting node. Both tests mock the /api/assets network boundary the same way the existing "Assets sidebar - cloud exports" tests in assets.spec.ts do, and are expected to start passing once the bug is fixed.
MediaAssetCard's src fallback (thumbnail_url || preview_url || '') left video/audio assets with an empty <video>/<audio> src whenever the backend had not populated a preview - which it never does for agent/cloud-generated video or audio outputs. The result was a black, unplayable tile. Mirror the existing '3D' fallback: when no server preview exists for a video or audio asset, point the element at the asset's own real content URL via getAssetFileUrl(), now with an explicit disposition=inline query param so the assets-API content endpoint serves it for in-page playback instead of forcing a download (its default is Content-Disposition: attachment). Existing callers of getAssetFileUrl() (downloads, the 3D viewer) are unaffected since the new disposition option defaults to unset. Video is unmounted while off-screen (VirtualGrid) and already loads with preload="metadata", so this does not turn the grid into an eager full-file video downloader. Flips the corresponding e2e assertion in agentVideoAsset.spec.ts from test.fail() to a passing assertion; the drag-to-canvas workflow-metadata test is left as test.fail() (separate, likely upstream/backend gap).
- The video E2E serves the MP4 fixture only at the card's own asset-id content URL (every other id gets the backend's 404 body) and asserts the dimensions load and currentTime advances after clicking play, instead of only checking currentSrc is non-empty. - The drag E2E uses the workflow-bearing fixture with the same exact-id routing; it stays an expected failure until #18111 lands. - The component test covers the video and audio fallback as one table and queries the media elements by test id instead of DOM traversal. - Drop the redundant disposition-default case in assetUrlUtil.test.ts.
5078410 to
e692393
Compare
…et-card-drag-uses-file-url
…/playback/metadata bugs Adds two test.fail() Playwright specs that reproduce the reported bug in the Comfy Agent / cloud media panel: a generated video asset with no thumbnail_url/preview_url renders a black tile with an unplayable <video> (MediaAssetCard.vue's src fallback has no case for video, unlike the '3D' kind), and dragging such an asset onto the canvas attaches no workflow metadata to the resulting node. Both tests mock the /api/assets network boundary the same way the existing "Assets sidebar - cloud exports" tests in assets.spec.ts do, and are expected to start passing once the bug is fixed.
MediaAssetCard's src fallback (thumbnail_url || preview_url || '') left video/audio assets with an empty <video>/<audio> src whenever the backend had not populated a preview - which it never does for agent/cloud-generated video or audio outputs. The result was a black, unplayable tile. Mirror the existing '3D' fallback: when no server preview exists for a video or audio asset, point the element at the asset's own real content URL via getAssetFileUrl(), now with an explicit disposition=inline query param so the assets-API content endpoint serves it for in-page playback instead of forcing a download (its default is Content-Disposition: attachment). Existing callers of getAssetFileUrl() (downloads, the 3D viewer) are unaffected since the new disposition option defaults to unset. Video is unmounted while off-screen (VirtualGrid) and already loads with preload="metadata", so this does not turn the grid into an eager full-file video downloader. Flips the corresponding e2e assertion in agentVideoAsset.spec.ts from test.fail() to a passing assertion; the drag-to-canvas workflow-metadata test is left as test.fail() (separate, likely upstream/backend gap).
- The video E2E serves the MP4 fixture only at the card's own asset-id content URL (every other id gets the backend's 404 body) and asserts the dimensions load and currentTime advances after clicking play, instead of only checking currentSrc is non-empty. - The drag E2E uses the workflow-bearing fixture with the same exact-id routing; it stays an expected failure until #18111 lands. - The component test covers the video and audio fallback as one table and queries the media elements by test id instead of DOM traversal. - Drop the redundant disposition-default case in assetUrlUtil.test.ts.
e692393 to
88fe75c
Compare
MediaAssetCard's src fallback (thumbnail_url || preview_url || '') left video/audio assets with an empty <video>/<audio> src whenever the backend had not populated a preview - which it never does for agent/cloud-generated video or audio outputs. The result was a black, unplayable tile. Mirror the existing '3D' fallback: when no server preview exists for a video or audio asset, point the element at the asset's own real content URL via getAssetFileUrl(), now with an explicit disposition=inline query param so the assets-API content endpoint serves it for in-page playback instead of forcing a download (its default is Content-Disposition: attachment). Existing callers of getAssetFileUrl() (downloads, the 3D viewer) are unaffected since the new disposition option defaults to unset. Video is unmounted while off-screen (VirtualGrid) and already loads with preload="metadata", so this does not turn the grid into an eager full-file video downloader. Flips the corresponding e2e assertion in agentVideoAsset.spec.ts from test.fail() to a passing assertion; the drag-to-canvas workflow-metadata test is left as test.fail() (separate, likely upstream/backend gap).
- The video E2E serves the MP4 fixture only at the card's own asset-id content URL (every other id gets the backend's 404 body) and asserts the dimensions load and currentTime advances after clicking play, instead of only checking currentSrc is non-empty. - The drag E2E uses the workflow-bearing fixture with the same exact-id routing; it stays an expected failure until #18111 lands. - The component test covers the video and audio fallback as one table and queries the media elements by test id instead of DOM traversal. - Drop the redundant disposition-default case in assetUrlUtil.test.ts.
35108ab to
1992034
Compare
…et-card-drag-uses-file-url
…/playback/metadata bugs Adds two test.fail() Playwright specs that reproduce the reported bug in the Comfy Agent / cloud media panel: a generated video asset with no thumbnail_url/preview_url renders a black tile with an unplayable <video> (MediaAssetCard.vue's src fallback has no case for video, unlike the '3D' kind), and dragging such an asset onto the canvas attaches no workflow metadata to the resulting node. Both tests mock the /api/assets network boundary the same way the existing "Assets sidebar - cloud exports" tests in assets.spec.ts do, and are expected to start passing once the bug is fixed.
MediaAssetCard's src fallback (thumbnail_url || preview_url || '') left video/audio assets with an empty <video>/<audio> src whenever the backend had not populated a preview - which it never does for agent/cloud-generated video or audio outputs. The result was a black, unplayable tile. Mirror the existing '3D' fallback: when no server preview exists for a video or audio asset, point the element at the asset's own real content URL via getAssetFileUrl(), now with an explicit disposition=inline query param so the assets-API content endpoint serves it for in-page playback instead of forcing a download (its default is Content-Disposition: attachment). Existing callers of getAssetFileUrl() (downloads, the 3D viewer) are unaffected since the new disposition option defaults to unset. Video is unmounted while off-screen (VirtualGrid) and already loads with preload="metadata", so this does not turn the grid into an eager full-file video downloader. Flips the corresponding e2e assertion in agentVideoAsset.spec.ts from test.fail() to a passing assertion; the drag-to-canvas workflow-metadata test is left as test.fail() (separate, likely upstream/backend gap).
- The video E2E serves the MP4 fixture only at the card's own asset-id content URL (every other id gets the backend's 404 body) and asserts the dimensions load and currentTime advances after clicking play, instead of only checking currentSrc is non-empty. - The drag E2E uses the workflow-bearing fixture with the same exact-id routing; it stays an expected failure until #18111 lands. - The component test covers the video and audio fallback as one table and queries the media elements by test id instead of DOM traversal. - Drop the redundant disposition-default case in assetUrlUtil.test.ts.
1992034 to
8f23ccc
Compare
…et-card-drag-uses-file-url
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the child delta against its parent branch at 8f23cccff61a1350a43b9fd1ef50128b98255c20, not against main. The file URL and content-ID changes preserve preview rendering, reject non-OK fetches, retain the asset filename, and surface asset-card failures without changing plain link drops. The real playback and embedded-workflow drag cases pass, and I found no blocking correctness issue. The generated-video bug ticket should remain open for release follow-through.
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed the refreshed drag fix. Playback and embedded-workflow drag pass. Keep the generated-video incident open for release acceptance.
Full context for agent readers
Rechecked the complete child delta after the playback parent landed. The two integration conflicts preserve the child regression test without its expected-failure marker and preserve the real asset-metadata dependency in component tests. The resulting patch is identical to the previously reviewed child delta. Original file URLs remain separate from image-preview URLs; grouped cards use their file asset ID; failed HTTP responses do not become dropped files; filenames survive content URLs. No blocking finding or unresolved review thread.
Fresh verification: 187 focused unit/component tests pass, with one existing skip; cloud production build passes; commit hooks passed lint and source/browser typechecks; push hook passed unused-code checks. Both browser tests pass without retries: decoded video playback advances and dropping the video opens its named two-node embedded workflow. Earlier local startup failures were caused by Vite's cloud proxy replacing the multi-user backend's users response; serving the same cloud build without that override matches CI's identity contract and passes unchanged assertions.
This is source acceptance, not release acceptance. Normal required checks and the native merge queue still apply. Glossary: CI = automated integration checks; child delta = changes beyond the now-merged playback fix.
…fy-Org#18096) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789785533918339?thread_ts=1789715585.888609&cid=C0BGH348Z0C)_ ## Summary Video assets generated through the Comfy Agent / cloud path show up as an unplayable black tile in the Media Assets panel. This is an asset-panel regression from the assets-backed panel migration (Comfy-Org#15381): history records used to carry the original video URL, but an `/api/assets` video record has neither `thumbnail_url` nor `preview_url` (the backend only builds previews for images), and `MediaAssetCard.vue` had no fallback for that case, unlike the `3D` kind, which already falls back to a real content URL. ## Changes - **Fix (black tile / unplayable video)**: `MediaAssetCard.vue`'s `src` fallback now points video and audio assets at their real content URL (`getAssetFileUrl()`) when both preview fields are empty, mirroring the `3D` pattern. `getAssetFileUrl()` gained an optional `{ disposition: 'inline' }` option because `/api/assets/{id}/content` defaults to `Content-Disposition: attachment`, which makes the browser download instead of play. Existing callers (downloads, the 3D viewer) are unaffected. - Perf: `VirtualGrid` unmounts off-screen cards and `<video>` uses `preload="metadata"`, so this does not turn the panel into an eager video downloader. - **Follow-up (audio waveform perf)**: the waveform player fetches and decodes the whole audio file as soon as it gets a source, independent of `preload="metadata"`, and has no unmount cancellation for the in-flight download. Restoring missing URLs activates that work for these assets too. Not measured as a blocking regression here; tracked separately. - **Tests**: - `browser_tests/tests/sidebar/agentVideoAsset.spec.ts`: the MP4 fixture (`workflowInMedia/workflow.mp4`) is served only at the card's own asset-id content URL; every other `/api/assets/*/content` id returns the backend's 404 JSON. The playback test asserts the video's `currentSrc` is that URL, its dimensions load (`videoWidth > 0`), and `currentTime` advances after clicking play, so a 404'd source can no longer pass. - Component level (`MediaAssetCard.test.ts`): a video/audio table asserts the inline content URL reaches each media element (`<video>`, `<audio>`), queried via `data-testid` (`media-asset-video`, `wave-audio-media`). Removing the audio fallback fails the audio row. - `assetUrlUtil.test.ts` covers the `disposition: 'inline'` option. - **Drag-to-canvas (not fixed here, `test.fail()` kept)**: this is a frontend bug, not an upstream metadata gap. The card is grouped per job, so its `id` is the job id; the drag publishes `/api/assets/<job-id>/content`, which 404s, and the error JSON gets loaded as the "workflow". Fixed in the stacked PR Comfy-Org#18111, which flips this test to passing. ## Verification `pnpm vitest run` on the two affected unit files, `pnpm eslint`, `pnpm oxfmt --check`, `pnpm vue-tsc --noEmit`, and `pnpm knip` pass locally. The Playwright spec could not be run in this sandbox (no Chromium, no backend); it lists cleanly and runs in CI. ## Notes - This branch replaces `test/pm-1342-video-asset-repro`, which had an internal ticket ID baked into the branch name, commit message, and test file. That branch is left in place, unused, for whoever wants to delete it. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UP49A8QXF7zN5cYmUqsAx4 --- _Generated by [Claude Code](https://claude.ai/code/session_01UP49A8QXF7zN5cYmUqsAx4)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
christian-byrne
left a comment
There was a problem hiding this comment.
Approving at exact head a6e084bff3 after independent verification, not on the strength of CI alone.
Black-box browser, cloud project, against a cloud dist served by ghcr.io/comfy-org/comfyui-ci-container:0.0.22: both cases in agentVideoAsset.spec.ts pass - the video plays from its own content URL, and dragging the card onto the canvas opens the workflow embedded in the file. Seven runs; a single early failure was a cold-container waitForAppReady timeout in beforeEach that never reproduced across five subsequent isolated runs and two full-file serial runs. The cloud export-naming cases in assets.spec.ts also pass. Unit: 2474 passed, 1 skipped across src/platform/assets, src/components/sidebar, src/utils, src/composables/node, src/scripts.
Diff review: the two changes with the widest reach are fetchDroppedAsset returning undefined on !response.ok (previously a 404 body was wrapped in a File, so this is strictly narrower) and the new failure toast in addDropHandler, which only fires when the drop carried MIME_ASSET_INFO and yielded no file, leaving plain link drops silent as before. The getAssetContentId widening to Pick<AssetItem, 'id' | 'user_metadata'> is source-compatible with its existing caller.
Branch was 3 commits behind main and was updated before this review, so this approval is against the merged-with-main head.
…401) (#18174) ## Summary Dragging an asset out of the Media Assets panel does nothing while the panel is in **list view**, and works in grid view ([PM-1401](https://linear.app/comfyorg/issue/PM-1401/fix-dragging-an-asset-from-the-asset-panel-does-not-work-in-list-view), reported on nightly through the feedback survey). The composer's "drag in asset from asset panel" path is therefore unusable from one of the two view modes, with no error shown. Opened RED (`98f7ee82`, 5 failing unit cases) and made GREEN by `b468ce99`. Now based directly on `main`: #18096 and #18111 have merged, and this branch was rebuilt on top of them (`2fd052d1a5`). The `MediaAssetCard` payload writer this PR extracts is #18111's post-fix version, so the file-URL `text/uri-list` rule moves into `startAssetDrag` intact. **Before:** `MediaAssetCard` was the only asset surface that set `:draggable="true"` and wrote a drag payload. `AssetsSidebarListView` renders `AssetsListItem`, which sets neither, so a list row never started a native drag at all. The drop side is view-agnostic - `AgentPanelRoot` `isAssetDrag` accepts a drop purely on `dataTransfer.types` containing `application/x-comfy-asset-info` - so a row that advertises nothing is a silent attachment failure rather than a rejected drop. **After:** both flavours are written by one function, `startAssetDrag`, which derives everything it needs from the `AssetItem` alone (`getAssetType(asset.tags)`, `getMediaTypeFromFilename(asset.name)`), and both the grid card and the list rows call it. A list row now carries exactly the payload a grid card carries, including the file-URL `text/uri-list` rule this PR's parent established. Not the marquee: `useAssetGridSelection` only `preventDefault`s a dragstart while it is tracking, and it starts tracking only in a container holding `[data-asset-id]`, which list rows do not set. That attribute is deliberately still not set, so list-view marquee behaviour is unchanged by this PR. ## Changes - **What**: - `src/platform/assets/utils/assetDragUtil.ts` (new): `startAssetDrag(event, asset)` holds the Ctrl/Meta cancel guard and both `dataTransfer` flavours, moved verbatim from `MediaAssetCard.dragStart` (including the `allOutputs[0]` branch and the file-URL rule from #18111). Pure function of the asset, no component state. - `src/platform/assets/components/MediaAssetCard.vue`: `dragStart` delegates to it; now-unused imports dropped. - `src/components/sidebar/tabs/AssetsSidebarListView.vue`: rows get `:draggable="true"` and `@dragstart="startAssetDrag($event, item.asset)"`. `AssetsListItem` is a single-root component with attribute fallthrough, so no prop plumbing. - `docs/adr/ASSETS-DRAG-DROP-0035-asset-card-drag-uses-file-url.md`: new rule 4, the payload belongs to the asset and not to a view mode, with the PM-1401 failure recorded as the worked example; two consequences added (nothing mechanically forces a new surface through `startAssetDrag`; the Ctrl/Meta branch is grid parity in list view, not a behaviour list view needs today). Rule 1 de-specialised from `MediaAssetCard` to the drag side. - **Tests**: - `AssetsSidebarListView.test.ts`: rows are `draggable`; a row publishes the asset-info payload the composer resolves an attachment from; it publishes the file URL as `text/uri-list`; `it.for` over Ctrl and Meta asserts the drag is cancelled with nothing added. All 5 fail on the parent. - `browser_tests/tests/sidebar/assetListViewDrag.spec.ts` (new, `@cloud`): switches the panel to list view through the settings menu and drags a row onto the canvas, asserting the workflow embedded in the dropped file opens and the tab is named after the asset - the same observable as the grid counterpart in `agentVideoAsset.spec.ts`, so a regression in either view mode reads as the same failure. ## Review Focus - `startAssetDrag` is a plain function rather than a composable so a non-setup call site (the `VirtualGrid` slot) can use it; it calls `useFeatureFlags()` transitively through `getAssetFileUrl`, which that helper already did at call time before this PR. - The list row keeps `role="button"` and `tabindex="0"`; `draggable` on the same element does not change its accessibility name or keyboard activation, and the existing keyboard-activation case still passes. - Nothing lints the invariant that a new asset surface must call `startAssetDrag`. The ADR records that gap; the practical guard is one case per surface. - There is still no browser coverage anywhere for asset-drag-to-**composer-attachment** (the literal PM-1401 journey), for either view mode - `browser_tests` has no agent-composer drop harness at all. This PR asserts the canvas consumer of the same payload instead. Building that harness is a separate PR. ## Verification - `vitest run src/platform/assets src/components/sidebar src/components/queue src/composables/node`: 97 files, 1195 passed, 0 failed. - Browser case verified both ways against a cloud dist served by `ghcr.io/comfy-org/comfyui-ci-container:0.0.22` (the CI backend), `--project=cloud`: **red** with the list-view wiring reverted (`expect(tabName).toContain('agent_generated_video')` fails, no workflow loads), **green** with it restored. - Re-verified after rebuilding on post-merge `main`: this PR's list-view case **and both of #18111's grid-card cases** pass together in one run, which is the check that matters here - the extraction must not regress the file-URL fix it moved. - `pnpm typecheck` and `typecheck:browser` clean; `eslint`, `oxlint`, `oxfmt`, `stylelint` clean on changed files via lint-staged on both commits; Knip clean on push.
## Summary Seventeen non-billing Agent sources are carried for `core/1.54`. Exact-head hosted checks and target-native replay acceptance pass; review remains. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `2bd4dace2e6207fede11d2ac219d691a811769dc`, verified under Node 25.9.0 and pnpm 11.13.1. - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - ancestor head `bd7da3cffd6dc349e1c48c5a277bc112cabd0e41` passed one zero-retry target-native warning-retention case with an inspected final frame; its [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/7fa0ba4d731f00684388a45f1aeb1d24dc6f2280/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1145-utc-exact-core-native-case-passes-final-warning-frame-inspected) is ancestry evidence, not acceptance of this newer head; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `389a3718bd2f637f704bde349068cbfd87cd9542` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `366e0287095876351377f873688fece88eb90397` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:44:02 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. Exact-head hosted checks and target-native replay acceptance pass. Review and the release-target merge-readiness gate remain required before merge. No deployment or check waiver is authorized. </details> Justification: Authorized Agent 1.54 release backport aggregate merged without standing human approval under the published release-backport authority; exact-head hosted checks, target-native replay acceptance, target-aware merge guard, adaptation review, and absence of unresolved human objections limit risk. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
## Summary Seventeen non-billing Agent sources are carried for `cloud/1.54`. The candidate now contains release `1.54.12`; fresh hosted checks and target-native replay acceptance passed. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`, verified locally under Node 25.9.0 and pnpm 11.13.1. - merged current `cloud/1.54` tip `d2667baf6bdb8664821b4bed7a7f5a1df65f9f49` cleanly; the imported release delta is limited to the package version and locale data; - frozen installation, 174 focused Agent/missing-model tests with 1 expected failure, main and browser typechecks, formatting, full ESLint with zero errors, the Cloud production build, target ancestry, and diff checks pass locally; - fresh exact-head hosted checks and one zero-retry target-native replay passed after the release target changed; - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `dfe99947cffb5f31c5f4750113eb9770720e5eac` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `5ec6c64e9b78b56b12350ae732dc1e1ea20052e0` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:45:15 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. The prior replay receipt remains historical evidence for parent head `516f6b5f71e251b25985fb61715432f05249c4bd`. Fresh hosted checks and the fresh target-native replay passed at current head `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`; adaptation review and the release-target merge-readiness gate also passed. </details> Justification: Author-owned release aggregate merged under the published Agent 1.54 backport grant after exact-head hosted checks, target-native replay, adaptation review, target ancestry, and the target-aware merge guard passed; no independent approval was available. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
Requested by Christian Byrne · Slack thread
Summary
Dropping a cloud video (or audio, or 3D) asset card onto the canvas showed an invalid-workflow error instead of opening the workflow embedded in the file, because the card dragged its preview URL rather than its file URL. This PR ships the fix, the ADR, and the tests. It was opened RED (ADR + failing tests, commits
a2c69cb6,844d56b9), went through two adversarial reviews, and the GREEN commits (14d047c8fix,d7ea37afADR rewrite) incorporate the reviewers' required changes.Before: with the cloud assets API on,
unflattenOutputAssetsgroups cards per job, so a card'sidis the job id and the file's own id lives inuser_metadata.assetId.MediaAssetCarddragStartpublishedresolvePreviewUrl(asset)astext/uri-list. Cloud images self-preview (theirpreview_urlis the file), so they worked. A video without a preview fell back to/api/assets/<jobId>/content, ingest answered 404{"code":"ASSET_NOT_FOUND"},fetchDroppedAssetwrapped that JSON body in aFilewithout checkingresponse.ok, andhandleFiletried to load{code,message}as a workflow. A 3D asset with a persisted thumbnail (preview_id) dragged the thumbnail PNG instead of the model. A node target withoutonResultItemDrop(LoadAudio) named the fetched file after the last URL segment, the literalcontent.After: the drag always carries
getAssetFileUrl(asset)(resolvesuser_metadata.assetId || asset.id, never a preview), for every media kind.fetchDroppedAssetreturns no file on a non-OK response (status-based). The canvas drop handler toasts andreportErrors when a drop that carriedapplication/x-comfy-asset-infoyields no file; plain link drops stay silent.useNodeDragAndDropnames the fetchedFileafter the asset-infofilenamebefore falling back to the URL.resolvePreviewUrl's fallback goes through the sharedgetAssetContentId, so no path derives a content URL from a job id. The asset-info payload still carriespreview_urlfor image previews (agent composer). No server change.Changes
src/platform/assets/components/MediaAssetCard.vue:text/uri-listfromgetAssetFileUrl(asset);resolvePreviewUrlonly feeds the imagepreview_urlfield of the asset-info payload.src/utils/eventUtils.ts:fetchDroppedAssetreturnsundefinedon!response.ok(return shape unchanged;AgentPanelRoot.attachDroppedAssetrelies on it).src/composables/node/useNodeDragAndDrop.ts: file name prefersparseAssetInfo(dataTransfer)?.filename, then?filename=, then last URL segment.src/scripts/app.tsaddDropHandler: whenextractFilesFromDragEventreturns[]anddataTransfer.typesincludesMIME_ASSET_INFO,reportError(..., { errorType: 'asset_drop_load_failure' })+useToastStore().addAlert(t('toastMessages.assetDropFailed')). New i18n keytoastMessages.assetDropFailed.src/platform/assets/utils/assetUrlUtil.ts: exportgetAssetContentId(acceptsPick<AssetItem, 'id' | 'user_metadata'>).assetPreviewUtil.tsresolvePreviewUrl: fallbackpreview_id ?? getAssetContentId(asset);AssetRecordgains optionaluser_metadata.docs/adr/ASSETS-DRAG-DROP-0035-asset-card-drag-uses-file-url.md(+ index row): Decision stated as four durable rules; Context records why node targets withonResultItemDropnever see the URI and the self-preview backend fact. Status left Proposed.MediaAssetCard.test.ts:it.fortable built with the realunflattenOutputAssets: grouped image with self-preview →/api/assets/<fileId>/content; grouped video with no preview →/api/assets/<fileId>/content; 3D model withpreview_id→/api/assets/model/content; flag-OFF history image → its/api/view?...URL absolutized. ThegetOutputAssetMetadatamodule mock is gone (it maskedassetId).src/utils/__tests__/eventUtils.test.ts: table over{status, contentType, body}: 404 JSON →[]; 500 HTML →[]; 200 workflow JSON → oneapplication/jsonFile (defeats a content-type-sniffing fake fix).useNodeDragAndDrop.test.ts: asset-card drop with{filename:'clip.wav'}asset-info yields a File namedclip.wav.assetPreviewUtil.test.ts:resolvePreviewUrltable incl. job-grouped card → file id.app.test.ts: drop yielding no file toasts + reports for an asset-card drag, stays silent for a plaintext/uri-listdrag.browser_tests/tests/sidebar/agentVideoAsset.spec.ts:test.fail()removed; asserts tab name andgetGraphNodesCount() === 2(workflow.mp4 embeds LoadImage + SaveImage); route-order comment states Playwright matches the most recently registered route first.Review outcomes
Both adversarial reviews confirmed the root cause and the kind-agnostic rule. Changes made because of them: the flag-OFF guard row and realistic grouped image row; the 500-HTML and 200-success rows; the
useNodeDragAndDropfilename fix; surfacing failed asset drops (toast + telemetry) instead of a silent no-op; tighteningresolvePreviewUrl; the node-count assertion in e2e; and the ADR rewritten as rules rather than a change log.Verification
pnpm vitest run src/platform/assets src/utils src/composables/node src/scripts: 159 files, 2357 passed, 1 skipped, 0 failed (the 4 previously red cases are green).pnpm eslinton changed files: 0 errors (3 pre-existingimport-x/no-named-as-default-memberwarnings in app.ts, untouched).pnpm oxlintclean on changed files.vue-tsc --noEmitexit 0.pnpm knipexit 0.oxfmt --checkclean.pnpm adr:checkpass. Pre-commit lint-staged (typecheck + typecheck:browser) passed on both commits. The Playwright cloud project foragentVideoAsset.spec.tsruns in CI.Review Focus
Unable to load the dropped asset. Random non-asset links dropped from elsewhere do not toast.asset_drop_load_failure.uploadAudio.tshas noonResultItemDrop, so a cloud audio card dropped on LoadAudio still re-uploads the fetched file (now correctly named) instead of referencing the existing asset.test/agent-video-asset-thumbnail-repro-v2(stacked on fix: play agent-generated video assets in the Media Assets panel #18096).🤖 Generated with Claude Code
https://claude.ai/code/session_01UP49A8QXF7zN5cYmUqsAx4