Skip to content

[backport cloud/1.54] Agent catalogue sweep 2 - #18185

Merged
christian-byrne merged 36 commits into
cloud/1.54from
catalogue-sweep2-cloud-1.54-20260920
Sep 20, 2026
Merged

christian-byrne merged 36 commits into
cloud/1.54from
catalogue-sweep2-cloud-1.54-20260920

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Seventeen non-billing Agent sources are carried for cloud/1.54. The candidate now contains release 1.54.12; fresh hosted checks and target-native replay acceptance passed.

Full context for agent readers

Changes

  • Sources: 18113, 18096, 18122, 18164, 18121, 18148, 18111, 18174, 17912, 18081, 16936, 18183, 18197, 18070, 18084, 18071, and 18107.
  • New in this head: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, HostDoc, and tab-return harnesses.
  • Dependencies: no new package dependency; release lockfile pins are preserved.
  • Exclusions: billing/account work, protected source 17730, target-specific screenshot source 18168, separately owned focused carriers, and 18123, whose generic Vue-node test depends on 17576, absent from this release line.

Review focus

  • PR 16936 adapts widget-state rebinding to the 1.54 store API without importing main's newer visibility architecture.
  • PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary.
  • PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content.
  • The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them.
  • This is not behavioral acceptance, deployment authorization, or a merge-check waiver.

Exact-head verification

Current head: aabd82168d2d7b2f1b9f685a5477dcdc491d3b02, verified locally under Node 25.9.0 and pnpm 11.13.1.

  • merged current cloud/1.54 tip d2667baf6bdb8664821b4bed7a7f5a1df65f9f49 cleanly; the imported release delta is limited to the package version and locale data;

  • frozen installation, 174 focused Agent/missing-model tests with 1 expected failure, main and browser typechecks, formatting, full ESLint with zero errors, the Cloud production build, target ancestry, and diff checks pass locally;

  • fresh exact-head hosted checks and one zero-retry target-native replay passed after the release target changed;

  • main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle;

  • the prior 146-test selection passed with 1 expected failure;

  • after repairing idempotent replay, 119 focused tests passed with 1 expected failure;

  • the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and aria-invalid=true survive tab return;

  • frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head;

  • the extended browser case commits pasted-node operations through the real HostDoc and asserts the pasted position survives another tab retarget;

  • parent head dfe99947cffb5f31c5f4750113eb9770720e5eac passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection;

  • the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully;

  • parent head 5ec6c64e9b78b56b12350ae732dc1e1ea20052e0 reached local paste but had already closed the Agent panel, which unmounted AgentPanelRoot, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged HostDoc assertion;

  • one zero-retry target-native invocation passed the complete case at 13:45:15 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the durable QA receipt includes inspected frames and cleanup;

  • PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully;

  • targeted format and ESLint passed;

  • three affected Cloud-project browser cases collected successfully.

The prior replay receipt remains historical evidence for parent head 516f6b5f71e251b25985fb61715432f05249c4bd. Fresh hosted checks and the fresh target-native replay passed at current head aabd82168d2d7b2f1b9f685a5477dcdc491d3b02; adaptation review and the release-target merge-readiness gate also passed.

Justification: Author-owned release aggregate merged under the published Agent 1.54 backport grant after exact-head hosted checks, target-native replay, adaptation review, target ancestry, and the target-aware merge guard passed; no independent approval was available.

@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 00f4cb3e-224b-417f-aed1-f8fe2114fc82

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 20, 2026 4:48pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/20/2026, 04:50:04 PM UTC

Links

🎭 Playwright: ✅ 1932 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1911 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 143ms TBT · 105.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.0 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 56ms TBT · 165.7 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 439ms TBT · 175.0 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 10ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 514ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 68.9 MB
canvas-idle: DOM nodes -131
canvas-idle: event listeners -79
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 34ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 975ms
canvas-mouse-sweep: script duration 176ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.8 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 378ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 74.1 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 467ms
dom-widget-clipping: script duration 168ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.8 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 683ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.7 MB
large-graph-idle: DOM nodes -271
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1770ms
large-graph-pan: script duration 867ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 76.8 MB
large-graph-pan: DOM nodes -281
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1735ms
large-graph-zoom: script duration 792ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.0 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1949ms
legacy-node-drag: script duration 958ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.0 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 615ms
minimap-idle: script duration 33ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.8 MB
minimap-idle: DOM nodes -279
minimap-idle: event listeners -177
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 422ms
subgraph-dom-widget-clipping: script duration 145ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.3 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 539ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.7 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -210
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 851ms
subgraph-mouse-sweep: script duration 114ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 65.2 MB
subgraph-mouse-sweep: DOM nodes -298
subgraph-mouse-sweep: event listeners -211
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 997ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 143ms
subgraph-transition-enter: heap used 105.3 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5925ms
viewport-pan-sweep: script duration 2713ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 71.7 MB
viewport-pan-sweep: DOM nodes -274
viewport-pan-sweep: event listeners -161
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16924ms
vue-large-graph-idle: script duration 287ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.0 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14933
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 165
vue-large-graph-pan: task duration 20817ms
vue-large-graph-pan: script duration 950ms
vue-large-graph-pan: TBT 56ms
vue-large-graph-pan: heap used 165.7 MB
vue-large-graph-pan: DOM nodes -8084
vue-large-graph-pan: event listeners -14926
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 79ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6217ms
vue-node-resize-workload: script duration 123ms
vue-node-resize-workload: TBT 439ms
vue-node-resize-workload: heap used 175.0 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8473ms
vue-zoom-out-idle: script duration 142ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.0 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 3
workflow-execution: style recalc count 8
workflow-execution: task duration 75ms
workflow-execution: script duration 7ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.8 MB
workflow-execution: DOM nodes 127
workflow-execution: event listeners 36
Raw data
{
  "timestamp": "2026-09-20T16:59:50.650Z",
  "gitSha": "11ea0ac256523a86126638ce3260df0e25f27ee9",
  "branch": "catalogue-sweep2-cloud-1.54-20260920",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2054.5549999999366,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.691,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 517.138,
      "heapDeltaBytes": 4050848,
      "heapUsedBytes": 73871628,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.815999999999999,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2039.6140000000287,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.921000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.3190000000001,
      "heapDeltaBytes": 1563252,
      "heapUsedBytes": 70563212,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 10.624000000000002,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2091.8400000000474,
      "styleRecalcs": 82,
      "styleRecalcDurationMs": 38.441,
      "layouts": 14,
      "layoutDurationMs": 5.4510000000000005,
      "taskDurationMs": 1074.845,
      "heapDeltaBytes": -2128316,
      "heapUsedBytes": 68787004,
      "domNodes": -280,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 192.626,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1885.291000000052,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 29.794999999999998,
      "layouts": 14,
      "layoutDurationMs": 4.468,
      "taskDurationMs": 875.924,
      "heapDeltaBytes": 13194544,
      "heapUsedBytes": 83788096,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 158.776,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1677.4599999999964,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 15.630999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.9910000000000001,
      "taskDurationMs": 368.48099999999994,
      "heapDeltaBytes": 4653088,
      "heapUsedBytes": 75726844,
      "domNodes": 75,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 11.876999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1751.5980000000582,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.001,
      "layouts": 6,
      "layoutDurationMs": 1.2960000000000003,
      "taskDurationMs": 387.19,
      "heapDeltaBytes": 5310028,
      "heapUsedBytes": 79709140,
      "domNodes": 74,
      "jsHeapTotalBytes": 18087936,
      "scriptDurationMs": 11.923999999999998,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 690.6370000000379,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.001000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 466.489,
      "heapDeltaBytes": -7810640,
      "heapUsedBytes": 62813672,
      "domNodes": 18,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 165.96,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 703.8279999999304,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.418,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 467.91099999999994,
      "heapDeltaBytes": 18750184,
      "heapUsedBytes": 87713080,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 170.768,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2050.31699999995,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.813,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 727.8589999999999,
      "heapDeltaBytes": -15844244,
      "heapUsedBytes": 87376440,
      "domNodes": -263,
      "jsHeapTotalBytes": -1118208,
      "scriptDurationMs": 37.744,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2034.7750000000815,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.909999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 637.8269999999999,
      "heapDeltaBytes": 5351316,
      "heapUsedBytes": 81803908,
      "domNodes": -278,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 38.216,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2429.793000000018,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 12.896,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1757.0199999999998,
      "heapDeltaBytes": -576216,
      "heapUsedBytes": 75993368,
      "domNodes": -284,
      "jsHeapTotalBytes": -405504,
      "scriptDurationMs": 837.1869999999999,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2456.6420000001017,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 11.976000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1783.6370000000002,
      "heapDeltaBytes": 7804456,
      "heapUsedBytes": 85134588,
      "domNodes": -277,
      "jsHeapTotalBytes": 118784,
      "scriptDurationMs": 896.642,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3771.993000000066,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.126,
      "layouts": 60,
      "layoutDurationMs": 12.295,
      "taskDurationMs": 1747.179,
      "heapDeltaBytes": 8393876,
      "heapUsedBytes": 75932956,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 781.64,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3591.32099999988,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.681000000000003,
      "layouts": 60,
      "layoutDurationMs": 11.846,
      "taskDurationMs": 1723.2620000000002,
      "heapDeltaBytes": 9716524,
      "heapUsedBytes": 77090796,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 801.6840000000001,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3129.426999999964,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.993999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1956.5600000000002,
      "heapDeltaBytes": 26418440,
      "heapUsedBytes": 94533584,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 958.8700000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3087.2620000000097,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.001000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1940.4750000000001,
      "heapDeltaBytes": 17549252,
      "heapUsedBytes": 85897548,
      "domNodes": 0,
      "jsHeapTotalBytes": 942080,
      "scriptDurationMs": 957.5480000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2048.708999999917,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 3.258999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 599.951,
      "heapDeltaBytes": 9813184,
      "heapUsedBytes": 86948396,
      "domNodes": -272,
      "jsHeapTotalBytes": -3252224,
      "scriptDurationMs": 32.45099999999999,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2042.2209999999268,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.8130000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 629.8989999999999,
      "heapDeltaBytes": 5655424,
      "heapUsedBytes": 82525584,
      "domNodes": -285,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 34.13200000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 573.9609999999402,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.587000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.937,
      "heapDeltaBytes": 14644024,
      "heapUsedBytes": 86578812,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 143.267,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 631.4170000000559,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.371000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 433.663,
      "heapDeltaBytes": 15047044,
      "heapUsedBytes": 88046832,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 145.86400000000003,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2032.3570000000473,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.464,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 554.342,
      "heapDeltaBytes": -12518460,
      "heapUsedBytes": 60237980,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 10.041000000000002,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.329999999949,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.685999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 523.681,
      "heapDeltaBytes": 2229044,
      "heapUsedBytes": 75347604,
      "domNodes": -293,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.511999999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1735.1700000000392,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.818999999999996,
      "layouts": 18,
      "layoutDurationMs": 5.093,
      "taskDurationMs": 850.209,
      "heapDeltaBytes": 5781392,
      "heapUsedBytes": 78348344,
      "domNodes": -296,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 115.46999999999998,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1756.7189999999755,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 28.987,
      "layouts": 18,
      "layoutDurationMs": 5.483999999999999,
      "taskDurationMs": 850.8169999999999,
      "heapDeltaBytes": -14521820,
      "heapUsedBytes": 58418968,
      "domNodes": -299,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 113.25299999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1402.0419999999376,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 33.022000000000006,
      "layouts": 15,
      "layoutDurationMs": 16.009,
      "taskDurationMs": 997.096,
      "heapDeltaBytes": 21224576,
      "heapUsedBytes": 110435940,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 32.531000000000006,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 143,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8620.620000000032,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 39.05200000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5915.955,
      "heapDeltaBytes": -6845240,
      "heapUsedBytes": 69310256,
      "domNodes": -280,
      "jsHeapTotalBytes": 4087808,
      "scriptDurationMs": 2710.312,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8664.831999999933,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.622,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5934.64,
      "heapDeltaBytes": -21875128,
      "heapUsedBytes": 81014556,
      "domNodes": -267,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 2716.532,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17377.380000000016,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16877.496,
      "heapDeltaBytes": -59834160,
      "heapUsedBytes": 179090912,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17457152,
      "scriptDurationMs": 283.416,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17575.296999999864,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16971.172,
      "heapDeltaBytes": -53268488,
      "heapUsedBytes": 181591908,
      "domNodes": -8068,
      "jsHeapTotalBytes": -8945664,
      "scriptDurationMs": 290.475,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21253.575999999954,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 19.86100000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21008.387,
      "heapDeltaBytes": -49230552,
      "heapUsedBytes": 168598592,
      "domNodes": -8100,
      "jsHeapTotalBytes": -11304960,
      "scriptDurationMs": 965.2720000000002,
      "eventListeners": -14923,
      "totalBlockingTimeMs": 89,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20900.65000000004,
      "styleRecalcs": 161,
      "styleRecalcDurationMs": 18.85500000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20625.544,
      "heapDeltaBytes": -39039568,
      "heapUsedBytes": 178818464,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12857344,
      "scriptDurationMs": 935.3599999999999,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 23,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6381.463999999937,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.015,
      "layouts": 20,
      "layoutDurationMs": 23.42699999999999,
      "taskDurationMs": 6300.235000000001,
      "heapDeltaBytes": -47715408,
      "heapUsedBytes": 178165636,
      "domNodes": -8068,
      "jsHeapTotalBytes": 5808128,
      "scriptDurationMs": 132.67000000000002,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 446,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6247.70599999988,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.80300000000001,
      "layouts": 20,
      "layoutDurationMs": 22.338999999999984,
      "taskDurationMs": 6134.618999999999,
      "heapDeltaBytes": -22884548,
      "heapUsedBytes": 188786756,
      "domNodes": -8068,
      "jsHeapTotalBytes": 13979648,
      "scriptDurationMs": 113.558,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 431,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8720.811000000027,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8478.064999999999,
      "heapDeltaBytes": 22021008,
      "heapUsedBytes": 181841204,
      "domNodes": 0,
      "jsHeapTotalBytes": -10747904,
      "scriptDurationMs": 136.25699999999995,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8833.442000000105,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8468.806,
      "heapDeltaBytes": 6104060,
      "heapUsedBytes": 178940160,
      "domNodes": 0,
      "jsHeapTotalBytes": -12845056,
      "scriptDurationMs": 146.75300000000001,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 114.41799999988689,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 16.757,
      "layouts": 3,
      "layoutDurationMs": 1.4690000000000003,
      "taskDurationMs": 85.147,
      "heapDeltaBytes": 3363460,
      "heapUsedBytes": 72407660,
      "domNodes": 150,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 9.161,
      "eventListeners": 38,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 89.18399999993198,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 13.174,
      "layouts": 2,
      "layoutDurationMs": 1.1629999999999998,
      "taskDurationMs": 65.21300000000001,
      "heapDeltaBytes": 3006248,
      "heapUsedBytes": 71833824,
      "domNodes": 104,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.943999999999999,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50278 75329 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.3% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.6% 257
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 20, 2026
@codecov

codecov Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.01310% with 32 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/workbench/extensions/agent/AgentPanelRoot.vue 33.33% 16 Missing ⚠️
...ench/extensions/agent/crdt/liveWidgetProjection.ts 92.45% 8 Missing ⚠️
...ensions/agent/composables/agent/useAgentConsent.ts 80.00% 3 Missing ⚠️
src/composables/node/useNodeDragAndDrop.ts 66.66% 1 Missing ⚠️
src/platform/assets/components/MediaAssetCard.vue 83.33% 1 Missing ⚠️
src/platform/assets/utils/assetUrlUtil.ts 87.50% 1 Missing ⚠️
...nch/extensions/agent/crdt/agentNodeMaterializer.ts 96.42% 1 Missing ⚠️
...h/extensions/agent/stores/agent/agentPanelStore.ts 75.00% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18185   +/-   ##
=============================================
  Coverage              ?   83.53%           
=============================================
  Files                 ?     2094           
  Lines                 ?   123397           
  Branches              ?    33330           
=============================================
  Hits                  ?   103077           
  Misses                ?    20142           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.75% <70.37%> (?)
unit 78.45% <93.84%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/common/WaveAudioPlayer.vue 90.74% <ø> (ø)
.../components/sidebar/tabs/AssetsSidebarListView.vue 67.79% <100.00%> (ø)
src/extensions/core/agentPanel.ts 100.00% <100.00%> (ø)
src/lib/litegraph/src/LGraphCanvas.ts 67.38% <100.00%> (ø)
src/lib/litegraph/src/widgets/BaseWidget.ts 83.45% <100.00%> (ø)
src/platform/assets/components/MediaVideoTop.vue 100.00% <ø> (ø)
src/platform/assets/utils/assetDragUtil.ts 100.00% <100.00%> (ø)
src/platform/assets/utils/assetPreviewUtil.ts 90.69% <100.00%> (ø)
src/platform/telemetry/types.ts 92.59% <ø> (ø)
...atform/workflow/management/stores/comfyWorkflow.ts 94.25% <100.00%> (ø)
... and 22 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

uytieu and others added 12 commits September 19, 2026 23:41
New users now see the agent consent card on first load, and the agent
tour appears for each workspace they join.

- **What**:
- A first-time user sees the consent card as soon as the app loads.
Before, the card appeared only after a click on "Ask Comfy Agent".
  - The button still opens the card, as before.
- The card is offered one time for each account and workspace. It does
not return on every load.
  - A user who already accepted sees nothing new.
- When the user accepts, the agent panel opens. This is what the button
already does.
- The short agent tour now counts per account and workspace, in the same
way as the consent card. A user who joins a new workspace gets the tour
there.
- A user who already finished the tour does not see it again in the
workspace they are in now.

- The card waits for the saved answer to arrive. A user who already
accepted never sees a flash of the card.
- If the saved answer cannot be read, the card is not offered, and the
one offer is kept for the next load.
- The record of the offer is written before the card opens. PM-1187
reports that the tour returns on every agent use. This order prevents
that result here.
- The tour used one record for the whole device, while consent uses one
record for each account and workspace. A user who joined a new workspace
therefore saw the card again but got no guidance. The two records now
use the same scope.
- An old device-wide tour record moves to the workspace the user is in
now, and then it is removed. Nobody who finished the tour sees it a
second time.
- The offer counts per account and workspace, not per version. There is
no record of which agent version a user has seen. Question 3 in PM-1276
is still open.
- Sign-in does not start on its own. The offer needs a signed-in user,
so a signed-out user is not interrupted.

<!-- Add a recording of a first load with an account that has not
accepted -->

[PM-1276](https://linear.app/comfyorg/issue/PM-1276/show-the-agent-consent-card-on-first-load-not-only-on-button-click)
·
[PM-514](https://linear.app/comfyorg/issue/PM-514/agent-opt-in-consent-card-on-both-local-and-cloud)

https://github.com/user-attachments/assets/a10de566-80d0-4e96-8883-c70b196699e5

---------

Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
(cherry picked from commit 7ca9c6a)
… tab-switch reconcile (#18081)

&lt;!-- ccr-slack-attribution --&gt;
_Requested by **Christian Byrne** · [Slack
thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789709391046969?thread_ts=1789709391.046969&cid=C0BGH348Z0C)_

Fixes an autogrow-node color and input label loss on tab switch: a CRDT
reconcile in `graphMutations.ts` now merges onto the live node's state
instead of wholesale-replacing it, so client-only presentation fields
the CRDT document never carries survive a tab-switch reconcile. Includes
the Playwright repro that pins the exact symptom (originally added as
`test.fail()`, now passing as a normal `test()`) plus new unit coverage
of the merge behavior.

- **What**: Before this PR, a node with an autogrow input group (e.g.
GPT Image 2.5's `model.images.image_N` slots) lost its API-node color
and showed the raw internal dotted input name after the in-app agent
wired something into it and the tab was switched away and back — a CRDT
reconcile in `nodeDataStore.ts`'s `assignNodeFields` (via `updateNode`)
unconditionally reset `color`/`bgcolor` and replaced `state.inputs`
wholesale from a CRDT payload that never carries either. **This PR fixes
that** in `src/workbench/extensions/agent/crdt/graphMutations.ts`:
`resolveNodeColors` keeps the live node's `color`/`bgcolor`/`boxcolor`
when the payload omits them, and `preserveSlotDisplayMetadata` (used by
the new `prepareInputSlot`) keeps an existing input slot's
`localized_name`/`label` when the payload's slot at the same index and
name doesn't carry one — while still applying an explicit value the
payload does set, and not carrying stale labels onto a genuinely
different input at the same slot index.
- **Tests**:
`browser_tests/tests/agent/agentAutogrowTabSwitchReconcile.spec.ts` sets
up the exact repro scenario (a wired autogrow node materialized via the
CRDT graph-mutation layer), confirms the node renders correctly before
the tab switch, switches to a new tab and back to force the CRDT
follower's tab-switch reconcile (`useAgentCrdtFollower.ts`), and asserts
the color and label are still correct afterward. This started as a
`test.fail()` pinning the bug; with the fix in place it now passes as a
normal `test()`. `graphMutations.test.ts` adds two unit-level regression
guards for the same merge behavior (color/label preserved on an
omitted-field reconcile; not stale when the payload does supply new
values).
- **Root cause / blast radius**: per the RCA in the spec file's header
comment, this reconcile path (`prepareNode`/`prepareInputSlots`) is
shared across every `reconcileNode` call, so the fix likely also
addresses other reports of the same class of client-only-field loss on
CRDT reconcile, not just the tab-switch trigger covered here.
- **Breaking**: none
- **Dependencies**: none

- The merge logic in `graphMutations.ts` (`resolveNodeColors`,
`preserveSlotDisplayMetadata`/`prepareInputSlot`): confirm it only fills
in fields the payload omits and never masks a value the payload does set
(see the second new unit test in `graphMutations.test.ts` for that
guard).
- The fix lives in the shared `prepareNode`/`prepareInputSlots`
reconcile path, so it likely also resolves other reports of the same
class of bug beyond the tab-switch trigger covered here.
- Confirmed locally: the Playwright repro spec passes, and the new
`graphMutations.test.ts` unit tests pass.

&lt;!-- Fixes #ISSUE_NUMBER --&gt;

N/A (non-visual regression test)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

https://claude.ai/code/session_01Mj4zDEXP8JxWeNcX24RGGw

---------

Co-authored-by: bymyself <cbyrne@comfy.org>
(cherry picked from commit 9f78312)
Carry the minimal document-host fixture used by the regression spec and adapt release-line fixture and locale APIs without changing the production fix.
Use the release-local activity row for the socket reconnect coverage, preserve the server object-info route for the autogrow case, and synchronize the carried ADR index metadata.
Adapt source PR #16936 (d15cdcc) to the cloud/1.54 widget store API while preserving the release-local visibility architecture.
…w modes (#18183)

Nothing exercised **a real drag from the assets panel into the
composer**, in either view mode. #18174 (PM-1401, a list row that never
started a drag) shipped proved by asserting the **canvas** consumer of
the same drag payload — a real but indirect proxy, because it cannot
catch a composer-side attach regression. That is the user-visible half
of [PM-1402](https://linear.app/comfyorg/issue/PM-1402).

**Scope note, corrected after a rebase.** When this branch was opened
there was no composer-attachment browser coverage at all. #18104 has
since landed `agentBatchOutputAttachment.spec.ts`, which does assert a
composer attachment — but it **synthesizes** the `DataTransfer` in
`page.evaluateHandle` and dispatches it, so it covers the drop/attach
half against a fabricated payload and never exercises a drag source. The
two are complements, not duplicates: that spec would still pass if every
asset card and list row in the panel stopped publishing a payload, which
is exactly the PM-1401 failure. This PR covers the source half, through
a real `dragTo` from the panel, in both view modes. Verified together
post-rebase: all four cases pass in one run.

This is coverage plus the harness affordances it needed. No production
behavior changes.

- **What**:
- `browser_tests/tests/agent/agentComposerAssetDrop.spec.ts` (new,
`@cloud`): opens the agent panel and the assets sidebar, drags an asset
onto the panel, and asserts a composer attachment chip naming that asset
appears. Runs for **both** grid and list view.
- `src/workbench/extensions/agent/.../AttachmentChip.vue`: adds
`data-testid="agent-attachment-chip"` and `data-attachment-name`.
Distinct from the existing `asset-reference-chip`, which is the inline
`@`-reference chip rendered elsewhere in the composer, not the
drop-attachment chip; `AttachmentChip` had no anchor of its own. The
visible label truncates at `max-w-32`, so asserting on rendered text
cannot distinguish two long filenames — precisely the wrong-asset
failure worth catching. Two attributes, no behavior or style change.
- `browser_tests/fixtures/components/AgentPanel.ts`: `attachmentChips`
and `attachmentChip(name)`.
- `browser_tests/fixtures/agentPanelFixture.ts`: `bootAgentApp` gains an
`assets` option. The fixture hard-routed `/api/assets` to an empty list,
so any asset-flow spec had to re-route after boot and lean on
route-precedence order. The route is also narrowed to the list endpoint
(`**/api/assets` and `**/api/assets?**`) so a spec can serve
`/api/assets/<id>/content` for the file itself; the previous
`**/api/assets**` swallowed it.

- **The route narrowing is the one change with reach beyond this spec.**
Previously `**/api/assets**` also absorbed content requests for every
agent spec; now it does not. No current agent spec seeds assets, so none
issues a content request, and the full agent suite passes — but it is
the thing to push back on if you know of a spec depending on the broader
swallow.
- The assertion is `attachmentChip(ASSET_NAME)` plus a count of 1, not a
bare "some chip appeared": a drag that attaches the wrong asset would
pass the weaker form.
- The drop target is `agentPanel.root` (`#agent-panel-root`), which is
where `AgentPanelRoot` binds `@drop`. That is deliberately the whole
panel, not the composer sub-element — relevant to
[PM-1361](https://linear.app/comfyorg/issue/PM-1361)/[PM-1363](https://linear.app/comfyorg/issue/PM-1363),
which are about widening the drop footprint.

- **Sensitivity proven, not assumed.** With the list-view
`draggable`/`dragstart` wiring removed from `AssetsSidebarListView.vue`
and the dist rebuilt, the **list case fails** on the missing chip
(`expect(locator).toBeVisible() failed — element(s) not found`) while
the **grid case still passes** — the exact PM-1401 signature. Wiring
restored and both pass again.
- Both new cases pass against a cloud dist served by
`ghcr.io/comfy-org/comfyui-ci-container:0.0.22`, `--project=cloud`.
- Rebased onto `main` at `38cc119a21` and re-verified: this spec's two
cases pass alongside `agentBatchOutputAttachment` and
`agentUploadedImageAttachment`, 4/4 in one run, after
`AgentPanelRoot.vue` changed underneath on main.
- Full agent browser suite on the pre-rebase build: **78 passed, 1
failed**. The failure is `agentConversationReplay.spec.ts` `@screenshot`
(24152 px, ratio 0.01). It fails **identically on clean `main`** with
these changes stashed, so it is a local-vs-CI rendering difference, not
this change.
- `pnpm typecheck` clean; agent unit suite 110 files / 1689 passed, 3
expected-fail; lint-staged (oxfmt, oxlint, eslint, stylelint, typecheck,
typecheck:browser) clean on commit.

Workspace row: `qaf-78`.

(cherry picked from commit b3b0579)
…8197)

Backport the source browser coverage and fixtures without production changes.

(cherry picked from commit 00b02cb)
Adapt the source change to the release-local liveWidgetProjection path. The retired recorded-conversation harness coverage is omitted; focused projection and widget tests remain.

(cherry picked from commit 77b7ef9)
Adapt the placement port to the release-line graph mutation and layout-store APIs. The retired prompt-reconcile test remains omitted.

(cherry picked from commit 1319876)
Extend the release-local document host for template operations and seed client-only API-node colors before exercising the reconcile preservation contract.
@christian-byrne christian-byrne changed the title Backport Agent catalogue sweep 2 to cloud/1.54 [backport cloud/1.54] Agent catalogue sweep 2 Sep 20, 2026
@christian-byrne
christian-byrne marked this pull request as ready for review September 20, 2026 13:59
@christian-byrne
christian-byrne requested a review from a team as a code owner September 20, 2026 13:59

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloud adaptation reviewed; exact-head gates are green.

Full context for agent readers

I reviewed the cloud/1.54 adaptation at exact head aabd82168d2d7b2f1b9f685a5477dcdc491d3b02. The refresh cleanly incorporates current target d2667baf6bdb8664821b4bed7a7f5a1df65f9f49; its additional delta is limited to release metadata and locales. Local focused verification, Cloud production build, the zero-retry target-native replay, and all 90 current hosted checks pass. The target-aware merge guard confirms the current target is an ancestor, test receipts postdate it, and there are no unresolved review threads or later reviewer objections.

This is an honest author COMMENT review under the published Agent 1.54 backport grant, not an independent approval or a waiver of checks.

@christian-byrne
christian-byrne merged commit 954b284 into cloud/1.54 Sep 20, 2026
94 checks passed
@christian-byrne
christian-byrne deleted the catalogue-sweep2-cloud-1.54-20260920 branch September 20, 2026 17:06

@dante01yoon dante01yoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as a backport: does every change match its original, and did anything main-only slip in. Mostly yes, with one production divergence I could not attribute to any named source.

File attribution is clean. I pulled the file lists of all seventeen sources and compared them to this PR's 89 files: every file here is attributable to a named source, with zero strays. All seventeen are merged to main. Seven source files are deliberately not carried (the Load3D pair, agentConversationFixture.ts, agentFollowerHostSocket.ts, agentConversationReplay.spec.ts, agentPastedNodeOrphanedOnRetarget.spec.ts, ecsFollowerAdapter.promptReconcile.test.ts), consistent with the declared harness adaptation.

Hunk fidelity. Comparing changed lines per src/ file against the owning source PRs: 52 of 65 are identical, including all of graphMutations.ts, agentNodeMaterializer.ts, ecsFollowerAdapter.ts, mintPortWiring.ts, opSender.ts, batchPlacement.ts, agentSubgraphDefinitions.ts, comfyWorkflow.ts, app.ts, assetUrlUtil.ts, assetDragUtil.ts, useAgentConsent.ts, useOnboarding.ts, agentPanelStore.ts and telemetry/types.ts. Ten of the thirteen differences are test files, i.e. the expected adaptation surface.

That leaves three production files differing. I checked each by diffing the final file content against main:

  • BaseWidget.ts — correct and declared. The backport carries 16936's bindRegisteredState(nodeId) verbatim minus the two getWidgetVisibility / _visibility lines. The release line has no widgetVisibility module at all, so dropping them is required, and this matches "adapts widget-state rebinding to the 1.54 store API without importing main's newer visibility architecture".
  • MediaAssetCard.vue — not a divergence. isVideoPlaying / showVideoControls and their MediaAssetKey provides are already on the cloud/1.54 base tip d2667ba; the backport preserved pre-existing release code while applying 18096/18111/18174.
  • liveWidgetProjection.ts — see the inline comment. One added guard I cannot trace to 16936 or 18070.

Type-contract rule. No hand-declared server/API response types. Every type added in this diff is an internal FE domain type (PlacementRect, SemanticPlacementPort, LiveWidgetProjectionResult, harness types), NodeColors/NodeDisplayFlags are Pick<NodeState, ...> rather than redeclarations, and GraphOperation stays derived from the pinned package's own op union. agentConversationFixture.ts continues to import WorkflowListResponse from @comfyorg/ingest-types.

One issue: below.

try {
setWidgetValue(widgetStore, node, widget, value, context)
widget.callback?.(value, canvas, node)
if (!Object.is(value, previousValue)) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: this guard is not in either source and is not in the declared adaptation list, and it changes shipped behaviour on the release line relative to main.

Both sources emit the notification unconditionally. 16936 adds the line as:

node.onWidgetChanged?.(name, value, previousValue, widget)

and 18070's hunk at this exact location changes only the line above it (widget.callback?.(value) → widget.callback?.(value, canvas, node)), carrying onWidgetChanged through untouched as context. Neither introduces an Object.is check. Diffing the final file against main confirms main still calls it unguarded.

Concretely: on cloud/1.54, an agent/remote widget write whose value equals the widget's current value stops invoking LGraphNode.onWidgetChanged; on main it still fires. Any node implementation or extension using onWidgetChanged as a "this widget was written" hook rather than strictly "the value changed" — re-running dependent logic, refreshing a preview, marking dirty — silently stops reacting to agent re-asserts on this release line only. A same-value remote write is not hypothetical here: that is exactly the resync shape the follower sees when the host re-publishes state after a catch-up.

It is clearly deliberate rather than an accident — the backport also adds a test pinning it (liveWidgetProjection.test.ts, 'does not emit a node change when replaying the current value', asserting expect(node.onWidgetChanged).not.toHaveBeenCalled()), and that test exists in neither 16936 nor 18070. But a deliberate behaviour change authored in a backport is the thing a backport review is meant to surface, and the Review focus section describes the 18070 adaptation only as "runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary", which does not cover suppressing the notification.

Could you say what the release line needs this for? If it is load-bearing — e.g. the 1.54 onWidgetChanged implementations loop on a no-op write in a way main's do not — it would be worth calling out explicitly in the adaptation list, since the divergence will also collide the next time main merges into this branch (or be silently reverted by it). If it is not load-bearing, dropping the guard and the accompanying test would keep the two lines behaviourally identical, which is the usual goal for a carried fix.

comfy-pr-bot pushed a commit that referenced this pull request Sep 23, 2026
#18622)

## Summary

Backports the Agent UI changes that staging and prod are missing to
`cloud/1.54`, as one cherry-pick catalogue: the folded trace, the shared
design system and buttons for the Agent controls, the consent card
redesign, and the moved Agent button with the nested panel. Staging
picks it up with the next `cloud/1.54` deploy; prod gets it at the next
production promotion of `cloud/1.54`.

Linear:
[PM-1657](https://linear.app/comfyorg/issue/PM-1657/test-stagingprod-missing-the-tool-call-always-expose-thinking-then),
[PM-1656](https://linear.app/comfyorg/issue/PM-1656)

## Changes

- **What**: `cherry-pick -x` of 8 merged `main` PRs, in `main` merge
order:
  - #17339 fold the finished trace into one summary
  - #17908 consent card video and stacked card layout
  - #17420 animate a step as it arrives (follow-up to #17339)
  - #18348 remove the workflow timing display (follow-up to #17339)
  - #18043 make the agent button legible in the light theme
- #17621 agent button at the far right, nested panel, without its two
`src/lib/litegraph/` files (see Review Focus)
  - #17471 replace the Agent shadow theme with the shared design system
  - #17690 use shared buttons across Agent controls
- **Already on `cloud/1.54`** from the same request, so not repeated
here: #17439 (via #18162), #17912 (via #18185), #17730 (via #18550).
- **Breaking**: none.
- **Dependencies**: none. `package.json` and the lockfile are unchanged
apart from the merged 1.54.15 bump (#18569).

## Review Focus

- #17621 changes shared chrome outside the Agent panel (top bar,
workflow tabs, side toolbar, breadcrumb, canvas splitter, LinearView),
so every user sees the new layout. #17471 changes the shared tooltip.
- #17621's two `src/lib/litegraph/` files are held out (agent fixes keep
litegraph unchanged); a 5 px HUD offset in `SideToolbar.vue`
compensates. Carrying them instead is a one-file follow-up if preferred.
- #18351 and #18367 are superseded by main's trace renderer, which this
brings in.
- Hosted checks are green on the head: 86 passed, 0 failed. Per-source
resolutions and the full verification log are in the details below.

<details><summary>Resolution and verification, per source</summary>

### Resolution

- `b5401705d8` drops a duplicate `useI18n` declaration left by the
#17339 pick.
- The merge of the `cloud/1.54` tip keeps main's `AgentMessage.vue` and
its test, which supersede #18351 and #18367: the working spinner after
tools is #17339's composing row, covered by `AgentMessage.test.ts`
"marks the turn as still working between the last tool and the first
reply token", and the thinking text uses the trace's `text-sm/5`.
- #17621: 8 release-line browser files switch from `askComfyAgent` to
`entryButton`, since #17621 removes that label; its GraphCanvas dock
tests set linear mode after mount on this line's test setup.
- `101c8f19cd` (test-only): three agent browser tests move off the
removed "Ran N tool calls" button to main's WorkSummary locators.
- `09236f342d` (test-only): `exact: true` on the autogrow spec's two
entry-button lookups, as on main, since "Agent" now also prefixes the
targeted workflow tab's button name.
- `d49b4ddf12` (runtime): `SideToolbar.vue` places the canvas info HUD
at `sidebarRight + canvasGutter() - 5`. The release line's `renderInfo`
keeps a 5 px text inset that main removed in #17621's litegraph half, so
this offset lands the HUD where main puts it. It goes away when that
litegraph change reaches the line.
- #17471: 12 conflicts resolved toward main. `ab65e60731` (runtime)
takes main's final `RunModePopover.vue` as is: main's end state is the
DropdownMenu form from #18115, which this line carries via #18265, and
the remaining diff was styling only. `55e005ed10` (runtime) maps the
last 2 shadow-theme tokens in `CrdtDevPanel`. 38 of 42 files carry the
source's exact change stream.
- #17690: 1 conflict resolved toward main; 17 of 18 files carry the
source's exact change stream.
- The `cloud/1.54` tip was merged in twice; the second merge brings the
1.54.15 bump (#18569) with no other change.

### Verification

- Hosted checks on the head: 86 passed, 0 failed (e2e run 35907168615:
16 chromium shards, cloud, 0.5x, 2x, mobile-chrome, mobile-safari,
video).
- `git diff --name-only origin/cloud/1.54...HEAD --
':/src/lib/litegraph/'` prints nothing.
- Local at the head: `pnpm typecheck` and `pnpm typecheck:browser` exit
0; 41 unit suites, 563 tests pass; 0 shadow-theme tokens and 0
`AgentTooltip` references remain.
- #17908: `agentConsent.spec.ts` passes 14 of 14 with the change and
fails 5 of 14 without it (local run, devtools setup endpoints stubbed).
- Per-source parity: every difference from the source change streams is
listed under Resolution.
- Staging acceptance after landing: the trace fold, the design system
and buttons in light and dark, the nested panel and moved button, the
consent card, plus the onboarding tour, consent without a click and the
graph activity bar as regressions. Prod needs a production promotion of
`cloud/1.54` after that.

</details>

## Screenshots (if applicable)

Visual changes are the ones already reviewed on `main` in #17471,
#17690, #17621 and #17908; the e2e screenshot baselines in this PR come
from those merges.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: uytieu <uytieu@users.noreply.github.com>
Co-authored-by: ryan-di <ryan.weihao.di@gmail.com>
Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-attachments Agent asset uploads, attachments or media references agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-docs Agent product architecture, contracts or documentation agent-onboarding Agent consent, first-use tour or onboarding gates agent-session Agent sessions, history, turn lifecycle or workflow binding agent-telemetry Agent analytics, diagnostics, error reporting or observability agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-attachments Agent asset uploads, attachments or media references agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-docs Agent product architecture, contracts or documentation agent-onboarding Agent consent, first-use tour or onboarding gates agent-session Agent sessions, history, turn lifecycle or workflow binding agent-telemetry Agent analytics, diagnostics, error reporting or observability agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants