Repository navigation
fix: play agent-generated video assets in the Media Assets panel - #18091
claude[bot] wants to merge 2 commits into
Conversation
…/playback/metadata bugs Adds two test.fail() Playwright specs that reproduce the reported bug in the Comfy Agent / cloud media panel: a generated video asset with no thumbnail_url/preview_url renders a black tile with an unplayable <video> (MediaAssetCard.vue's src fallback has no case for video, unlike the '3D' kind), and dragging such an asset onto the canvas attaches no workflow metadata to the resulting node. Both tests mock the /api/assets network boundary the same way the existing "Assets sidebar - cloud exports" tests in assets.spec.ts do, and are expected to start passing once the bug is fixed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UP49A8QXF7zN5cYmUqsAx4
MediaAssetCard's src fallback (thumbnail_url || preview_url || '') left video/audio assets with an empty <video>/<audio> src whenever the backend had not populated a preview - which it never does for agent/cloud-generated video or audio outputs. The result was a black, unplayable tile. Mirror the existing '3D' fallback: when no server preview exists for a video or audio asset, point the element at the asset's own real content URL via getAssetFileUrl(), now with an explicit disposition=inline query param so the assets-API content endpoint serves it for in-page playback instead of forcing a download (its default is Content-Disposition: attachment). Existing callers of getAssetFileUrl() (downloads, the 3D viewer) are unaffected since the new disposition option defaults to unset. Video is unmounted while off-screen (VirtualGrid) and already loads with preload="metadata", so this does not turn the grid into an eager full-file video downloader. Flips the corresponding e2e assertion in agentVideoAsset.spec.ts from test.fail() to a passing assertion; the drag-to-canvas workflow-metadata test is left as test.fail() (separate, likely upstream/backend gap). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UP49A8QXF7zN5cYmUqsAx4
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2039 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.92 MB gzip 🔴 +109 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • 🔴 +558 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 73 added / 73 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T03:14:29.395Z",
"gitSha": "a765054cd378c90e6cc4607185010a53e657e699",
"branch": "test/agent-video-asset-thumbnail-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1997.2740000000044,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.147999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.141,
"heapDeltaBytes": 10035080,
"heapUsedBytes": 70898584,
"domNodes": -263,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.502000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2007.776999999976,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.9399999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.40700000000004,
"heapDeltaBytes": 1253600,
"heapUsedBytes": 63301336,
"domNodes": -263,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.973000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1996.7079999999555,
"styleRecalcs": 78,
"styleRecalcDurationMs": 32.536,
"layouts": 14,
"layoutDurationMs": 5.0889999999999995,
"taskDurationMs": 961.497,
"heapDeltaBytes": 16173440,
"heapUsedBytes": 77392024,
"domNodes": -267,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 167.43999999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1794.5920000000228,
"styleRecalcs": 75,
"styleRecalcDurationMs": 27.727999999999998,
"layouts": 14,
"layoutDurationMs": 4.933,
"taskDurationMs": 844.9099999999999,
"heapDeltaBytes": 13071784,
"heapUsedBytes": 80071284,
"domNodes": -259,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 148.26399999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1736.7780000000153,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.909000000000002,
"layouts": 6,
"layoutDurationMs": 1.4610000000000003,
"taskDurationMs": 286.678,
"heapDeltaBytes": 2009252,
"heapUsedBytes": 62809772,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 12.174999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.5109999999977,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.138000000000002,
"layouts": 6,
"layoutDurationMs": 1.452,
"taskDurationMs": 340.494,
"heapDeltaBytes": 2173536,
"heapUsedBytes": 64186284,
"domNodes": 74,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.638000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 663.9279999999985,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.459,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.06,
"heapDeltaBytes": 17914912,
"heapUsedBytes": 80371520,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 153.507,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 651.6659999999774,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.820000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.10499999999996,
"heapDeltaBytes": 17975148,
"heapUsedBytes": 79961400,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 154.599,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2027.2219999999948,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.636999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.3009999999999,
"heapDeltaBytes": 4034552,
"heapUsedBytes": 83237540,
"domNodes": -248,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 33.107,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2042.1420000000126,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.761999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.951,
"heapDeltaBytes": 3190452,
"heapUsedBytes": 83271592,
"domNodes": -249,
"jsHeapTotalBytes": -1056768,
"scriptDurationMs": 35.455,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2303.4920000000056,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.023999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1642.9070000000002,
"heapDeltaBytes": 18827352,
"heapUsedBytes": 83121652,
"domNodes": -253,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 824.3269999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2318.0869999999913,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.135000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1636.965,
"heapDeltaBytes": -5783812,
"heapUsedBytes": 74755756,
"domNodes": -254,
"jsHeapTotalBytes": 1003520,
"scriptDurationMs": 808.2819999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3498.108000000002,
"styleRecalcs": 62,
"styleRecalcDurationMs": 12.222000000000003,
"layouts": 60,
"layoutDurationMs": 13.056,
"taskDurationMs": 1554.459,
"heapDeltaBytes": -6886444,
"heapUsedBytes": 74214148,
"domNodes": -257,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 759.7199999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3598.510000000033,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.767999999999997,
"layouts": 60,
"layoutDurationMs": 13.233000000000002,
"taskDurationMs": 1654.3360000000002,
"heapDeltaBytes": 8069560,
"heapUsedBytes": 74265088,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 762.694,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3103.613999999993,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.997000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1935.731,
"heapDeltaBytes": 19372280,
"heapUsedBytes": 85626608,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 960.3460000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3121.226999999976,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.463999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1811.2689999999998,
"heapDeltaBytes": 21675844,
"heapUsedBytes": 89381628,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1031.5510000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2064.817000000005,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.660999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.676,
"heapDeltaBytes": -3418204,
"heapUsedBytes": 83717560,
"domNodes": -249,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.572,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2061.423999999988,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.415999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.8359999999999,
"heapDeltaBytes": -7140548,
"heapUsedBytes": 80342348,
"domNodes": -253,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 32.37799999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.2949999999732,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.636000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.75800000000004,
"heapDeltaBytes": 13479312,
"heapUsedBytes": 76799112,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.47,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.431000000076,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.659,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.70799999999997,
"heapDeltaBytes": 13851976,
"heapUsedBytes": 76644960,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 139.623,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.1799999999917,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.47400000000005,
"heapDeltaBytes": 17557580,
"heapUsedBytes": 80537072,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.059999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2003.2679999999914,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.8770000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.29200000000003,
"heapDeltaBytes": -2757228,
"heapUsedBytes": 60576304,
"domNodes": -272,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.136000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.8619999999914,
"styleRecalcs": 78,
"styleRecalcDurationMs": 25.764999999999997,
"layouts": 18,
"layoutDurationMs": 5.357,
"taskDurationMs": 805.5550000000001,
"heapDeltaBytes": 1112064,
"heapUsedBytes": 64242488,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 99.473,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.126999999948,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.019,
"layouts": 18,
"layoutDurationMs": 4.955,
"taskDurationMs": 801.5129999999999,
"heapDeltaBytes": 12986004,
"heapUsedBytes": 76220600,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 98.49000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1367.543000000012,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.766000000000005,
"layouts": 5,
"layoutDurationMs": 11.300999999999998,
"taskDurationMs": 890.5959999999999,
"heapDeltaBytes": 20124140,
"heapUsedBytes": 102510588,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.803000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 130,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8585.966999999982,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.683,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5832.84,
"heapDeltaBytes": -4552916,
"heapUsedBytes": 74129040,
"domNodes": -254,
"jsHeapTotalBytes": 1757184,
"scriptDurationMs": 2692.7059999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8422.961999999985,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.309,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5822.469,
"heapDeltaBytes": -14338268,
"heapUsedBytes": 65768012,
"domNodes": -248,
"jsHeapTotalBytes": 3661824,
"scriptDurationMs": 2730.2500000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 15074.315000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14700.379,
"heapDeltaBytes": -61027196,
"heapUsedBytes": 169747204,
"domNodes": -8061,
"jsHeapTotalBytes": -9756672,
"scriptDurationMs": 226.985,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14864.429999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14592.173999999999,
"heapDeltaBytes": -32612932,
"heapUsedBytes": 181331556,
"domNodes": -8061,
"jsHeapTotalBytes": -11964416,
"scriptDurationMs": 225.69500000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 17959.962000000018,
"styleRecalcs": 133,
"styleRecalcDurationMs": 15.916999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17825.708,
"heapDeltaBytes": -43151032,
"heapUsedBytes": 187292396,
"domNodes": -8061,
"jsHeapTotalBytes": -10612736,
"scriptDurationMs": 842.062,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18167.715999999928,
"styleRecalcs": 128,
"styleRecalcDurationMs": 15.646999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18002.027000000002,
"heapDeltaBytes": -63955544,
"heapUsedBytes": 166921932,
"domNodes": -8061,
"jsHeapTotalBytes": -10543104,
"scriptDurationMs": 831.503,
"eventListeners": -14928,
"totalBlockingTimeMs": 38,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 5458.315000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.00499999999998,
"layouts": 20,
"layoutDurationMs": 24.125000000000007,
"taskDurationMs": 5423.22,
"heapDeltaBytes": -28457820,
"heapUsedBytes": 201578664,
"domNodes": -8061,
"jsHeapTotalBytes": 16982016,
"scriptDurationMs": 98.85600000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 264,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5422.5249999999505,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.36300000000001,
"layouts": 20,
"layoutDurationMs": 23.857000000000003,
"taskDurationMs": 5366.7429999999995,
"heapDeltaBytes": -48906552,
"heapUsedBytes": 181137952,
"domNodes": -8061,
"jsHeapTotalBytes": 18030592,
"scriptDurationMs": 99.958,
"eventListeners": -14928,
"totalBlockingTimeMs": 234,
"frameDurationMs": 17.773333333333298,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5533.02599999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5333.848,
"heapDeltaBytes": -24835904,
"heapUsedBytes": 167534752,
"domNodes": 0,
"jsHeapTotalBytes": -7077888,
"scriptDurationMs": 95.051,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7558.665000000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7395.6269999999995,
"heapDeltaBytes": -2260828,
"heapUsedBytes": 183078120,
"domNodes": 0,
"jsHeapTotalBytes": -26214400,
"scriptDurationMs": 113.45300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 495.9870000000137,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.333000000000002,
"layouts": 6,
"layoutDurationMs": 2.9459999999999997,
"taskDurationMs": 151.688,
"heapDeltaBytes": 5308336,
"heapUsedBytes": 66474000,
"domNodes": 149,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 16.23,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 452.5730000000294,
"styleRecalcs": 15,
"styleRecalcDurationMs": 20.441000000000003,
"layouts": 3,
"layoutDurationMs": 1.0410000000000001,
"taskDurationMs": 109.574,
"heapDeltaBytes": 4737868,
"heapUsedBytes": 66407604,
"domNodes": 123,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.961,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
|
Superseded by #18096 — this PR's two commits carried Closing this PR. The leftover branch |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18091 +/- ##
==========================================
+ Coverage 82.77% 83.80% +1.02%
==========================================
Files 2936 2242 -694
Lines 144482 127642 -16840
Branches 39021 34345 -4676
==========================================
- Hits 119593 106967 -12626
+ Misses 23632 20385 -3247
+ Partials 1257 290 -967
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 694 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Requested by Christian Byrne · Slack thread
Summary
Video assets generated through the Comfy Agent / cloud path show up as an unplayable black tile in the Media Assets panel, because the backend never populates
thumbnail_url/preview_urlfor video (only for images) andMediaAssetCard.vuehad no fallback for that case (unlike the3Dkind, which already falls back to a real content URL). Separately, dragging such a video onto the canvas drops its workflow metadata.Two
test.fail()Playwright specs (browser_tests/tests/sidebar/agentVideoAsset.spec.ts) reproduce both symptoms by mocking/api/assetsthe same way the existing cloud-exports tests do.Changes
What (shipped fix, symptom 1 — black tile / unplayable video):
MediaAssetCard.vue'ssrcfallback now points video/audio assets at their real content URL (getAssetFileUrl()) when the backend has left both preview fields empty, mirroring the existing3Dpattern.getAssetFileUrl()gained an optional{ disposition: 'inline' }option, since the assets-API content endpoint (/api/assets/{id}/content) defaults toContent-Disposition: attachmentand would otherwise make the browser try to download the file instead of playing it. Existing callers (downloads, the 3D viewer) are unaffected — the option defaults to unset/attachment.VirtualGrid) and the<video>already usespreload="metadata", so this doesn't turn the panel into an eager full-file video downloader. Audio gets the same fallback since the backend gap is the same; its waveform player already fully downloads audio for any asset with a real preview URL today, so this isn't a new class of cost.test.fail()to a plain passing assertion.assetUrlUtil.test.ts(the newdispositionoption) and a component-level Vitest inMediaAssetCard.test.tsasserting the rendered<video>gets a real, non-empty, inline-dispositionsrcwhen no server preview exists.pnpm lint,pnpm typecheck, and the fullsrc/platform/assetsVitest suite all pass. I could not run the actual Playwright spec in this sandbox (no Chromium binary, no backend) — that assertion is unverified end-to-end, only at the unit/component level.What (plan, symptom 2 — drag-to-canvas metadata loss): Not fixed here; kept as
test.fail(). The frontend's drag-and-drop metadata parser (src/scripts/metadata/parser.ts+isobmff.ts) already parses MP4/MOV via ISOBMFF just as well as PNG, so the likely gap is upstream: the video-generation pipeline (ComfyUI-core or a custom node, not this repo) never embeds a workflow-metadata box into its video output in the first place. Recommendation: confirm with whoever owns the video-generation/custom-node source, since no frontend-only fix is available.Review Focus
disposition: 'inline'is the right long-term contract for "give me a URL safe to embed as<video>/<audio>src" vs. adding a more explicit "playable" helper.Notes
test/pm-1342-video-asset-repro, which had "PM-1342" (an internal Linear ticket ID) baked into the branch name, commit message, and test file — not allowed in this public repo. That branch is left in place, unused, for whoever wants to delete it.🤖 Generated with Claude Code
https://claude.ai/code/session_01UP49A8QXF7zN5cYmUqsAx4
Generated by Claude Code