Repository navigation
[backport core/1.54] Agent catalogue sweep 2 - #18186
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1933 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T13:51:29.961Z",
"gitSha": "c96945dff57c7c86df6b2d99c2b63208c0a69772",
"branch": "catalogue-sweep2-core-1.54-20260920",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2051.368000000025,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.6149999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.66800000000006,
"heapDeltaBytes": 8473864,
"heapUsedBytes": 78255960,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.157999999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2041.0750000000348,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.845,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.648,
"heapDeltaBytes": -7217500,
"heapUsedBytes": 62583432,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.691000000000003,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2002.320999999995,
"styleRecalcs": 79,
"styleRecalcDurationMs": 32.785,
"layouts": 14,
"layoutDurationMs": 4.441000000000001,
"taskDurationMs": 978.694,
"heapDeltaBytes": -12726204,
"heapUsedBytes": 57904112,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 175.45100000000002,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1891.6600000000017,
"styleRecalcs": 79,
"styleRecalcDurationMs": 30.773999999999997,
"layouts": 14,
"layoutDurationMs": 4.511,
"taskDurationMs": 890.735,
"heapDeltaBytes": -5068624,
"heapUsedBytes": 64701936,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 163.96,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.1410000000265,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.654000000000003,
"layouts": 6,
"layoutDurationMs": 0.9479999999999998,
"taskDurationMs": 358.73,
"heapDeltaBytes": 4269724,
"heapUsedBytes": 73243836,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.918000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.9839999998967,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.747,
"layouts": 6,
"layoutDurationMs": 1.1369999999999998,
"taskDurationMs": 347.347,
"heapDeltaBytes": 4628616,
"heapUsedBytes": 75379368,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.574999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 645.3759999999988,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.611999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.058,
"heapDeltaBytes": 18746084,
"heapUsedBytes": 88595380,
"domNodes": 20,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 156.09699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 625.4769999999894,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.231000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 452.43500000000006,
"heapDeltaBytes": 18119740,
"heapUsedBytes": 88170400,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 158.53499999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.584999999984,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.665,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.5800000000002,
"heapDeltaBytes": 10234896,
"heapUsedBytes": 86562608,
"domNodes": -267,
"jsHeapTotalBytes": -2203648,
"scriptDurationMs": 39.189,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2027.400000000057,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.5179999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.437,
"heapDeltaBytes": -15232508,
"heapUsedBytes": 87763212,
"domNodes": -271,
"jsHeapTotalBytes": -1642496,
"scriptDurationMs": 29.782000000000004,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2423.320999999987,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.779000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1664.499,
"heapDeltaBytes": 21819368,
"heapUsedBytes": 88621660,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 841.8050000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2387.297999999987,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.019000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1727.409,
"heapDeltaBytes": -1010768,
"heapUsedBytes": 75562888,
"domNodes": -284,
"jsHeapTotalBytes": 1429504,
"scriptDurationMs": 835.28,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3602.2159999999985,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.456000000000003,
"layouts": 60,
"layoutDurationMs": 11.699000000000002,
"taskDurationMs": 1717.659,
"heapDeltaBytes": 11772916,
"heapUsedBytes": 79768212,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 785.507,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3575.036999999952,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.670999999999996,
"layouts": 60,
"layoutDurationMs": 11.532,
"taskDurationMs": 1706.874,
"heapDeltaBytes": 8083384,
"heapUsedBytes": 75929264,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 774.409,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3105.391999999995,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.8130000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1945.208,
"heapDeltaBytes": 26420560,
"heapUsedBytes": 93981668,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 970.292,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3142.6839999999174,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.7650000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1900.1200000000003,
"heapDeltaBytes": 22156916,
"heapUsedBytes": 90343132,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 957.2839999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2066.951999999958,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.882999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 621.3519999999999,
"heapDeltaBytes": 8778904,
"heapUsedBytes": 86375856,
"domNodes": -274,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 34.09200000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2014.6720000000187,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.8639999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.682,
"heapDeltaBytes": 21799024,
"heapUsedBytes": 88108324,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.445,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.7460000000242,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.603,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.3450000000001,
"heapDeltaBytes": 15002668,
"heapUsedBytes": 87668604,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.096,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.4889999999341,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.191000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 399.049,
"heapDeltaBytes": 15002348,
"heapUsedBytes": 87668880,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.432,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.3520000000121,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.143000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.402,
"heapDeltaBytes": 8468768,
"heapUsedBytes": 81624996,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.074000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.4900000000284,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.58,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.953,
"heapDeltaBytes": -12795844,
"heapUsedBytes": 60170384,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 7.7330000000000005,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.2490000000098,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.994000000000003,
"layouts": 18,
"layoutDurationMs": 4.837999999999999,
"taskDurationMs": 823.2700000000001,
"heapDeltaBytes": 2693696,
"heapUsedBytes": 76183164,
"domNodes": -314,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 109.40599999999999,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1733.7310000000343,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.958000000000002,
"layouts": 18,
"layoutDurationMs": 4.724,
"taskDurationMs": 816.279,
"heapDeltaBytes": -7493880,
"heapUsedBytes": 64801820,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 108.932,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.6079999999906,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.755999999999993,
"layouts": 15,
"layoutDurationMs": 15.383999999999999,
"taskDurationMs": 957.2320000000001,
"heapDeltaBytes": -5147772,
"heapUsedBytes": 85466676,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 30.096999999999998,
"eventListeners": 2385,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8538.40600000001,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.553,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5859.239,
"heapDeltaBytes": 12846280,
"heapUsedBytes": 89186808,
"domNodes": -270,
"jsHeapTotalBytes": -929792,
"scriptDurationMs": 2688.8099999999995,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8671.829000000002,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.597,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5940.269,
"heapDeltaBytes": 8970364,
"heapUsedBytes": 85157452,
"domNodes": -270,
"jsHeapTotalBytes": -1454080,
"scriptDurationMs": 2763.967,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17132.735999999964,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16675.197,
"heapDeltaBytes": -52019068,
"heapUsedBytes": 181487824,
"domNodes": -8068,
"jsHeapTotalBytes": -13524992,
"scriptDurationMs": 329.86099999999993,
"eventListeners": -14929,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17330.351000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16793.197,
"heapDeltaBytes": -39649884,
"heapUsedBytes": 178534640,
"domNodes": -8068,
"jsHeapTotalBytes": -10256384,
"scriptDurationMs": 278.092,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21191.54100000003,
"styleRecalcs": 166,
"styleRecalcDurationMs": 17.28000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20819.198,
"heapDeltaBytes": -46326024,
"heapUsedBytes": 178772992,
"domNodes": -8068,
"jsHeapTotalBytes": -19095552,
"scriptDurationMs": 903.344,
"eventListeners": -14927,
"totalBlockingTimeMs": 190,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20957.753000000026,
"styleRecalcs": 167,
"styleRecalcDurationMs": 17.82800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20556.391,
"heapDeltaBytes": -39325956,
"heapUsedBytes": 178842356,
"domNodes": -8068,
"jsHeapTotalBytes": -10543104,
"scriptDurationMs": 938.7900000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 66,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6230.500000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.50300000000006,
"layouts": 20,
"layoutDurationMs": 24.310999999999986,
"taskDurationMs": 6101.456999999999,
"heapDeltaBytes": -36918624,
"heapUsedBytes": 181565884,
"domNodes": -8068,
"jsHeapTotalBytes": 16510976,
"scriptDurationMs": 112.48200000000001,
"eventListeners": -14927,
"totalBlockingTimeMs": 415,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6256.469999999922,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.64500000000002,
"layouts": 20,
"layoutDurationMs": 23.638000000000005,
"taskDurationMs": 6130.764,
"heapDeltaBytes": -35743076,
"heapUsedBytes": 181216528,
"domNodes": -8068,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 111.522,
"eventListeners": -14929,
"totalBlockingTimeMs": 451,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8649.491000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8441.721,
"heapDeltaBytes": 1682656,
"heapUsedBytes": 178943128,
"domNodes": 0,
"jsHeapTotalBytes": -21233664,
"scriptDurationMs": 144.67699999999994,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8624.122999999941,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8399.896999999999,
"heapDeltaBytes": 7945556,
"heapUsedBytes": 178441768,
"domNodes": 0,
"jsHeapTotalBytes": -7864320,
"scriptDurationMs": 141.625,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 460.23499999995465,
"styleRecalcs": 15,
"styleRecalcDurationMs": 24.767,
"layouts": 4,
"layoutDurationMs": 1.6450000000000002,
"taskDurationMs": 116.19900000000001,
"heapDeltaBytes": 4803208,
"heapUsedBytes": 73924628,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.036,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 105.77499999999418,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.257,
"layouts": 2,
"layoutDurationMs": 1.3269999999999997,
"taskDurationMs": 68.78700000000002,
"heapDeltaBytes": 2994596,
"heapUsedBytes": 71623924,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.860999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.54 #18186 +/- ##
=============================================
+ Coverage 83.49% 83.52% +0.03%
=============================================
Files 2090 2094 +4
Lines 123015 123380 +365
Branches 33146 31385 -1761
=============================================
+ Hits 102712 103057 +345
- Misses 20123 20144 +21
+ Partials 180 179 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
New users now see the agent consent card on first load, and the agent tour appears for each workspace they join. - **What**: - A first-time user sees the consent card as soon as the app loads. Before, the card appeared only after a click on "Ask Comfy Agent". - The button still opens the card, as before. - The card is offered one time for each account and workspace. It does not return on every load. - A user who already accepted sees nothing new. - When the user accepts, the agent panel opens. This is what the button already does. - The short agent tour now counts per account and workspace, in the same way as the consent card. A user who joins a new workspace gets the tour there. - A user who already finished the tour does not see it again in the workspace they are in now. - The card waits for the saved answer to arrive. A user who already accepted never sees a flash of the card. - If the saved answer cannot be read, the card is not offered, and the one offer is kept for the next load. - The record of the offer is written before the card opens. PM-1187 reports that the tour returns on every agent use. This order prevents that result here. - The tour used one record for the whole device, while consent uses one record for each account and workspace. A user who joined a new workspace therefore saw the card again but got no guidance. The two records now use the same scope. - An old device-wide tour record moves to the workspace the user is in now, and then it is removed. Nobody who finished the tour sees it a second time. - The offer counts per account and workspace, not per version. There is no record of which agent version a user has seen. Question 3 in PM-1276 is still open. - Sign-in does not start on its own. The offer needs a signed-in user, so a signed-out user is not interrupted. <!-- Add a recording of a first load with an account that has not accepted --> [PM-1276](https://linear.app/comfyorg/issue/PM-1276/show-the-agent-consent-card-on-first-load-not-only-on-button-click) · [PM-514](https://linear.app/comfyorg/issue/PM-514/agent-opt-in-consent-card-on-both-local-and-cloud) https://github.com/user-attachments/assets/a10de566-80d0-4e96-8883-c70b196699e5 --------- Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com> (cherry picked from commit 7ca9c6a)
… tab-switch reconcile (#18081) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789709391046969?thread_ts=1789709391.046969&cid=C0BGH348Z0C)_ Fixes an autogrow-node color and input label loss on tab switch: a CRDT reconcile in `graphMutations.ts` now merges onto the live node's state instead of wholesale-replacing it, so client-only presentation fields the CRDT document never carries survive a tab-switch reconcile. Includes the Playwright repro that pins the exact symptom (originally added as `test.fail()`, now passing as a normal `test()`) plus new unit coverage of the merge behavior. - **What**: Before this PR, a node with an autogrow input group (e.g. GPT Image 2.5's `model.images.image_N` slots) lost its API-node color and showed the raw internal dotted input name after the in-app agent wired something into it and the tab was switched away and back — a CRDT reconcile in `nodeDataStore.ts`'s `assignNodeFields` (via `updateNode`) unconditionally reset `color`/`bgcolor` and replaced `state.inputs` wholesale from a CRDT payload that never carries either. **This PR fixes that** in `src/workbench/extensions/agent/crdt/graphMutations.ts`: `resolveNodeColors` keeps the live node's `color`/`bgcolor`/`boxcolor` when the payload omits them, and `preserveSlotDisplayMetadata` (used by the new `prepareInputSlot`) keeps an existing input slot's `localized_name`/`label` when the payload's slot at the same index and name doesn't carry one — while still applying an explicit value the payload does set, and not carrying stale labels onto a genuinely different input at the same slot index. - **Tests**: `browser_tests/tests/agent/agentAutogrowTabSwitchReconcile.spec.ts` sets up the exact repro scenario (a wired autogrow node materialized via the CRDT graph-mutation layer), confirms the node renders correctly before the tab switch, switches to a new tab and back to force the CRDT follower's tab-switch reconcile (`useAgentCrdtFollower.ts`), and asserts the color and label are still correct afterward. This started as a `test.fail()` pinning the bug; with the fix in place it now passes as a normal `test()`. `graphMutations.test.ts` adds two unit-level regression guards for the same merge behavior (color/label preserved on an omitted-field reconcile; not stale when the payload does supply new values). - **Root cause / blast radius**: per the RCA in the spec file's header comment, this reconcile path (`prepareNode`/`prepareInputSlots`) is shared across every `reconcileNode` call, so the fix likely also addresses other reports of the same class of client-only-field loss on CRDT reconcile, not just the tab-switch trigger covered here. - **Breaking**: none - **Dependencies**: none - The merge logic in `graphMutations.ts` (`resolveNodeColors`, `preserveSlotDisplayMetadata`/`prepareInputSlot`): confirm it only fills in fields the payload omits and never masks a value the payload does set (see the second new unit test in `graphMutations.test.ts` for that guard). - The fix lives in the shared `prepareNode`/`prepareInputSlots` reconcile path, so it likely also resolves other reports of the same class of bug beyond the tab-switch trigger covered here. - Confirmed locally: the Playwright repro spec passes, and the new `graphMutations.test.ts` unit tests pass. <!-- Fixes #ISSUE_NUMBER --> N/A (non-visual regression test) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Mj4zDEXP8JxWeNcX24RGGw --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit 9f78312)
Carry the minimal document-host fixture used by the regression spec and adapt release-line fixture and locale APIs without changing the production fix.
Use the release-local activity row for the socket reconnect coverage, preserve the server object-info route for the autogrow case, and synchronize the carried ADR index metadata.
…w modes (#18183) Nothing exercised **a real drag from the assets panel into the composer**, in either view mode. #18174 (PM-1401, a list row that never started a drag) shipped proved by asserting the **canvas** consumer of the same drag payload — a real but indirect proxy, because it cannot catch a composer-side attach regression. That is the user-visible half of [PM-1402](https://linear.app/comfyorg/issue/PM-1402). **Scope note, corrected after a rebase.** When this branch was opened there was no composer-attachment browser coverage at all. #18104 has since landed `agentBatchOutputAttachment.spec.ts`, which does assert a composer attachment — but it **synthesizes** the `DataTransfer` in `page.evaluateHandle` and dispatches it, so it covers the drop/attach half against a fabricated payload and never exercises a drag source. The two are complements, not duplicates: that spec would still pass if every asset card and list row in the panel stopped publishing a payload, which is exactly the PM-1401 failure. This PR covers the source half, through a real `dragTo` from the panel, in both view modes. Verified together post-rebase: all four cases pass in one run. This is coverage plus the harness affordances it needed. No production behavior changes. - **What**: - `browser_tests/tests/agent/agentComposerAssetDrop.spec.ts` (new, `@cloud`): opens the agent panel and the assets sidebar, drags an asset onto the panel, and asserts a composer attachment chip naming that asset appears. Runs for **both** grid and list view. - `src/workbench/extensions/agent/.../AttachmentChip.vue`: adds `data-testid="agent-attachment-chip"` and `data-attachment-name`. Distinct from the existing `asset-reference-chip`, which is the inline `@`-reference chip rendered elsewhere in the composer, not the drop-attachment chip; `AttachmentChip` had no anchor of its own. The visible label truncates at `max-w-32`, so asserting on rendered text cannot distinguish two long filenames — precisely the wrong-asset failure worth catching. Two attributes, no behavior or style change. - `browser_tests/fixtures/components/AgentPanel.ts`: `attachmentChips` and `attachmentChip(name)`. - `browser_tests/fixtures/agentPanelFixture.ts`: `bootAgentApp` gains an `assets` option. The fixture hard-routed `/api/assets` to an empty list, so any asset-flow spec had to re-route after boot and lean on route-precedence order. The route is also narrowed to the list endpoint (`**/api/assets` and `**/api/assets?**`) so a spec can serve `/api/assets/<id>/content` for the file itself; the previous `**/api/assets**` swallowed it. - **The route narrowing is the one change with reach beyond this spec.** Previously `**/api/assets**` also absorbed content requests for every agent spec; now it does not. No current agent spec seeds assets, so none issues a content request, and the full agent suite passes — but it is the thing to push back on if you know of a spec depending on the broader swallow. - The assertion is `attachmentChip(ASSET_NAME)` plus a count of 1, not a bare "some chip appeared": a drag that attaches the wrong asset would pass the weaker form. - The drop target is `agentPanel.root` (`#agent-panel-root`), which is where `AgentPanelRoot` binds `@drop`. That is deliberately the whole panel, not the composer sub-element — relevant to [PM-1361](https://linear.app/comfyorg/issue/PM-1361)/[PM-1363](https://linear.app/comfyorg/issue/PM-1363), which are about widening the drop footprint. - **Sensitivity proven, not assumed.** With the list-view `draggable`/`dragstart` wiring removed from `AssetsSidebarListView.vue` and the dist rebuilt, the **list case fails** on the missing chip (`expect(locator).toBeVisible() failed — element(s) not found`) while the **grid case still passes** — the exact PM-1401 signature. Wiring restored and both pass again. - Both new cases pass against a cloud dist served by `ghcr.io/comfy-org/comfyui-ci-container:0.0.22`, `--project=cloud`. - Rebased onto `main` at `38cc119a21` and re-verified: this spec's two cases pass alongside `agentBatchOutputAttachment` and `agentUploadedImageAttachment`, 4/4 in one run, after `AgentPanelRoot.vue` changed underneath on main. - Full agent browser suite on the pre-rebase build: **78 passed, 1 failed**. The failure is `agentConversationReplay.spec.ts` `@screenshot` (24152 px, ratio 0.01). It fails **identically on clean `main`** with these changes stashed, so it is a local-vs-CI rendering difference, not this change. - `pnpm typecheck` clean; agent unit suite 110 files / 1689 passed, 3 expected-fail; lint-staged (oxfmt, oxlint, eslint, stylelint, typecheck, typecheck:browser) clean on commit. Workspace row: `qaf-78`. (cherry picked from commit b3b0579)
Adapt the source change to the release-local liveWidgetProjection path. The retired recorded-conversation harness coverage is omitted; focused projection and widget tests remain. (cherry picked from commit 77b7ef9)
Adapt the placement port to the release-line graph mutation and layout-store APIs. The retired prompt-reconcile test remains omitted. (cherry picked from commit 1319876)
Extend the release-local document host for template operations and seed client-only API-node colors before exercising the reconcile preservation contract.
Use the zoom controls toggle and assert the popup is hidden before selecting the node. The prior exact-head runs proved warning retention but were blocked before paste by the popup backdrop.
christian-byrne
left a comment
There was a problem hiding this comment.
Adaptation review: no blockers at the exact head.
- Core target ancestry and 95 terminal checks are green.
- Target-native lifecycle replay passed at this head.
- The published Agent 1.54 backport grant authorizes guarded admin merge.
Full context for agent readers
Reviewed 2bd4dace2e6207fede11d2ac219d691a811769dc against core/1.54 at a301780099551aa0084366eb564b6fa3bb2e5b67.
The seventeen mapped non-billing sources retain source provenance. Release adaptations stay within the 1.54 APIs: asset tests use the release feature-flag and locale setup; Agent browser fixtures use the release panel label, activity row, object-info route, and HostDoc contract; widget projection, placement, pasted-node propagation, incompatible-link retirement, and consent behavior remain covered without importing unrelated main architecture.
The complete target-native replay passed once with zero retries and verifies warning retention across tab return, node presentation, popup closure, follower re-subscription, pasted position locally and in HostDoc after retarget, incompatible-link retirement without host corruption, and a subsequent visible Agent edit. Receipt: https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case
The current target-aware guard reports 95 completed non-adverse checks, current Core ancestry, no unresolved review threads, and no later reviewer objection. This COMMENT is the honest author review permitted by the standing release-backport grant; it is not represented as independent human approval. Cloud PR 18185 is outside this verdict and remains blocked on its newer target tip.
…ore/1.54 The wholesale main-version swap in the previous commit assumed a WorkSummary.vue / ActivityTrace.vue split (distinct "Working..." vs "Worked for ..." UI states, driven by the `agent.working`/`agent.worked` i18n keys) that does not exist on core/1.54: this branch's tool-call UI is still ToolCallGroup.vue, which renders a single "Ran N tool call(s)" label throughout a turn (see src/workbench/extensions/agent/components/ agent/message/ToolCallGroup.vue). The `agent.working` i18n string exists in the locale file but nothing on this branch reads it, so the fixture's `workingRow` locator never resolves and every test using AgentTurnLockHarness.startTurn() timed out in CI (playwright-tests (cloud), 5/5 specs in agentTurnSurvivesSocketDrop.spec.ts failing identically on every retry). Reverting these two files to the pre-existing core/1.54 content (the `activityRow` locator matching the real "Ran 1 tool call" button) restores parity with the actual UI. That content already carries equivalent coverage for PM-1199 from the earlier #18186 sweep, so no further backport of these files is needed until the WorkSummary/ ActivityTrace refactor itself lands on this branch. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WgCgZKjk1bLPcyYppEr9DZ
## Summary Ports to `core/1.54` every merged `main` Agent fix that `cloud/1.54` carries and core does not (the Agent UI catch-up from #18622, the cloud-only CRDT and workflow fixes, and the round-2 fixes), so both release lines are symmetric ahead of the local-agent rollout. ## Changes - **What**: `cherry-pick -x`, in three groups: - Agent UI, as in #18622: #17339, #17908, #17420, #18348, #18043, #17621 (without its two `src/lib/litegraph/` files; a 5 px HUD offset in `SideToolbar.vue` compensates), #17471, #17690. - Cloud-only fixes: #18063, #18073, #18064, #18033, #18289, #18604, #18616, #18376. - Round 2: #17568, #17628, #16491, #18453, #17767, #18431 (from #18571), #18603. - **Already on `core/1.54`**: #17439 (#18161), #17912 (#18186), #18391 (#18595). - **Excluded**: #17730 (core lacks its three files), #18421 (dead code on core builds), #16917 (conflicts with later core changes), #18066 (Christian's request), #18375 and #18251 (need their litegraph hunks). ## Review Focus - On this line the Agent panel registers only in cloud builds (`src/extensions/core/index.ts:41-44`); the shared chrome from #17621 and #17471 and the host telemetry from #18376 and #18603 ship in every build. - `HostTelemetrySink.ts` and its test equal `main`'s files (#18376, then #18603 on top). - #18064: `agentConversationHostDoc.test.ts` keeps this line's file; #18063's new test uses `main`'s version (multi-player 0.3.x stamps). - Supersedes #18571 and the closed #18637. Linear: [PM-1657](https://linear.app/comfyorg/issue/PM-1657), [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) Visual changes are the ones reviewed on `main` and carried to cloud in #18622. --------- Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: ryan-di <ryan.weihao.di@gmail.com> Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
Summary
Seventeen non-billing Agent sources are carried for
core/1.54. Exact-head hosted checks and target-native replay acceptance pass; review remains.Full context for agent readers
Changes
HostDoc, and tab-return harnesses.Review focus
main's newer visibility architecture.Exact-head verification
Current head:
2bd4dace2e6207fede11d2ac219d691a811769dc, verified under Node 25.9.0 and pnpm 11.13.1.aria-invalid=truesurvive tab return;bd7da3cffd6dc349e1c48c5a277bc112cabd0e41passed one zero-retry target-native warning-retention case with an inspected final frame; its durable QA receipt is ancestry evidence, not acceptance of this newer head;HostDocand asserts the pasted position survives another tab retarget;389a3718bd2f637f704bde349068cbfd87cd9542passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection;366e0287095876351377f873688fece88eb90397reached local paste but had already closed the Agent panel, which unmountedAgentPanelRoot, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchangedHostDocassertion;Exact-head hosted checks and target-native replay acceptance pass. Review and the release-target merge-readiness gate remain required before merge. No deployment or check waiver is authorized.
Justification: Authorized Agent 1.54 release backport aggregate merged without standing human approval under the published release-backport authority; exact-head hosted checks, target-native replay acceptance, target-aware merge guard, adaptation review, and absence of unresolved human objections limit risk.