Repository navigation
fix: pasted nodes reach the agent doc at the pasted position, not [10, 10] - #18071
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2063 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.95 MB gzip 🟢 -55 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.87 MB (baseline 3.87 MB) • 🔴 +52 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 73 added / 73 removed / 228 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T11:12:21.052Z",
"gitSha": "8726029012d11550a82f04a0bfcc54ce1a0f0d80",
"branch": "test/pm-1295-orphaned-loadimage-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2054.3200000000184,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.968,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.296,
"heapDeltaBytes": 17589076,
"heapUsedBytes": 79317312,
"domNodes": -262,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 10.975000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2016.8240000000424,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.344999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.34600000000006,
"heapDeltaBytes": 14324336,
"heapUsedBytes": 75541800,
"domNodes": -267,
"jsHeapTotalBytes": 3923968,
"scriptDurationMs": 8.702000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1861.6780000000404,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.761000000000003,
"layouts": 14,
"layoutDurationMs": 4.3420000000000005,
"taskDurationMs": 902.329,
"heapDeltaBytes": -6171944,
"heapUsedBytes": 55805808,
"domNodes": -263,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 171.409,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1876.3150000000905,
"styleRecalcs": 80,
"styleRecalcDurationMs": 28.436000000000003,
"layouts": 14,
"layoutDurationMs": 4.521000000000001,
"taskDurationMs": 882.022,
"heapDeltaBytes": 14235316,
"heapUsedBytes": 76459536,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 170.483,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.537000000008,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.197999999999997,
"layouts": 6,
"layoutDurationMs": 1.3110000000000002,
"taskDurationMs": 381.413,
"heapDeltaBytes": 2314036,
"heapUsedBytes": 63989824,
"domNodes": 74,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 13.406,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.9219999999632,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.048,
"layouts": 6,
"layoutDurationMs": 1.147,
"taskDurationMs": 340.19699999999995,
"heapDeltaBytes": 2146352,
"heapUsedBytes": 64267348,
"domNodes": 74,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 10.574,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 757.4139999999829,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.845000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.93300000000005,
"heapDeltaBytes": 18842848,
"heapUsedBytes": 86188148,
"domNodes": 12,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 184.98000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 659.4460000000026,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.908,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.7610000000001,
"heapDeltaBytes": 18210872,
"heapUsedBytes": 80254284,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 171.52100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2034.5679999999788,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.947000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 648.171,
"heapDeltaBytes": 2859524,
"heapUsedBytes": 83490840,
"domNodes": -252,
"jsHeapTotalBytes": -1318912,
"scriptDurationMs": 36.907999999999994,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2049.9589999999444,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.457000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.0080000000002,
"heapDeltaBytes": 2720032,
"heapUsedBytes": 83534264,
"domNodes": -249,
"jsHeapTotalBytes": -1806336,
"scriptDurationMs": 38.605000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2508.7449999999762,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.383999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1762.9519999999998,
"heapDeltaBytes": 2538484,
"heapUsedBytes": 84549312,
"domNodes": -256,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 911.421,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2561.3069999999425,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.279000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1765.5810000000001,
"heapDeltaBytes": -1988528,
"heapUsedBytes": 80081932,
"domNodes": -256,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 901.969,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3624.654000000021,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.356,
"layouts": 60,
"layoutDurationMs": 13.485999999999997,
"taskDurationMs": 1756.631,
"heapDeltaBytes": 7687996,
"heapUsedBytes": 73655460,
"domNodes": -261,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 816.5049999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3646.225999999956,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.103,
"layouts": 60,
"layoutDurationMs": 13.312,
"taskDurationMs": 1721.5639999999999,
"heapDeltaBytes": -9386960,
"heapUsedBytes": 74271388,
"domNodes": -255,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 806.663,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3143.5429999999656,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.191999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1955.855,
"heapDeltaBytes": 17492032,
"heapUsedBytes": 83111128,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1009.3070000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3143.3489999999438,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.407999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1975.2679999999998,
"heapDeltaBytes": 843640,
"heapUsedBytes": 66816236,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1030.9669999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2026.9509999999968,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.472000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 614.9390000000001,
"heapDeltaBytes": -4699944,
"heapUsedBytes": 83979616,
"domNodes": -253,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 37.419999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2005.1569999999401,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.195,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.4820000000001,
"heapDeltaBytes": 19711232,
"heapUsedBytes": 83549332,
"domNodes": -254,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.946,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.4180000000324,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.399999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 417.46399999999994,
"heapDeltaBytes": 14511400,
"heapUsedBytes": 78100112,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 146.74200000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.9849999999797,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.498000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.57800000000003,
"heapDeltaBytes": 14142272,
"heapUsedBytes": 83670240,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 153.336,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.4729999999909,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.306999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.25299999999993,
"heapDeltaBytes": -6349804,
"heapUsedBytes": 63284564,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.694,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2018.310999999926,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.364,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.289,
"heapDeltaBytes": 15603056,
"heapUsedBytes": 78984248,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.295000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.3849999999838,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.378999999999998,
"layouts": 18,
"layoutDurationMs": 5.772,
"taskDurationMs": 858.938,
"heapDeltaBytes": 16372988,
"heapUsedBytes": 79612884,
"domNodes": -276,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 121.479,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.6579999999476,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.188000000000002,
"layouts": 18,
"layoutDurationMs": 5.0600000000000005,
"taskDurationMs": 820.637,
"heapDeltaBytes": 16188828,
"heapUsedBytes": 79734024,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 113.80399999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.6860000000643,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.078000000000003,
"layouts": 5,
"layoutDurationMs": 13.008000000000003,
"taskDurationMs": 907.6490000000001,
"heapDeltaBytes": -6447276,
"heapUsedBytes": 81578652,
"domNodes": 13587,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.969000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9107.775000000003,
"styleRecalcs": 247,
"styleRecalcDurationMs": 37.269,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6240.206,
"heapDeltaBytes": 5601564,
"heapUsedBytes": 86660500,
"domNodes": -249,
"jsHeapTotalBytes": -1089536,
"scriptDurationMs": 2983.701,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8272.42799999999,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.35,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5232.911999999999,
"heapDeltaBytes": -45372,
"heapUsedBytes": 80517340,
"domNodes": -248,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 2846.3599999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17406.89200000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16926.473,
"heapDeltaBytes": -43864072,
"heapUsedBytes": 168047752,
"domNodes": -8061,
"jsHeapTotalBytes": -17764352,
"scriptDurationMs": 307.241,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16565.732000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15831.929,
"heapDeltaBytes": -32726264,
"heapUsedBytes": 196992416,
"domNodes": -8061,
"jsHeapTotalBytes": -9187328,
"scriptDurationMs": 251.26199999999997,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20905.552999999996,
"styleRecalcs": 165,
"styleRecalcDurationMs": 18.570000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20723.606,
"heapDeltaBytes": -32749536,
"heapUsedBytes": 190915800,
"domNodes": -8061,
"jsHeapTotalBytes": -18620416,
"scriptDurationMs": 956.9010000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 49,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20513.137000000028,
"styleRecalcs": 162,
"styleRecalcDurationMs": 17.19599999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20186.457,
"heapDeltaBytes": -37557244,
"heapUsedBytes": 179985708,
"domNodes": -8061,
"jsHeapTotalBytes": -11591680,
"scriptDurationMs": 911.02,
"eventListeners": -14928,
"totalBlockingTimeMs": 100,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6225.90699999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.952,
"layouts": 20,
"layoutDurationMs": 24.582999999999995,
"taskDurationMs": 6156.6720000000005,
"heapDeltaBytes": -25457392,
"heapUsedBytes": 193586680,
"domNodes": -8061,
"jsHeapTotalBytes": 15880192,
"scriptDurationMs": 112.442,
"eventListeners": -14928,
"totalBlockingTimeMs": 500,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6187.546999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.15599999999998,
"layouts": 20,
"layoutDurationMs": 23.988999999999997,
"taskDurationMs": 6097.978000000001,
"heapDeltaBytes": -46851332,
"heapUsedBytes": 175638180,
"domNodes": -8061,
"jsHeapTotalBytes": 13430784,
"scriptDurationMs": 116.47300000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 411,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8612.289999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8428.817,
"heapDeltaBytes": 12387260,
"heapUsedBytes": 196764680,
"domNodes": 0,
"jsHeapTotalBytes": -12582912,
"scriptDurationMs": 134.745,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8500.967000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8318.525000000001,
"heapDeltaBytes": 27441252,
"heapUsedBytes": 197780928,
"domNodes": 0,
"jsHeapTotalBytes": -6291456,
"scriptDurationMs": 156.416,
"eventListeners": -1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 443.9220000000432,
"styleRecalcs": 13,
"styleRecalcDurationMs": 20.486000000000004,
"layouts": 3,
"layoutDurationMs": 0.9,
"taskDurationMs": 110.48600000000003,
"heapDeltaBytes": 4852472,
"heapUsedBytes": 66350312,
"domNodes": 120,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.706,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 119.39999999992779,
"styleRecalcs": 7,
"styleRecalcDurationMs": 18.005,
"layouts": 3,
"layoutDurationMs": 2.054,
"taskDurationMs": 89.20400000000001,
"heapDeltaBytes": 3094324,
"heapUsedBytes": 64822868,
"domNodes": 131,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.235000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3a851363c48b233b3b576131dff6e1e92b0e1573
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
6a903c6 to
bf139a9
Compare
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18071 +/- ##
==========================================
+ Coverage 82.78% 83.91% +1.12%
==========================================
Files 2939 2260 -679
Lines 144660 128531 -16129
Branches 37220 33221 -3999
==========================================
- Hits 119763 107858 -11905
+ Misses 23630 20383 -3247
+ Partials 1267 290 -977
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 813 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Fix plan for the disconnected LoadImage node bug (not yet implemented — for review)Three areas are implicated; none is a one-line fix. 1. Position-ordering bug (litegraph bulk-add) 2. Transport bug ( 3. Scoping bug (
Open question for review: for #2, should reconciliation on the next subscribe prefer "trust the server" (adopt whatever landed) or "trust the client's last known-good state" (roll back anything not locally acknowledged)? This affects a real user's undo history and deserves a human call before implementing. Edit: the adversarial audit below shows #2 is a dev-log accuracy issue, not a data-integrity bug (its settle state has a single consumer, the debug event log), #3 has no demonstrated repro, and the position fix (#1) is the actual fix. Corrected order: #1, then #2 as telemetry. The reconciliation question is moot. Generated by Claude Code |
Adversarial audit of the fix planRead against 1. Claim checkPosition ordering (fix #1): claims correct, remedy incomplete.
Transport (fix #2): code claim correct, causal claim wrong.
Scoping (fix #3): code claim correct, threat not demonstrated.
The e2e in this PR did not reproduce the bug.
2. What the R-73 "settle undeliverable on unbind" invariant protects todayThe four assertions (crossWorkflowPending.test.ts:255-261, useAgentCrdtFollower.test.ts:1071/1108/1146) guard three things: settle NOW so the next doc's batch is not stuck behind the 10 s silence window (the #16637 residual); never re-address a batch minted for one doc to another; a late result for the old doc must not settle the new doc's batch. None of those depends on the label being 3. Reconciliation question: decided, not a toss-up
Decision for #2: keep the immediate settle at retarget and at the transmit-time recheck, but report it honestly. A batch that was transmitted at least once and then lost its doc before any host result settles as a new terminal state 4. Fix #1: smallest safe change
5. Order and scope
The e2e is rewritten as a regression test (the pasted node keeps its pasted position after the tab return) and the harness's fake host is taught to commit client Generated by Claude Code |
bf139a9 to
870f696
Compare
7544f72 to
1a7ef7b
Compare
… host that commits client ops
72be5b2 to
48a49b2
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
The pasted-node acceptance blocker is repaired. Unit and browser checks pass; the broader disconnected-node incident stays open.
Full context for agent readers
Substantive review covers the pasted-position snapshot, transmitted versus unconfirmed settlement, and the newly repaired serialization boundary. The host was receiving add_node but rejecting the copied reserved __incarnation field as invalid_node_payload. Removing that source identity from the minted payload makes the host accept the copied node. The new unit input failed before this repair; 116 tests now pass across clipboard, sender, cross-workflow pending state, follower, mint wiring and the host fixture.
The Cloud browser case now proves host acceptance, tab return and fresh-follower reload after deleting local workflow storage. It passes in 14.9s with the real shared operation applier. The fixture correctly classifies duplicate/no-op outcomes as skipped, with a focused regression test. Main/browser typechecks, formatting, lint and commit hooks pass.
Evidence limitation: removing only the original paste-position assignment still passes this browser journey. The position snapshot and settlement fixes are distinguished by the existing unit red/green checks (11 pre-fix failures), not by a claimed browser red/green result for those lines. The original disconnected Load Image report also occurs without paste; this PR does not prove that separate journey repaired. The existing evaluation reproduction and both 1.54 release acceptance tasks remain owned by Christian's completion lane. Full backports require the absent conversation fixtures or target-native adaptation; no clean-backport labels yet.
Glossary: incarnation is the host-owned identity of a node instance; unconfirmed means transport sent an operation but its server result is unknown. Neither client acknowledgement nor source merge equals release acceptance.
christian-byrne
left a comment
There was a problem hiding this comment.
The pasted-node repair retains host acceptance, tab-return and fresh-reload coverage. The final test adjustment targets empty canvas rather than a node covering the previous pointer position.
Full context for agent readers
Reviewed this head, retaining the earlier source review and 116 passing unit tests for stripping the host-owned incarnation from newly minted nodes. The final delta changes only the actionable canvas-hover coordinates. Readiness, asymmetric paste position, authoritative acceptance, tab return and fresh reload assertions remain intact; no timeout or assertion was weakened.
The pinned CI container reproduced the old hover failure: the covered target did not update graph mouse position. With the empty-canvas target, the production-artifact offline case passes in 4.8s; the same container with video and 250ms slow motion passes in 9.3s. Commit and push hooks pass. This supersedes the earlier development-server-only confidence in the pointer setup.
Removing only the original paste-position change still passes the browser case. Position-specific discrimination remains unit-level, not browser red/green proof. The original disconnected Load Image incident also occurs without paste and stays open. Christian's completion lane retains original-workflow acceptance and both release branches, without replacing the existing evaluation owner.
Glossary: incarnation is a host-owned node-instance identity; fresh reload reconstructs workflow state without the local workflow cache.
## Summary Seventeen non-billing Agent sources are carried for `core/1.54`. Exact-head hosted checks and target-native replay acceptance pass; review remains. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `2bd4dace2e6207fede11d2ac219d691a811769dc`, verified under Node 25.9.0 and pnpm 11.13.1. - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - ancestor head `bd7da3cffd6dc349e1c48c5a277bc112cabd0e41` passed one zero-retry target-native warning-retention case with an inspected final frame; its [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/7fa0ba4d731f00684388a45f1aeb1d24dc6f2280/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1145-utc-exact-core-native-case-passes-final-warning-frame-inspected) is ancestry evidence, not acceptance of this newer head; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `389a3718bd2f637f704bde349068cbfd87cd9542` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `366e0287095876351377f873688fece88eb90397` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:44:02 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. Exact-head hosted checks and target-native replay acceptance pass. Review and the release-target merge-readiness gate remain required before merge. No deployment or check waiver is authorized. </details> Justification: Authorized Agent 1.54 release backport aggregate merged without standing human approval under the published release-backport authority; exact-head hosted checks, target-native replay acceptance, target-aware merge guard, adaptation review, and absence of unresolved human objections limit risk. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
## Summary Seventeen non-billing Agent sources are carried for `cloud/1.54`. The candidate now contains release `1.54.12`; fresh hosted checks and target-native replay acceptance passed. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`, verified locally under Node 25.9.0 and pnpm 11.13.1. - merged current `cloud/1.54` tip `d2667baf6bdb8664821b4bed7a7f5a1df65f9f49` cleanly; the imported release delta is limited to the package version and locale data; - frozen installation, 174 focused Agent/missing-model tests with 1 expected failure, main and browser typechecks, formatting, full ESLint with zero errors, the Cloud production build, target ancestry, and diff checks pass locally; - fresh exact-head hosted checks and one zero-retry target-native replay passed after the release target changed; - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `dfe99947cffb5f31c5f4750113eb9770720e5eac` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `5ec6c64e9b78b56b12350ae732dc1e1ea20052e0` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:45:15 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. The prior replay receipt remains historical evidence for parent head `516f6b5f71e251b25985fb61715432f05249c4bd`. Fresh hosted checks and the fresh target-native replay passed at current head `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`; adaptation review and the release-target merge-readiness gate also passed. </details> Justification: Author-owned release aggregate merged under the published Agent 1.54 backport grant after exact-head hosted checks, target-native replay, adaptation review, target ancestry, and the target-aware merge guard passed; no independent approval was available. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
…raph (Comfy-Org#18109) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789709550015299?thread_ts=1789709550.015299&cid=C0BGH348Z0C)_ ## Summary **Before:** While the Agent panel is bound to a workflow, switching to another workflow tab reuses the same in-memory root graph object for the new tab's nodes before the panel's document binding has caught up. Every node LiteGraph attaches during that window queues a layout `createNode` change, and the mint port did not check which graph a change belonged to, so those changes for the new tab were minted as `add_node` operations and sent into the *previous* tab's still-bound document. **After:** The layout mint port now compares every root-scoped `createNode`/`deleteNode`/`clearGraph` change against the bound document's own root graph id, sourced from a plain accessor derived from the bound workflow's own serialized `activeState.id` (not the live canvas graph, and not a memoized `computed`, so it can never latch a value that goes stale while the same workflow's own graph id rotates in place). A change naming a different graph is dropped and reported once (`agent_crdt_op_for_unbound_graph`) instead of being minted, so a tab switch can no longer leak one workflow's nodes into another workflow's document. Mechanism: `app.ts` reuses one root graph instance across every workflow and reconfigures it (rewriting its stored id) before the panel's `isBoundWorkflowActive` flag has a chance to flip, so the layout store's queued `createNode` notifications for the newly-loaded workflow flush on a microtask while the mint port still believes the previous workflow's document is bound. ## Changes - **What**: - `AgentPanelRoot.vue` derives `boundRootGraphId` as a plain function reading the bound workflow's own serialized `activeState.id` (via `boundOrOpenWorkflowFor(boundWorkflowId)`), converted with `toRootGraphId`, and passes the accessor into `attachMintPortWiring`. Reading it as a plain accessor (not a `computed`) matters because the workflow's `changeTracker` is `markRaw`'d: a `computed` reading through it has no reactive dependency on `activeState.id` and would keep serving a stale id after the same bound workflow's own graph id rotates without a rebind (e.g. `LGraph.clear()`). - `mintPortWiring.ts` forwards the `boundRootGraphId` accessor (typed `RootGraphId | null`) through to the layout mint port. - `layoutMintPort.ts` drops a root-scoped `createNode`/`deleteNode`/`clearGraph` whose `graphId` does not match the bound root graph id, reporting once per action and graph pair per tick via `reportError` (`agent_crdt_op_for_unbound_graph`). Its own mint-dedupe bookkeeping is keyed by each operation's own `graphId` (one id set per root graph, looked up by the value the op itself carries — every real op's `graphId` comes from the live `LGraph`, which always has one) rather than by the `boundRootGraphId()` accessor, so a graph's bucket is reachable only through its own ops: a rebind, a still-in-flight foreign load, or a document whose id has not hydrated yet can never share or evict another graph's bookkeeping. `clearGraph` only forgets a graph's bucket for an intentional (human-confirmed) clear captured via `runIntentionalClear`, never for an incidental clear (a tab switch's in-place `LGraph.clear()`), so a return to a root whose nodes are still in the document does not re-mint them. `deleteNode`'s forget-side bookkeeping only fires for a genuinely same-graph, root-owned delete (`ownerGraphId === graphId`), so a subgraph-interior delete sharing a node id with a root-level node cannot corrupt the root's own entry. ## Review Focus - `src/renderer/core/layout/store/layoutStoreMintDelivery.test.ts` reproduces the exact microtask race against the real layout store (teardown bracket open → configure the new workflow's nodes → teardown bracket close, all synchronous → flush). It failed before this change (an `add_node` for the other workflow's node was minted) and passes after. - `layoutMintPort.test.ts` covers the dedupe-bookkeeping regressions: a root-scoped delete or clear for a foreign graph is dropped and reported without touching the bound graph's own dedupe entry or an active intentional-clear capture; an incidental (non-intentional) same-graph clear — the shape a tab switch's in-place `LGraph.clear()` emits before rebinding — also leaves the bound graph's dedupe entry untouched; two unidentified documents (accessor reporting null for both) no longer share a dedupe bucket; a subgraph-interior delete colliding on node id with a root-level node cannot clear the root's own entry; and a rebind to a different root, including an A→B→A round trip that actually delivers B's own create while B is bound, mints/suppresses correctly on each side. - For `createNode` and `deleteNode` the scope check only applies once a change is already root-scoped (`ownerGraphId === graphId`); `clearGraph` has no owner-graph check because it is always root-scoped by construction (`layoutStore.clearGraph(rootGraphId)` is its only call site) — it is classified directly by its `graphId`. The existing subgraph-interior handling in `reportUnrepresentableInteriorChange` is untouched, as is `serializeForMint`. - `boundRootGraphId()` returning `null` (no workflow bound, or a workflow bound before its `activeState` has hydrated) is treated as permissive rather than restrictive, matching every other existing caller's fixtures: failing closed there would turn an ordinary, transient post-bind race into permanently dropped user edits, which is worse than the narrow foreign-load race it would guard against — a race the dedupe bucket's own per-graphId keying (above) already removes the practical risk from, and one still independently covered by the teardown/session brackets. ### Verification - `pnpm vitest run src/workbench/extensions/agent/crdt src/renderer/core/layout/store/layoutStoreMintDelivery.test.ts`: 727 passed, 2 pre-existing expected fails (unrelated). - `pnpm vitest run src/workbench/extensions/agent`: 1803 passed, 4 pre-existing expected fails (unrelated). - `pnpm vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts`: included above. - `pnpm typecheck`, `pnpm lint` (targeted to changed files plus the full pre-commit hook), `pnpm format`, `pnpm knip`: clean. Related: Comfy-Org#18078, Comfy-Org#18071 --- _Generated by [Claude Code](https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc)_ --------- Co-authored-by: Claude <noreply@anthropic.com>
…nodes across a workflow tab switch (#18378) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789709550015299?thread_ts=1789709550.015299&cid=C0BGH348Z0C)_ Backport of #18078 to `core/1.54`. ## Summary **Before:** With the Agent panel bound to a workflow, a user adds a Get/Set node (or any other frontend-registered node such as Note) or a subgraph blueprint to the canvas, switches to another workflow tab, and switches back. The node is gone. Nodes from the server's node catalog (KSampler, CLIPTextEncode) survive the same round trip. **After:** The add of a frontend-only node or blueprint host lands in the document like any catalogued node's, so it survives the tab return. `serializeForMint` (`src/workbench/extensions/agent/crdt/mintPortWiring.ts`) no longer rewrites a frontend-only node's `widgets_values` into the name-keyed object the document applier rejects for uncatalogued classes; it keeps the positional form `serialize()` already produced. ## Changes - **What**: Cherry-picked the squash-merge commit `963d1ee947179cf2124bead716610cf8e6fed52f` (#18078) onto a new branch from `origin/core/1.54`. The fix itself (`mintPortWiring.ts`) and most of the new Vitest regression tests applied cleanly. - **Conflicts resolved faithfully**: `mintPortWiring.test.ts` and `agentConversationHostDoc.ts` conflicted because `core/1.54`'s copies predate this PR's changes; both were resolved by combining `core/1.54`'s existing content with #18078's additions (the `applyClient` → `applyWire` rewrite in `HostDoc`, and the two new Note/blueprint mint cases in the unit test), with no logic invented beyond what #18078 wrote. - **Adapted one pre-existing call site**: `agentAutogrowTabSwitchReconcile.spec.ts` (already on `core/1.54`, untouched by #18078 on `main` because an intervening, unbackported refactor already migrated it there) called `HostDoc.applyClient(...)`, which this PR renames to `applyWire` with a different return shape. Updated that one call site to the new `{ result, update }` shape with identical frame-send behavior; no test assertions changed. - **Omitted three files whose subject module/infra is entirely absent from `core/1.54`** (not part of #18078's own new work — each belongs to a separate, unrelated, unbackported main PR that this branch never got): - `browser_tests/fixtures/agentConversationFixture.ts` and `browser_tests/fixtures/agentFollowerHostSocket.ts` — the "replay recorded agent conversations" Playwright harness these belong to was added by #16764 and #17537, neither backported to `core/1.54`; their dependency chain (`agentConversation.ts`, `agentReplayNodeDefs.ts`, `agentConversationExpectations.ts`, `agentReplayNodeContract.ts`) is also absent. Porting them would mean re-implementing those unrelated PRs wholesale, so they were dropped along with the new spec that exclusively depends on them (`agentHumanAddTabSwitch.spec.ts`), its dedicated unit test (`agentFollowerHostSocket.test.ts`), and the now-orphaned blueprint data file (`agentHumanAddBlueprints.ts`) and the `TabSwitchLens`/`__tabSwitchLens` type addition in `browser_tests/types/globals.d.ts` that only that spec used. - `browser_tests/tests/agent/agentPastedNodeOrphanedOnRetarget.spec.ts` — this pre-existing spec (added by #18071, not on `core/1.54`) doesn't exist to receive #18078's one-line `test.use({ humanOpsHost: 'apply' })` tweak, so there is nothing to apply it to. - `src/workbench/extensions/agent/crdt/agentCrdtProjection.tabReturn.test.ts` — imports `AgentCrdtProjection` from `./agentCrdtProjection`, a class introduced by the unrelated refactor #16908 ("split CRDT follower layers"), which is not on `core/1.54`. The sibling test that doesn't need that module, `agentCrdtProjection.serializeDivergence.test.ts`, was kept. - The still-applicable e2e coverage (`workflowTabSwitchKeepsAddedNodes.spec.ts`, the non-Agent baseline) and Vitest coverage (`mintPortWiring.test.ts`, `agentCrdtProjection.serializeDivergence.test.ts`, `useAgentCrdtFollower.rejectedHumanAdd.test.ts`, `LGraph.tabSwitchSnapshot.test.ts`) were kept as-is. ## Review Focus - The three omissions above are infra/coverage gaps caused by branch divergence, not behavior changes — the production fix in `mintPortWiring.ts` is unconditional and applies exactly as on `main`. - `agentAutogrowTabSwitchReconcile.spec.ts`'s adapted call site is mechanical (same two frames sent in the same order); worth a second look given it wasn't part of #18078's own diff. ## Local verification - `pnpm vitest run src/workbench/extensions/agent`: 1697 passed, 4 expected fail, 4 failed. 3 of the 4 failures (`AgentPanelRoot.test.ts` "Media-card" attach/upload cases) confirmed pre-existing by running the same file against unmodified `origin/core/1.54`. The 4th (`Composer.test.ts` "closes when the caret moves out of the token") passes when run in isolation on this branch and passed on unmodified `origin/core/1.54`; it is a pre-existing flake unrelated to this change (the file is untouched by this backport). - `pnpm lint`, `pnpm typecheck`, `pnpm typecheck:browser`: all clean (ran automatically via the pre-commit hook). - `pnpm format:check` (oxfmt) on changed files: clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc --- _Generated by [Claude Code](https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc)_ Co-authored-by: Claude <noreply@anthropic.com>
… nodes across a workflow tab switch (#18382) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789709550015299?thread_ts=1789709550.015299&cid=C0BGH348Z0C)_ Backport of #18078 to `cloud/1.54`. ## Summary **Before:** With the Agent panel bound to a workflow, a user adds a Get/Set node (or any other frontend-registered node such as Note) or a subgraph blueprint to the canvas, switches to another workflow tab, and switches back. The node is gone. Nodes from the server's node catalog (KSampler, CLIPTextEncode) survive the same round trip. **After:** The add of a frontend-only node or blueprint host lands in the document like any catalogued node's, so it survives the tab return. `serializeForMint` (`src/workbench/extensions/agent/crdt/mintPortWiring.ts`) no longer rewrites a frontend-only node's `widgets_values` into the name-keyed object the document applier rejects for uncatalogued classes; it keeps the positional form `serialize()` already produced. ## Changes - **What**: Cherry-picked the squash-merge commit `963d1ee947179cf2124bead716610cf8e6fed52f` (#18078) onto a new branch from `origin/cloud/1.54`. The fix itself (`mintPortWiring.ts`) and most of the new Vitest regression tests applied cleanly. - **Conflicts resolved faithfully**: `mintPortWiring.test.ts` and `agentConversationHostDoc.ts` conflicted because `cloud/1.54`'s copies (byte-identical to `core/1.54`'s) predate this PR's changes; both were resolved by combining the branch's existing content with #18078's additions (the `applyClient` → `applyWire` rewrite in `HostDoc`, and the two new Note/blueprint mint cases in the unit test), with no logic invented beyond what #18078 wrote. - **Adapted one pre-existing call site**: `agentAutogrowTabSwitchReconcile.spec.ts` (already on `cloud/1.54`, untouched by #18078 on `main` because an intervening, unbackported refactor already migrated it there) called `HostDoc.applyClient(...)`, which this PR renames to `applyWire` with a different return shape. Updated that one call site to the new `{ result, update }` shape with identical frame-send behavior; no test assertions changed. - **Omitted the same three files as the `core/1.54` backport (#18378), whose subject module/infra is checked and confirmed independently absent from `cloud/1.54`** (not part of #18078's own new work — each belongs to a separate, unrelated, unbackported main PR that this branch never got either): - `browser_tests/fixtures/agentConversationFixture.ts` and `browser_tests/fixtures/agentFollowerHostSocket.ts` — the "replay recorded agent conversations" Playwright harness these belong to was added by #16764 and #17537, neither backported to `cloud/1.54`; their dependency chain (`agentConversation.ts`, `agentReplayNodeDefs.ts`, `agentConversationExpectations.ts`, `agentReplayNodeContract.ts`) is also absent. Porting them would mean re-implementing those unrelated PRs wholesale, so they were dropped along with the new spec that exclusively depends on them (`agentHumanAddTabSwitch.spec.ts`), its dedicated unit test (`agentFollowerHostSocket.test.ts`), the now-orphaned blueprint data file (`agentHumanAddBlueprints.ts`), and the `TabSwitchLens`/`__tabSwitchLens` type addition in `browser_tests/types/globals.d.ts` that only that spec used. - `browser_tests/tests/agent/agentPastedNodeOrphanedOnRetarget.spec.ts` — this pre-existing spec (added by #18071, not on `cloud/1.54`) doesn't exist to receive #18078's one-line `test.use({ humanOpsHost: 'apply' })` tweak, so there is nothing to apply it to. - `src/workbench/extensions/agent/crdt/agentCrdtProjection.tabReturn.test.ts` — imports `AgentCrdtProjection` from `./agentCrdtProjection`, a class introduced by the unrelated refactor #16908 ("split CRDT follower layers"), which is not on `cloud/1.54`. The sibling test that doesn't need that module, `agentCrdtProjection.serializeDivergence.test.ts`, was kept. - The still-applicable e2e coverage (`workflowTabSwitchKeepsAddedNodes.spec.ts`, the non-Agent baseline) and Vitest coverage (`mintPortWiring.test.ts`, `agentCrdtProjection.serializeDivergence.test.ts`, `useAgentCrdtFollower.rejectedHumanAdd.test.ts`, `LGraph.tabSwitchSnapshot.test.ts`) were kept as-is. ## Review Focus - The three omissions above are infra/coverage gaps caused by branch divergence, not behavior changes — the production fix in `mintPortWiring.ts` is unconditional and applies exactly as on `main`. - `agentAutogrowTabSwitchReconcile.spec.ts`'s adapted call site is mechanical (same two frames sent in the same order); worth a second look given it wasn't part of #18078's own diff. ## Local verification - `pnpm vitest run src/workbench/extensions/agent`: 1732 passed, 4 expected fail, 3 failed. All 3 failures (`AgentPanelRoot.test.ts` "Media-card" attach/upload cases) confirmed pre-existing by running the same file against unmodified `origin/cloud/1.54`, where they fail identically. - `pnpm lint`, `pnpm typecheck`, `pnpm typecheck:browser`: all clean (ran automatically via the pre-commit hook). - `pnpm format:check` (oxfmt) on changed files: clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc --- _Generated by [Claude Code](https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Requested by Christian Byrne · Slack thread
Before: A node pasted onto the in-app agent's canvas (paste, insert-workflow, node template, subgraph blueprint all funnel through
LGraphCanvas._deserializeItems) reached the shared doc at theLGraphNodeconstructor default[10, 10]:graph.add()snapshots the position into the layout store, the feed the CRDT layout-mint port mintsadd_nodefrom, and it ran before the pasted position was set. Locally the node looked right; the next resubscribe (leave the tab and return) replayed the doc's position over the live node and left it disconnected at[10, 10]. Separately,opSenderreported a batch the transport had already carried as'undeliverable'when its doc was unbound mid-flight, contradicting that outcome's own contract.After: The pasted node's final position is assigned before
graph.add(), so thecreateNodelayout snapshot, and theadd_nodeminted from it, carry the pasted position. A transmitted batch whose doc is unbound before any host result now settles as'unconfirmed';'undeliverable'is reserved for batches the transport never carried. Retarget behaviour (settle immediately, never re-address) is unchanged; the only consumer is the dev log.Changes
src/lib/litegraph/src/LGraphCanvas.ts: compute the paste offset before the node loop and setnode.posto the final pasted position beforegraph.add(node).src/workbench/extensions/agent/crdt/opSender.ts: track whether a batch was transmitted; an unbound transmitted batch settles'unconfirmed'.it.fails()reproductions are now plainit()and pass. R-73 settle-label assertions updated to'unconfirmed'for transmitted batches; the guarantees they encode (immediate settle, no re-addressing, no cross-doc settle) are unchanged.browser_tests/tests/agent/agentPastedNodeOrphanedOnRetarget.spec.ts: rewritten as a regression test (run the recorded turn so the follower is bound, paste a seed node, switch tabs and return, the pasted node keeps its pasted position; screenshot lens dropped, no golden exists).browser_tests/fixtures/agentFollowerHostSocket.tsandagentConversationHostDoc.ts: the fake host now commits clientdoc_opsthrough the library'sapplyOpsand answers withdoc_ops_resultanddoc_update. Previously it dropped client ops, so the originaltest.fail()could not have reproduced the bug; its green CI run only proved that some assertion failed.Deliberately not done
Plan item #3 (root-graph-id scoping in
layoutMintPort): no failing test and no demonstrated leak path. See the audit comment for the reasoning and two follow-ups it surfaced (human node moves are never replicated because the wire vocabulary has no move op; the load bracket does not actually coverLGraph.configure's layout changes, tab activation timing does).Red-green
test: assert the paste-time createNode layout snapshot carries the pasted positionexpected { x: 10, y: 10 } to deeply equal { x: 900, y: 900 }fix: set the pasted position before graph.add so the layout snapshot carries ittest: assert a transmitted batch is never settled undeliverable on a doc retargetexpected 'undeliverable' not to be 'undeliverable'fix: settle an unbound transmitted op batch as unconfirmed instead of undeliverableVerified locally:
pnpm exec vitest run src/lib/litegraph src/renderer/core/layout/operations(126 files) andsrc/workbench/extensions/agent/crdt(39 files) pass;pnpm typecheck,pnpm typecheck:browser,pnpm lint,pnpm format:check,pnpm knip,pnpm fallow:auditclean. The e2e runs in theplaywright-tests (cloud)job.🤖 Generated with Claude Code
https://claude.ai/code/session_014xsZPwcYvkrGi5LsfDSXXL