Skip to content

[backport cloud/1.54] fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch - #18382

Merged
christian-byrne merged 2 commits into
cloud/1.54from
backport-18078-to-cloud-1.54
Sep 22, 2026
Merged

christian-byrne merged 2 commits into
cloud/1.54from
backport-18078-to-cloud-1.54

Conversation

@claude

@claude claude Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Requested by Christian Byrne · Slack thread

Backport of #18078 to cloud/1.54.

Summary

Before: With the Agent panel bound to a workflow, a user adds a Get/Set node (or any other frontend-registered node such as Note) or a subgraph blueprint to the canvas, switches to another workflow tab, and switches back. The node is gone. Nodes from the server's node catalog (KSampler, CLIPTextEncode) survive the same round trip.

After: The add of a frontend-only node or blueprint host lands in the document like any catalogued node's, so it survives the tab return. serializeForMint (src/workbench/extensions/agent/crdt/mintPortWiring.ts) no longer rewrites a frontend-only node's widgets_values into the name-keyed object the document applier rejects for uncatalogued classes; it keeps the positional form serialize() already produced.

Changes

Review Focus

  • The three omissions above are infra/coverage gaps caused by branch divergence, not behavior changes — the production fix in mintPortWiring.ts is unconditional and applies exactly as on main.
  • agentAutogrowTabSwitchReconcile.spec.ts's adapted call site is mechanical (same two frames sent in the same order); worth a second look given it wasn't part of fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078's own diff.

Local verification

  • pnpm vitest run src/workbench/extensions/agent: 1732 passed, 4 expected fail, 3 failed. All 3 failures (AgentPanelRoot.test.ts "Media-card" attach/upload cases) confirmed pre-existing by running the same file against unmodified origin/cloud/1.54, where they fail identically.
  • pnpm lint, pnpm typecheck, pnpm typecheck:browser: all clean (ran automatically via the pre-commit hook).
  • pnpm format:check (oxfmt) on changed files: clean.

🤖 Generated with Claude Code

https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc


Generated by Claude Code

…ow tab switch

Backport of #18078 to cloud/1.54.

Serializes frontend-only nodes (Note, MarkdownNote, PrimitiveNode,
Get/Set, subgraph blueprint hosts) with positional widgets_values
before minting add_node, so the document applier no longer rejects
them with uncatalogued_widget_write and the node survives a workflow
tab switch.
@claude
claude Bot requested a review from christian-byrne September 22, 2026 05:46
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 2ae541d5-749b-4188-8ebe-b3177f5e947d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 22, 2026 6:03am UTC

Request Review

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/22/2026, 06:09:53 AM UTC

Links

🎭 Playwright: ✅ 1937 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1916 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.5 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 141ms TBT · 81.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.0 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 65ms TBT · 183.4 MB heap
vue-node-resize-workload: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 417ms TBT · 169.9 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 513ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 64.3 MB
canvas-idle: DOM nodes -282
canvas-idle: event listeners -180
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 33ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 959ms
canvas-mouse-sweep: script duration 175ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 70.9 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 375ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.9 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 458ms
dom-widget-clipping: script duration 162ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 60.2 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 10ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 665ms
large-graph-idle: script duration 38ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.2 MB
large-graph-idle: DOM nodes -273
large-graph-idle: event listeners -193
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1730ms
large-graph-pan: script duration 839ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.7 MB
large-graph-pan: DOM nodes -142
large-graph-pan: event listeners -93
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 63
large-graph-zoom: task duration 1793ms
large-graph-zoom: script duration 802ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 78.5 MB
large-graph-zoom: DOM nodes -140
large-graph-zoom: event listeners -89
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1969ms
legacy-node-drag: script duration 972ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.9 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 559ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.0 MB
minimap-idle: DOM nodes -134
minimap-idle: event listeners 5
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 425ms
subgraph-dom-widget-clipping: script duration 148ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.9 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 503ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.4 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 862ms
subgraph-mouse-sweep: script duration 115ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 70.9 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 949ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 141ms
subgraph-transition-enter: heap used 81.1 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6030ms
viewport-pan-sweep: script duration 2752ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.8 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -161
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17093ms
vue-large-graph-idle: script duration 296ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.0 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14933
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 168
vue-large-graph-pan: task duration 20698ms
vue-large-graph-pan: script duration 969ms
vue-large-graph-pan: TBT 65ms
vue-large-graph-pan: heap used 183.4 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14929
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 89ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6234ms
vue-node-resize-workload: script duration 114ms
vue-node-resize-workload: TBT 417ms
vue-node-resize-workload: heap used 169.9 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8473ms
vue-zoom-out-idle: script duration 156ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 23ms
workflow-execution: layout count 3
workflow-execution: style recalc count 18
workflow-execution: task duration 111ms
workflow-execution: script duration 10ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.8 MB
workflow-execution: DOM nodes 145
workflow-execution: event listeners 66
Raw data
{
  "timestamp": "2026-09-22T06:19:17.650Z",
  "gitSha": "d0f193bce8f6a82a6a4c14e16bc40ea1a8308898",
  "branch": "backport-18078-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2072.1849999999904,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.021999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 508.436,
      "heapDeltaBytes": 3639248,
      "heapUsedBytes": 74345224,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.463,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2028.6100000000147,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.440999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 516.599,
      "heapDeltaBytes": -9721352,
      "heapUsedBytes": 60526568,
      "domNodes": -282,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 9.347999999999999,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2011.0649999999737,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 35.998000000000005,
      "layouts": 14,
      "layoutDurationMs": 5.058,
      "taskDurationMs": 1033.694,
      "heapDeltaBytes": -4730036,
      "heapUsedBytes": 65277256,
      "domNodes": -282,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 187.21,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1814.045999999962,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 29.860999999999997,
      "layouts": 14,
      "layoutDurationMs": 4.164,
      "taskDurationMs": 883.5,
      "heapDeltaBytes": 12699348,
      "heapUsedBytes": 83425104,
      "domNodes": -280,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 162.25300000000001,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1750.8429999999748,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 16.93,
      "layouts": 6,
      "layoutDurationMs": 1.1440000000000001,
      "taskDurationMs": 367.00899999999996,
      "heapDeltaBytes": 4618128,
      "heapUsedBytes": 75751164,
      "domNodes": 74,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 11.964000000000002,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1662.341999999967,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 18.21,
      "layouts": 6,
      "layoutDurationMs": 0.9939999999999999,
      "taskDurationMs": 383.0330000000001,
      "heapDeltaBytes": 4584140,
      "heapUsedBytes": 75047668,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.296999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 692.1760000000177,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.937000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 456.8380000000001,
      "heapDeltaBytes": -7842540,
      "heapUsedBytes": 63174200,
      "domNodes": 18,
      "jsHeapTotalBytes": 6553600,
      "scriptDurationMs": 161.358,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 694.8940000000334,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 9.899000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 458.581,
      "heapDeltaBytes": -7469420,
      "heapUsedBytes": 63027580,
      "domNodes": 20,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 163.29,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.937999999993,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 12.93,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 666.4110000000001,
      "heapDeltaBytes": 9504860,
      "heapUsedBytes": 85435408,
      "domNodes": -268,
      "jsHeapTotalBytes": -892928,
      "scriptDurationMs": 41.611999999999995,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2050.4059999999527,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.554999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 663.282,
      "heapDeltaBytes": 6009432,
      "heapUsedBytes": 82713916,
      "domNodes": -278,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 33.79,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2433.954999999969,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 8.185999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1685.2739999999997,
      "heapDeltaBytes": 25939476,
      "heapUsedBytes": 92877056,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 833.538,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2520.8599999999706,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.695000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1774.5300000000002,
      "heapDeltaBytes": 3784908,
      "heapUsedBytes": 80515852,
      "domNodes": -284,
      "jsHeapTotalBytes": 1429504,
      "scriptDurationMs": 845.252,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3783.1540000000246,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 13.452000000000002,
      "layouts": 60,
      "layoutDurationMs": 12.874,
      "taskDurationMs": 1774.3319999999999,
      "heapDeltaBytes": 10941048,
      "heapUsedBytes": 89017524,
      "domNodes": 6,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 804.525,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3684.9070000000665,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 11.958999999999998,
      "layouts": 60,
      "layoutDurationMs": 11.786999999999999,
      "taskDurationMs": 1811.683,
      "heapDeltaBytes": -3045176,
      "heapUsedBytes": 75633884,
      "domNodes": -285,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 798.4910000000001,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3135.742999999991,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.922,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1979.149,
      "heapDeltaBytes": 25963532,
      "heapUsedBytes": 94214652,
      "domNodes": 0,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 983.5790000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3140.2930000000424,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.986999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1958.3780000000002,
      "heapDeltaBytes": 18454716,
      "heapUsedBytes": 85939804,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 959.469,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666696,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2005.077999999969,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 2.9539999999999984,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 562.121,
      "heapDeltaBytes": 21758156,
      "heapUsedBytes": 87696552,
      "domNodes": -272,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 36.52799999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2003.9179999999988,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 2.0859999999999976,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 555.26,
      "heapDeltaBytes": 21699284,
      "heapUsedBytes": 88379804,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 33.194,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 611.6859999999633,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.040999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.032,
      "heapDeltaBytes": 15034944,
      "heapUsedBytes": 88109180,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 147.867,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 589.334000000008,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.687999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 423.2939999999999,
      "heapDeltaBytes": 15019024,
      "heapUsedBytes": 87856312,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 147.319,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.1809999999796,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.051,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.842,
      "heapDeltaBytes": -3283784,
      "heapUsedBytes": 69616828,
      "domNodes": -295,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 9.171,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2036.7720000000418,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.93,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 504.988,
      "heapDeltaBytes": -5730976,
      "heapUsedBytes": 67484536,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.669,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1733.883999999989,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 28.35,
      "layouts": 18,
      "layoutDurationMs": 5.079000000000001,
      "taskDurationMs": 867.092,
      "heapDeltaBytes": 10263376,
      "heapUsedBytes": 82828832,
      "domNodes": -296,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 114.737,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1714.7820000000138,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 28.448,
      "layouts": 18,
      "layoutDurationMs": 4.74,
      "taskDurationMs": 856.395,
      "heapDeltaBytes": -5972604,
      "heapUsedBytes": 65763188,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 114.397,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1402.2960000000353,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 31.614000000000004,
      "layouts": 16,
      "layoutDurationMs": 15.550999999999998,
      "taskDurationMs": 949.2089999999997,
      "heapDeltaBytes": -5319188,
      "heapUsedBytes": 85028564,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 33.065999999999995,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8706.69700000002,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 38.071999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6089.7519999999995,
      "heapDeltaBytes": 8353336,
      "heapUsedBytes": 84432924,
      "domNodes": -271,
      "jsHeapTotalBytes": -405504,
      "scriptDurationMs": 2765.7400000000002,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8737.310999999976,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 36.894999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5969.525999999999,
      "heapDeltaBytes": 13250736,
      "heapUsedBytes": 89220996,
      "domNodes": -267,
      "jsHeapTotalBytes": -176128,
      "scriptDurationMs": 2738.849,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17951.05000000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17184.013,
      "heapDeltaBytes": -39094248,
      "heapUsedBytes": 178642308,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9732096,
      "scriptDurationMs": 300.22400000000005,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17778.425999999967,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17002.268999999997,
      "heapDeltaBytes": -59631912,
      "heapUsedBytes": 177860684,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19050496,
      "scriptDurationMs": 290.84299999999996,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21101.944000000003,
      "styleRecalcs": 161,
      "styleRecalcDurationMs": 18.606999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20749.022,
      "heapDeltaBytes": -25211172,
      "heapUsedBytes": 192056008,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10813440,
      "scriptDurationMs": 978.067,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 53,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20924.233999999957,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 19.47099999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20647.020999999997,
      "heapDeltaBytes": -27130916,
      "heapUsedBytes": 192638556,
      "domNodes": -8068,
      "jsHeapTotalBytes": -13606912,
      "scriptDurationMs": 959.665,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 76,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6422.857000000022,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 100.74499999999998,
      "layouts": 20,
      "layoutDurationMs": 25.678999999999995,
      "taskDurationMs": 6268.572,
      "heapDeltaBytes": -53222384,
      "heapUsedBytes": 179153220,
      "domNodes": -8068,
      "jsHeapTotalBytes": 2572288,
      "scriptDurationMs": 111.71099999999998,
      "eventListeners": -14926,
      "totalBlockingTimeMs": 431,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6300.648000000024,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.94100000000003,
      "layouts": 20,
      "layoutDurationMs": 21.84700000000002,
      "taskDurationMs": 6198.991999999999,
      "heapDeltaBytes": -41269932,
      "heapUsedBytes": 177049096,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10674176,
      "scriptDurationMs": 116.49299999999998,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 402,
      "frameDurationMs": 18.89333333333331,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8893.32300000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8523.979000000001,
      "heapDeltaBytes": 14792508,
      "heapUsedBytes": 176829928,
      "domNodes": 0,
      "jsHeapTotalBytes": -16777216,
      "scriptDurationMs": 171.03899999999993,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8725.897000000032,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8421.146999999999,
      "heapDeltaBytes": 19997748,
      "heapUsedBytes": 179148548,
      "domNodes": 0,
      "jsHeapTotalBytes": -10747904,
      "scriptDurationMs": 140.81500000000003,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 482.53299999998944,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 26.099999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.5330000000000004,
      "taskDurationMs": 121.643,
      "heapDeltaBytes": 4976068,
      "heapUsedBytes": 73218164,
      "domNodes": 145,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.902,
      "eventListeners": 65,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 450.26499999994485,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 20.568,
      "layouts": 3,
      "layoutDurationMs": 1.204,
      "taskDurationMs": 99.97800000000001,
      "heapDeltaBytes": 4856452,
      "heapUsedBytes": 73141756,
      "domNodes": 144,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 8.661999999999999,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 22, 2026
@christian-byrne
christian-byrne enabled auto-merge (squash) September 22, 2026 06:13
@christian-byrne
christian-byrne merged commit 9f211c8 into cloud/1.54 Sep 22, 2026
88 checks passed
@christian-byrne
christian-byrne deleted the backport-18078-to-cloud-1.54 branch September 22, 2026 06:30
@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18382   +/-   ##
=============================================
  Coverage              ?   78.52%           
=============================================
  Files                 ?     2006           
  Lines                 ?   110743           
  Branches              ?    33437           
=============================================
  Hits                  ?    86957           
  Misses                ?    23607           
  Partials              ?      179           
Flag Coverage Δ
unit 78.52% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../workbench/extensions/agent/crdt/mintPortWiring.ts 93.49% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants