Repository navigation
[backport cloud/1.54] fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch - #18382
Conversation
…ow tab switch Backport of #18078 to cloud/1.54. Serializes frontend-only nodes (Note, MarkdownNote, PrimitiveNode, Get/Set, subgraph blueprint hosts) with positional widgets_values before minting add_node, so the document applier no longer rejects them with uncatalogued_widget_write and the node survives a workflow tab switch.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1937 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-22T06:19:17.650Z",
"gitSha": "d0f193bce8f6a82a6a4c14e16bc40ea1a8308898",
"branch": "backport-18078-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2072.1849999999904,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.021999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.436,
"heapDeltaBytes": 3639248,
"heapUsedBytes": 74345224,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.463,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2028.6100000000147,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.440999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.599,
"heapDeltaBytes": -9721352,
"heapUsedBytes": 60526568,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.347999999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2011.0649999999737,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.998000000000005,
"layouts": 14,
"layoutDurationMs": 5.058,
"taskDurationMs": 1033.694,
"heapDeltaBytes": -4730036,
"heapUsedBytes": 65277256,
"domNodes": -282,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 187.21,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1814.045999999962,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.860999999999997,
"layouts": 14,
"layoutDurationMs": 4.164,
"taskDurationMs": 883.5,
"heapDeltaBytes": 12699348,
"heapUsedBytes": 83425104,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 162.25300000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1750.8429999999748,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.93,
"layouts": 6,
"layoutDurationMs": 1.1440000000000001,
"taskDurationMs": 367.00899999999996,
"heapDeltaBytes": 4618128,
"heapUsedBytes": 75751164,
"domNodes": 74,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.964000000000002,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1662.341999999967,
"styleRecalcs": 29,
"styleRecalcDurationMs": 18.21,
"layouts": 6,
"layoutDurationMs": 0.9939999999999999,
"taskDurationMs": 383.0330000000001,
"heapDeltaBytes": 4584140,
"heapUsedBytes": 75047668,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.296999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 692.1760000000177,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.937000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 456.8380000000001,
"heapDeltaBytes": -7842540,
"heapUsedBytes": 63174200,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 161.358,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 694.8940000000334,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.899000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.581,
"heapDeltaBytes": -7469420,
"heapUsedBytes": 63027580,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 163.29,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.937999999993,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.93,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 666.4110000000001,
"heapDeltaBytes": 9504860,
"heapUsedBytes": 85435408,
"domNodes": -268,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 41.611999999999995,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2050.4059999999527,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.554999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.282,
"heapDeltaBytes": 6009432,
"heapUsedBytes": 82713916,
"domNodes": -278,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 33.79,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2433.954999999969,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.185999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1685.2739999999997,
"heapDeltaBytes": 25939476,
"heapUsedBytes": 92877056,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 833.538,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2520.8599999999706,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.695000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1774.5300000000002,
"heapDeltaBytes": 3784908,
"heapUsedBytes": 80515852,
"domNodes": -284,
"jsHeapTotalBytes": 1429504,
"scriptDurationMs": 845.252,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3783.1540000000246,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.452000000000002,
"layouts": 60,
"layoutDurationMs": 12.874,
"taskDurationMs": 1774.3319999999999,
"heapDeltaBytes": 10941048,
"heapUsedBytes": 89017524,
"domNodes": 6,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 804.525,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3684.9070000000665,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.958999999999998,
"layouts": 60,
"layoutDurationMs": 11.786999999999999,
"taskDurationMs": 1811.683,
"heapDeltaBytes": -3045176,
"heapUsedBytes": 75633884,
"domNodes": -285,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 798.4910000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3135.742999999991,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.922,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1979.149,
"heapDeltaBytes": 25963532,
"heapUsedBytes": 94214652,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 983.5790000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3140.2930000000424,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.986999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1958.3780000000002,
"heapDeltaBytes": 18454716,
"heapUsedBytes": 85939804,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 959.469,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2005.077999999969,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.9539999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.121,
"heapDeltaBytes": 21758156,
"heapUsedBytes": 87696552,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.52799999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2003.9179999999988,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.0859999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.26,
"heapDeltaBytes": 21699284,
"heapUsedBytes": 88379804,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.194,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.6859999999633,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.040999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.032,
"heapDeltaBytes": 15034944,
"heapUsedBytes": 88109180,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 147.867,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.334000000008,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.687999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.2939999999999,
"heapDeltaBytes": 15019024,
"heapUsedBytes": 87856312,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 147.319,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2020.1809999999796,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.051,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.842,
"heapDeltaBytes": -3283784,
"heapUsedBytes": 69616828,
"domNodes": -295,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.171,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2036.7720000000418,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.93,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 504.988,
"heapDeltaBytes": -5730976,
"heapUsedBytes": 67484536,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.669,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1733.883999999989,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.35,
"layouts": 18,
"layoutDurationMs": 5.079000000000001,
"taskDurationMs": 867.092,
"heapDeltaBytes": 10263376,
"heapUsedBytes": 82828832,
"domNodes": -296,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 114.737,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1714.7820000000138,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.448,
"layouts": 18,
"layoutDurationMs": 4.74,
"taskDurationMs": 856.395,
"heapDeltaBytes": -5972604,
"heapUsedBytes": 65763188,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 114.397,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.2960000000353,
"styleRecalcs": 20,
"styleRecalcDurationMs": 31.614000000000004,
"layouts": 16,
"layoutDurationMs": 15.550999999999998,
"taskDurationMs": 949.2089999999997,
"heapDeltaBytes": -5319188,
"heapUsedBytes": 85028564,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 33.065999999999995,
"eventListeners": 2385,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8706.69700000002,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.071999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6089.7519999999995,
"heapDeltaBytes": 8353336,
"heapUsedBytes": 84432924,
"domNodes": -271,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 2765.7400000000002,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8737.310999999976,
"styleRecalcs": 248,
"styleRecalcDurationMs": 36.894999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5969.525999999999,
"heapDeltaBytes": 13250736,
"heapUsedBytes": 89220996,
"domNodes": -267,
"jsHeapTotalBytes": -176128,
"scriptDurationMs": 2738.849,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17951.05000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17184.013,
"heapDeltaBytes": -39094248,
"heapUsedBytes": 178642308,
"domNodes": -8068,
"jsHeapTotalBytes": -9732096,
"scriptDurationMs": 300.22400000000005,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17778.425999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17002.268999999997,
"heapDeltaBytes": -59631912,
"heapUsedBytes": 177860684,
"domNodes": -8068,
"jsHeapTotalBytes": -19050496,
"scriptDurationMs": 290.84299999999996,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21101.944000000003,
"styleRecalcs": 161,
"styleRecalcDurationMs": 18.606999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20749.022,
"heapDeltaBytes": -25211172,
"heapUsedBytes": 192056008,
"domNodes": -8068,
"jsHeapTotalBytes": -10813440,
"scriptDurationMs": 978.067,
"eventListeners": -14929,
"totalBlockingTimeMs": 53,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20924.233999999957,
"styleRecalcs": 174,
"styleRecalcDurationMs": 19.47099999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20647.020999999997,
"heapDeltaBytes": -27130916,
"heapUsedBytes": 192638556,
"domNodes": -8068,
"jsHeapTotalBytes": -13606912,
"scriptDurationMs": 959.665,
"eventListeners": -14929,
"totalBlockingTimeMs": 76,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6422.857000000022,
"styleRecalcs": 20,
"styleRecalcDurationMs": 100.74499999999998,
"layouts": 20,
"layoutDurationMs": 25.678999999999995,
"taskDurationMs": 6268.572,
"heapDeltaBytes": -53222384,
"heapUsedBytes": 179153220,
"domNodes": -8068,
"jsHeapTotalBytes": 2572288,
"scriptDurationMs": 111.71099999999998,
"eventListeners": -14926,
"totalBlockingTimeMs": 431,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6300.648000000024,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.94100000000003,
"layouts": 20,
"layoutDurationMs": 21.84700000000002,
"taskDurationMs": 6198.991999999999,
"heapDeltaBytes": -41269932,
"heapUsedBytes": 177049096,
"domNodes": -8068,
"jsHeapTotalBytes": 10674176,
"scriptDurationMs": 116.49299999999998,
"eventListeners": -14929,
"totalBlockingTimeMs": 402,
"frameDurationMs": 18.89333333333331,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8893.32300000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8523.979000000001,
"heapDeltaBytes": 14792508,
"heapUsedBytes": 176829928,
"domNodes": 0,
"jsHeapTotalBytes": -16777216,
"scriptDurationMs": 171.03899999999993,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8725.897000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8421.146999999999,
"heapDeltaBytes": 19997748,
"heapUsedBytes": 179148548,
"domNodes": 0,
"jsHeapTotalBytes": -10747904,
"scriptDurationMs": 140.81500000000003,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 482.53299999998944,
"styleRecalcs": 17,
"styleRecalcDurationMs": 26.099999999999998,
"layouts": 3,
"layoutDurationMs": 1.5330000000000004,
"taskDurationMs": 121.643,
"heapDeltaBytes": 4976068,
"heapUsedBytes": 73218164,
"domNodes": 145,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.902,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 450.26499999994485,
"styleRecalcs": 19,
"styleRecalcDurationMs": 20.568,
"layouts": 3,
"layoutDurationMs": 1.204,
"taskDurationMs": 99.97800000000001,
"heapDeltaBytes": 4856452,
"heapUsedBytes": 73141756,
"domNodes": 144,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.661999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18382 +/- ##
=============================================
Coverage ? 78.52%
=============================================
Files ? 2006
Lines ? 110743
Branches ? 33437
=============================================
Hits ? 86957
Misses ? 23607
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Requested by Christian Byrne · Slack thread
Backport of #18078 to
cloud/1.54.Summary
Before: With the Agent panel bound to a workflow, a user adds a Get/Set node (or any other frontend-registered node such as Note) or a subgraph blueprint to the canvas, switches to another workflow tab, and switches back. The node is gone. Nodes from the server's node catalog (KSampler, CLIPTextEncode) survive the same round trip.
After: The add of a frontend-only node or blueprint host lands in the document like any catalogued node's, so it survives the tab return.
serializeForMint(src/workbench/extensions/agent/crdt/mintPortWiring.ts) no longer rewrites a frontend-only node'swidgets_valuesinto the name-keyed object the document applier rejects for uncatalogued classes; it keeps the positional formserialize()already produced.Changes
963d1ee947179cf2124bead716610cf8e6fed52f(fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078) onto a new branch fromorigin/cloud/1.54. The fix itself (mintPortWiring.ts) and most of the new Vitest regression tests applied cleanly.mintPortWiring.test.tsandagentConversationHostDoc.tsconflicted becausecloud/1.54's copies (byte-identical tocore/1.54's) predate this PR's changes; both were resolved by combining the branch's existing content with fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078's additions (theapplyClient→applyWirerewrite inHostDoc, and the two new Note/blueprint mint cases in the unit test), with no logic invented beyond what fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078 wrote.agentAutogrowTabSwitchReconcile.spec.ts(already oncloud/1.54, untouched by fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078 onmainbecause an intervening, unbackported refactor already migrated it there) calledHostDoc.applyClient(...), which this PR renames toapplyWirewith a different return shape. Updated that one call site to the new{ result, update }shape with identical frame-send behavior; no test assertions changed.core/1.54backport ([backport core/1.54] fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18378), whose subject module/infra is checked and confirmed independently absent fromcloud/1.54(not part of fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078's own new work — each belongs to a separate, unrelated, unbackported main PR that this branch never got either):browser_tests/fixtures/agentConversationFixture.tsandbrowser_tests/fixtures/agentFollowerHostSocket.ts— the "replay recorded agent conversations" Playwright harness these belong to was added by BE-11470: test(agent): replay recorded agent conversations turn by turn #16764 and fix: Load3D preview capture stale after agent-driven model_file change (PM-1011) #17537, neither backported tocloud/1.54; their dependency chain (agentConversation.ts,agentReplayNodeDefs.ts,agentConversationExpectations.ts,agentReplayNodeContract.ts) is also absent. Porting them would mean re-implementing those unrelated PRs wholesale, so they were dropped along with the new spec that exclusively depends on them (agentHumanAddTabSwitch.spec.ts), its dedicated unit test (agentFollowerHostSocket.test.ts), the now-orphaned blueprint data file (agentHumanAddBlueprints.ts), and theTabSwitchLens/__tabSwitchLenstype addition inbrowser_tests/types/globals.d.tsthat only that spec used.browser_tests/tests/agent/agentPastedNodeOrphanedOnRetarget.spec.ts— this pre-existing spec (added by fix: pasted nodes reach the agent doc at the pasted position, not [10, 10] #18071, not oncloud/1.54) doesn't exist to receive fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078's one-linetest.use({ humanOpsHost: 'apply' })tweak, so there is nothing to apply it to.src/workbench/extensions/agent/crdt/agentCrdtProjection.tabReturn.test.ts— importsAgentCrdtProjectionfrom./agentCrdtProjection, a class introduced by the unrelated refactor refactor(agent): split CRDT follower layers #16908 ("split CRDT follower layers"), which is not oncloud/1.54. The sibling test that doesn't need that module,agentCrdtProjection.serializeDivergence.test.ts, was kept.workflowTabSwitchKeepsAddedNodes.spec.ts, the non-Agent baseline) and Vitest coverage (mintPortWiring.test.ts,agentCrdtProjection.serializeDivergence.test.ts,useAgentCrdtFollower.rejectedHumanAdd.test.ts,LGraph.tabSwitchSnapshot.test.ts) were kept as-is.Review Focus
mintPortWiring.tsis unconditional and applies exactly as onmain.agentAutogrowTabSwitchReconcile.spec.ts's adapted call site is mechanical (same two frames sent in the same order); worth a second look given it wasn't part of fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078's own diff.Local verification
pnpm vitest run src/workbench/extensions/agent: 1732 passed, 4 expected fail, 3 failed. All 3 failures (AgentPanelRoot.test.ts"Media-card" attach/upload cases) confirmed pre-existing by running the same file against unmodifiedorigin/cloud/1.54, where they fail identically.pnpm lint,pnpm typecheck,pnpm typecheck:browser: all clean (ran automatically via the pre-commit hook).pnpm format:check(oxfmt) on changed files: clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc
Generated by Claude Code