Repository navigation
[backport core/1.54] fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch - #18378
Conversation
…ow tab switch Backport of #18078 to core/1.54. Serializes frontend-only nodes (Note, MarkdownNote, PrimitiveNode, Get/Set, subgraph blueprint hosts) with positional widgets_values before minting add_node, so the document applier no longer rejects them with uncatalogued_widget_write and the node survives a workflow tab switch.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1938 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T05:53:36.875Z",
"gitSha": "f19fc26babda331be23584b44bbbba0a0b39c5c6",
"branch": "backport-18078-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2090.1100000000097,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.471,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.808,
"heapDeltaBytes": 4722748,
"heapUsedBytes": 75203340,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.719,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2022.8740000000016,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.100999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.375,
"heapDeltaBytes": -10802296,
"heapUsedBytes": 58224324,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.274000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1889.509999999973,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.660000000000004,
"layouts": 14,
"layoutDurationMs": 4.341,
"taskDurationMs": 876.8659999999999,
"heapDeltaBytes": -4204388,
"heapUsedBytes": 66800844,
"domNodes": -280,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 164.335,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1857.7190000000314,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.009,
"layouts": 14,
"layoutDurationMs": 3.87,
"taskDurationMs": 854.3700000000001,
"heapDeltaBytes": -12963760,
"heapUsedBytes": 57339372,
"domNodes": -280,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 158.736,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1755.2299999999832,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.2,
"layouts": 6,
"layoutDurationMs": 1.0739999999999998,
"taskDurationMs": 370.43899999999996,
"heapDeltaBytes": 4397404,
"heapUsedBytes": 74282544,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.294000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1660.886000000005,
"styleRecalcs": 29,
"styleRecalcDurationMs": 14.967,
"layouts": 6,
"layoutDurationMs": 0.9530000000000001,
"taskDurationMs": 340.181,
"heapDeltaBytes": 4619968,
"heapUsedBytes": 75695752,
"domNodes": 76,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 10.056,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 643.3780000000411,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.336000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.77199999999993,
"heapDeltaBytes": 18090592,
"heapUsedBytes": 88183204,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 162.988,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 632.3150000000055,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.720000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.826,
"heapDeltaBytes": 17781736,
"heapUsedBytes": 88247480,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 159.997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2037.8499999999917,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.2170000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.56,
"heapDeltaBytes": 10534952,
"heapUsedBytes": 86545856,
"domNodes": -266,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 37.745,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2031.89900000001,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.643999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.619,
"heapDeltaBytes": 11523612,
"heapUsedBytes": 87446792,
"domNodes": -272,
"jsHeapTotalBytes": -1417216,
"scriptDurationMs": 34.71000000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2194.4129999999973,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.635000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1600.7520000000002,
"heapDeltaBytes": 19048368,
"heapUsedBytes": 84945188,
"domNodes": -270,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 805.341,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2223.8059999999678,
"styleRecalcs": 62,
"styleRecalcDurationMs": 7.157,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1588.399,
"heapDeltaBytes": 17884984,
"heapUsedBytes": 84322748,
"domNodes": 0,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 818.0849999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3539.23199999997,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.478,
"layouts": 60,
"layoutDurationMs": 11.705000000000002,
"taskDurationMs": 1725.9860000000003,
"heapDeltaBytes": -11720412,
"heapUsedBytes": 66261856,
"domNodes": -285,
"jsHeapTotalBytes": 1990656,
"scriptDurationMs": 759.966,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3504.780000000096,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.652,
"layouts": 60,
"layoutDurationMs": 11.84,
"taskDurationMs": 1711.0020000000002,
"heapDeltaBytes": 14746880,
"heapUsedBytes": 93456868,
"domNodes": -288,
"jsHeapTotalBytes": 3301376,
"scriptDurationMs": 768.4499999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3101.831000000004,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.560000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1898.219,
"heapDeltaBytes": 22149940,
"heapUsedBytes": 89690384,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 938.3389999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3081.9340000000466,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.52,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1903.9990000000003,
"heapDeltaBytes": 20544096,
"heapUsedBytes": 87950056,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 941.326,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.9110000000032,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.536000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.183,
"heapDeltaBytes": 10138240,
"heapUsedBytes": 87803252,
"domNodes": -271,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 31.380999999999993,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2013.9299999999594,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.022999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.3850000000001,
"heapDeltaBytes": 21852404,
"heapUsedBytes": 87643672,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.349,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 620.755000000031,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.778999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.772,
"heapDeltaBytes": 14711912,
"heapUsedBytes": 87641172,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 143.72000000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 591.4679999999635,
"styleRecalcs": 47,
"styleRecalcDurationMs": 9.852,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.834,
"heapDeltaBytes": 14500604,
"heapUsedBytes": 86271236,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 139.925,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2016.7219999999588,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.8340000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.553,
"heapDeltaBytes": -15084972,
"heapUsedBytes": 57945400,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.7540000000000004,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.6869999999758,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.889,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.5659999999999,
"heapDeltaBytes": -9028836,
"heapUsedBytes": 63282572,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.092999999999998,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.6639999999697,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.464,
"layouts": 18,
"layoutDurationMs": 5.186,
"taskDurationMs": 741.746,
"heapDeltaBytes": 20397100,
"heapUsedBytes": 85083288,
"domNodes": 35,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 107.69800000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.4730000000222,
"styleRecalcs": 76,
"styleRecalcDurationMs": 26.088,
"layouts": 18,
"layoutDurationMs": 5.159999999999999,
"taskDurationMs": 803.95,
"heapDeltaBytes": -5693948,
"heapUsedBytes": 67225912,
"domNodes": -294,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 109.99300000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.3510000000047,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.706999999999994,
"layouts": 15,
"layoutDurationMs": 15.455999999999998,
"taskDurationMs": 899.5160000000002,
"heapDeltaBytes": 20064112,
"heapUsedBytes": 104078616,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 30.820999999999994,
"eventListeners": 2387,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8956.244000000026,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.259,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6081.763000000001,
"heapDeltaBytes": 4705680,
"heapUsedBytes": 80530876,
"domNodes": -277,
"jsHeapTotalBytes": -405504,
"scriptDurationMs": 2762.822,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8324.008000000049,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.062999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5714.360999999999,
"heapDeltaBytes": 8473636,
"heapUsedBytes": 84788564,
"domNodes": -266,
"jsHeapTotalBytes": -1716224,
"scriptDurationMs": 2677.191,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17683.721999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17045.066000000003,
"heapDeltaBytes": -58732080,
"heapUsedBytes": 178358696,
"domNodes": -8068,
"jsHeapTotalBytes": -18788352,
"scriptDurationMs": 313.933,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16664.62999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16083.24,
"heapDeltaBytes": -54530008,
"heapUsedBytes": 178427684,
"domNodes": -8068,
"jsHeapTotalBytes": -12525568,
"scriptDurationMs": 250.59799999999998,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20965.125999999997,
"styleRecalcs": 171,
"styleRecalcDurationMs": 18.328999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20557.095999999998,
"heapDeltaBytes": -19055196,
"heapUsedBytes": 192414972,
"domNodes": -8068,
"jsHeapTotalBytes": -19382272,
"scriptDurationMs": 931.195,
"eventListeners": -14929,
"totalBlockingTimeMs": 192,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21001.322000000073,
"styleRecalcs": 176,
"styleRecalcDurationMs": 17.484000000000055,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20524.171,
"heapDeltaBytes": -59406528,
"heapUsedBytes": 168739188,
"domNodes": -8068,
"jsHeapTotalBytes": -18370560,
"scriptDurationMs": 938.5540000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 61,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6116.065000000049,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.322,
"layouts": 20,
"layoutDurationMs": 21.099000000000007,
"taskDurationMs": 6004.167,
"heapDeltaBytes": -36269044,
"heapUsedBytes": 182176296,
"domNodes": -8068,
"jsHeapTotalBytes": 17551360,
"scriptDurationMs": 107.092,
"eventListeners": -14929,
"totalBlockingTimeMs": 409,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6197.6470000000745,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.66500000000003,
"layouts": 20,
"layoutDurationMs": 21.228000000000012,
"taskDurationMs": 6077.128000000001,
"heapDeltaBytes": -56290788,
"heapUsedBytes": 182692772,
"domNodes": -8068,
"jsHeapTotalBytes": 10833920,
"scriptDurationMs": 108.913,
"eventListeners": -14927,
"totalBlockingTimeMs": 386,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8426.340999999979,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8198.61,
"heapDeltaBytes": 16185660,
"heapUsedBytes": 180594888,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 149.61799999999997,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8961.580000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8475.024,
"heapDeltaBytes": 11492884,
"heapUsedBytes": 192354244,
"domNodes": 0,
"jsHeapTotalBytes": -25427968,
"scriptDurationMs": 139.86700000000002,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 98.85300000001962,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.476,
"layouts": 2,
"layoutDurationMs": 1.302,
"taskDurationMs": 73.182,
"heapDeltaBytes": 3018628,
"heapUsedBytes": 71367792,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.834000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 113.04299999994782,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.253000000000002,
"layouts": 2,
"layoutDurationMs": 0.801,
"taskDurationMs": 73.33,
"heapDeltaBytes": 3007780,
"heapUsedBytes": 72118596,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.027,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18378 +/- ##
==========================================
Coverage 83.55% 83.55%
==========================================
Files 2094 2094
Lines 123520 123523 +3
Branches 33296 33297 +1
==========================================
+ Hits 103202 103206 +4
+ Misses 20139 20138 -1
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
… nodes across a workflow tab switch (#18382) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789709550015299?thread_ts=1789709550.015299&cid=C0BGH348Z0C)_ Backport of #18078 to `cloud/1.54`. ## Summary **Before:** With the Agent panel bound to a workflow, a user adds a Get/Set node (or any other frontend-registered node such as Note) or a subgraph blueprint to the canvas, switches to another workflow tab, and switches back. The node is gone. Nodes from the server's node catalog (KSampler, CLIPTextEncode) survive the same round trip. **After:** The add of a frontend-only node or blueprint host lands in the document like any catalogued node's, so it survives the tab return. `serializeForMint` (`src/workbench/extensions/agent/crdt/mintPortWiring.ts`) no longer rewrites a frontend-only node's `widgets_values` into the name-keyed object the document applier rejects for uncatalogued classes; it keeps the positional form `serialize()` already produced. ## Changes - **What**: Cherry-picked the squash-merge commit `963d1ee947179cf2124bead716610cf8e6fed52f` (#18078) onto a new branch from `origin/cloud/1.54`. The fix itself (`mintPortWiring.ts`) and most of the new Vitest regression tests applied cleanly. - **Conflicts resolved faithfully**: `mintPortWiring.test.ts` and `agentConversationHostDoc.ts` conflicted because `cloud/1.54`'s copies (byte-identical to `core/1.54`'s) predate this PR's changes; both were resolved by combining the branch's existing content with #18078's additions (the `applyClient` → `applyWire` rewrite in `HostDoc`, and the two new Note/blueprint mint cases in the unit test), with no logic invented beyond what #18078 wrote. - **Adapted one pre-existing call site**: `agentAutogrowTabSwitchReconcile.spec.ts` (already on `cloud/1.54`, untouched by #18078 on `main` because an intervening, unbackported refactor already migrated it there) called `HostDoc.applyClient(...)`, which this PR renames to `applyWire` with a different return shape. Updated that one call site to the new `{ result, update }` shape with identical frame-send behavior; no test assertions changed. - **Omitted the same three files as the `core/1.54` backport (#18378), whose subject module/infra is checked and confirmed independently absent from `cloud/1.54`** (not part of #18078's own new work — each belongs to a separate, unrelated, unbackported main PR that this branch never got either): - `browser_tests/fixtures/agentConversationFixture.ts` and `browser_tests/fixtures/agentFollowerHostSocket.ts` — the "replay recorded agent conversations" Playwright harness these belong to was added by #16764 and #17537, neither backported to `cloud/1.54`; their dependency chain (`agentConversation.ts`, `agentReplayNodeDefs.ts`, `agentConversationExpectations.ts`, `agentReplayNodeContract.ts`) is also absent. Porting them would mean re-implementing those unrelated PRs wholesale, so they were dropped along with the new spec that exclusively depends on them (`agentHumanAddTabSwitch.spec.ts`), its dedicated unit test (`agentFollowerHostSocket.test.ts`), the now-orphaned blueprint data file (`agentHumanAddBlueprints.ts`), and the `TabSwitchLens`/`__tabSwitchLens` type addition in `browser_tests/types/globals.d.ts` that only that spec used. - `browser_tests/tests/agent/agentPastedNodeOrphanedOnRetarget.spec.ts` — this pre-existing spec (added by #18071, not on `cloud/1.54`) doesn't exist to receive #18078's one-line `test.use({ humanOpsHost: 'apply' })` tweak, so there is nothing to apply it to. - `src/workbench/extensions/agent/crdt/agentCrdtProjection.tabReturn.test.ts` — imports `AgentCrdtProjection` from `./agentCrdtProjection`, a class introduced by the unrelated refactor #16908 ("split CRDT follower layers"), which is not on `cloud/1.54`. The sibling test that doesn't need that module, `agentCrdtProjection.serializeDivergence.test.ts`, was kept. - The still-applicable e2e coverage (`workflowTabSwitchKeepsAddedNodes.spec.ts`, the non-Agent baseline) and Vitest coverage (`mintPortWiring.test.ts`, `agentCrdtProjection.serializeDivergence.test.ts`, `useAgentCrdtFollower.rejectedHumanAdd.test.ts`, `LGraph.tabSwitchSnapshot.test.ts`) were kept as-is. ## Review Focus - The three omissions above are infra/coverage gaps caused by branch divergence, not behavior changes — the production fix in `mintPortWiring.ts` is unconditional and applies exactly as on `main`. - `agentAutogrowTabSwitchReconcile.spec.ts`'s adapted call site is mechanical (same two frames sent in the same order); worth a second look given it wasn't part of #18078's own diff. ## Local verification - `pnpm vitest run src/workbench/extensions/agent`: 1732 passed, 4 expected fail, 3 failed. All 3 failures (`AgentPanelRoot.test.ts` "Media-card" attach/upload cases) confirmed pre-existing by running the same file against unmodified `origin/cloud/1.54`, where they fail identically. - `pnpm lint`, `pnpm typecheck`, `pnpm typecheck:browser`: all clean (ran automatically via the pre-commit hook). - `pnpm format:check` (oxfmt) on changed files: clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc --- _Generated by [Claude Code](https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc)_ Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
Requested by Christian Byrne · Slack thread
Backport of #18078 to
core/1.54.Summary
Before: With the Agent panel bound to a workflow, a user adds a Get/Set node (or any other frontend-registered node such as Note) or a subgraph blueprint to the canvas, switches to another workflow tab, and switches back. The node is gone. Nodes from the server's node catalog (KSampler, CLIPTextEncode) survive the same round trip.
After: The add of a frontend-only node or blueprint host lands in the document like any catalogued node's, so it survives the tab return.
serializeForMint(src/workbench/extensions/agent/crdt/mintPortWiring.ts) no longer rewrites a frontend-only node'swidgets_valuesinto the name-keyed object the document applier rejects for uncatalogued classes; it keeps the positional formserialize()already produced.Changes
963d1ee947179cf2124bead716610cf8e6fed52f(fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078) onto a new branch fromorigin/core/1.54. The fix itself (mintPortWiring.ts) and most of the new Vitest regression tests applied cleanly.mintPortWiring.test.tsandagentConversationHostDoc.tsconflicted becausecore/1.54's copies predate this PR's changes; both were resolved by combiningcore/1.54's existing content with fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078's additions (theapplyClient→applyWirerewrite inHostDoc, and the two new Note/blueprint mint cases in the unit test), with no logic invented beyond what fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078 wrote.agentAutogrowTabSwitchReconcile.spec.ts(already oncore/1.54, untouched by fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078 onmainbecause an intervening, unbackported refactor already migrated it there) calledHostDoc.applyClient(...), which this PR renames toapplyWirewith a different return shape. Updated that one call site to the new{ result, update }shape with identical frame-send behavior; no test assertions changed.core/1.54(not part of fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078's own new work — each belongs to a separate, unrelated, unbackported main PR that this branch never got):browser_tests/fixtures/agentConversationFixture.tsandbrowser_tests/fixtures/agentFollowerHostSocket.ts— the "replay recorded agent conversations" Playwright harness these belong to was added by BE-11470: test(agent): replay recorded agent conversations turn by turn #16764 and fix: Load3D preview capture stale after agent-driven model_file change (PM-1011) #17537, neither backported tocore/1.54; their dependency chain (agentConversation.ts,agentReplayNodeDefs.ts,agentConversationExpectations.ts,agentReplayNodeContract.ts) is also absent. Porting them would mean re-implementing those unrelated PRs wholesale, so they were dropped along with the new spec that exclusively depends on them (agentHumanAddTabSwitch.spec.ts), its dedicated unit test (agentFollowerHostSocket.test.ts), and the now-orphaned blueprint data file (agentHumanAddBlueprints.ts) and theTabSwitchLens/__tabSwitchLenstype addition inbrowser_tests/types/globals.d.tsthat only that spec used.browser_tests/tests/agent/agentPastedNodeOrphanedOnRetarget.spec.ts— this pre-existing spec (added by fix: pasted nodes reach the agent doc at the pasted position, not [10, 10] #18071, not oncore/1.54) doesn't exist to receive fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078's one-linetest.use({ humanOpsHost: 'apply' })tweak, so there is nothing to apply it to.src/workbench/extensions/agent/crdt/agentCrdtProjection.tabReturn.test.ts— importsAgentCrdtProjectionfrom./agentCrdtProjection, a class introduced by the unrelated refactor refactor(agent): split CRDT follower layers #16908 ("split CRDT follower layers"), which is not oncore/1.54. The sibling test that doesn't need that module,agentCrdtProjection.serializeDivergence.test.ts, was kept.workflowTabSwitchKeepsAddedNodes.spec.ts, the non-Agent baseline) and Vitest coverage (mintPortWiring.test.ts,agentCrdtProjection.serializeDivergence.test.ts,useAgentCrdtFollower.rejectedHumanAdd.test.ts,LGraph.tabSwitchSnapshot.test.ts) were kept as-is.Review Focus
mintPortWiring.tsis unconditional and applies exactly as onmain.agentAutogrowTabSwitchReconcile.spec.ts's adapted call site is mechanical (same two frames sent in the same order); worth a second look given it wasn't part of fix(agent-crdt): keep human-added frontend-only nodes across a workflow tab switch #18078's own diff.Local verification
pnpm vitest run src/workbench/extensions/agent: 1697 passed, 4 expected fail, 4 failed. 3 of the 4 failures (AgentPanelRoot.test.ts"Media-card" attach/upload cases) confirmed pre-existing by running the same file against unmodifiedorigin/core/1.54. The 4th (Composer.test.ts"closes when the caret moves out of the token") passes when run in isolation on this branch and passed on unmodifiedorigin/core/1.54; it is a pre-existing flake unrelated to this change (the file is untouched by this backport).pnpm lint,pnpm typecheck,pnpm typecheck:browser: all clean (ran automatically via the pre-commit hook).pnpm format:check(oxfmt) on changed files: clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01NQVcfKhCKjLstqo3mJS7fc
Generated by Claude Code