Repository navigation
fix(agent-crdt): preserve restored same-document subscription - #16849
Conversation
📦 Bundle: 9.41 MB gzip 🔴 +6 BDetailsSummary
Category Glance App Entry Points — 5.36 kB (baseline 5.36 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.16 MB (baseline 2.16 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 669 kB (baseline 669 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 29 unchanged User & Accounts — 61.2 kB (baseline 61.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 15 unchanged Editors & Dialogs — 341 kB (baseline 341 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 211 kB (baseline 211 kB) • ⚪ 0 BReusable component library chunks Status: 24 unchanged Data & Services — 1.36 MB (baseline 1.36 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 25 unchanged Utilities & Hooks — 2.29 MB (baseline 2.29 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 62 unchanged Vendor & Third-Party — 14.3 MB (baseline 14.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 19 MB (baseline 19 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 351 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-12T09:02:17.342Z",
"gitSha": "038525d4ea2668c5e01b532a38a5af3781d1fd6e",
"branch": "christian-byrne/qax32-same-document-ack-recovery",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.9760000000183,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.660000000000001,
"layouts": 11,
"layoutDurationMs": 2.733,
"taskDurationMs": 356.377,
"heapDeltaBytes": -2229716,
"heapUsedBytes": 65663636,
"domNodes": -162,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.735000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-idle",
"durationMs": 2009.2600000000402,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.468999999999999,
"layouts": 11,
"layoutDurationMs": 3.0319999999999996,
"taskDurationMs": 396.51800000000003,
"heapDeltaBytes": -1969940,
"heapUsedBytes": 65799456,
"domNodes": -162,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.051999999999998,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1695.2249999999935,
"styleRecalcs": 72,
"styleRecalcDurationMs": 15.248999999999999,
"layouts": 12,
"layoutDurationMs": 2.974,
"taskDurationMs": 638.736,
"heapDeltaBytes": -369032,
"heapUsedBytes": 67318740,
"domNodes": -162,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 113.119,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1762.207999999987,
"styleRecalcs": 71,
"styleRecalcDurationMs": 17.497,
"layouts": 12,
"layoutDurationMs": 2.994,
"taskDurationMs": 743.643,
"heapDeltaBytes": 5125952,
"heapUsedBytes": 72685236,
"domNodes": -162,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 143.21099999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66698113207547,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.0869999999777,
"styleRecalcs": 18,
"styleRecalcDurationMs": 7.235,
"layouts": 13,
"layoutDurationMs": 3.662,
"taskDurationMs": 290.18399999999997,
"heapDeltaBytes": 19261988,
"heapUsedBytes": 86945508,
"domNodes": 47,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 12.292000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475724,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.3750000000227,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.737,
"layouts": 13,
"layoutDurationMs": 3.2500000000000004,
"taskDurationMs": 282.79,
"heapDeltaBytes": 18972868,
"heapUsedBytes": 86713744,
"domNodes": 47,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.867,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 543.5789999999656,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.320000000000001,
"layouts": 11,
"layoutDurationMs": 3.039,
"taskDurationMs": 339.53,
"heapDeltaBytes": 347728,
"heapUsedBytes": 68027220,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 113.41900000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 460.3370000000382,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.396000000000001,
"layouts": 11,
"layoutDurationMs": 2.6420000000000003,
"taskDurationMs": 308.32499999999993,
"heapDeltaBytes": 373252,
"heapUsedBytes": 68135436,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 106.704,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428571,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 976.0750000000371,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.502,
"heapDeltaBytes": -11352608,
"heapUsedBytes": 81468220,
"domNodes": -192,
"jsHeapTotalBytes": 19406848,
"scriptDurationMs": 48.877,
"eventListeners": -106,
"totalBlockingTimeMs": 330,
"frameDurationMs": 27.31666666666667,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 913.490999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.665,
"heapDeltaBytes": -12489380,
"heapUsedBytes": 80737276,
"domNodes": -192,
"jsHeapTotalBytes": 22028288,
"scriptDurationMs": 41.69800000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 285,
"frameDurationMs": 26.958823529411763,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 719.4400000000201,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 298.83000000000015,
"heapDeltaBytes": -4676096,
"heapUsedBytes": 75356504,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 102.12900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 99,
"frameDurationMs": 21.079411764705878,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 719.2770000000337,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 304.284,
"heapDeltaBytes": -5569304,
"heapUsedBytes": 74277276,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 97.50999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 94,
"frameDurationMs": 20.474285714285724,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6637.081999999992,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.5399999999999996,
"layouts": 4,
"layoutDurationMs": 1.2179999999999995,
"taskDurationMs": 5501.811999999999,
"heapDeltaBytes": -18068904,
"heapUsedBytes": 77126816,
"domNodes": -258,
"jsHeapTotalBytes": 5894144,
"scriptDurationMs": 4256.2660000000005,
"eventListeners": -67,
"totalBlockingTimeMs": 15,
"frameDurationMs": 20.990822784810128,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6351.743999999997,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.576000000000001,
"layouts": 4,
"layoutDurationMs": 1.2179999999999995,
"taskDurationMs": 5184.178,
"heapDeltaBytes": 34297088,
"heapUsedBytes": 114114496,
"domNodes": -258,
"jsHeapTotalBytes": 13758464,
"scriptDurationMs": 4149.99,
"eventListeners": -67,
"totalBlockingTimeMs": 1,
"frameDurationMs": 21.379461279461278,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6388.546000000019,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.419999999999998,
"layouts": 5,
"layoutDurationMs": 1.2140000000000002,
"taskDurationMs": 5233.369,
"heapDeltaBytes": 8212672,
"heapUsedBytes": 87365712,
"domNodes": -258,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 4008.1499999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 26,
"frameDurationMs": 20.458653846153844,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6567.4140000000425,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2920000000000007,
"layouts": 4,
"layoutDurationMs": 0.9809999999999997,
"taskDurationMs": 5403.449,
"heapDeltaBytes": 8224796,
"heapUsedBytes": 88477048,
"domNodes": -258,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 4237.946,
"eventListeners": -68,
"totalBlockingTimeMs": 22,
"frameDurationMs": 20.45607476635514,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 148.78299999998035,
"styleRecalcs": 22,
"styleRecalcDurationMs": 13.474,
"layouts": 13,
"layoutDurationMs": 3.1989999999999994,
"taskDurationMs": 111.519,
"heapDeltaBytes": -12718928,
"heapUsedBytes": 79366744,
"domNodes": 917,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.2989999999999995,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.75,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "large-combo-open",
"durationMs": 151.23599999998305,
"styleRecalcs": 21,
"styleRecalcDurationMs": 13.453999999999999,
"layouts": 12,
"layoutDurationMs": 3.047,
"taskDurationMs": 108.683,
"heapDeltaBytes": -8498864,
"heapUsedBytes": 86290144,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6.135,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.44285714285713,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-graph-idle",
"durationMs": 2007.3189999999954,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.521000000000001,
"layouts": 10,
"layoutDurationMs": 2.657,
"taskDurationMs": 445.419,
"heapDeltaBytes": -2519812,
"heapUsedBytes": 81048160,
"domNodes": -258,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 34.44800000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2026.85299999996,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.4229999999999996,
"layouts": 11,
"layoutDurationMs": 2.0480000000000005,
"taskDurationMs": 375.66800000000006,
"heapDeltaBytes": -2059436,
"heapUsedBytes": 82565180,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 23.009999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2869.29200000003,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.496,
"layouts": 8,
"layoutDurationMs": 1.981,
"taskDurationMs": 1286.5,
"heapDeltaBytes": 2674644,
"heapUsedBytes": 87968416,
"domNodes": -258,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 612.784,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666279069767445,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-pan",
"durationMs": 2164.843000000019,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.625000000000001,
"layouts": 11,
"layoutDurationMs": 2.429,
"taskDurationMs": 1077.7379999999998,
"heapDeltaBytes": -866336,
"heapUsedBytes": 84454972,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 535.601,
"eventListeners": -65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665891472868214,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3812.3879999999986,
"styleRecalcs": 73,
"styleRecalcDurationMs": 10.337999999999997,
"layouts": 67,
"layoutDurationMs": 13.437999999999999,
"taskDurationMs": 1392.7450000000001,
"heapDeltaBytes": 11841344,
"heapUsedBytes": 90435472,
"domNodes": -234,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 582.317,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66593886462882,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3157.4190000000044,
"styleRecalcs": 74,
"styleRecalcDurationMs": 9.755999999999998,
"layouts": 68,
"layoutDurationMs": 12.381,
"taskDurationMs": 1201.354,
"heapDeltaBytes": -15316976,
"heapUsedBytes": 71345944,
"domNodes": -234,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 562.703,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666315789473686,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2772.6749999999925,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.760000000000002,
"layouts": 8,
"layoutDurationMs": 2.408,
"taskDurationMs": 1477.535,
"heapDeltaBytes": 13145440,
"heapUsedBytes": 100865972,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 728.3850000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665868263473055,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2301.4800000000264,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.678999999999999,
"layouts": 8,
"layoutDurationMs": 1.9819999999999993,
"taskDurationMs": 1279.914,
"heapDeltaBytes": 2204160,
"heapUsedBytes": 83421160,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 644.808,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.3360000000102,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.457,
"layouts": 9,
"layoutDurationMs": 2.6670000000000007,
"taskDurationMs": 429.00399999999996,
"heapDeltaBytes": 13535448,
"heapUsedBytes": 90990828,
"domNodes": -258,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 29.554000000000006,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.4990000000198,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1660000000000004,
"layouts": 10,
"layoutDurationMs": 1.8489999999999998,
"taskDurationMs": 372.36199999999997,
"heapDeltaBytes": 4681792,
"heapUsedBytes": 84527484,
"domNodes": -258,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 24.586,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 514.9729999999977,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.121,
"layouts": 12,
"layoutDurationMs": 3.1399999999999997,
"taskDurationMs": 323.884,
"heapDeltaBytes": 51564,
"heapUsedBytes": 76714512,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 103.849,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66774193548388,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 476.62800000000516,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.706000000000001,
"layouts": 11,
"layoutDurationMs": 2.9050000000000002,
"taskDurationMs": 306.342,
"heapDeltaBytes": 2969680,
"heapUsedBytes": 85125236,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 99.84,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241382,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2010.6869999999617,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.8260000000000005,
"layouts": 11,
"layoutDurationMs": 2.284,
"taskDurationMs": 385.18600000000004,
"heapDeltaBytes": 838200,
"heapUsedBytes": 68802612,
"domNodes": -180,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.534999999999998,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2005.724999999984,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.327999999999999,
"layouts": 12,
"layoutDurationMs": 3.037,
"taskDurationMs": 384.599,
"heapDeltaBytes": -7845604,
"heapUsedBytes": 69753388,
"domNodes": -180,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 8.491,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.9199999999914,
"styleRecalcs": 75,
"styleRecalcDurationMs": 18.346,
"layouts": 12,
"layoutDurationMs": 3.481,
"taskDurationMs": 669.8890000000001,
"heapDeltaBytes": -1909436,
"heapUsedBytes": 66030088,
"domNodes": -172,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 95.774,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664705882352937,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1691.2189999999896,
"styleRecalcs": 75,
"styleRecalcDurationMs": 17.509,
"layouts": 12,
"layoutDurationMs": 2.9920000000000004,
"taskDurationMs": 587.9720000000001,
"heapDeltaBytes": -8098092,
"heapUsedBytes": 69287876,
"domNodes": -172,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 80.803,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 866.561000000047,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.755999999999997,
"layouts": 5,
"layoutDurationMs": 10.507000000000003,
"taskDurationMs": 685.6560000000001,
"heapDeltaBytes": 33564764,
"heapUsedBytes": 119884952,
"domNodes": 15956,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 22.323000000000004,
"eventListeners": 3244,
"totalBlockingTimeMs": 93,
"frameDurationMs": 20.151162790697676,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 8324.275,
"styleRecalcs": 251,
"styleRecalcDurationMs": 26.474999999999998,
"layouts": 10,
"layoutDurationMs": 2.6899999999999995,
"taskDurationMs": 4057.7419999999993,
"heapDeltaBytes": -14169416,
"heapUsedBytes": 68858852,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 2047.2349999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8437.581000000024,
"styleRecalcs": 251,
"styleRecalcDurationMs": 24.186,
"layouts": 10,
"layoutDurationMs": 2.229,
"taskDurationMs": 3975.787,
"heapDeltaBytes": -16670108,
"heapUsedBytes": 67647928,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 1886.19,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581027667984,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17070.738000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16459.053,
"heapDeltaBytes": -31803744,
"heapUsedBytes": 261472296,
"domNodes": -307,
"jsHeapTotalBytes": 1228800,
"scriptDurationMs": 224.561,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.887915936952716,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 16487.65400000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15569.052,
"heapDeltaBytes": -17462576,
"heapUsedBytes": 288801380,
"domNodes": -3330,
"jsHeapTotalBytes": 7397376,
"scriptDurationMs": 248.50399999999996,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.20393162393163,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 19143.13199999998,
"styleRecalcs": 148,
"styleRecalcDurationMs": 15.348999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18820.411,
"heapDeltaBytes": -14976,
"heapUsedBytes": 273390612,
"domNodes": -307,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 687.5029999999999,
"eventListeners": -5,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.659590316573556,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 19019.43200000005,
"styleRecalcs": 148,
"styleRecalcDurationMs": 14.55300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18668.833,
"heapDeltaBytes": -21562540,
"heapUsedBytes": 269313888,
"domNodes": -3330,
"jsHeapTotalBytes": 2043904,
"scriptDurationMs": 647.954,
"eventListeners": -651,
"totalBlockingTimeMs": 20,
"frameDurationMs": 35.279962894248605,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6439.323000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.15,
"layouts": 20,
"layoutDurationMs": 24.78899999999999,
"taskDurationMs": 6347.831,
"heapDeltaBytes": -50028544,
"heapUsedBytes": 252301312,
"domNodes": -3330,
"jsHeapTotalBytes": -1585152,
"scriptDurationMs": 95.52999999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.760571428571424,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6062.649000000079,
"styleRecalcs": 20,
"styleRecalcDurationMs": 47.397999999999996,
"layouts": 20,
"layoutDurationMs": 21.307999999999993,
"taskDurationMs": 5915.57,
"heapDeltaBytes": -19883616,
"heapUsedBytes": 282766924,
"domNodes": -307,
"jsHeapTotalBytes": 3850240,
"scriptDurationMs": 86.85,
"eventListeners": -7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.06531791907514,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8442.791,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8118.8,
"heapDeltaBytes": 14657164,
"heapUsedBytes": 276118020,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 114.672,
"eventListeners": 0,
"totalBlockingTimeMs": 5,
"frameDurationMs": 28.937328767123283,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8101.417000000083,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7660.196999999998,
"heapDeltaBytes": 106800,
"heapUsedBytes": 251777228,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.856,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.872413793103455,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 132.40999999999303,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.917,
"layouts": 8,
"layoutDurationMs": 4.848,
"taskDurationMs": 107.249,
"heapDeltaBytes": 4614012,
"heapUsedBytes": 71342924,
"domNodes": 123,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.057000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662500000000023,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 92.75500000001102,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.676,
"layouts": 7,
"layoutDurationMs": 2.237,
"taskDurationMs": 57.27099999999999,
"heapDeltaBytes": 4413004,
"heapUsedBytes": 71397752,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.323,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 205.08199999994758,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.886,
"layouts": 76,
"layoutDurationMs": 9.437,
"taskDurationMs": 158.562,
"heapDeltaBytes": 8800160,
"heapUsedBytes": 99884956,
"domNodes": 4,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 68.355,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.67500000000003,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 224.11399999998594,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9219999999999999,
"layouts": 76,
"layoutDurationMs": 10.893999999999998,
"taskDurationMs": 176.577,
"heapDeltaBytes": 8985628,
"heapUsedBytes": 99805984,
"domNodes": 4,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 74.352,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 251.21500000000196,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.403,
"layouts": 76,
"layoutDurationMs": 9.193,
"taskDurationMs": 208.005,
"heapDeltaBytes": -7558016,
"heapUsedBytes": 109479528,
"domNodes": 4,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 63.003,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 233.8439999999764,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.358,
"layouts": 76,
"layoutDurationMs": 9.413,
"taskDurationMs": 195.939,
"heapDeltaBytes": 25766992,
"heapUsedBytes": 143676756,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 63.400999999999996,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2264 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ae3afc4705a12efcaecde072e5299be0befc4767
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16849 +/- ##
==========================================
+ Coverage 86.09% 86.89% +0.79%
==========================================
Files 3651 2601 -1050
Lines 174174 145969 -28205
Branches 48040 40069 -7971
==========================================
- Hits 149949 126833 -23116
+ Misses 22215 18749 -3466
+ Partials 2010 387 -1623
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1057 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Read both files at 8594f61 against main (branch is at the merge-base; no main commits touch either file). Ran the three follower suites locally at head (80 passed), then deleted the guard line and re-ran the integration test to confirm it fails on the base implementation (connected false after the same-document acknowledgement). Traced the mechanism: bridge.subscribe(id) for an id equal to desiredWorkflowId reaches reconcile(), which returns early because sentWorkflowId === desired, so before this PR the watcher zeroed connected, cancelled the stale probe and any pending subscribe retry, and nothing re-armed them because no new doc_subscribed frame was ever going to arrive. The one-line guard is the right fix and the boundary claims in the PR body check out: the inactive branch nulls subscribedWorkflowId, so the activation edge can never satisfy the guard, and initialBind is already false on every path that leaves subscribedWorkflowId non-null.
Two suggestions I can push (a comment for the guard, and a unit test pinning the activation boundary) and one question about intent versus reality.
question: the guard keys on the composable's intent (subscribedWorkflowId), not on delivery. After a refused subscribe has exhausted SUBSCRIBE_RETRY_MAX_ATTEMPTS, or after a schema_error, subscribedWorkflowId still names the doc while connected is false and no timer is pending. A same-document re-selection is now a pure no-op in that state. Before this PR it was also a no-op at the wire (same reconcile() short-circuit), so this is not a regression, but if a user re-picking the same workflow is meant to be a recovery nudge the guard is the place to call bridge.resubscribe() when !connected.value and no retry is scheduled. Detail inline.
Fixes for the two suggestions pushed to this branch; the question is left open.
|
Deployment failed for project comfy-home-v1 with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Pushed 7f8614c addressing the two suggestion threads from the review.
The open question thread about exhausted retries or a Verified locally: the three follower suites pass (81 tests), oxfmt, eslint, oxlint, and |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 5 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 3 |
| 🟢 Low | 1 |
| ⚪ Nit | 1 |
Panel: 8/8 reviewers contributed findings.
7f8614c to
52b56a8
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
pr-shepherd — stage 2 (merge conflict) advanced. The conflict was real, not an R-223 phantom. Shape: additive-both-sides at a single anchor. #16802's Proof the resolution dropped nothing. Checked that the rebased guard still detects the defect, rather than trusting a green suite. A passing test after a rebase does not prove the fix survived, so I deleted only the guard line and re-ran: Semantic interaction worth noting. #16655 gave Verification at the exact head ( Not merged, and the gate is review. Landing-order note for whoever merges this. |
52b56a8 to
621cc6e
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested
I reproduced the intended regression: the focused 85-test follower run passes at this head, and deleting only the new same-document guard makes the integration test fail at the expected connected assertion. I also traced the activation and true-retarget paths and found no subscription leak or duplicate registration.
The new integration test does not pass the required lint-and-format gate. Both string-path vi.mock calls violate vitest/prefer-import-in-mock; the CI fixer converts them to dynamic imports, then vue-tsc rejects the incomplete module factories. Please switch these mocks to typed dynamic-import factories that preserve each module’s full shape.
Checks I ran: pnpm install --frozen-lockfile; focused Vitest, 85 passed; pnpm typecheck, passed; changed-file ESLint, failed with the two inline errors; Fallow audit, no new findings in the three changed files; git diff --check, passed.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: follow-up needed: resolve the current main conflicts without dropping either regression.
All findings from my earlier reviews remain addressed. The typed mock factories pass lint and typecheck, the test no longer declares a second sent-frame contract or casts readonly status back to mutable, the Evidence count now matches this head, and CodeRabbit's later re-evaluation explicitly accepted the Playwright rationale.
The branch has fallen behind main again. A local merge of fresh origin/main at 4346841849 conflicts in both follower test files. The add/add conflict in useAgentCrdtFollower.integration.test.ts needs a semantic resolution: main independently added a projection-recovery regression at that path, while this PR adds the same-document subscription regression. Please retain both behaviors rather than selecting either side. The production file merges automatically, and the same-document guard is still absent from current main, so this PR is not superseded.
I also reproduced the existing nonblocking timer finding against current main. Keeping this PR's integration test during the merge fails at line 121 because the 2-second catch-up probe and the 30-second stale probe emit two doc_subscribe frames. The merge resolution should assert those two reasons separately, rather than merely widening the count, so the test still proves that the same-document acknowledgement itself emits no duplicate frame.
FE-2504 does not change my recommendation. This guard controls subscription acknowledgement and retarget lifecycle; it does not add or depend on the store-first graph projection path FE-2504 proposes removing. The subscription tests are behavioral coverage worth retaining. main's independently added projection-recovery test intersects that architecture work, but this PR must not discard it during the add/add resolution.
Checks at exact head 045e209c93: frozen install passed; focused follower suites passed, 109/109; full typecheck passed; changed-file ESLint and oxfmt passed; exact-head CI has 102 terminal check runs with no failures. The local current-main merge reproduced the two conflicts and the two-frame assertion failure above.
Maintainability: none in this follow-up diff.
Dismissed at DrJKL's request during the Agent PR survey. This does not mark the findings as fixed or approve the PR.
|
Merged |
Keep the same-document acknowledgement guard off the inactive-to-active edge introduced by held tab-switch ops, and move its regression into the follower unit suite. Amp-Thread-ID: https://ampcode.com/threads/T-01a0894f-6bfb-7251-b544-8f6e096ed917
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: approved at 62be621.
At the maintainer's request I pushed the commits being approved, so no independent reviewer has seen them. The fix is still needed on current main: the follower used by AgentPanelRoot.vue still clears the subscription when a persisted rebind is followed by the same workflow id, and the added regression fails against main's follower. #18700 and #20172 did not replace this lifecycle path.
Review record
- Earlier lint/typecheck finding from 2026-09-10: fixed by typed dynamic mocks, then superseded by this head's unit regression.
- Earlier sent-frame and readonly-status findings: fixed in the earlier integration test, which is removed at this head.
- Timer-expectation question in r4058462211: addressed in r4246199614. The regression checks that no second subscribe is sent and that the catch-up probe still fires.
- Merge with current
mainae3afc4705: the old guard broke held same-workflow tab-switch ops from #18063.4125b191faexcludes the activation edge, removes the stale guard comment and invalid activation test, and replaces the mock-heavy integration file with one follower regression. 62be621061splits the guard predicate so the introduced Fallow complexity finding is gone.- PR description updated to match the final head.
Checks on this head: all 63 follower test files passed (964 passed, 1 expected fail); full typecheck passed; changed-file oxlint, ESLint, and oxfmt passed; pre-push Knip and Fallow passed. Hosted CI: 129 check runs completed, 106 successful, 23 skipped, 0 failed; combined status success.
Maintainability: none remaining.
|
@christian-byrne Successfully backported to #21314 |
…FE-1969) (Comfy-Org#21147) ## Summary After a full page reload the panel restores its target from the thread's own transcript — the tab reopens, the picker repaints, the transcript is back — but the session binding is not restored, so the CRDT follower never resubscribes. Every host edit between the reload and the **next turn ack** reaches nobody, and during a turn recovered across the reload the user cannot send that next turn, so there is no way out of it. This binds the restored workflow, taken from the id the server's transcript carries. The guard is deliberately narrow: bind only when the restored workflow is both the panel's selected target and the active tab, which is what a restoration itself produces. `onWorkflowRestored` also reports success when there was nothing to restore (an already-decided target on a remount), so that cannot be the only condition, and a background target must never be subscribed. No binding or document id is read from client-side storage. `agentCrdtDocLifecycle`'s persisted doc-id record still refuses a pre-reload page-session nonce, which is deliberate and unchanged; the restored id comes from the service. The one thing kept in `sessionStorage` is a list of workflow ids whose canvas may hold edits the shared document lacks (see below); it can only stop the automatic bind, never cause one. <!-- updated by agent oploop-904h, 2026-10-22 --> Extends [FE-1969](https://linear.app/comfyorg/issue/FE-1969/crdt-follower-cannot-restore-persisted-binding-through-agentpanelroot). ## Verification Measured on `main` at `f2c829248b`, where a production-shaped reload (transcript naming the bound workflow) restores the target automatically, leaves the follower subscribe count unchanged, and drops a host edit pushed afterwards. On this head the same sequence resubscribes and the edit paints. - **Browser regression** `browser_tests/tests/agent/agentFollowerRestoredBindingReload.spec.ts`: red on the parent commit (post-reload subscribe count never rises, so the host edit never arrives), green here. The asserted value was never saved or recorded and no turn is sent after the reload, so only a live subscription can deliver it. - **Harness capability**: `agentConversationFixture` can now serve a stored transcript (`persistThreadTranscript`). Its history handler answered with an empty array — a thread that never ran — so a reloaded page had no target to restore and no reload case could reach this path at all. This is the gap recorded in Comfy-Org#16849's "why this fix has no `browser_tests/` case" note. - **Component cases** (2, in `AgentPanelRoot.test.ts`): the positive case is red on the parent; the negative case pins that a transcript which restores nothing leaves the session unbound. - Neighbouring reload coverage re-run green: `agentFollowerReloadBinding`, `agentHumanAddReload`, `agentChatRefreshPersistence`, `agentTurnSurvivesRefresh`. The explicit-reattachment case in `agentFollowerReloadBinding` is unchanged — picking a workflow in the switcher is still a target choice, not a live rebind. - `AgentPanelRoot.test.ts` 435/435; `pnpm typecheck`, `pnpm typecheck:browser`, type-aware oxlint, eslint, oxfmt, knip and the Fallow audit all pass; pre-commit and pre-push hooks ran. ### Restore-time precedence (dante01yoon's saved-edit finding) Binding at restore runs the subscribe catch-up, which writes the shared document into the canvas. On `main` a saved edit whose operation never reached the shared document survives a reload: the next message posts the live canvas as its draft, and turn preparation replaces the shared document with it (`ensureDoc` → `replaceDocFromClient` in cloud `services/agent/internal/loop/crdt.go`; [`CRDT-AUTHORITY-0035`](https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/docs/adr/CRDT-AUTHORITY-0035-human-canvas-authority-and-draft-reconciliation.md) decision 1). The first version of this PR reversed that: the catch-up overwrote the saved edit at restore ([reproduced](Comfy-Org#21147 (comment)), [confirmed](Comfy-Org#21147 (comment))). That precedence is kept, not re-decided. The follower records which workflows have human operations that are unsettled, or settled without being applied. A restore skips the automatic bind for such a workflow, so the canvas keeps the edit and the next message reconciles it exactly as on `main`. Every other restore binds as before. - The record clears per workflow on `doc_reset` (the draft replaced the document) and, for what an earlier page recorded, when this page subscribes to that workflow. It is carried across further reloads until then. - No operation is stored or replayed; persistence of pending operations across a full reload stays the separate decision [`CRDT-REPLAY-0039`](https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/docs/adr/CRDT-REPLAY-0039-retain-exhausted-operations-for-same-page-replay.md) defers. - A stale or duplicated-tab record can only reproduce `main`'s behaviour for that workflow (bind at the next turn). It cannot overwrite or resend anything. - Accepted cost: in that case, live host edits after the reload wait for the next turn, as on `main`. **Browser case** `keeps a saved edit the shared document never received, and posts it with the next message`: the host holds a `set_widget`, Save As, two reloads, then the next message's draft is asserted to carry the edit. It fails with the restore guard removed (canvas reads the older shared value, the exact failure in the review thread), with the follower's admission record removed, and at the second reload if the record is consumed on first read. One component case and three unit cases (`unsyncedHumanOps.test.ts`) pin the rest. The original restored-binding case still binds and receives the host edit. Re-run at `190b7f871e`: 18/18 Chromium cases across the restored-binding spec, `agentFollowerReloadBinding`, `agentHumanAddReload`, `agentHumanAddTabSwitch`, `agentChatRefreshPersistence`, `agentTurnSurvivesRefresh`, `agentMultilineTextEchoGarbling` and `boundCanvasReadPath`; `src/workbench/extensions/agent` 3,917 unit tests; typecheck (app and browser), oxlint, eslint, oxfmt, knip, Fallow audit and the pre-commit and pre-push hooks. Supersedes Comfy-Org#16708, which pursued the same user-visible outcome by adopting the pre-reload `sessionStorage` record across a reload. That approach conflicts with the current deliberate design and with the merged reload coverage; its other three claims — page-session nonce, expiry slide, background suspension — are already on `main` via Comfy-Org#16624, Comfy-Org#18063 and Comfy-Org#16849.
…FE-1969) (#21147) After a full page reload the panel restores its target from the thread's own transcript — the tab reopens, the picker repaints, the transcript is back — but the session binding is not restored, so the CRDT follower never resubscribes. Every host edit between the reload and the **next turn ack** reaches nobody, and during a turn recovered across the reload the user cannot send that next turn, so there is no way out of it. This binds the restored workflow, taken from the id the server's transcript carries. The guard is deliberately narrow: bind only when the restored workflow is both the panel's selected target and the active tab, which is what a restoration itself produces. `onWorkflowRestored` also reports success when there was nothing to restore (an already-decided target on a remount), so that cannot be the only condition, and a background target must never be subscribed. No binding or document id is read from client-side storage. `agentCrdtDocLifecycle`'s persisted doc-id record still refuses a pre-reload page-session nonce, which is deliberate and unchanged; the restored id comes from the service. The one thing kept in `sessionStorage` is a list of workflow ids whose canvas may hold edits the shared document lacks (see below); it can only stop the automatic bind, never cause one. <!-- updated by agent oploop-904h, 2026-10-22 --> Extends [FE-1969](https://linear.app/comfyorg/issue/FE-1969/crdt-follower-cannot-restore-persisted-binding-through-agentpanelroot). Measured on `main` at `f2c829248b`, where a production-shaped reload (transcript naming the bound workflow) restores the target automatically, leaves the follower subscribe count unchanged, and drops a host edit pushed afterwards. On this head the same sequence resubscribes and the edit paints. - **Browser regression** `browser_tests/tests/agent/agentFollowerRestoredBindingReload.spec.ts`: red on the parent commit (post-reload subscribe count never rises, so the host edit never arrives), green here. The asserted value was never saved or recorded and no turn is sent after the reload, so only a live subscription can deliver it. - **Harness capability**: `agentConversationFixture` can now serve a stored transcript (`persistThreadTranscript`). Its history handler answered with an empty array — a thread that never ran — so a reloaded page had no target to restore and no reload case could reach this path at all. This is the gap recorded in #16849's "why this fix has no `browser_tests/` case" note. - **Component cases** (2, in `AgentPanelRoot.test.ts`): the positive case is red on the parent; the negative case pins that a transcript which restores nothing leaves the session unbound. - Neighbouring reload coverage re-run green: `agentFollowerReloadBinding`, `agentHumanAddReload`, `agentChatRefreshPersistence`, `agentTurnSurvivesRefresh`. The explicit-reattachment case in `agentFollowerReloadBinding` is unchanged — picking a workflow in the switcher is still a target choice, not a live rebind. - `AgentPanelRoot.test.ts` 435/435; `pnpm typecheck`, `pnpm typecheck:browser`, type-aware oxlint, eslint, oxfmt, knip and the Fallow audit all pass; pre-commit and pre-push hooks ran. Binding at restore runs the subscribe catch-up, which writes the shared document into the canvas. On `main` a saved edit whose operation never reached the shared document survives a reload: the next message posts the live canvas as its draft, and turn preparation replaces the shared document with it (`ensureDoc` → `replaceDocFromClient` in cloud `services/agent/internal/loop/crdt.go`; [`CRDT-AUTHORITY-0035`](https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/docs/adr/CRDT-AUTHORITY-0035-human-canvas-authority-and-draft-reconciliation.md) decision 1). The first version of this PR reversed that: the catch-up overwrote the saved edit at restore ([reproduced](#21147 (comment)), [confirmed](#21147 (comment))). That precedence is kept, not re-decided. The follower records which workflows have human operations that are unsettled, or settled without being applied. A restore skips the automatic bind for such a workflow, so the canvas keeps the edit and the next message reconciles it exactly as on `main`. Every other restore binds as before. - The record clears per workflow on `doc_reset` (the draft replaced the document) and, for what an earlier page recorded, when this page subscribes to that workflow. It is carried across further reloads until then. - No operation is stored or replayed; persistence of pending operations across a full reload stays the separate decision [`CRDT-REPLAY-0039`](https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/docs/adr/CRDT-REPLAY-0039-retain-exhausted-operations-for-same-page-replay.md) defers. - A stale or duplicated-tab record can only reproduce `main`'s behaviour for that workflow (bind at the next turn). It cannot overwrite or resend anything. - Accepted cost: in that case, live host edits after the reload wait for the next turn, as on `main`. **Browser case** `keeps a saved edit the shared document never received, and posts it with the next message`: the host holds a `set_widget`, Save As, two reloads, then the next message's draft is asserted to carry the edit. It fails with the restore guard removed (canvas reads the older shared value, the exact failure in the review thread), with the follower's admission record removed, and at the second reload if the record is consumed on first read. One component case and three unit cases (`unsyncedHumanOps.test.ts`) pin the rest. The original restored-binding case still binds and receives the host edit. Re-run at `190b7f871e`: 18/18 Chromium cases across the restored-binding spec, `agentFollowerReloadBinding`, `agentHumanAddReload`, `agentHumanAddTabSwitch`, `agentChatRefreshPersistence`, `agentTurnSurvivesRefresh`, `agentMultilineTextEchoGarbling` and `boundCanvasReadPath`; `src/workbench/extensions/agent` 3,917 unit tests; typecheck (app and browser), oxlint, eslint, oxfmt, knip, Fallow audit and the pre-commit and pre-push hooks. Supersedes #16708, which pursued the same user-visible outcome by adopting the pre-reload `sessionStorage` record across a reload. That approach conflicts with the current deliberate design and with the merged reload coverage; its other three claims — page-session nonce, expiry slide, background suspension — are already on `main` via #16624, (cherry picked from commit 3422e4c)
Summary
Preserves connected and stale-recovery state when a restored follower's first reactive acknowledgement names its already-subscribed document.
Changes
Review Focus
The early return applies only while active, not on an activation edge, and only when the named document already equals the subscribed workflow. Inactive transitions, activation edges, and true retargets keep the existing reset path.
Follow-up to #16708. Extends FE-1969.
Evidence
mainwithconnectedfalse after the same-document acknowledgement.NODE_OPTIONS=--no-experimental-webstorage pnpm exec vitest run src/workbench/extensions/agent/crdt/— 964 passed, 1 expected fail.NODE_OPTIONS=--no-experimental-webstorage pnpm typecheck— passed.End-to-end coverage: why this fix has no
browser_tests/caseReproducing this in the browser needs a live document subscription that survives a reload.
agentConversationTesthas no reload step, andagentChatRefreshPersistence.spec.tsruns withconnectWebSocketToServer: false, so neither enters the persisted-rebind path with a live subscription. Adding that harness capability is separate work.