Repository navigation
[backport cloud/1.55] fix(agent): use a neutral color palette and lighter text in the agent panel - #18796
Conversation
… panel (#18052) ## Summary The agent side panel uses neutral colors and lighter text now. Linear: [DES-1043](https://linear.app/comfyorg/issue/DES-1043/des-use-a-more-neutral-color-palette-in-agent-panel) Taken over from @uytieu with his go-ahead in #agent-eng. Rebased onto main, and three things changed from his version. Details under **Handover changes** below. ## Changes - **What**: - The notice box had a blue line on the left and a blue icon. Both are neutral now. - The welcome screen had a yellow "C" logo in a box with a purple outline. The logo and the box are gone. That removes the panel's only raw-palette usage: `border-plum-600`, `bg-ink-700`, `text-brand-yellow`. - The workflow menu used the same yellow "C" to mark your choice. It uses a standard check mark now. - Hardcoded label weights in the panel drop to normal weight. - One menu did not receive the panel styles. It receives them now. Buttons keep their slightly bold text. That weight comes from `button.variants.ts`, which the whole product uses, not from this panel. [DES-1095](https://linear.app/comfyorg/issue/DES-1095/des-button-base-weight-is-font-medium-revisit-as-design-system-default) recorded that decision and closed it as intentional. ## Handover changes **1. The notice rule uses a background token, not a text token.** It was `before:bg-muted-foreground`. That is the secondary-text role (light `#494a50`, dark `#8a8a8a`), and filling a 4px rule with it inverts the role. `docs/guidance/design-standards.md` asks for the semantic role rather than whichever value lands right. It is `before:bg-muted-background` now, the neutral surface role already used as both a fill and a border elsewhere in `src` (light `#a0a0a0`, dark `#55565e`). No new token: design-standards says not to name one for the first component that wants it. **2. The weight pins are deleted, not restated.** Every one of those sites is a `p`/`span`/`div` with no weight-setting ancestor, so `font-normal` renders identically to no class at all. It only pins the value at the call site. Two `font-medium` labels that main's refactor moved out from under the original sweep are gone the same way, which finishes the DES-1043 checkbox. `font-normal` on a Button or a heading is load-bearing and was left alone: `button.variants.ts` bakes `font-medium` into the base class, and Tailwind Preflight is disabled host-wide so an `h2` still renders UA bold. The panel keeps about twenty of those. **3. Font smoothing is out of this PR, on scope grounds only.** `-webkit-font-smoothing: antialiased` was scoped to `:where(#agent-panel-root, .agent-scope)`. It reads better and should land, but there is no font-smoothing declaration anywhere else in the repo, so panel-scoped would make the agent panel the only surface rendering text differently from the rest of the product. That is a product-wide typography call. Parked in **[DES-1205](https://linear.app/comfyorg/issue/DES-1205)** with two ways to land it, whichever @uytieu and design prefer: a separate PR putting it in `packages/design-system/src/css/base.css` with a visual pass over high-traffic surfaces, or folding it into the design-system work Alex Tov and Alex Brown are running. Nothing is blocked on it. One note for that visual pass: grayscale AA thins strokes and change 2 drops this panel a weight step, so the two stack at `text-xs` and `text-[11px]/4` here. Not an argument against smoothing, just the pairing to look at first. ## Review Focus - `RunNoticeBanner` now has its own story in both themes. That is the surface this PR recolors, and #18693 rewrites the same markup to add a target-following context, so it earns a baseline of its own. - **Chromatic does not run on this PR.** `ci-tests-storybook.yaml` gates `chromatic-deployment` on `startsWith(github.head_ref, 'version-bump-')`, deliberately, since #5167. So no ordinary PR gets a visual diff, and Uy's original version of this change had no visual check either. `storybook-build` passing only means Storybook compiles. The new story starts paying off at the next version bump. ## Verification Chromatic dispatched manually on a throwaway branch came back `Snapshot quota reached`, so it compared nothing. Diffed the two Storybook builds locally instead, Uy's rebased state against this one, across all 42 shared agent stories in both themes. | | | |---|---| | Identical | 78 of 84 comparisons | | Different | the notice rule only, 352 px at a 4x90 box, in all three `AgentPanel` stories, both themes, byte-identical across two runs | Six more stories flagged on the first pass and were ruled out. `AgentMessage` composing/streaming and `ConsentCard` also differ when a build is diffed **against itself**, so they are animation phase. `AttachmentChip Uploading` and `AgentEntryButton Inviting` were stable across runs but come back byte-identical once `animation: none` is injected, and their sources are unchanged between the two commits. Every weight-pin deletion is a pixel-exact no-op. The only thing that moved is the rule. - The welcome screen is 64 pixels shorter. Check that the space above the greeting still looks correct. - Open the workflow menu. Check that the check mark reads as a choice. - The commits are separate on purpose. Any one can be dropped alone. ## Still blue, not in scope here Two `primary-background` usages survive in the panel and are worth a separate design call rather than a silent change: - `components/agent/composer/WorkflowSelectorChip.vue` — the blue dot marking the chosen workflow, the same signal as the check mark this PR de-yellowed. - `components/agent/message/MarkdownStream.vue` — link color in agent replies. (`crdt/CrdtDevPanel.vue` has four more. Dev-only, out of scope.) ## Screenshots The notice rule, cropped from the `AgentPanel` story in both themes with animations frozen. `muted-foreground` on the left, `muted-background` on the right.  Uy's original panel shot, which predates the token change. Accurate for the logo removal and the check mark, not for the rule color.  --------- Co-authored-by: bymyself <cbyrne@comfy.org>
🎭 Playwright: ✅ 2124 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (19 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 63632c70b94deada6e78dbb85a52991c313b979f
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T05:19:16.870Z",
"gitSha": "60282bc488b5df9c4d70515543371a80ccf66a99",
"branch": "backport-18052-to-cloud-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1998.7409999999954,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.913999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.62699999999995,
"heapDeltaBytes": -6618572,
"heapUsedBytes": 60838880,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.227999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2050.13299999996,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.104,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.591,
"heapDeltaBytes": 8096828,
"heapUsedBytes": 75645044,
"domNodes": -259,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.080999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.3839999999568,
"styleRecalcs": 47,
"styleRecalcDurationMs": 14.983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.362,
"heapDeltaBytes": -4784656,
"heapUsedBytes": 62765924,
"domNodes": -258,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 151.62699999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1735.6240000000298,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.163,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 738.005,
"heapDeltaBytes": 8312004,
"heapUsedBytes": 75917160,
"domNodes": -257,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 147.75500000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.0980000000304,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.982,
"layouts": 6,
"layoutDurationMs": 0.937,
"taskDurationMs": 307.38699999999994,
"heapDeltaBytes": 3069616,
"heapUsedBytes": 70648272,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.593999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.2339999999476,
"styleRecalcs": 30,
"styleRecalcDurationMs": 12.861999999999998,
"layouts": 6,
"layoutDurationMs": 0.9970000000000001,
"taskDurationMs": 305.232,
"heapDeltaBytes": 2808504,
"heapUsedBytes": 70398972,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.01,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 586.7869999999584,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.459,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 400.03,
"heapDeltaBytes": 18909800,
"heapUsedBytes": 86542592,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 167.85299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 626.5140000000429,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.258000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.469,
"heapDeltaBytes": 18837228,
"heapUsedBytes": 86534920,
"domNodes": 24,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 163.519,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1133.8159999999675,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 780.212,
"heapDeltaBytes": 38806876,
"heapUsedBytes": 106335332,
"domNodes": 0,
"jsHeapTotalBytes": 18509824,
"scriptDurationMs": 65.05999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 517,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1181.2260000000379,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 859.9169999999999,
"heapDeltaBytes": -17384692,
"heapUsedBytes": 72648312,
"domNodes": -295,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 64.443,
"eventListeners": -217,
"totalBlockingTimeMs": 531,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 848.3939999999848,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.52799999999934,
"heapDeltaBytes": 14573252,
"heapUsedBytes": 90817092,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 161.59199999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 829.5940000000428,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.2899999999995,
"heapDeltaBytes": 14808772,
"heapUsedBytes": 90227104,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 157.132,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9366.71899999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8443.778,
"heapDeltaBytes": 15942032,
"heapUsedBytes": 97797144,
"domNodes": -16,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 7199.150000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 868,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10057.079999999929,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9216.659,
"heapDeltaBytes": 13793848,
"heapUsedBytes": 95909784,
"domNodes": -14,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 7697.384,
"eventListeners": 0,
"totalBlockingTimeMs": 1051,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9117.903000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8334.813,
"heapDeltaBytes": -864320,
"heapUsedBytes": 81314552,
"domNodes": -14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 6839.414,
"eventListeners": 0,
"totalBlockingTimeMs": 666,
"frameDurationMs": 18.89333333333331,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9928.38100000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9126.813,
"heapDeltaBytes": 12622292,
"heapUsedBytes": 95011608,
"domNodes": -18,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 7567.307000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 898,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2040.8780000000206,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.412000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.5729999999999,
"heapDeltaBytes": -3428920,
"heapUsedBytes": 83578276,
"domNodes": -238,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 27.77800000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2029.7489999999243,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.177999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.2030000000001,
"heapDeltaBytes": -2817264,
"heapUsedBytes": 83579960,
"domNodes": -242,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 28.796000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2254.9149999999827,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.834000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1606.9089999999999,
"heapDeltaBytes": -5431740,
"heapUsedBytes": 75369596,
"domNodes": -247,
"jsHeapTotalBytes": 217088,
"scriptDurationMs": 843.065,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2159.518999999932,
"styleRecalcs": 70,
"styleRecalcDurationMs": 12.563999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1524.979,
"heapDeltaBytes": -7313284,
"heapUsedBytes": 80209648,
"domNodes": -240,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 803.645,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3476.447999999948,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.146,
"layouts": 60,
"layoutDurationMs": 12.483,
"taskDurationMs": 1666.893,
"heapDeltaBytes": -15653864,
"heapUsedBytes": 73692600,
"domNodes": -258,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 783.4250000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3562.498000000005,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.114000000000003,
"layouts": 60,
"layoutDurationMs": 12.534,
"taskDurationMs": 1643.1869999999997,
"heapDeltaBytes": 8753884,
"heapUsedBytes": 74562960,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 794.766,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3048.5160000000064,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.283999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1881.2799999999997,
"heapDeltaBytes": 844232,
"heapUsedBytes": 66678000,
"domNodes": 8,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 988.7830000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2980.5450000000064,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.363,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1864.862,
"heapDeltaBytes": 25612652,
"heapUsedBytes": 91603436,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1000.8509999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2019.3270000000325,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.657999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 524.415,
"heapDeltaBytes": -4260308,
"heapUsedBytes": 84301008,
"domNodes": -244,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 32.819,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1998.1649999999718,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.9589999999999974,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 359.69399999999996,
"heapDeltaBytes": 20140824,
"heapUsedBytes": 84772404,
"domNodes": 12,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 28.282,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 581.9210000000226,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.67,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 384.077,
"heapDeltaBytes": 14068072,
"heapUsedBytes": 83854448,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 147.29899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.2470000000139,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.2,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.09099999999995,
"heapDeltaBytes": 13796796,
"heapUsedBytes": 83631212,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 146.387,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1993.9370000000167,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.378999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.371,
"heapDeltaBytes": -11630112,
"heapUsedBytes": 58104968,
"domNodes": -270,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.501000000000003,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1990.3279999999768,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.534,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.02399999999994,
"heapDeltaBytes": -89156,
"heapUsedBytes": 68896188,
"domNodes": -272,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.397,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.4780000000278,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.969000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 670.686,
"heapDeltaBytes": -6839512,
"heapUsedBytes": 62969884,
"domNodes": -273,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 94.98600000000002,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1725.080999999932,
"styleRecalcs": 45,
"styleRecalcDurationMs": 12.566,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 672.365,
"heapDeltaBytes": 4237312,
"heapUsedBytes": 74126092,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 94.485,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1084.0709999999945,
"styleRecalcs": 17,
"styleRecalcDurationMs": 26.687999999999995,
"layouts": 5,
"layoutDurationMs": 12.610000000000001,
"taskDurationMs": 813.091,
"heapDeltaBytes": 20173668,
"heapUsedBytes": 103657488,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 24.625,
"eventListeners": 2383,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8330.609000000039,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5509.54,
"heapDeltaBytes": -9961296,
"heapUsedBytes": 76790224,
"domNodes": -241,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 2752.178,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8276.894999999968,
"styleRecalcs": 251,
"styleRecalcDurationMs": 37.815000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5501.4039999999995,
"heapDeltaBytes": -6448308,
"heapUsedBytes": 80497000,
"domNodes": -238,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 2711.2039999999997,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 15218.462999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14603.689,
"heapDeltaBytes": -45867040,
"heapUsedBytes": 167602212,
"domNodes": -8061,
"jsHeapTotalBytes": -8634368,
"scriptDurationMs": 215.10399999999996,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 10886.905999999954,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10288.091,
"heapDeltaBytes": -23670316,
"heapUsedBytes": 182599376,
"domNodes": -8061,
"jsHeapTotalBytes": -4177920,
"scriptDurationMs": 163.936,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 19377.193000000036,
"styleRecalcs": 167,
"styleRecalcDurationMs": 16.316999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19083.63,
"heapDeltaBytes": -55537740,
"heapUsedBytes": 179521120,
"domNodes": -8062,
"jsHeapTotalBytes": -10498048,
"scriptDurationMs": 871.9520000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 42,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19022.756999999954,
"styleRecalcs": 172,
"styleRecalcDurationMs": 15.63400000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18511.413,
"heapDeltaBytes": -57559108,
"heapUsedBytes": 180238276,
"domNodes": -8061,
"jsHeapTotalBytes": -14876672,
"scriptDurationMs": 837.81,
"eventListeners": -14928,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5635.99899999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.30399999999997,
"layouts": 20,
"layoutDurationMs": 20.48699999999999,
"taskDurationMs": 5545.019,
"heapDeltaBytes": -57598432,
"heapUsedBytes": 183814424,
"domNodes": -8061,
"jsHeapTotalBytes": 11071488,
"scriptDurationMs": 91.49599999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 332,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 5459.733000000028,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.75099999999999,
"layouts": 20,
"layoutDurationMs": 21.557999999999993,
"taskDurationMs": 5358.752,
"heapDeltaBytes": -27506348,
"heapUsedBytes": 193489364,
"domNodes": -8062,
"jsHeapTotalBytes": 15994880,
"scriptDurationMs": 89.53999999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 373,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7711.180000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7377.985999999998,
"heapDeltaBytes": -18780416,
"heapUsedBytes": 171306996,
"domNodes": 0,
"jsHeapTotalBytes": -14155776,
"scriptDurationMs": 106.21799999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7542.736999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7255.768999999999,
"heapDeltaBytes": 49664,
"heapUsedBytes": 191353112,
"domNodes": 0,
"jsHeapTotalBytes": -11796480,
"scriptDurationMs": 125.36300000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 478.26099999997496,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.214,
"layouts": 3,
"layoutDurationMs": 1.5539999999999998,
"taskDurationMs": 121.81200000000003,
"heapDeltaBytes": 5196300,
"heapUsedBytes": 70944984,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.533999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 451.6390000000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.57,
"layouts": 5,
"layoutDurationMs": 2.31,
"taskDurationMs": 113.57300000000001,
"heapDeltaBytes": 5037908,
"heapUsedBytes": 70825416,
"domNodes": 146,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.665,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
christian-byrne
left a comment
There was a problem hiding this comment.
Clean cherry-pick of #18052 (1e98c37aa), no conflicts, same 15 files.
Verified on this head rather than assuming the file list means the content carried: notice rule is before:bg-muted-background, icon is muted-foreground, no weight pins left in the banner, the comfy-c logo and its plum-600/ink-700 raw-palette wrapper are gone from EmptyState, agent-scope is on the MessageFeedback dropdown, the RunNoticeBanner story carried, and no font-smoothing leaked into agentPanel.css (that stays parked in DES-1205).
Parent was approved with its residual risk stated; nothing changes on cloud/1.55.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.55 #18796 +/- ##
=============================================
Coverage ? 84.59%
=============================================
Files ? 2294
Lines ? 131268
Branches ? 35426
=============================================
Hits ? 111047
Misses ? 19921
Partials ? 300
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #18052 to
cloud/1.55Automatically created by backport workflow.