Repository navigation
[backport cloud/1.54] fix(agent): use a neutral color palette and lighter text in the agent panel - #18794
Conversation
… panel (#18052) ## Summary The agent side panel uses neutral colors and lighter text now. Linear: [DES-1043](https://linear.app/comfyorg/issue/DES-1043/des-use-a-more-neutral-color-palette-in-agent-panel) Taken over from @uytieu with his go-ahead in #agent-eng. Rebased onto main, and three things changed from his version. Details under **Handover changes** below. ## Changes - **What**: - The notice box had a blue line on the left and a blue icon. Both are neutral now. - The welcome screen had a yellow "C" logo in a box with a purple outline. The logo and the box are gone. That removes the panel's only raw-palette usage: `border-plum-600`, `bg-ink-700`, `text-brand-yellow`. - The workflow menu used the same yellow "C" to mark your choice. It uses a standard check mark now. - Hardcoded label weights in the panel drop to normal weight. - One menu did not receive the panel styles. It receives them now. Buttons keep their slightly bold text. That weight comes from `button.variants.ts`, which the whole product uses, not from this panel. [DES-1095](https://linear.app/comfyorg/issue/DES-1095/des-button-base-weight-is-font-medium-revisit-as-design-system-default) recorded that decision and closed it as intentional. ## Handover changes **1. The notice rule uses a background token, not a text token.** It was `before:bg-muted-foreground`. That is the secondary-text role (light `#494a50`, dark `#8a8a8a`), and filling a 4px rule with it inverts the role. `docs/guidance/design-standards.md` asks for the semantic role rather than whichever value lands right. It is `before:bg-muted-background` now, the neutral surface role already used as both a fill and a border elsewhere in `src` (light `#a0a0a0`, dark `#55565e`). No new token: design-standards says not to name one for the first component that wants it. **2. The weight pins are deleted, not restated.** Every one of those sites is a `p`/`span`/`div` with no weight-setting ancestor, so `font-normal` renders identically to no class at all. It only pins the value at the call site. Two `font-medium` labels that main's refactor moved out from under the original sweep are gone the same way, which finishes the DES-1043 checkbox. `font-normal` on a Button or a heading is load-bearing and was left alone: `button.variants.ts` bakes `font-medium` into the base class, and Tailwind Preflight is disabled host-wide so an `h2` still renders UA bold. The panel keeps about twenty of those. **3. Font smoothing is out of this PR, on scope grounds only.** `-webkit-font-smoothing: antialiased` was scoped to `:where(#agent-panel-root, .agent-scope)`. It reads better and should land, but there is no font-smoothing declaration anywhere else in the repo, so panel-scoped would make the agent panel the only surface rendering text differently from the rest of the product. That is a product-wide typography call. Parked in **[DES-1205](https://linear.app/comfyorg/issue/DES-1205)** with two ways to land it, whichever @uytieu and design prefer: a separate PR putting it in `packages/design-system/src/css/base.css` with a visual pass over high-traffic surfaces, or folding it into the design-system work Alex Tov and Alex Brown are running. Nothing is blocked on it. One note for that visual pass: grayscale AA thins strokes and change 2 drops this panel a weight step, so the two stack at `text-xs` and `text-[11px]/4` here. Not an argument against smoothing, just the pairing to look at first. ## Review Focus - `RunNoticeBanner` now has its own story in both themes. That is the surface this PR recolors, and #18693 rewrites the same markup to add a target-following context, so it earns a baseline of its own. - **Chromatic does not run on this PR.** `ci-tests-storybook.yaml` gates `chromatic-deployment` on `startsWith(github.head_ref, 'version-bump-')`, deliberately, since #5167. So no ordinary PR gets a visual diff, and Uy's original version of this change had no visual check either. `storybook-build` passing only means Storybook compiles. The new story starts paying off at the next version bump. ## Verification Chromatic dispatched manually on a throwaway branch came back `Snapshot quota reached`, so it compared nothing. Diffed the two Storybook builds locally instead, Uy's rebased state against this one, across all 42 shared agent stories in both themes. | | | |---|---| | Identical | 78 of 84 comparisons | | Different | the notice rule only, 352 px at a 4x90 box, in all three `AgentPanel` stories, both themes, byte-identical across two runs | Six more stories flagged on the first pass and were ruled out. `AgentMessage` composing/streaming and `ConsentCard` also differ when a build is diffed **against itself**, so they are animation phase. `AttachmentChip Uploading` and `AgentEntryButton Inviting` were stable across runs but come back byte-identical once `animation: none` is injected, and their sources are unchanged between the two commits. Every weight-pin deletion is a pixel-exact no-op. The only thing that moved is the rule. - The welcome screen is 64 pixels shorter. Check that the space above the greeting still looks correct. - Open the workflow menu. Check that the check mark reads as a choice. - The commits are separate on purpose. Any one can be dropped alone. ## Still blue, not in scope here Two `primary-background` usages survive in the panel and are worth a separate design call rather than a silent change: - `components/agent/composer/WorkflowSelectorChip.vue` — the blue dot marking the chosen workflow, the same signal as the check mark this PR de-yellowed. - `components/agent/message/MarkdownStream.vue` — link color in agent replies. (`crdt/CrdtDevPanel.vue` has four more. Dev-only, out of scope.) ## Screenshots The notice rule, cropped from the `AgentPanel` story in both themes with animations frozen. `muted-foreground` on the left, `muted-background` on the right.  Uy's original panel shot, which predates the token change. Accurate for the logo removal and the check mark, not for the rule color.  --------- Co-authored-by: bymyself <cbyrne@comfy.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1956 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-25T07:29:24.628Z",
"gitSha": "363c4869e66db4f1741c3f24241a253d7e65e135",
"branch": "backport-18052-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2068.728999999962,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.415,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.549,
"heapDeltaBytes": -11632220,
"heapUsedBytes": 58508636,
"domNodes": -284,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 13.183999999999997,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2054.597000000058,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.271,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.665,
"heapDeltaBytes": -11458760,
"heapUsedBytes": 59014252,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 12.546000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2087.716999999998,
"styleRecalcs": 79,
"styleRecalcDurationMs": 36.88699999999999,
"layouts": 14,
"layoutDurationMs": 4.976999999999999,
"taskDurationMs": 1056.716,
"heapDeltaBytes": 5392472,
"heapUsedBytes": 76450624,
"domNodes": -283,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 184.49599999999998,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1815.2489999999943,
"styleRecalcs": 75,
"styleRecalcDurationMs": 29.241999999999997,
"layouts": 14,
"layoutDurationMs": 3.921,
"taskDurationMs": 890.7870000000001,
"heapDeltaBytes": 348604,
"heapUsedBytes": 71411324,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 164.26500000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.1160000000286,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.956000000000003,
"layouts": 6,
"layoutDurationMs": 1.112,
"taskDurationMs": 375.005,
"heapDeltaBytes": 4594136,
"heapUsedBytes": 75914280,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.636999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.1410000000042,
"styleRecalcs": 33,
"styleRecalcDurationMs": 18.563999999999997,
"layouts": 6,
"layoutDurationMs": 1.0730000000000002,
"taskDurationMs": 380.09499999999997,
"heapDeltaBytes": 4633980,
"heapUsedBytes": 75391920,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.247,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 691.6899999999941,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.054999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.72800000000007,
"heapDeltaBytes": -7617476,
"heapUsedBytes": 63508676,
"domNodes": 20,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 171.957,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 659.1809999999896,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.304999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.789,
"heapDeltaBytes": -7861052,
"heapUsedBytes": 63466428,
"domNodes": 16,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 161.42000000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.7370000000024,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.8329999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 622.7250000000001,
"heapDeltaBytes": 10685928,
"heapUsedBytes": 86998932,
"domNodes": -275,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 33.407000000000004,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2032.5279999999566,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.431999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.358,
"heapDeltaBytes": 10807120,
"heapUsedBytes": 87337236,
"domNodes": -267,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 33.147999999999996,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2463.8100000000236,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.563,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1731.5269999999998,
"heapDeltaBytes": 23886484,
"heapUsedBytes": 90127068,
"domNodes": -279,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 881.535,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2414.026999999919,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.622999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1724.173,
"heapDeltaBytes": 8698264,
"heapUsedBytes": 86067672,
"domNodes": -274,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 840.076,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3583.420999999987,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.577,
"layouts": 60,
"layoutDurationMs": 11.988999999999999,
"taskDurationMs": 1713.4900000000002,
"heapDeltaBytes": 9476500,
"heapUsedBytes": 76675396,
"domNodes": 2,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 783.3950000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3733.0670000000055,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.657999999999996,
"layouts": 60,
"layoutDurationMs": 11.938,
"taskDurationMs": 1803.1190000000001,
"heapDeltaBytes": -2993196,
"heapUsedBytes": 75845828,
"domNodes": -278,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 785.707,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3129.1709999999853,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.906000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1968.0010000000002,
"heapDeltaBytes": 25816660,
"heapUsedBytes": 92859036,
"domNodes": -282,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 969.8630000000002,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3188.963000000058,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.646,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2044.7530000000002,
"heapDeltaBytes": 9432316,
"heapUsedBytes": 90374424,
"domNodes": -257,
"jsHeapTotalBytes": -471040,
"scriptDurationMs": 990.541,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2033.048000000008,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.5920000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.058,
"heapDeltaBytes": 9432676,
"heapUsedBytes": 87848084,
"domNodes": -274,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 28.561000000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2066.396999999938,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.882,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.348,
"heapDeltaBytes": 9097380,
"heapUsedBytes": 88087428,
"domNodes": -273,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 38.607,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 640.1299999999992,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.805000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.28900000000004,
"heapDeltaBytes": 15033348,
"heapUsedBytes": 88528872,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 149.668,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.2729999999401,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.183000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.14599999999996,
"heapDeltaBytes": 14621852,
"heapUsedBytes": 87242000,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.72899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.6609999999846,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.767999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.77099999999996,
"heapDeltaBytes": -14603580,
"heapUsedBytes": 58719344,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 8.23,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2000.2649999998994,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.850000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 490.96900000000005,
"heapDeltaBytes": 7298656,
"heapUsedBytes": 80590164,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.303999999999998,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.88,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.646,
"layouts": 18,
"layoutDurationMs": 5.2170000000000005,
"taskDurationMs": 874.257,
"heapDeltaBytes": -10719016,
"heapUsedBytes": 62848248,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 117.58,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.2159999999421,
"styleRecalcs": 78,
"styleRecalcDurationMs": 27.487000000000002,
"layouts": 18,
"layoutDurationMs": 4.429,
"taskDurationMs": 822.286,
"heapDeltaBytes": -14132444,
"heapUsedBytes": 59219236,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 108.83,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.128999999969,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.995999999999995,
"layouts": 14,
"layoutDurationMs": 15.643999999999998,
"taskDurationMs": 946.7249999999998,
"heapDeltaBytes": 20090312,
"heapUsedBytes": 103675596,
"domNodes": 13751,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.890999999999995,
"eventListeners": 2385,
"totalBlockingTimeMs": 151,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8624.431000000015,
"styleRecalcs": 246,
"styleRecalcDurationMs": 33.793000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5914.1720000000005,
"heapDeltaBytes": 13785484,
"heapUsedBytes": 90245856,
"domNodes": -272,
"jsHeapTotalBytes": -1187840,
"scriptDurationMs": 2716.5910000000003,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8767.450999999937,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.262,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6079.836,
"heapDeltaBytes": 5547364,
"heapUsedBytes": 82204820,
"domNodes": -247,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2796.888,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17726.02599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17058.063,
"heapDeltaBytes": -43138220,
"heapUsedBytes": 178633604,
"domNodes": -8068,
"jsHeapTotalBytes": -13639680,
"scriptDurationMs": 296.24300000000005,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17658.98100000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16957.522999999997,
"heapDeltaBytes": -57897344,
"heapUsedBytes": 182053720,
"domNodes": -8068,
"jsHeapTotalBytes": -14356480,
"scriptDurationMs": 292.948,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21737.949000000073,
"styleRecalcs": 174,
"styleRecalcDurationMs": 21.083999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21506.270999999997,
"heapDeltaBytes": -58692608,
"heapUsedBytes": 179809724,
"domNodes": -8068,
"jsHeapTotalBytes": -17465344,
"scriptDurationMs": 961.719,
"eventListeners": -14927,
"totalBlockingTimeMs": 154,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21230.723000000013,
"styleRecalcs": 171,
"styleRecalcDurationMs": 18.587999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20829.533,
"heapDeltaBytes": -25869772,
"heapUsedBytes": 193513892,
"domNodes": -8068,
"jsHeapTotalBytes": -11923456,
"scriptDurationMs": 924.6049999999999,
"eventListeners": -14925,
"totalBlockingTimeMs": 56,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6356.857000000105,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.77099999999999,
"layouts": 20,
"layoutDurationMs": 23.700999999999986,
"taskDurationMs": 6228.357,
"heapDeltaBytes": -41235736,
"heapUsedBytes": 177354832,
"domNodes": -8068,
"jsHeapTotalBytes": 11505664,
"scriptDurationMs": 142.22299999999998,
"eventListeners": -14927,
"totalBlockingTimeMs": 489,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6274.279999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 99.88599999999998,
"layouts": 20,
"layoutDurationMs": 30.349000000000014,
"taskDurationMs": 6172.32,
"heapDeltaBytes": -42872872,
"heapUsedBytes": 176206456,
"domNodes": -8068,
"jsHeapTotalBytes": 9641984,
"scriptDurationMs": 109.78400000000002,
"eventListeners": -14927,
"totalBlockingTimeMs": 569,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9074.632000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8666.385,
"heapDeltaBytes": 9819060,
"heapUsedBytes": 178837316,
"domNodes": 0,
"jsHeapTotalBytes": -24117248,
"scriptDurationMs": 150.77000000000007,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8571.446000000036,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8376.987,
"heapDeltaBytes": 15309532,
"heapUsedBytes": 178737108,
"domNodes": 0,
"jsHeapTotalBytes": -19660800,
"scriptDurationMs": 137.93100000000004,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 101.41299999997955,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.225999999999999,
"layouts": 2,
"layoutDurationMs": 1.2910000000000001,
"taskDurationMs": 71.15199999999999,
"heapDeltaBytes": 3033112,
"heapUsedBytes": 72301016,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.633,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 92.97600000002149,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.084999999999999,
"layouts": 2,
"layoutDurationMs": 0.939,
"taskDurationMs": 59.60100000000001,
"heapDeltaBytes": 2949864,
"heapUsedBytes": 72468112,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 3.565000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
christian-byrne
left a comment
There was a problem hiding this comment.
Clean cherry-pick of #18052 (1e98c37aa), no conflicts, same 15 files.
Verified on this head rather than assuming the file list means the content carried: notice rule is before:bg-muted-background, icon is muted-foreground, no weight pins left in the banner, the comfy-c logo and its plum-600/ink-700 raw-palette wrapper are gone from EmptyState, agent-scope is on the MessageFeedback dropdown, the RunNoticeBanner story carried, and no font-smoothing leaked into agentPanel.css (that stays parked in DES-1205).
Parent was approved with its residual risk stated; nothing changes on cloud/1.54.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #18794 +/- ##
=============================================
Coverage ? 83.81%
=============================================
Files ? 2113
Lines ? 125652
Branches ? 32145
=============================================
Hits ? 105313
Misses ? 20160
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Backport of #18052 to
cloud/1.54Automatically created by backport workflow.