Repository navigation
[backport core/1.55] fix(agent): use a neutral color palette and lighter text in the agent panel - #18795
Conversation
… panel (#18052) ## Summary The agent side panel uses neutral colors and lighter text now. Linear: [DES-1043](https://linear.app/comfyorg/issue/DES-1043/des-use-a-more-neutral-color-palette-in-agent-panel) Taken over from @uytieu with his go-ahead in #agent-eng. Rebased onto main, and three things changed from his version. Details under **Handover changes** below. ## Changes - **What**: - The notice box had a blue line on the left and a blue icon. Both are neutral now. - The welcome screen had a yellow "C" logo in a box with a purple outline. The logo and the box are gone. That removes the panel's only raw-palette usage: `border-plum-600`, `bg-ink-700`, `text-brand-yellow`. - The workflow menu used the same yellow "C" to mark your choice. It uses a standard check mark now. - Hardcoded label weights in the panel drop to normal weight. - One menu did not receive the panel styles. It receives them now. Buttons keep their slightly bold text. That weight comes from `button.variants.ts`, which the whole product uses, not from this panel. [DES-1095](https://linear.app/comfyorg/issue/DES-1095/des-button-base-weight-is-font-medium-revisit-as-design-system-default) recorded that decision and closed it as intentional. ## Handover changes **1. The notice rule uses a background token, not a text token.** It was `before:bg-muted-foreground`. That is the secondary-text role (light `#494a50`, dark `#8a8a8a`), and filling a 4px rule with it inverts the role. `docs/guidance/design-standards.md` asks for the semantic role rather than whichever value lands right. It is `before:bg-muted-background` now, the neutral surface role already used as both a fill and a border elsewhere in `src` (light `#a0a0a0`, dark `#55565e`). No new token: design-standards says not to name one for the first component that wants it. **2. The weight pins are deleted, not restated.** Every one of those sites is a `p`/`span`/`div` with no weight-setting ancestor, so `font-normal` renders identically to no class at all. It only pins the value at the call site. Two `font-medium` labels that main's refactor moved out from under the original sweep are gone the same way, which finishes the DES-1043 checkbox. `font-normal` on a Button or a heading is load-bearing and was left alone: `button.variants.ts` bakes `font-medium` into the base class, and Tailwind Preflight is disabled host-wide so an `h2` still renders UA bold. The panel keeps about twenty of those. **3. Font smoothing is out of this PR, on scope grounds only.** `-webkit-font-smoothing: antialiased` was scoped to `:where(#agent-panel-root, .agent-scope)`. It reads better and should land, but there is no font-smoothing declaration anywhere else in the repo, so panel-scoped would make the agent panel the only surface rendering text differently from the rest of the product. That is a product-wide typography call. Parked in **[DES-1205](https://linear.app/comfyorg/issue/DES-1205)** with two ways to land it, whichever @uytieu and design prefer: a separate PR putting it in `packages/design-system/src/css/base.css` with a visual pass over high-traffic surfaces, or folding it into the design-system work Alex Tov and Alex Brown are running. Nothing is blocked on it. One note for that visual pass: grayscale AA thins strokes and change 2 drops this panel a weight step, so the two stack at `text-xs` and `text-[11px]/4` here. Not an argument against smoothing, just the pairing to look at first. ## Review Focus - `RunNoticeBanner` now has its own story in both themes. That is the surface this PR recolors, and #18693 rewrites the same markup to add a target-following context, so it earns a baseline of its own. - **Chromatic does not run on this PR.** `ci-tests-storybook.yaml` gates `chromatic-deployment` on `startsWith(github.head_ref, 'version-bump-')`, deliberately, since #5167. So no ordinary PR gets a visual diff, and Uy's original version of this change had no visual check either. `storybook-build` passing only means Storybook compiles. The new story starts paying off at the next version bump. ## Verification Chromatic dispatched manually on a throwaway branch came back `Snapshot quota reached`, so it compared nothing. Diffed the two Storybook builds locally instead, Uy's rebased state against this one, across all 42 shared agent stories in both themes. | | | |---|---| | Identical | 78 of 84 comparisons | | Different | the notice rule only, 352 px at a 4x90 box, in all three `AgentPanel` stories, both themes, byte-identical across two runs | Six more stories flagged on the first pass and were ruled out. `AgentMessage` composing/streaming and `ConsentCard` also differ when a build is diffed **against itself**, so they are animation phase. `AttachmentChip Uploading` and `AgentEntryButton Inviting` were stable across runs but come back byte-identical once `animation: none` is injected, and their sources are unchanged between the two commits. Every weight-pin deletion is a pixel-exact no-op. The only thing that moved is the rule. - The welcome screen is 64 pixels shorter. Check that the space above the greeting still looks correct. - Open the workflow menu. Check that the check mark reads as a choice. - The commits are separate on purpose. Any one can be dropped alone. ## Still blue, not in scope here Two `primary-background` usages survive in the panel and are worth a separate design call rather than a silent change: - `components/agent/composer/WorkflowSelectorChip.vue` — the blue dot marking the chosen workflow, the same signal as the check mark this PR de-yellowed. - `components/agent/message/MarkdownStream.vue` — link color in agent replies. (`crdt/CrdtDevPanel.vue` has four more. Dev-only, out of scope.) ## Screenshots The notice rule, cropped from the `AgentPanel` story in both themes with animations frozen. `muted-foreground` on the left, `muted-background` on the right.  Uy's original panel shot, which predates the token change. Accurate for the logo removal and the check mark, not for the rule color.  --------- Co-authored-by: bymyself <cbyrne@comfy.org>
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2122 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (19 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since a98216aca69eceb499622ed009caa3faf2539f00
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T05:19:32.179Z",
"gitSha": "49ef857c7b8417f455cf2b96c38ab87d069e20b1",
"branch": "backport-18052-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2022.8409999999712,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.28,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.76099999999997,
"heapDeltaBytes": -5709708,
"heapUsedBytes": 61884856,
"domNodes": -258,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.060000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2015.9940000000915,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.902000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.002,
"heapDeltaBytes": -8096688,
"heapUsedBytes": 59359788,
"domNodes": -257,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.275,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1726.3599999999997,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.570000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 782.079,
"heapDeltaBytes": 230404,
"heapUsedBytes": 67827188,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 140.695,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.25900000009,
"styleRecalcs": 48,
"styleRecalcDurationMs": 15.346999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 800.933,
"heapDeltaBytes": -419816,
"heapUsedBytes": 67153444,
"domNodes": -260,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 146.08499999999998,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.5600000000013,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.304,
"layouts": 6,
"layoutDurationMs": 1.2339999999999998,
"taskDurationMs": 352.721,
"heapDeltaBytes": 2089968,
"heapUsedBytes": 64497696,
"domNodes": 79,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.593000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.6880000000247,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.062,
"layouts": 6,
"layoutDurationMs": 1.272,
"taskDurationMs": 364.212,
"heapDeltaBytes": 3108564,
"heapUsedBytes": 70698652,
"domNodes": 80,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.853000000000005,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 627.4030000000153,
"styleRecalcs": 13,
"styleRecalcDurationMs": 8.193,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.35099999999994,
"heapDeltaBytes": 18989128,
"heapUsedBytes": 86534680,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 163.464,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 665.9059999999499,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.671999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.56600000000003,
"heapDeltaBytes": 18534412,
"heapUsedBytes": 86441660,
"domNodes": 24,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 154.258,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1132.0709999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 757.5520000000001,
"heapDeltaBytes": 12573880,
"heapUsedBytes": 84608500,
"domNodes": 0,
"jsHeapTotalBytes": 20344832,
"scriptDurationMs": 49.78000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 526,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1178.1409999999823,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 858.058,
"heapDeltaBytes": -17540068,
"heapUsedBytes": 73005532,
"domNodes": -292,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 55.489999999999995,
"eventListeners": -217,
"totalBlockingTimeMs": 511,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 773.9109999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.6100000000001,
"heapDeltaBytes": 14650044,
"heapUsedBytes": 91415080,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.84299999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 152,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 763.4699999999839,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.07999999999987,
"heapDeltaBytes": 14289348,
"heapUsedBytes": 90444324,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 125.20200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 150,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8759.100999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7769.585999999999,
"heapDeltaBytes": 3936196,
"heapUsedBytes": 86042840,
"domNodes": -14,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6237.4400000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 271,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9401.392999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8370.071,
"heapDeltaBytes": -7642224,
"heapUsedBytes": 74307808,
"domNodes": -14,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 6620.55,
"eventListeners": 0,
"totalBlockingTimeMs": 108,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9315.710999999965,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8206.632,
"heapDeltaBytes": 11828872,
"heapUsedBytes": 93933528,
"domNodes": -16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 6440.518,
"eventListeners": 0,
"totalBlockingTimeMs": 185,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8746.246000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7673.1359999999995,
"heapDeltaBytes": 4190840,
"heapUsedBytes": 82111516,
"domNodes": -273,
"jsHeapTotalBytes": 1826816,
"scriptDurationMs": 5945.811,
"eventListeners": -174,
"totalBlockingTimeMs": 64,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "large-graph-idle",
"durationMs": 2050.61900000004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.0120000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 595.316,
"heapDeltaBytes": -7006236,
"heapUsedBytes": 80004064,
"domNodes": -248,
"jsHeapTotalBytes": -233472,
"scriptDurationMs": 39.001999999999995,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2028.4510000000182,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.453,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.9699999999999,
"heapDeltaBytes": -3731656,
"heapUsedBytes": 83653128,
"domNodes": -242,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.992,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2529.5619999999985,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.883000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1711.5150000000003,
"heapDeltaBytes": -2758508,
"heapUsedBytes": 85267488,
"domNodes": -244,
"jsHeapTotalBytes": 1040384,
"scriptDurationMs": 843.514,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2308.993999999984,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.023999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1443.126,
"heapDeltaBytes": 18924340,
"heapUsedBytes": 84095188,
"domNodes": 8,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 785.6410000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3580.0690000000372,
"styleRecalcs": 64,
"styleRecalcDurationMs": 18.838000000000005,
"layouts": 60,
"layoutDurationMs": 15.941,
"taskDurationMs": 1580.396,
"heapDeltaBytes": -15615520,
"heapUsedBytes": 73739104,
"domNodes": -254,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 748.121,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3508.1100000001015,
"styleRecalcs": 63,
"styleRecalcDurationMs": 15.057,
"layouts": 60,
"layoutDurationMs": 15.621,
"taskDurationMs": 1544.4019999999998,
"heapDeltaBytes": 9416240,
"heapUsedBytes": 74656800,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 748.259,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3164.0670000000455,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.948,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1889.147,
"heapDeltaBytes": 21408104,
"heapUsedBytes": 87481348,
"domNodes": 6,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 930.6320000000002,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3123.4080000000404,
"styleRecalcs": 44,
"styleRecalcDurationMs": 10.788000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1965.1549999999997,
"heapDeltaBytes": -4365552,
"heapUsedBytes": 86762144,
"domNodes": -254,
"jsHeapTotalBytes": 184320,
"scriptDurationMs": 931.3939999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.0100000000461,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.516000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.5709999999999,
"heapDeltaBytes": 20475056,
"heapUsedBytes": 84568132,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.332999999999984,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2004.2809999999918,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.3329999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.6700000000001,
"heapDeltaBytes": 20254432,
"heapUsedBytes": 84710808,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.68300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 576.9579999999905,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.318999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.58500000000004,
"heapDeltaBytes": 13722144,
"heapUsedBytes": 83559672,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 131.511,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.2470000000385,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.572000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.43000000000006,
"heapDeltaBytes": 13692272,
"heapUsedBytes": 83711644,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 137.55700000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.4469999999942,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.913000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.24600000000004,
"heapDeltaBytes": 11358464,
"heapUsedBytes": 81480284,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.471,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.0559999999305,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.403,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 467.28700000000003,
"heapDeltaBytes": -6325800,
"heapUsedBytes": 63911740,
"domNodes": -275,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.921,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.0750000000312,
"styleRecalcs": 46,
"styleRecalcDurationMs": 14.833999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 736.605,
"heapDeltaBytes": -4315964,
"heapUsedBytes": 59027836,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 96.634,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.2000000000571,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.706,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 756.553,
"heapDeltaBytes": 7516688,
"heapUsedBytes": 77220984,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 100.02999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1349.8919999999544,
"styleRecalcs": 18,
"styleRecalcDurationMs": 25.10799999999999,
"layouts": 5,
"layoutDurationMs": 9.784,
"taskDurationMs": 842.163,
"heapDeltaBytes": 21420380,
"heapUsedBytes": 104079920,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 30.191999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8411.463000000025,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.753,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5606.862999999999,
"heapDeltaBytes": -10349788,
"heapUsedBytes": 76251336,
"domNodes": -242,
"jsHeapTotalBytes": 483328,
"scriptDurationMs": 2621.204,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8227.807999999983,
"styleRecalcs": 250,
"styleRecalcDurationMs": 46.37999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5617.407999999999,
"heapDeltaBytes": -7448332,
"heapUsedBytes": 79871408,
"domNodes": -243,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2610.6980000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14675.407000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14455.554999999998,
"heapDeltaBytes": -52204500,
"heapUsedBytes": 173263628,
"domNodes": -8061,
"jsHeapTotalBytes": -16261120,
"scriptDurationMs": 261.31100000000004,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14477.25099999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14179.313999999998,
"heapDeltaBytes": -72200012,
"heapUsedBytes": 168089700,
"domNodes": -8061,
"jsHeapTotalBytes": -17944576,
"scriptDurationMs": 222.10199999999998,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18049.020999999982,
"styleRecalcs": 127,
"styleRecalcDurationMs": 19.450999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17901.18,
"heapDeltaBytes": -45733728,
"heapUsedBytes": 168009008,
"domNodes": -8061,
"jsHeapTotalBytes": -10805248,
"scriptDurationMs": 897.0619999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 19,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14226.085000000012,
"styleRecalcs": 67,
"styleRecalcDurationMs": 15.335000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13898.848,
"heapDeltaBytes": -39980640,
"heapUsedBytes": 178821680,
"domNodes": -8061,
"jsHeapTotalBytes": -17309696,
"scriptDurationMs": 873.2869999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 54,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5382.213999999976,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.70999999999997,
"layouts": 20,
"layoutDurationMs": 24.602,
"taskDurationMs": 5322.401,
"heapDeltaBytes": -45137124,
"heapUsedBytes": 194949276,
"domNodes": -8062,
"jsHeapTotalBytes": 8757248,
"scriptDurationMs": 98.27699999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 227,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5421.703999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 71.957,
"layouts": 20,
"layoutDurationMs": 26.34499999999999,
"taskDurationMs": 5388.366999999999,
"heapDeltaBytes": -60785012,
"heapUsedBytes": 180590768,
"domNodes": -8061,
"jsHeapTotalBytes": 9760768,
"scriptDurationMs": 100.61700000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 351,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7080.741999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6997.1129999999985,
"heapDeltaBytes": 13547460,
"heapUsedBytes": 182769316,
"domNodes": 0,
"jsHeapTotalBytes": -22282240,
"scriptDurationMs": 109.94899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7466.194999999971,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7300.995999999999,
"heapDeltaBytes": -10117652,
"heapUsedBytes": 176304864,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 123.01600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 112.26199999998698,
"styleRecalcs": 10,
"styleRecalcDurationMs": 18.978,
"layouts": 5,
"layoutDurationMs": 2.401,
"taskDurationMs": 91.64,
"heapDeltaBytes": 3149808,
"heapUsedBytes": 68811608,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.531,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 465.3369999999768,
"styleRecalcs": 16,
"styleRecalcDurationMs": 22.564,
"layouts": 4,
"layoutDurationMs": 2.301,
"taskDurationMs": 130.58700000000002,
"heapDeltaBytes": 4902804,
"heapUsedBytes": 70610372,
"domNodes": 123,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.254999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
christian-byrne
left a comment
There was a problem hiding this comment.
Clean cherry-pick of #18052 (1e98c37aa), no conflicts, same 15 files.
Verified on this head rather than assuming the file list means the content carried: notice rule is before:bg-muted-background, icon is muted-foreground, no weight pins left in the banner, the comfy-c logo and its plum-600/ink-700 raw-palette wrapper are gone from EmptyState, agent-scope is on the MessageFeedback dropdown, the RunNoticeBanner story carried, and no font-smoothing leaked into agentPanel.css (that stays parked in DES-1205).
Parent was approved with its residual risk stated; nothing changes on core/1.55.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #18795 +/- ##
=============================================
- Coverage 84.59% 84.58% -0.01%
=============================================
Files 2294 2294
Lines 131267 131265 -2
Branches 35426 35425 -1
=============================================
- Hits 111044 111033 -11
- Misses 19923 19932 +9
Partials 300 300
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #18052 to
core/1.55Automatically created by backport workflow.