Skip to content

feat(billing): route top-up through the account billing SDK behind a flag (FE-2216) - #17665

Merged
dante01yoon merged 8 commits into
mainfrom
jaewon/fe-2216-phase-5-adopt-the-billing-sdk-in-comfyui_frontend-behind-a
Sep 15, 2026
Merged

dante01yoon merged 8 commits into
mainfrom
jaewon/fe-2216-phase-5-adopt-the-billing-sdk-in-comfyui_frontend-behind-a

Conversation

@dante01yoon

@dante01yoon dante01yoon commented Sep 14, 2026 •

Copy link
Copy Markdown
Collaborator

Why

Stacked on #17664 (the type-only BillingSession core change this consumer surfaced, split out of this PR) on top of the Phase 3 integration branch (jaewon/fe-2227-phase3-integration); slice 1 of FE-2216, top-up only; flag default off, so an unflagged build sees no behavior change.

First in-app consumer of @comfyorg/account/billing: with billing_sdk_topup_enabled on, top-up creation, hosted/in-page verification, resume, and the balance/capability refresh run on the SDK's operation lifecycle instead of billingOperationStore's poller. Existing billing test suites are untouched and pass.

Linear: https://linear.app/comfyorg/issue/FE-2216

How

  • billing_sdk_topup_enabled: server flag resolved fail-closed, declared exactly like embeddedCheckoutEnabled (enum, getter, telemetry evaluation).
  • Composition root src/platform/workspace/billing/sdk/createBillingSdk.ts (ports in, SDK out): createSessionBillingTransport over the auth store's one SessionClient with resolveUrl = workspaceApiUrl and the store's own mint target, the three Phase 2 readers, createBillingOperationLifecycle with pointerStorage: sessionStorage, embeddedCheckoutAvailable = embeddedCheckoutEnabled && VITE_STRIPE_PUBLISHABLE_KEY, the top-up command, and driveChallenge over a lazily loaded loadStripe port.
  • useBillingSdkStore (Pinia, once per app) wires it: one visibilitychange/focus handler calling lifecycle.wake(), the SDK telemetry mapped onto trackBillingEvent's operation shape (billingSdkTelemetry.ts), progress toast, one auto-driven in-page challenge per operation, and, for an operation this tab reattached to, the refresh / dialog close / settings open / toast the poller performs today.
  • topupOperationView.ts projects SDK state onto the operation record the dialog reads and TopupResult onto the CreateTopupResponse it handles (ok → completed, declined → failed, refusals → WorkspaceApiError with the code, so the dialog's NO_PAYMENT_METHOD copy still fires).
  • useWorkspaceBilling.topup() and its pending-op recovery in fetchStatus() branch on the flag; the flag-off body is unchanged. The dialog consults useTopupOperation() for isAddingCredits / topupActionOperation / retry / dismiss (6 lines in the script; handleBuy untouched) — projecting into the poller's store would have started its own polling loop on the same id.
  • workspaceAuthStore exposes getUnifiedSessionClient() and getUnifiedMintWorkspaceId(); no second session client.
  • Package (type-only): BillingSession = Pick<SessionClient, 'getSnapshot' | 'subscribe' | 'ensureFresh' | 'remint'> replaces SessionClient in the billing option types. The app's client is SessionClient<User> and attachIdentity is contravariant in the user, so the first real consumer could not be typed against the full client.
  • Tests: dual-path suites for the wrapper (useWorkspaceBilling.sdk.test.ts), the dialog adapter, the store, the projections, the telemetry mapping, and the composition root over a fake session + fetch (bearer, idempotency key, mint target, pointer storage, port-driven challenge). Flag test mirrors embeddedCheckoutEnabled.

Not routed through the SDK without touching call sites (listed, not faked):

  • topup_id: the SDK surfaces only billing_op_id; the projected response carries topup_id: ''. Nothing reads it.
  • Unsettled outcomes (timed_out, reconciliation_needed): the wrapper resolves undefined, which the dialog reports as failure_category: 'unknown' rather than the poller's operation.timeout / reconciliation_needed. The timeout toast still shows and the reconciliation id stays visible through the operation view.
  • Refusals without an HTTP status (NO_PAYMENT_METHOD — the SDK drops the status; capability denial; invalid amount; route absent) are bucketed network by categorizeBillingApiError instead of api_rejected. Follow-up for 3C: carry httpStatus on TopupNoPaymentMethod.
  • Telemetry for a dialog-issued top-up is emitted by the dialog exactly as before; the SDK's events are forwarded only for resumed operations. If begin adopts a backend-pending top-up under a dialog click, both report it.
  • Resume is triggered from fetchStatus() only when the server reports a pending top-up; the tab pointer alone (server unreachable) is not probed on load.
  • The rail is fixed when the dialog opens; a flag flip mid-operation does not move a live operation between observers.
  • Failure toast detail for SDK refusals is the generic credits.topUp.unknownError copy (no server text, by design); an unloadable Stripe port fails the challenge with the generic authentication copy rather than authenticationUnavailable.
  • The wrapper does not hold isLoading on the SDK path (it resolves at settlement); the dialog locks itself.

Size: ~560 new non-test lines + ~115 modified (27 in the package). The composition root is 115 lines; the Pinia wiring is the bulk. Splitting root + package narrowing + auth accessors + flag into a flag-less parent PR is possible if preferred.

AS-IS / TO-BE

No UI surface change, no screenshots.

  • AS-IS: topup() posts through workspaceApi, the dialog hands a pending id to billingOperationStore, which polls, drives Stripe, and refreshes.
  • TO-BE (flag on): topup() runs createTopupCommand(...).createTopupCheckout on the SDK lifecycle; the dialog reads the same operation shape from useTopupOperation(); the SDK store owns wake, challenge, toast, and resumed-operation effects. Flag off: byte-identical call path.

Stack (2026-09-14)

Merge top-down. After a parent is squash-merged, rebase each child with git rebase --onto origin/main <parent tip> and force-push; GitHub retargets the base. Solid edges are code dependencies, dashed edges are sequencing.

flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104ac3<br/>before 2026-09-30"] -.-> E
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
Loading

@coderabbitai

coderabbitai Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: b2ddc13a-fbcc-46f2-937e-1b37d747a1f0

📥 Commits

Reviewing files that changed from the base of the PR and between 63c94bf and f42eb60.

📒 Files selected for processing (10)
  • src/composables/useFeatureFlags.test.ts
  • src/composables/useFeatureFlags.ts
  • src/platform/workspace/billing/sdk/createBillingSdk.test.ts
  • src/platform/workspace/billing/sdk/createBillingSdk.ts
  • src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.test.ts
  • src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue
  • src/platform/workspace/composables/useTopupOperation.test.ts
  • src/platform/workspace/composables/useTopupOperation.ts
  • src/platform/workspace/composables/useWorkspaceBilling.sdk.test.ts
  • src/platform/workspace/composables/useWorkspaceBilling.ts

Included review availability: Your plan provides up to 8 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

The pull request adds a billing SDK top-up flow, feature-flagged routing, operation projections, lifecycle handling, telemetry mapping, challenge support, workspace integration, and tests for SDK and poller behavior.

Changes

Billing SDK top-up flow

Layer / File(s) Summary
SDK composition and operation projection
src/platform/workspace/billing/sdk/*
The SDK now composes billing readers, lifecycle handling, top-up commands, challenge loading, telemetry mapping, and dialog-facing operation projections.
SDK store and lifecycle handling
src/platform/workspace/billing/sdk/billingSdkStore.ts, src/platform/workspace/billing/sdk/billingSdkStore.test.ts
The Pinia store manages operation snapshots, progress toasts, challenges, recovery, settings refreshes, telemetry, dismissal, and lifecycle wake events.
Feature-flagged workspace integration
src/composables/useFeatureFlags.ts, src/platform/workspace/composables/*, src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue, src/platform/workspace/composables/useWorkspaceBilling.ts, src/platform/workspace/stores/workspaceAuthStore.ts
The new fail-closed flags select the SDK rail only when cloud distribution and unified authentication are enabled. Workspace billing and the top-up dialog delegate to the selected rail while preserving poller handling for other cases. Superseded purchase attempts no longer reset or close the dialog state.

Priority: ➖ Normal

Estimated code review effort: 4 (Complex) | ~60 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant TopUpDialog
  participant useTopupOperation
  participant BillingSdkStore
  participant BillingSdk
  participant BillingOperationLifecycle
  TopUpDialog->>useTopupOperation: submit top-up
  useTopupOperation->>BillingSdkStore: createTopup(amountCents)
  BillingSdkStore->>BillingSdk: createTopupCheckout
  BillingSdk->>BillingOperationLifecycle: publish operation state
  BillingOperationLifecycle-->>BillingSdkStore: lifecycle snapshot
  BillingSdkStore-->>TopUpDialog: operation view and result
Loading

Suggested reviewers: codejuggernaut, benceruleanlu

Merge Risk: 🟡 Moderate · up to f42eb

Timed-out SDK top-ups can unlock the dialog before the original operation is resolved, allowing another attempt. Resolve this state mapping before merge.


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore (reviewers only)

❌ Failed checks (1 error)

Check name Status Explanation Resolution
End-To-End Regression Coverage For Fixes ❌ Error The PR contains bug-fix signals: the commit subjects include fix(billing) multiple times. It changes frontend files under src/, and the changed-file list contains no browser_tests/ file. The PR … Add or update a Playwright regression test under browser_tests/. If an end-to-end test is not practical, add a concrete explanation in the PR description.
✅ Passed checks (6 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: routing billing top-ups through the account billing SDK behind a feature flag.
Description check ✅ Passed The description is detailed, on-topic, and covers the motivation, implementation, feature-flag behavior, review focus, tests, known limitations, and lack of screenshots. It does not use the repository…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Website End-To-End Regression Coverage ✅ Passed The changed-file list contains no files under apps/website/src/ or apps/website/public/. The PR changes workspace billing runtime files under src/ and adds tests, so this website-specific check …
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains billing, workspace, composable, and authentication files only. It contains no files under src/lib/litegraph/, src/ecs/, or files related to graph entities. The ADR c…
Full details: End-To-End Regression Coverage For Fixes

Explanation

The PR contains bug-fix signals: the commit subjects include fix(billing) multiple times. It changes frontend files under src/, and the changed-file list contains no browser_tests/ file. The PR description lists unit and affected-suite validation, but it does not give a concrete explanation for why an end-to-end regression test was not added.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jaewon/fe-2216-phase-5-adopt-the-billing-sdk-in-comfyui_frontend-behind-a

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2017 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1996 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/15/2026, 08:48:01 PM UTC

Links

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

📦 Bundle: 10 MB gzip 🔴 +16.1 kB

Details

Summary

  • Raw size: 42.6 MB baseline 42.5 MB — 🔴 +66.8 kB
  • Gzip: 10 MB baseline 10 MB — 🔴 +16.1 kB
  • Brotli: 7.07 MB baseline 7.06 MB — 🔴 +12.3 kB
  • Bundles: 451 current • 451 baseline • 153 added / 153 removed

Category Glance
Data & Services 🔴 +66 kB (3.8 MB) · Other 🔴 +425 B (17.5 MB) · Utilities & Hooks 🔴 +374 B (561 kB) · Graph Workspace 🔴 +1 B (1.44 MB) · UI Components 🔴 +1 B (123 kB) · Vendor & Third-Party ⚪ 0 B (18.2 MB) · + 5 more

App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 B

Main entry bundles and manifests

File Before After Δ Raw Δ Gzip Δ Brotli
assets/index-DWhwnaH7.js (new) — 3.73 kB 🔴 +3.73 kB 🔴 +1.87 kB 🔴 +1.61 kB
assets/index-npAAMmxr.js (removed) 3.73 kB — 🟢 -3.73 kB 🟢 -1.87 kB 🟢 -1.63 kB

Status: 1 added / 1 removed

Graph Workspace — 1.44 MB (baseline 1.44 MB) • 🔴 +1 B

Graph editor runtime, canvas, workflow orchestration

File Before After Δ Raw Δ Gzip Δ Brotli
assets/GraphView-Ce5N0QxR.js (new) — 1.43 MB 🔴 +1.43 MB 🔴 +314 kB 🔴 +235 kB
assets/GraphView-C9oXArsV.js (removed) 1.43 MB — 🟢 -1.43 MB 🟢 -314 kB 🟢 -235 kB
assets/WidgetCompositor-BMZF4TzL.js (new) — 8.5 kB 🔴 +8.5 kB 🔴 +2.8 kB 🔴 +2.48 kB
assets/WidgetCompositor-CCy4C946.js (removed) 8.5 kB — 🟢 -8.5 kB 🟢 -2.8 kB 🟢 -2.48 kB

Status: 2 added / 2 removed / 1 unchanged

Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

File Before After Δ Raw Δ Gzip Δ Brotli
assets/CloudSurveyView-CLcDTIa1.js (removed) 25 kB — 🟢 -25 kB 🟢 -6.25 kB 🟢 -5.52 kB
assets/CloudSurveyView-CzYdaSgF.js (new) — 25 kB 🔴 +25 kB 🔴 +6.25 kB 🔴 +5.52 kB
assets/CloudLayoutView-Dalkmn3g.js (new) — 21.7 kB 🔴 +21.7 kB 🔴 +6.56 kB 🔴 +5.73 kB
assets/CloudLayoutView-INdua5Yu.js (removed) 21.7 kB — 🟢 -21.7 kB 🟢 -6.55 kB 🟢 -5.73 kB
assets/useCloudAuthPage-BcKPBN-T.js (new) — 11 kB 🔴 +11 kB 🔴 +4.18 kB 🔴 +3.53 kB
assets/useCloudAuthPage-dmmJrLXa.js (removed) 11 kB — 🟢 -11 kB 🟢 -4.18 kB 🟢 -3.53 kB
assets/CloudLoginView-BhW4Dnht.js (removed) 8.74 kB — 🟢 -8.74 kB 🟢 -2.56 kB 🟢 -2.26 kB
assets/CloudLoginView-CNSkfcDd.js (new) — 8.74 kB 🔴 +8.74 kB 🔴 +2.56 kB 🔴 +2.25 kB
assets/UserCheckView-Bt9fIx70.js (new) — 8.51 kB 🔴 +8.51 kB 🔴 +2.14 kB 🔴 +1.86 kB
assets/UserCheckView-C9xdFKoB.js (removed) 8.51 kB — 🟢 -8.51 kB 🟢 -2.13 kB 🟢 -1.86 kB
assets/CloudSignupView-C3JU-At2.js (removed) 6.96 kB — 🟢 -6.96 kB 🟢 -2.28 kB 🟢 -2 kB
assets/CloudSignupView-D3FkY7jU.js (new) — 6.96 kB 🔴 +6.96 kB 🔴 +2.27 kB 🔴 +2 kB
assets/WidgetTextPreview-BkV31xGu.js (removed) 6.06 kB — 🟢 -6.06 kB 🟢 -2.12 kB 🟢 -1.89 kB
assets/WidgetTextPreview-Dh7pRCjY.js (new) — 6.06 kB 🔴 +6.06 kB 🔴 +2.12 kB 🔴 +1.89 kB
assets/CloudSubscriptionRedirectView-DZTHLXG0.js (new) — 5.69 kB 🔴 +5.69 kB 🔴 +1.93 kB 🔴 +1.7 kB
assets/CloudSubscriptionRedirectView-FSLb70wM.js (removed) 5.69 kB — 🟢 -5.69 kB 🟢 -1.94 kB 🟢 -1.7 kB
assets/UserSelectView-DPCCk6az.js (new) — 5.63 kB 🔴 +5.63 kB 🔴 +2 kB 🔴 +1.75 kB
assets/UserSelectView-Dr2mT_uh.js (removed) 5.63 kB — 🟢 -5.63 kB 🟢 -2 kB 🟢 -1.75 kB
assets/CloudForgotPasswordView-BmWZihfM.js (removed) 5 kB — 🟢 -5 kB 🟢 -1.72 kB 🟢 -1.5 kB
assets/CloudForgotPasswordView-SQSXiH78.js (new) — 5 kB 🔴 +5 kB 🔴 +1.72 kB 🔴 +1.5 kB
assets/CloudAuthTimeoutView-0usbkqgL.js (new) — 4.43 kB 🔴 +4.43 kB 🔴 +1.54 kB 🔴 +1.34 kB
assets/CloudAuthTimeoutView-CA4RBzFJ.js (removed) 4.43 kB — 🟢 -4.43 kB 🟢 -1.54 kB 🟢 -1.34 kB
assets/WidgetResolutionPreview-B4AXN0i_.js (removed) 3.78 kB — 🟢 -3.78 kB 🟢 -1.49 kB 🟢 -1.33 kB
assets/WidgetResolutionPreview-DwNX4civ.js (new) — 3.78 kB 🔴 +3.78 kB 🔴 +1.49 kB 🔴 +1.33 kB
assets/OAuthLayoutView-CwemDmmh.js (new) — 1.32 kB 🔴 +1.32 kB 🔴 +707 B 🔴 +596 B
assets/OAuthLayoutView-hQf1mD_L.js (removed) 1.32 kB — 🟢 -1.32 kB 🟢 -705 B 🟢 -594 B
assets/WidgetTextPreview-BPQ9x1Z9.js (removed) 131 B — 🟢 -131 B 🟢 -100 B 🟢 -88 B
assets/WidgetTextPreview-C1imbooL.js (new) — 131 B 🔴 +131 B 🔴 +100 B 🔴 +89 B

Status: 14 added / 14 removed / 4 unchanged

Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

File Before After Δ Raw Δ Gzip Δ Brotli
assets/KeybindingPanel-CXJlftg_.js (new) — 49.4 kB 🔴 +49.4 kB 🔴 +9.95 kB 🔴 +8.79 kB
assets/KeybindingPanel-I5Uauej9.js (removed) 49.4 kB — 🟢 -49.4 kB 🟢 -9.95 kB 🟢 -8.81 kB
assets/CreditsPanel-CS6VxcLk.js (new) — 38 kB 🔴 +38 kB 🔴 +9.12 kB 🔴 +7.98 kB
assets/CreditsPanel-Dsu9K7qm.js (removed) 38 kB — 🟢 -38 kB 🟢 -9.12 kB 🟢 -7.98 kB
assets/SecretsPanel-CxCUWiMl.js (new) — 33.8 kB 🔴 +33.8 kB 🔴 +7.9 kB 🔴 +6.93 kB
assets/SecretsPanel-DaQ_xfmN.js (removed) 33.8 kB — 🟢 -33.8 kB 🟢 -7.9 kB 🟢 -6.93 kB
assets/AboutPanel-D5XmLeEG.js (removed) 11.4 kB — 🟢 -11.4 kB 🟢 -3.14 kB 🟢 -2.81 kB
assets/AboutPanel-DzNMyIUg.js (new) — 11.4 kB 🔴 +11.4 kB 🔴 +3.14 kB 🔴 +2.8 kB
assets/ExtensionPanel-C8JG1O3z.js (removed) 9.19 kB — 🟢 -9.19 kB 🟢 -2.52 kB 🟢 -2.23 kB
assets/ExtensionPanel-en9_L_ub.js (new) — 9.19 kB 🔴 +9.19 kB 🔴 +2.51 kB 🔴 +2.23 kB
assets/ServerConfigPanel-BR3y6lP5.js (removed) 6.15 kB — 🟢 -6.15 kB 🟢 -1.96 kB 🟢 -1.74 kB
assets/ServerConfigPanel-Cj4JkVQc.js (new) — 6.15 kB 🔴 +6.15 kB 🔴 +1.96 kB 🔴 +1.74 kB
assets/UserPanel-CMLuS_CY.js (new) — 5.76 kB 🔴 +5.76 kB 🔴 +1.8 kB 🔴 +1.55 kB
assets/UserPanel-DC_nd3Py.js (removed) 5.76 kB — 🟢 -5.76 kB 🟢 -1.8 kB 🟢 -1.55 kB
assets/refreshRemoteConfig-DQNqoDfY.js (new) — 4.54 kB 🔴 +4.54 kB 🔴 +1.61 kB 🔴 +1.43 kB
assets/refreshRemoteConfig-DrJ2d5ud.js (removed) 4.54 kB — 🟢 -4.54 kB 🟢 -1.61 kB 🟢 -1.43 kB
assets/CreditsPanel-BN17QIVk.js (removed) 116 B — 🟢 -116 B 🟢 -95 B 🟢 -87 B
assets/CreditsPanel-CdJ_2Oco.js (new) — 116 B 🔴 +116 B 🔴 +95 B 🔴 +87 B
assets/refreshRemoteConfig-C0xAbym_.js (new) — 110 B 🔴 +110 B 🔴 +89 B 🔴 +88 B
assets/refreshRemoteConfig-CY3xZILi.js (removed) 110 B — 🟢 -110 B 🟢 -89 B 🟢 -81 B

Status: 10 added / 10 removed / 17 unchanged

User & Accounts — 32.3 kB (baseline 32.3 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/SignUpForm-6NJDy3uC.js (removed) 15.7 kB — 🟢 -15.7 kB 🟢 -5.1 kB 🟢 -4.44 kB
assets/SignUpForm-pKfAK0jl.js (new) — 15.7 kB 🔴 +15.7 kB 🔴 +5.1 kB 🔴 +4.43 kB
assets/auth-CGQ6yKdj.js (new) — 3.48 kB 🔴 +3.48 kB 🔴 +1.21 kB 🔴 +1.01 kB
assets/auth-DNdBfXzl.js (removed) 3.48 kB — 🟢 -3.48 kB 🟢 -1.2 kB 🟢 -1.01 kB
assets/UpdatePasswordContent-CrvwoORr.js (removed) 1.85 kB — 🟢 -1.85 kB 🟢 -843 B 🟢 -733 B
assets/UpdatePasswordContent-DArqsVWO.js (new) — 1.85 kB 🔴 +1.85 kB 🔴 +840 B 🔴 +733 B
assets/authStore-Db6Rj360.js (new) — 126 B 🔴 +126 B 🔴 +106 B 🔴 +101 B
assets/authStore-DLNoDxsO.js (removed) 126 B — 🟢 -126 B 🟢 -106 B 🟢 -102 B
assets/workspaceAuthStore-CC5UwQl2.js (removed) 108 B — 🟢 -108 B 🟢 -99 B 🟢 -105 B
assets/workspaceAuthStore-CLmKjL_w.js (new) — 108 B 🔴 +108 B 🔴 +99 B 🔴 +102 B
assets/auth-BR_IiPZ9.js (removed) 105 B — 🟢 -105 B 🟢 -96 B 🟢 -86 B
assets/auth-DWeu5LSe.js (new) — 105 B 🔴 +105 B 🔴 +96 B 🔴 +88 B

Status: 6 added / 6 removed / 5 unchanged

Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

File Before After Δ Raw Δ Gzip Δ Brotli
assets/ComfyHubPublishDialog-Bk4nkAY2.js (removed) 90.8 kB — 🟢 -90.8 kB 🟢 -19.3 kB 🟢 -16.6 kB
assets/ComfyHubPublishDialog-CDIGpTY3.js (new) — 90.8 kB 🔴 +90.8 kB 🔴 +19.3 kB 🔴 +16.5 kB
assets/useShareDialog-CfCG3x1y.js (new) — 23.9 kB 🔴 +23.9 kB 🔴 +5.74 kB 🔴 +5.07 kB
assets/useShareDialog-CyEeCRoB.js (removed) 23.9 kB — 🟢 -23.9 kB 🟢 -5.74 kB 🟢 -5.08 kB
assets/feedbackDialog-DIoui7Nj.js (new) — 4.45 kB 🔴 +4.45 kB 🔴 +1.86 kB 🔴 +1.59 kB
assets/feedbackDialog-ls43LhsS.js (removed) 4.45 kB — 🟢 -4.45 kB 🟢 -1.87 kB 🟢 -1.59 kB
assets/useRangeEditor-aW26RgxF.js (removed) 3.29 kB — 🟢 -3.29 kB 🟢 -1.14 kB 🟢 -1.04 kB
assets/useRangeEditor-o9-g6aYF.js (new) — 3.29 kB 🔴 +3.29 kB 🔴 +1.14 kB 🔴 +1.03 kB
assets/useLayerEditor-APuoT99H.js (removed) 1.19 kB — 🟢 -1.19 kB 🟢 -564 B 🟢 -490 B
assets/useLayerEditor-D9rzpkrq.js (new) — 1.19 kB 🔴 +1.19 kB 🔴 +561 B 🔴 +487 B
assets/ComfyHubPublishDialog-bNiKUArP.js (new) — 143 B 🔴 +143 B 🔴 +105 B 🔴 +96 B
assets/ComfyHubPublishDialog-uGj57HMq.js (removed) 143 B — 🟢 -143 B 🟢 -105 B 🟢 -89 B
assets/useSubscriptionDialog-0Lespswi.js (new) — 107 B 🔴 +107 B 🔴 +101 B 🔴 +87 B
assets/useSubscriptionDialog-Dnx0hV9a.js (removed) 107 B — 🟢 -107 B 🟢 -101 B 🟢 -88 B

Status: 7 added / 7 removed / 1 unchanged

UI Components — 123 kB (baseline 123 kB) • 🔴 +1 B

Reusable component library chunks

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useMoreOptionsMenu-C8LlFPFD.js (new) — 47.8 kB 🔴 +47.8 kB 🔴 +11.5 kB 🔴 +9.97 kB
assets/useMoreOptionsMenu-DKcFp6v6.js (removed) 47.8 kB — 🟢 -47.8 kB 🟢 -11.5 kB 🟢 -9.96 kB
assets/ComfyQueueButton-BppdqISi.js (removed) 14.6 kB — 🟢 -14.6 kB 🟢 -3.98 kB 🟢 -3.53 kB
assets/ComfyQueueButton-BtrHzGPd.js (new) — 14.6 kB 🔴 +14.6 kB 🔴 +3.98 kB 🔴 +3.53 kB
assets/useTerminalTabs-DGD_0m_E.js (removed) 11.8 kB — 🟢 -11.8 kB 🟢 -3.71 kB 🟢 -3.28 kB
assets/useTerminalTabs-qzaZ1_PR.js (new) — 11.8 kB 🔴 +11.8 kB 🔴 +3.71 kB 🔴 +3.28 kB
assets/InviteMembersForm-BHH25EvF.js (new) — 10.2 kB 🔴 +10.2 kB 🔴 +3.1 kB 🔴 +2.77 kB
assets/InviteMembersForm-CByjGGrY.js (removed) 10.2 kB — 🟢 -10.2 kB 🟢 -3.1 kB 🟢 -2.76 kB
assets/SubscribeButton-CBNgdmAf.js (new) — 2.15 kB 🔴 +2.15 kB 🔴 +968 B 🔴 +849 B
assets/SubscribeButton-PuPHKes0.js (removed) 2.15 kB — 🟢 -2.15 kB 🟢 -969 B 🟢 -849 B
assets/cloudFeedbackTopbarButton-BmQAiLJF.js (removed) 701 B — 🟢 -701 B 🟢 -420 B 🟢 -381 B
assets/cloudFeedbackTopbarButton-IuO0Ho4g.js (new) — 701 B 🔴 +701 B 🔴 +419 B 🔴 +378 B
assets/ComfyQueueButton-CuJwMVV7.js (new) — 128 B 🔴 +128 B 🔴 +99 B 🔴 +91 B
assets/ComfyQueueButton-DUDQploO.js (removed) 128 B — 🟢 -128 B 🟢 -99 B 🟢 -91 B

Status: 7 added / 7 removed / 9 unchanged

Data & Services — 3.8 MB (baseline 3.73 MB) • 🔴 +66 kB

Stores, services, APIs, and repositories

File Before After Δ Raw Δ Gzip Δ Brotli
assets/settingStore-BeiQGeXa.js (new) — 3.47 MB 🔴 +3.47 MB 🔴 +823 kB 🔴 +621 kB
assets/settingStore-B3JbWDaH.js (removed) 3.4 MB — 🟢 -3.4 MB 🟢 -807 kB 🟢 -609 kB
assets/api-C7Eq8FzP.js (new) — 180 kB 🔴 +180 kB 🔴 +41.4 kB 🔴 +34.8 kB
assets/api-CtButj6W.js (removed) 179 kB — 🟢 -179 kB 🟢 -41.1 kB 🟢 -34.6 kB
assets/load3dService-Cmel41ud.js (new) — 86.9 kB 🔴 +86.9 kB 🔴 +20.3 kB 🔴 +17.5 kB
assets/load3dService-zf50NJkP.js (removed) 86.9 kB — 🟢 -86.9 kB 🟢 -20.3 kB 🟢 -17.6 kB
assets/releaseStore-BE-YRxzp.js (new) — 23.8 kB 🔴 +23.8 kB 🔴 +7.07 kB 🔴 +6.21 kB
assets/releaseStore-BrV7jyXC.js (removed) 23.8 kB — 🟢 -23.8 kB 🟢 -7.07 kB 🟢 -6.2 kB
assets/workflowShareService-BIEOwHIC.js (removed) 17 kB — 🟢 -17 kB 🟢 -5.06 kB 🟢 -4.47 kB
assets/workflowShareService-Bn7hrE4d.js (new) — 17 kB 🔴 +17 kB 🔴 +5.06 kB 🔴 +4.47 kB
assets/keybindingService-C5PXe105.js (new) — 6.95 kB 🔴 +6.95 kB 🔴 +1.74 kB 🔴 +1.51 kB
assets/keybindingService-CwfgpFtB.js (removed) 6.95 kB — 🟢 -6.95 kB 🟢 -1.74 kB 🟢 -1.51 kB
assets/userStore-B0zQ03hI.js (new) — 2.38 kB 🔴 +2.38 kB 🔴 +900 B 🔴 +794 B
assets/userStore-C6Sbt6zC.js (removed) 2.38 kB — 🟢 -2.38 kB 🟢 -898 B 🟢 -794 B
assets/audioService-BA45dO7s.js (removed) 1.71 kB — 🟢 -1.71 kB 🟢 -828 B 🟢 -726 B
assets/audioService-CIACx9Es.js (new) — 1.71 kB 🔴 +1.71 kB 🔴 +831 B 🔴 +727 B
assets/dialogService-BytiPZOz.js (removed) 97 B — 🟢 -97 B 🟢 -96 B 🟢 -75 B
assets/dialogService-D3WU96k1.js (new) — 97 B 🔴 +97 B 🔴 +96 B 🔴 +81 B
assets/releaseStore-CDFKbLhN.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +85 B
assets/releaseStore-Cy2K-EcX.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -85 B
assets/settingStore-BQhRTqkj.js (removed) 95 B — 🟢 -95 B 🟢 -86 B 🟢 -86 B
assets/settingStore-us9yh1-_.js (new) — 95 B 🔴 +95 B 🔴 +86 B 🔴 +85 B
assets/assetsStore-Be4QHgSE.js (removed) 94 B — 🟢 -94 B 🟢 -92 B 🟢 -84 B
assets/assetsStore-QOJtJGMB.js (new) — 94 B 🔴 +94 B 🔴 +92 B 🔴 +81 B
assets/api-DFDHsK21.js (removed) 62 B — 🟢 -62 B 🟢 -74 B 🟢 -66 B
assets/api-wMij2oGV.js (new) — 62 B 🔴 +62 B 🔴 +74 B 🔴 +66 B

Status: 13 added / 13 removed / 3 unchanged

Utilities & Hooks — 561 kB (baseline 560 kB) • 🔴 +374 B

Helpers, composables, and utility bundles

File Before After Δ Raw Δ Gzip Δ Brotli
assets/useConflictDetection-CL97jW_W.js (new) — 235 kB 🔴 +235 kB 🔴 +53 kB 🔴 +43.2 kB
assets/useConflictDetection-jFrQ5cMI.js (removed) 235 kB — 🟢 -235 kB 🟢 -53 kB 🟢 -43.1 kB
assets/useLayerEditorSession-CJ3zSoqI.js (new) — 159 kB 🔴 +159 kB 🔴 +41 kB 🔴 +34.5 kB
assets/useLayerEditorSession-DNET864b.js (removed) 159 kB — 🟢 -159 kB 🟢 -41 kB 🟢 -34.5 kB
assets/useLoad3d-C4kKoKSu.js (new) — 26.3 kB 🔴 +26.3 kB 🔴 +5.95 kB 🔴 +5.27 kB
assets/useLoad3d-SSdyPrTa.js (removed) 26.3 kB — 🟢 -26.3 kB 🟢 -5.95 kB 🟢 -5.27 kB
assets/useLoad3dViewer-DvGABU0I.js (new) — 21.9 kB 🔴 +21.9 kB 🔴 +5.24 kB 🔴 +4.58 kB
assets/useLoad3dViewer-gIHshvaM.js (removed) 21.9 kB — 🟢 -21.9 kB 🟢 -5.25 kB 🟢 -4.58 kB
assets/useImageCrop-BBG-dkLT.js (removed) 15.3 kB — 🟢 -15.3 kB 🟢 -3.54 kB 🟢 -3.08 kB
assets/useImageCrop-BMWqIQ7U.js (new) — 15.3 kB 🔴 +15.3 kB 🔴 +3.53 kB 🔴 +3.08 kB
assets/useDowngradeToPersonal-Bj1lEwpW.js (new) — 11 kB 🔴 +11 kB 🔴 +2.78 kB 🔴 +2.39 kB
assets/useDowngradeToPersonal-CxtHXs-w.js (removed) 11 kB — 🟢 -11 kB 🟢 -2.78 kB 🟢 -2.39 kB
assets/useFeatureFlags-CRj7mJHD.js (new) — 8.64 kB 🔴 +8.64 kB 🔴 +2.36 kB 🔴 +2.02 kB
assets/useFeatureFlags-DoqN0YS4.js (removed) 8.27 kB — 🟢 -8.27 kB 🟢 -2.25 kB 🟢 -1.92 kB
assets/useExternalLink-Br65MIdi.js (removed) 7.57 kB — 🟢 -7.57 kB 🟢 -2.54 kB 🟢 -2.17 kB
assets/useExternalLink-mmxftN64.js (new) — 7.57 kB 🔴 +7.57 kB 🔴 +2.55 kB 🔴 +2.18 kB
assets/usePricingTableUrlLoader-BtDJSANR.js (new) — 4.81 kB 🔴 +4.81 kB 🔴 +1.65 kB 🔴 +1.41 kB
assets/usePricingTableUrlLoader-K29F8zPY.js (removed) 4.81 kB — 🟢 -4.81 kB 🟢 -1.66 kB 🟢 -1.44 kB
assets/useCompositorLayers-CU64qyh2.js (new) — 2.93 kB 🔴 +2.93 kB 🔴 +855 B 🔴 +774 B
assets/useCompositorLayers-DNCaUe6D.js (removed) 2.93 kB — 🟢 -2.93 kB 🟢 -858 B 🟢 -774 B
assets/useScheduledPlanChange-D80rlf_7.js (removed) 2.4 kB — 🟢 -2.4 kB 🟢 -962 B 🟢 -837 B
assets/useScheduledPlanChange-Tl8EFvcm.js (new) — 2.4 kB 🔴 +2.4 kB 🔴 +961 B 🔴 +837 B
assets/useUpstreamValue-Cuh0X8zS.js (new) — 1.97 kB 🔴 +1.97 kB 🔴 +749 B 🔴 +660 B
assets/useUpstreamValue-DfdJr6Kz.js (removed) 1.97 kB — 🟢 -1.97 kB 🟢 -753 B 🟢 -699 B
assets/useWorkspaceTierLabel-B_PpqE49.js (new) — 1.97 kB 🔴 +1.97 kB 🔴 +843 B 🔴 +711 B
assets/useWorkspaceTierLabel-E6W6X1zB.js (removed) 1.97 kB — 🟢 -1.97 kB 🟢 -844 B 🟢 -712 B
assets/useSessionCookie-CH1xpiqW.js (new) — 688 B 🔴 +688 B 🔴 +354 B 🔴 +308 B
assets/useSessionCookie-CwBs8eL_.js (removed) 688 B — 🟢 -688 B 🟢 -353 B 🟢 -306 B
assets/useLoad3d-BIFJMVmc.js (removed) 311 B — 🟢 -311 B 🟢 -162 B 🟢 -147 B
assets/useLoad3d-DT65KEcA.js (new) — 311 B 🔴 +311 B 🔴 +162 B 🔴 +148 B
assets/useSessionCookie-BhsAMkIg.js (new) — 101 B 🔴 +101 B 🔴 +86 B 🔴 +83 B
assets/useSessionCookie-CZ0uVGDM.js (removed) 101 B — 🟢 -101 B 🟢 -86 B 🟢 -82 B
assets/useFeatureFlags-CV_7XzeN.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +80 B
assets/useFeatureFlags-RQ6Um-R6.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -81 B
assets/useLoad3dViewer-Ce4mA47Z.js (new) — 98 B 🔴 +98 B 🔴 +85 B 🔴 +86 B
assets/useLoad3dViewer-CsuaPsrC.js (removed) 98 B — 🟢 -98 B 🟢 -85 B 🟢 -92 B
assets/useCurrentUser-BksWGSdK.js (removed) 93 B — 🟢 -93 B 🟢 -94 B 🟢 -93 B
assets/useCurrentUser-CowahRkd.js (new) — 93 B 🔴 +93 B 🔴 +94 B 🔴 +91 B

Status: 19 added / 19 removed / 18 unchanged

Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 17.5 MB (baseline 17.5 MB) • 🔴 +425 B

Bundles that do not match a named category

File Before After Δ Raw Δ Gzip Δ Brotli
assets/core-DIOASc7g.js (new) — 119 kB 🔴 +119 kB 🔴 +30.9 kB 🔴 +26.1 kB
assets/core-DD3KqhUA.js (removed) 119 kB — 🟢 -119 kB 🟢 -30.9 kB 🟢 -26.1 kB
assets/WorkspaceSettingsPanelContent-D8ePo-Cv.js (removed) 110 kB — 🟢 -110 kB 🟢 -21.7 kB 🟢 -18.1 kB
assets/WorkspaceSettingsPanelContent-DrmkJJzV.js (new) — 110 kB 🔴 +110 kB 🔴 +21.7 kB 🔴 +18.1 kB
assets/SubscriptionTransitionPreviewWorkspace-B9ebeZwP.js (removed) 103 kB — 🟢 -103 kB 🟢 -20 kB 🟢 -17 kB
assets/SubscriptionTransitionPreviewWorkspace-zda_9bXh.js (new) — 103 kB 🔴 +103 kB 🔴 +20 kB 🔴 +17 kB
assets/WidgetSelect-BQ6c259d.js (removed) 88.6 kB — 🟢 -88.6 kB 🟢 -20.1 kB 🟢 -17.1 kB
assets/WidgetSelect-zqGf6wOH.js (new) — 88.6 kB 🔴 +88.6 kB 🔴 +20.1 kB 🔴 +17.1 kB
assets/Load3D-6F02SpQ6.js (new) — 82.4 kB 🔴 +82.4 kB 🔴 +13.6 kB 🔴 +11.4 kB
assets/Load3D-QBpi-pT-.js (removed) 82.4 kB — 🟢 -82.4 kB 🟢 -13.6 kB 🟢 -11.4 kB
assets/WidgetVideoEdit-Dl1WIKMi.js (new) — 73.2 kB 🔴 +73.2 kB 🔴 +17.4 kB 🔴 +15.2 kB
assets/WidgetVideoEdit-DpjQtvyF.js (removed) 73.2 kB — 🟢 -73.2 kB 🟢 -17.4 kB 🟢 -15.2 kB
assets/CameraInfo-b13leFzd.js (removed) 67 kB — 🟢 -67 kB 🟢 -14.5 kB 🟢 -12.7 kB
assets/CameraInfo-Cgo2cwKe.js (new) — 67 kB 🔴 +67 kB 🔴 +14.5 kB 🔴 +12.7 kB
assets/Preview3d-BbgcIaNM.js (removed) 52.6 kB — 🟢 -52.6 kB 🟢 -8.6 kB 🟢 -7.51 kB
assets/Preview3d-tEDKbk6K.js (new) — 52.6 kB 🔴 +52.6 kB 🔴 +8.59 kB 🔴 +7.5 kB
assets/SubscriptionRequiredDialogContentUnified-_G4jC-n7.js (removed) 52.4 kB — 🟢 -52.4 kB 🟢 -11 kB 🟢 -9.63 kB
assets/SubscriptionRequiredDialogContentUnified-BwkzYuJQ.js (new) — 52.4 kB 🔴 +52.4 kB 🔴 +11 kB 🔴 +9.65 kB
assets/Viewport3d-C9BM0hSq.js (new) — 48 kB 🔴 +48 kB 🔴 +10.2 kB 🔴 +9.01 kB
assets/Viewport3d-DfcDtKpP.js (removed) 48 kB — 🟢 -48 kB 🟢 -10.2 kB 🟢 -9.03 kB
assets/LayerEditorContent-DP3SjrtO.js (new) — 45.4 kB 🔴 +45.4 kB 🔴 +10.6 kB 🔴 +9.25 kB
assets/LayerEditorContent-eSUHQruX.js (removed) 45.4 kB — 🟢 -45.4 kB 🟢 -10.6 kB 🟢 -9.25 kB
assets/main-Bn-XEKD0.js (new) — 44 kB 🔴 +44 kB 🔴 +13.2 kB 🔴 +11.4 kB
assets/main-wtqw1nDc.js (removed) 44 kB — 🟢 -44 kB 🟢 -13.2 kB 🟢 -11.4 kB
assets/WidgetBoundingBoxes-CdBD-ZB4.js (removed) 33.8 kB — 🟢 -33.8 kB 🟢 -9.17 kB 🟢 -8.13 kB
assets/WidgetBoundingBoxes-Cjs0Bamf.js (new) — 33.8 kB 🔴 +33.8 kB 🔴 +9.17 kB 🔴 +8.13 kB
assets/WidgetPainter-BFTq4K5z.js (removed) 32.1 kB — 🟢 -32.1 kB 🟢 -7.89 kB 🟢 -6.98 kB
assets/WidgetPainter-CQt3cuhD.js (new) — 32.1 kB 🔴 +32.1 kB 🔴 +7.89 kB 🔴 +6.97 kB
assets/Load3dViewerContent-BHRWy81O.js (removed) 30.6 kB — 🟢 -30.6 kB 🟢 -6.21 kB 🟢 -5.38 kB
assets/Load3dViewerContent-DMOGbEfd.js (new) — 30.6 kB 🔴 +30.6 kB 🔴 +6.2 kB 🔴 +5.37 kB
assets/SubscriptionRequiredDialogContent-CAIulY2u.js (new) — 27.1 kB 🔴 +27.1 kB 🔴 +6.4 kB 🔴 +5.64 kB
assets/SubscriptionRequiredDialogContent-D0-DhF0M.js (removed) 27.1 kB — 🟢 -27.1 kB 🟢 -6.4 kB 🟢 -5.64 kB
assets/SubscriptionRequiredDialogContentWorkspace-DCLYKNkE.js (new) — 26.5 kB 🔴 +26.5 kB 🔴 +6.08 kB 🔴 +5.36 kB
assets/SubscriptionRequiredDialogContentWorkspace-DXxjVXsg.js (removed) 26.5 kB — 🟢 -26.5 kB 🟢 -6.08 kB 🟢 -5.37 kB
assets/initHostTelemetry-1g-NR44b.js (new) — 25.8 kB 🔴 +25.8 kB 🔴 +5.94 kB 🔴 +4.93 kB
assets/initHostTelemetry-CeUaa3ef.js (removed) 25.8 kB — 🟢 -25.8 kB 🟢 -5.94 kB 🟢 -4.92 kB
assets/load3d-BgZgpt3b.js (new) — 22.2 kB 🔴 +22.2 kB 🔴 +5.42 kB 🔴 +4.68 kB
assets/load3d-CY3zLEzO.js (removed) 22.2 kB — 🟢 -22.2 kB 🟢 -5.42 kB 🟢 -4.68 kB
assets/SignInContent-BhYkoSPy.js (new) — 20.7 kB 🔴 +20.7 kB 🔴 +5.23 kB 🔴 +4.57 kB
assets/SignInContent-ZT0efxSl.js (removed) 20.7 kB — 🟢 -20.7 kB 🟢 -5.23 kB 🟢 -4.57 kB
assets/CurrentUserPopoverWorkspace-BeY_Gkrp.js (removed) 18.1 kB — 🟢 -18.1 kB 🟢 -4.19 kB 🟢 -3.71 kB
assets/CurrentUserPopoverWorkspace-r3rMQqFN.js (new) — 18.1 kB 🔴 +18.1 kB 🔴 +4.19 kB 🔴 +3.71 kB
assets/WidgetRecordAudio-CcFhckGG.js (removed) 16.5 kB — 🟢 -16.5 kB 🟢 -4.59 kB 🟢 -4.09 kB
assets/WidgetRecordAudio-CFCZJbqe.js (new) — 16.5 kB 🔴 +16.5 kB 🔴 +4.59 kB 🔴 +4.11 kB
assets/WidgetInputNumber-DKU_fk4i.js (removed) 13.9 kB — 🟢 -13.9 kB 🟢 -3.63 kB 🟢 -3.2 kB
assets/WidgetInputNumber-v3BWr_al.js (new) — 13.9 kB 🔴 +13.9 kB 🔴 +3.63 kB 🔴 +3.21 kB
assets/WidgetRange-CitIxMjD.js (removed) 13.7 kB — 🟢 -13.7 kB 🟢 -3.55 kB 🟢 -3.13 kB
assets/WidgetRange-COzOGLoh.js (new) — 13.7 kB 🔴 +13.7 kB 🔴 +3.55 kB 🔴 +3.13 kB
assets/WaveAudioPlayer-D00Gs_Lc.js (new) — 12.9 kB 🔴 +12.9 kB 🔴 +3.49 kB 🔴 +3.05 kB
assets/WaveAudioPlayer-DCpA4gEs.js (removed) 12.9 kB — 🟢 -12.9 kB 🟢 -3.49 kB 🟢 -3.05 kB
assets/GlobalToast-BMAXhdI9.js (new) — 12.2 kB 🔴 +12.2 kB 🔴 +4.01 kB 🔴 +3.49 kB
assets/GlobalToast-sc5jBwMu.js (removed) 12.2 kB — 🟢 -12.2 kB 🟢 -4.01 kB 🟢 -3.49 kB
assets/WidgetCurve-BfIRaL1B.js (new) — 11.2 kB 🔴 +11.2 kB 🔴 +3.48 kB 🔴 +3.15 kB
assets/WidgetCurve-Djx0bJAI.js (removed) 11.2 kB — 🟢 -11.2 kB 🟢 -3.48 kB 🟢 -3.16 kB
assets/TeamWorkspacesDialogContent-DT7GjQT6.js (new) — 10.4 kB 🔴 +10.4 kB 🔴 +2.99 kB 🔴 +2.65 kB
assets/TeamWorkspacesDialogContent-sPUBPwrb.js (removed) 10.4 kB — 🟢 -10.4 kB 🟢 -2.99 kB 🟢 -2.65 kB
assets/types-DsD1IEsA.js (new) — 9.77 kB 🔴 +9.77 kB 🔴 +3.15 kB 🔴 +2.55 kB
assets/onboardingCloudRoutes-BvniJMO3.js (new) — 9.76 kB 🔴 +9.76 kB 🔴 +2.87 kB 🔴 +2.46 kB
assets/onboardingCloudRoutes-Ch4HJWyk.js (removed) 9.76 kB — 🟢 -9.76 kB 🟢 -2.86 kB 🟢 -2.45 kB
assets/types-Du99HPV-.js (removed) 9.34 kB — 🟢 -9.34 kB 🟢 -3.03 kB 🟢 -2.45 kB
assets/Load3DConfiguration-B5B8-SAC.js (removed) 8.88 kB — 🟢 -8.88 kB 🟢 -2.59 kB 🟢 -2.29 kB
assets/Load3DConfiguration-DNzDYut8.js (new) — 8.88 kB 🔴 +8.88 kB 🔴 +2.59 kB 🔴 +2.29 kB
assets/nodeTemplates-B8tNaW7x.js (removed) 8.64 kB — 🟢 -8.64 kB 🟢 -2.97 kB 🟢 -2.61 kB
assets/nodeTemplates-ChSgzyre.js (new) — 8.64 kB 🔴 +8.64 kB 🔴 +2.97 kB 🔴 +2.61 kB
assets/WidgetImageCrop-Bvlh9_hT.js (new) — 8.49 kB 🔴 +8.49 kB 🔴 +2.66 kB 🔴 +2.34 kB
assets/WidgetImageCrop-BZoTJC0e.js (removed) 8.49 kB — 🟢 -8.49 kB 🟢 -2.66 kB 🟢 -2.34 kB
assets/SetMemberCreditLimitDialogContent-CbQbotJY.js (new) — 8.47 kB 🔴 +8.47 kB 🔴 +2.34 kB 🔴 +2.05 kB
assets/SetMemberCreditLimitDialogContent-UAq4wLJm.js (removed) 8.47 kB — 🟢 -8.47 kB 🟢 -2.34 kB 🟢 -2.05 kB
assets/CloudRunButtonWrapper-CaLYCHvd.js (new) — 8.15 kB 🔴 +8.15 kB 🔴 +2.45 kB 🔴 +2.16 kB
assets/CloudRunButtonWrapper-CZVkLtKL.js (removed) 8.15 kB — 🟢 -8.15 kB 🟢 -2.45 kB 🟢 -2.16 kB
assets/WorkspaceSwitcherPopover-5qMCMXJ6.js (new) — 8.08 kB 🔴 +8.08 kB 🔴 +2.39 kB 🔴 +2.13 kB
assets/WorkspaceSwitcherPopover-Bt88M5qK.js (removed) 8.08 kB — 🟢 -8.08 kB 🟢 -2.39 kB 🟢 -2.13 kB
assets/NightlySurveyController-BpPgcTu5.js (removed) 7.5 kB — 🟢 -7.5 kB 🟢 -2.56 kB 🟢 -2.25 kB
assets/NightlySurveyController-CbtQRnE2.js (new) — 7.5 kB 🔴 +7.5 kB 🔴 +2.56 kB 🔴 +2.25 kB
assets/LayoutDefault-BV3443iM.js (removed) 7.41 kB — 🟢 -7.41 kB 🟢 -2.44 kB 🟢 -2.14 kB
assets/LayoutDefault-C9kfXFxG.js (new) — 7.41 kB 🔴 +7.41 kB 🔴 +2.44 kB 🔴 +2.14 kB
assets/missingModelMetadata-BQyAcr7F.js (removed) 6.52 kB — 🟢 -6.52 kB 🟢 -2.22 kB 🟢 -1.95 kB
assets/missingModelMetadata-wMMQbx8w.js (new) — 6.52 kB 🔴 +6.52 kB 🔴 +2.22 kB 🔴 +1.94 kB
assets/WidgetWithControl-C_UmWPrk.js (removed) 6.46 kB — 🟢 -6.46 kB 🟢 -2.64 kB 🟢 -2.32 kB
assets/WidgetWithControl-EVSPDAO6.js (new) — 6.46 kB 🔴 +6.46 kB 🔴 +2.64 kB 🔴 +2.32 kB
assets/CancelSubscriptionDialogContent-BxY_U9qj.js (new) — 6.05 kB 🔴 +6.05 kB 🔴 +2.01 kB 🔴 +1.76 kB
assets/CancelSubscriptionDialogContent-NcRjxb_r.js (removed) 6.05 kB — 🟢 -6.05 kB 🟢 -2.01 kB 🟢 -1.76 kB
assets/load3dPreviewExtensions-BDk3YLIE.js (new) — 5.88 kB 🔴 +5.88 kB 🔴 +1.81 kB 🔴 +1.6 kB
assets/load3dPreviewExtensions-VqRkrSoN.js (removed) 5.88 kB — 🟢 -5.88 kB 🟢 -1.81 kB 🟢 -1.6 kB
assets/ApiNodesSignInContent-BT1ejn96.js (new) — 5.68 kB 🔴 +5.68 kB 🔴 +2.02 kB 🔴 +1.78 kB
assets/ApiNodesSignInContent-CJiJPikC.js (removed) 5.68 kB — 🟢 -5.68 kB 🟢 -2.02 kB 🟢 -1.79 kB
assets/launchCancellationFlow-BwS5Eek0.js (removed) 5.18 kB — 🟢 -5.18 kB 🟢 -1.78 kB 🟢 -1.56 kB
assets/launchCancellationFlow-CBuheApm.js (new) — 5.18 kB 🔴 +5.18 kB 🔴 +1.78 kB 🔴 +1.58 kB
assets/CreateWorkspaceDialogContent-BD_TUeq_.js (removed) 5.12 kB — 🟢 -5.12 kB 🟢 -1.8 kB 🟢 -1.55 kB
assets/CreateWorkspaceDialogContent-DAXo4sHh.js (new) — 5.12 kB 🔴 +5.12 kB 🔴 +1.79 kB 🔴 +1.55 kB
assets/ChangeMemberRoleDialogContent-BV6RQgPK.js (new) — 4.97 kB 🔴 +4.97 kB 🔴 +1.64 kB 🔴 +1.43 kB
assets/ChangeMemberRoleDialogContent-DSerSkQB.js (removed) 4.97 kB — 🟢 -4.97 kB 🟢 -1.64 kB 🟢 -1.43 kB
assets/InviteMemberDialogContent-DHIb1a9u.js (removed) 4.94 kB — 🟢 -4.94 kB 🟢 -1.63 kB 🟢 -1.42 kB
assets/InviteMemberDialogContent-OyEZFsLf.js (new) — 4.94 kB 🔴 +4.94 kB 🔴 +1.63 kB 🔴 +1.42 kB
assets/EditWorkspaceDialogContent-B2GFSN82.js (removed) 4.93 kB — 🟢 -4.93 kB 🟢 -1.76 kB 🟢 -1.53 kB
assets/EditWorkspaceDialogContent-L-MtdyPW.js (new) — 4.93 kB 🔴 +4.93 kB 🔴 +1.76 kB 🔴 +1.53 kB
assets/WidgetTextarea-BbIem3ag.js (removed) 4.83 kB — 🟢 -4.83 kB 🟢 -1.88 kB 🟢 -1.64 kB
assets/WidgetTextarea-CrQq1XnE.js (new) — 4.83 kB 🔴 +4.83 kB 🔴 +1.88 kB 🔴 +1.64 kB
assets/saveMesh-B3gKzP9a.js (removed) 4.72 kB — 🟢 -4.72 kB 🟢 -1.5 kB 🟢 -1.33 kB
assets/saveMesh-CzIWs8Wj.js (new) — 4.72 kB 🔴 +4.72 kB 🔴 +1.5 kB 🔴 +1.33 kB
assets/ValueControlPopover-C3J9xyF1.js (new) — 4.49 kB 🔴 +4.49 kB 🔴 +1.55 kB 🔴 +1.38 kB
assets/ValueControlPopover-CY5jj9-s.js (removed) 4.49 kB — 🟢 -4.49 kB 🟢 -1.55 kB 🟢 -1.38 kB
assets/DeleteWorkspaceDialogContent-CdvELb4_.js (removed) 3.84 kB — 🟢 -3.84 kB 🟢 -1.44 kB 🟢 -1.24 kB
assets/DeleteWorkspaceDialogContent-DPlEzAhP.js (new) — 3.84 kB 🔴 +3.84 kB 🔴 +1.44 kB 🔴 +1.24 kB
assets/RemoveMemberDialogContent-C0q1UloF.js (new) — 3.76 kB 🔴 +3.76 kB 🔴 +1.38 kB 🔴 +1.2 kB
assets/RemoveMemberDialogContent-DbV2oavm.js (removed) 3.76 kB — 🟢 -3.76 kB 🟢 -1.39 kB 🟢 -1.2 kB
assets/RevokeInviteDialogContent-CAHv887Z.js (removed) 3.67 kB — 🟢 -3.67 kB 🟢 -1.39 kB 🟢 -1.21 kB
assets/RevokeInviteDialogContent-CsRTjbol.js (new) — 3.67 kB 🔴 +3.67 kB 🔴 +1.39 kB 🔴 +1.21 kB
assets/LeaveWorkspaceDialogContent-B7c5htnt.js (new) — 3.67 kB 🔴 +3.67 kB 🔴 +1.38 kB 🔴 +1.19 kB
assets/LeaveWorkspaceDialogContent-DlazkVI8.js (removed) 3.67 kB — 🟢 -3.67 kB 🟢 -1.38 kB 🟢 -1.19 kB
assets/InviteMemberUpsellDialogContent-C_8Rifeo.js (removed) 3.47 kB — 🟢 -3.47 kB 🟢 -1.24 kB 🟢 -1.09 kB
assets/InviteMemberUpsellDialogContent-Dhvj-m30.js (new) — 3.47 kB 🔴 +3.47 kB 🔴 +1.24 kB 🔴 +1.09 kB
assets/SubscribeToRun-DA6Lrc-I.js (removed) 3.34 kB — 🟢 -3.34 kB 🟢 -1.42 kB 🟢 -1.21 kB
assets/SubscribeToRun-OYMy3IVC.js (new) — 3.34 kB 🔴 +3.34 kB 🔴 +1.42 kB 🔴 +1.21 kB
assets/Media3DTop-3jA8sH8c.js (removed) 3.21 kB — 🟢 -3.21 kB 🟢 -1.27 kB 🟢 -1.1 kB
assets/Media3DTop-DAOD9gqC.js (new) — 3.21 kB 🔴 +3.21 kB 🔴 +1.27 kB 🔴 +1.1 kB
assets/load3dAdvanced-CEcvJCsz.js (new) — 2.82 kB 🔴 +2.82 kB 🔴 +1.09 kB 🔴 +952 B
assets/load3dAdvanced-rpSrhfcp.js (removed) 2.82 kB — 🟢 -2.82 kB 🟢 -1.1 kB 🟢 -957 B
assets/LocalRunButtonWrapper-BJApANML.js (new) — 2.49 kB 🔴 +2.49 kB 🔴 +1.14 kB 🔴 +1 kB
assets/LocalRunButtonWrapper-CWDPB-fG.js (removed) 2.49 kB — 🟢 -2.49 kB 🟢 -1.14 kB 🟢 -1 kB
assets/MediaAudioTop-B6gLa8x5.js (new) — 1.62 kB 🔴 +1.62 kB 🔴 +808 B 🔴 +669 B
assets/MediaAudioTop-BE9pg-1C.js (removed) 1.62 kB — 🟢 -1.62 kB 🟢 -809 B 🟢 -667 B
assets/paymentReturnUrl-CXVVQbu0.js (removed) 1.58 kB — 🟢 -1.58 kB 🟢 -784 B 🟢 -622 B
assets/paymentReturnUrl-DNGnuyzC.js (new) — 1.58 kB 🔴 +1.58 kB 🔴 +783 B 🔴 +628 B
assets/cameraInfo-CWtdKoXD.js (removed) 1.1 kB — 🟢 -1.1 kB 🟢 -571 B 🟢 -489 B
assets/cameraInfo-D7EJymxw.js (new) — 1.1 kB 🔴 +1.1 kB 🔴 +570 B 🔴 +490 B
assets/Load3DAdvanced-DXkMqGW7.js (removed) 761 B — 🟢 -761 B 🟢 -421 B 🟢 -359 B
assets/Load3DAdvanced-YcLVxCra.js (new) — 761 B 🔴 +761 B 🔴 +424 B 🔴 +358 B
assets/nightlyBadges-BUIOsCmD.js (removed) 411 B — 🟢 -411 B 🟢 -274 B 🟢 -231 B
assets/nightlyBadges-DMnGb_Jx.js (new) — 411 B 🔴 +411 B 🔴 +271 B 🔴 +235 B
assets/Load3dViewerContent-BLsE3isk.js (removed) 137 B — 🟢 -137 B 🟢 -103 B 🟢 -111 B
assets/Load3dViewerContent-C8X9yxY4.js (new) — 137 B 🔴 +137 B 🔴 +103 B 🔴 +92 B
assets/missingModelMetadata-C6FL7Ro9.js (removed) 125 B — 🟢 -125 B 🟢 -103 B 🟢 -103 B
assets/missingModelMetadata-x9OoBgyV.js (new) — 125 B 🔴 +125 B 🔴 +103 B 🔴 +103 B
assets/Load3DAdvanced-BlynW_UV.js (removed) 122 B — 🟢 -122 B 🟢 -97 B 🟢 -88 B
assets/Load3DAdvanced-BwV7x3tv.js (new) — 122 B 🔴 +122 B 🔴 +97 B 🔴 +101 B
assets/LayoutDefault-B_SnAins.js (removed) 119 B — 🟢 -119 B 🟢 -92 B 🟢 -88 B
assets/LayoutDefault-BA3rqRoj.js (new) — 119 B 🔴 +119 B 🔴 +92 B 🔴 +84 B
assets/WidgetLegacy-BMqCaOJk.js (new) — 117 B 🔴 +117 B 🔴 +106 B 🔴 +101 B
assets/WidgetLegacy-DtonAGhY.js (removed) 117 B — 🟢 -117 B 🟢 -106 B 🟢 -102 B
assets/workflowDraftStoreV2-B_zObHmm.js (removed) 112 B — 🟢 -112 B 🟢 -101 B 🟢 -108 B
assets/workflowDraftStoreV2-B9rT80B7.js (new) — 112 B 🔴 +112 B 🔴 +101 B 🔴 +107 B
assets/CameraInfo-d5GgT0ez.js (removed) 110 B — 🟢 -110 B 🟢 -93 B 🟢 -91 B
assets/CameraInfo-eeNVFnAJ.js (new) — 110 B 🔴 +110 B 🔴 +93 B 🔴 +91 B
assets/Load3D-BqvrlLoI.js (removed) 98 B — 🟢 -98 B 🟢 -89 B 🟢 -81 B
assets/Load3D-D-IWM26d.js (new) — 98 B 🔴 +98 B 🔴 +89 B 🔴 +82 B
assets/changeTracker-bmnsbR8O.js (new) — 92 B 🔴 +92 B 🔴 +94 B 🔴 +86 B
assets/changeTracker-NBdhz65S.js (removed) 92 B — 🟢 -92 B 🟢 -94 B 🟢 -87 B

Status: 74 added / 74 removed / 222 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.5 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 135ms TBT · 77.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.3 MB heap
vue-large-graph-idle: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.0 MB heap
vue-large-graph-pan: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 96ms TBT · 180.8 MB heap
vue-node-resize-workload: · 59.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 144ms TBT · 164.4 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 160.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap

⚠️ 7 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: heap used 69.6 MB 72.6 MB +4% ⚠️ z=3.0
canvas-idle: DOM nodes -262 -126 -52% ⚠️ z=3.0
canvas-idle: event listeners -154 -75 -51% ⚠️ z=3.1
large-graph-pan: p95 frame time 17ms 17ms -0% ⚠️ z=2.2
minimap-idle: style recalc duration 5ms 7ms +34% ⚠️ z=2.4
vue-large-graph-pan: heap used 158.3 MB 180.8 MB +14% ⚠️ z=2.3
workflow-execution: layout duration 2ms 3ms +57% ⚠️ z=2.2
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms -0% z=-0.7
canvas-idle: p95 frame time 17ms 17ms -1% z=-2.5
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 9ms 7ms -25% z=-0.8
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 9 7 -28% z=-2.5
canvas-idle: task duration 466ms 500ms +7% z=0.5
canvas-idle: script duration 8ms 11ms +33% z=0.6
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 69.6 MB 72.6 MB +4% ⚠️ z=3.0
canvas-idle: DOM nodes -262 -126 -52% ⚠️ z=3.0
canvas-idle: event listeners -154 -75 -51% ⚠️ z=3.1
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=0.5
canvas-mouse-sweep: p95 frame time 17ms 17ms -0% z=0.3
canvas-mouse-sweep: layout duration 4ms 5ms +8% z=0.5
canvas-mouse-sweep: style recalc duration 30ms 31ms +5% z=0.6
canvas-mouse-sweep: layout count 14 14 +0% —
canvas-mouse-sweep: style recalc count 75 75 +0% z=-0.3
canvas-mouse-sweep: task duration 863ms 955ms +11% z=1.0
canvas-mouse-sweep: script duration 163ms 160ms -2% z=0.2
canvas-mouse-sweep: TBT 0ms 0ms +0% variance too high
canvas-mouse-sweep: heap used 70.0 MB 60.7 MB -13% z=-1.2
canvas-mouse-sweep: DOM nodes -263 -263 -0% z=-0.6
canvas-mouse-sweep: event listeners -156 -185 +19% z=-2.2
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=-1.0
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% z=0.3
canvas-zoom-sweep: layout duration 1ms 1ms +10% z=0.9
canvas-zoom-sweep: style recalc duration 17ms 17ms +0% z=0.6
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 31 31 +0% z=-0.7
canvas-zoom-sweep: task duration 343ms 395ms +15% z=1.1
canvas-zoom-sweep: script duration 11ms 14ms +25% z=0.9
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 61.4 MB 61.5 MB +0% z=0.0
canvas-zoom-sweep: DOM nodes 75 75 +0% z=-0.8
canvas-zoom-sweep: event listeners 19 19 +0% z=-0.4
dom-widget-clipping: avg frame time 17ms 17ms +0% z=1.0
dom-widget-clipping: p95 frame time 17ms 17ms +0% z=0.1
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 9ms 9ms -4% z=1.1
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 12 11 -13% z=-0.6
dom-widget-clipping: task duration 452ms 502ms +11% z=1.1
dom-widget-clipping: script duration 164ms 176ms +7% z=0.8
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 76.4 MB 75.1 MB -2% z=-2.4
dom-widget-clipping: DOM nodes 20 17 -15% z=-0.6
dom-widget-clipping: event listeners 2 2 +0% z=0.7
large-graph-idle: avg frame time 17ms 17ms -0% z=-3.8
large-graph-idle: p95 frame time 17ms 17ms +0% z=-0.2
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 4ms 5ms +30% z=-0.6
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 4 5 +25% z=-0.6
large-graph-idle: task duration 560ms 680ms +21% z=1.1
large-graph-idle: script duration 35ms 35ms -1% z=0.2
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 79.3 MB 79.1 MB -0% z=0.8
large-graph-idle: DOM nodes -249 -248 -1% z=0.4
large-graph-idle: event listeners -182 -153 -16% z=0.5
large-graph-pan: avg frame time 17ms 17ms +0% z=1.1
large-graph-pan: p95 frame time 17ms 17ms -0% ⚠️ z=2.2
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 16ms 12ms -24% z=0.5
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 67 66 -1% z=-0.1
large-graph-pan: task duration 1714ms 1744ms +2% z=0.8
large-graph-pan: script duration 864ms 877ms +1% z=0.6
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 75.0 MB 79.6 MB +6% z=1.1
large-graph-pan: DOM nodes -251 -240 -4% z=-0.8
large-graph-pan: event listeners -182 -87 -52% z=0.7
large-graph-zoom: avg frame time 17ms 17ms -0% z=-0.6
large-graph-zoom: p95 frame time 17ms 17ms +0% z=0.4
large-graph-zoom: layout duration 13ms 14ms +10% z=0.7
large-graph-zoom: style recalc duration 13ms 11ms -12% z=-0.3
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 63 61 -4% z=-0.9
large-graph-zoom: task duration 1733ms 1871ms +8% z=1.0
large-graph-zoom: script duration 793ms 835ms +5% z=0.7
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 66.6 MB 71.4 MB +7% z=0.4
large-graph-zoom: DOM nodes -231 -128 -45% z=-0.0
large-graph-zoom: event listeners -178 10 -106% z=1.0
legacy-node-drag: avg frame time 17ms 17ms -0% z=-1.1
legacy-node-drag: p95 frame time 17ms 17ms -0% z=0.1
legacy-node-drag: layout duration 0ms 0ms +0% —
legacy-node-drag: style recalc duration 5ms 7ms +30% z=0.1
legacy-node-drag: layout count 0 0 +0% —
legacy-node-drag: style recalc count 40 41 +3% z=-0.6
legacy-node-drag: task duration 1921ms 2163ms +13% z=1.1
legacy-node-drag: script duration 986ms 1041ms +6% z=0.7
legacy-node-drag: TBT 0ms 0ms +0% —
legacy-node-drag: heap used 80.8 MB 86.6 MB +7% z=1.4
legacy-node-drag: DOM nodes 0 -131 — z=-0.6
legacy-node-drag: event listeners 188 94 -50% z=-1.0
minimap-idle: avg frame time 17ms 17ms +0% z=1.7
minimap-idle: p95 frame time 17ms 17ms -0% z=0.3
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 5ms 7ms +34% ⚠️ z=2.4
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 5 4 -20% z=-1.0
minimap-idle: task duration 598ms 666ms +11% z=0.9
minimap-idle: script duration 35ms 37ms +6% z=0.3
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 75.9 MB 80.5 MB +6% z=1.6
minimap-idle: DOM nodes -257 -252 -2% z=0.1
minimap-idle: event listeners -182 -154 -15% z=0.4
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% z=0.8
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -0% z=0.2
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 11ms 13ms +19% z=1.5
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 48 +1% z=1.6
subgraph-dom-widget-clipping: task duration 399ms 447ms +12% z=1.0
subgraph-dom-widget-clipping: script duration 141ms 149ms +6% z=0.7
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 73.5 MB 73.8 MB +0% z=0.7
subgraph-dom-widget-clipping: DOM nodes 20 21 +5% z=1.6
subgraph-dom-widget-clipping: event listeners 8 8 +0% z=1.2
subgraph-idle: avg frame time 17ms 17ms +0% z=1.0
subgraph-idle: p95 frame time 17ms 17ms +0% z=0.2
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 9ms 9ms -4% z=0.6
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 10 +0% z=1.0
subgraph-idle: task duration 465ms 551ms +18% z=1.2
subgraph-idle: script duration 8ms 12ms +46% z=1.4
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 65.3 MB 70.4 MB +8% z=1.2
subgraph-idle: DOM nodes -275 -276 +0% z=-0.3
subgraph-idle: event listeners -200 -200 +0% z=1.0
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=2.0
subgraph-mouse-sweep: p95 frame time 17ms 17ms -1% z=-2.1
subgraph-mouse-sweep: layout duration 6ms 6ms +13% z=1.3
subgraph-mouse-sweep: style recalc duration 27ms 30ms +12% z=0.8
subgraph-mouse-sweep: layout count 18 18 +0% —
subgraph-mouse-sweep: style recalc count 77 78 +1% z=0.1
subgraph-mouse-sweep: task duration 820ms 831ms +1% z=0.6
subgraph-mouse-sweep: script duration 115ms 116ms +1% z=0.6
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 65.8 MB 63.9 MB -3% z=-0.4
subgraph-mouse-sweep: DOM nodes -277 -275 -1% z=0.3
subgraph-mouse-sweep: event listeners -202 -200 -1% z=1.6
subgraph-transition-enter: avg frame time 17ms 17ms -0% z=0.2
subgraph-transition-enter: p95 frame time 17ms 17ms +0% z=-0.9
subgraph-transition-enter: layout duration 13ms 12ms -10% z=-0.1
subgraph-transition-enter: style recalc duration 29ms 27ms -7% z=-0.1
subgraph-transition-enter: layout count 5 5 +0% —
subgraph-transition-enter: style recalc count 18 17 -6% z=-0.2
subgraph-transition-enter: task duration 891ms 941ms +6% z=0.6
subgraph-transition-enter: script duration 29ms 32ms +8% z=0.4
subgraph-transition-enter: TBT 139ms 135ms -3% z=0.1
subgraph-transition-enter: heap used 77.2 MB 77.7 MB +1% z=-1.3
subgraph-transition-enter: DOM nodes 13587 13587 +0% —
subgraph-transition-enter: event listeners 2385 2387 +0% z=1.4
viewport-pan-sweep: avg frame time 17ms 17ms -0% z=-1.1
viewport-pan-sweep: p95 frame time 17ms 17ms -1% z=-1.8
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 36ms 39ms +6% z=0.4
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 248 247 -0% z=-1.1
viewport-pan-sweep: task duration 5882ms 6632ms +13% z=1.3
viewport-pan-sweep: script duration 2789ms 2965ms +6% z=0.8
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 63.5 MB 70.3 MB +11% z=0.2
viewport-pan-sweep: DOM nodes -243 -238 -2% z=0.3
viewport-pan-sweep: event listeners -168 -147 -13% z=0.5
vue-large-graph-idle: avg frame time 18ms 17ms -3% z=-0.7
vue-large-graph-idle: p95 frame time 17ms 17ms +0% z=1.0
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 16837ms 13241ms -21% z=-0.6
vue-large-graph-idle: script duration 287ms 227ms -21% z=-0.4
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 160.4 MB 172.0 MB +7% z=0.4
vue-large-graph-idle: DOM nodes -6543 -6542 -0% z=0.3
vue-large-graph-idle: event listeners -7478 -7480 +0% z=-0.6
vue-large-graph-pan: avg frame time 18ms 18ms -2% z=-0.2
vue-large-graph-pan: p95 frame time 17ms 17ms +0% z=1.0
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 17ms 18ms +6% z=0.1
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 151 133 -12% z=-0.0
vue-large-graph-pan: task duration 20767ms 18617ms -10% z=0.1
vue-large-graph-pan: script duration 882ms 879ms -0% z=0.3
vue-large-graph-pan: TBT 21ms 96ms +357% variance too high
vue-large-graph-pan: heap used 158.3 MB 180.8 MB +14% ⚠️ z=2.3
vue-large-graph-pan: DOM nodes -6542 -6544 +0% z=-0.1
vue-large-graph-pan: event listeners -7472 -7475 +0% z=0.2
vue-node-resize-workload: avg frame time 18ms 17ms -5% z=-1.5
vue-node-resize-workload: p95 frame time 17ms 17ms -1% z=-4.0
vue-node-resize-workload: layout duration 24ms 27ms +16% z=1.1
vue-node-resize-workload: style recalc duration 83ms 77ms -8% z=0.1
vue-node-resize-workload: layout count 20 20 +0% —
vue-node-resize-workload: style recalc count 20 20 +0% —
vue-node-resize-workload: task duration 6100ms 4845ms -21% z=-0.6
vue-node-resize-workload: script duration 110ms 113ms +2% z=0.4
vue-node-resize-workload: TBT 387ms 144ms -63% variance too high
vue-node-resize-workload: heap used 171.1 MB 164.4 MB -4% z=-1.1
vue-node-resize-workload: DOM nodes -6542 -6542 +0% z=0.3
vue-node-resize-workload: event listeners -7476 -7478 +0% z=-1.1
vue-zoom-out-idle: avg frame time 18ms 18ms +0% z=0.5
vue-zoom-out-idle: p95 frame time 17ms 17ms -1% z=-2.6
vue-zoom-out-idle: layout duration 0ms 0ms +0% —
vue-zoom-out-idle: style recalc duration 0ms 0ms +0% variance too high
vue-zoom-out-idle: layout count 0 0 +0% —
vue-zoom-out-idle: style recalc count 0 0 +0% variance too high
vue-zoom-out-idle: task duration 8370ms 7585ms -9% z=0.1
vue-zoom-out-idle: script duration 139ms 134ms -4% z=0.1
vue-zoom-out-idle: TBT 0ms 0ms +0% —
vue-zoom-out-idle: heap used 176.8 MB 160.2 MB -9% z=-1.8
vue-zoom-out-idle: DOM nodes 0 0 +0% z=0.3
vue-zoom-out-idle: event listeners -10 -11 +10% z=-0.0
workflow-execution: avg frame time 17ms 17ms +0% z=0.4
workflow-execution: p95 frame time 17ms 17ms -1% z=-1.6
workflow-execution: layout duration 2ms 3ms +57% ⚠️ z=2.2
workflow-execution: style recalc duration 24ms 24ms +0% z=1.3
workflow-execution: layout count 3 5 +50% z=2.7
workflow-execution: style recalc count 19 12 -37% z=-0.0
workflow-execution: task duration 127ms 120ms -6% z=1.2
workflow-execution: script duration 12ms 13ms +9% z=1.6
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 63.5 MB 63.1 MB -1% z=0.5
workflow-execution: DOM nodes 144 126 -13% z=-0.2
workflow-execution: event listeners 83 50 -40% z=-0.4
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: p95 frame time 17ms 0ms 0.1%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 8ms 1ms 17.5%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 9 1 9.3%
canvas-idle: task duration 449ms 96ms 21.3%
canvas-idle: script duration 10ms 2ms 25.2%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: heap used 62.9 MB 3.3 MB 5.2%
canvas-idle: DOM nodes -244 40 0.0%
canvas-idle: event listeners -154 26 0.0%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: p95 frame time 17ms 0ms 0.1%
canvas-mouse-sweep: layout duration 4ms 1ms 13.8%
canvas-mouse-sweep: style recalc duration 28ms 5ms 19.3%
canvas-mouse-sweep: layout count 14 0 0.0%
canvas-mouse-sweep: style recalc count 76 2 2.7%
canvas-mouse-sweep: task duration 825ms 125ms 15.2%
canvas-mouse-sweep: script duration 155ms 28ms 18.0%
canvas-mouse-sweep: TBT 0ms 1ms 387.3%
canvas-mouse-sweep: heap used 66.1 MB 4.6 MB 7.0%
canvas-mouse-sweep: DOM nodes -261 2 0.0%
canvas-mouse-sweep: event listeners -166 9 0.0%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: p95 frame time 17ms 0ms 0.2%
canvas-zoom-sweep: layout duration 1ms 0ms 8.6%
canvas-zoom-sweep: style recalc duration 16ms 3ms 17.4%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 0 1.3%
canvas-zoom-sweep: task duration 333ms 59ms 17.8%
canvas-zoom-sweep: script duration 12ms 2ms 19.8%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: heap used 61.5 MB 931.6 KB 1.5%
canvas-zoom-sweep: DOM nodes 75 1 0.8%
canvas-zoom-sweep: event listeners 19 1 3.7%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: p95 frame time 17ms 0ms 0.2%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 7ms 1ms 16.3%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 11 1 5.8%
dom-widget-clipping: task duration 425ms 68ms 16.0%
dom-widget-clipping: script duration 154ms 26ms 16.7%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: heap used 76.1 MB 430.6 KB 0.6%
dom-widget-clipping: DOM nodes 18 1 6.8%
dom-widget-clipping: event listeners 2 0 25.3%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: p95 frame time 17ms 0ms 0.2%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 5ms 1ms 16.2%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 6 1 24.9%
large-graph-idle: task duration 573ms 94ms 16.3%
large-graph-idle: script duration 34ms 6ms 16.3%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: heap used 78.0 MB 1.4 MB 1.8%
large-graph-idle: DOM nodes -248 2 0.0%
large-graph-idle: event listeners -163 19 0.0%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: p95 frame time 17ms 0ms 0.2%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 12ms 2ms 13.9%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 66 2 2.5%
large-graph-pan: task duration 1567ms 235ms 15.0%
large-graph-pan: script duration 797ms 128ms 16.1%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: heap used 75.4 MB 3.9 MB 5.2%
large-graph-pan: DOM nodes -196 53 0.0%
large-graph-pan: event listeners -120 47 0.0%
large-graph-zoom: avg frame time 17ms 0ms 0.0%
large-graph-zoom: p95 frame time 17ms 0ms 0.1%
large-graph-zoom: layout duration 13ms 1ms 10.3%
large-graph-zoom: style recalc duration 12ms 1ms 12.4%
large-graph-zoom: layout count 60 0 0.0%
large-graph-zoom: style recalc count 62 2 2.6%
large-graph-zoom: task duration 1630ms 239ms 14.7%
large-graph-zoom: script duration 748ms 122ms 16.3%
large-graph-zoom: TBT 0ms 0ms 0.0%
large-graph-zoom: heap used 70.4 MB 2.2 MB 3.2%
large-graph-zoom: DOM nodes -124 91 0.0%
large-graph-zoom: event listeners -58 70 0.0%
legacy-node-drag: avg frame time 17ms 0ms 0.0%
legacy-node-drag: p95 frame time 17ms 0ms 0.2%
legacy-node-drag: layout duration 0ms 0ms 0.0%
legacy-node-drag: style recalc duration 6ms 1ms 15.4%
legacy-node-drag: layout count 0 0 0.0%
legacy-node-drag: style recalc count 42 2 4.3%
legacy-node-drag: task duration 1816ms 304ms 16.7%
legacy-node-drag: script duration 920ms 164ms 17.9%
legacy-node-drag: TBT 0ms 0ms 0.0%
legacy-node-drag: heap used 80.6 MB 4.2 MB 5.2%
legacy-node-drag: DOM nodes -93 64 0.0%
legacy-node-drag: event listeners 137 42 30.7%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: p95 frame time 17ms 0ms 0.1%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 5ms 1ms 17.5%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 6 2 27.1%
minimap-idle: task duration 576ms 98ms 17.0%
minimap-idle: script duration 35ms 6ms 18.5%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: heap used 77.9 MB 1.7 MB 2.1%
minimap-idle: DOM nodes -252 3 0.0%
minimap-idle: event listeners -162 19 0.0%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: p95 frame time 17ms 0ms 0.1%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 10ms 2ms 16.4%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 47 1 1.2%
subgraph-dom-widget-clipping: task duration 385ms 63ms 16.3%
subgraph-dom-widget-clipping: script duration 134ms 22ms 16.6%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: heap used 73.4 MB 573.8 KB 0.8%
subgraph-dom-widget-clipping: DOM nodes 19 1 5.8%
subgraph-dom-widget-clipping: event listeners 7 1 7.2%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: p95 frame time 17ms 0ms 0.1%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 8ms 1ms 16.3%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 10 0 4.9%
subgraph-idle: task duration 460ms 79ms 17.3%
subgraph-idle: script duration 9ms 2ms 21.2%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: heap used 63.8 MB 5.5 MB 8.7%
subgraph-idle: DOM nodes -269 26 0.0%
subgraph-idle: event listeners -212 13 0.0%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: p95 frame time 17ms 0ms 0.1%
subgraph-mouse-sweep: layout duration 5ms 1ms 14.6%
subgraph-mouse-sweep: style recalc duration 27ms 5ms 17.9%
subgraph-mouse-sweep: layout count 18 0 0.0%
subgraph-mouse-sweep: style recalc count 77 1 0.7%
subgraph-mouse-sweep: task duration 761ms 111ms 14.6%
subgraph-mouse-sweep: script duration 105ms 18ms 17.0%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: heap used 65.2 MB 3.4 MB 5.2%
subgraph-mouse-sweep: DOM nodes -275 1 0.0%
subgraph-mouse-sweep: event listeners -215 10 0.0%
subgraph-transition-enter: avg frame time 17ms 0ms 0.0%
subgraph-transition-enter: p95 frame time 17ms 0ms 0.3%
subgraph-transition-enter: layout duration 12ms 3ms 22.5%
subgraph-transition-enter: style recalc duration 27ms 4ms 16.1%
subgraph-transition-enter: layout count 5 0 0.0%
subgraph-transition-enter: style recalc count 17 1 5.0%
subgraph-transition-enter: task duration 845ms 158ms 18.7%
subgraph-transition-enter: script duration 29ms 6ms 18.7%
subgraph-transition-enter: TBT 133ms 27ms 20.6%
subgraph-transition-enter: heap used 90.4 MB 10.0 MB 11.0%
subgraph-transition-enter: DOM nodes 13587 0 0.0%
subgraph-transition-enter: event listeners 2386 1 0.0%
viewport-pan-sweep: avg frame time 17ms 0ms 0.0%
viewport-pan-sweep: p95 frame time 17ms 0ms 0.1%
viewport-pan-sweep: layout duration 0ms 0ms 0.0%
viewport-pan-sweep: style recalc duration 36ms 5ms 14.3%
viewport-pan-sweep: layout count 0 0 0.0%
viewport-pan-sweep: style recalc count 248 1 0.4%
viewport-pan-sweep: task duration 5505ms 852ms 15.5%
viewport-pan-sweep: script duration 2625ms 423ms 16.1%
viewport-pan-sweep: TBT 0ms 0ms 0.0%
viewport-pan-sweep: heap used 69.1 MB 6.6 MB 9.6%
viewport-pan-sweep: DOM nodes -240 9 0.0%
viewport-pan-sweep: event listeners -151 8 0.0%
vue-large-graph-idle: avg frame time 18ms 0ms 2.3%
vue-large-graph-idle: p95 frame time 17ms 0ms 0.2%
vue-large-graph-idle: layout duration 0ms 0ms 0.0%
vue-large-graph-idle: style recalc duration 0ms 0ms 0.0%
vue-large-graph-idle: layout count 0 0 0.0%
vue-large-graph-idle: style recalc count 0 0 0.0%
vue-large-graph-idle: task duration 15043ms 2910ms 19.3%
vue-large-graph-idle: script duration 254ms 63ms 24.8%
vue-large-graph-idle: TBT 0ms 0ms 0.0%
vue-large-graph-idle: heap used 169.6 MB 5.8 MB 3.4%
vue-large-graph-idle: DOM nodes -6543 3 0.0%
vue-large-graph-idle: event listeners -7478 4 0.0%
vue-large-graph-pan: avg frame time 18ms 0ms 2.2%
vue-large-graph-pan: p95 frame time 17ms 0ms 0.2%
vue-large-graph-pan: layout duration 0ms 0ms 0.0%
vue-large-graph-pan: style recalc duration 18ms 4ms 24.4%
vue-large-graph-pan: layout count 0 0 0.0%
vue-large-graph-pan: style recalc count 135 39 29.1%
vue-large-graph-pan: task duration 18445ms 3320ms 18.0%
vue-large-graph-pan: script duration 848ms 119ms 14.1%
vue-large-graph-pan: TBT 67ms 74ms 110.7%
vue-large-graph-pan: heap used 169.4 MB 4.9 MB 2.9%
vue-large-graph-pan: DOM nodes -6544 3 0.0%
vue-large-graph-pan: event listeners -7476 4 0.0%
vue-node-resize-workload: avg frame time 18ms 0ms 2.6%
vue-node-resize-workload: p95 frame time 17ms 0ms 0.1%
vue-node-resize-workload: layout duration 24ms 3ms 11.1%
vue-node-resize-workload: style recalc duration 75ms 11ms 14.9%
vue-node-resize-workload: layout count 20 0 0.0%
vue-node-resize-workload: style recalc count 20 0 0.0%
vue-node-resize-workload: task duration 5458ms 1043ms 19.1%
vue-node-resize-workload: script duration 102ms 23ms 22.8%
vue-node-resize-workload: TBT 303ms 159ms 52.3%
vue-node-resize-workload: heap used 169.3 MB 4.5 MB 2.6%
vue-node-resize-workload: DOM nodes -6543 3 0.0%
vue-node-resize-workload: event listeners -7476 1 0.0%
vue-zoom-out-idle: avg frame time 18ms 0ms 2.4%
vue-zoom-out-idle: p95 frame time 17ms 0ms 0.2%
vue-zoom-out-idle: layout duration 0ms 0ms 0.0%
vue-zoom-out-idle: style recalc duration 0ms 0ms 387.3%
vue-zoom-out-idle: layout count 0 0 0.0%
vue-zoom-out-idle: style recalc count 0 0 387.3%
vue-zoom-out-idle: task duration 7491ms 1429ms 19.1%
vue-zoom-out-idle: script duration 131ms 29ms 21.8%
vue-zoom-out-idle: TBT 0ms 0ms 0.0%
vue-zoom-out-idle: heap used 168.5 MB 4.6 MB 2.7%
vue-zoom-out-idle: DOM nodes -0 0 0.0%
vue-zoom-out-idle: event listeners -11 2 0.0%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: p95 frame time 17ms 0ms 0.2%
workflow-execution: layout duration 2ms 0ms 28.9%
workflow-execution: style recalc duration 19ms 4ms 20.0%
workflow-execution: layout count 3 0 13.7%
workflow-execution: style recalc count 12 3 23.1%
workflow-execution: task duration 100ms 17ms 17.3%
workflow-execution: script duration 10ms 2ms 20.9%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: heap used 62.8 MB 437.7 KB 0.7%
workflow-execution: DOM nodes 127 7 5.5%
workflow-execution: event listeners 54 11 20.2%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▃▃█▆▆▁▁▆▃▁▃█▁▃▃ ➡️ 17ms
canvas-idle: p95 frame time ▅▅▅▁▅▅▄▁▁▁▁█▁▁▄ ➡️ 17ms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration █▇█▅▇▁█▃▄▃▆▄▅▇▆ ➡️ 8ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count ▅▇▆▄▃▇▁█▇▇▄▄▃▅▅ ➡️ 8
canvas-idle: task duration ▆▄▅▅▇▂█▁▄▁▅▄▄▄▅ 📉 493ms
canvas-idle: script duration ▇▄▅▃█▁█▂▃▂▅▂▄▅▄ 📉 9ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ▄▃██▄▂▁▄▂▇▄▆▂▅▇ ➡️ 66.8 MB
canvas-idle: DOM nodes ▂█▂▂▂▂▁█▂█▂▂▁▂▁ ➡️ -271
canvas-idle: event listeners ▃▇▄▄▃▂▂▇▁█▃▃▃▃▃ ➡️ -155
canvas-mouse-sweep: avg frame time ▄▄█▆▁▄▆█▅▆▆▅▄▅▆ ➡️ 17ms
canvas-mouse-sweep: p95 frame time █▆▃▃▃▃▆▃▃▃▃▃▃▁▆ ➡️ 17ms
canvas-mouse-sweep: layout duration ▇▅▆▆█▁▇▁▆▆▅▅▇▇▆ ➡️ 5ms
canvas-mouse-sweep: style recalc duration █▄▆▆█▁█▁▄▄▆▅█▇▆ ➡️ 30ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 14
canvas-mouse-sweep: style recalc count ▇▂▄▅█▁▇▂▅▂▅▅█▅▄ ➡️ 75
canvas-mouse-sweep: task duration ▇▃▆▆█▁▇▁▄▁▆▅▆▆▆ ➡️ 863ms
canvas-mouse-sweep: script duration █▄▇▇▇▁█▂▄▂▇▆▇▇▇ ➡️ 166ms
canvas-mouse-sweep: TBT ▁▁▁▁▁█▁▁▁▁▁▁▁▁▁ 📉 0ms
canvas-mouse-sweep: heap used ▅▆▇█▇▁▇▂▃▅▇▇▅▇▆ ➡️ 67.1 MB
canvas-mouse-sweep: DOM nodes ▄▅▁▅▂▆▃▅▅█▄▄▁▃▁ ➡️ -264
canvas-mouse-sweep: event listeners ▆▆█▅▆▁█▁▆▆▆█▃▆▆ ➡️ -165
canvas-zoom-sweep: avg frame time ▆▁▃▆▁▃▆▃▃▃▆▆█▃▃ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ▁▆▆▃▆▃▃▆▃▁█▆▃▁▃ ➡️ 17ms
canvas-zoom-sweep: layout duration ▄▄▄▄█▃▅▁▃▆▄▂▅▅▄ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▇▄▆▅█▁▇▂▃▄▅▄▆▆▆ ➡️ 17ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count █▁▄▅▄▂▂▄▄▅▁▄▂▄▄ ➡️ 31
canvas-zoom-sweep: task duration ▇▃▅▅█▁▆▂▃▁▅▄▅▆▄ ➡️ 321ms
canvas-zoom-sweep: script duration ▇▄▄▃█▁▅▂▃▃▅▂▅▅▄ ➡️ 12ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ▁▁▂▂▂▂▂▂▁█▂▂▂▁▂ ➡️ 61.4 MB
canvas-zoom-sweep: DOM nodes ▆▂▅▃▁▅▁▆▅█▂▂▇▃▂ ➡️ 75
canvas-zoom-sweep: event listeners ▁█▁▁▃▁▁█▁▁▁▁▁▁▁ ➡️ 19
dom-widget-clipping: avg frame time ▁▃█▆▁▃▃▁▃█▃▁▁▃▁ ➡️ 17ms
dom-widget-clipping: p95 frame time ▆▆▆▁▃▃▆█▃▁█▁▆▆▁ ➡️ 17ms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▅▄▆▅█▁█▂▃▄▆▅▆▇▇ ➡️ 9ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▁▃▃▂▁█▃█▅▆▃▆▃▃▇ ➡️ 12
dom-widget-clipping: task duration ▇▃▆▆█▁▇▂▅▁▆▅▆▆▆ ➡️ 452ms
dom-widget-clipping: script duration █▄▇▇█▁█▃▅▂▇▇▇▇▇ ➡️ 164ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ▁▆▇█▆▆▆▆▆▇▄█▄▄▇ ➡️ 76.4 MB
dom-widget-clipping: DOM nodes ▁▃▄▂▁█▄█▅▆▄▆▄▄▇ ➡️ 19
dom-widget-clipping: event listeners █▁█▄█▄███▄▄█▄██ ➡️ 2
large-graph-idle: avg frame time ▅██▄▄▅▁███▄█▅█▅ ➡️ 17ms
large-graph-idle: p95 frame time ▁▆█▆▃▆▆▃▆▆█▃▃▆▃ ➡️ 17ms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▂▅▃▅▅▄▃▄▄▅▄▇█▃▁ ➡️ 4ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count ▁▆▃▄▂█▂█▅▇▃▄▅▃▁ ➡️ 4
large-graph-idle: task duration ▆▄▅▄█▁▅▂▃▁▅▃▅▄▄ ➡️ 567ms
large-graph-idle: script duration ▇▄▆▄█▁▅▂▃▂▅▂▅▄▅ ➡️ 36ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used █▆▇▇▇▂█▁▇▃▇▄▆▅█ ➡️ 79.2 MB
large-graph-idle: DOM nodes ▂█▃▅▄▇▃▄█▅▄▁▂▁▃ ➡️ -249
large-graph-idle: event listeners ▃▃▃▂█▁▃▁▃▂▃▃▂▂▂ ➡️ -173
large-graph-pan: avg frame time ██▁█▁▁██▅▅▄▁▅█▁ ➡️ 17ms
large-graph-pan: p95 frame time ▅▁▅███▁▅█▅█▅█▁█ ➡️ 17ms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▃▄▂▃▃▁▂▁▄▇▁▂▂▃█ 📈 15ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▃▆▃▄▁▆▃█▅▆▂▅▃▄▆ ➡️ 67
large-graph-pan: task duration █▃▇▇█▁▇▂▅▂▇▅▇▇▆ ➡️ 1660ms
large-graph-pan: script duration █▃▇▇█▁█▂▅▂█▆▇▇▇ ➡️ 864ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ▅▁▆▆▆▆▇▄▆▄▅▄█▃▅ ➡️ 75.1 MB
large-graph-pan: DOM nodes ▅▂▅▅▄▅▁▂▂▅█▁▄▁▁ ➡️ -251
large-graph-pan: event listeners ▅▁▄▅█▄█▁▁▄█▂▄▂▁ 📈 -172
large-graph-zoom: avg frame time ▃▃▁▅▄▁▁▆▃█▁▅▁▅▃ ➡️ 17ms
large-graph-zoom: p95 frame time ▄█▄█▁▄▄▄█▄▁█▄█▄ ➡️ 17ms
large-graph-zoom: layout duration ▅▄▄▄█▁▄▂▆▆▄▃▅▄▄ ➡️ 13ms
large-graph-zoom: style recalc duration ▃▄▁▄▅▁▅▃▆█▂▁▃▁▅ ➡️ 13ms
large-graph-zoom: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 60
large-graph-zoom: style recalc count ▂▅▁▄▂█▅█▅▇▂▂▂▁▅ ➡️ 63
large-graph-zoom: task duration ▆▄▆▆█▁▇▂▅▂▆▅▆▆▆ ➡️ 1741ms
large-graph-zoom: script duration ▇▄▆▇█▁▆▂▅▂▇▆▇▆▆ ➡️ 798ms
large-graph-zoom: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-zoom: heap used ▄▄▄▃▄█▃▁▄▄▄▂▄▄▁ ➡️ 66.8 MB
large-graph-zoom: DOM nodes █▃▃▁▅█▁▃▃▃█▅▃█▄ 📉 -162
large-graph-zoom: event listeners █▃█▃██▁▃▃▃█▆██▃ ➡️ -116
legacy-node-drag: avg frame time ▆▃▆█▃▆▁▆▆▆▆▃▁▁▆ ➡️ 17ms
legacy-node-drag: p95 frame time ▃█▃▃▃▃▃▃█▃▃▃▆▁█ ➡️ 17ms
legacy-node-drag: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
legacy-node-drag: style recalc duration ▆▄▄▆▅▃▁▄▇█▂▃▄▂▂ ➡️ 5ms
legacy-node-drag: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
legacy-node-drag: style recalc count ▃▃▃▃▂█▁█▅▅▂▃▃▁▁ ➡️ 40
legacy-node-drag: task duration ▇▄▆▆█▁▆▂▅▂▆▆▆▆▆ ➡️ 1925ms
legacy-node-drag: script duration ▇▄▆▆█▁▆▂▅▃▆▆▆▆▆ ➡️ 984ms
legacy-node-drag: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
legacy-node-drag: heap used ▇▁█▆█▃█▄▆▄█▆▇▇▆ ➡️ 80.5 MB
legacy-node-drag: DOM nodes ▁█▁▅▅▅█▅▂█▄▂▁▄▄ 📈 -85
legacy-node-drag: event listeners ▁█▄▄▄▄█▄▁█▄▄▄██ ➡️ 188
minimap-idle: avg frame time ▅▆▅▃▃▃▃▃▅█▆▁▁▃▃ ➡️ 17ms
minimap-idle: p95 frame time ▁▅▅█▅██▅▅▅▁▅███ ➡️ 17ms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▁▇▄▃▃▃▂▂▃█▃▄▄▄▄ 📈 5ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▁▆▂▃▂█▂▆▅█▃▃▃▃▃ ➡️ 5
minimap-idle: task duration ▆▄▄▄█▁▅▂▄▁▃▄▄▅▄ ➡️ 591ms
minimap-idle: script duration ▇▄▄▄█▁▇▃▄▂▆▃▆▆▄ ➡️ 35ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ▇▁▆▆▆▄█▃▃▃█▅▆▆▄ ➡️ 77.2 MB
minimap-idle: DOM nodes ▄▂▂▃▂█▄▅▂▆▅▃▄▃▁ ➡️ -257
minimap-idle: event listeners ▄▁▂▃▂▁▃█▂▂▄█▃▂▂ ➡️ -173
subgraph-dom-widget-clipping: avg frame time █▆▁▃▄▃▆▄▄▄▄▆▆▆▃ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time █▅▅█▅▄▁█▅▄▁████ ➡️ 17ms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▇▅▆▆█▁▇▂▄▆▆▅▇▆▆ ➡️ 11ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▄▄▄▅▄▅▁▃▄█▃▄▄▄▄ ➡️ 47
subgraph-dom-widget-clipping: task duration ▇▄▆▆█▁█▃▅▂▆▅▆▆▆ ➡️ 398ms
subgraph-dom-widget-clipping: script duration ▇▄▇▇█▁█▃▅▂▇▆▇▆▆ ➡️ 141ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ▂▂▁▃▄▂▂█▃▃▁▂▂▃▃ ➡️ 73.5 MB
subgraph-dom-widget-clipping: DOM nodes ▅▅▄▆▅▆▁▃▅█▃▅▅▅▅ ➡️ 19
subgraph-dom-widget-clipping: event listeners ▁█▄██▄▄▁█▁▄█▁▄▄ ➡️ 7
subgraph-idle: avg frame time ▁▅██▄█▄█▄▁▅██▁▁ ➡️ 17ms
subgraph-idle: p95 frame time ▅▁█▅█▅▅▄██▅███▅ ➡️ 17ms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration █▆▇▆█▁▇▃▄▄█▅▇▆▇ ➡️ 9ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▁█▂▂▂▄▁▅▅▄▄▂▁▁▄ ➡️ 10
subgraph-idle: task duration ▇▃▅▅█▁▆▃▄▁▅▄▅▅▅ ➡️ 465ms
subgraph-idle: script duration █▄▅▂█▁▅▁▃▂▅▂▄▅▃ 📉 8ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used █▆▂▅▇▁▆▂█▁▃▆▄▆▆ ➡️ 66.6 MB
subgraph-idle: DOM nodes ▁▁▁▁▁▁▁▁▁█▁▁▁▁▁ ➡️ -276
subgraph-idle: event listeners █▆▆██▁█▂█▂▁▆▄▆█ ➡️ -200
subgraph-mouse-sweep: avg frame time █▄▆▁▄█▆▆▅▄▃▆▅▆▄ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ▃▆▆▃▃▆▁▆▃▆▆▆▃▃█ ➡️ 17ms
subgraph-mouse-sweep: layout duration ▅▄▄▄█▂▄▁▃▆▄▃▄▅▄ ➡️ 5ms
subgraph-mouse-sweep: style recalc duration ▅▄▄▄█▁▅▁▂▄▅▃▄▅▄ ➡️ 27ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 18
subgraph-mouse-sweep: style recalc count ▂▃▂▂█▃▁▅▂▁▁▂▂▁▁ ➡️ 77
subgraph-mouse-sweep: task duration ▇▃▆▅█▁▅▁▄▂▅▄▅▆▆ ➡️ 823ms
subgraph-mouse-sweep: script duration ▇▄▇▆█▁▇▁▃▄▇▅▆▇▆ ➡️ 115ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ▄▁▂▇▇▄█▇▄▆▅▇▃▇▅ ➡️ 65.5 MB
subgraph-mouse-sweep: DOM nodes ▃▅▂▃▃▇▂▇▇█▁▃▄▂▃ ➡️ -276
subgraph-mouse-sweep: event listeners ▆▂▁▆█▄█▆▄▆▄▆▄▆▆ ➡️ -212
subgraph-transition-enter: avg frame time ▁▅█▅▅▁▁▅▅█▅▅▅▁▅ ➡️ 17ms
subgraph-transition-enter: p95 frame time ▁▁██▁██▁█▁▁▁██▁ ➡️ 17ms
subgraph-transition-enter: layout duration ▅▃▅▅▅▁█▂▃▁▅▅▅▅▅ ➡️ 13ms
subgraph-transition-enter: style recalc duration ▇▃▇▆▇▁█▂▅▁▇▆▇▇▆ ➡️ 29ms
subgraph-transition-enter: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 5
subgraph-transition-enter: style recalc count ▁▃▃▆▃█▃▃▃▆▃▆▁▁▆ ➡️ 18
subgraph-transition-enter: task duration ▇▄▅▆█▁▇▃▅▂▇▅▆▇▆ ➡️ 891ms
subgraph-transition-enter: script duration ▆▂▄▆█▁▆▂▅▂▆▄▆▆▄ ➡️ 29ms
subgraph-transition-enter: TBT ▇▃▇▇▆▃█▅▆▁▇▆▇▇▆ ➡️ 139ms
subgraph-transition-enter: heap used ▇▁▁▁▇▁▇▇▇█▄▇▇▇▁ ➡️ 77.2 MB
subgraph-transition-enter: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 13587
subgraph-transition-enter: event listeners █▁▁▁█▁▁▁█▁▁██▁▁ ➡️ 2385
viewport-pan-sweep: avg frame time ▅▃▃▃▃█▃▆▆▆▃▅▃▁█ ➡️ 17ms
viewport-pan-sweep: p95 frame time ▃▁▃▃▃▃▃▃▃▆▆▆▃█▆ ➡️ 17ms
viewport-pan-sweep: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: style recalc duration ▆▆▆▅█▁▆▂▆█▅▄▆▅▅ ➡️ 36ms
viewport-pan-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
viewport-pan-sweep: style recalc count ▂▅▄▂▁▅▂█▄▇▂▃▅▄▄ ➡️ 248
viewport-pan-sweep: task duration ▇▄▇▆█▁▇▃▅▂▇▅▇▆▆ ➡️ 5891ms
viewport-pan-sweep: script duration █▄▇▇█▁█▃▅▃▇▆▇▇▇ ➡️ 2802ms
viewport-pan-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: heap used █▂█▁▅▃▆▃▁▃▄▁▁▁▁ 📉 63.4 MB
viewport-pan-sweep: DOM nodes ▂▂▅▄▂▆▁█▂▇▂▂▆▄▄ ➡️ -240
viewport-pan-sweep: event listeners ▆▆▁▃▇▆▄▄▆▄▆█▃▆▃ ➡️ -158
vue-large-graph-idle: avg frame time ▇▄▆█▇▁█▁▃▁▆▆▇▇▇ ➡️ 18ms
vue-large-graph-idle: p95 frame time █▆▆▆▆▆▃▁█▆██▆█▆ ➡️ 17ms
vue-large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: task duration ▇▅▇▆█▁▇▃▅▃▇▄▇▆▇ ➡️ 16773ms
vue-large-graph-idle: script duration ▇▄▅▆█▁▆▃▄▂▆▄▆▅▆ ➡️ 289ms
vue-large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: heap used ▄▇▅▂▅▃▂▄▁█▇▃▃▅▁ ➡️ 161.7 MB
vue-large-graph-idle: DOM nodes ███▇█▇█▇█▇████▁ ➡️ -6554
vue-large-graph-idle: event listeners ▂█▂▃▂▁▂▂▂▂▂▂▃▂▂ ➡️ -7478
vue-large-graph-pan: avg frame time ▇▃▅▅█▁▅▃▇▂▆▅▃▆▇ ➡️ 18ms
vue-large-graph-pan: p95 frame time █▆██▆▃▆▆▆▁█▆▆█▆ ➡️ 17ms
vue-large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-pan: style recalc duration ▅▂▃▃█▁▄▁▃▁▃▂▂▃▃ 📉 17ms
vue-large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-pan: style recalc count ▇▃▅▇█▁▇▁▅▁▇▇▅▇▆ ➡️ 152
vue-large-graph-pan: task duration ▆▃▅▆█▁▆▂▄▂▆▅▄▆▆ ➡️ 20660ms
vue-large-graph-pan: script duration ▇▃▇▇█▁▆▃▅▁▆▅▆▆▆ ➡️ 884ms
vue-large-graph-pan: TBT ▃▁▄▃█▁▃▁▁▁▂▁▂▂▁ 📉 18ms
vue-large-graph-pan: heap used ▄▃▅▄▇▅▇▂▄▃▁▂█▅▂ ➡️ 165.0 MB
vue-large-graph-pan: DOM nodes ▁███▇▇██▇▇████▁ ➡️ -6552
vue-large-graph-pan: event listeners ▁▆▇██▆▇▆▇▆▇▇▆▇█ ➡️ -7473
vue-node-resize-workload: avg frame time ▆▆▆▅▆▁▆▃▃▃▆▅▆█▅ ➡️ 18ms
vue-node-resize-workload: p95 frame time █▁▄██▄▄█▄▅█████ ➡️ 17ms
vue-node-resize-workload: layout duration ▄▃▃▄█▁▅▂▄▅▄▃▄▃▃ ➡️ 23ms
vue-node-resize-workload: style recalc duration ▆▃▆▇▇▁▇▃▄▂▆█▇▆▇ ➡️ 82ms
vue-node-resize-workload: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: task duration ▇▅▇▆█▁▇▃▄▃▇▆▇▇▆ ➡️ 5663ms
vue-node-resize-workload: script duration ▇▆▆▆█▁▇▃▅▂▆▅▇▆▆ ➡️ 106ms
vue-node-resize-workload: TBT ▇▅▇▆█▁▇▁▂▂▇▆▇▇▆ 📉 339ms
vue-node-resize-workload: heap used ▂▂▅▄▅▅▅▅▄█▄▁▅▇▆ ➡️ 173.3 MB
vue-node-resize-workload: DOM nodes █████▆█▇██████▁ ➡️ -6552
vue-node-resize-workload: event listeners █▇▆▄█▁▆▃▂▄▆▆▅▆▇ ➡️ -7475
vue-zoom-out-idle: avg frame time ▆▄▆▆▅▁▇▃▄▃▆▅█▅▅ ➡️ 18ms
vue-zoom-out-idle: p95 frame time █▆▆██▁█▆▃▆█▆▆▆█ ➡️ 17ms
vue-zoom-out-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: style recalc duration ▁▁▁▁▁█▁▁▁▁▁▁▁▁▁ 📉 0ms
vue-zoom-out-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: style recalc count ▁▁▁▁▁█▁▁▁▁▁▁▁▁▁ 📉 0
vue-zoom-out-idle: task duration █▆█▇█▁█▄▅▄▇▆██▇ ➡️ 7701ms
vue-zoom-out-idle: script duration ▇▅█▇█▁▇▄▅▄▇▅▇▇▇ ➡️ 143ms
vue-zoom-out-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: heap used ▄▅▄▆▃▄▅▆▁▇██▆▃▆ ➡️ 171.2 MB
vue-zoom-out-idle: DOM nodes █████████████▁█ ➡️ 0
vue-zoom-out-idle: event listeners ▄▅▁▅▃█▃▅▆▇▅▅▃▃▅ ➡️ -10
workflow-execution: avg frame time ▅▅▅▅█▄▅▄▇▄▁▄▄▂▄ ➡️ 17ms
workflow-execution: p95 frame time ▆▆▃▃▃█▃▃▆▃▆▃▁▁▆ ➡️ 17ms
workflow-execution: layout duration ▃▃▃▂█▁▃▃▂▁▂▂▇▅▃ ➡️ 2ms
workflow-execution: style recalc duration ▅▅▄▄█▁▅▅▃▂▄▄▆▆▅ ➡️ 21ms
workflow-execution: layout count ▄▅▁▁█▄▂▄▂▂▂▂▅▅▅ ➡️ 4
workflow-execution: style recalc count ▄▆▄▁▅▂▃█▃▁▄▂▄▆▇ ➡️ 16
workflow-execution: task duration ▆▅▅▄█▁▅▅▄▂▆▄▅▆▆ ➡️ 113ms
workflow-execution: script duration ▅▅▄▃▇▁▃▄▄▁▅▂▅█▆ ➡️ 11ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ▄▅▂▁▅▂▁█▄▂▄▁▂▅▄ ➡️ 63.1 MB
workflow-execution: DOM nodes ▄▇▆▂▇▅▃▇▄▅▇▁█▇▇ ➡️ 133
workflow-execution: event listeners ▄▆▃▁▄▂▁█▅▂▅▃▂▅▆ 📈 66
Raw data
{
  "timestamp": "2026-09-15T20:54:47.146Z",
  "gitSha": "d33d8860e6aca9fe75d6386f0632c9e99ea5ff49",
  "branch": "jaewon/fe-2216-phase-5-adopt-the-billing-sdk-in-comfyui_frontend-behind-a",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2024.8090000000047,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.931999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 603.691,
      "heapDeltaBytes": 3940256,
      "heapUsedBytes": 65598248,
      "domNodes": -267,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 11.443000000000001,
      "eventListeners": -156,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 1999.5869999999059,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.216,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 395.98,
      "heapDeltaBytes": 25252784,
      "heapUsedBytes": 86753044,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 10.949,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1903.4880000000385,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 30.106,
      "layouts": 14,
      "layoutDurationMs": 4.867,
      "taskDurationMs": 940.995,
      "heapDeltaBytes": -1018780,
      "heapUsedBytes": 61424564,
      "domNodes": -263,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 156.684,
      "eventListeners": -184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1881.7619999999806,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 32.398999999999994,
      "layouts": 14,
      "layoutDurationMs": 4.7299999999999995,
      "taskDurationMs": 968.9749999999999,
      "heapDeltaBytes": 3275016,
      "heapUsedBytes": 65772068,
      "domNodes": -262,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 163.71599999999998,
      "eventListeners": -186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1741.1180000000286,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 17.924,
      "layouts": 6,
      "layoutDurationMs": 1.393,
      "taskDurationMs": 399.027,
      "heapDeltaBytes": 2187296,
      "heapUsedBytes": 64574156,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 14.177000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1735.3339999999662,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 17.037000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.2710000000000001,
      "taskDurationMs": 390.76500000000004,
      "heapDeltaBytes": 2202816,
      "heapUsedBytes": 64436332,
      "domNodes": 74,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 13.992,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 741.4230000000543,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 9.309000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 509.64699999999993,
      "heapDeltaBytes": 16863908,
      "heapUsedBytes": 78097144,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 176.978,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 730.9109999999919,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.265,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 493.892,
      "heapDeltaBytes": 18213044,
      "heapUsedBytes": 79402752,
      "domNodes": 16,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 174.821,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2031.3650000000507,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.749,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 672.463,
      "heapDeltaBytes": 3452876,
      "heapUsedBytes": 83243340,
      "domNodes": -247,
      "jsHeapTotalBytes": -270336,
      "scriptDurationMs": 33.67000000000001,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2051.3729999998986,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.115000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 686.7829999999999,
      "heapDeltaBytes": 3431564,
      "heapUsedBytes": 82712996,
      "domNodes": -248,
      "jsHeapTotalBytes": -270336,
      "scriptDurationMs": 36.386999999999986,
      "eventListeners": -152,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2842.583999999988,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 13.939,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1707.1309999999999,
      "heapDeltaBytes": -1043512,
      "heapUsedBytes": 79536284,
      "domNodes": -228,
      "jsHeapTotalBytes": 1003520,
      "scriptDurationMs": 888.97,
      "eventListeners": -182,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3046.8929999999546,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.772,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1780.037,
      "heapDeltaBytes": 22865876,
      "heapUsedBytes": 87429604,
      "domNodes": -252,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 864.9290000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3931.47399999998,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 11.697000000000003,
      "layouts": 60,
      "layoutDurationMs": 14.309000000000003,
      "taskDurationMs": 1879.503,
      "heapDeltaBytes": 9571524,
      "heapUsedBytes": 75496248,
      "domNodes": -256,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 850.062,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3954.407999999944,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.685,
      "layouts": 60,
      "layoutDurationMs": 14.259,
      "taskDurationMs": 1861.841,
      "heapDeltaBytes": 7741432,
      "heapUsedBytes": 74139180,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 820.248,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3197.5680000000466,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 7.765999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2135.833,
      "heapDeltaBytes": 4724128,
      "heapUsedBytes": 88422868,
      "domNodes": -262,
      "jsHeapTotalBytes": 671744,
      "scriptDurationMs": 1010.934,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3341.380000000072,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.303999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2189.6910000000003,
      "heapDeltaBytes": 26502360,
      "heapUsedBytes": 93127124,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 1070.974,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2025.914000000057,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 7.358000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 680.55,
      "heapDeltaBytes": -3111088,
      "heapUsedBytes": 84273756,
      "domNodes": -253,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 33.695,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2020.6319999999778,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 7.226,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 651.056,
      "heapDeltaBytes": -2885324,
      "heapUsedBytes": 84565312,
      "domNodes": -251,
      "jsHeapTotalBytes": -495616,
      "scriptDurationMs": 39.711,
      "eventListeners": -154,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 680.8719999999084,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 13.548999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.07399999999996,
      "heapDeltaBytes": 14037212,
      "heapUsedBytes": 77516956,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 149.822,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 622.353999999973,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.032,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.013,
      "heapDeltaBytes": 13526564,
      "heapUsedBytes": 77204088,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 148.812,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.351000000076,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.449000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 547.644,
      "heapDeltaBytes": 15622164,
      "heapUsedBytes": 79036996,
      "domNodes": -277,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 11.195999999999998,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.1120000000165,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.136,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 554.699,
      "heapDeltaBytes": 4999952,
      "heapUsedBytes": 68598344,
      "domNodes": -275,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 11.945,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1709.7390000000132,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.127000000000002,
      "layouts": 18,
      "layoutDurationMs": 6.5040000000000004,
      "taskDurationMs": 833.4379999999999,
      "heapDeltaBytes": -6110196,
      "heapUsedBytes": 57390408,
      "domNodes": -277,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 118.66799999999999,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1718.705,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 30.508999999999997,
      "layouts": 18,
      "layoutDurationMs": 6.005,
      "taskDurationMs": 827.7370000000001,
      "heapDeltaBytes": 13130640,
      "heapUsedBytes": 76578296,
      "domNodes": -273,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 113.955,
      "eventListeners": -200,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1399.9659999999494,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 27.219999999999995,
      "layouts": 5,
      "layoutDurationMs": 11.629999999999997,
      "taskDurationMs": 941.3629999999999,
      "heapDeltaBytes": -6441244,
      "heapUsedBytes": 81517000,
      "domNodes": 13587,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 31.501,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 135,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10587.37199999996,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 39.449999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6649.992,
      "heapDeltaBytes": -12225156,
      "heapUsedBytes": 67284520,
      "domNodes": -225,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 2992.044,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 10660.015000000043,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 37.659,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6614.198,
      "heapDeltaBytes": 311392,
      "heapUsedBytes": 80067276,
      "domNodes": -250,
      "jsHeapTotalBytes": 1232896,
      "scriptDurationMs": 2937.315,
      "eventListeners": -132,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15664.660000000025,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15289.253999999999,
      "heapDeltaBytes": -20549708,
      "heapUsedBytes": 181287080,
      "domNodes": -6542,
      "jsHeapTotalBytes": 4136960,
      "scriptDurationMs": 244.94,
      "eventListeners": -7478,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11770.204000000034,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11193.636000000002,
      "heapDeltaBytes": -39423572,
      "heapUsedBytes": 179519856,
      "domNodes": -6542,
      "jsHeapTotalBytes": 4608000,
      "scriptDurationMs": 208.172,
      "eventListeners": -7482,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18951.29499999996,
      "styleRecalcs": 137,
      "styleRecalcDurationMs": 18.953999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18799.044,
      "heapDeltaBytes": -28123676,
      "heapUsedBytes": 190594216,
      "domNodes": -6546,
      "jsHeapTotalBytes": -1216512,
      "scriptDurationMs": 900.2330000000001,
      "eventListeners": -7474,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18606.232999999975,
      "styleRecalcs": 129,
      "styleRecalcDurationMs": 17.127000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18435.448999999997,
      "heapDeltaBytes": -29728660,
      "heapUsedBytes": 188651396,
      "domNodes": -6542,
      "jsHeapTotalBytes": 94208,
      "scriptDurationMs": 858.159,
      "eventListeners": -7476,
      "totalBlockingTimeMs": 51,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5588.194000000044,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.619,
      "layouts": 20,
      "layoutDurationMs": 27.434,
      "taskDurationMs": 5538.848,
      "heapDeltaBytes": -26532936,
      "heapUsedBytes": 168157468,
      "domNodes": -6542,
      "jsHeapTotalBytes": 13312000,
      "scriptDurationMs": 103.815,
      "eventListeners": -7476,
      "totalBlockingTimeMs": 283,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4230.277000000001,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.72600000000001,
      "layouts": 20,
      "layoutDurationMs": 26.895000000000003,
      "taskDurationMs": 4151.893,
      "heapDeltaBytes": -17683908,
      "heapUsedBytes": 176669876,
      "domNodes": -6542,
      "jsHeapTotalBytes": 24584192,
      "scriptDurationMs": 121.21500000000002,
      "eventListeners": -7480,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7710.1809999999205,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7577.730999999998,
      "heapDeltaBytes": -19795104,
      "heapUsedBytes": 159867740,
      "domNodes": 0,
      "jsHeapTotalBytes": -10223616,
      "scriptDurationMs": 147.31200000000004,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7757.806000000073,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7592.993999999999,
      "heapDeltaBytes": -16819752,
      "heapUsedBytes": 176010476,
      "domNodes": 0,
      "jsHeapTotalBytes": -14942208,
      "scriptDurationMs": 120.59599999999998,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 139.2990000000509,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 23.812,
      "layouts": 5,
      "layoutDurationMs": 3.0160000000000005,
      "taskDurationMs": 118.08600000000003,
      "heapDeltaBytes": 3320688,
      "heapUsedBytes": 65359480,
      "domNodes": 135,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 14.595999999999998,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 449.636000000055,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 24.208000000000006,
      "layouts": 4,
      "layoutDurationMs": 2.3800000000000003,
      "taskDurationMs": 122.31699999999998,
      "heapDeltaBytes": 4875064,
      "heapUsedBytes": 66904568,
      "domNodes": 117,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.008999999999999,
      "eventListeners": 83,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50922 77184 66.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.6% 1157
src/LGraphNode.ts 69.9% 388
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/workspaceAuthStore.ts 33.1% 331
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/LGraph.ts 79.1% 263
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/scripts/app.ts 71.8% 251
src/core/billing/operationLifecycle.ts 0.9% 226

@dante01yoon
dante01yoon force-pushed the jaewon/fe-2216-phase-5-adopt-the-billing-sdk-in-comfyui_frontend-behind-a branch from a289661 to fe777e5 Compare September 14, 2026 17:37
@dante01yoon
dante01yoon changed the base branch from jaewon/fe-2227-phase3-integration to jaewon/fe-2227-billing-session-type September 14, 2026 17:37
@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 14, 2026
@codecov

codecov Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.89189% with 24 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...atform/workspace/billing/sdk/topupOperationView.ts 78.72% 10 Missing ⚠️
.../platform/workspace/billing/sdk/billingSdkStore.ts 92.92% 7 Missing ⚠️
...tform/workspace/billing/sdk/billingSdkTestUtils.ts 93.10% 2 Missing ⚠️
.../components/TopUpCreditsDialogContentWorkspace.vue 90.00% 2 Missing ⚠️
...rc/platform/workspace/stores/workspaceAuthStore.ts 50.00% 2 Missing ⚠️
...tform/workspace/composables/useWorkspaceBilling.ts 96.96% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main   #17665      +/-   ##
==========================================
+ Coverage   82.54%   83.51%   +0.97%     
==========================================
  Files        2811     2164     -647     
  Lines      140882   125374   -15508     
  Branches    36247    31930    -4317     
==========================================
- Hits       116289   104705   -11584     
+ Misses      23390    20375    -3015     
+ Partials     1203      294     -909     
Flag Coverage Δ
e2e 66.08% <34.09%> (-0.59%) ⬇️
unit 78.47% <92.49%> (+0.02%) ⬆️
website-unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/useFeatureFlags.ts 99.25% <100.00%> (+0.02%) ⬆️
...tform/workspace/billing/sdk/billingSdkTelemetry.ts 100.00% <100.00%> (ø)
...platform/workspace/billing/sdk/createBillingSdk.ts 100.00% <100.00%> (ø)
...latform/workspace/composables/useTopupOperation.ts 100.00% <100.00%> (ø)
...tform/workspace/composables/useWorkspaceBilling.ts 96.27% <96.96%> (-0.19%) ⬇️
...tform/workspace/billing/sdk/billingSdkTestUtils.ts 93.10% <93.10%> (ø)
.../components/TopUpCreditsDialogContentWorkspace.vue 87.00% <90.00%> (+0.28%) ⬆️
...rc/platform/workspace/stores/workspaceAuthStore.ts 90.80% <50.00%> (-0.28%) ⬇️
.../platform/workspace/billing/sdk/billingSdkStore.ts 92.92% <92.92%> (ø)
...atform/workspace/billing/sdk/topupOperationView.ts 78.72% <78.72%> (ø)

... and 683 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 14, 2026
…g#17668)

## Summary

Stacked on Comfy-Org#17466. The top-up "Buy credits" dialog showed "Checkout
could not start" on every Continue click, even though the backend was
creating the Stripe session fine.

The client validator in `buy-credits.ts` only accepted
`checkout.stripe.com`, but the Comfy Stripe account serves its hosted
Checkout page from a custom domain, `checkout.comfy.org`, in every
environment (confirmed in the cloud repo's
`environments/prod/api_checkout_test.tf`). So a valid 200 with a
`checkout.comfy.org` URL was rejected as `INVALID_RESPONSE`, which falls
through to the generic failure state. The backend had already opened the
session, so the user was blocked on a checkout that actually existed.

Reproduced locally against staging: Continue returned 200 with
`checkout_url: https://checkout.comfy.org/c/pay/cs_test_...` and the
dialog still failed.

## Changes

- Allowlist both `checkout.stripe.com` and `checkout.comfy.org` in the
checkout-URL validator, via an exact-match Set. All the other guards
stay (https only, no port, no embedded credentials), so look-alikes like
`checkout.comfy.org.evil.test` are still refused.
- Add unit coverage: accept the custom domain, and reject the
custom-domain look-alike.

## Review Focus

- The custom domain is a Stripe-account setting, so this affects prod
too, not just staging/preview. Worth confirming `checkout.comfy.org` is
the only additional host prod emits.
- Jaewon's billing-SDK stack (Comfy-Org#17655-Comfy-Org#17665) may later replace this
file. This fix unblocks the current dialog in the meantime; if the SDK
path lands first, fold the same allowlist there.

## Testing

- `vitest run src/lib/workshop/buy-credits.test.ts` — 11 pass (2 new)
- `vitest run src/components/workshop/BuyCreditsDialog.test.ts` — 17
pass
- Full workshop + credits suite — 414 pass, 49 files
- `astro check` — 0 errors, 0 warnings
- `eslint` / `oxfmt` on changed files — clean
@dante01yoon
dante01yoon force-pushed the jaewon/fe-2227-billing-session-type branch from 9cbec4a to 05638e6 Compare September 15, 2026 01:31
@dante01yoon
dante01yoon force-pushed the jaewon/fe-2216-phase-5-adopt-the-billing-sdk-in-comfyui_frontend-behind-a branch from b6f0e41 to 931ef2f Compare September 15, 2026 01:31
dante01yoon added a commit that referenced this pull request Sep 15, 2026
…FE-2214) (#17689)

## Why

FE-2214's done-when says all three current top-up hosts can integrate
the top-up command. #17657 covers ComfyUI_frontend's route (`POST
/api/billing/topup`, an operation to poll). Workshop (`apps/website`)
and Platform ship on the other route, `POST
/api/billing/topup/checkout`: a provider-hosted Checkout session with no
`billing_op_id`, credits landing through a webhook. That route could not
be decoded with generated schemas until the ingest-types regen #17396
merged; it now carries `CreateTopupCheckoutRequest` /
`CreateTopupCheckoutResponse`, so this is the 3A-2 follow-up recorded on
FE-2214.

Stacked on #17657 (FE-2214 top-up command); merge after it.

## How

`createTopupCommand` gains a second method on the same surface,
`createHostedTopupCheckout({ amountCents, returnUrl, signal? })`:

- input is validated by the generated `zCreateTopupCheckoutRequest`;
`INVALID_AMOUNT` / `INVALID_RETURN_URL` are returned before anything is
sent
- the same capability gate as the in-app command (`ACCESS_DENIED`
carrying the server's denial), then the pre-purchase balance is read
- one idempotency key per attempt, in the body and on the request; a 404
maps to `NOT_AVAILABLE` so a host keeps its legacy path while
`topup_checkout_enabled` is off
- `checkout_url` must be https (`validateActionUrl`, the same rule every
lifecycle continuation obeys), otherwise `MALFORMED_RESPONSE`;
`session_id` passes through when present
- nothing is adopted on the lifecycle and no operation id is invented
(FE-2214 invariant): the result is `{ url, sessionId?, baselineMicros?
}`. The host executes its `OpenUrlMode` on `url` (Workshop pre-opens a
tab, Platform redirects) and on return arms the existing
`createBalanceWatch` with `baselineMicros`, which is how the test proves
completion

`readTopupEligibility` (from the fallow split on #17657) now returns the
two failures it can actually produce, which is what lets the hosted
result union exclude `NO_PAYMENT_METHOD`.

## AS-IS / TO-BE

AS-IS: `TopupCommand` exposes `createTopupCheckout` only; Workshop keeps
its own `createTopUpCheckout` fetch with a hand-written `zTopUpCheckout`
schema, and Platform its own.
TO-BE: `TopupCommand` exposes `createHostedTopupCheckout` over the
generated contract; a host adapter is a thin wrapper (validate → gate →
POST → open → balance watch). No UI in this PR, so no screenshots; the
consumer cutover for Workshop is a separate slice.

## Testing

Eight new tests under `createHostedTopupCheckout` in `topup.test.ts`:
success shape, request body and idempotency key, and no lifecycle
operation; `can_top_up` false without a POST; amount and return-URL
rejection without a request; 404 → `NOT_AVAILABLE`; missing or non-https
URL → `MALFORMED_RESPONSE`; optional session id and baseline omitted
when unknown; baseline handed to a balance watch that reconciles on
return; no server or provider text on the failure path. Billing core
suite 187 passing; oxlint, eslint, oxfmt, `vue-tsc` clean.

## Stack (2026-09-15)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442 · ingest-types regen #17396"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  A --> A2["FE-2214 3A-2 hosted top-up checkout<br/>this PR"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  A2 -.-> WS["Workshop adapter over createHostedTopupCheckout<br/>later slice"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe (FE-2331)"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  H --> H8["FE-2331 Phase 8 hosted surfaces"]
```

Design: [Billing SDK implementation plan
(V2)](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8).
Linear: FE-2214.
dante01yoon added a commit that referenced this pull request Sep 15, 2026
The context claimed the cloud app reaches billing through
createSessionBillingTransport. It does not: billing and workspaces go
through workspaceApi's axios client, which carries
attachUnifiedRemintInterceptor, and the transport's only callers
outside its definition are tests. So the re-mint rule is duplicated
twice in production today, not three times, with the transport a
designed replacement awaiting #17665.

Rule 3 also overstated compliance. The checkout and workspace-list
sites compare workspace id; the balance reader's publish guard
compares uid and token and leans on the credential being a
workspace-scoped JWT.
dante01yoon added a commit that referenced this pull request Sep 15, 2026
…river (FE-2227) (#17656)

## Why

Stacked on #17655 (FE-2227); merge after it. The two Phase 3 command PRs
— top-up ([FE-2214](https://linear.app/comfyorg/issue/FE-2214)) and
subscription ([FE-2223](https://linear.app/comfyorg/issue/FE-2223)) —
both need to act on the server's coded error (`NO_PAYMENT_METHOD`,
`ALREADY_CANCELED`, …) and both need to drive an embedded 3DS challenge
through the lifecycle. FE-2223 may not depend on FE-2214, so the shared
pieces land here, on the core, and each command PR stacks on this one.

## How

- `BillingFailure.serverCode` (additive, optional):
`readValidatedBillingResponse` decodes a non-2xx body with the generated
`zErrorResponse` and carries only its `code`. The `message` is read by
the schema and dropped in `billingErrorBody.ts`, so server text still
cannot travel into the SDK. The codes are `z.string()` in the generated
contract, so each command owns a closed allowlist of the codes it acts
on.
- `driveEmbeddedChallenge(lifecycle, operationId, port)`:
`reportChallengeStarted` → `port.handleNextAction(clientSecret)` →
`reportChallengeSettled`. The port is Stripe's `handleNextAction` shape;
no provider SDK is imported in core, the host injects the object. The
unmoved-intent denylist (`requires_payment_method | requires_action |
canceled` → failed) is ported from
`billingOperationStore.runPaymentIntentAction` on this repo's `main`
(`src/platform/workspace/stores/billingOperationStore.ts:51-55`, `:555`;
landed in `a39b1ce9fa3`, 2026-09-03 — it is not in `cf-main`), and fails
toward the server: an unknown status reports completed and the next poll
corrects it.

## AS-IS / TO-BE

AS-IS: a command sees only `REQUEST_FAILED` + `httpStatus` for a 4xx and
cannot tell "no payment method" from "declined"; each command PR would
re-implement the 3DS drive over `reportChallenge*`.
TO-BE: `result.serverCode === 'NO_PAYMENT_METHOD'` is one comparison;
the challenge drive is one call. No UI surface, so no screenshots.

## Testing

`packages/account` 473/473. Named tests: coded error carried without its
message; non-contract error body yields no code; moved intent →
completed; error / unmoved intent / throw → failed; nothing driven
without a required embedded challenge.

## Stack (2026-09-14)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
```
dante01yoon added a commit that referenced this pull request Sep 15, 2026
…FE-2214) (#17689)

## Why

FE-2214's done-when says all three current top-up hosts can integrate
the top-up command. #17657 covers ComfyUI_frontend's route (`POST
/api/billing/topup`, an operation to poll). Workshop (`apps/website`)
and Platform ship on the other route, `POST
/api/billing/topup/checkout`: a provider-hosted Checkout session with no
`billing_op_id`, credits landing through a webhook. That route could not
be decoded with generated schemas until the ingest-types regen #17396
merged; it now carries `CreateTopupCheckoutRequest` /
`CreateTopupCheckoutResponse`, so this is the 3A-2 follow-up recorded on
FE-2214.

Stacked on #17657 (FE-2214 top-up command); merge after it.

## How

`createTopupCommand` gains a second method on the same surface,
`createHostedTopupCheckout({ amountCents, returnUrl, signal? })`:

- input is validated by the generated `zCreateTopupCheckoutRequest`;
`INVALID_AMOUNT` / `INVALID_RETURN_URL` are returned before anything is
sent
- the same capability gate as the in-app command (`ACCESS_DENIED`
carrying the server's denial), then the pre-purchase balance is read
- one idempotency key per attempt, in the body and on the request; a 404
maps to `NOT_AVAILABLE` so a host keeps its legacy path while
`topup_checkout_enabled` is off
- `checkout_url` must be https (`validateActionUrl`, the same rule every
lifecycle continuation obeys), otherwise `MALFORMED_RESPONSE`;
`session_id` passes through when present
- nothing is adopted on the lifecycle and no operation id is invented
(FE-2214 invariant): the result is `{ url, sessionId?, baselineMicros?
}`. The host executes its `OpenUrlMode` on `url` (Workshop pre-opens a
tab, Platform redirects) and on return arms the existing
`createBalanceWatch` with `baselineMicros`, which is how the test proves
completion

`readTopupEligibility` (from the fallow split on #17657) now returns the
two failures it can actually produce, which is what lets the hosted
result union exclude `NO_PAYMENT_METHOD`.

## AS-IS / TO-BE

AS-IS: `TopupCommand` exposes `createTopupCheckout` only; Workshop keeps
its own `createTopUpCheckout` fetch with a hand-written `zTopUpCheckout`
schema, and Platform its own.
TO-BE: `TopupCommand` exposes `createHostedTopupCheckout` over the
generated contract; a host adapter is a thin wrapper (validate → gate →
POST → open → balance watch). No UI in this PR, so no screenshots; the
consumer cutover for Workshop is a separate slice.

## Testing

Eight new tests under `createHostedTopupCheckout` in `topup.test.ts`:
success shape, request body and idempotency key, and no lifecycle
operation; `can_top_up` false without a POST; amount and return-URL
rejection without a request; 404 → `NOT_AVAILABLE`; missing or non-https
URL → `MALFORMED_RESPONSE`; optional session id and baseline omitted
when unknown; baseline handed to a balance watch that reconciles on
return; no server or provider text on the failure path. Billing core
suite 187 passing; oxlint, eslint, oxfmt, `vue-tsc` clean.

## Stack (2026-09-15)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442 · ingest-types regen #17396"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  A --> A2["FE-2214 3A-2 hosted top-up checkout<br/>this PR"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  A2 -.-> WS["Workshop adapter over createHostedTopupCheckout<br/>later slice"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe (FE-2331)"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  H --> H8["FE-2331 Phase 8 hosted surfaces"]
```

Design: [Billing SDK implementation plan
(V2)](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8).
Linear: FE-2214.
@dante01yoon
dante01yoon force-pushed the jaewon/fe-2227-billing-session-type branch from 05638e6 to 485544f Compare September 15, 2026 15:43
@dante01yoon
dante01yoon force-pushed the jaewon/fe-2216-phase-5-adopt-the-billing-sdk-in-comfyui_frontend-behind-a branch from 931ef2f to 4b87c06 Compare September 15, 2026 15:43
@dante01yoon

Copy link
Copy Markdown
Collaborator Author

CI was red on this head after the rebase: src/platform/workspace/billing/sdk/billingSdkTestUtils.ts(81,5): error TS2741. The rebase onto the Phase 3 core brought TopupCommand.createHostedTopupCheckout, and the frontend test double still implemented only createTopupCheckout, so setup and lint-and-format both failed on typecheck and everything downstream of setup (scan, validate-fonts, perf-tests, e2e) fell over with it.

Fixed in 86e2d6b by completing the double. No production code touched; pnpm typecheck is clean and the four suites that consume the double pass (billingSdkStore, useTopupOperation, useWorkspaceBilling.sdk, topupOperationView — 35 tests).

dante01yoon added a commit that referenced this pull request Sep 15, 2026
)

## Why

Stacked on B1
(`jaewon/fe-2223-phase-3b-subscription-commands-and-eight-state-payment`,
#17658) → PR 0 (`jaewon/fe-2227-core-error-codes-and-challenge-driver`,
#17656) → #17655 (FE-2227); independent of FE-2214; merge after all
parents.

Phase 3B, part 2 of 2: the eight public payment states as a pure
projection of one lifecycle operation, plus the copy keys behind them.
Split out of B1 to keep each PR under the source budget.

- Linear: https://linear.app/comfyorg/issue/FE-2223

## How

New `packages/account/src/core/billing/paymentProjection.ts` and
`paymentCopy.ts` (+ tests), export lines appended to `index.ts`. No
other core file is touched.

`projectPaymentStep(operation | undefined, hostStep: 'select' |
'preview' | 'canceled')` → `{ step, reasonKey?, recoveryAction?,
operationId?, noChargeConfirmed }` over the eight states `select |
preview | verifying | canceled | declined | processing_error |
payment_received_hold | success`.

- No operation → the host's step. Pending: parked on the customer
(`challenge` or `actionUrl`) → `verifying`; a retryable decline
(`declineReason`, or this tab's failed challenge →
`authentication_failed`) → `declined`; otherwise `preview`. `succeeded`
→ `success`; `failed` → `declined`, except `processing_error` /
`generic` → `processing_error`; `timed_out` → `processing_error`
(`generic`); `superseded` → `select`.
- Reason keys are the generated `decline_reason` enum plus
`checkout_expired` and `generic`; copy keys are `billing.reason.<key>`.
No raw text can become a key.
- `paymentCopy.ts` ports the PoC `copy.ts` semantics:
`DEFAULT_PAYMENT_COPY`, `createPaymentCopy(overrides)` where the safety
line `billing.safety.nothing_was_charged` is not host-overridable, and
`paymentCopyKeys(projection)` which names the safety key only for
`canceled` with `noChargeConfirmed`.
- `noChargeConfirmed` is always `false`: the generated contract has no
field that lets a terminal backend result guarantee no current or later
charge (one short comment in code says so). Relates to the BE cancel
endpoint work (BE-10064).

Tests: every projection row (24 via `it.for`, including the host-cancel
precedence rows and a sweep asserting `noChargeConfirmed` is never true
and `payment_received_hold` is never produced) and the copy gate (3,
including the PoC TP-12 port).

## Review focus

Two decisions the plan left open, made here:

1. Lifecycle `reconciliation_needed` projects to `processing_error`
(`generic`) with `operationId` surfaced, not to `payment_received_hold`.
The contract cannot tell "paid, entitlement pending" from "needs a
human"; the id is what support acts on. `payment_received_hold` stays in
the public union and copy table but has no producing row until the
backend distinguishes the two.
2. `canceled` is reached only through the host: `hostStep` accepts
`'canceled'` for a cancel the host observed (closed page, dismissed
challenge). A server verdict (`succeeded`, `failed`,
`reconciliation_needed`) outranks it — a customer who backs out after
the charge went through still sees the result — while pending,
`timed_out`, and `superseded` yield to it.

Ticket vs generated contract:
- `checkout_expired` has no producing row:
`BillingOpStatusResponse.status` has no `expired` value. The key and its
copy are kept for the host and for the backend adding one.
- `noChargeConfirmed` has no source field, so it is a `boolean` that is
always `false` (a literal `false` type makes the copy gate dead by type
and fails `no-unnecessary-condition`).

## AS-IS / TO-BE

No UI surface, no screenshots.

AS-IS: the PoC reducer derived these states from an invented operation
status set (`expired`, `canceled`, `payment_received_hold`) and matched
raw `error_message` text for reasons.

TO-BE: a pure projection over the real `BillingOperationState`; hosts
render `step`/`reasonKey`/`operationId` and localize by copy key.

## Stack (2026-09-14)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
```
dante01yoon added a commit that referenced this pull request Sep 15, 2026
…(FE-2223) (#17658)

## Why

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
```


Stacked on PR 0 (`jaewon/fe-2227-core-error-codes-and-challenge-driver`,
#17656) → #17655 (FE-2227); independent of FE-2214; merge after both
parents.

Phase 3B, part 1 of 2: the subscription commands ported onto the
SDK-owned billing operation lifecycle. Part 2 (the eight-state payment
projection and copy) is stacked on this PR so each stays under the
source budget.

- Linear: https://linear.app/comfyorg/issue/FE-2223

## How

New `packages/account/src/core/billing/subscriptionCommands.ts` (+
test), export lines appended to `index.ts`. No other core file is
touched.

`createBillingCommands({ transport, lifecycle, statusReader,
capabilities, credits, idempotencyKey? })` returns `subscribe`,
`resubscribe`, `cancelSubscription`, `openPaymentPortal`.

- Every command encodes against the generated contract
(`zSubscribeRequest/Response`, `zResubscribeResponse`,
`zCancelSubscriptionResponse2` = the generated union of
`zCancelSubscriptionResponse | zCancelSubscriptionAcceptedResponse`,
`zPaymentPortalResponse`), reads through `readValidatedBillingResponse`,
and issues through `lifecycle.begin` — single-flight, the status gate,
backend-pending adoption, polling, routing, pointer, recovery, and
telemetry all stay in core. The command then awaits
`lifecycle.settled(id)` and returns the terminal state.
- Eligibility comes from the Phase 2 status snapshot's server fields
only (`is_active`, `subscription_tier`, `subscription_status`): FREE →
subscribe issues; PRO active → subscribe is a no-op success with no
request; PRO canceled → subscribe routes to the resubscribe endpoint.
- Saved payment method: `saved_payment_method_id` XOR
`confirmation_token`, empty strings dropped, both present →
`CONFLICTING_PAYMENT_METHOD` before any request (before the status read
too); a request the generated schema refuses (e.g. an id without the
`pm_` prefix) → `INVALID_REQUEST`, also before any request.
- Response mapping: `subscribed` and resubscribe `active` still adopt
the id so the first poll settles it and invalidation/telemetry are
uniform; `needs_payment_method` hands `payment_method_url` to the
lifecycle as the hosted `actionUrl` (missing →
`MISSING_PAYMENT_METHOD_URL`); `pending_payment` / `pending` / both
cancel shapes → observed to a terminal state. 3DS is driven by the host
through the existing `driveEmbeddedChallenge` while the command awaits
settlement (tested end to end through the real lifecycle).
- Server codes (via `BillingFailure.serverCode`):
`REACTIVATION_CONFIRMATION_REQUIRED` → coded result for the host to
re-preview and resend with `confirm_reactivation`; `ALREADY_CANCELED` /
`NOT_SCHEDULED_FOR_CANCELLATION` from a 4xx → already-in-requested-state
success after a status re-read (a 5xx echoing the code stays a failure,
as in `useWorkspaceBilling.isAlreadyInRequestedState`);
`NO_ACTIVE_SUBSCRIPTION` → coded error. Command-level codes live in
`SubscriptionCommandCode`; `BillingErrorCode` is untouched.
- Every succeeded outcome (settled operation or already-in-state)
invalidates the capabilities read and re-reads credits and status (so
`cancel_at` is available after a cancel). A failed credits read never
turns a success into a failure.
- `idempotency_key` goes in every subscribe/resubscribe/cancel body and
as `idempotencyKey` on the `BillingRequest` (the transport's 401 replay
gate), one key per attempt. The portal request carries neither (the
contract has no key; a portal session is not a mutation).
- `openPaymentPortal` returns `{ url }` after `validateActionUrl` (https
only); the SDK never opens it and does not refresh anything on it.
- Raw server / provider text (`message`, `error_message`) never reaches
a result; asserted in the decline, 5xx, coded-error, and resubscribe
(`message` field) tests.

Tests (32, one per ticket row): the {FREE, PRO active, PRO canceled} ×
{subscribe, resubscribe, cancel, portal} matrix including
subscribe→resubscribe routing; saved payment method (4); 3DS through
`driveEmbeddedChallenge`, hosted page, missing page; declines and
reactivation; both cancel response shapes and the 5xx echo; transport
failure, malformed 2xx, 5xx, failed eligibility read; reconciliation;
and reload/resume, poll timeout, and workspace supersession through the
real lifecycle with fake timers.

## Review focus

- Subscribe reads status once for eligibility and `lifecycle.begin`
reads it again for its own pending gate: two `GET /billing/status` per
subscribe. Avoiding it would need a core change (letting `begin` accept
a status), which this PR deliberately does not make.
- Per the eligibility doc, a PRO-active subscribe is a no-op regardless
of `plan_slug`; a plan change on an active subscription (the app's
`checkoutType: 'change'`) is therefore not reachable through this
command yet. Flagged, not silently decided.
- A `needs_payment_method` without a URL is refused without adopting the
id; the backend still reports it as pending, so the next
`begin`/`recover` adopts it rather than reissuing.

Ticket vs generated contract:
- The ticket's resubscribe "`active` → sync success without an id" is
unreachable: `zResubscribeResponse.billing_op_id` is required, so the id
is adopted uniformly.
- `zPaymentPortalRequest` has no `idempotency_key`; the portal POST is
sent without one.

## AS-IS / TO-BE

No UI surface, no screenshots.

AS-IS: subscription commands live in the cloud app (`workspaceApi`,
`useSubscriptionCheckout`, `useWorkspaceBilling`) with their own
polling, pending-checkout storage, and error-string handling.

TO-BE: `@comfyorg/account/billing` exports `createBillingCommands`;
hosts issue commands and render the lifecycle state, never own the
machine, and never see server text.

## Stack (2026-09-14)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe + plan-change decision"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  S["FE-2211 salvage tag d059104<br/>before 2026-09-30"] -.-> E
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  AD1 -.-> SPLIT["account-core / account-ui rename PR"]
  SPLIT -.-> H
```
dante01yoon added a commit that referenced this pull request Sep 15, 2026
…FE-2214) (#17689)

FE-2214's done-when says all three current top-up hosts can integrate
the top-up command. #17657 covers ComfyUI_frontend's route (`POST
/api/billing/topup`, an operation to poll). Workshop (`apps/website`)
and Platform ship on the other route, `POST
/api/billing/topup/checkout`: a provider-hosted Checkout session with no
`billing_op_id`, credits landing through a webhook. That route could not
be decoded with generated schemas until the ingest-types regen #17396
merged; it now carries `CreateTopupCheckoutRequest` /
`CreateTopupCheckoutResponse`, so this is the 3A-2 follow-up recorded on
FE-2214.

Stacked on #17657 (FE-2214 top-up command); merge after it.

`createTopupCommand` gains a second method on the same surface,
`createHostedTopupCheckout({ amountCents, returnUrl, signal? })`:

- input is validated by the generated `zCreateTopupCheckoutRequest`;
`INVALID_AMOUNT` / `INVALID_RETURN_URL` are returned before anything is
sent
- the same capability gate as the in-app command (`ACCESS_DENIED`
carrying the server's denial), then the pre-purchase balance is read
- one idempotency key per attempt, in the body and on the request; a 404
maps to `NOT_AVAILABLE` so a host keeps its legacy path while
`topup_checkout_enabled` is off
- `checkout_url` must be https (`validateActionUrl`, the same rule every
lifecycle continuation obeys), otherwise `MALFORMED_RESPONSE`;
`session_id` passes through when present
- nothing is adopted on the lifecycle and no operation id is invented
(FE-2214 invariant): the result is `{ url, sessionId?, baselineMicros?
}`. The host executes its `OpenUrlMode` on `url` (Workshop pre-opens a
tab, Platform redirects) and on return arms the existing
`createBalanceWatch` with `baselineMicros`, which is how the test proves
completion

`readTopupEligibility` (from the fallow split on #17657) now returns the
two failures it can actually produce, which is what lets the hosted
result union exclude `NO_PAYMENT_METHOD`.

AS-IS: `TopupCommand` exposes `createTopupCheckout` only; Workshop keeps
its own `createTopUpCheckout` fetch with a hand-written `zTopUpCheckout`
schema, and Platform its own.
TO-BE: `TopupCommand` exposes `createHostedTopupCheckout` over the
generated contract; a host adapter is a thin wrapper (validate → gate →
POST → open → balance watch). No UI in this PR, so no screenshots; the
consumer cutover for Workshop is a separate slice.

Eight new tests under `createHostedTopupCheckout` in `topup.test.ts`:
success shape, request body and idempotency key, and no lifecycle
operation; `can_top_up` false without a POST; amount and return-URL
rejection without a request; 404 → `NOT_AVAILABLE`; missing or non-https
URL → `MALFORMED_RESPONSE`; optional session id and baseline omitted
when unknown; baseline handed to a balance watch that reconciles on
return; no server or provider text on the failure path. Billing core
suite 187 passing; oxlint, eslint, oxfmt, `vue-tsc` clean.

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442 · ingest-types regen #17396"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up command<br/>#17657"]
  A --> A2["FE-2214 3A-2 hosted top-up checkout<br/>this PR"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  A2 -.-> WS["Workshop adapter over createHostedTopupCheckout<br/>later slice"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe (FE-2331)"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  H --> H8["FE-2331 Phase 8 hosted surfaces"]
```

Design: [Billing SDK implementation plan
(V2)](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8).
Linear: FE-2214.
@dante01yoon
dante01yoon force-pushed the jaewon/fe-2227-billing-session-type branch from 485544f to ea83a9e Compare September 15, 2026 16:32
@dante01yoon
dante01yoon force-pushed the jaewon/fe-2216-phase-5-adopt-the-billing-sdk-in-comfyui_frontend-behind-a branch from 86e2d6b to e1f81f9 Compare September 15, 2026 16:32
dante01yoon added a commit that referenced this pull request Sep 15, 2026
…4) (#17657)

## Why

Stacked on PR 0 (`jaewon/fe-2227-core-error-codes-and-challenge-driver`,
#17656) → #17655 (FE-2227); merge after both.

Phase 3A of the billing SDK: the top-up command mapped onto the shared
operation lifecycle, covering both routes cloud exposes today. Only
request/response mapping lives here — the status-read gate,
single-flight, polling, routing, the pointer, failure meaning, and
telemetry all come from the lifecycle in #17655/#17656 and are not
duplicated.

- Linear: https://linear.app/comfyorg/issue/FE-2214

## How

`packages/account/src/core/billing/topup.ts` — `createTopupCommand({
transport, lifecycle, capabilities, credits, idempotencyKey? })`
returning two commands on one surface:

**`createTopupCheckout({ amountCents, signal? })`** — the in-app route
ComfyUI_frontend uses (`POST /billing/topup`, an operation to observe):

1. `capabilities.read()` → `can_top_up === false` ⇒ `{ status: 'error',
code: 'ACCESS_DENIED', denial? }` without a POST. The server flag is the
only gate; nothing is derived.
2. Amount validated with `zCreateTopupRequest`; the plain input object
is what travels (the schema coerces to bigint, which the transport
cannot serialize).
3. One fresh key per POST attempt, in the body (`idempotency_key`) and
as `idempotencyKey` on the `BillingRequest`. Supplying that key is what
makes the POST replayable at the transport's 401 gate (`replayable =
method === 'GET' || idempotencyKey !== undefined`): the single 401
replay is safe *because* the same key travels in both places for the
backend to deduplicate on. Backend dedup is load-bearing on this route,
not incidental. A fresh key is minted per attempt, so two user-initiated
top-ups never collide.
4. POST through `lifecycle.begin('topup', issue)`; the response is
decoded with `zCreateTopupResponse` and its `billing_op_id` adopted
regardless of `status`, so the first poll settles synchronous results
and carries the coded decline.
5. Command-level `TopupResult` union: `ok` (terminal `succeeded` state
embedded + `creditsReconciled`), `declined` (terminal `failed` state
embedded: `declineReason`, `recoveryAction`, `retryable`), `unsettled`
(`timed_out` / `reconciliation_needed` embedded), plus `error` codes —
the core `BillingErrorCode`s untouched, and `NOT_AVAILABLE` (404 on the
POST), `NO_PAYMENT_METHOD` (`serverCode`, with `recoveryAction:
'replace_payment_method'`), `INVALID_AMOUNT` (below the generated
minimum; nothing sent). A `superseded` operation passes through as
`SUPERSEDED`.
6. On `succeeded`: `capabilities.invalidate()` and a credits re-read;
`creditsReconciled` compares it with the read taken before the POST.

**`createHostedTopupCheckout({ amountCents, returnUrl, signal? })`** —
the hosted route Workshop (`apps/website`) and Platform ship on (`POST
/billing/topup/checkout`, a provider-hosted Checkout session with no
operation; credits land through a webhook). Decodable since the
ingest-types regen #17396 merged:

1. Input validated by the generated `zCreateTopupCheckoutRequest`;
`INVALID_AMOUNT` / `INVALID_RETURN_URL` before anything is sent.
2. The same capability gate, then the pre-purchase balance is read.
3. One idempotency key per attempt, in the body and on the request; 404
→ `NOT_AVAILABLE` so a host keeps its legacy path while
`topup_checkout_enabled` is off.
4. `checkout_url` must be https (`validateActionUrl`, the rule every
lifecycle continuation obeys), otherwise `MALFORMED_RESPONSE`;
`session_id` passes through when present.
5. Nothing is adopted on the lifecycle and no operation id is invented:
the result is `{ url, sessionId?, baselineMicros? }`. The host executes
its `OpenUrlMode` on `url` (Workshop pre-opens a tab, Platform
redirects) and on return arms `createBalanceWatch` with
`baselineMicros`.

`packages/account/src/core/billing/balanceWatch.ts` —
`createBalanceWatch({ credits, baselineMicros? })`, the framework-free
port of `src/composables/billing/topupBalanceRefresh.ts` (gaps `[0, 2,
5, 10, 20]s`, 15-minute lifetime, 5 scheduled runs, a single read per
wake past the cap). No document listeners: the host calls `wake()` from
its own focus/visibility signals. This is the completion path for the
hosted command and the explicit fallback when no `billing_op_id` can be
observed on the in-app one; the SDK never invents one.

Raw server / Stripe text never reaches a result (asserted in the tests).

Contract findings (generated contract wins; for FE-2211's TDD-correction
list):

- The ticket's `returnUrl` and "no `billing_op_id`" rows describe the
hosted route, not `zCreateTopupRequest` (which has only `amount_cents`,
`checkout_attempt_id`, `idempotency_key`). They are served by
`createHostedTopupCheckout`.
- `zCreateTopupResponse.billing_op_id` is required, so the in-app
command's balance-watch fallback is tested against a
`MALFORMED_RESPONSE` on the POST, not an invented id.
- The plan's `credits.read({ forceRefresh })` does not exist:
`CreditsReader.read` always requests, so it is called plainly.
- `amount_cents` is `z.coerce.bigint()` on both request schemas;
validated with `safeParse`, sent as the number.
- `ErrorResponse.code` is `z.string()`, not an enum, so
`NO_PAYMENT_METHOD` is an SDK-owned allowlist entry.

Tests (`topup.test.ts`, `balanceWatch.test.ts`), one per ticket row for
the in-app command: `can_top_up` false, saved payment method, needs 3DS
(driven through PR 0's `driveEmbeddedChallenge`), no payment method,
declined, unexpected error, payment received with credits pending, 404 →
`NOT_AVAILABLE` (and a 404 while polling left to the lifecycle), fresh
idempotency key per attempt, in the body and on the request,
generated-schema rejection, invalidation on success, scope supersession
passthrough, no-`billing_op_id` balance-watch fallback. For the hosted
command: success shape with request body, idempotency key, and no
lifecycle operation; `can_top_up` false without a POST; amount and
return-URL rejection without a request; 404 → `NOT_AVAILABLE`; missing
or non-https URL → `MALFORMED_RESPONSE`; optional session id and
baseline omitted when unknown; baseline handed to a balance watch that
reconciles on return; no server text on the failure path. Reload/resume,
routing, timeout, and duplicate-poll coverage stays in the core suite.

## AS-IS / TO-BE

No UI surface, no screenshots.

- AS-IS: the SDK exposes the lifecycle but no command issues a top-up on
it; the cloud app's `workspaceApi.createTopup` + `topupBalanceRefresh`,
Workshop's `createTopUpCheckout` fetch with a hand-written schema, and
Platform's own call remain the only paths.
- TO-BE: `@comfyorg/account/billing` exports `createTopupCommand`
(in-app and hosted top-up over the generated contract) and
`createBalanceWatch`; each host adapter is a thin wrapper that reads a
coded, text-free result. Consumer cutovers are separate slices
(ComfyUI_frontend: #17665; Workshop and Platform: later).

## Stack (2026-09-15)

Merge top-down. After a parent is squash-merged, rebase each child with
`git rebase --onto origin/main <parent tip>` and force-push; GitHub
retargets the base. Solid edges are code dependencies, dashed edges are
sequencing. The hosted command (formerly #17689) is squashed into this
PR.

```mermaid
flowchart TD
  P12["Phase 1 + 2 merged<br/>#17436 · #17442 · ingest-types regen #17396"] --> C["FE-2227 Phase 3 core<br/>#17655 · base main"]
  C --> P0["PR 0 coded error bodies + 3DS driver<br/>#17656"]
  P0 --> A["FE-2214 top-up commands, in-app + hosted<br/>#17657"]
  P0 --> B1["FE-2223 B1 subscription commands<br/>#17658"]
  B1 --> B2["FE-2223 B2 eight-state projection<br/>#17659"]
  A --> I["Integration, do not merge<br/>#17660"]
  B2 --> I
  I --> V1["FE-2215 @comfyorg/account-ui composables<br/>#17662"]
  V1 --> V2["FE-2215 CheckoutSteps<br/>#17663"]
  I --> SES["core: narrowed BillingSession type<br/>#17664"]
  SES --> AD1["FE-2216 slice 1 top-up behind a flag<br/>#17665"]
  A -.-> WS["Workshop adapter over createHostedTopupCheckout<br/>consumer slice"]
  AD1 -.-> AD2["FE-2216 slice 2 subscription<br/>needs previewSubscribe (FE-2331)"]
  AD1 --> E["FE-2217 Phase 6 evidence"]
  BW["billing-web #17370 → #17574"] --> H["FE-2218 Phase 7 separate origin"]
  AD1 --> H
  V2 -.-> H
  H --> H8["FE-2331 Phase 8 hosted surfaces"]
```
@dante01yoon
dante01yoon force-pushed the jaewon/fe-2227-billing-session-type branch from ea83a9e to 832e211 Compare September 15, 2026 16:59
@dante01yoon
dante01yoon force-pushed the jaewon/fe-2216-phase-5-adopt-the-billing-sdk-in-comfyui_frontend-behind-a branch from e1f81f9 to 6e12f90 Compare September 15, 2026 16:59
dante01yoon added a commit that referenced this pull request Sep 16, 2026
…the SDK rail behind billing_sdk_subscription_enabled (#17853)

Stacked on #17783 (base branch
`jaewon/fe-2210-hosted-destination-port`); merge that first.

## Why

Phase 5 slice 1 (#17665) moved top-up onto the Billing SDK behind
`billing_sdk_topup_enabled`. The subscription actions the host already
owns — cancel, resubscribe, and opening the payment portal — still call
the workspace API directly and rely on the legacy poller for settlement
and telemetry. This slice moves those three onto the SDK's commands
behind their own server flag, `billing_sdk_subscription_enabled`
(already on `/api/features` via Comfy-Org/cloud#9248, PostHog at 0%), so
the eight-state lifecycle, idempotency, recovery and telemetry come from
one implementation. Subscribe and plan change are slice 2b, stacked on
this PR.

## How

- **Rail switch.** `billingSdkSubscriptionRailEnabled` =
`billing_sdk_subscription_enabled` AND `unified_cloud_auth`, exactly
like the top-up rail. `useSubscriptionRail()` reads it once,
synchronously, at the start of an action, so a flag flip mid-flow cannot
issue on one rail and observe on the other.
- **Three actions, one adapter.**
`useWorkspaceBilling.cancelSubscription / resubscribe /
manageSubscription` try the rail first; the store runs
`sdk.commands.cancelSubscription()`, `resubscribe()`,
`openPaymentPortal({ returnUrl })` and projects the result onto what the
adapter already does with the legacy calls: settle, or throw a
`WorkspaceApiError` (message is the host's, since the SDK never carries
server text; `serverCode` lands in `.code`). A command that settles in
any phase but `succeeded` is a failure, matching the poller. The refresh
after success mirrors the poller's: cancel → status + balance +
capabilities; resubscribe → `reconcileSubscriptionSuccess` +
capabilities.
- **Fallback.** A 404 (backend gate closed while the client flag is on)
projects to `unavailable`: the adapter runs its legacy body for that
action, and the store latches the route as unavailable for the tab so
later actions go straight to legacy without another failed round trip.
Every other failure — including `SUPERSEDED` — is thrown, never retried
on legacy, so a late or superseded result cannot double-issue.
- **Telemetry.** Lifecycle events are now reported for non-topup
operations (top-up keeps its resumed-only filter because its dialog
reports). `toBillingTelemetryEvent` already emits the poller's payload
shape, so dashboards cannot tell the rails apart.
- **No client-derived server state.** Eligibility and already-held
answers come from the SDK and the server, as for top-up. `subscribe`,
`previewSubscribe`, `useSubscriptionCheckout` and `useLegacyBilling` are
untouched.

## AS-IS / TO-BE

| State | AS-IS (flag off) | TO-BE (flag on) |
| --- | --- | --- |
| Cancel dialog at rest | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-dialog.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-dialog.png">
|
| Cancel in flight | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-in-flight.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-in-flight.png">
|
| Cancel settled (success toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-settled.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-settled.png">
|
| Cancel failed (error toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-failed.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-failed.png">
|
| User popover after cancel (cancelled state) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-panel-after-cancel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-panel-after-cancel.png">
|
| Cancel request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-network.png">
|
| Settings billing panel | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-billing-panel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-billing-panel.png">
|
| Resubscribe (Resume Pro) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe.png">
|
| Resubscribe request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe-network.png">
|
| Payment-portal request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-portal-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-portal-network.png">
|

- AS-IS (flag off): cancel / resubscribe / portal POST the workspace API
directly; settlement and telemetry come from the legacy poller.
- TO-BE (flag on): the same dialogs and toasts, the POSTs go through the
SDK transport (`Idempotency-Key` on the request), settlement through the
operation lifecycle; a 404 falls back to the legacy call.

## Testing

| Gate | Result |
| --- | --- |
| `vitest run src/platform/workspace/billing src/composables/billing
src/platform/workspace/composables src/platform/workspace/stores
src/composables/useFeatureFlags` | 41 files, 1138 tests (12 new
projection tests, 13 new adapter rail tests, +5 store tests) |
| `pnpm typecheck`, `pnpm typecheck:browser`, `lint`, `format:check`,
`knip` | exit 0 |
| `fallow audit --changed-since
origin/jaewon/fe-2210-hosted-destination-port` | no issues in 11 changed
files, complexity 0, duplication 0 |
| Playwright
`browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts` (cloud
project) | **3 passed** against a served cloud dev build —
`PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test
--project=cloud
browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts
--reporter=list`. Flag off → legacy request, flow unchanged; flag on →
SDK request (`Idempotency-Key`), same dialog outcome; flag on + 404 →
legacy fallback. |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (#17662, #17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | #17783 (review; parent of this PR) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | #17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | #17798
(queued) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | #17798 (queued) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| #17798 (queued) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (#17827); #17844 (queued) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | #17798 (queued) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | **this PR** |
| 5 slice 2b | Subscribe / plan change through the SDK
(`previewSubscribe` quote, then subscribe; the SDK stops
short-circuiting an active plan) | FE-2216 | next, stacked on this PR |
| follow-up | One `needsCustomerAttention` predicate (from the #17665
review) | FE-2216 | merged (#17792) |
| follow-up | Opaque `BillingServerCode` (from the #17656 review) |
FE-2227 | merged (#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799
review) | FE-2215 | merged (#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged
(#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["Phase 5 slice 2a cancel / resubscribe / portal rail"]
  S2B["Phase 5 slice 2b subscribe + plan change"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style S2A stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 16, 2026
…int one (Comfy-Org#17794)

Linear FE-2227. Follow-up parked from the Comfy-Org#17656 review.

## Why

`BillingFailure.serverCode` is an unbounded server string in a contract
whose
whole point is that server text never reaches a user. Its doc said
"never
render it", but the type said plain `string`, so a command could invent
a code
and compare against it as if the server had sent one.

This closes provenance, not containment. After it, only
`readBillingErrorCode`
can mint a `BillingServerCode`, so a code that reaches a comparison is
one the
server actually sent. The value is still `string` underneath, so
interpolating
it into copy, widening it with `??`, concatenating it or passing it to
`t()`
all still compile — the rendering half of the Comfy-Org#17656 finding stays open,
and
the file comment says so. Full containment is costed in "Not done here"
below.

## How

- `BillingServerCode = string & { readonly [brand]: true }` with a
module-private `unique symbol`, so the brand cannot be forged outside
the
  module that declares it.
- `readBillingErrorCode` is the single producer and the only place the
brand
is minted, at the decode boundary. The brand erases at runtime, so there
is
  no cost.
- Two contract-level helpers bound what a holder can do:
`matchesServerCode`
compares against a code a command names, and `unwrapServerCode` is the
one
widening back to `string`, so every widening is visible at its call
site.
- The four equality comparisons (`topup.ts` `commandFailure`,
`subscriptionCommands.ts` `alreadyInRequestedState`, `mapServerCode`,
and
  the reactivation check) now go through `matchesServerCode`. The named
  constants and their closed sets stay where they were.
- The one host handoff, `topupFailureError` in `topupOperationView.ts`,
calls
`unwrapServerCode` to put the code where `WorkspaceApiError.code`
already
  lives. It is the only widening in the tree.

## AS-IS / TO-BE

No behaviour change; the change is type-level only. AS-IS, any caller
could
write `const code: BillingFailure['serverCode'] = 'NO_PAYMENT_METHOD'`
and
compare against a code no server ever sent. TO-BE that line is a compile
error,
and the only values in the field came through the decode boundary.
Rendering
paths are unchanged in both directions. Every existing test passes with
the
same assertions.

## Not done here

Making the brand genuinely opaque — dropping the `string &` so nothing
reads it
without `unwrapServerCode` — is the containment half, and it is cheapest
now:
`topupOperationView.ts:98` is the only consumer today and it already
calls
`unwrapServerCode`. Measured cost of the switch, from compiling it:
three
errors, all inside the declaring module — `matchesServerCode`'s `===`,
`unwrapServerCode`'s return, and the mint in `billingErrorBody.ts` —
each
needing an `as unknown as` that the current declaration does not. That
tradeoff
(containment bought with double casts in the owning module) is a
deliberate
call, not a default, and Comfy-Org#17798 / Comfy-Org#17799 add consumers this week.
Flagged for a
decision rather than taken here.

## Testing

- New `billingContracts.test.ts`: a table over `matchesServerCode` for a
  matching code, a different code, and a failure with no error body; a
  `@ts-expect-error` case proving a plain string is not assignable to
`serverCode`; and `unwrapServerCode` returning the string the server
sent.
- Fixtures mint codes through `readBillingErrorCode` on a real error
body
  rather than casting, so the test exercises the production decode.
- `pnpm typecheck`, `pnpm lint`, `pnpm format`, `pnpm knip`,
`fallow audit --changed-since origin/main`, and the account, account-ui,
and
  `src/platform/workspace/billing` suites all pass.
## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | open (Comfy-Org#17783) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | open (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | local, opens after Comfy-Org#17782 and Comfy-Org#17783 |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | in progress |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
open (Comfy-Org#17793) |
| 8 | `previewSubscribe`, plans, payment-methods readers + account-ui +
billing-web views | FE-2331 | todo |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests + live E2E per flow × consumer | FE-2217 | todo |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo
(plan-change decision) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | open (Comfy-Org#17792) |
| follow-up | Unforgeable `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | **this PR** |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8["Phase 8 readers + billing-web views"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6["Phase 6 evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["unforgeable BillingServerCode"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P4 --> P8
  P8 --> S2
  P5 --> P6
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style FU11 stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 16, 2026
…ders, hosted composables, own-origin session and v1 surfaces (Comfy-Org#17798)

Linear FE-2331 / FE-2218.

This PR is the whole Phase 8 view layer after the stack was
consolidated: Comfy-Org#17799 (account-ui `usePlans` / `usePaymentMethods` /
`usePreviewSubscribe` + app-root readers), Comfy-Org#17807 (billing-web
own-origin session, sign-in, SDK composition) and Comfy-Org#17809 (billing-web
`/v1` entry routing, subscription and payment-method surfaces) were
squash-merged into this branch; their bodies, decisions and screenshots
remain on those PRs. Rebased onto main after Comfy-Org#17782 (scopeSource),
Comfy-Org#17795 (billing-contract) and Comfy-Org#17797 (previewSubscribe) landed, so none
of that content is in this diff.

## Why

Phase 8's hosted billing surfaces render plan management and saved
payment
methods, and both reads have to go through the billing SDK so they
inherit the
scope tracking, deduplication, and coded failures the other readers
already
have. The generated schemas for both routes exist, so nothing has to be
hand-declared.

## How

- `plans.ts`: `createPlansReader` over `GET /billing/plans`, decoded
with
`zGetBillingPlansResponse`. No freshness window — the catalog carries no
  declared lifetime, so the host decides when to re-read.
- `paymentMethods.ts`: `createPaymentMethodsReader` over
  `GET /billing/payment-methods`, decoded with
`zListSavedPaymentMethodsResponse`, plus `invalidate()` so a host
returning
from the payment portal can drop the list it holds without a scope
change.
- Both follow the existing reader shape exactly:
`createBillingScopeTracker`
drops the snapshot and any in-flight read on a scope change, concurrent
reads
  for one scope share a single request, a 2xx that fails the schema is
`MALFORMED_RESPONSE`, and HTTP failures map through `codeForHttpStatus`.
- Exported from `@comfyorg/account/billing` alongside the credits,
status, and
  capabilities readers.

The four readers now share the same request/publish body, which `fallow
audit`
reports as a duplication warning. Factoring it out would touch
`credits.ts` and
`status.ts`, which two open PRs already modify, so it is left for a
follow-up.

## AS-IS / TO-BE

No UI change. The cloud app still calls `workspaceApi.getBillingPlans`
and
`workspaceApi.listSavedPaymentMethods`; the composables and host wiring
that
move it onto these readers land in separate PRs.

## Testing

`plans.test.ts` and `paymentMethods.test.ts` cover the decode and scope
of a
successful read, the caller timeout reaching the request, deduplication
of
concurrent reads, a scope change in flight reporting `SUPERSEDED` with
nothing
cached, a signed-out reader reporting `NOT_AUTHENTICATED` without a
request, the
HTTP status table (401 replayed and unreplayed, 403, 404, 500), a
malformed 2xx,
and `dispose`. Payment methods additionally cover the empty list and
`invalidate` dropping the snapshot so the next read refetches.

`pnpm typecheck`, `pnpm lint`, `pnpm format`, `pnpm knip`, and
`fallow audit --changed-since origin/main` pass.

Follow-up, not in this PR: the four readers now share a 32-line
scope/in-flight skeleton (`credits.ts`, `status.ts`, `plans.ts`,
`paymentMethods.ts`; fallow reports it as one clone family). Comfy-Org#17782 has
landed, but extracting it still touches files Comfy-Org#17794 is changing, so it
waits for that to land.

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | open (Comfy-Org#17783) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | local, opens after Comfy-Org#17783 and Comfy-Org#17794 |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | **this PR**
|
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | **this PR** (was Comfy-Org#17799) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| **this PR** (was Comfy-Org#17807) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | **this PR** (was Comfy-Org#17809) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests + live E2E per flow × consumer | FE-2217 | todo |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo
(plan-change decision) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | open (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | open (Comfy-Org#17824) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6["Phase 6 evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  P5 --> P6
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style P8RD stroke:#0366d6,stroke-width:4px
  style P8 stroke:#0366d6,stroke-width:4px
  style BWS stroke:#0366d6,stroke-width:4px
  style BWV stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 16, 2026
… a status (Comfy-Org#17844)

Follow-up to Comfy-Org#17827, from @huang47's review.

## Why

Two of the three review points, both in files Comfy-Org#17827 touched.

**1. The workflow does not gate on itself**
([comment](Comfy-Org#17827 (comment))).
`app_billing_web` listed only `apps/billing-web/**`, so a PR that
changes nothing but `ci-billing-web-unit.yaml` leaves `billing-web-unit`
skipped and `billing-web-unit-gate` passing through its skip branch.
Comfy-Org#17827 merged exactly that way — run
[35103654481](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35103654481)
never executed the job it added. Only the post-merge push run on `main`
([35121739924](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35121739924))
did, because every filter output defaults to `'true'` off
`pull_request`.

**2. The flag has no status of its own**
([comment](Comfy-Org#17827 (comment))).
`codecov.yml` declared the `billing-web` flag but no
`project.billing-web` / `patch.billing-web` under `coverage.status`,
while the website flag has both. The upload arrived with nothing
attributing it, which is why Comfy-Org#17827 showed live `codecov/patch/website`
and `codecov/project/website` checks and no billing-web counterparts.

## How

- `app_billing_web` now lists
`.github/workflows/ci-billing-web-unit.yaml`, the way `app_website`
lists `ci-website-e2e.yaml` and its two scripts. Output description
updated to match.
- `project.billing-web` and `patch.billing-web` mirror the website
entries verbatim apart from the path and flag: scoped to
`apps/billing-web/src/**`, `informational: true`,
`flag_coverage_not_uploaded_behavior: pass`, so a skipped job does not
fail the status.

## Also in this PR (added after the first push)

**The flag rename** (`billing-web` → `billing-web-unit`, @huang47's
third point) landed as a second commit, 089a852. It changes `flags:`
in `ci-billing-web-unit.yaml`, the `flags:` list of both new status
entries and the `flags.` block in `codecov.yml` in one commit, so the
upload and the config never disagree. The status keys stay `billing-web`
(check names `codecov/project/billing-web`,
`codecov/patch/billing-web`), mirroring how the website keeps status key
`website` with flag `website-unit`. The first push could not include it
because that session's token lacked the `workflow` scope; this push has
it.

Deliberately unchanged: `app_website` still does **not** list
`ci-website-unit.yaml` (only the e2e workflow and its two scripts), so
the website *unit* workflow keeps the blind spot this PR fixes for
billing-web. @huang47 — worth the matching one-liner, or do you want the
asymmetry left alone?

## AS-IS / TO-BE

No UI change; CI configuration only.

- AS-IS: a `ci-billing-web-unit.yaml`-only PR skips the suite and
reports a green gate. The `billing-web` flag uploads with no dedicated
status.
- TO-BE: that PR runs the suite. The upload gets
`codecov/project/billing-web` and `codecov/patch/billing-web`.

## Testing

- `curl -X POST --data-binary @codecov.yml https://codecov.io/validate`
→ `Valid!`. Both new statuses resolve to flag `billing-web` and path
`(?s:apps/billing\-web/src/.*)\Z`.
- Cross-checked the three places the flag name appears — the workflow's
`flags:`, `flags.billing-web`, and both status entries — all read
`billing-web`, so the upload is attributed.
- Both changed files parse as YAML; `app_billing_web` resolves to
`['apps/billing-web/**', '.github/workflows/ci-billing-web-unit.yaml']`.
- Not demonstrated end-to-end: this PR touches neither
`apps/billing-web/**` nor the workflow, so `billing-web-unit` is
expected to **skip** here too. The self-test behaviour can only be
observed on a PR that edits the workflow file, which is the push this
token cannot make. The mechanism is the same glob matching that already
makes `app_website` react to `ci-website-e2e.yaml`.

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | todo (after Comfy-Org#17783, Comfy-Org#17794) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | Comfy-Org#17798
(review) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | Comfy-Org#17798 (review) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| Comfy-Org#17798 (review) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827); **this PR** (Comfy-Org#17844) self-tests the workflow
and adds the flag statuses |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | Comfy-Org/cloud#9512 (approved
x2, CI rerun) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | Comfy-Org#17798 (review) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo
(plan-change decision) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | Comfy-Org#17794 (review) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  CI["billing-web unit CI: PR 17827 (merged) + PR 17844 follow-up"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  BWS --> CI
  CI --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style CI stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 16, 2026
… billing reads (Comfy-Org#17852)

Stacked on Comfy-Org#17798 (base branch
`jaewon/fe-2331-plans-payment-methods-readers`); merge that first.
Comfy-Org#17851 (the `account-core` rename) sits on the same parent: whichever of
the two lands second is re-based mechanically (the rename has a replay
script).

## Why

`fallow audit` on Comfy-Org#17798 reported a clone family across the five billing
readers: `credits.ts`, `status.ts`, `capabilities.ts`, `plans.ts` and
`paymentMethods.ts` each re-implemented the same fetch-and-fence shape —
capture the scope, share one request per scope, release a caller on its
own signal, report a late answer (success or failure) as `SUPERSEDED`,
and drop a published snapshot on a denial unless the request predates a
change the host fenced. Five copies of that logic is five places the
Comfy-Org#17828 late-failure fence had to be applied, and the next reader would
have been a sixth.

## How

One skeleton, `createScopedReader`, owns the request sharing, the caller
release, the publish fence and the denial drop. A reader supplies only
its route, decoder (`parse`) and projection into a snapshot, plus two
optional hooks that absorb the real variants: `cached` (capabilities'
freshness window) and `publish` (payment-methods' fenced list,
capabilities' publish-as-stale). `setSnapshot` and `fenceInFlight({
detach })` let each reader assemble its own `invalidate` — capabilities
fences without detaching, payment methods fences and detaches.

The public API of every reader is unchanged in shape and semantics:
`index.ts` is untouched and no consumer in `account-ui`, `billing-web`
or `src/platform/workspace/billing` changed. Per-reader production size:
credits 158→80, status 137→64, plans 163→78, paymentMethods 197→94,
capabilities 317→235 lines.

Tests: the fence family is proven once in `scopedReader.test.ts` with a
five-reader case table (sparse filters for the one reader that paces
itself), and each reader keeps only the tests of its own projection —
capabilities' freshness, denials, revision invalidation and
`resolved_for` checks; payment-methods' three invalidation cases.
Coverage went up: status gained the signed-out-in-flight case, plans and
payment methods gained dispose, all five gained sign-out-then-read.

## AS-IS / TO-BE

No user-facing change; core package internals only.

- AS-IS: five readers, each with its own copy of the scope fence; fallow
reports 2 clone groups / 46 lines across three of them plus 4 groups
spanning all four non-paced readers.
- TO-BE: one skeleton, five thin readers; `fallow audit --changed-since
<parent>` reports duplication 0 and no clone group above the 3-instance
threshold.

## Testing

| Gate | Result |
| --- | --- |
| `packages/account` vitest | 42 files, 659 tests (67 new shared cases
replace 82 per-reader copies) |
| `packages/account-ui` vitest | 9 files, 41 tests |
| `@comfyorg/billing-web` test:unit | 10 files, 90 tests |
| `pnpm typecheck`, `lint`, `format`, `knip` | exit 0 |
| `fallow audit --changed-since
origin/jaewon/fe-2331-plans-payment-methods-readers` | no issues in 13
changed files |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | Comfy-Org#17851 (review, sibling of this PR on Comfy-Org#17798) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | Comfy-Org#17798
(review) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | Comfy-Org#17798 (review) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| Comfy-Org#17798 (review) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827); Comfy-Org#17844 follow-up (review) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | Comfy-Org#17798 (review) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo
(plan-change decision) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |
| follow-up | one scoped-reader skeleton behind the five billing reads
(from the Comfy-Org#17798 fallow report) | FE-2331 | **this PR** |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  FU14["scoped reader skeleton"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  P8RD --> FU14
  FU13 --> FU14
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style FU14 stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 16, 2026
…g#17757)

## Summary

Gives the billing surfaces a required reviewer, so the boundary recorded
in ADR-AUTH-BILLING-0032 has something to resolve against.

## Changes

- **What**: Six `CODEOWNERS` entries covering
`packages/account/src/core/billing/`, `apps/billing-web/`,
`apps/website/src/lib/workshop/`, and the three
`workshop-account`/`balance`/`credits` config modules. Every path was
checked to exist on `main`.

## Review Focus

`CODEOWNERS` currently has no entry for `packages/account/`,
`apps/website/`, or either billing surface. That is why Comfy-Org#17736 has to
describe its own rule 4 as convention rather than a gate: "domain-owner
review" has no owner to route to, and the PR risk workflow is advisory
by construction (`ci-pr-risk.yml` calls itself a shadow check). These
entries are the smallest thing that turns that rule into a real gate.

**This lists the billing half only, on purpose.** The account layer's
session and identity paths — `packages/account/src/core/session.ts`,
`packages/account/src/firebase/`, and whatever else you consider yours —
are deliberately unlisted, because naming an owner for them is not mine
to do. Tell me which paths you want and I will add them here rather than
opening a second PR. Until then a change crossing that side of the
boundary still has no required reviewer, which is worth being explicit
about rather than papering over; the comment in the file says so.

Two things worth checking:

- **Team choice per path.** Billing core and `billing-web` route to
`@Comfy-Org/comfy_frontend_devs`, the Workshop site paths to
`@Comfy-Org/comfy_website_devs`. If the site paths should carry
frontend-devs too, say so.
- **Scope.** `src/platform/workspace/billing/` is not listed because it
does not exist on `main` yet — Comfy-Org#17665 creates it. It should be added
when that lands, not pre-emptively.

Companion to Comfy-Org#17736; neither blocks the other.
dante01yoon added a commit that referenced this pull request Sep 17, 2026
…the SDK rail behind billing_sdk_subscription_enabled (#17853)

Stacked on #17783 (base branch
`jaewon/fe-2210-hosted-destination-port`); merge that first.

Phase 5 slice 1 (#17665) moved top-up onto the Billing SDK behind
`billing_sdk_topup_enabled`. The subscription actions the host already
owns — cancel, resubscribe, and opening the payment portal — still call
the workspace API directly and rely on the legacy poller for settlement
and telemetry. This slice moves those three onto the SDK's commands
behind their own server flag, `billing_sdk_subscription_enabled`
(already on `/api/features` via Comfy-Org/cloud#9248, PostHog at 0%), so
the eight-state lifecycle, idempotency, recovery and telemetry come from
one implementation. Subscribe and plan change are slice 2b, stacked on
this PR.

- **Rail switch.** `billingSdkSubscriptionRailEnabled` =
`billing_sdk_subscription_enabled` AND `unified_cloud_auth`, exactly
like the top-up rail. `useSubscriptionRail()` reads it once,
synchronously, at the start of an action, so a flag flip mid-flow cannot
issue on one rail and observe on the other.
- **Three actions, one adapter.**
`useWorkspaceBilling.cancelSubscription / resubscribe /
manageSubscription` try the rail first; the store runs
`sdk.commands.cancelSubscription()`, `resubscribe()`,
`openPaymentPortal({ returnUrl })` and projects the result onto what the
adapter already does with the legacy calls: settle, or throw a
`WorkspaceApiError` (message is the host's, since the SDK never carries
server text; `serverCode` lands in `.code`). A command that settles in
any phase but `succeeded` is a failure, matching the poller. The refresh
after success mirrors the poller's: cancel → status + balance +
capabilities; resubscribe → `reconcileSubscriptionSuccess` +
capabilities.
- **Fallback.** A 404 (backend gate closed while the client flag is on)
projects to `unavailable`: the adapter runs its legacy body for that
action, and the store latches the route as unavailable for the tab so
later actions go straight to legacy without another failed round trip.
Every other failure — including `SUPERSEDED` — is thrown, never retried
on legacy, so a late or superseded result cannot double-issue.
- **Telemetry.** Lifecycle events are now reported for non-topup
operations (top-up keeps its resumed-only filter because its dialog
reports). `toBillingTelemetryEvent` already emits the poller's payload
shape, so dashboards cannot tell the rails apart.
- **No client-derived server state.** Eligibility and already-held
answers come from the SDK and the server, as for top-up. `subscribe`,
`previewSubscribe`, `useSubscriptionCheckout` and `useLegacyBilling` are
untouched.

| State | AS-IS (flag off) | TO-BE (flag on) |
| --- | --- | --- |
| Cancel dialog at rest | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-dialog.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-dialog.png">
|
| Cancel in flight | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-in-flight.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-in-flight.png">
|
| Cancel settled (success toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-settled.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-settled.png">
|
| Cancel failed (error toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-failed.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-failed.png">
|
| User popover after cancel (cancelled state) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-panel-after-cancel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-panel-after-cancel.png">
|
| Cancel request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-network.png">
|
| Settings billing panel | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-billing-panel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-billing-panel.png">
|
| Resubscribe (Resume Pro) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe.png">
|
| Resubscribe request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe-network.png">
|
| Payment-portal request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-portal-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-portal-network.png">
|

- AS-IS (flag off): cancel / resubscribe / portal POST the workspace API
directly; settlement and telemetry come from the legacy poller.
- TO-BE (flag on): the same dialogs and toasts, the POSTs go through the
SDK transport (`Idempotency-Key` on the request), settlement through the
operation lifecycle; a 404 falls back to the legacy call.

| Gate | Result |
| --- | --- |
| `vitest run src/platform/workspace/billing src/composables/billing
src/platform/workspace/composables src/platform/workspace/stores
src/composables/useFeatureFlags` | 41 files, 1138 tests (12 new
projection tests, 13 new adapter rail tests, +5 store tests) |
| `pnpm typecheck`, `pnpm typecheck:browser`, `lint`, `format:check`,
`knip` | exit 0 |
| `fallow audit --changed-since
origin/jaewon/fe-2210-hosted-destination-port` | no issues in 11 changed
files, complexity 0, duplication 0 |
| Playwright
`browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts` (cloud
project) | **3 passed** against a served cloud dev build —
`PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test
--project=cloud
browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts
--reporter=list`. Flag off → legacy request, flow unchanged; flag on →
SDK request (`Idempotency-Key`), same dialog outcome; flag on + 404 →
legacy fallback. |

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (#17662, #17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | #17783 (review; parent of this PR) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | #17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | #17798
(queued) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | #17798 (queued) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| #17798 (queued) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (#17827); #17844 (queued) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | #17798 (queued) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | **this PR** |
| 5 slice 2b | Subscribe / plan change through the SDK
(`previewSubscribe` quote, then subscribe; the SDK stops
short-circuiting an active plan) | FE-2216 | next, stacked on this PR |
| follow-up | One `needsCustomerAttention` predicate (from the #17665
review) | FE-2216 | merged (#17792) |
| follow-up | Opaque `BillingServerCode` (from the #17656 review) |
FE-2227 | merged (#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799
review) | FE-2215 | merged (#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged
(#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["Phase 5 slice 2a cancel / resubscribe / portal rail"]
  S2B["Phase 5 slice 2b subscribe + plan change"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style S2A stroke:#0366d6,stroke-width:4px
```
dante01yoon added a commit that referenced this pull request Sep 17, 2026
…the SDK rail behind billing_sdk_subscription_enabled (#17853)

Stacked on #17783 (base branch
`jaewon/fe-2210-hosted-destination-port`); merge that first.

Phase 5 slice 1 (#17665) moved top-up onto the Billing SDK behind
`billing_sdk_topup_enabled`. The subscription actions the host already
owns — cancel, resubscribe, and opening the payment portal — still call
the workspace API directly and rely on the legacy poller for settlement
and telemetry. This slice moves those three onto the SDK's commands
behind their own server flag, `billing_sdk_subscription_enabled`
(already on `/api/features` via Comfy-Org/cloud#9248, PostHog at 0%), so
the eight-state lifecycle, idempotency, recovery and telemetry come from
one implementation. Subscribe and plan change are slice 2b, stacked on
this PR.

- **Rail switch.** `billingSdkSubscriptionRailEnabled` =
`billing_sdk_subscription_enabled` AND `unified_cloud_auth`, exactly
like the top-up rail. `useSubscriptionRail()` reads it once,
synchronously, at the start of an action, so a flag flip mid-flow cannot
issue on one rail and observe on the other.
- **Three actions, one adapter.**
`useWorkspaceBilling.cancelSubscription / resubscribe /
manageSubscription` try the rail first; the store runs
`sdk.commands.cancelSubscription()`, `resubscribe()`,
`openPaymentPortal({ returnUrl })` and projects the result onto what the
adapter already does with the legacy calls: settle, or throw a
`WorkspaceApiError` (message is the host's, since the SDK never carries
server text; `serverCode` lands in `.code`). A command that settles in
any phase but `succeeded` is a failure, matching the poller. The refresh
after success mirrors the poller's: cancel → status + balance +
capabilities; resubscribe → `reconcileSubscriptionSuccess` +
capabilities.
- **Fallback.** A 404 (backend gate closed while the client flag is on)
projects to `unavailable`: the adapter runs its legacy body for that
action, and the store latches the route as unavailable for the tab so
later actions go straight to legacy without another failed round trip.
Every other failure — including `SUPERSEDED` — is thrown, never retried
on legacy, so a late or superseded result cannot double-issue.
- **Telemetry.** Lifecycle events are now reported for non-topup
operations (top-up keeps its resumed-only filter because its dialog
reports). `toBillingTelemetryEvent` already emits the poller's payload
shape, so dashboards cannot tell the rails apart.
- **No client-derived server state.** Eligibility and already-held
answers come from the SDK and the server, as for top-up. `subscribe`,
`previewSubscribe`, `useSubscriptionCheckout` and `useLegacyBilling` are
untouched.

| State | AS-IS (flag off) | TO-BE (flag on) |
| --- | --- | --- |
| Cancel dialog at rest | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-dialog.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-dialog.png">
|
| Cancel in flight | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-in-flight.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-in-flight.png">
|
| Cancel settled (success toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-settled.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-settled.png">
|
| Cancel failed (error toast) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-cancel-failed.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-cancel-failed.png">
|
| User popover after cancel (cancelled state) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-panel-after-cancel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-panel-after-cancel.png">
|
| Cancel request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-network.png">
|
| Settings billing panel | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-billing-panel.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-billing-panel.png">
|
| Resubscribe (Resume Pro) | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe.png">
|
| Resubscribe request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-resubscribe-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-resubscribe-network.png">
|
| Payment-portal request recorded | <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/as-is-portal-network.png">
| <img width="480"
src="https://raw.githubusercontent.com/Comfy-Org/ComfyUI_frontend/assets/pr-17853-screenshots/screenshots/to-be-portal-network.png">
|

- AS-IS (flag off): cancel / resubscribe / portal POST the workspace API
directly; settlement and telemetry come from the legacy poller.
- TO-BE (flag on): the same dialogs and toasts, the POSTs go through the
SDK transport (`Idempotency-Key` on the request), settlement through the
operation lifecycle; a 404 falls back to the legacy call.

| Gate | Result |
| --- | --- |
| `vitest run src/platform/workspace/billing src/composables/billing
src/platform/workspace/composables src/platform/workspace/stores
src/composables/useFeatureFlags` | 41 files, 1138 tests (12 new
projection tests, 13 new adapter rail tests, +5 store tests) |
| `pnpm typecheck`, `pnpm typecheck:browser`, `lint`, `format:check`,
`knip` | exit 0 |
| `fallow audit --changed-since
origin/jaewon/fe-2210-hosted-destination-port` | no issues in 11 changed
files, complexity 0, duplication 0 |
| Playwright
`browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts` (cloud
project) | **3 passed** against a served cloud dev build —
`PLAYWRIGHT_TEST_URL=http://localhost:5173 pnpm exec playwright test
--project=cloud
browser_tests/tests/dialogs/cancelSubscriptionSdkRail.spec.ts
--reporter=list`. Flag off → legacy request, flow unchanged; flag on →
SDK request (`Idempotency-Key`), same dialog outcome; flag on + 404 →
legacy fallback. |

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (#17662, #17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | #17783 (review; parent of this PR) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | #17851 (review) |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | #17798
(queued) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | #17798 (queued) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| #17798 (queued) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (#17827); #17844 (queued) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | #17798 (queued) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2a | Cancel, resubscribe and payment portal through the SDK
behind `billing_sdk_subscription_enabled` | FE-2216 | **this PR** |
| 5 slice 2b | Subscribe / plan change through the SDK
(`previewSubscribe` quote, then subscribe; the SDK stops
short-circuiting an active plan) | FE-2216 | next, stacked on this PR |
| follow-up | One `needsCustomerAttention` predicate (from the #17665
review) | FE-2216 | merged (#17792) |
| follow-up | Opaque `BillingServerCode` (from the #17656 review) |
FE-2227 | merged (#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the #17799
review) | FE-2215 | merged (#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the #17798 review) | FE-2331 | merged
(#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2A["Phase 5 slice 2a cancel / resubscribe / portal rail"]
  S2B["Phase 5 slice 2b subscribe + plan change"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2B
  HD --> S2A
  S2A --> S2B
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style S2A stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…unt-core (Comfy-Org#17851)

Stacked on Comfy-Org#17798 (base branch
`jaewon/fe-2331-plans-payment-methods-readers`); merge that first, then
this rebases to `main` with no content change.

## Why

Phase 7 (FE-2218) publishes the framework-free billing core to npm so
Platform can install it from a clean non-workspace checkout, and the
plan fixes the physical `account-core` / `account-ui` split as the
boundary that gets published, not the transitional `packages/account`.
The view package `@comfyorg/account-ui` already exists; the core still
carries the old name. This is the one mechanical rename PR the plan
schedules after Phase 5 slice 1 and before the first publish.

## How

Two commits so the review is trivial:

1. `git mv packages/account packages/account-core` — 95 files, 0
insertions, 0 deletions, every path a 100% rename.
2. The specifier and config edits — package name `@comfyorg/account` →
`@comfyorg/account-core`, every `workspace:*` dependency (root,
`apps/billing-web`, `apps/website`, `packages/account-ui`), every import
specifier under `src/`, `packages/`, `apps/`, `browser_tests/`, the root
`typecheck` / `lint` scripts (`typecheck:account` →
`typecheck:account-core`), `knip.config.ts`, `eslint.config.ts`, the
per-package loop and codecov file list in `ci-tests-unit.yaml`, the
lockfile importer keys, and the two ADRs that name the package in prose.
The delta over a 1:1 swap is oxfmt reflowing import lines the five extra
characters pushed past 80 columns.

Left alone on purpose: the `./vue` entry (the auth Vue pieces move to
`account-ui` in the next PR of this stack), the Firebase app name
`comfy-account` in ADR-0028, and the ADR filenames and headings
(renaming those would break the ADR index and inbound links). `git grep
"@comfyorg/account\b"` and `git grep "packages/account/"` return nothing
after this change.

The replay script lives under `temp/scripts/rename-account-core.sh`
(gitignored); if a sibling PR merges first, re-running it on a fresh
base reproduces this diff.

## AS-IS / TO-BE

No user-facing change; package boundary only.

- AS-IS: `packages/account` publishes as `@comfyorg/account` and is the
name Platform would have to install, while the view layer is already
`@comfyorg/account-ui`.
- TO-BE: `packages/account-core` publishes as `@comfyorg/account-core`;
`account-ui` and `billing-web` depend on it by the final name.

## Testing

| Gate | Result |
| --- | --- |
| `pnpm install --frozen-lockfile` | resolves with the new name |
| `packages/account-core` vitest | 41 files, 674 tests |
| `packages/account-ui` vitest | 9 files, 41 tests |
| `@comfyorg/billing-web` test:unit / build | 10 files, 90 tests / built
|
| `@comfyorg/website` typecheck | 0 errors |
| root `pnpm typecheck`, `lint`, `format`, `knip` | all exit 0 |
| `vitest run src/platform/workspace/billing` | 5 files, 50 tests |
| `pnpm typecheck:browser`, `typecheck:website` (pre-commit) | green |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | **this PR** |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | Comfy-Org#17798
(review) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | Comfy-Org#17798 (review) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| Comfy-Org#17798 (review) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827); Comfy-Org#17844 follow-up (review) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | Comfy-Org#17798 (review) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo
(plan-change decision) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["account-core rename"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style RN stroke:#0366d6,stroke-width:4px
```
pull Bot pushed a commit to Mu-L/ComfyUI_frontend that referenced this pull request Sep 17, 2026
…ling core (Comfy-Org#17854)

Stacked on Comfy-Org#17851 (base branch `jaewon/fe-2218-account-core-rename`),
which stacks on Comfy-Org#17798; merge those first.

## Why

The plan's first decision was that the Vue layer leaves the account
package: composables and unstyled components ship from
`@comfyorg/account-ui`, and the core keeps zero Vue coupling by
construction rather than by an import-guard test. The auth Vue pieces
(`PasswordRules`, `SocialAuthButtons`, `TurnstileWidget`, the region and
Turnstile gates, the lifecycle scope and generation guard) had shipped
in the core's `./vue` entry days before that decision and were
deliberately left for a later follow-up so the fresh auth stack was not
destabilised. With the rename in Comfy-Org#17851 fixing `account-core` as the
boundary that gets published (Phase 7), this is that follow-up: the
published core must not drag `vue`, `@vueuse/core` or a `.vue` entry to
Platform.

## How

- `packages/account-core/src/vue/**` → `packages/account-ui/src/auth/**`
with `git mv` (7 modules + their 7 tests; git records every file as a
rename). The framework-free helpers stay in the core and keep their
public subpaths (`/signInSchemas`, `/turnstileScript`,
`/boundedOperation`); the moved files reach them through those.
- `@comfyorg/account-ui` gains per-module `./auth/*` exports (mirroring
how consumers already import these individually and how the app-side
test mocks target one module each) plus the two workspace deps the moved
files need (`@comfyorg/shared-frontend-utils`,
`@comfyorg/tailwind-utils`; both fine in the view package, neither
allowed in the core).
- The core drops the `./vue/*` exports, `vue`, `@vueuse/core`,
`vue-tsc`, `@vitejs/plugin-vue`, `@testing-library/vue|user-event`,
`@comfyorg/tailwind-utils` and the `peerDependenciesMeta` block;
`typecheck` becomes `tsc --noEmit`; the vitest `account-vue` project
becomes `account-firebase` (happy-dom for `src/firebase/**` only).
- `vueBoundary.test.ts` now proves the boundary three ways: no `vue` /
`@vueuse` import anywhere under `src` (the old `vue/` carve-out is
gone), no Vue dependency in any manifest field, and no `.vue` file
behind any export.
- 17 import sites in 13 files repointed (`apps/billing-web`,
`apps/website`, `src/`); root and `apps/website` gain
`@comfyorg/account-ui: workspace:*`.

A pure `git mv` commit was not possible: the pre-commit hook lints and
type-checks the staged tree, and a rename without repoints leaves 17
unresolved imports. Commit 1 is therefore the rename plus the mechanical
repoints; commit 2 is the boundary guard.

## AS-IS / TO-BE

No user-facing change; package boundary only.

- AS-IS: `@comfyorg/account-core` exports `./vue/*` and depends on
`vue`; a Platform install of the core would pull Vue and `.vue` files.
- TO-BE: `@comfyorg/account-core` has no view entry and no Vue
dependency; the sign-in pieces ship from `@comfyorg/account-ui/auth/*`
next to `./billing`.

## Testing

| Gate | Result |
| --- | --- |
| `packages/account-core` vitest | 34 files, 638 tests |
| `packages/account-ui` vitest | 16 files, 79 tests (7 moved suites) |
| `@comfyorg/billing-web` test:unit / build | 10 files, 90 tests / built
|
| `@comfyorg/website` typecheck | 0 errors |
| root `pnpm typecheck`, `lint`, `format`, `knip` | exit 0 |
| `vitest run src/components/dialog/content/signin src/components/auth
src/platform/workspace/billing` | 11 files, 94 tests |
| `git grep "account-core/vue"` | no matches |

## Where this sits in the plan

Billing SDK track FE-2210 ([implementation plan
V2](https://app.notion.com/p/3d86d73d36508152b92cdbdfdfe83ac8)). Hybrid
model: top-up in-app, subscription management / invoices / payment
methods on the hosted billing app.

| Phase | Item | Ticket | Status |
| --- | --- | --- | --- |
| 1-2 | Session core, transport, readers | FE-2211/2212/2213 | merged |
| 3 | Operation lifecycle, commands, eight-state projection |
FE-2227/2214/2223 | merged (Comfy-Org#17655) |
| 4 | `@comfyorg/account-ui` composables + `CheckoutSteps` | FE-2215 |
merged (Comfy-Org#17662, Comfy-Org#17663) |
| 5 slice 1 | Top-up through the SDK behind `billing_sdk_topup_enabled`
| FE-2216 | merged (Comfy-Org#17665) |
| rollout C | `hosted_billing_destination` server flag read by the host
| FE-2218 | merged (Comfy-Org#17716) |
| rollout C | `hostedDestination` port on the lifecycle, value on
operation state | FE-2210/2218 | Comfy-Org#17783 (review) |
| 7 prep | Scope-source port + credentialed transport (BFF / cookie
hosts) | FE-2218 | merged (Comfy-Org#17782) |
| 7 prep | `@comfyorg/account` → `@comfyorg/account-core` rename |
FE-2218 | Comfy-Org#17851 (review; parent of this PR) |
| 4 follow-up | auth Vue pieces leave the core for
`@comfyorg/account-ui` (`./auth/*`) | FE-2215 | **this PR** |
| 7 prep | `billing-contract` route builder + `return_to` registry |
FE-2218 | merged (Comfy-Org#17795) |
| 3A-3 | Workshop adapter over `createHostedTopupCheckout` | FE-2214 |
merged (Comfy-Org#17793) |
| 8 core | `previewSubscribe` command | FE-2331 | merged (Comfy-Org#17797) |
| 8 core | Plans + saved payment-methods readers | FE-2331 | Comfy-Org#17798
(queued) |
| 8 ui | account-ui composables (`usePlans`, `usePaymentMethods`,
`usePreviewSubscribe`) | FE-2331 | Comfy-Org#17798 (queued) |
| 7 | billing-web own-origin session, sign-in, SDK composition | FE-2218
| Comfy-Org#17798 (queued) |
| 7 | billing-web unit tests in CI (`ci-billing-web-unit.yaml`) |
FE-2218 | merged (Comfy-Org#17827); Comfy-Org#17844 (queued) |
| 7 | ingest CORS + top-up return hosts for billing.comfy.org and its
previews (Comfy-Org/cloud) | FE-2218 | merged (Comfy-Org/cloud#9512) |
| 8 ui | billing-web `/v1` entry routing + subscription / payment-method
surfaces | FE-2331 | Comfy-Org#17798 (queued) |
| 7 | npm publish (`ingest-types`, `account-core`, `billing-contract`),
Platform install, billing-web live top-up | FE-2218 | todo |
| 6 | Contract tests per generated schema (package layer) | FE-2217 |
Comfy-Org#17829 (review) |
| 6 | Live E2E per flow × consumer + evidence table | FE-2217 | todo
(needs staging flags) |
| 5 slice 2 | Subscription flows through the SDK | FE-2216 | todo
(plan-change decision) |
| follow-up | One `needsCustomerAttention` predicate (from the Comfy-Org#17665
review) | FE-2216 | merged (Comfy-Org#17792) |
| follow-up | Opaque `BillingServerCode` (from the Comfy-Org#17656 review) |
FE-2227 | merged (Comfy-Org#17794) |
| follow-up | `useCredits` clears on `SUPERSEDED` (from the Comfy-Org#17799
review) | FE-2215 | merged (Comfy-Org#17824) |
| follow-up | credits / status / capabilities readers fence a late
failure as `SUPERSEDED` (from the Comfy-Org#17798 review) | FE-2331 | merged
(Comfy-Org#17828) |

```mermaid
flowchart LR
  P3["Phase 3 core lifecycle (merged)"]
  P4["Phase 4 account-ui (merged)"]
  P5["Phase 5 slice 1 top-up flag (merged)"]
  FC["PR 17716 hosted_billing_destination flag (merged)"]
  HD["PR 17783 hostedDestination port"]
  SS["PR 17782 scope-source port + credentialed transport"]
  RN["PR 17851 account-core rename"]
  VUE["auth Vue pieces to account-ui"]
  RB["billing-contract route builder + return_to"]
  WS["Workshop adapter"]
  P8PV["previewSubscribe command"]
  P8RD["plans + payment-methods readers"]
  P8["account-ui hosted composables"]
  BWS["billing-web session + sign-in"]
  BWV["billing-web /v1 surfaces"]
  CORS["cloud PR 9512 ingest CORS + return hosts"]
  PUB["npm publish account-core / billing-contract"]
  P7["Phase 7 host proof: Platform + billing-web live"]
  P6C["Phase 6 contract tests"]
  P6["Phase 6 live evidence"]
  S2["Phase 5 slice 2 subscription"]
  FU9["customer-attention predicate"]
  FU11["opaque BillingServerCode"]
  FU12["useCredits clears on SUPERSEDED"]
  FU13["reader late-failure fence"]
  P3 --> HD
  FC --> HD
  HD --> RB
  P3 --> SS
  SS --> P7
  RB --> P7
  P3 --> RN
  RN --> PUB
  RN --> VUE
  RB --> PUB
  PUB --> P7
  P3 --> P8PV
  P3 --> P8RD
  P8PV --> P8
  P8RD --> P8
  P4 --> P8
  P8 --> S2
  P8 --> BWS
  BWS --> BWV
  RB --> BWV
  BWV --> P7
  CORS --> P7
  P5 --> P6
  P3 --> P6C
  P5 --> WS
  P5 --> FU9
  P3 --> FU11
  P4 --> FU12
  P3 --> FU13
  style P3 fill:#d4edda,stroke:#155724
  style P4 fill:#d4edda,stroke:#155724
  style P5 fill:#d4edda,stroke:#155724
  style FC fill:#d4edda,stroke:#155724
  style SS fill:#d4edda,stroke:#155724
  style RB fill:#d4edda,stroke:#155724
  style WS fill:#d4edda,stroke:#155724
  style FU9 fill:#d4edda,stroke:#155724
  style FU11 fill:#d4edda,stroke:#155724
  style FU12 fill:#d4edda,stroke:#155724
  style FU13 fill:#d4edda,stroke:#155724
  style CORS fill:#d4edda,stroke:#155724
  style P8PV fill:#d4edda,stroke:#155724
  style VUE stroke:#0366d6,stroke-width:4px
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-backport Fix/change that needs to be cherry-picked to the current feature freeze branch risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants