Repository navigation
[backport core/1.53] fix(billing): only one subscribe CTA at a time (#16721) - #17707
Conversation
Backport of #16721. Conflict resolution: main rewrote both test files' mocks after this branch was cut (typed `vi.mock(import(...))` specifiers, `vi.mock('pinia')` dropped for the global testing pinia, `useDialogStore` asserted directly). The cherry-pick carried those rewrites in. Kept this branch's existing mock style and layered the PR's additions on top: the reactive `useBillingContext` mock, the `useSubscribeCtaPresence` mock, the presence-registering `SubscribeToRun` stub, and the "one subscribe CTA at a time" cases.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1895 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-15T03:20:01.094Z",
"gitSha": "4735a359fd3423d3ab1f869ddb9a3b68aef9ccb0",
"branch": "backport-16721-to-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2071.7050000000086,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.377999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.458,
"heapDeltaBytes": -1015852,
"heapUsedBytes": 68231892,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.812,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2021.3370000000168,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.858,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 498.15500000000003,
"heapDeltaBytes": -2977144,
"heapUsedBytes": 66800708,
"domNodes": -280,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.9049999999999985,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1954.3390000000045,
"styleRecalcs": 80,
"styleRecalcDurationMs": 45.989000000000004,
"layouts": 14,
"layoutDurationMs": 4.51,
"taskDurationMs": 993.9800000000001,
"heapDeltaBytes": -8610060,
"heapUsedBytes": 61703080,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 174.509,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1838.6649999999918,
"styleRecalcs": 76,
"styleRecalcDurationMs": 39.664,
"layouts": 14,
"layoutDurationMs": 4.341,
"taskDurationMs": 861.088,
"heapDeltaBytes": -7765020,
"heapUsedBytes": 62282432,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 152.92700000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.0459999999903,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.579,
"layouts": 6,
"layoutDurationMs": 1.059,
"taskDurationMs": 396.02900000000005,
"heapDeltaBytes": 4442208,
"heapUsedBytes": 74676564,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.815999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1668.0990000000975,
"styleRecalcs": 31,
"styleRecalcDurationMs": 14.916999999999998,
"layouts": 6,
"layoutDurationMs": 1.0010000000000001,
"taskDurationMs": 336.91900000000004,
"heapDeltaBytes": 4347040,
"heapUsedBytes": 75089228,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.199000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 686.743999999976,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.466,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.09200000000004,
"heapDeltaBytes": -7810356,
"heapUsedBytes": 62803464,
"domNodes": 18,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 164.969,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 649.1659999999229,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.460000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.863,
"heapDeltaBytes": 18156180,
"heapUsedBytes": 87827476,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 161.331,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2031.722000000002,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.256000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.3309999999999,
"heapDeltaBytes": -13449024,
"heapUsedBytes": 87243428,
"domNodes": -270,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 33.386,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2059.466000000043,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.726000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.8040000000001,
"heapDeltaBytes": -13302364,
"heapUsedBytes": 87265456,
"domNodes": -267,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 31.30999999999999,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2380.2390000000173,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.552999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1734.7700000000002,
"heapDeltaBytes": -12062044,
"heapUsedBytes": 89909248,
"domNodes": -273,
"jsHeapTotalBytes": -1130496,
"scriptDurationMs": 866.3199999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2197.0979999999827,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.896000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1601.5420000000001,
"heapDeltaBytes": 23481016,
"heapUsedBytes": 88815184,
"domNodes": -270,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 807.373,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3754.638,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.947,
"layouts": 60,
"layoutDurationMs": 12.827,
"taskDurationMs": 1833.771,
"heapDeltaBytes": 10195864,
"heapUsedBytes": 76624104,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 830.067,
"eventListeners": -151,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3562.426999999957,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.737000000000002,
"layouts": 60,
"layoutDurationMs": 11.555000000000003,
"taskDurationMs": 1671.973,
"heapDeltaBytes": 8107704,
"heapUsedBytes": 75525072,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 782.1740000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3155.6420000000003,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.035999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2014.682,
"heapDeltaBytes": 26589788,
"heapUsedBytes": 93757512,
"domNodes": -11,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 996.573,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3026.6860000000406,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.321999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1898.3759999999997,
"heapDeltaBytes": 21473876,
"heapUsedBytes": 89392056,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 946.943,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2028.031999999996,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.8200000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 665.379,
"heapDeltaBytes": -15358508,
"heapUsedBytes": 87149236,
"domNodes": -270,
"jsHeapTotalBytes": -1617920,
"scriptDurationMs": 36.497,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2054.345000000012,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.4280000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.001,
"heapDeltaBytes": -15210356,
"heapUsedBytes": 87151460,
"domNodes": -273,
"jsHeapTotalBytes": -831488,
"scriptDurationMs": 32.204,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 647.5289999999632,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.189999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.28299999999996,
"heapDeltaBytes": 14720472,
"heapUsedBytes": 87607712,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 150.975,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.3100000000077,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.37,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.87899999999996,
"heapDeltaBytes": 14766616,
"heapUsedBytes": 87156716,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 141.529,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2021.0589999999797,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.578000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.83799999999997,
"heapDeltaBytes": -12000624,
"heapUsedBytes": 60767424,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.486,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 1990.7060000000456,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.208999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.06499999999994,
"heapDeltaBytes": -10565632,
"heapUsedBytes": 61181424,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.252000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1735.7549999999833,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.377,
"layouts": 18,
"layoutDurationMs": 6.031,
"taskDurationMs": 851.3689999999999,
"heapDeltaBytes": -11371936,
"heapUsedBytes": 61331316,
"domNodes": -299,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 116.40500000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.9759999999933,
"styleRecalcs": 78,
"styleRecalcDurationMs": 36.038000000000004,
"layouts": 18,
"layoutDurationMs": 5.159999999999999,
"taskDurationMs": 785.4599999999999,
"heapDeltaBytes": -12538952,
"heapUsedBytes": 60222144,
"domNodes": -297,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 103.886,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1399.3370000000596,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.46399999999999,
"layouts": 14,
"layoutDurationMs": 15.581000000000005,
"taskDurationMs": 914.159,
"heapDeltaBytes": 113468,
"heapUsedBytes": 97326736,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 31.831,
"eventListeners": 2381,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8838.941999999974,
"styleRecalcs": 246,
"styleRecalcDurationMs": 35.211,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6103.294,
"heapDeltaBytes": 19839644,
"heapUsedBytes": 84871564,
"domNodes": -271,
"jsHeapTotalBytes": 454656,
"scriptDurationMs": 2787.782,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8342.990999999984,
"styleRecalcs": 248,
"styleRecalcDurationMs": 33.792,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5697.101,
"heapDeltaBytes": -15886396,
"heapUsedBytes": 84663472,
"domNodes": -268,
"jsHeapTotalBytes": -606208,
"scriptDurationMs": 2679.718,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17748.402999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16992.485,
"heapDeltaBytes": -40605032,
"heapUsedBytes": 169128416,
"domNodes": -6548,
"jsHeapTotalBytes": 991232,
"scriptDurationMs": 312.104,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16538.75800000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15637.587,
"heapDeltaBytes": -35180352,
"heapUsedBytes": 175120700,
"domNodes": -6548,
"jsHeapTotalBytes": 2879488,
"scriptDurationMs": 248.618,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20535.963999999978,
"styleRecalcs": 171,
"styleRecalcDurationMs": 17.403000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20227.835,
"heapDeltaBytes": -17915112,
"heapUsedBytes": 186737212,
"domNodes": -6548,
"jsHeapTotalBytes": 1499136,
"scriptDurationMs": 909.293,
"eventListeners": -7469,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20679.27300000008,
"styleRecalcs": 171,
"styleRecalcDurationMs": 17.715000000000035,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20360.081000000002,
"heapDeltaBytes": -25674568,
"heapUsedBytes": 176575516,
"domNodes": -6552,
"jsHeapTotalBytes": 1822720,
"scriptDurationMs": 926.1990000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6061.883999999964,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.82699999999998,
"layouts": 20,
"layoutDurationMs": 22.691000000000017,
"taskDurationMs": 5958.596,
"heapDeltaBytes": -37294148,
"heapUsedBytes": 172478344,
"domNodes": -6548,
"jsHeapTotalBytes": 880640,
"scriptDurationMs": 131.585,
"eventListeners": -7471,
"totalBlockingTimeMs": 368,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5996.397000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.60300000000004,
"layouts": 20,
"layoutDurationMs": 22.714,
"taskDurationMs": 5856.636,
"heapDeltaBytes": -36531680,
"heapUsedBytes": 172368744,
"domNodes": -6548,
"jsHeapTotalBytes": 3715072,
"scriptDurationMs": 130.56699999999998,
"eventListeners": -7471,
"totalBlockingTimeMs": 309,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 451.13000000003467,
"styleRecalcs": 15,
"styleRecalcDurationMs": 24.730999999999998,
"layouts": 3,
"layoutDurationMs": 1.368,
"taskDurationMs": 112.77400000000002,
"heapDeltaBytes": 5079120,
"heapUsedBytes": 73561244,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.857000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 495.8769999999504,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.178,
"layouts": 3,
"layoutDurationMs": 2.836,
"taskDurationMs": 129.523,
"heapDeltaBytes": 5180968,
"heapUsedBytes": 73470604,
"domNodes": 148,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.382000000000001,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.53 #17707 +/- ##
=============================================
+ Coverage 83.26% 83.35% +0.09%
=============================================
Files 2034 2033 -1
Lines 117458 117542 +84
Branches 32570 32582 +12
=============================================
+ Hits 97796 97972 +176
+ Misses 19306 19216 -90
+ Partials 356 354 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 61 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Were these manually QA tested, and is there any log of that evidence? |
It tested manuallly. You don't have to cut another production release just for this. It's not a critical bug, but nice to get included on next patch/regular release |
|
Holding this backport for 1.55 from main: there is no log of testing beyond unit tests, and the release lines need that evidence. |
christian-byrne
left a comment
There was a problem hiding this comment.
Approving as part of a batch pass over the eight backports that had been sitting unreviewed.
For the "only one subscribe CTA" family (#17707, #17708, #17709, #17710), I compared the payloads across release lines rather than reading each one separately — the useful question for a backport set is whether the four branches are getting the same change, not whether the diff reads well four times.
They are. Diffing the core/1.54 payload against core/1.53 file by file gives zero files with differing line counts: identical file set, identical additions, identical deletions. Same for the cloud siblings, which carry the same +178/−15 across 7 files. So all four release lines receive the same fix and there is no per-branch drift to reason about.
CI green and mergeable on all four.
Backport of #16721 to
core/1.53. The automation could not open this PR — the cherry-pick conflicted (pr-backport.yamlrun 34923077263).Why
A free-tier workspace that cannot run showed two subscribe CTAs at once: "Upgrade" in the top corner and "Subscribe to Run" in the Run slot. The coexistence was deliberate when built, but it reads as a glitch.
Root cause
TopbarSubscribeButtongated only onisCloud && isFreeTier, whileshowsSubscribeToRunPromptisisInitialized && !canRunWorkflows. A free-tier workspace out of quota satisfies both, so both CTAs render.How
TopbarSubscribeButtonnow yields while a Run-slot prompt is actually mounted.SubscribeToRunregisters its presence throughuseSubscribeCtaPresence, so modes without the Run slot — builder, Linear without outputs, sales-managed, payment recovery — keep the Upgrade button and never drop to zero CTAs. The presence counter is read rather than the billing flag, because the flag over-reports:CloudRunButtonWrapperrendersComfyQueueButtoninstead of the prompt for sales-managed and payment-recovery states even while the flag is true.Also folds in the user-popover half:
showSubscribeActionnow requirescanTopUp, so the popover no longer renders "Upgrade to add credits" and "Subscribe" side by side.AS IS / TO BE
Behavioral evidence for the original change is on #16721; this backport is a cherry-pick of that reviewed commit with no production-code changes of its own.
Conflict resolution
Only the two test files conflicted; every production file applied cleanly.
mainrewrote both test files' mocks after this branch was cut — typedvi.mock(import(...))specifiers,vi.mock('pinia')dropped in favour of the global testing pinia, anduseDialogStoreasserted directly instead of through a hoisted stub. The cherry-pick dragged those rewrites onto a branch that does not have them.Resolution keeps this branch's existing mock style and layers only the PR's additions on top: the reactive
useBillingContextmock, theuseSubscribeCtaPresencemock, the presence-registeringSubscribeToRunstub, and the "one subscribe CTA at a time" cases. TheBillingStatustype import anduseDialogStoreassertions were left out — they belong to main-only changes, not to this PR.Verification
CloudRunButtonWrapper.test.ts,TopbarSubscribeButton.test.ts, andCurrentUserPopoverWorkspace.test.tson this branch: 59 tests, all passing.oxlintandoxfmt --checkclean on both resolved files.