Skip to content

[agent-v1 12/18] feat(agent): composer input and attachments - #16213

Closed
CodeJuggernaut wants to merge 16 commits into
nathaniel/agent-v1/11-media-reference-renderersfrom
nathaniel/agent-v1/12-composer-attachments
Closed

CodeJuggernaut wants to merge 16 commits into
nathaniel/agent-v1/11-media-reference-renderersfrom
nathaniel/agent-v1/12-composer-attachments

Conversation

@CodeJuggernaut

@CodeJuggernaut CodeJuggernaut commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Merge after: #16211 (11) - stacked on its branch per the successive-stack chain.
Decisions: Agent V1 Decision Log
Landing strategy: SQUASH-MERGE ONLY - owner order 2026-08-28 (branch-history containment; do not merge-commit).

Summary

Slice 12 of the agent-v1 chain: composer input and attachments - the Composer with its mention picker and workflow-selector chips, attachment handling, the run-mode popover, and the composer store. Census vs merge-base: 23 files, +3958/-659 (22-file cut + one fix-round file).

Changes

  • What: the composer family (Composer pair, WorkflowSelectorChip pair, RunModePopover, attachment surfaces + attachableFiles), agentComposerStore, activeTab at its first-consumer landing, two first-consumer riders (useCanvasSelection pair - imported by Composer; workflowTabActivityStore pair - a dedicated plain-data store the topbar also reads), useAgentSession.test.ts restored to canonical bytes now that its subject's home slice landed, +40 locale keys, and one fix-round file (below).

Review Focus

  • Extraction fidelity: 21 of the 22 cut files hash-exact against the integration snapshot; the one delta is a single disclosed import-line redirect in the restored test (the permanent 07/08 interface inversion). An independent second blind cut converged on the identical core membership (10 of 14 shared files byte-identical) under fully neutral dispatches.
  • The fix-round file, useAgentSessionChainFixes.test.ts (+757): the review panel caught that restoring useAgentSession.test.ts to canonical deleted the chain-authored 08-fix-round regression pins while useAgentSession.ts deliberately keeps those fixes (+75/-35 vs the snapshot). The pins are relocated verbatim (script-assembled from exact line slices with byte-equality assertions) into this sibling file the snapshot does not own, so the canonical file stays byte-exact AND the five otherwise-unpinned paths keep coverage: the 3s prepare-timeout gate, both post-ack warn guards, the resubscribe teardown, module-scope error ids, and the non-404 reset branch. The file's header carries the retirement rule: delete it in the same commit that ever reverts the composable to canonical.
  • Pair suite at this head: 71 passed (71). Full gates: tsc 0, eslint 0, cache-free knip 0, oxfmt clean; the only full-suite fails are counterfactual-proven pre-existing (unrelated shell-script/tour files, identical without this change).
  • Known audit row, inherited and deliberately not fixed here: this slice is where PrimeVue's tooltip directive enters the agent tree (four production v-tooltip sites; the reka-based AgentTooltip in the same component is the repo-idiomaticalternative). Boarded for the post-chain convergence pass, with the test setup correctly load-bearing until then.
  • Draft until the chain's review flow completes.

Linear tickets

Implemented in this slice:

  • FE-1329 - composer max-height (field-sizing-content max-h-100)
  • FE-1325 - composer placeholder hint copy (all three affordances)
  • FE-1323 - video/movie file attach
  • FE-1707 - add-to-prompt menu fits its content (w-max min-w-[186px], 186px floor kept)
  • FE-1309 - explicit Stop button replaces the submitting spinner

Partially touched, not resolved:

  • FE-1674 - this slice carries the video upload byte cap but keeps it at 30MB; the ticket asks for a larger ceiling, so it stays open
  • FE-1651 - duplicate of FE-1674; follows it

Not in this slice:

  • FE-1314 - the drag-from-media-tab path is not here, only the shared attachment destination; tracked by FE-1761
  • FE-1327 - no suggested-prompt border highlight in this cut

Review-audit deltas (salvage matrix): items found during the slicing and review audits that did not make it through the integration merge (#16198).

8 artifacts resolved by this slice (1 high severity):

ID Severity Kind Artifact
8.0 high test useAgentSessionChainFixes.test.ts - 26 chain-authored session regression pins (08-fix1/fix2/fix3 receipts), pl
8.1 medium fix WorkflowSelectorChip keyboard navigation fix + [12-T5] regression test - dropdown navigation keys must escape
8.2 medium fix Removal of the unenforced run-mode control + [12-T7] pin + API-aligned skipped spec suite
8.3 medium guard Composer mention async-state hardening: generation guard on loadMentionAssets, reportError telemetry, mentionA
8.4 medium fix useAttachment: batch staging with concurrent uploads ([12-T4]) and rejected-deferred-resolver guard ([12-T2])
8.5 medium fix Node-selection-mode toast-layer hide rule: .node-selection-active .p-toast { visibility: hidden }
8.6 low fix Enter-as-stop while submitting: isStreaming: () => streaming // submitting
8.7 low fix 200MB client video ceiling/default (MAX_VIDEO_ATTACHMENT_BYTES) + its two unit tests

@coderabbitai

coderabbitai Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 13c22447-8860-4bb7-b0b3-526880ed76d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1890 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1869 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/01/2026, 11:10:27 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 54.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.0 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.0 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 141ms TBT · 98.1 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.5 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 20ms TBT · 176.5 MB heap
vue-node-resize-workload: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 302ms TBT · 171.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.2 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 10ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 559ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 54.4 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 7ms
canvas-mouse-sweep: style recalc duration 44ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 1042ms
canvas-mouse-sweep: script duration 157ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 66.8 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -186
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 30
canvas-zoom-sweep: task duration 393ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.0 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 471ms
dom-widget-clipping: script duration 157ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.1 MB
dom-widget-clipping: DOM nodes 17
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 654ms
large-graph-idle: script duration 33ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.5 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -169
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 63
large-graph-pan: task duration 1644ms
large-graph-pan: script duration 764ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 86.0 MB
large-graph-pan: DOM nodes -139
large-graph-pan: event listeners 5
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1762ms
large-graph-zoom: script duration 753ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.7 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1972ms
legacy-node-drag: script duration 935ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.6 MB
legacy-node-drag: DOM nodes -141
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 638ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.9 MB
minimap-idle: DOM nodes -276
minimap-idle: event listeners -185
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 45
subgraph-dom-widget-clipping: task duration 439ms
subgraph-dom-widget-clipping: script duration 141ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 81.9 MB
subgraph-dom-widget-clipping: DOM nodes 16
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 542ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 66.6 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -215
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 40ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 925ms
subgraph-mouse-sweep: script duration 108ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.4 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -217
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 940ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 141ms
subgraph-transition-enter: heap used 98.1 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6040ms
viewport-pan-sweep: script duration 2598ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.0 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -153
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 15137ms
vue-large-graph-idle: script duration 249ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.5 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7472
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 146
vue-large-graph-pan: task duration 18433ms
vue-large-graph-pan: script duration 866ms
vue-large-graph-pan: TBT 20ms
vue-large-graph-pan: heap used 176.5 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7472
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 74ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5608ms
vue-node-resize-workload: script duration 100ms
vue-node-resize-workload: TBT 302ms
vue-node-resize-workload: heap used 171.8 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 2
workflow-execution: style recalc count 6
workflow-execution: task duration 82ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.2 MB
workflow-execution: DOM nodes 108
workflow-execution: event listeners 49
Raw data
{
  "timestamp": "2026-09-01T11:21:40.753Z",
  "gitSha": "e9c5c5153d0fe889c74d44eef77cb03f2b208285",
  "branch": "nathaniel/agent-v1/12-composer-attachments",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2037.779999999998,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 10.113999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 559.7879999999999,
      "heapDeltaBytes": -12561100,
      "heapUsedBytes": 56645692,
      "domNodes": -279,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.577,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2068.28900000005,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.113999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 557.585,
      "heapDeltaBytes": -11450748,
      "heapUsedBytes": 57471460,
      "domNodes": -282,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 11.073,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2194.2499999999827,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 47.128,
      "layouts": 14,
      "layoutDurationMs": 9.792,
      "taskDurationMs": 1141.122,
      "heapDeltaBytes": -1376192,
      "heapUsedBytes": 68139124,
      "domNodes": -281,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 169.02700000000002,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1890.939000000003,
      "styleRecalcs": 73,
      "styleRecalcDurationMs": 40.669000000000004,
      "layouts": 14,
      "layoutDurationMs": 4.653,
      "taskDurationMs": 943.7070000000001,
      "heapDeltaBytes": 1693564,
      "heapUsedBytes": 71986800,
      "domNodes": -283,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 144.633,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1683.2279999999855,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 18.674000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.436,
      "taskDurationMs": 397.261,
      "heapDeltaBytes": 4414208,
      "heapUsedBytes": 74450328,
      "domNodes": 78,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 12.851999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1683.685999999966,
      "styleRecalcs": 29,
      "styleRecalcDurationMs": 16.668000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.1549999999999998,
      "taskDurationMs": 389.67099999999994,
      "heapDeltaBytes": 4345180,
      "heapUsedBytes": 74381332,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.516,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 721.8629999999848,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.641,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 465.24100000000004,
      "heapDeltaBytes": 18109144,
      "heapUsedBytes": 88063920,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 153.862,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 710.3430000000799,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.048,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.86899999999997,
      "heapDeltaBytes": 18423380,
      "heapUsedBytes": 88390736,
      "domNodes": 16,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 160.50300000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2052.956999999992,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.645999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 675.654,
      "heapDeltaBytes": 11012568,
      "heapUsedBytes": 86367636,
      "domNodes": -269,
      "jsHeapTotalBytes": -2433024,
      "scriptDurationMs": 33.483,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2033.3230000001095,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 6.409999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 632.5540000000001,
      "heapDeltaBytes": -13874976,
      "heapUsedBytes": 86750720,
      "domNodes": -271,
      "jsHeapTotalBytes": -1347584,
      "scriptDurationMs": 32.32599999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2549.5970000000057,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 8.315,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1669.1349999999998,
      "heapDeltaBytes": 25921676,
      "heapUsedBytes": 91897132,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 775.178,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2254.670000000033,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 9.041999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1619.252,
      "heapDeltaBytes": 22577616,
      "heapUsedBytes": 88405216,
      "domNodes": -277,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 752.861,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3643.22199999998,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.363999999999999,
      "layouts": 60,
      "layoutDurationMs": 13.599,
      "taskDurationMs": 1748.703,
      "heapDeltaBytes": 8036444,
      "heapUsedBytes": 75018620,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 748.846,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3751.0389999999916,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.786,
      "layouts": 60,
      "layoutDurationMs": 13.717,
      "taskDurationMs": 1775.0719999999997,
      "heapDeltaBytes": 7721020,
      "heapUsedBytes": 75367280,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 757.4069999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3121.8569999999772,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.196000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1987.315,
      "heapDeltaBytes": 22324300,
      "heapUsedBytes": 90085016,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 943.6750000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3135.94999999998,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.133000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1956.0989999999997,
      "heapDeltaBytes": 22389656,
      "heapUsedBytes": 89479076,
      "domNodes": -281,
      "jsHeapTotalBytes": 679936,
      "scriptDurationMs": 926.123,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2044.179999999983,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.8310000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 638.6100000000001,
      "heapDeltaBytes": 10253408,
      "heapUsedBytes": 87034292,
      "domNodes": -273,
      "jsHeapTotalBytes": -2170880,
      "scriptDurationMs": 30.92199999999999,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2031.9319999999834,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 2.0610000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 637.377,
      "heapDeltaBytes": 9869708,
      "heapUsedBytes": 86769012,
      "domNodes": -279,
      "jsHeapTotalBytes": -1908736,
      "scriptDurationMs": 32.245999999999995,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 657.2509999999738,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 9.802000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 443.404,
      "heapDeltaBytes": 14293412,
      "heapUsedBytes": 86076672,
      "domNodes": 14,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 144.506,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 619.8970000000372,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.439,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.5450000000001,
      "heapDeltaBytes": 13691416,
      "heapUsedBytes": 85744848,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 137.4,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.8240000000046,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.472,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 542.053,
      "heapDeltaBytes": 10869584,
      "heapUsedBytes": 75948440,
      "domNodes": -297,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.752,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2040.4120000000603,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.656999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 542.628,
      "heapDeltaBytes": -8456808,
      "heapUsedBytes": 63794132,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.328999999999997,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1790.3520000000412,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 41.378,
      "layouts": 18,
      "layoutDurationMs": 6.418,
      "taskDurationMs": 939.579,
      "heapDeltaBytes": 3114728,
      "heapUsedBytes": 75495476,
      "domNodes": -298,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 111.08999999999999,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1733.6400000000367,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 37.646,
      "layouts": 18,
      "layoutDurationMs": 5.563999999999999,
      "taskDurationMs": 910.6310000000001,
      "heapDeltaBytes": -12423344,
      "heapUsedBytes": 59589660,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 104.19600000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1383.6159999999609,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 31.118999999999993,
      "layouts": 14,
      "layoutDurationMs": 14.479999999999997,
      "taskDurationMs": 940.018,
      "heapDeltaBytes": 20030928,
      "heapUsedBytes": 102878032,
      "domNodes": 13671,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 29.426999999999996,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8785.153000000037,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 37.833,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6044.03,
      "heapDeltaBytes": 15328364,
      "heapUsedBytes": 89461600,
      "domNodes": -271,
      "jsHeapTotalBytes": -110592,
      "scriptDurationMs": 2592.72,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8483.244000000013,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.918,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6036.849999999999,
      "heapDeltaBytes": -10932060,
      "heapUsedBytes": 88848664,
      "domNodes": -271,
      "jsHeapTotalBytes": -598016,
      "scriptDurationMs": 2603.841,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15740.522999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15124.243,
      "heapDeltaBytes": -33252084,
      "heapUsedBytes": 180244124,
      "domNodes": -6548,
      "jsHeapTotalBytes": -1753088,
      "scriptDurationMs": 243.311,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15893.103999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15149.382,
      "heapDeltaBytes": -22856088,
      "heapUsedBytes": 175138788,
      "domNodes": -6548,
      "jsHeapTotalBytes": 8437760,
      "scriptDurationMs": 254.309,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18710.01000000001,
      "styleRecalcs": 147,
      "styleRecalcDurationMs": 18.47399999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18356.811,
      "heapDeltaBytes": -29239928,
      "heapUsedBytes": 180101736,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5406720,
      "scriptDurationMs": 873.283,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 25,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18818.877000000044,
      "styleRecalcs": 144,
      "styleRecalcDurationMs": 18.867999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18510.140999999996,
      "heapDeltaBytes": -19647236,
      "heapUsedBytes": 189953380,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6217728,
      "scriptDurationMs": 858.611,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 14,
      "frameDurationMs": 18.330000000000048,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5577.289000000008,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.63999999999999,
      "layouts": 20,
      "layoutDurationMs": 23.993000000000002,
      "taskDurationMs": 5519.42,
      "heapDeltaBytes": -34640532,
      "heapUsedBytes": 181145032,
      "domNodes": -6548,
      "jsHeapTotalBytes": 19664896,
      "scriptDurationMs": 99.86600000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 296,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5778.815000000009,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.102,
      "layouts": 20,
      "layoutDurationMs": 24.701999999999988,
      "taskDurationMs": 5697.0419999999995,
      "heapDeltaBytes": -44611536,
      "heapUsedBytes": 179153100,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10125312,
      "scriptDurationMs": 100.61500000000001,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 308,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 122.4610000000439,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 15.683000000000003,
      "layouts": 2,
      "layoutDurationMs": 0.821,
      "taskDurationMs": 81.41400000000002,
      "heapDeltaBytes": 3254952,
      "heapUsedBytes": 71561012,
      "domNodes": 109,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.7829999999999995,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "workflow-execution",
      "durationMs": 120.69599999995262,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 12.698999999999998,
      "layouts": 2,
      "layoutDurationMs": 0.9309999999999999,
      "taskDurationMs": 82.15099999999998,
      "heapDeltaBytes": 3167092,
      "heapUsedBytes": 71439928,
      "domNodes": 106,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.881000000000002,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.669999999999998,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48037 70477 68.2% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.7% 391
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.5% 251
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 29, 2026
@codecov

codecov Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.50649% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/graph/GraphCanvas.vue 61.53% 5 Missing ⚠️
@@                                 Coverage Diff                                 @@
##           nathaniel/agent-v1/11-media-reference-renderers   #16213      +/-   ##
===================================================================================
- Coverage                                            83.28%   83.26%   -0.03%     
===================================================================================
  Files                                                 2025     2024       -1     
  Lines                                               117139   117110      -29     
  Branches                                             33075    33078       +3     
===================================================================================
- Hits                                                 97562    97514      -48     
- Misses                                               19234    19252      +18     
- Partials                                               343      344       +1     
Flag Coverage Δ
e2e 66.65% <39.47%> (-0.04%) ⬇️
unit 76.50% <91.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/toast/GlobalToast.vue 92.30% <100.00%> (-0.55%) ⬇️
src/stores/agentNodeSelectionStore.ts 98.96% <100.00%> (+0.98%) ⬆️
...nch/extensions/agent/components/agent/Composer.vue 99.57% <100.00%> (+0.45%) ⬆️
...components/agent/composer/WorkflowSelectorChip.vue 100.00% <100.00%> (ø)
...xtensions/agent/composables/agent/useAttachment.ts 100.00% <100.00%> (ø)
src/components/graph/GraphCanvas.vue 78.08% <61.53%> (-1.22%) ⬇️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Aug 30, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 3
🟡 Medium 6
🟢 Low 1

Panel: 8/8 reviewers contributed findings.

@christian-byrne

christian-byrne commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Automated fleet review (desktop operator, Christian-authorized)

  • BLOCKED.
  • Slice-local review passes.
  • Chain and CI blocked.
Full context for agent readers

PR #16213 design-review packet — [agent-v1 12/18] feat(agent): composer input and attachments

Lane: pr16213-review (Class A, report-only). Date: 2026-08-29.
Subject: Comfy-Org/ComfyUI_frontend#16213
— OPEN, draft, author CodeJuggernaut, 23 files, +3958/−659.
Head 7a0bb637ec36bf369bd590716ea675b0cb75ed15; base branch nathaniel/agent-v1/11-media-reference-renderers @ 3fc436c09a848bdf543a664cb3d54e31a8f7aa1c (not FE main).
Landing rule stated by the author: squash-merge only, after #16211.

COR-8: reviewed against OUR decisions/ ADRs and plans/technical-design.md only. Nathaniel's
CRDT design docs were not read. The PR body links a Notion decision log — not opened.


1. What the PR actually does

The agent chat composer family, plus two first-consumer riders and one test-restructuring file.
Everything lands under src/workbench/extensions/agent/ except three shared-namespace files.

Surface Files Note
Composer component components/agent/Composer.vue (+585) + test (+697) textarea, @-mention picker (nodes + assets), attachment previews, selection chips, add-menu, send/stop
Composer sub-components composer/{AttachmentChip,RunModePopover,WorkflowSelectorChip}.vue (+56/+201/+238) + 2 tests run-mode popover w/ credit limit; workflow-selector dropdown
Composer logic composables/agent/{useComposer,useAttachment,useCanvasSelection}.ts (+75/+87/+115) + 3 tests draft/attachment state, upload+size-cap, canvas-selection staging
Composer state stores/agent/agentComposerStore.ts (+11) 2 refs: draft, attachments
Types/utils types/activeTab.ts (+6), utils/attachableFiles.ts (+25) + test ActiveTab{path,name,isPersisted?,modified?}; attach allow-list judged by filename extension, not MIME
Shared src/stores/workflowTabActivityStore.ts (+51) + test NEW top-level Pinia store, keyed by tab path
Shared src/composables/useTooltipConfig.ts (+13) appends buildAgentTooltipConfig() (PrimeVue v-tooltip config)
Shared src/locales/en/main.json (+41/−1) ~2.1 KB of agent-only English copy
Test restructuring useAgentSession.test.ts (+18/−658), useAgentSessionChainFixes.test.ts (+757, new) canonical file restored to snapshot bytes; chain-authored regression pins rehomed to a sibling

Imports of CRDT internals: zero. Verified by grepping every added from '…' in the patch:
no yjs, no y-*, no crdt/*, no docFrameClient/followerDoc/opEnvelope/opSender, no
lamport/stamp/seq/state vector symbols anywhere in added lines. The agent extension's
crdt/ tree does exist at this head (22 modules incl. followerDoc.ts, opEnvelope.ts,
mintGate.ts, layoutFollowerBridge.ts) — this PR does not read, write, or reference any of it.
The only transport symbols in the diff (agentRestClient, agentEventSource, agentApiSchema)
appear solely inside the two useAgentSession* test files, inherited unchanged.


2. Alignment with our ADRs

ADR-003 (graph-awareness scope = draft + selection) — ALIGNED, cleanly

useCanvasSelection stages exactly {id, locatorId?, title} per selected node and nothing else.
Viewport, zoom, pan, cursor, and hover — the explicitly excluded set in ADR-003 — are absent from
the composable, from ComposerAttachment, and from every emit. The composer is the FE half of
ADR-003's input #2 (selection ids sent per turn) and does not attempt input #1 (it never scrapes
the live graph to ship a data model, which ADR-003 rejected). It also correctly treats selection as
staged and consumable (consume() returns the tags and clears), i.e. per-turn, not ambient state.

Scalar-v1 vs Lamport stamps (comfy-multi-player main @ 8636af3e, Lamport-merged) — NO CONTACT

This slice has no wire surface. It emits Vue events to its parent; the request/apply path lives in
useAgentSession (slice 07/08) and the crdt/ tree, neither of which it touches. There is no
op envelope, no version field, no base_version, no sequence number in any added line. A rebase
of the CRDT stamp representation cannot break this slice, and this slice cannot bake in a stamp
assumption.
This is the strongest signal in the packet: it is orthogonal, not merely compatible.

ADR-015 (target-graph addressing) — inherited gap, not introduced here

ADR-015: "active-tab identity is presentation state, not a valid address for an agent mutation";
canonical identity is workflow_id. This slice addresses workflows by tab path string
throughout — ActiveTab.path, emit('selectTab', path), and the new workflowTabActivityStore
(editingTabPath, unseenModifiedPaths: Set<string>, pruneClosed(openPaths)). A rename or
save-as silently invalidates those keys, and pruneClosed would then evict the entry as "closed".
ActiveTab.isPersisted?: boolean concedes that unsaved tabs — which have no stable persisted
identity — are in scope.

Mitigating: the chat↔workflow binding itself is owned by agentWorkflowTabBindingStore, which
already exists at this head and is not in this diff. So 16213 consumes a pre-existing addressing
choice rather than making one. plans/technical-design.md §4.1 already records target as absent
from every request. Board it against the ADR-015 target-session registry work; do not bill it to
this PR.

ADR-011 (one branch, distribution-resolved boundaries) — ALIGNED

The new shared store is justified in-file as a boundary, not a leak: "Feature extensions (the agent
panel) write it; the topbar reads it, so the topbar never has to import feature internals."
That is
exactly ADR-011's narrow-seam posture — a plain-data store at the boundary instead of scattered
feature imports. Note the topbar consumer does not exist in this slice; at this head the only
production reader is WorkflowSelectorChip.vue (inside the agent chunk).

ADR-018 (product-flag gating) — not applicable; FE gating verified independently

ADR-018 governs the server-side CRDT WebSocket seam. No FE counterpart is touched here. FE gating
is covered in §3.


3. Risk classing

Shipped surface, but hard-gated. Verified at head 7a0bb637 in
src/workbench/extensions/agent/composables/useAgentDockMount.ts (not in this diff — inherited):

if (__DISTRIBUTION__ !== 'cloud') return { docked: false, DockedAgentPanel: null }
... defineAsyncComponent(() => import('.../DockedAgentPanel.vue'))

Three layers: compile-time __DISTRIBUTION__ DCE (OSS / desktop / localhost builds drop the whole
tree), a runtime PostHog product flag (agentPanelStore.enabled, cf. utils/postHogFlagSource.ts),
and an async chunk that a flag-off cloud session never requests. Feature-gating: present and
adequate. Every component/composable/store in this PR lands behind all three.

Bundle impact: effectively zero for the gated tree. Two ungated deltas:

  • src/locales/en/main.json +41 keys ≈ 2.1 KB raw of agent-only copy shipping to every
    distribution including OSS and desktop (locale JSON is not tree-shaken by key).
  • src/composables/useTooltipConfig.ts +13 lines — one named const arrow export, tree-shakeable,
    unused outside the agent chunk.

Both are immaterial. No new runtime dependency; reka-ui, pinia, @comfyorg/tailwind-utils are
all already in the tree.

Rebase risk onto the integration candidate: low and confined to the three shared files. The
locale JSON (+41 keys in the agent.* block) is the conventional conflict magnet across a
sequential 18-slice chain; useTooltipConfig.ts is a pure append. Every other file is a new path.
No file in this PR overlaps the crdt/ tree, so an integration-candidate rebase touching CRDT wire,
frames, or stamps has zero textual or semantic overlap with this slice.

Code notes worth forwarding (non-blocking; not design-alignment issues)

  1. Object-URL leak on send. useComposer.removeAttachment() revokes blob: preview URLs, but
    submit() clears via attachments.value = [] with no revoke — every image attachment leaks its
    preview blob for the life of the page. One-line fix in submit(). Cloud-gated, images only.
  2. The +757 useAgentSessionChainFixes.test.ts is structural debt by construction. Two test
    files now pin one composable, kept consistent by a comment-header retirement rule ("delete this
    file in the same commit that ever reverts the composable to canonical"). It exists so that
    useAgentSession.test.ts can stay byte-identical to an extraction snapshot — optimizing an
    extraction-fidelity metric at the cost of a hand-maintained invariant. Worth an explicit owner
    decision before the chain lands, since nothing enforces the rule. (I did not byte-verify the
    "verbatim relocation" claim; the PR's own receipts are the only evidence.)
  3. useAttachment keeps let stagedCount = 0 at module scope — monotonic so ids don't collide, but
    it is cross-instance mutable module state. Consistent with the chain's existing pattern; noted
    only for completeness.
  4. attachableFiles.ts classifies by filename extension, deliberately not MIME, and documents why
    (dragged glb/md carry empty MIME). Correct call; the AGENT_ATTACH_ACCEPT list and the
    isAgentAttachable predicate are two hand-synced lists that will drift — cheap to derive one
    from the other.
  5. PrimeVue v-tooltip entering the agent tree (4 production sites) is disclosed in the PR body as
    an inherited, deliberately-unfixed audit row with the reka-based AgentTooltip as the idiomatic
    alternative in the same component. Agreed as boardable, not blocking.

4. Verdict

MERGE-OK-AS-IS — from our design-alignment standpoint

No conflict with any accepted ADR. Zero CRDT surface, zero stamp/wire assumptions, correct
ADR-003 awareness scope, correct ADR-011 boundary shape, and gating that satisfies the shipped-
surface concern on all three layers. The ADR-015 tab-path addressing gap is real but inherited from
an earlier slice and already recorded in plans/technical-design.md §4.1 — it should not gate this
PR. Items 1–2 in §3 are ordinary code-review material for the chain's own reviewer, not design
objections; forward them, do not hold the slice on them.

Merge path: its own packet — does NOT fold into #97

#97 is Comfy-Org/comfy-multi-player. This is an FE-repo agent-chat UI slice with no CRDT or
multiplayer contact whatsoever; it shares no repo, no branch lineage, and no reviewable surface with
that integration candidate. Its path is the Nathaniel FE chain: squash-merge onto
nathaniel/agent-v1/11-media-reference-renderers after #16211, then forward to FE main in
sequence. Folding it into the #97 packet would create a false dependency between an FE UI slice and
the CRDT integration candidate.

Recommendation only — operator files it (R5).


Candidate verified-state.md rows (NOT appended by this lane)

R3/Class-A holds reports/audit/verified-state.md as a shared artifact, and four sibling review
lanes are running concurrently; this lane wrote only its own report. Operator to fold in if wanted:

Fact Verified at (SHA/state) Date (Z) Lane/actor
PR #16213 has zero CRDT/yjs/stamp imports; crdt/ tree present at head but untouched FE 7a0bb637ec36 2026-08-29 pr16213-review
FE agent panel gated 3 ways (__DISTRIBUTION__ !== 'cloud' DCE + PostHog agentPanelStore.enabled + async chunk) in useAgentDockMount.ts FE 7a0bb637ec36 2026-08-29 pr16213-review
PR #16213 ungated bundle delta = 2.1 KB locale copy + 1 tree-shakeable tooltip export FE 7a0bb637ec36 2026-08-29 pr16213-review

Merge-readiness scorecard

Slice 12 merge-readiness scorecard

PR: Comfy-Org/ComfyUI_frontend#16213 — composer input and attachments
Observed: 2026-08-30 at head 7a0bb637ec36bf369bd590716ea675b0cb75ed15
Overall verdict: BLOCKED — slice-local design review is acceptable, but CI is red and slices 03–11 have not landed.
Score: 3.5/7 (PASS or accepted discretion = 1; PARTIAL = 0.5; FAIL/BLOCKED = 0)

03 -> 04 -> 05 -> 06 -> 07 -> 08 -> 09 -> 10 -> 11 -> [12] -> main
                                                      ^
                                        chain tip; last to restack
gate status evidence
Review verdict PASS (1/1) The review packet says MERGE-OK-AS-IS from design alignment. Non-blocking code-review notes remain: revoke image preview object URLs on submit, and get an owner decision on the split useAgentSession* test-maintenance invariant.
Flag-off safety PASS-WITH-DISCRETION (1/1) mr-1 labels pre-gate activity tracking/global tab-store consumption a structural LEAK. Applying issue #149's later user-facing-strict rule, desktop discretion accepts it for this checkpoint: with the panel gated off and activity state empty, no user-visible indicator is established. This is conditional; any visible flag-off dot/status in runtime evidence reopens the gate.
CI on current head FAIL (0/1) Live gh pr checks at 7a0bb637: 90 pass, 11 fail, 21 skip. Red: e2e-status, mobile Chrome, and Chromium shards 2, 3, 4, 6, 7, 8, 10, 14, and 15. The set matches its base lineage, but GitHub remains UNSTABLE, not green.
Conflict with declared base PASS (1/1) GitHub reports MERGEABLE against nathaniel/agent-v1/11-media-reference-renderers@3fc436c0; no current-base merge conflict. mergeStateStatus=UNSTABLE is checks state.
Draft and retarget-to-main readiness BLOCKED (0/1) Still draft. FEH-4 places slice 12 after candidate and every slice 03–11. It is the last of this group to restack and is not ready for direct main retargeting.
Test coverage PARTIAL (0.5/1) Ten changed test files cover composer actions, attachment chips/uploads, selection, workflow selection, activity store, attachability, and rehomed session regressions. Gaps remain in direct coverage for RunModePopover, agentComposerStore, and activeTab; no full browser composer/upload/mention/run-mode journey is proven; current E2E is red.
Open blockers BLOCKED (0/1) Green CI; owner-controlled undraft; bottom-up landing of slices 03–11; rp-1 completion for 03–07; union-preview interaction checks; plus known product gaps in the Linear checkpoint (30 MB video cap remains, media-tab drag and suggested-prompt highlight absent).

Merge decision

No design-alignment change is required before restacking. Hold until the preceding chain lands, then
restack, rerun full CI and real composer/browser coverage, and verify the discretionary flag-off path
has no visible tab indicator.

Provenance and glossary

Sources: live GitHub metadata/checks, internal review packet, mr-1 plus issue #149 ruling, FEH-4,
and the G1 Linear checkpoint. No quarantined Nathaniel design document or Linear narrative was read.

  • Activity seam — the store/watcher boundary carrying agent-related workflow-tab status.
  • Chain tip — the last PR in the currently published 08–12 stack.
  • PASS-WITH-DISCRETION — accepted under issue Convert legacy format node.widget_values #149 only while flag-off behavior is not user-visible.
  • rp-1 — the separate review lane for slices 03–07.

@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/11-media-reference-renderers branch from 3fc436c to 9406898 Compare August 30, 2026 14:55
@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/12-composer-attachments branch from 7a0bb63 to a6ff28b Compare August 30, 2026 14:57
@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/11-media-reference-renderers branch from 9406898 to 7c8e2fb Compare August 30, 2026 17:09
@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/12-composer-attachments branch from a6ff28b to 7156402 Compare August 30, 2026 17:17
@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/11-media-reference-renderers branch from 7c8e2fb to 479e3a7 Compare August 30, 2026 17:45
CodeJuggernaut and others added 5 commits August 30, 2026 17:45
- the composer surface: text entry, node references from canvas
  selection, asset drag-in, attachment chips with upload states
- attachment validation and upload through the shared asset paths
- the workflow selector chip binds a chat to a tab, backed by the
  tab activity store landing with this first consumer
- the run-mode popover writes the persisted run preference
- the agent tooltip builder completes its shared composable
The slice's restore of useAgentSession.test.ts to canonical bytes
deleted the three chain-authored 08-fix describe blocks while
useAgentSession.ts stays deliberately divergent, carrying the 08
fixes those tests pin. Per the round ruling, the pins move VERBATIM
(from 3fc436c) into useAgentSessionChainFixes.test.ts: the three
describes, the Set-based fakeEvents double with its
subscription-semantics comment, resetHarness, and the helpers they
depend on. The canonical test file is untouched. The header states
provenance and the retirement rule: delete this file in the same
commit that ever reverts useAgentSession.ts to canonical.

Receipts: without this file, greps for the five re-covered paths'
markers (sendFailed handling, the persist-failure warn, double-start
ingestion, the prepare timeout gate, the remount id-mint pin by its
test name) hit zero test files; with it they restore, and the pins
run green against the divergent composable.
@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR and removed cursor-review Trigger multi-model Cursor agent review on this PR labels Aug 31, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor

Superseded — closing per Christian's direction.

Full context for agent readers

Program pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

⚠️ The judge step did not submit a final review through its structured-output tool (status=error). The findings below are the raw, un-adjudicated panel output — they may contain duplicates or false positives the judge would normally filter.

Round 2 — ledger: 10 prior finding(s) across 1 round(s) (10 never answered).

Found 26 finding(s).

Severity Count
🟠 High 9
🟡 Medium 15
🟢 Low 1
⚪ Nit 1

Panel: 5/8 reviewers contributed findings.

Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gpt-5.6-sol-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error)


The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:

src/workbench/extensions/agent/components/agent/message/ReplyAssetGroup.vue:96 — 🟠 High — LLM-generated reply markdown supplies asset URLs; for 3D assets this calls generateModelThumbnail(url), which fetches and parses the URL with three.js's GLTF loader with no origin or content validation. A prompt-injected or hostile model URL is fetched and parsed by a native binary parser without any user interaction, exposing a drive-by parser attack surface.

src/workbench/extensions/agent/crdt/layoutFollowerBridge.ts:227 — 🟠 High — After an old lineage reaches (for example) seq 42, a dropped doc_reset followed by the new lineage's seq 1 update does not satisfy this forward-gap check and is applied as if stale/duplicate. Yjs then merges two unrelated histories, so old-only structs can survive instead of the new lineage replacing them.

src/workbench/extensions/agent/crdt/layoutFollowerBridge.ts:188 — 🟠 High — sendHumanOps discards the false result from a closed transport (and silently returns when no subscribe has landed), while the composable exposes this method as its human-write API. A valid local edit made during reconnect is therefore neither queued nor reported and is permanently lost.

src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts:193 — 🟠 High — Inbound frames are correlated to the bound workflow, but their mutation target is always the current app.graph with no workflow-identity check. If the agent continues on workflow A while the user views B, an A update writes its nodes and links directly into B.

src/workbench/extensions/agent/crdt/litegraphMutator.ts:44 — 🟠 High — A missing canvas is returned from as a successful batch, so SemanticProjector advances its snapshot even though nothing was applied. An update arriving while the graph is unloaded/offscreen will not be materialized on later activation, because subsequent diffs start from the already-advanced snapshot.

src/workbench/extensions/agent/crdt/litegraphMutator.ts:47 — 🟠 High — The batch mutates LiteGraph item-by-item with no rollback. If a custom-node callback throws on a later mutation, earlier mutations remain while the projector keeps its pre-batch snapshot; the next projection replays them and can duplicate/remint an already-added node.

src/workbench/extensions/agent/crdt/litegraphMutator.ts:94 — 🟠 High — origin.connect always mints a fresh local link ID and the CRDT's mutation.link.id is ignored. After remote link 41 is rendered as local link X, a local node deletion reports removed_links: [X], so the host's link 41 is not correlated or removed and local serialization also carries the wrong identity.

src/workbench/extensions/agent/crdt/linkMintPort.ts:110 — 🟠 High — This only verifies that a link is in the root of its own scope; it never checks that scope.rootGraphId is the graph belonging to the bound document. A root-link mutation in offscreen workflow B while A is bound therefore passes the gate and enqueues B's connect operation to A.

src/workbench/extensions/agent/crdt/diffSnapshots.ts:60 — 🟠 High — Replacement is detected only when the node type changes, and NodeSpec does not retain node_incarnation. A host batch that deletes and re-adds the same ID and type before one doc_update therefore produces no remove/add (or only field deltas), leaving the prior LiteGraph instance and its stale extension-owned state as the new occupant.

src/workbench/extensions/agent/composables/agent/useAgentSession.ts:295 — 🟡 Medium — When the user clicks Stop while the turn POST is pending and the ack arrives after a thread switch, the turn is backgrounded via startBackgroundTurn and the function returns before the stopRequestedWhileSending check below. The flag is reset at the start of the next sendMessage without ever being honored, so the user's stop intent is silently dropped and the backgrounded turn runs to completion.

src/platform/workflow/core/services/workflowService.ts:90 — 🟡 Medium — queueWorkflowLoad chains every workflow load onto workflowLoadTail with no timeout or abandonment path. If a load() promise (workflow.load() or app.loadGraphData) never settles, every subsequent workflow open and close is blocked indefinitely — a single hung load deadlocks all workflow management in the UI.

src/components/toast/GlobalToast.vue:73 — 🟡 Medium — When selection mode defers a toast into deferredMessages, a later messagesToRemove request for that toast calls toast.remove() on a message that was never added — a no-op — and the deferred copy is never dropped. On exit the stale toast is added and remains visible indefinitely (e.g. a progress toast that was already completed).

src/platform/workflow/templates/composables/useTemplateWorkflows.ts:159 — 🟡 Medium — fetchTemplateJson no longer checks response.ok before response.json(). A non-2xx response (e.g. 404 from an install pinning an older template package) returns an HTML error page that fails JSON.parse with an opaque error instead of surfacing the HTTP status, regressing the error handling the removed check provided.

src/workbench/extensions/agent/crdt/opEnvelope.ts:47 — 🟡 Medium — The envelope only shallow-copies the operation, leaving nested node/widget payloads shared with caller state; retries serialize this object again later. Mutating an array/object widget value between the first send and timeout resends different bytes under the same op_id, which the host rejects as changed-payload reuse.

src/workbench/extensions/agent/crdt/linkMintPort.ts:153 — 🟡 Medium — Severances are keyed only by graph-local node ID (and consumed link IDs are likewise unscoped). If two loaded graphs contain node 2, a link deletion in B followed in the same delivery window by deleting node 2 in A can attach B's link ID to A's delete_node and suppress B's divergence signal.

src/workbench/extensions/agent/crdt/mintPortWiring.ts:179 — 🟡 Medium — The action bridge observes only register/replace/delete and ignores successful updateEndpoint/updateEndpoints actions, even though production link setters and input-slot reordering use those actions. Such a valid endpoint or slot change updates the local topology but emits no connect op, leaving the shared document silently stale.

src/workbench/extensions/agent/crdt/litegraphMutator.ts:116 — 🟡 Medium — readDocSnapshot represents valid opaque positional widgets with keys such as "0" and "1", but this code resolves every key as a widget name. A custom node with __widgets_opaque therefore applies none of its values, yet the projector commits the snapshot and never retries them.

src/workbench/extensions/agent/composables/agent/useAgentSession.ts:264 — 🟡 Medium — When workflow.prepare() resolves after the user switched threads (or a loadThread bumped loadGeneration), the post-ack guard returns false without recording the send anywhere: no user entry, no error notice, and the composer's draft was already cleared by useComposer.submit(). The user's message silently vanishes with no signal that it was never sent.

src/workbench/extensions/agent/composables/agent/useAgentSession.ts:302 — 🟡 Medium — The backgrounded-ack path (startBackgroundTurn + return true) skips storageSet(ack.thread_id), so a send that lands while its target thread is being switched away is never persisted to localStorage. On the next reload the resumed-thread pointer is stale and the accepted turn's thread is not restored.

src/workbench/extensions/agent/composables/agent/useAgentSession.ts:322 — 🟡 Medium — stopRequestedWhileSending is cleared at the top of sendMessage (stopRequestedWhileSending = false before the prepare gate) but only consumed after a successful ack. If the user hits Stop during a send that then fails (or is dropped by the generation guard), the flag stays set; the next successful send's ack triggers stopTurn() on the new turn, cancelling a turn the user never asked to stop.

src/workbench/extensions/agent/composables/agent/useAgentSession.ts:447 — 🟡 Medium — onStatus(false) drops all background turns (dropBackgroundTurns), but onStatus(true) is a no-op (if (live) return). After a transient disconnect, turns that were streaming in background threads are permanently settled with partial content and never resumed or refetched when the socket comes back — the reconnect handler does nothing to recover them.

src/components/toast/GlobalToast.vue:73 — 🟡 Medium — The messagesToRemove watcher calls toast.remove(message) but never checks deferredMessages: a message that was deferred (because node-selection mode was active when it was added) and then explicitly removed before the mode exits is still flushed by the isActive watcher, so a toast the store asked to remove pops up anyway.

build/plugins/gcsRedirect.ts:51 — 🟢 Low — The dev-server fetch of the GCS redirect location has no timeout or abort. A hung GCS connection (or slow intermediate) keeps the dev server's upstream connection open indefinitely, so sustained media requests can exhaust dev-server sockets.

src/workbench/extensions/agent/components/agent/message/ReplyAssetGroup.vue:154 — ⚪ Nit — refreshModelThumbnail schedules a setTimeout retry without checking the mounted flag that the watch-based loaders use, so after the component unmounts the retry still fires findServerPreviewUrl and writes into modelThumbnails.value on a dead component.

isActive.value = false
const canvas = canvasStore.canvas
if (!canvas) return
canvas.allow_dragnodes = restoreAllowDragNodes ?? true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — exit() restores canvas interaction flags with restoreAllowDragNodes ?? true (and similar defaults) when enter() captured nothing because no canvas existed at entry. If a canvas appears while selection mode is active, exit() clobbers its real configuration (e.g. allow_dragnodes=false) with these defaults.

options.maxBytes?.(file) ??
Math.min(
serverLimit,
hasVideoType(file) ? MAX_VIDEO_ATTACHMENT_BYTES : MAX_ATTACHMENT_BYTES

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — isTooLarge computes Math.min(serverLimit, hasVideoType(file) ? MAX_VIDEO_ATTACHMENT_BYTES : MAX_ATTACHMENT_BYTES), so a non-video file is always capped at 20MB even when the server advertises a higher max_upload_size (e.g. 100MB). A 30MB .glb/.md asset that the backend would accept is rejected client-side with a misleading "larger than 20MB" error.

…rence-renderers' into hub-12-cascade

# Conflicts:
#	src/components/graph/GraphCanvas.vue
#	src/components/graph/NodeSelectionModeBanner.test.ts
#	src/components/toast/GlobalToast.vue
#	src/locales/en/main.json
#	src/stores/agentNodeSelectionStore.test.ts
#	src/stores/agentNodeSelectionStore.ts
#	src/workbench/extensions/agent/components/agent/Composer.test.ts
#	src/workbench/extensions/agent/components/agent/Composer.vue
#	src/workbench/extensions/agent/components/agent/composer/WorkflowSelectorChip.test.ts
#	src/workbench/extensions/agent/components/agent/composer/WorkflowSelectorChip.vue
#	src/workbench/extensions/agent/composables/agent/useAttachment.test.ts
#	src/workbench/extensions/agent/composables/agent/useAttachment.ts
Entering the node-selection store from the composer flipped isActive
before AgentPanelRoot merged its mention references with the canvas
selection, so the sync selection watch replaced the staged tags with the
bare canvas selection and the references were dropped on mode entry.
The panel already enters the mode itself after its merge; the composer
only emits selectNodes again.
@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR and removed cursor-review Trigger multi-model Cursor agent review on this PR labels Sep 2, 2026
@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Round 3 — ledger: 12 prior finding(s) across 2 round(s) (12 never answered).

Found 4 finding(s).

Severity Count
🔴 Critical 1
🟠 High 1
🟡 Medium 1
🟢 Low 1

Panel: 2/8 reviewers contributed findings.

Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gemini-3.1-pro:adversarial (error), gpt-5.6-sol-max:adversarial (error), kimi-k3-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gpt-5.6-sol-max:edge-case (error)

*/
function frameForPicking(): void {
if (isActive.value) return
const canvas = canvasStore.canvas

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 Critical — enter() snapshots allow_dragnodes/multi_select/selectOnly here, but AgentPanelRoot.onSelectNodes() already sets all three to their picking values before it calls enter(), so the snapshot captures the locked state rather than the user's configuration. Every path that leaves picking via exitNodeSelectionMode() (send, close panel, new chat, attach, unmount) restores the panel's own pre-mutation values first and then calls store.exit(), which re-applies selectOnly=true/allow_dragnodes=false and leaves the canvas read-only until reload. Give the flags a single owner: capture in enter() before the panel mutates them, or drop the panel's copy now that the store manages them. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

restoreMultiSelect = canvas.multi_select
restoreSelectOnly = canvas.selectOnly
canvas.allow_dragnodes = false
canvas.multi_select = true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — fitViewToSelectionAnimated() throws when bounds cannot be computed — an empty graph with nothing selected, which is exactly the state of a freshly minted agent workflow tab. The throw escapes before isActive.value = true on line 90, so the mode never activates (no banner, and the Escape handler short-circuits on !isActive) even though allow_dragnodes/selectOnly were already flipped two lines earlier. Guard the call so a bounds-less graph still enters the mode. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

const canvas = canvasStore.canvas
if (!canvas?.selectedItems.size) return
if (!canvas) return
canvas.allow_dragnodes = restoreAllowDragNodes ?? true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — exit() writes restoreAllowDragNodes ?? true / restoreMultiSelect ?? false / restoreSelectOnly ?? false, but enter() only captures those flags when a canvas exists at entry, so a canvas that appears while the mode is active has hard-coded defaults stamped over its real configuration (e.g. re-enabling dragging on a canvas that had it disabled). The if (!canvas) return on line 97 also skips the three resets below it, so a previous session's captures stay live and get applied to a different canvas on a later exit. Round 2 raised this and it was never answered. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

Comment thread src/assets/css/style.css
pointer-events: auto;
}

.node-selection-active .p-toast {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — This hides the entire toast layer, but GlobalToast only defers messages published after the mode becomes active, so a toast already on screen keeps running its PrimeVue life timer while invisible and expires unseen. Sticky (life-less) errors survive the hide, so the gap is limited to timed messages raised just before entry — worth a moment's thought about whether any of those matter. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

@christian-byrne

Copy link
Copy Markdown
Contributor

This slice is reference-only. Accepted work is routed to #16385 and #16406.

Full context for agent readers

Per Christian's main-target close ruling, #16213 (12 — composer and attachments) is no longer a landing vehicle. It remains readable implementation and review provenance. Composer behavior and permanent-test responsibilities are separated. If a genuinely unaccounted delta is found, reopen this source or file a bounded main-based carrier rather than reviving the stacked merge path.

Decision record.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-attachments Agent asset uploads, attachments or media references agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-attachments Agent asset uploads, attachments or media references agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants