Skip to content

[agent-v1 11/18] feat(agent): message composites and media rendering - #16211

Closed
CodeJuggernaut wants to merge 12 commits into
nathaniel/agent-v1/10-message-renderersfrom
nathaniel/agent-v1/11-media-reference-renderers
Closed

CodeJuggernaut wants to merge 12 commits into
nathaniel/agent-v1/10-message-renderersfrom
nathaniel/agent-v1/11-media-reference-renderers

Conversation

@CodeJuggernaut

@CodeJuggernaut CodeJuggernaut commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Merge after: #16210 (10) - stacked on its branch per the successive-stack chain.
Decisions: Agent V1 Decision Log
Landing strategy: SQUASH-MERGE ONLY - owner order 2026-08-28 (branch-history containment; do not merge-commit).

Summary

Slice 11 of the agent-v1 chain: the message composites and media/reference rendering - AgentMessage, UserMessage, MarkdownStream, MessageFeedback, ReplyAssetGroup with audio/3D asset handling, TabLinkCard, and the agent styling substrate. Census vs merge-base: 29 files, +3139/-8.

Changes

  • What: the composite message renderers and their suites (AgentMessage, UserMessage, MarkdownStream, MessageFeedback, ReplyAudioCard, ReplyAssetGroup, TabLinkCard), the reply-asset utilities (replyAssets pair, downloadReplyAsset), the workflow-tab binding store pair, modelThumbnail (lazy 3D thumbnail capture, first consumer lands here), AgentTooltip + four tooltip consts, agent CSS (theme + panel sheets), 9 locale keys, and the knip transitional entry retired as its exports gain in-slice consumers.

Review Focus

  • Extraction fidelity: 25 of 29 files hash-exact against the integration snapshot; the 4 that differ are exactly the disclosed shared-file hunks (locale +9 keys, knip retirement, one style.css import line, four tooltip consts). ToolCallGroup.test.ts is restored to canonical bytes - the describe block slice 10's cut deferred returns verbatim now that AgentMessage exists.
  • Dual independent cuts converged on an identical 25-file content membership (17 byte-identical), including a file outside the message/ directory that neither cut's planning census had listed - both derived it from the snapshot tree directly.
  • CSS staging, stated plainly: agentTheme.css is wired via the style.css import (the agent-* utilities are live). agentPanel.css lands hash-exact and INERT - nothing mounts these components until the panel-root slice (ConversationView, the only renderer of AgentMessage, is not in the chain yet), so the sheet ships with the consumers it styles; the panel-root slice brings its canonical import './agentPanel.css' and makes it live, with a computed-style shimmer check in that slice's acceptance. This description supersedes the commit body's wiring bullet, which overstates ("wired through the global style import" holds only for the theme sheet).
  • Review panel returned Ship it from both reviewers with zero fix rounds. Non-blocking findings are deferred with named owners rather than fixed here (files are extraction-fenced): a subpath-deployment edge in the asset-download URL recovery, a retry timeout without unmount teardown, missing aria-expanded on the Show more/less toggles, and no-test debt on AgentTooltip and downloadReplyAsset - all inherited from the snapshot and boarded for the post-chain fix round.
  • The single v-html sits behind DOMPurify; object-URL handling revokes on microtask and is assert-covered; TabLinkCard navigates through the existing workflowService only.
  • Draft until the chain's review flow completes.

Linear tickets

  • FE-1310 - render in-line tab links
  • FE-1326 - render asset previews + inspect view
  • FE-1328 - asset URL + hyperlink in chat (the panel-shell half lands in 14)

Review-audit deltas (salvage matrix): items found during the slicing and review audits that did not make it through the integration merge (#16198).

No missing-artifact rows in this territory; the diff is the reviewed media/reference renderer delta, plus the cross-origin download pin and shimmer fix (CI-verified).

@github-actions

github-actions Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/01/2026, 11:10:13 AM UTC

Links

🎭 Playwright: ✅ 1890 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1869 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.7 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 129ms TBT · 83.8 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.1 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.7 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 149ms TBT · 168.2 MB heap
vue-node-resize-workload: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 478ms TBT · 171.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 513ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 64.8 MB
canvas-idle: DOM nodes -283
canvas-idle: event listeners -185
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 47ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 995ms
canvas-mouse-sweep: script duration 160ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 69.4 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -157
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 370ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.7 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 441ms
dom-widget-clipping: script duration 153ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 81.2 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 4
large-graph-idle: task duration 658ms
large-graph-idle: script duration 39ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.9 MB
large-graph-idle: DOM nodes -271
large-graph-idle: event listeners -169
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1567ms
large-graph-pan: script duration 743ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.4 MB
large-graph-pan: DOM nodes -138
large-graph-pan: event listeners -75
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1798ms
large-graph-zoom: script duration 790ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.8 MB
large-graph-zoom: DOM nodes -139
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1990ms
legacy-node-drag: script duration 956ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.6 MB
legacy-node-drag: DOM nodes -6
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 591ms
minimap-idle: script duration 38ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.9 MB
minimap-idle: DOM nodes -139
minimap-idle: event listeners 4
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 409ms
subgraph-dom-widget-clipping: script duration 141ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 81.9 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 524ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 58.7 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -201
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 41ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 857ms
subgraph-mouse-sweep: script duration 112ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 56.9 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 956ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 129ms
subgraph-transition-enter: heap used 83.8 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 41ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 5766ms
viewport-pan-sweep: script duration 2543ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 81.1 MB
viewport-pan-sweep: DOM nodes -269
viewport-pan-sweep: event listeners -139
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17787ms
vue-large-graph-idle: script duration 304ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.7 MB
vue-large-graph-idle: DOM nodes -6550
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 22ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 164
vue-large-graph-pan: task duration 21919ms
vue-large-graph-pan: script duration 895ms
vue-large-graph-pan: TBT 149ms
vue-large-graph-pan: heap used 168.2 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 74ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6468ms
vue-node-resize-workload: script duration 119ms
vue-node-resize-workload: TBT 478ms
vue-node-resize-workload: heap used 171.0 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7468
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 22ms
workflow-execution: layout count 3
workflow-execution: style recalc count 13
workflow-execution: task duration 102ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.6 MB
workflow-execution: DOM nodes 140
workflow-execution: event listeners 62
Raw data
{
  "timestamp": "2026-09-01T11:22:23.532Z",
  "gitSha": "df9324d69b6dd6a53a318507f4bb69a046a90be2",
  "branch": "nathaniel/agent-v1/11-media-reference-renderers",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2051.6170000000216,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.696,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 514.737,
      "heapDeltaBytes": 7609120,
      "heapUsedBytes": 71182948,
      "domNodes": -281,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.885000000000002,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2056.878999999981,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.723999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 511.96299999999997,
      "heapDeltaBytes": 1399036,
      "heapUsedBytes": 64810944,
      "domNodes": -284,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 9.783,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2050.6540000000086,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 51.46500000000001,
      "layouts": 14,
      "layoutDurationMs": 5.111,
      "taskDurationMs": 1076.961,
      "heapDeltaBytes": -8309356,
      "heapUsedBytes": 61869312,
      "domNodes": -281,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 174.27800000000002,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1872.2380000000385,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 42.965999999999994,
      "layouts": 14,
      "layoutDurationMs": 4.743,
      "taskDurationMs": 912.99,
      "heapDeltaBytes": 13836504,
      "heapUsedBytes": 83600232,
      "domNodes": -279,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 145.24800000000002,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.0980000000459,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.205,
      "layouts": 6,
      "layoutDurationMs": 1.3410000000000002,
      "taskDurationMs": 364.88800000000003,
      "heapDeltaBytes": 4451204,
      "heapUsedBytes": 74637492,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 12.020000000000003,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.7159999999067,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.073999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.2069999999999999,
      "taskDurationMs": 375.298,
      "heapDeltaBytes": 4382308,
      "heapUsedBytes": 73734872,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 13.011999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 705.3180000000339,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.6320000000000014,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 442.492,
      "heapDeltaBytes": 18414856,
      "heapUsedBytes": 82282864,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 153.961,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 683.6729999999989,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.599,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 438.89,
      "heapDeltaBytes": 18106112,
      "heapUsedBytes": 88063384,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 151.138,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2032.2909999999865,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 3.039,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 673.077,
      "heapDeltaBytes": 11078064,
      "heapUsedBytes": 86862424,
      "domNodes": -273,
      "jsHeapTotalBytes": -1646592,
      "scriptDurationMs": 36.586,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2068.4139999999616,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 7.823,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 643.099,
      "heapDeltaBytes": -13182240,
      "heapUsedBytes": 87062240,
      "domNodes": -268,
      "jsHeapTotalBytes": -1609728,
      "scriptDurationMs": 40.804,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2216.3659999999936,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 9.147000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1561.912,
      "heapDeltaBytes": 22123512,
      "heapUsedBytes": 88102296,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 746.9100000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2150.8780000000343,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 12.067000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1571.9990000000003,
      "heapDeltaBytes": 19023296,
      "heapUsedBytes": 84669392,
      "domNodes": -275,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 739.694,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3629.465000000039,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.539999999999997,
      "layouts": 60,
      "layoutDurationMs": 13.802,
      "taskDurationMs": 1754.1190000000001,
      "heapDeltaBytes": 9562724,
      "heapUsedBytes": 76570256,
      "domNodes": -279,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 768.9359999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3643.063999999981,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 13.179999999999998,
      "layouts": 60,
      "layoutDurationMs": 14.295,
      "taskDurationMs": 1841.271,
      "heapDeltaBytes": 8454308,
      "heapUsedBytes": 76031816,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 810.121,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3179.1620000000194,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.563999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2038.6350000000002,
      "heapDeltaBytes": 19702740,
      "heapUsedBytes": 86818944,
      "domNodes": -11,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 987.882,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3099.0840000000617,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.890999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1941.803,
      "heapDeltaBytes": 17429268,
      "heapUsedBytes": 84254384,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 924.3750000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 1999.430000000018,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.505999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 565.9499999999999,
      "heapDeltaBytes": 21575364,
      "heapUsedBytes": 87332916,
      "domNodes": -3,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 37.84,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2006.8989999999758,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.9030000000000018,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 616.313,
      "heapDeltaBytes": 22413816,
      "heapUsedBytes": 88561892,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 38.349999999999994,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 613.0380000000173,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.588999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 413.11199999999997,
      "heapDeltaBytes": 14206728,
      "heapUsedBytes": 86217328,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 141.773,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 587.3060000000123,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.343000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 404.719,
      "heapDeltaBytes": 13687468,
      "heapUsedBytes": 85614172,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 140.688,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.555999999985,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.866,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 540.191,
      "heapDeltaBytes": -10691984,
      "heapUsedBytes": 61699204,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.197999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2032.4789999999666,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.021,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.76500000000004,
      "heapDeltaBytes": -10689896,
      "heapUsedBytes": 61309856,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 10.450999999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1722.438000000011,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 43.683,
      "layouts": 18,
      "layoutDurationMs": 5.9639999999999995,
      "taskDurationMs": 872.104,
      "heapDeltaBytes": -12970968,
      "heapUsedBytes": 58994972,
      "domNodes": -295,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 114.77099999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1734.4560000000229,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 38.913999999999994,
      "layouts": 18,
      "layoutDurationMs": 5.638,
      "taskDurationMs": 841.1719999999999,
      "heapDeltaBytes": -11569824,
      "heapUsedBytes": 60319560,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 110.146,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1383.7879999999814,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 32.70100000000001,
      "layouts": 15,
      "layoutDurationMs": 14.395000000000001,
      "taskDurationMs": 955.599,
      "heapDeltaBytes": -7290576,
      "heapUsedBytes": 87832288,
      "domNodes": 13671,
      "jsHeapTotalBytes": 11272192,
      "scriptDurationMs": 29.918000000000006,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 129,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8447.32399999998,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 41.78900000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5811.659,
      "heapDeltaBytes": -19511144,
      "heapUsedBytes": 80775600,
      "domNodes": -270,
      "jsHeapTotalBytes": -1384448,
      "scriptDurationMs": 2552.028,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8464.97099999999,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 40.339,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5720.511,
      "heapDeltaBytes": -11301280,
      "heapUsedBytes": 89207756,
      "domNodes": -268,
      "jsHeapTotalBytes": -1908736,
      "scriptDurationMs": 2534.709,
      "eventListeners": -139,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18298.54899999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17753.346999999998,
      "heapDeltaBytes": -32835408,
      "heapUsedBytes": 176501384,
      "domNodes": -6552,
      "jsHeapTotalBytes": -1736704,
      "scriptDurationMs": 303.824,
      "eventListeners": -7477,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18140.646999999946,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17819.672,
      "heapDeltaBytes": -23581576,
      "heapUsedBytes": 179362756,
      "domNodes": -6548,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 303.803,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22301.285000000007,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 22.374000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22054.484000000004,
      "heapDeltaBytes": -12421940,
      "heapUsedBytes": 190143720,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1245184,
      "scriptDurationMs": 895.513,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 105,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22019.351000000028,
      "styleRecalcs": 158,
      "styleRecalcDurationMs": 21.902000000000033,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21784.195,
      "heapDeltaBytes": -40142972,
      "heapUsedBytes": 162598744,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2129920,
      "scriptDurationMs": 894.26,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 192,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6568.331,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.22299999999998,
      "layouts": 20,
      "layoutDurationMs": 25.478,
      "taskDurationMs": 6525.834,
      "heapDeltaBytes": -32897380,
      "heapUsedBytes": 180363688,
      "domNodes": -6548,
      "jsHeapTotalBytes": 8376320,
      "scriptDurationMs": 119.959,
      "eventListeners": -7467,
      "totalBlockingTimeMs": 482,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6496.058000000062,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 73.78000000000002,
      "layouts": 20,
      "layoutDurationMs": 25.345000000000006,
      "taskDurationMs": 6410.548000000001,
      "heapDeltaBytes": -18961940,
      "heapUsedBytes": 178235952,
      "domNodes": -6548,
      "jsHeapTotalBytes": 15761408,
      "scriptDurationMs": 117.08099999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 474,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 470.9890000000314,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 26.823999999999998,
      "layouts": 3,
      "layoutDurationMs": 1.539,
      "taskDurationMs": 121.185,
      "heapDeltaBytes": 5285976,
      "heapUsedBytes": 73254784,
      "domNodes": 151,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 11.308,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "workflow-execution",
      "durationMs": 124.18800000000374,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 17.818,
      "layouts": 2,
      "layoutDurationMs": 1.19,
      "taskDurationMs": 83.25399999999999,
      "heapDeltaBytes": 3006128,
      "heapUsedBytes": 70559972,
      "domNodes": 128,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.433000000000001,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48086 70504 68.2% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.7% 391
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.5% 251
src/scripts/pnginfo.ts 21.4% 221
src/renderer/core/canvas/pathRenderer.ts 24.7% 192

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 29, 2026
@codecov

codecov Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                             Coverage Diff                             @@
##           nathaniel/agent-v1/10-message-renderers   #16211      +/-   ##
===========================================================================
+ Coverage                                    83.26%   83.28%   +0.02%     
===========================================================================
  Files                                         2025     2025              
  Lines                                       117133   117139       +6     
  Branches                                     33076    33075       -1     
===========================================================================
+ Hits                                         97527    97562      +35     
+ Misses                                       19262    19234      -28     
+ Partials                                       344      343       -1     
Flag Coverage Δ
e2e 66.69% <ø> (+0.05%) ⬆️
unit 76.51% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/load3d/modelThumbnail.ts 100.00% <100.00%> (+5.00%) ⬆️
...tensions/agent/components/agent/AgentPanelRoot.vue 100.00% <ø> (+100.00%) ⬆️
...agent/components/agent/message/ReplyAssetGroup.vue 95.00% <100.00%> (+0.17%) ⬆️
...ons/agent/components/agent/message/UserMessage.vue 100.00% <ø> (ø)
...bench/extensions/agent/utils/downloadReplyAsset.ts 94.73% <100.00%> (+0.61%) ⬆️
...rc/workbench/extensions/agent/utils/replyAssets.ts 96.87% <100.00%> (+0.10%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 2
🟡 Medium 5
🟢 Low 3

Panel: 8/8 reviewers contributed findings.

Comment thread src/assets/css/style.css Resolved
Comment thread src/components/load3d/modelThumbnail.ts Resolved
Comment thread src/components/load3d/modelThumbnail.ts Resolved
@christian-byrne

christian-byrne commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Automated fleet review (desktop operator, Christian-authorized)

  • BLOCKED.
  • Slice-local review passes.
  • Chain and CI blocked.
Full context for agent readers

PR #16211 — design-review packet (agent-v1 slice 11/18)

Target: Comfy-Org/ComfyUI_frontend#16211
— "[agent-v1 11/18] feat(agent): message composites and media rendering". DRAFT, OPEN, MERGEABLE.
Author: CodeJuggernaut. Head: 3fc436c09a848bdf543a664cb3d54e31a8f7aa1c (single commit
3fc436c09). Base: nathaniel/agent-v1/10-message-renderers (PR #16210), not main.
Census: 29 files, +3139 / −8 (11 of the 29 are *.test.ts).
Method: gh pr view / gh pr diff only — no worktree added (R4), no checkout of the branch.
Host-side symbols cross-checked against the pre-existing workspace checkout
ComfyUI_frontend/ @ 7ed43cf341 (read-only; that tree is the QA-42 lineage, not the slice chain).
Quarantine: the PR body links a Notion "Agent V1 Decision Log". Per COR-8 that link was not
opened
. Everything below is derived from the diff, from CI, and from our own decisions/ +
program/ surfaces.
Report-only. No PR comment, no review, no issue filed. Date: 2026-08-29.


0. Verdict first

MERGE-OK-AS-IS, with two non-blocking notes for the operator to carry (§5).

Merge path: does NOT fold into #97. It needs no packet of its own either — it is a link in
Nathaniel's stack, governed by the stack's own squash-merge order.

Reasoning, stated plainly because the lane brief anticipated the opposite:
this slice contains zero CRDT surface. No import of agent/crdt/*, no stamp, no Lamport or
scalar clock, no Yjs/Loro/Automerge symbol, no op vocabulary, no wire frame. The only occurrence of
the string crdt in the entire 3351-line diff is an untouched context line in knip.config.ts
naming CrdtDevPanel.vue. Consequently the ADR-016 / ADR-007 / DQ-10 stamp questions and the
"baked-in schema assumptions that break on rebase onto the integration candidate" concern do not
bind here
. They bind at slice 07 (agent-control-plane, the slice whose landing the knip comment
says will "import the crdt tree"), which is exactly where a collision with our integration candidate
#16198 would surface. §2 develops this.


1. What the PR actually does

Message-composite rendering for the agent chat panel, plus the media/reference substrate those
composites need. Nothing in it is mounted by any current renderer.

New, inside src/workbench/extensions/agent/ (23 files):

Surface Files
Message composites message/AgentMessage.vue, UserMessage.vue, MarkdownStream.vue, MessageFeedback.vue (+ 4 suites)
Media / reference cards message/ReplyAssetGroup.vue, ReplyAudioCard.vue, TabLinkCard.vue (+ 3 suites)
Reply-asset utilities utils/replyAssets.ts (+ suite), utils/downloadReplyAsset.ts (no suite)
Tab binding stores/agent/agentWorkflowTabBindingStore.ts (+ suite)
Tooltip components/agent/AgentTooltip.vue (no suite)
Styling agentTheme.css (24 lines, tokens), agentPanel.css (86 lines, keyframes + classes)

New, outside the agent extension (2 files):
src/components/load3d/modelThumbnail.ts (+ suite) — 51 lines; offscreen 3D thumbnail capture,
serialized through a module-level promise queue to bound live WebGL contexts, persisting through
persistThumbnail. It reaches createLoad3d through a dynamic await import(...), so nothing
pulls the load3d/three.js graph into an eagerly-loaded chunk.

Modified shared files (4) — the disclosed hunks, all verified to match the disclosure:

  • knip.config.ts — removes the transitional ignore for services/agent/agentMessageParts.ts
    (its part types gain in-slice consumers here). The CrdtDevPanel.vue ignore is left in place,
    untouched.
  • src/assets/css/style.css — +1 line, @import '../../workbench/extensions/agent/agentTheme.css'.
    This is the one genuinely global, ungated edit in the PR (§3).
  • src/composables/useTooltipConfig.ts — +4 exported consts (AGENT_TOOLTIP_SHOW_DELAY,
    AGENT_REKA_TOOLTIP_PROVIDER_PROPS, AGENT_TOOLTIP_SURFACE_CLASS,
    AGENT_REKA_TOOLTIP_CONTENT_CLASS). Purely additive; no existing export changed.
  • src/locales/en/main.json — +9 keys (2 in g.*: mute/unmute; 7 agent-scoped).
  • (message/ToolCallGroup.test.ts is a fifth modified file — restoring the describe block slice 10
    deferred, as the body states.)

Host surfaces it consumes: @/scripts/api, @/stores/queueStore (ResultItemImpl),
@/stores/dialogStore, @/platform/assets/utils/{assetPreviewUtil,mediaIconUtil},
@/platform/workflow/{core/services/workflowService, management/stores/workflowStore, validation/schemas/workflowSchema}, @/utils/{markdownRendererUtil,formatUtil},
@/composables/useWaveAudioPlayer, @/base/common/downloadUtil, marked, reka-ui, @vueuse/core.
All read-only consumption of existing host APIs; no host API is redefined or shadowed.


2. Alignment with our design surfaces

2.1 CRDT / stamp alignment — not applicable, and that is the finding

Grepped the full diff for crdt|lamport|yjs|loro|automerge|stamp|scalar|clock|vectorClock|revision:
two hits, both the untouched CrdtDevPanel.vue knip context lines. The import census (§1) contains
no agent/crdt/* path.

So the specific hazards the lane brief named:

  • scalar-v1 vs Lamport stamps (ADR-007, ADR-016, DQ-10 ruled Lamport-in-V1 08-29 01:14Z;
    comfy-multi-player main Lamport-merged @ 8636af3e) — no exposure. This slice never
    constructs, compares, or serializes a stamp.
  • baked-in schema assumptions that break on rebase onto the integration candidate — no
    exposure at this slice.
    The only schema import is ../../../schemas/agentApiSchema (the agent
    HTTP/SSE reply shape, established upstream in the chain at slices 07–09) plus the host's own
    workflowSchema. Neither is a CRDT document schema. Rebasing [agent-v1 11/18] feat(agent): message composites and media rendering #16211's content onto anything
    that changes stamp or frame shape is a no-op for these 29 files.

Where the exposure actually lives, for the operator's map: knip.config.ts still carries
'src/workbench/extensions/agent/crdt/CrdtDevPanel.vue' under the comment "dev-only debug panel
with no mount site until slices 07+ import the crdt tree"
. That comment is the chain's own
statement that slice 07 lands an agent/crdt/ tree in the FE. Our v2 follower integration
candidate #16198 also lands FE CRDT code. The port-vs-merge collision between the two is a slice-07
question. Slice 11 is downstream of it and inherits whatever slice 07 settles; it adds nothing to it.

2.2 ADR-011 (one FE branch, distribution-resolved boundaries)

Consistent. Nothing here forks on DISTRIBUTION, isCloud, or isDesktop, and nothing needs to —
message rendering has no distribution-specific semantics. downloadReplyAsset routes through
api.apiURL / api.fetchApi, i.e. the single existing transport seam, rather than hardcoding an
origin. That is the ADR-011-correct choice. INV-AUTH-UNIFIED is untouched (no new auth path);
INV-MODEL-REMOTE is untouched (no model call).

2.3 ADR-018 (product-flag gating)

ADR-018 governs the backend CRDT WebSocket dispatch seam and is not implicated. On the FE side the
cohort gate is the PostHog flag agent-in-app-experience
(agent/utils/postHogFlagSource.ts:1, AGENT_PANEL_FLAG). §3 records what this slice does and does
not put behind it.

2.4 Our own review discipline

The v-html at MarkdownStream.vue is genuinely sanitized — renderMarkdownToHtml
(src/utils/markdownRendererUtil.ts:56) terminates in DOMPurify.sanitize(html, { ADD_TAGS, ADD_ATTR: [...ALLOWED_ATTRS, 'target', 'rel'] }). The PR body's claim checks out; I verified it against the
host util rather than taking the body's word.


3. Risk classing

Shipped-surface exposure: one line, and it is small but real.

style.css gains an unconditional @import of agentTheme.css. That sheet is 24 lines of Tailwind
v4 @theme / @theme inline token declarations — 14 --color-agent-* vars (13 aliasing existing
design-system tokens, one hardcoded #303036 pill, one hardcoded #ffffff accent-fg with an
in-file comment boarding it to FE-1187), --radius-agent, and two --animate-agent-collapsible-*
tokens. Effects:

  • It ships to every distribution and every user, including users outside the
    agent-in-app-experience cohort. There is no flag on a CSS @import and there is no reasonable
    way to put one there, so this is a design consequence rather than an oversight.
  • Byte cost is negligible (<1 KB of :root custom properties; the bg-agent-* / text-agent-*
    utilities are emitted on demand and only this slice's unmounted components reference them).
    binary-size CI passes.
  • No global selector is overridden. No html, body, *, or bare-element rule anywhere in the
    sheet. Token-namespace addition only. Low risk, accepted.

Everything else is dev-inert. agentPanel.css is imported by nothing, so it contributes zero
bytes to any bundle. ConversationView — the only renderer of AgentMessage — is not in the chain
yet, so no component in this slice mounts. Feature-gating of the mount is correctly deferred to the
panel-root slice (14), which is where AGENT_PANEL_FLAG belongs.

Bundle: two defineAsyncComponent boundaries (MediaLightbox, Load3dViewerContent) and two
dynamic import()s (modelThumbnail, and createLoad3d inside it). No heavy dependency enters a
static chunk. binary-size and storybook-build both pass.

CI — no new failures introduced. #16211 has 11 failing checks; PR #16210, its base, has the
same 11, by identical name and shard index
(e2e-status, playwright-tests (mobile-chrome), and
chromium shards 2,3,4,6,7,8,10,14,15 of 16). The Playwright breakage is inherited from the stack, not
authored here. The gates that would catch this slice's own defects all pass: test,
lint-and-format, json-lint, binary-size, storybook-build, perf-tests, validate-licenses,
Check for AI agent co-author trailers. That last one matters by contrast: the trailer check that is
currently blocking our #16198 (per blocked-on-christian#97) passes cleanly here, so #16211 carries
no equivalent history-rewrite debt.


4. Code observations

Reviewed against our standards, not adopted from the PR's own review panel.

  1. agentWorkflowTabBindingStore — useLocalStorage<Record<string,string>>('Comfy.Agent.WorkflowTabBindings', {}),
    with bind() enforcing a one-tab-one-workflow invariant by filtering out any prior entry holding
    the same tabPath. The invariant is enforced in the right direction and tabPathFor correctly
    uses Object.hasOwn rather than truthiness. Two notes, neither blocking: the map is never
    evicted
    (a workflow id deleted from the workspace leaves a permanent row), and workflowIdFor
    is a linear scan — fine at realistic sizes. This is client-local UI state, deliberately outside
    any synced document; that is the correct placement and does not conflict with anything our design
    owns.
  2. downloadReplyAsset subpath edge (disclosed by the author, confirmed real). The
    asset.url.includes(apiBase) → slice(indexOf(apiBase) + api.apiURL('').length) recovery yields
    a correct leading-slash route on the happy path. When the URL does not contain the API base, it
    falls through to passing an absolute URL to api.fetchApi, which prepends the base — producing a
    malformed request rather than a cross-origin fetch. Failure mode is a dead download button, not an
    egress. Acceptable to defer.
  3. Cross-sheet coupling between the live and inert stylesheets — the one thing the PR body's
    framing understates.
    --animate-agent-collapsible-down/-up are registered in the live
    agentTheme.css, but @keyframes agent-collapsible-down / -up / agent-shimmer and the
    .agent-shimmer-text class body are all in the inert agentPanel.css. AgentMessage.vue
    already applies agent-shimmer-text (and its suite asserts the class is present), so between now
    and slice 14 the token is live while its keyframes are absent — the animation resolves to a
    no-op. Nothing user-visible today, because nothing mounts. But it means the two sheets are not
    independent and must land together, and it means slice 11's shimmer assertion is a class-presence
    assertion, not a styling assertion. The author's stated plan (computed-style shimmer check in the
    panel-root slice's acceptance) is the right remedy; the operator should hold them to it.
  4. classifyAssetUrl resolves via new URL(href, window.location.origin) with no same-origin
    constraint, so agent-authored markdown can classify a third-party URL as a renderable asset. This
    is the pre-existing behaviour of markdown image rendering in the host and the download path
    fails closed on it (see 2). Noted, not raised.
  5. Bounded retry timer (ReplyAssetGroup, setTimeout(() => refreshModelThumbnail(asset, false), 2000))
    — the author flags "no unmount teardown". It is a single non-recursive retry writing to a ref;
    worst case is a ≤2 s dangling closure with no DOM write. Agreed non-blocking.
  6. Test coverage: 11 suites for 12 non-test source files. AgentTooltip.vue and
    downloadReplyAsset.ts ship untested — the author's own disclosed no-test debt. Both are small
    and inert; boarding them to the post-chain fix round is proportionate.
  7. aria-expanded is present and asserted on the collapsible surfaces this slice adds; the
    author's disclosed gap is specifically the Show more/less toggles. Not verified further — it does
    not change the verdict.

5. Verdict and merge path

MERGE-OK-AS-IS

Nothing in this slice conflicts with our design, because nothing in it touches the surface our design
governs. It is a self-contained rendering slice: additive to shared files, inert at runtime, clean on
every gate that can see it, and introducing zero CI failures over its base.

Two notes to carry, neither a merge condition:

  • N1 (carry to slice 14 acceptance). agentTheme.css and agentPanel.css are coupled — the
    animate tokens in the live sheet resolve to keyframes that exist only in the inert one. Slice 14's
    acceptance must include the computed-style check the author already committed to, and must not
    land the import './agentPanel.css' behind a flag that would leave the tokens dangling in the
    gated-off case.
  • N2 (record, do not act). style.css now ships --color-agent-* tokens to all users
    irrespective of the agent-in-app-experience cohort. Sub-kilobyte and side-effect-free; recorded
    so it is not re-discovered as a surprise during rollout.

Merge path: its own lane, folding into neither #97 nor a new packet

Recommendation to the operator: no review comment, no hold. If a chain-level comment is ever
posted, N1 is the only item worth including.


6. Verified-state delta

Two genuinely new SHA-anchored facts were verified here. They are staged below rather than written
into reports/audit/verified-state.md
: the single-writer rule for this lane grants me only
reports/review/pr16211-review.md, and four sibling slice-review lanes are live against the same
ledger file. The operator should append them (or authorise one lane to serialise the batch).

Fact Verified at (SHA/state) Date (Z) Lane/actor
FE PR #16211 introduces zero CRDT surface (no agent/crdt/* import; full-diff grep for crdt|lamport|yjs|loro|automerge|stamp|scalar|clock hits only untouched CrdtDevPanel.vue knip context) PR #16211 head 3fc436c09 2026-08-29 pr16211-review
FE PR #16211 CI failure set is identical to its base #16210 — same 11 checks, same chromium shard indices; zero new failures #16211 3fc436c09 vs #16210, runs 33225924338 et al. 2026-08-29 pr16211-review

Summary of the same two facts in prose:


Merge-readiness scorecard

Slice 11 merge-readiness scorecard

PR: Comfy-Org/ComfyUI_frontend#16211 — message composites and media rendering
Observed: 2026-08-30 at head 3fc436c09a848bdf543a664cb3d54e31a8f7aa1c
Overall verdict: BLOCKED — slice-local review is acceptable, but CI is red and bottom-up predecessors 03–10 have not landed.
Score: 3.5/7 (PASS or accepted discretion = 1; PARTIAL = 0.5; FAIL/BLOCKED = 0)

03 -> 04 -> 05 -> 06 -> 07 -> 08 -> 09 -> 10 -> [11] -> 12 -> main
                                                ^
                             locally acceptable; globally out of turn
gate status evidence
Review verdict PASS (1/1) The review packet says MERGE-OK-AS-IS. Its two carry notes are non-blocking: keep agentTheme.css and agentPanel.css coupled through slice 14 acceptance, and record that globally loaded agent color tokens are sub-kilobyte/side-effect-free.
Flag-off safety PASS-WITH-DISCRETION (1/1) mr-1 labels the global agentTheme.css import a LEAK. Under issue #149's later user-facing-strict, desktop-discretion ruling, this is accepted: the sheet adds namespaced variables only, overrides no global selector, and the gated component tree is unmounted. Reopen if runtime flag-off evidence shows a visible delta.
CI on current head FAIL (0/1) Live gh pr checks at 3fc436c0: 90 pass, 11 fail, 22 skip. Red: e2e-status, mobile Chrome, and Chromium shards 2, 3, 4, 6, 7, 8, 10, 14, and 15. The review proves the set is identical to base slice 10, but the current head is still not green.
Conflict with declared base PASS (1/1) GitHub reports MERGEABLE against nathaniel/agent-v1/10-message-renderers@16fe0e90; no current-base merge conflict. mergeStateStatus=BLOCKED is policy/check state.
Draft and retarget-to-main readiness BLOCKED (0/1) Still draft. FEH-4 requires candidate then slices 03–10 before this restack. Direct retarget to main is premature.
Test coverage PARTIAL (0.5/1) Broad unit/component coverage: 11 suites for 12 non-test source files, including message composition, media cards, URL extraction, tab binding, and 3D thumbnail serialization. AgentTooltip.vue and downloadReplyAsset.ts have no direct suite; no composed browser media journey is proven; full E2E remains red.
Open blockers BLOCKED (0/1) Green CI; owner-controlled undraft; bottom-up landing of slices 03–10; independent rp-1 packets for 03–07; and union-preview checks for image/video/audio/3D, download, tab navigation, feedback, and accessibility.

Merge decision

No slice-local code change is required by this review. Hold until its predecessor chain is landed,
then restack, rerun CI and composed media/browser coverage, and confirm the flag-off discretion still
produces no visible behavior.

Provenance and glossary

Sources: live GitHub metadata/checks, internal review packet, mr-1 plus issue #149 ruling, FEH-4,
and the G1 Linear checkpoint. No quarantined Nathaniel design document or Linear narrative was read.

  • PASS-WITH-DISCRETION — accepted by the desktop-owned issue Convert legacy format node.widget_values #149 rule because no user-facing flag-off change is established.
  • Composite — a component assembling lower-level message and media renderers.
  • Current base — slice 10, not main.
  • rp-1 — the parallel review-packet lane for slices 03–07.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: ab2cafb2-2928-4cb3-8072-f9f9b9a43cdd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/10-message-renderers branch from 023fb92 to 6eae48b Compare August 30, 2026 16:56
@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/11-media-reference-renderers branch from 9406898 to 7c8e2fb Compare August 30, 2026 17:09
@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/10-message-renderers branch from 6eae48b to 84b33db Compare August 30, 2026 17:43
CodeJuggernaut and others added 3 commits August 30, 2026 17:43
- the message container, markdown stream, user message, and
  feedback controls compose over the landed leaves
- media asset groups with audio playback, lazy 3D thumbnails, and
  lightbox handoff; workflow tab-link cards navigate through the
  shared workflow service
- the agent theme and panel style sheets land with their first
  mounted consumers, wired through the global style import
- the tab binding store rides with its first consumer; the
  tool-grouping spec returns to its full form
@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/11-media-reference-renderers branch from 7c8e2fb to 479e3a7 Compare August 30, 2026 17:45
@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR and removed cursor-review Trigger multi-model Cursor agent review on this PR labels Aug 31, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor

Superseded — closing per Christian's direction.

Full context for agent readers

Program pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs.

The download-action test still asserted the pre-fix contract (every
asset through authenticated fetchApi). downloadReplyAsset deliberately
scopes credentials to exact same-origin /view URLs; cross-origin assets
go through plain fetch. Assert the fixed contract: two plain fetches, a
fresh Response per call (a shared mock Response fails on second body
read), fetchApi untouched. Routing itself stays pinned in
downloadReplyAsset.test.ts.
The tool-group status label lost the agent-shimmer-text arming that
both the upstream tree and main carry; the resumed-thinking parity
test expects it. Arm it with the chain's own signals (thoughts
present + group active) via cn.
…nderers' into hub-11-cascade

# Conflicts:
#	knip.config.ts
#	src/assets/css/style.css
#	src/components/load3d/modelThumbnail.test.ts
#	src/components/load3d/modelThumbnail.ts
#	src/composables/useTooltipConfig.ts
#	src/locales/en/main.json
#	src/workbench/extensions/agent/components/agent/AgentPanelRoot.test.ts
#	src/workbench/extensions/agent/components/agent/message/MessageFeedback.test.ts
#	src/workbench/extensions/agent/components/agent/message/ReplyAssetGroup.test.ts
#	src/workbench/extensions/agent/components/agent/message/ReplyAssetGroup.vue
#	src/workbench/extensions/agent/components/agent/message/UserMessage.vue
#	src/workbench/extensions/agent/utils/downloadReplyAsset.ts
#	src/workbench/extensions/agent/utils/replyAssets.test.ts
#	src/workbench/extensions/agent/utils/replyAssets.ts
@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR and removed cursor-review Trigger multi-model Cursor agent review on this PR labels Sep 2, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Round 2 — ledger: 10 prior finding(s) across 1 round(s) (10 never answered).

Found 10 finding(s).

Severity Count
🟠 High 1
🟡 Medium 8
🟢 Low 1

Panel: 4/8 reviewers contributed findings.

Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gpt-5.6-sol-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gemini-3.1-pro:edge-case (error)


The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:

src/lib/litegraph/src/linkDeduplication.ts:219 — 🟠 High — The new while (successfulPasses < referencedNames.size) retry loop can make zero progress: when updateEndpoints fails while moved is empty (every remaining link already in skipped, with the rejection coming from removals), blocked is empty too, so blocked.length ? blocked : moved adds nothing to skipped, successfulPasses never increments, and continue re-runs identical state — an unbreakable loop that hangs the tab during graph configure. The previous for loop with break always terminated; bound the attempts or bail out when neither skipped nor successfulPasses grew.

Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max edge-case).

src/workbench/extensions/agent/crdt/ecsFollowerAdapter.ts:221 — 🟡 Medium — applyQueuedFrame has already dequeued the frame and here discards the session's pending change-set before the commit is attempted, so when mutations.batch rejects and applies nothing (unowned node/link, unkeyable widget, missing slot, or a non-numeric link key that the Number(id) coercion below turns into NaN) the observed effects are gone with no requeue and the ECS stores diverge from the follower doc permanently. ADR 0024, added in this same PR, requires the opposite — "remove the frame from the queue only after that commit succeeds" — so discard the pending sets only on success and requeue or report on failure.

Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial).

src/workbench/extensions/agent/crdt/layoutFollowerBridge.ts:191 — 🟡 Medium — lastSeq is advanced on the two lines above, so a Y.applyUpdate that throws on a corrupt or truncated update leaves the sequence consumed while nothing was integrated: seq stays contiguous, the gap detector above never fires, and the follower doc is permanently missing that content with no resubscribe. Advance lastSeq only after a successful apply, and treat an apply failure as a gap rather than letting it escape the listener.

Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial).

src/platform/assets/schemas/mediaAssetSchema.ts:59 — 🟡 Medium — attachment_ref and preview_url are read out of a DataTransfer payload with no provenance check, and any page can set the application/x-comfy-asset-info MIME on its own dragstart. AgentPanelRoot.attachDroppedAsset stages asset.ref verbatim when present (skipping the upload path) and the composer forwards it as attachments, with no validation that it is a bare filename — ../../etc/passwd reaches the server as an uploaded-input reference — while preview_url is rendered as an <img src> beacon. Only trust a ref this app minted, validate its shape (no separators, no ..), and restrict preview_url to the API origin.

Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).

src/composables/useLoad3dViewer.ts:517 — 🟡 Medium — standaloneAssetName parses a bare filename out of the model URL and persistThumbnail(name, blob) lets the server attach the render to whatever previewless asset matches that name. ReplyAssetGroup opens this viewer with modelUrl: asset.url straight from an agent-supplied markdown link, so one click on a reply tile can overwrite an unrelated asset's server-side preview with an image rendered from a URL the message controls — round 1 raised this at the previous call site and the call was relocated here rather than resolved. Persist only against a record the client itself resolved for this asset.

Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).

src/workbench/extensions/agent/stores/agentPanelStore.ts:8 — 🟡 Medium — Two modules register defineStore('agentPanel') with incompatible shapes: this gate-only one (enabled/isOpen/gateSettled) and stores/agent/agentPanelStore.ts, which adds width, isMaximized, setWidth, toggleMaximize and close(source). Pinia keys stores by id, so whichever module instantiates first wins for every importer — if this one does, visibleCanvasViewport computes a NaN viewport from panel.width === undefined (poisoning ds.scale/ds.offset on Fit View) and toggleMaximize is missing; the new agentPanelStoreId.test.ts only pins the current import order. Delete this module and the nested components/agent/AgentPanelRoot.vue stub that imports it, or merge the shapes.

Raised by 2 of 8 reviewers (kimi-k3-max adversarial, kimi-k3-max edge-case).

src/composables/useWorkspaceInset.ts:12 — 🟡 Medium — useWorkspaceInsetRight is never called outside its own test, so --workspace-inset-right is never published and every consumer added in this diff (dialog.variants.ts, dialogService, useAssetBrowserDialog, useShareDialog) resolves the 0px fallback — dialogs stay centred on the raw viewport and partly under the docked Agent panel, which is the exact case this composable exists for. DockedAgentPanel should call it with the store width (and release it on unmount).

Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

src/platform/errorCatalog/promptErrorResolver.ts:20 — 🟡 Medium — agent_api_failed is missing from this set even though the locale now defines errorCatalog.promptErrors.agent_api_failed.title/desc ("Comfy Agent error"), useErrorGroups' AGENT_PROMPT_ERROR_TYPES lists it, and AgentPanelRoot.surfaceAgentError records exactly that type. Every agent transport/session failure therefore misses the catalog lookup and shows the generic prompt-error copy instead.

Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

src/workbench/extensions/agent/components/agent/Composer.vue:291 — 🟡 Medium — Enter calls composer.submit(), whose only guard is the isStreaming: () => streaming callback a few lines above — it ignores submitting. While a POST is in flight (submitting true, streaming still false) Enter clears the draft and the staged attachments, then sendMessage rejects with the busy guard, so the second message is never sent and its uploaded attachment refs are lost. The Send button already uses running = streaming || submitting; pass the same condition into useComposer.

Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

src/workbench/extensions/agent/crdt/docFrameClient.ts:105 — 🟢 Low — atob is called unguarded on update_b64, which is only type-checked as a string, so a malformed or truncated doc_update throws InvalidCharacterError out of parseServerDocFrame inside the api custom-event listener instead of being dropped like every other unparseable frame — an uncaught exception plus a swallowed frame that only recovers via the next seq gap. Wrap the decode in try/catch and return null for the frame.

Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor

This slice is reference-only. Accepted work is routed to #16385, #16430, and #16406.

Full context for agent readers

Per Christian's main-target close ruling, #16211 (11 — media and reference renderers) is no longer a landing vehicle. It remains readable implementation and review provenance. Renderer, reply-asset, and permanent-test responsibilities are separated. If a genuinely unaccounted delta is found, reopen this source or file a bounded main-based carrier rather than reviving the stacked merge path.

Decision record.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-attachments Agent asset uploads, attachments or media references agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-attachments Agent asset uploads, attachments or media references agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants