Repository navigation
[agent-v1 11/18] feat(agent): message composites and media rendering - #16211
CodeJuggernaut wants to merge 12 commits into
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1890 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-01T11:22:23.532Z",
"gitSha": "df9324d69b6dd6a53a318507f4bb69a046a90be2",
"branch": "nathaniel/agent-v1/11-media-reference-renderers",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2051.6170000000216,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.696,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 514.737,
"heapDeltaBytes": 7609120,
"heapUsedBytes": 71182948,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 9.885000000000002,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2056.878999999981,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.723999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.96299999999997,
"heapDeltaBytes": 1399036,
"heapUsedBytes": 64810944,
"domNodes": -284,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.783,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2050.6540000000086,
"styleRecalcs": 77,
"styleRecalcDurationMs": 51.46500000000001,
"layouts": 14,
"layoutDurationMs": 5.111,
"taskDurationMs": 1076.961,
"heapDeltaBytes": -8309356,
"heapUsedBytes": 61869312,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 174.27800000000002,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1872.2380000000385,
"styleRecalcs": 79,
"styleRecalcDurationMs": 42.965999999999994,
"layouts": 14,
"layoutDurationMs": 4.743,
"taskDurationMs": 912.99,
"heapDeltaBytes": 13836504,
"heapUsedBytes": 83600232,
"domNodes": -279,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 145.24800000000002,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.0980000000459,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.205,
"layouts": 6,
"layoutDurationMs": 1.3410000000000002,
"taskDurationMs": 364.88800000000003,
"heapDeltaBytes": 4451204,
"heapUsedBytes": 74637492,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.020000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.7159999999067,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.073999999999998,
"layouts": 6,
"layoutDurationMs": 1.2069999999999999,
"taskDurationMs": 375.298,
"heapDeltaBytes": 4382308,
"heapUsedBytes": 73734872,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 13.011999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 705.3180000000339,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.6320000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.492,
"heapDeltaBytes": 18414856,
"heapUsedBytes": 82282864,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 153.961,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 683.6729999999989,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.599,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.89,
"heapDeltaBytes": 18106112,
"heapUsedBytes": 88063384,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 151.138,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2032.2909999999865,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.039,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 673.077,
"heapDeltaBytes": 11078064,
"heapUsedBytes": 86862424,
"domNodes": -273,
"jsHeapTotalBytes": -1646592,
"scriptDurationMs": 36.586,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2068.4139999999616,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.823,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 643.099,
"heapDeltaBytes": -13182240,
"heapUsedBytes": 87062240,
"domNodes": -268,
"jsHeapTotalBytes": -1609728,
"scriptDurationMs": 40.804,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2216.3659999999936,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.147000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1561.912,
"heapDeltaBytes": 22123512,
"heapUsedBytes": 88102296,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 746.9100000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2150.8780000000343,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.067000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1571.9990000000003,
"heapDeltaBytes": 19023296,
"heapUsedBytes": 84669392,
"domNodes": -275,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 739.694,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3629.465000000039,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.539999999999997,
"layouts": 60,
"layoutDurationMs": 13.802,
"taskDurationMs": 1754.1190000000001,
"heapDeltaBytes": 9562724,
"heapUsedBytes": 76570256,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 768.9359999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3643.063999999981,
"styleRecalcs": 61,
"styleRecalcDurationMs": 13.179999999999998,
"layouts": 60,
"layoutDurationMs": 14.295,
"taskDurationMs": 1841.271,
"heapDeltaBytes": 8454308,
"heapUsedBytes": 76031816,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 810.121,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3179.1620000000194,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.563999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2038.6350000000002,
"heapDeltaBytes": 19702740,
"heapUsedBytes": 86818944,
"domNodes": -11,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 987.882,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3099.0840000000617,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.890999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1941.803,
"heapDeltaBytes": 17429268,
"heapUsedBytes": 84254384,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 924.3750000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1999.430000000018,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.505999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.9499999999999,
"heapDeltaBytes": 21575364,
"heapUsedBytes": 87332916,
"domNodes": -3,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.84,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2006.8989999999758,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.9030000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.313,
"heapDeltaBytes": 22413816,
"heapUsedBytes": 88561892,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.349999999999994,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 613.0380000000173,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.588999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 413.11199999999997,
"heapDeltaBytes": 14206728,
"heapUsedBytes": 86217328,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 141.773,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 587.3060000000123,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.343000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 404.719,
"heapDeltaBytes": 13687468,
"heapUsedBytes": 85614172,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.688,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.555999999985,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.866,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.191,
"heapDeltaBytes": -10691984,
"heapUsedBytes": 61699204,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.197999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2032.4789999999666,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.76500000000004,
"heapDeltaBytes": -10689896,
"heapUsedBytes": 61309856,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.450999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.438000000011,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.683,
"layouts": 18,
"layoutDurationMs": 5.9639999999999995,
"taskDurationMs": 872.104,
"heapDeltaBytes": -12970968,
"heapUsedBytes": 58994972,
"domNodes": -295,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 114.77099999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.4560000000229,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.913999999999994,
"layouts": 18,
"layoutDurationMs": 5.638,
"taskDurationMs": 841.1719999999999,
"heapDeltaBytes": -11569824,
"heapUsedBytes": 60319560,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 110.146,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.7879999999814,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.70100000000001,
"layouts": 15,
"layoutDurationMs": 14.395000000000001,
"taskDurationMs": 955.599,
"heapDeltaBytes": -7290576,
"heapUsedBytes": 87832288,
"domNodes": 13671,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 29.918000000000006,
"eventListeners": 2381,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8447.32399999998,
"styleRecalcs": 247,
"styleRecalcDurationMs": 41.78900000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5811.659,
"heapDeltaBytes": -19511144,
"heapUsedBytes": 80775600,
"domNodes": -270,
"jsHeapTotalBytes": -1384448,
"scriptDurationMs": 2552.028,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8464.97099999999,
"styleRecalcs": 247,
"styleRecalcDurationMs": 40.339,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5720.511,
"heapDeltaBytes": -11301280,
"heapUsedBytes": 89207756,
"domNodes": -268,
"jsHeapTotalBytes": -1908736,
"scriptDurationMs": 2534.709,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 18298.54899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17753.346999999998,
"heapDeltaBytes": -32835408,
"heapUsedBytes": 176501384,
"domNodes": -6552,
"jsHeapTotalBytes": -1736704,
"scriptDurationMs": 303.824,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18140.646999999946,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17819.672,
"heapDeltaBytes": -23581576,
"heapUsedBytes": 179362756,
"domNodes": -6548,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 303.803,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22301.285000000007,
"styleRecalcs": 170,
"styleRecalcDurationMs": 22.374000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22054.484000000004,
"heapDeltaBytes": -12421940,
"heapUsedBytes": 190143720,
"domNodes": -6548,
"jsHeapTotalBytes": 1245184,
"scriptDurationMs": 895.513,
"eventListeners": -7469,
"totalBlockingTimeMs": 105,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22019.351000000028,
"styleRecalcs": 158,
"styleRecalcDurationMs": 21.902000000000033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21784.195,
"heapDeltaBytes": -40142972,
"heapUsedBytes": 162598744,
"domNodes": -6548,
"jsHeapTotalBytes": 2129920,
"scriptDurationMs": 894.26,
"eventListeners": -7469,
"totalBlockingTimeMs": 192,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6568.331,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.22299999999998,
"layouts": 20,
"layoutDurationMs": 25.478,
"taskDurationMs": 6525.834,
"heapDeltaBytes": -32897380,
"heapUsedBytes": 180363688,
"domNodes": -6548,
"jsHeapTotalBytes": 8376320,
"scriptDurationMs": 119.959,
"eventListeners": -7467,
"totalBlockingTimeMs": 482,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6496.058000000062,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.78000000000002,
"layouts": 20,
"layoutDurationMs": 25.345000000000006,
"taskDurationMs": 6410.548000000001,
"heapDeltaBytes": -18961940,
"heapUsedBytes": 178235952,
"domNodes": -6548,
"jsHeapTotalBytes": 15761408,
"scriptDurationMs": 117.08099999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 474,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 470.9890000000314,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.823999999999998,
"layouts": 3,
"layoutDurationMs": 1.539,
"taskDurationMs": 121.185,
"heapDeltaBytes": 5285976,
"heapUsedBytes": 73254784,
"domNodes": 151,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 11.308,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 124.18800000000374,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.818,
"layouts": 2,
"layoutDurationMs": 1.19,
"taskDurationMs": 83.25399999999999,
"heapDeltaBytes": 3006128,
"heapUsedBytes": 70559972,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.433000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## nathaniel/agent-v1/10-message-renderers #16211 +/- ##
===========================================================================
+ Coverage 83.26% 83.28% +0.02%
===========================================================================
Files 2025 2025
Lines 117133 117139 +6
Branches 33076 33075 -1
===========================================================================
+ Hits 97527 97562 +35
+ Misses 19262 19234 -28
+ Partials 344 343 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 5 |
| 🟢 Low | 3 |
Panel: 8/8 reviewers contributed findings.
|
Automated fleet review (desktop operator, Christian-authorized)
Full context for agent readersPR #16211 — design-review packet (agent-v1 slice 11/18)Target: Comfy-Org/ComfyUI_frontend#16211 0. Verdict firstMERGE-OK-AS-IS, with two non-blocking notes for the operator to carry (§5). Merge path: does NOT fold into #97. It needs no packet of its own either — it is a link in Reasoning, stated plainly because the lane brief anticipated the opposite: 1. What the PR actually doesMessage-composite rendering for the agent chat panel, plus the media/reference substrate those New, inside
New, outside the agent extension (2 files): Modified shared files (4) — the disclosed hunks, all verified to match the disclosure:
Host surfaces it consumes: 2. Alignment with our design surfaces2.1 CRDT / stamp alignment — not applicable, and that is the findingGrepped the full diff for So the specific hazards the lane brief named:
Where the exposure actually lives, for the operator's map: 2.2 ADR-011 (one FE branch, distribution-resolved boundaries)Consistent. Nothing here forks on 2.3 ADR-018 (product-flag gating)ADR-018 governs the backend CRDT WebSocket dispatch seam and is not implicated. On the FE side the 2.4 Our own review disciplineThe 3. Risk classingShipped-surface exposure: one line, and it is small but real.
Everything else is dev-inert. Bundle: two CI — no new failures introduced. #16211 has 11 failing checks; PR #16210, its base, has the 4. Code observationsReviewed against our standards, not adopted from the PR's own review panel.
5. Verdict and merge pathMERGE-OK-AS-ISNothing in this slice conflicts with our design, because nothing in it touches the surface our design Two notes to carry, neither a merge condition:
Merge path: its own lane, folding into neither #97 nor a new packet
Recommendation to the operator: no review comment, no hold. If a chain-level comment is ever 6. Verified-state deltaTwo genuinely new SHA-anchored facts were verified here. They are staged below rather than written
Summary of the same two facts in prose:
Merge-readiness scorecardSlice 11 merge-readiness scorecardPR: Comfy-Org/ComfyUI_frontend#16211 — message composites and media rendering
Merge decisionNo slice-local code change is required by this review. Hold until its predecessor chain is landed, Provenance and glossarySources: live GitHub metadata/checks, internal review packet, mr-1 plus issue #149 ruling, FEH-4,
|
16fe0e9 to
023fb92
Compare
3fc436c to
9406898
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
023fb92 to
6eae48b
Compare
9406898 to
7c8e2fb
Compare
6eae48b to
84b33db
Compare
- the message container, markdown stream, user message, and feedback controls compose over the landed leaves - media asset groups with audio playback, lazy 3D thumbnails, and lightbox handoff; workflow tab-link cards navigate through the shared workflow service - the agent theme and panel style sheets land with their first mounted consumers, wired through the global style import - the tab binding store rides with its first consumer; the tool-grouping spec returns to its full form
7c8e2fb to
479e3a7
Compare
|
Superseded — closing per Christian's direction.
Full context for agent readersProgram pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs. |
The download-action test still asserted the pre-fix contract (every asset through authenticated fetchApi). downloadReplyAsset deliberately scopes credentials to exact same-origin /view URLs; cross-origin assets go through plain fetch. Assert the fixed contract: two plain fetches, a fresh Response per call (a shared mock Response fails on second body read), fetchApi untouched. Routing itself stays pinned in downloadReplyAsset.test.ts.
The tool-group status label lost the agent-shimmer-text arming that both the upstream tree and main carry; the resumed-thinking parity test expects it. Arm it with the chain's own signals (thoughts present + group active) via cn.
…nderers' into hub-11-cascade # Conflicts: # knip.config.ts # src/assets/css/style.css # src/components/load3d/modelThumbnail.test.ts # src/components/load3d/modelThumbnail.ts # src/composables/useTooltipConfig.ts # src/locales/en/main.json # src/workbench/extensions/agent/components/agent/AgentPanelRoot.test.ts # src/workbench/extensions/agent/components/agent/message/MessageFeedback.test.ts # src/workbench/extensions/agent/components/agent/message/ReplyAssetGroup.test.ts # src/workbench/extensions/agent/components/agent/message/ReplyAssetGroup.vue # src/workbench/extensions/agent/components/agent/message/UserMessage.vue # src/workbench/extensions/agent/utils/downloadReplyAsset.ts # src/workbench/extensions/agent/utils/replyAssets.test.ts # src/workbench/extensions/agent/utils/replyAssets.ts
…nderers' into hub-11-cascade
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 10 prior finding(s) across 1 round(s) (10 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 8 |
| 🟢 Low | 1 |
Panel: 4/8 reviewers contributed findings.
Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gpt-5.6-sol-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gemini-3.1-pro:edge-case (error)
The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:
src/lib/litegraph/src/linkDeduplication.ts:219— 🟠 High — The newwhile (successfulPasses < referencedNames.size)retry loop can make zero progress: whenupdateEndpointsfails whilemovedis empty (every remaining link already inskipped, with the rejection coming fromremovals),blockedis empty too, soblocked.length ? blocked : movedadds nothing toskipped,successfulPassesnever increments, andcontinuere-runs identical state — an unbreakable loop that hangs the tab during graph configure. The previousforloop withbreakalways terminated; bound the attempts or bail out when neitherskippednorsuccessfulPassesgrew.Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max edge-case).
src/workbench/extensions/agent/crdt/ecsFollowerAdapter.ts:221— 🟡 Medium —applyQueuedFramehas already dequeued the frame and here discards the session's pending change-set before the commit is attempted, so whenmutations.batchrejects and applies nothing (unowned node/link, unkeyable widget, missing slot, or a non-numeric link key that theNumber(id)coercion below turns intoNaN) the observed effects are gone with no requeue and the ECS stores diverge from the follower doc permanently. ADR 0024, added in this same PR, requires the opposite — "remove the frame from the queue only after that commit succeeds" — so discard the pending sets only on success and requeue or report on failure.Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial).
src/workbench/extensions/agent/crdt/layoutFollowerBridge.ts:191— 🟡 Medium —lastSeqis advanced on the two lines above, so aY.applyUpdatethat throws on a corrupt or truncated update leaves the sequence consumed while nothing was integrated: seq stays contiguous, the gap detector above never fires, and the follower doc is permanently missing that content with no resubscribe. AdvancelastSeqonly after a successful apply, and treat an apply failure as a gap rather than letting it escape the listener.Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial).
src/platform/assets/schemas/mediaAssetSchema.ts:59— 🟡 Medium —attachment_refandpreview_urlare read out of aDataTransferpayload with no provenance check, and any page can set theapplication/x-comfy-asset-infoMIME on its own dragstart.AgentPanelRoot.attachDroppedAssetstagesasset.refverbatim when present (skipping the upload path) and the composer forwards it asattachments, with no validation that it is a bare filename —../../etc/passwdreaches the server as an uploaded-input reference — whilepreview_urlis rendered as an<img src>beacon. Only trust a ref this app minted, validate its shape (no separators, no..), and restrictpreview_urlto the API origin.Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).
src/composables/useLoad3dViewer.ts:517— 🟡 Medium —standaloneAssetNameparses a bare filename out of the model URL andpersistThumbnail(name, blob)lets the server attach the render to whatever previewless asset matches that name.ReplyAssetGroupopens this viewer withmodelUrl: asset.urlstraight from an agent-supplied markdown link, so one click on a reply tile can overwrite an unrelated asset's server-side preview with an image rendered from a URL the message controls — round 1 raised this at the previous call site and the call was relocated here rather than resolved. Persist only against a record the client itself resolved for this asset.Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).
src/workbench/extensions/agent/stores/agentPanelStore.ts:8— 🟡 Medium — Two modules registerdefineStore('agentPanel')with incompatible shapes: this gate-only one (enabled/isOpen/gateSettled) andstores/agent/agentPanelStore.ts, which addswidth,isMaximized,setWidth,toggleMaximizeandclose(source). Pinia keys stores by id, so whichever module instantiates first wins for every importer — if this one does,visibleCanvasViewportcomputes aNaNviewport frompanel.width === undefined(poisoningds.scale/ds.offseton Fit View) andtoggleMaximizeis missing; the newagentPanelStoreId.test.tsonly pins the current import order. Delete this module and the nestedcomponents/agent/AgentPanelRoot.vuestub that imports it, or merge the shapes.Raised by 2 of 8 reviewers (kimi-k3-max adversarial, kimi-k3-max edge-case).
src/composables/useWorkspaceInset.ts:12— 🟡 Medium —useWorkspaceInsetRightis never called outside its own test, so--workspace-inset-rightis never published and every consumer added in this diff (dialog.variants.ts,dialogService,useAssetBrowserDialog,useShareDialog) resolves the0pxfallback — dialogs stay centred on the raw viewport and partly under the docked Agent panel, which is the exact case this composable exists for.DockedAgentPanelshould call it with the store width (and release it on unmount).Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
src/platform/errorCatalog/promptErrorResolver.ts:20— 🟡 Medium —agent_api_failedis missing from this set even though the locale now defineserrorCatalog.promptErrors.agent_api_failed.title/desc("Comfy Agent error"),useErrorGroups'AGENT_PROMPT_ERROR_TYPESlists it, andAgentPanelRoot.surfaceAgentErrorrecords exactly that type. Every agent transport/session failure therefore misses the catalog lookup and shows the generic prompt-error copy instead.Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
src/workbench/extensions/agent/components/agent/Composer.vue:291— 🟡 Medium — Enter callscomposer.submit(), whose only guard is theisStreaming: () => streamingcallback a few lines above — it ignoressubmitting. While a POST is in flight (submittingtrue,streamingstill false) Enter clears the draft and the staged attachments, thensendMessagerejects with the busy guard, so the second message is never sent and its uploaded attachment refs are lost. The Send button already usesrunning = streaming || submitting; pass the same condition intouseComposer.Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
src/workbench/extensions/agent/crdt/docFrameClient.ts:105— 🟢 Low —atobis called unguarded onupdate_b64, which is only type-checked as a string, so a malformed or truncateddoc_updatethrowsInvalidCharacterErrorout ofparseServerDocFrameinside theapicustom-event listener instead of being dropped like every other unparseable frame — an uncaught exception plus a swallowed frame that only recovers via the next seq gap. Wrap the decode in try/catch and returnnullfor the frame.Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).
|
This slice is reference-only. Accepted work is routed to #16385, #16430, and #16406. Full context for agent readersPer Christian's main-target close ruling, #16211 (11 — media and reference renderers) is no longer a landing vehicle. It remains readable implementation and review provenance. Renderer, reply-asset, and permanent-test responsibilities are separated. If a genuinely unaccounted delta is found, reopen this source or file a bounded main-based carrier rather than reviving the stacked merge path. |
Merge after: #16210 (10) - stacked on its branch per the successive-stack chain.
Decisions: Agent V1 Decision Log
Landing strategy: SQUASH-MERGE ONLY - owner order 2026-08-28 (branch-history containment; do not merge-commit).
Summary
Slice 11 of the agent-v1 chain: the message composites and media/reference rendering - AgentMessage, UserMessage, MarkdownStream, MessageFeedback, ReplyAssetGroup with audio/3D asset handling, TabLinkCard, and the agent styling substrate. Census vs merge-base: 29 files, +3139/-8.
Changes
Review Focus
ToolCallGroup.test.tsis restored to canonical bytes - the describe block slice 10's cut deferred returns verbatim now thatAgentMessageexists.agentTheme.cssis wired via thestyle.cssimport (theagent-*utilities are live).agentPanel.csslands hash-exact and INERT - nothing mounts these components until the panel-root slice (ConversationView, the only renderer of AgentMessage, is not in the chain yet), so the sheet ships with the consumers it styles; the panel-root slice brings its canonicalimport './agentPanel.css'and makes it live, with a computed-style shimmer check in that slice's acceptance. This description supersedes the commit body's wiring bullet, which overstates ("wired through the global style import" holds only for the theme sheet).aria-expandedon the Show more/less toggles, and no-test debt on AgentTooltip and downloadReplyAsset - all inherited from the snapshot and boarded for the post-chain fix round.v-htmlsits behind DOMPurify; object-URL handling revokes on microtask and is assert-covered; TabLinkCard navigates through the existing workflowService only.Linear tickets
Review-audit deltas (salvage matrix): items found during the slicing and review audits that did not make it through the integration merge (#16198).
No missing-artifact rows in this territory; the diff is the reviewed media/reference renderer delta, plus the cross-origin download pin and shimmer fix (CI-verified).