Repository navigation
[agent-v1 13/18] feat(agent): chat history screen and command UX - #16314
CodeJuggernaut wants to merge 118 commits into
Conversation
Lands the agent shell dark behind the existing PostHog flag agent-in-app-experience: the gate wiring (extension setup syncing the flag into the panel store), the Ask Comfy Agent topbar entry button, a stub docked panel mounted in graph and linear views, and the flag-off E2E proving no agent surface renders while the flag is off. The stub intentionally omits what later slices own: engagement telemetry and detection, panel resize and maximize, the workspace inset, selection-driven chrome hiding, and the full panel content. File paths match the feature branch so later slices replace stub content in place.
Rapid or overlapping workflow opens, closes, and subgraph hash navigations could interleave: a slower earlier load could overwrite a newer selection, closing a workflow could re-activate it, and stale hash navigations could move the canvas after a newer one. Workflow loads now run through a serialized queue with per-path pending tracking and re-entrant close accounting; hash/graph synchronization carries navigation intent ids so only the newest intent can write the route or move the canvas. Test-led split from the agent feature branch: the added service and navigation-store tests pin the contract - 13 of them fail against the previous implementation - and only non-agent hunks are extracted (the new extension load hooks stay on the feature branch with their consumer).
The full-suite baseline caught main's navigateToHash suite failing against the extracted intent-id signature: the feature branch had extended that suite (+557) plus app.test.ts's intent-forwarding case, and the initial extraction missed both. Both are taken now; the app.test.ts case covering the excluded extension load hooks stays on the feature branch with its subject.
Eight-hat review round on the shell PR; the convergent findings: - Register the gate extension in the cloud block, where the PostHog flag actually exists and the SDK is initialized - the misplaced !isCloud registration made the panel unreachable in every shipped build, failed the cloud E2E job, and leaked posthog-js into the OSS dist scan. - Force-enable dev builds BEFORE the SDK import so a blocked chunk cannot take local development down, and add a bounded retry that re-takes the flag subscription when extension setup wins the race against posthog initialization (pre-init subscriptions are dead). The gate marks a body dataset when settled so the flag-off E2E asserts after gating actually ran, anchored by the tab-bar container being visible. - Restructure LinearView like the canvas overlay (row root + column wrapper) so the docked panel is a right-hand sibling instead of stacking below the workspace; pinned by a placement test. - Replace the entry chip's fixed ink-700 fill with a semantic surface token (the fixed hex under a theme-flipping foreground computed 1.11:1 in light themes) and add aria-pressed. - Rebuild the E2E boot mocks on the shared mockCloudBoot helper instead of a hand-rolled route fork. - Trim agentTheme.css to the four consumed tokens (the trimmed rest returns with its consumers and keyframes in later slices), drop the width ref and dead guards from the store, drop the dead shell testid and alias click handler, and merge the async component into the setup block with a complementary landmark role. - New gate composition tests (flag on/off/flip, init race, blocked SDK), a close-button test for the panel root, a legacy-tab-bar gating case, and a real enable/disable transition in the store persistence test.
The cloud E2E run proved the registration fix end to end (the flag-on test passed against the production build) but the flag-off spec timed out awaiting the settle marker: posthog drops false-valued bootstrap flags, so isFeatureEnabled legitimately stays undefined forever when the flag is off and settle only arrived at retry exhaustion (~30s). The retry budget only needs to cover telemetry's init window, so it shrinks to ~5s worst case, exhaustion being the settled fail-closed state, and the spec awaits settle with an explicit window.
Round-2 panel residuals on the gate: readiness now settles on an observed flags delivery OR a definite flag read, the resolved path no longer stacks a second subscription, and the exhausted path re-takes the subscription against the by-now live instance before settling - so a flag that first appears mid-session still propagates instead of waiting for a reload. The unit mock now models the off state the way the real SDK reports it (undefined, never false) and pins the exhausted-then-arrives path. Also: the close button reuses g.close instead of minting a duplicate key, and the store drops the consumer-less open().
…delivery Round-2 panels caught the rework's own regression with the SDK source as receipt: uninitialized posthog invokes the onFeatureFlags callback synchronously with errorsLoading and registers nothing, so the delivered signal fired against a dead subscription and pinned the panel off for the session - the exact race the retry defends. The flag source now filters error-context callbacks before they reach the listener, the unit double models the real pre-init contract (fires once, registers nothing, undefined flags) and the race test asserts a live subscription exists after recovery. The retry constants are exported so tests pace off the real values, the settle window fits inside the cloud project's test timeout with actual headroom, and the E2E mocks drop a hand-rolled auth-token route that shadowed the shared workspace mint.
Eight-hat review round; the convergent findings: - Pass suppressWorkflowReset=false at the two import call sites (importA1111, loadApiJson) - they reset to root with no later workflow-load hash republish, so the armed suppression left the URL on a destroyed subgraph id; pinned by new app tests covering both branches of the clean flag. - Capture the closing workflow's path once at closeWorkflow entry: a rename mid-close mutates workflow.path in place, and the live re-read in the finally would strand a phantom closingWorkflowCounts entry that silently no-ops every future open of that path. - Restore main's last-workflow fallback for an inactive close: the sole open workflow closing while inactive now still creates the default workflow. - Log queued-load failures inside the serialization chain: attaching the internal handler marks the caller's promise handled, which had silenced fire-and-forget failures. - Test hardening: a module-state reset hook with per-test leak assertions, the active-workflow no-op guard pinned from both sides, a reopen-after-close-settles case, the misleadingly named clean-flag test renamed, and a shadowed parameter renamed.
Tree-shaking: the cloud extension block now gates on the literal __DISTRIBUTION__ comparison - the cross-module isCloud const does not dead-code-eliminate, so the gate's posthog-js import was shipping into OSS and desktop bundles (measured +289KB; the localhost build now scans clean and the vendor chunk returns to baseline). The gate's retry/re-take machinery is deleted: the shipped posthog bundle constructs its featureFlags extension in the constructor, so a pre-init subscription registers and survives init() (probe-verified); what remains is the errorsLoading filter, a settle timeout for the no-token path, and a dev force-enable that now honours the ff: localStorage override in both directions. The gate's settle signal moved off document.body onto a store ref bound as a data attribute on the tab-bar actions container, and its constants moved out of extensions/core so nothing new lands on the window.comfyAPI surface. Layout and a11y: the dock width is a proportional cap (min(420px, 33%)) so narrow viewports and the linear arrange panels can no longer be clipped dead; the panel title is a real heading the landmark references via aria-labelledby; borders unify on interface-stroke and the four-token alias theme file is deleted in favour of design-system tokens. Structure: the extension tree flattens to the manager exemplar's shape (stores/, utils/, components/agent/), and the E2E fixture moves to fixtures/ and drives a raw page like the cloud siblings - with the assets mock typed against ListAssetsResponse and the posthog ingest host routed so CI emits no live third-party traffic. Tests: real-contract gate coverage replaces the mock-manufactured race tests, dev force-enable and blocked-import paths are pinned, aria-pressed and the settle attribute are asserted, the graph-side mount invariants are pinned, and the hollow store case is replaced with a writeDefaults pin.
- key the closing-workflow registry by raw workflow object identity - queue default/blank/duplicate loads through the same load queue - bound the close-drain and skip it when no workflow is open - release a failed workflow-load navigation intent and restore the hash - move the workflow-load hash publish into loadGraphData's finally - pin the close-race orderings and the intent release in unit tests
- new-surface mutation battery left this guard undiscriminated: the existing replacement test's interleaving empties the closing window before the shift loop runs - hold the neighbor's close inside the store call so it is still open AND registered at decision time, then assert the fallback lands on the survivor and never the closing neighbor
- a blocked posthog import only reached console.error; it now also calls reportError with the stable agent_flag_gate_load_failure type, so the failure is queryable in Sentry and RUM - fail-closed settling and the dev force-enable are unchanged and both paths pin the report in the gate tests
- swap the store test onto createTestingPinia({stubActions:false})
per the repo's testing-pinia convention
- pin that disabling the flag mid-session never wipes the stored
open preference
- give the async panel root a Suspense fallback so the dock frame
never flashes empty chrome
…w nits - the nav recovery catch and the queued-load catch now also call reportError with stable types (workflow_navigation_failure, workflow_load_failure), keeping each site's redirect and queue-continue behavior - pin that a stale workflow-load publish reapplies the latest graph intent and clears the pending reset suppression (the finally publish is what prevents the suppression leak on a failed load) - detect the default load by its payload, not a missing argument
The Aug-12 review's one Request-Changes gap, still live: closeWorkflow deleted the draft at the top of the try, so a replacement load that fails (which now rethrows) left the tab open with its draft already gone. The draft is removed only after the store close is real, and the regression pin asserts a failed replacement keeps both the tab and the draft.
… source Two comment anchors naming which coordination primitives the ECS per-document milestone deletes and which survive, so the supersession is greppable from the code as well as the decision log and PR body.
Same treatment the crdt files got: every multi-line justification block drops to the one invariant the code cannot show.
A real configure failure is caught inside loadGraphData (dialog, then resolve), so the close path never saw it and deleted the draft of a tab that stayed open over a never-painted graph. loadGraphData now returns an explicit outcome; openWorkflow and loadDefaultWorkflow thread it; closeWorkflow aborts on an explicit failure report through its existing not-closed contract, releasing the load's navigation intent and skipping warnings for a graph that never painted. The regression tests drive the real failure shape: rootGraph.configure throwing, not a mocked rejection.
The docked panel's complementary landmark lost its accessible name while the async panel body loaded; the Suspense fallback now carries a visually-hidden agent-panel-title heading with the same translated string, covered in loading and resolved states. The dock-siblinghood test now mounts the splitter overlay and asserts the rendered structure instead of pinning source text; the linear-mode guard stays a source pin because GraphCanvas cannot mount in the unit environment. The dock width moves from an arbitrary min() to w-1/3 max-w-[420px].
A rejected AgentPanelRoot load left the Suspense fallback up forever with nothing reported. The dock now acts as an error boundary: the failure reaches reportError under agent_panel_load_failure and the panel renders a localized error state that keeps the landmark named. Also drops a non-null assertion in the mount test for optional chaining.
OSS builds now emit no agent chunk and carry no agent code: the dock mounts and tab-bar button sit behind the distribution literal (new useAgentDockMount seam), and the flag gate follows the initTelemetry idiom - the guard lives inside the retained function with every agent module imported dynamically past it, so the dead remainder and its import edges fold away, taking posthog-js with them. Cloud builds inline the gate into the core graph instead of fetching a separate extension chunk, and the panel body chunks load only once the gate enables and the panel opens. Verified by dist scans of both distributions.
The follower doc, wire schema and frame client, mint ports, litegraph mutator and semantic projector, layout follower bridge, op envelope and sender, schema guard, and the dev panel - all flag-gated and inert with no consumer in this slice (activation arrives with the agent stack). Carries the beforeLoadGraph/afterLoadGraph extension hooks, the layoutStore withActor scope, graph traversal support, the four transport prompt-error registrations with their locale entries, the comfy-multi-player dependency with its license-scan exclusion, ADR-0020 and the follower boundary check. Transitional knip entries mark the tree until slices 07+ import it.
…heet - rename ADR 0020 -> 0024 (main already carries 0020-0023), fix its H1, update all references, add the missing README index row - correct the license-exclusion comment: the pinned package declares GPL-3.0-only and ships a LICENSE file - genericize RUN-CLOUD-E2E.md (no internal hosts or names) and note the follower has no mount site until the agent-panel slice - install __agentCrdtPoc only under import.meta.env.DEV - update stale PoC comments; document both load hooks in docs/extensions/core.md including the configure-failure asymmetry
- port the child's graph-load hook test and pin once-each-in-order - pin afterLoadGraph skipped when graph configure fails - cover the four agent prompt-error types in the resolver suite - document beforeLoadGraph/afterLoadGraph pairing on ComfyExtension - dedupe findSubgraphPathById/findSubgraphNodePathById via a shared walk - reject async callbacks in layoutStore.withActor, with a pinning test - exercise the traversal walker's malformed-subgraph guard
- remove the comfy-multi-player license-scan exclusion: the pinned package declares GPL-3.0-only (allowlisted), and keeping the check live guards future pin bumps of a git-ref dependency - render CrdtDevPanel only in dev builds; knip tracks it via ignore instead of entry so unused-export reporting stays live for the tree - reword the ADR and boundary-check lines that asserted an env gate that does not exist on this branch
- correct the afterLoadGraph JSDoc: neither after-hook fires on a configure failure; brackets reset at the next beforeLoadGraph and close on afterConfigureGraph (superset of this hook's cases) - pin the full four-hook load order in the app suite - widen withActor's guard to thenables, report through the assert seam, neutralize the orphaned rejection, and pin actor restoration
- dev panel: init open state and start the poll interval only in dev builds (the render gate alone left prod lifecycle effects running) - symmetric DEV gate on the console-helper teardown delete - ADR: drop the dev-rendered claim, name the stopgap product-flag-gated, future-tense the mount statement - run sheet: point Verify at the dev panel's real testid
…ooks - the guard asserts, not throws: DEV throws, production reports and returns the thenable - say so on the method - the configure-fail test now pins that afterConfigureGraph is also skipped, completing the documented two-hook promise
🎭 Playwright: ✅ 1886 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-01T11:23:29.172Z",
"gitSha": "aa6706a5645fb1f04d7d8e7e7a31ad686a79d8c4",
"branch": "nathaniel/agent-v1/13-history-command-ux",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2097.9300000000194,
"styleRecalcs": 6,
"styleRecalcDurationMs": 7.019000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 711.3380000000001,
"heapDeltaBytes": 4124540,
"heapUsedBytes": 67406736,
"domNodes": -281,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 13.117,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2059.0029999999615,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 617.5740000000001,
"heapDeltaBytes": 3149948,
"heapUsedBytes": 66980828,
"domNodes": -278,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 12.293,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1941.5089999999964,
"styleRecalcs": 81,
"styleRecalcDurationMs": 45.667,
"layouts": 14,
"layoutDurationMs": 5.138999999999999,
"taskDurationMs": 1009.2529999999999,
"heapDeltaBytes": -9618272,
"heapUsedBytes": 60276188,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 156.462,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1922.3739999999907,
"styleRecalcs": 80,
"styleRecalcDurationMs": 47.03699999999999,
"layouts": 14,
"layoutDurationMs": 5.594999999999999,
"taskDurationMs": 967.8499999999999,
"heapDeltaBytes": -9510236,
"heapUsedBytes": 59437176,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 152.269,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.7140000000018,
"styleRecalcs": 30,
"styleRecalcDurationMs": 26.355,
"layouts": 6,
"layoutDurationMs": 1.5659999999999998,
"taskDurationMs": 504.188,
"heapDeltaBytes": 4389560,
"heapUsedBytes": 74746248,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 17.037,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1768.9439999999195,
"styleRecalcs": 30,
"styleRecalcDurationMs": 19.395000000000003,
"layouts": 6,
"layoutDurationMs": 1.378,
"taskDurationMs": 493.491,
"heapDeltaBytes": 4401960,
"heapUsedBytes": 74678964,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 17.270999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 722.9539999999588,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.084,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.74499999999995,
"heapDeltaBytes": 18479744,
"heapUsedBytes": 88407724,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 158.605,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 699.5580000000245,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.521999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.511,
"heapDeltaBytes": 18092924,
"heapUsedBytes": 88308596,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 157.43599999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2161.7160000000126,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.659999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 872.2879999999999,
"heapDeltaBytes": 10293576,
"heapUsedBytes": 85045524,
"domNodes": -272,
"jsHeapTotalBytes": -1646592,
"scriptDurationMs": 50.87699999999999,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2046.2860000000092,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.470000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 749.5550000000001,
"heapDeltaBytes": -13234196,
"heapUsedBytes": 87065776,
"domNodes": -268,
"jsHeapTotalBytes": -1609728,
"scriptDurationMs": 41.741,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2353.8509999999633,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.365,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1697.363,
"heapDeltaBytes": 23181196,
"heapUsedBytes": 88176956,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 781.7650000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2573.20900000002,
"styleRecalcs": 65,
"styleRecalcDurationMs": 12.819999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1783.8919999999998,
"heapDeltaBytes": -14044192,
"heapUsedBytes": 87449304,
"domNodes": -273,
"jsHeapTotalBytes": -1122304,
"scriptDurationMs": 831.434,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 4015.7370000000014,
"styleRecalcs": 60,
"styleRecalcDurationMs": 13.834,
"layouts": 60,
"layoutDurationMs": 16.557000000000002,
"taskDurationMs": 2046.43,
"heapDeltaBytes": 12500524,
"heapUsedBytes": 79784008,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 905.394,
"eventListeners": 10,
"totalBlockingTimeMs": 30,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3737.551000000053,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.878,
"layouts": 60,
"layoutDurationMs": 15.290999999999999,
"taskDurationMs": 1804.981,
"heapDeltaBytes": 11721860,
"heapUsedBytes": 79498524,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 788.528,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3105.173999999977,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.597000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1980.508,
"heapDeltaBytes": 24020956,
"heapUsedBytes": 91501768,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 949.6080000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3162.068999999974,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.607999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2028.1670000000004,
"heapDeltaBytes": 26057876,
"heapUsedBytes": 93404256,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 979.1,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.7819999999538,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.9929999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 707.7970000000001,
"heapDeltaBytes": 21754496,
"heapUsedBytes": 87849004,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.896,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2053.250999999932,
"styleRecalcs": 3,
"styleRecalcDurationMs": 5.153999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 786.524,
"heapDeltaBytes": -14907600,
"heapUsedBytes": 87279528,
"domNodes": -272,
"jsHeapTotalBytes": -1085440,
"scriptDurationMs": 42.69200000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.424000000005,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.562999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.07400000000007,
"heapDeltaBytes": 13623400,
"heapUsedBytes": 85842368,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 150.844,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 732.845999999995,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.205,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.925,
"heapDeltaBytes": 14727380,
"heapUsedBytes": 86987496,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 149.858,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2039.1870000000267,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.268999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 595.8159999999999,
"heapDeltaBytes": -9640744,
"heapUsedBytes": 62286028,
"domNodes": -298,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 14.806,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2015.0049999999737,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.950000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 579.9019999999999,
"heapDeltaBytes": -11971224,
"heapUsedBytes": 60070388,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.796,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1774.6700000000146,
"styleRecalcs": 78,
"styleRecalcDurationMs": 43.925,
"layouts": 18,
"layoutDurationMs": 6.919,
"taskDurationMs": 948.038,
"heapDeltaBytes": -12355924,
"heapUsedBytes": 59868336,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 119.283,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1740.2589999999236,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.633,
"layouts": 18,
"layoutDurationMs": 6.384,
"taskDurationMs": 908.282,
"heapDeltaBytes": -12438064,
"heapUsedBytes": 59586968,
"domNodes": -296,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 115.41,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.5289999998922,
"styleRecalcs": 18,
"styleRecalcDurationMs": 34.609,
"layouts": 14,
"layoutDurationMs": 15.760999999999997,
"taskDurationMs": 1011.725,
"heapDeltaBytes": -9321296,
"heapUsedBytes": 84304724,
"domNodes": 13671,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 32.46300000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9903.133000000025,
"styleRecalcs": 245,
"styleRecalcDurationMs": 40.86300000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6479.459000000001,
"heapDeltaBytes": -7121572,
"heapUsedBytes": 93229372,
"domNodes": -272,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 2861.319,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8898.958999999992,
"styleRecalcs": 246,
"styleRecalcDurationMs": 41.924,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6158.406999999999,
"heapDeltaBytes": -11584536,
"heapUsedBytes": 88580380,
"domNodes": -272,
"jsHeapTotalBytes": -860160,
"scriptDurationMs": 2620.8619999999996,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 18314.184000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18084.684,
"heapDeltaBytes": -46079300,
"heapUsedBytes": 169493016,
"domNodes": -6548,
"jsHeapTotalBytes": 204800,
"scriptDurationMs": 336.236,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18464.643999999906,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18296.261000000002,
"heapDeltaBytes": -25763956,
"heapUsedBytes": 183968048,
"domNodes": -6548,
"jsHeapTotalBytes": -4837376,
"scriptDurationMs": 318.925,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 23459.607000000004,
"styleRecalcs": 174,
"styleRecalcDurationMs": 28.471999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23281.481,
"heapDeltaBytes": -21290420,
"heapUsedBytes": 180713660,
"domNodes": -6548,
"jsHeapTotalBytes": 1769472,
"scriptDurationMs": 977.7079999999999,
"eventListeners": -7467,
"totalBlockingTimeMs": 183,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 23040.678000000073,
"styleRecalcs": 167,
"styleRecalcDurationMs": 25.88600000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22839.655,
"heapDeltaBytes": -39374004,
"heapUsedBytes": 163201236,
"domNodes": -6548,
"jsHeapTotalBytes": 2912256,
"scriptDurationMs": 948.3020000000001,
"eventListeners": -7467,
"totalBlockingTimeMs": 276,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6816.319000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.953,
"layouts": 20,
"layoutDurationMs": 30.70600000000001,
"taskDurationMs": 6771.490999999999,
"heapDeltaBytes": -19299580,
"heapUsedBytes": 190214376,
"domNodes": -5028,
"jsHeapTotalBytes": 7221248,
"scriptDurationMs": 121.044,
"eventListeners": -7469,
"totalBlockingTimeMs": 452,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6731.480000000033,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.68599999999998,
"layouts": 20,
"layoutDurationMs": 26.92599999999999,
"taskDurationMs": 6695.708,
"heapDeltaBytes": -31082636,
"heapUsedBytes": 171628552,
"domNodes": -6548,
"jsHeapTotalBytes": 15499264,
"scriptDurationMs": 131.21899999999997,
"eventListeners": -7469,
"totalBlockingTimeMs": 469,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 105.3829999999607,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.455,
"layouts": 2,
"layoutDurationMs": 0.5149999999999998,
"taskDurationMs": 71.075,
"heapDeltaBytes": 3246272,
"heapUsedBytes": 71326412,
"domNodes": 109,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 6.290999999999998,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 116.98800000010579,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.426000000000002,
"layouts": 2,
"layoutDurationMs": 1.69,
"taskDurationMs": 80.923,
"heapDeltaBytes": 3089920,
"heapUsedBytes": 70309148,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.699,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## nathaniel/agent-v1/12-composer-attachments #16314 +/- ##
==============================================================================
- Coverage 83.26% 83.26% -0.01%
==============================================================================
Files 2024 2024
Lines 117110 117119 +9
Branches 33078 33081 +3
==============================================================================
+ Hits 97514 97520 +6
- Misses 19252 19256 +4
+ Partials 344 343 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 8 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 1 |
| 🟢 Low | 4 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
| renamingId.value = session.id | ||
| renameDraft.value = session.title | ||
| await nextTick() | ||
| const input = renameInputs.value?.[0] |
There was a problem hiding this comment.
🟠 High — reka-ui's DropdownMenuContent restores focus to its trigger when it unmounts after @select, on a later task than this single nextTick, so the just-focused input can be blurred immediately and @blur="cancelRename" tears the editor down before the user can type. The happy-dom test asserting toHaveFocus cannot reproduce that focus restoration, so it does not prove the browser behaviour. Add @close-auto-focus.prevent on DropdownMenuContent (as JobDetailsHoverPopover.vue does) or focus the input after the close settles. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| class="group hover:bg-agent-surface-hover flex items-center gap-2 rounded-sm px-2 py-1" | ||
| > | ||
| <div | ||
| v-if="renamingId === session.id" |
There was a problem hiding this comment.
🟡 Medium — When a session changes bucket mid-rename — the store regroups on a 60s clock so a today row becomes yesterday at midnight, and an activeId change moves a row into current — the row unmounts from one <section> and remounts under another. renamingId/renameDraft survive, so the editor reappears holding the draft but without focus, and because no blur fires for a focused element that is removed, cancelRename never runs either: further keystrokes and Enter are silently dropped. Refocus on remount or close the editor when the row regroups. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).
| :aria-label="t('g.rename')" | ||
| class="text-agent-fg border-agent-accent h-6 min-w-0 flex-1 rounded-lg border px-2 py-1 text-xs outline-none" | ||
| @keydown="onRenameKeydown(session, $event)" | ||
| @blur="cancelRename" |
There was a problem hiding this comment.
🟢 Low — @blur="cancelRename" discards the draft on any focus loss, including a window or tab switch, which browsers report as a blur on the focused element. The inert circle-check icon rendered beside the input also reads as a commit affordance, so clicking it silently throws the typed title away. Committing on blur, as the sibling inline rename in LayerPanel.vue does, would avoid destroying user input with no recovery path. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial).
| <span | ||
| class="text-agent-fg-muted icon-[lucide--circle-check] size-4 shrink-0" | ||
| /> | ||
| <input |
There was a problem hiding this comment.
🟢 Low — The rename input has no maxlength and commitRename only trims, so an arbitrarily long pasted title is emitted upward and copied into the consuming store's localStorage overlay, where a multi-megabyte value can exhaust the origin's storage quota and break persistence of every chat title in that scope. Cap the length on the input, and ideally in the store's rename too. Raised by 3 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).
| /> | ||
| <DropdownMenuItem | ||
| class="text-agent-fg data-highlighted:bg-agent-surface-hover data-highlighted:text-agent-danger flex h-6 w-full shrink-0 cursor-pointer items-center gap-1.5 rounded-lg px-1.5 py-1 text-xs outline-none" | ||
| @select="emit('delete', session.id)" |
There was a problem hiding this comment.
🟢 Low — Delete is emitted straight from a single menu-item select with no confirmation, and it sits directly under Rename in a compact 32px-tall menu, so a mis-click or stray keyboard activation is plausible. The consuming store records the removal as a permanent local tombstone with no undo, making the mistake irrecoverable; add a confirmation step or an undo affordance in the consuming view. Raised by 3 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).
| > | ||
| <span class="icon-[lucide--circle-check] size-4 shrink-0" /> | ||
| <span class="truncate">{{ | ||
| session.title || t('agent.untitledChat') |
There was a problem hiding this comment.
🟢 Low — session.title || t('agent.untitledChat') only falls back for the empty string, so a whitespace-only title renders a row button with a blank label and an empty accessible name. Relatedly, commitRename compares the trimmed draft against the untrimmed session.title, so opening and confirming an unchanged ' Foo ' emits a spurious rename; normalising the title once at this boundary fixes both. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case).
|
|
||
| const renamingId = ref<string | null>(null) | ||
| const renameDraft = ref('') | ||
| const renameInputs = useTemplateRef<HTMLInputElement[]>('renameInput') |
There was a problem hiding this comment.
⚪ Nit — renameInputs.value?.[0] takes the first entry of a v-for template-ref array whose order Vue explicitly does not guarantee, and nothing dedupes ids across the four buckets, so a groups payload repeating an id would render two inputs bound to the same renameDraft with focus landing on whichever mounted first. A function ref (:ref="focusInput", as LayerPanel.vue uses) removes both the index and the nextTick, and makes startRename synchronous so the template handler no longer leaves a floating promise. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| side="bottom" | ||
| align="end" | ||
| :side-offset="4" | ||
| class="agent-scope bg-agent-surface-raised z-1100 flex h-16 w-32 flex-col gap-1 overflow-clip rounded-[10px] p-1 shadow-md ring-1 ring-black/10 ring-inset" |
There was a problem hiding this comment.
⚪ Nit — The menu content is pinned to h-16 with overflow-clip, and p-1 plus two h-6 items plus two gap-1 gaps add up to exactly 64px with zero slack, so any translation wrap or font-metric growth clips the Delete item and makes it unreachable. Let the content size to its children instead of hard-coding the height. Raised by 1 of 8 reviewers (kimi-k3-max adversarial).
The rename editor was torn down by the dropdown restoring focus to its trigger after select, and left orphaned unfocused when a row changed bucket mid-rename, silently dropping keystrokes. A blur also discarded the draft outright, so an ordinary tab switch destroyed typed input. - prevent the dropdown's close-auto-focus so the editor keeps focus - focus via a ref callback so a regrouped row refocuses on remount, selecting only on a fresh open so a remount cannot wipe typed text - commit on blur instead of discarding, matching LayerPanel - trim at the display fallback and the commit compare, so a whitespace-only title keeps an accessible name and an unchanged padded title emits no rename - cap the rename length - let the menu size to its children instead of a fixed height with no slack for translated labels
…ttachments' into hub-13-cascade # Conflicts: # src/locales/en/main.json # src/workbench/extensions/agent/components/agent/ChatHistoryScreen.test.ts # src/workbench/extensions/agent/components/agent/ChatHistoryScreen.vue
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 8 prior finding(s) across 1 round(s) (8 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🔴 Critical | 1 |
| 🟠 High | 5 |
| 🟡 Medium | 3 |
| 🟢 Low | 1 |
Panel: 4/8 reviewers contributed findings.
Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gpt-5.6-sol-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), kimi-k3-max:edge-case (error)
The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:
src/stores/agentNodeSelectionStore.ts:100— 🔴 Critical —enter()snapshotsallow_dragnodes/multi_select/selectOnlyonly afterAgentPanelRoot.onSelectNodeshas already set them to false/true/true, so this restore (plus lines 101-102) writes the picking values back. On the normal send/attach/close pathexitNodeSelectionMode()restores the real values first and then callsexit(), which overwrites them; theisActivewatcher's secondexitNodeSelectionMode()findsnodeSelectionCanvasalready cleared and skips the restore, so the canvas stays select-only and non-draggable until reload. Capture the baseline in one place, before any mutation. Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, gemini-3.1-pro adversarial, gemini-3.1-pro edge-case, kimi-k3-max adversarial).
vite.config.mts:187— 🟠 High —location?.includes('storage.googleapis.com')acceptshttps://storage.googleapis.com.attacker.example/objandhttp://127.0.0.1/?next=storage.googleapis.com, and the fetch below no longer passesredirect: 'manual', so a single 302 can chain the dev server to an arbitrary host (including link-local metadata) and stream the body back to the browser. Parse the URL and requireprotocol === 'https:'andhostname === 'storage.googleapis.com', and restoreredirect: 'manual'. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial, kimi-k3-max adversarial).
src/composables/useCoreCommands.ts:293— 🟠 High — TheisSelectOnlyguards are gone from Clear Workflow, both paste variants, mute/bypass/pin/collapse/resize, group-selected, convert/unpack subgraph, fit-group, move-selected, widget promotion, the subgraph metadata prompts, and the search box, so their keybindings still mutate the graph while the agent has the canvas in pick-only mode — Ctrl+Shift+V creates nodes and Clear Workflow destroys the user's graph from a picking surface. Raised by 3 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, gemini-3.1-pro edge-case).
src/lib/litegraph/src/LGraphCanvas.ts:2489— 🟠 High — TheselectOnlyshort-circuit at the top of_processPrimaryButtonwas removed, so pick-mode pointer input now falls through into the edit paths starting here: alt-drag node cloning, alt-click reroute insertion, the link-marker menu, and bring-to-front reordering all mutate the graph while the canvas is supposed to be a read-only picking surface. The setter at line 450 also no longer resetspointer/linkConnector/resizingGroup, so a drag or wire gesture already in flight when picking is armed completes its mutation on pointerup. Raised by 3 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, gemini-3.1-pro edge-case).
src/utils/graphTraversalUtil.ts:385— 🟠 High —findSubgraphNodePathByIdlost itsancestorsset andfindSubgraphPathByIdlost itsvisitedset, so a subgraph definition that directly or transitively contains an instance of itself is pushed onto the stack forever with an ever-growing path array, hanging the tab on any workflow that carries one. The same rewrite also returns the first match instead of failing closed when one definition has several instances, so an ambiguous definition UUID now resolves to an arbitrary sibling path. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial).
src/workbench/extensions/agent/crdt/layoutMintPort.ts:93— 🟠 High — TheinRootGraphcheck was dropped fromcreateNode/deleteNode/clearGraphminting, so a layout operation on a node inside a subgraph (whosegraphIdis the subgraph UUID) is now minted as a root-document op carrying a subgraph-internal node id, polluting the shared semantic doc with entities that do not exist at root scope. Raised by 3 of 8 reviewers (gemini-3.1-pro adversarial, gemini-3.1-pro edge-case, kimi-k3-max adversarial).
src/lib/litegraph/src/LGraph.ts:646— 🟡 Medium — The deprecatedlast_node_id/last_link_idsetters now assign whatever they are handed,configurerestores the counters with a bareMath.max, andobserveLinkIdlost itsNumber.isIntegercheck. A workflow JSON carrying a string,NaN, or a value at or above the coordination-free mint floor instate.lastNodeId/lastLinkIdtherefore poisons the allocator, and every node or link created afterwards collides on one id — silent graph corruption from a routinely shared file. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max adversarial, gemini-3.1-pro edge-case).
src/utils/markdownRendererUtil.ts:47— 🟡 Medium —href,src,title, andaltare now interpolated raw into double-quoted attributes, so a markdown title or alt text containing a double quote closes the attribute and injects arbitrary ones. Restore the quote-only escape at each interpolation rather than relying on every consumer of this public extension-facing renderer to sanitize its output. Raised by 2 of 8 reviewers (kimi-k3-max adversarial, gemini-3.1-pro edge-case).
| renamingId.value = null | ||
| const title = renameDraft.value.trim() | ||
| if (title !== '' && title !== session.title) emit('rename', session.id, title) | ||
| if (title !== '' && title !== session.title.trim()) |
There was a problem hiding this comment.
🟡 Medium — commitRename never checks that the editor is still open, so a blur that lands after Enter or Escape has already set renamingId = null re-enters the commit path — re-emitting the same rename, or emitting the draft the user just cancelled on browsers that dispatch blur when the focused element is detached. The sibling inline rename in AgentPanel.vue guards this exact handler with if (!renaming.value) return. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case).
| v-model="renameDraft" | ||
| type="text" | ||
| :aria-label="t('g.rename')" | ||
| :maxlength="MAX_TITLE_LENGTH" |
There was a problem hiding this comment.
🟢 Low — maxlength only constrains typing and pasting; it does not truncate a value assigned programmatically, and startRename copies session.title into the draft verbatim. A title already longer than 200 characters (written by an older build or another client) is loaded whole and can be committed back at full length, so the emit boundary still has no cap — enforce the limit in commitRename too. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
christian-byrne
left a comment
There was a problem hiding this comment.
Two unresolved rename-boundary defects remain. Both are scoped to this slice's three-file base-to-head diff.
Full context for agent readers
-
High,
src/workbench/extensions/agent/components/agent/ChatHistoryScreen.vue:93:commitRenamedoes not verify that this session is still being renamed. Enter or Escape first clearsrenamingId; when Vue removes the focused input, Chromium synchronously firesblur, which callscommitRenameagain. Enter can emit the rename twice, while Escape can emit the draft the user explicitly canceled. I reproduced the browser event order askeydown,blur,removed; the component tests run in happy-dom and do not exercise it. Guard the blur path with the active rename id before clearing or emitting. Existing exact-head thread: #16314 (comment) -
Medium,
src/workbench/extensions/agent/components/agent/ChatHistoryScreen.vue:170:maxlengthconstrains user input but does not truncate a value assigned byv-model. A title over 200 characters from an older build or another client is copied intact instartRenameand can cross the emit boundary unchanged in length when whitespace is normalized. Headless Chromium retained all 250 programmatically assigned characters on an input withmaxlength=200. Enforce the cap incommitRename, where the title leaves this component. Existing exact-head thread: #16314 (comment)
No other actionable findings were found in the diff from nathaniel/agent-v1/12-composer-attachments to 80c1b35d468e6b42cf85f07cb95b0d035477043d.
|
Exact-head review is complete: #16314 (review). The program-repo bookkeeping lock timed out twice, so the completion row has been handed to the fleet commander; no duplicate review was posted. Full context for agent readersReadback confirmed a COMMENT review by |
|
This slice is reference-only. Accepted work is routed to #16482 and #16340. Full context for agent readersPer Christian's main-target close ruling, #16314 (13 — history and command UX) is no longer a landing vehicle. It remains readable implementation and review provenance. Rename/focus and panel/state responsibilities are separated. If a genuinely unaccounted delta is found, reopen this source or file a bounded main-based carrier rather than reviving the stacked merge path. |
Slice 13 of the agent-v1 extraction ladder (stacked on #16213).
Extracts the chat history screen from the canonical agent panel (#13892): time-bucketed session list (Current/Today/Yesterday/Earlier), row select/rename/copy/delete actions, empty state, and back navigation. Component lands at canonical bytes; the spec was strengthened in review (15 behavioral tests, two-row identity fixtures, grouping-order and empty-state coverage).
Scope note: row 13's "command history" has no canonical implementation (arrow-key handlers are mention-picker only) - recorded unsatisfied per plan disposition rather than authoring net-new code in an extraction chain.
Review-audit deltas (salvage matrix): items found during the slicing and review audits that did not make it through the integration merge (#16198).
7 artifacts resolved by this slice (1 high severity):