Repository navigation
[agent-v1 14/18] feat(agent): panel shell and extension composition - #16316
CodeJuggernaut wants to merge 15 commits into
Conversation
AgentPanelRoot replaces the slice-00 stub body and composes the landed services and leaf UI: the session composable (now carrying the draft upload/patch/version flow with 409 retry and 5xx fallback), the draft store and getDraft REST surface, chat history, composer, message renderers, and the new panel chrome (PanelHeader, EmptyState, ConversationView, RunNoticeBanner, OnboardingCoach). DockedAgentPanel gains the resizable width, anchor name, and workspace-inset wiring while keeping the chunk-load failure guard and labeled landmark. The panel store moves to stores/agent/ with open and close telemetry, width state, and the preserved gate-settled flag; the core extension registers the workflow tab-activity tracker beside the existing fail-closed flag gate. The CRDT follower is default-off behind followerGate (env, URL param, or persisted opt-in), so the legacy whole-draft apply owns the canvas unless a session opts in. The decomposed panel test lands with the shell.
# Conflicts: # src/components/rightSidePanel/errors/useErrorGroups.test.ts # src/components/rightSidePanel/errors/useErrorGroups.ts # src/composables/canvas/visibleCanvasViewport.test.ts # src/composables/canvas/visibleCanvasViewport.ts # src/locales/en/main.json # src/platform/errorCatalog/promptErrorResolver.ts # src/workbench/extensions/agent/components/agent/AgentPanelRoot.test.ts # src/workbench/extensions/agent/components/agent/AgentPanelRoot.vue # src/workbench/extensions/agent/composables/agent/useAgentSession.test.ts # src/workbench/extensions/agent/composables/agent/useAgentSession.ts # src/workbench/extensions/agent/schemas/agentApiSchema.test.ts
The entry was marked removable once the crdt tree gained a mount site; the real AgentPanelRoot now mounts the dev panel.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 1886 passed, 1 failed · 1 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-01T12:37:22.407Z",
"gitSha": "7c8e0d055403df7353f7390716ffdaceef4da13d",
"branch": "nathaniel/agent-v1/14-panel-shell",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2090.022000000033,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.1049999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.423,
"heapDeltaBytes": -11300188,
"heapUsedBytes": 58250448,
"domNodes": -282,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 9.409999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2005.2100000000337,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.419,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.56100000000004,
"heapDeltaBytes": -9119960,
"heapUsedBytes": 60333844,
"domNodes": -283,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.723999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1765.8270000000016,
"styleRecalcs": 74,
"styleRecalcDurationMs": 33.946,
"layouts": 14,
"layoutDurationMs": 4.495,
"taskDurationMs": 838.2700000000001,
"heapDeltaBytes": -8741972,
"heapUsedBytes": 60759424,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 134.20399999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1801.413000000025,
"styleRecalcs": 76,
"styleRecalcDurationMs": 36.207,
"layouts": 14,
"layoutDurationMs": 4.465,
"taskDurationMs": 858.9259999999999,
"heapDeltaBytes": -8474880,
"heapUsedBytes": 61276812,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 138.716,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.5170000000016,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.657,
"layouts": 6,
"layoutDurationMs": 1.33,
"taskDurationMs": 347.916,
"heapDeltaBytes": 4584100,
"heapUsedBytes": 74209460,
"domNodes": 78,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.248999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.062999999982,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.301999999999996,
"layouts": 6,
"layoutDurationMs": 1.1640000000000001,
"taskDurationMs": 353.944,
"heapDeltaBytes": 4344140,
"heapUsedBytes": 74488120,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.597,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 667.0969999999556,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.015000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.01499999999993,
"heapDeltaBytes": 18098520,
"heapUsedBytes": 88226508,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 152.81900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 641.4480000000822,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.6129999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.7010000000001,
"heapDeltaBytes": 17793856,
"heapUsedBytes": 88077328,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 151.64100000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2035.6380000000058,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.089999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.462,
"heapDeltaBytes": 22226196,
"heapUsedBytes": 87089668,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.218999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.4000000000433,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.008000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 606.9930000000002,
"heapDeltaBytes": 10502960,
"heapUsedBytes": 85893804,
"domNodes": -271,
"jsHeapTotalBytes": -1384448,
"scriptDurationMs": 35.35600000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2154.1260000000193,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.476999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1547.0399999999997,
"heapDeltaBytes": 17736500,
"heapUsedBytes": 83564604,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 790.613,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2113.6390000000347,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.011000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1472.823,
"heapDeltaBytes": 22244240,
"heapUsedBytes": 88084292,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 714.3980000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3397.1160000000395,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.350000000000001,
"layouts": 60,
"layoutDurationMs": 13.677,
"taskDurationMs": 1588.146,
"heapDeltaBytes": 11709704,
"heapUsedBytes": 79090848,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 715.229,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3394.0810000000283,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.466999999999997,
"layouts": 60,
"layoutDurationMs": 13.651,
"taskDurationMs": 1606.706,
"heapDeltaBytes": 8431924,
"heapUsedBytes": 76016936,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 730.98,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3052.8170000000046,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.847000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1861.7810000000002,
"heapDeltaBytes": 22378472,
"heapUsedBytes": 89448744,
"domNodes": -279,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 920.9459999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3060.4700000000093,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.943,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1857.9479999999999,
"heapDeltaBytes": 21933524,
"heapUsedBytes": 89586264,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 917.2,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2006.4030000000344,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.962999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 554.3720000000001,
"heapDeltaBytes": 21850280,
"heapUsedBytes": 87051044,
"domNodes": -272,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.958999999999996,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2015.072000000032,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.199999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 553.842,
"heapDeltaBytes": 21799508,
"heapUsedBytes": 87672112,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.309999999999995,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.7290000000153,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.889,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.451,
"heapDeltaBytes": 13715656,
"heapUsedBytes": 85552328,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 140.061,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 593.3039999999892,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.568000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.362,
"heapDeltaBytes": 13663112,
"heapUsedBytes": 85595724,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.228,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.2540000000226,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.518000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.0570000000001,
"heapDeltaBytes": -9478072,
"heapUsedBytes": 62598104,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.658000000000001,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2029.311000000007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.147,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.88200000000006,
"heapDeltaBytes": -7701248,
"heapUsedBytes": 64277580,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.504000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.8890000000001,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.24400000000001,
"layouts": 18,
"layoutDurationMs": 5.221,
"taskDurationMs": 772.938,
"heapDeltaBytes": 3678676,
"heapUsedBytes": 75403612,
"domNodes": -298,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 96.35400000000001,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1705.3449999999657,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.511,
"layouts": 18,
"layoutDurationMs": 5.886,
"taskDurationMs": 784.129,
"heapDeltaBytes": -12470356,
"heapUsedBytes": 59542844,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 97.21,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1385.1819999999861,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.458,
"layouts": 14,
"layoutDurationMs": 14.213000000000003,
"taskDurationMs": 894.3450000000001,
"heapDeltaBytes": -1693128,
"heapUsedBytes": 95126412,
"domNodes": 13671,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 27.617000000000004,
"eventListeners": 2381,
"totalBlockingTimeMs": 119,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8250.722999999994,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5401.224,
"heapDeltaBytes": 8772340,
"heapUsedBytes": 84609620,
"domNodes": -268,
"jsHeapTotalBytes": -372736,
"scriptDurationMs": 2434.8329999999996,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8258.613999999965,
"styleRecalcs": 246,
"styleRecalcDurationMs": 35.277,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5419.513,
"heapDeltaBytes": -14789092,
"heapUsedBytes": 84974200,
"domNodes": -269,
"jsHeapTotalBytes": -1122304,
"scriptDurationMs": 2389.134,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17845.484999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16949.136,
"heapDeltaBytes": -33606312,
"heapUsedBytes": 176648084,
"domNodes": -6548,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 303.244,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17872.67600000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17084.885,
"heapDeltaBytes": -36338384,
"heapUsedBytes": 174019304,
"domNodes": -6548,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 313.71400000000006,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21641.338000000018,
"styleRecalcs": 172,
"styleRecalcDurationMs": 18.54899999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21378.661,
"heapDeltaBytes": -46775692,
"heapUsedBytes": 162687948,
"domNodes": -6548,
"jsHeapTotalBytes": -4050944,
"scriptDurationMs": 879.3,
"eventListeners": -7469,
"totalBlockingTimeMs": 147,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 21678.714000000014,
"styleRecalcs": 167,
"styleRecalcDurationMs": 18.529000000000018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21341.512000000002,
"heapDeltaBytes": -16649016,
"heapUsedBytes": 186321684,
"domNodes": -6548,
"jsHeapTotalBytes": 2232320,
"scriptDurationMs": 853.392,
"eventListeners": -7471,
"totalBlockingTimeMs": 90,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6310.97699999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.42699999999998,
"layouts": 20,
"layoutDurationMs": 29.679,
"taskDurationMs": 6205.179999999999,
"heapDeltaBytes": -35114164,
"heapUsedBytes": 174620264,
"domNodes": -6548,
"jsHeapTotalBytes": 6696960,
"scriptDurationMs": 159.05399999999997,
"eventListeners": -7471,
"totalBlockingTimeMs": 581,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6330.551000000014,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.13599999999998,
"layouts": 20,
"layoutDurationMs": 25.10499999999999,
"taskDurationMs": 6196.613,
"heapDeltaBytes": -14006236,
"heapUsedBytes": 195444620,
"domNodes": -6548,
"jsHeapTotalBytes": 12201984,
"scriptDurationMs": 111.43,
"eventListeners": -7471,
"totalBlockingTimeMs": 546,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 113.68100000004233,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.276,
"layouts": 2,
"layoutDurationMs": 0.6219999999999999,
"taskDurationMs": 81.66500000000002,
"heapDeltaBytes": 3242428,
"heapUsedBytes": 71128876,
"domNodes": 111,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.088000000000001,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 103.23999999991429,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.934999999999997,
"layouts": 2,
"layoutDurationMs": 0.8370000000000001,
"taskDurationMs": 69.38699999999999,
"heapDeltaBytes": 3217672,
"heapUsedBytes": 70672072,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.837,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## nathaniel/agent-v1/13-history-command-ux #16316 +/- ##
============================================================================
- Coverage 83.26% 83.23% -0.03%
============================================================================
Files 2024 2024
Lines 117119 117423 +304
Branches 33081 33195 +114
============================================================================
+ Hits 97520 97738 +218
- Misses 19256 19332 +76
- Partials 343 353 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 18 files with indirect coverage changes 🚀 New features to boost your workflow:
|
The docking test located the panel body by the stub's data-testid; the real shell exposes the stable #agent-panel-root id instead, and its onboarding coach is a modal that intercepts the close click. Locate the root by id and pre-seed the coach dismissal in the boot fixture, both as the canonical agent suite does. The fixture's relative imports move to the @e2e/ alias the lint gate mandates for files it touches.
Deleting a chat was immediate and irreversible. It now goes through the same confirmation the workflow tab uses, carrying the chat's own title, and declining leaves the thread untouched. The cut's one hand-added guard, which drops out of an apply when loadGraphData resolves false, had no coverage: deleting it left the suite green while a failed load still recorded the draft as applied, fired applied-telemetry, and autosaved the unloaded canvas over the agent's workflow. That path is now pinned. Three inherited one-liners in the panel teardown: the active-tab generation is bumped first, so an in-flight link cannot create a tab and write a file after the panel closes; stop() moves ahead of the throw-capable exit so a raise there cannot leave the session subscribed; and the active-tab chain gains a terminal catch so one rejection cannot poison it. Two comments described behaviour that does not exist at this head - the toast layer is marked but nothing styles it yet, and the follower was never env-gated on this chain - and now say so. Tests: the 409 draft-conflict retry is pinned as bounded to one attempt, the flag gate is shown to settle even when its sibling registration rejects, and copying a non-active history row is pinned to the unavailable notice. The shimmer's animation is asserted in the browser suite, where an engine actually resolves it.
The generation bump added last round was load-bearing and unpinned: deleting it left the suite green while a panel closed mid-create still minted a tab and wrote a file. That path is now driven under fake timers, with the unmount landing inside the 500 ms window, and it fails without the bump. The follower-gate comment described the opposite of this head. The gate arrived with the follower here, so there was never an env-only era to recover from, and the env is what gates it now. The text says that. The shimmer check in the browser suite appends its own element carrying the class, so it pins the stylesheet rule and not the component's use of it. Renamed to say so; the element-to-class half stays where it already lives. Teardown ordering completes what the previous round started: the activity flags now clear before the throw-capable exit rather than after it.
The browser probe pins that the shimmer rule animates; this pins that the rendered thinking element carries the class the rule targets. Together they cover both halves the rider requires.
|
Superseded — closing per Christian's direction.
Full context for agent readersProgram pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs. |
…mmand-ux' into hub-14-step # Conflicts: # browser_tests/tests/agent/agentPanel.spec.ts # knip.config.ts # src/components/rightSidePanel/errors/useErrorGroups.test.ts # src/components/topbar/WorkflowTabs.vue # src/extensions/core/agentPanel.test.ts # src/extensions/core/agentPanel.ts # src/extensions/core/agentPanelGateDependencyFailure.test.ts # src/locales/en/main.json # src/platform/errorCatalog/promptErrorResolver.ts # src/platform/telemetry/types.ts # src/stores/agentNodeSelectionStore.test.ts # src/stores/agentNodeSelectionStore.ts # src/workbench/extensions/agent/AgentPanelRoot.test.ts # src/workbench/extensions/agent/AgentPanelRoot.vue # src/workbench/extensions/agent/README.md # src/workbench/extensions/agent/components/agent/AgentPanelRoot.vue # src/workbench/extensions/agent/components/agent/ConversationView.test.ts # src/workbench/extensions/agent/components/agent/DockedAgentPanel.test.ts # src/workbench/extensions/agent/components/agent/DockedAgentPanel.vue # src/workbench/extensions/agent/composables/useAgentDockMount.test.ts # src/workbench/extensions/agent/crdt/useAgentCrdtFollower.test.ts # src/workbench/extensions/agent/crdt/useAgentCrdtFollower.ts # src/workbench/extensions/agent/schemas/agentApiSchema.test.ts # src/workbench/extensions/agent/stores/agent/agentPanelStore.test.ts # src/workbench/extensions/agent/stores/agent/agentPanelStore.ts
…mmand-ux' into hub-14-step # Conflicts: # browser_tests/tests/agent/agentPanel.spec.ts # src/workbench/extensions/agent/components/agent/Composer.vue
# Conflicts: # browser_tests/tests/agent/agentPanel.spec.ts
christian-byrne
left a comment
There was a problem hiding this comment.
First review coverage on this slice (head f590895, diffed against the slice-13 stack base). The shell/store relocation itself looks clean — no stale importers of the deleted stores/agentPanelStore path found, and the node-selection enter/exit story is complete at this head (banner exit, Escape, workflow-switch, and unmount paths all exit the mode). Five items: one on the follower gate contradiction with the PR body, two session-lifecycle issues, one error-path composition gap, one question.
| @@ -386,7 +451,7 @@ const isBoundWorkflowActive = computed(() => { | |||
| // subscription makes reopening pull state-vector catch-up only after the | |||
| // workflow's serialized activeState has hydrated the transient stores. | |||
| const { status: crdtStatus, enqueueHumanOperations } = useAgentCrdtFollower( | |||
There was a problem hiding this comment.
issue: the PR body describes followerGate as "the default-off switch the panel requires", but nothing consumes it — resolveFollowerEnabled has zero non-test references, and this line mounts useAgentCrdtFollower unconditionally while the follower reports enabled: true hard-coded. As shipped, the CRDT path is always-on whenever the panel mounts (and line 812 then disables the legacy draft application because crdtStatus.value.enabled is always true). Either this call should be behind resolveFollowerEnabled(...) or the default-off claim needs updating — as-is the gate is dead code and the fallback path is unreachable.
| registered = true | ||
|
|
||
| if (!IS_CLOUD_BUILD) return | ||
| useExtensionService().registerExtension({ |
There was a problem hiding this comment.
issue: the previous let registered = false; if (registered) return guard was dropped in the rewrite, and extensionStore.registerExtension throws on a duplicate name (Extension named '...' already registered., extensionStore.ts:63-64). Any second invocation of registerAgentPanelExtension() (HMR, repeated bootstrap, tests sharing a pinia) now throws where it used to no-op. Was losing the guard intentional with the new IS_CLOUD_BUILD idiom, or should it come back inside the retained function?
| tabs = workflow?.tabs?.() | ||
| uploaded = upload !== undefined | ||
| if ( | ||
| initiatingOwner !== sessionGeneration || |
There was a problem hiding this comment.
issue: these ownership checks are what an in-flight sendMessage continuation runs after resolution — but stop() (line 207, unchanged here) never bumps sessionGeneration, so after the panel tears down, initiatingOwner === sessionGeneration still holds and the continuation proceeds to recordUser/startTurn/draft binding/workflow?.adopted(...) against the global stores. The microtask in stop() aborts the active turn, but a POST resolving after that microtask re-creates one on a closed session. Should stop() increment sessionGeneration (mirroring how start() claims ownership) so post-teardown continuations are inert?
| upload !== undefined && | ||
| typeof serverVersion === 'number' | ||
| ) { | ||
| return await post(threadId, { ...upload, version: serverVersion }) |
There was a problem hiding this comment.
issue: the 409 branch's return await post(threadId, { ...upload, version: serverVersion }) re-throws straight out of postTurn's catch — a 5xx on the conflict retry never reaches the error.status >= 500 send-without-draft fallback below it, so the same server failure is recoverable on first send but fatal after version reconciliation. Wrapping the retry (or looping once through the same handler) would make the two recovery paths compose.
| workflow ?? undefined | ||
| ) | ||
| tabActivity.setCreating(false) | ||
| await workflowService.openWorkflow(tab) |
There was a problem hiding this comment.
question (non-blocking): after await workflowService.openWorkflow(tab), a stale() supersession returns without closing the just-created temporary tab, leaving it open in the tab bar. The later stale checks in this chain have the same shape. Is leaving the orphan tab intentional (user may want the content), or should the stale path close the temporary it minted?
The slice carried stale-base copies: WorkflowTabs resurrected the deleted close-button hover rule (breaking four screenshot specs), dropped the agent entry telemetry and creating-tab scroll watch, and pinned the old overflow-observer contract, while the observer kept the narrow element signature. Rebuilt both from main with only the cloud-distribution gate applied; the test stubs the runtime global so the gated entry button still renders under the mocked store.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 4 |
| 🟡 Medium | 5 |
| 🟢 Low | 1 |
Panel: 7/8 reviewers contributed findings.
Reviewers that did not contribute: gpt-5.6-sol-max:edge-case (error)
| }} | ||
| </div> | ||
| <CrdtDevPanel v-if="isCrdtDevPanelEnabled" :status="crdtStatus" /> | ||
| <CrdtDevPanel v-if="crdtStatus.enabled" :status="crdtStatus" /> |
There was a problem hiding this comment.
🟠 High — The dev-overlay gate changed from import.meta.env.DEV to crdtStatus.enabled, and useAgentCrdtFollower reports enabled: true unconditionally, so CrdtDevPanel — whose own docstring says it is not shipped beyond the PoC branch — now renders for every production user who opens the agent panel, exposing copyable doc/workflow ids, the backend proxy target, and a raw outbound-operation log. Gate this on import.meta.env.DEV again, or on a real follower flag, rather than on the follower's status object. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| storage: Pick<Storage, 'getItem' | 'setItem' | 'removeItem'> | null | ||
| } | ||
|
|
||
| export function resolveFollowerEnabled(input: FollowerGateInput): boolean { |
There was a problem hiding this comment.
🟠 High — resolveFollowerEnabled is not imported by any production module — AgentPanelRoot.vue calls useAgentCrdtFollower directly and never consults this gate — so the kill switch that the README and the new VITE_AGENT_CRDT_FOLLOWER typing document has no effect, and the experimental follower is unconditionally on in every build, including the ?agentCrdtFollower=0 path an operator would reach for. It also makes the legacy apply path permanently unreachable (applyDraft returns early on crdtStatus.value.enabled), so loadDraft, arrangeAgentNodes, fitDraftIntoView and both applyDraft watchers are dead code and nothing applies the agent's changes when the doc subscription is refused or offline. Raised by 3 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| await workflowStore.closeWorkflow(tab) | ||
| return | ||
| } | ||
| if (stale()) return |
There was a problem hiding this comment.
🟠 High — The superseded branch no longer closes the tab it just minted (the removed await workflowStore.closeWorkflow(tab)), so a newer agent_active_tab frame or a panel unmount landing during openWorkflow strands an unsaved temporary tab the user never asked for, which will later block close with an unsaved-changes prompt. Worse, autosaveAppliedDraft on the next line runs before the following stale() check, so a superseded activation still writes a workflow file under a server-controlled name and binds it. The new supersede tests only exercise staleness before the tab is minted, so this window is untested. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, kimi-k3-max edge-case).
| const loadFailed = ref(false) | ||
| // Only a failed chunk load is a load failure; runtime errors inside the | ||
| // resolved panel keep their normal propagation. | ||
| const AgentPanelRoot = defineAsyncComponent(() => |
There was a problem hiding this comment.
🟠 High — Hoisting defineAsyncComponent to module scope makes the second docked host mount an already-resolved root synchronously, so the arriving root's setup now runs before the departing root's onBeforeUnmount — the test's maxLive expectation moved from 1 to 2. The departing root then tears down shared, non-instance state the new root just established: stop(), tabActivity.setEditing(null)/setCreating(false), and the CRDT bridge's client.unsubscribe(workflowId) on the shared socket (which the new bridge's reconcile() no-ops past because sentWorkflowId already matches). During the overlap two adapters are bound to the same doc, so any doc_update in that window applies twice. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| ) | ||
| const ack = await post(threadId, undefined) | ||
| uploaded = false | ||
| workflow?.uploadSkipped?.() |
There was a problem hiding this comment.
🟡 Medium — On the 5xx draft-rejection retry, workflow.uploadSkipped() runs resetSnapshotGuard() (nulling snapshotTabPath) and uploaded is set to false, so when the ack arrives with sent === undefined both branches of onWorkflowAdopted are skipped: the turn is accepted and draftStore.bind() runs, but no tab is bound to the minted workflow, isBoundWorkflowActive stays false, and the next agent_active_tab mints a duplicate tab. The same retry also re-POSTs a non-idempotent message with no idempotency key, so a 5xx raised after the first request committed (e.g. at a gateway) creates a duplicate agent turn. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max adversarial).
|
|
||
| async function resyncDraft(): Promise<void> { | ||
| const id = draftStore.workflowId | ||
| if (id === null || resyncing) return |
There was a problem hiding this comment.
🟡 Medium — resyncDraft coalesces on a bare resyncing flag with no trailing re-check, so a draft_version heartbeat that arrives while a getDraft is in flight is dropped outright and the client stays behind until some unrelated later heartbeat or reconnect fires. Because rest.getDraft carries no timeout or abort signal, a hung request also holds the latch for the life of the panel. Re-running the version comparison once in the finally and giving the fetch a timeout closes both gaps. Raised by 4 of 8 reviewers (gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).
| return undefined | ||
| lastSentGraph = serialized | ||
| snapshotTabPath = activePath | ||
| return { content: graph, version: draftStore.version } |
There was a problem hiding this comment.
🟡 Medium — takeWorkflowSnapshot pairs the active tab's serialized graph with draftStore.version, but that version belongs to whichever workflow the draft store is currently bound to, not necessarily the tab being serialized. After switching among bound tabs, workflow B's content is uploaded carrying workflow A's optimistic-concurrency token, producing spurious 409s (whose retry then resubmits the same snapshot at the server's version) or version skew if the server accepts it. Derive the version from the tab being snapshotted, or omit it when the bound workflow doesn't match. Raised by 2 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max adversarial).
| restoreSelectOnly = undefined | ||
| if (!canvas.selectedItems.size) return | ||
| if (!canvas?.selectedItems.size) return | ||
| canvas.deselectAll() |
There was a problem hiding this comment.
🟡 Medium — exit() dropped its if (!isActive.value) return guard, so any call while the mode was never entered falls straight through to canvas.deselectAll()/updateSelectedItems() and wipes the user's existing canvas selection; NodeSelectionModeBanner calls exit() directly and its <Transition> keeps the button in the DOM for the 150ms leave, so a second click lands after isActive is already false. enter() lost the mirror guard too, so a repeated call re-runs frameForPicking() and animates the viewport mid-pick. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
| import('@/workbench/extensions/agent/AgentPanelRoot.vue').catch( | ||
| (error: unknown) => { | ||
| reportError(error, { errorType: 'agent_panel_load_failure' }) | ||
| loadFailed.value = true |
There was a problem hiding this comment.
🟡 Medium — loadFailed is a module-scoped ref that is only ever set to true, and the rejected import is cached for the page, so a single transient chunk-load failure (offline blip, CDN 5xx, stale chunk after a deploy) pins the panel to the error state until a full reload — the previous per-instance defineAsyncComponent({ errorComponent, onError }) retried the import on each remount. The throw error also escapes a <Suspense> that has no onErrorCaptured boundary and no errorComponent, so the same failure is reported twice: once here and once through the global app error handler. Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| reportError(error, { | ||
| errorType: 'agent_cloud_workflow_ids_refresh_failed' | ||
| }) | ||
| console.warn('[agent] could not refresh cloud workflow ids', error) |
There was a problem hiding this comment.
🟢 Low — Downgrading reportError(error, { errorType: 'agent_cloud_workflow_ids_refresh_failed' }) to console.warn makes this failure invisible to both Sentry and RUM, and it is not benign: on failure cloudIdsByName silently keeps its previous contents, so cloudIdFor/boundTabFor/openTabsSnapshot keep resolving tabs through a stale name→id map and the turn omits or mis-attributes workflow_id/open_tabs/current_tab. Per src/AGENTS.md this should stay a reportError with a stable errorType. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).
christian-byrne
left a comment
There was a problem hiding this comment.
Re-review at 79ba411f5ed3749b432a57f8601c7cd907fee5c7: not ready. None of the five prior human threads is addressed at this head, and the exact-head pass confirms eight additional distinct issues after deduplicating the follower-gate and stale-tab findings. The two red E2E statuses are one underlying viewport-restoration failure, not two independent failures.
Full context for agent readers
Prior-thread follow-through:
| Prior thread | Status | Exact-head evidence |
|---|---|---|
AgentPanelRoot.vue:453, follower gate |
Unresolved | resolveFollowerEnabled still has no production caller; useAgentCrdtFollower still mounts unconditionally and returns enabled: true. Corroborated by the exact-head gate finding. |
agentPanel.ts:14, duplicate registration |
Unresolved | registerAgentPanelExtension() still calls registerExtension() without the former idempotency guard. |
useAgentSession.ts:304, teardown generation |
Unresolved | stop() still does not advance sessionGeneration, so a POST that resolves after teardown still passes the continuation's ownership check. |
useAgentSession.ts:274, 409 retry composition |
Unresolved | The 409 retry still returns directly from the catch; a 5xx from that retry still bypasses the send-without-draft fallback. |
AgentPanelRoot.vue:731, superseded temporary tab |
Unresolved | The stale branch after openWorkflow(tab) still returns without closing the temporary tab. Corroborated by the exact-head stale-tab finding. |
Additional exact-head findings, ordered by severity:
- High,
AgentPanelRoot.vue:1321: the PoCCrdtDevPanelis now exposed whenever the always-enabled follower mounts, including production. - High,
DockedAgentPanel.vue:58: module-scoped async-component resolution permits overlapping roots, allowing the departing root to tear down shared state established by the arriving root. - Medium,
useAgentSession.ts:283: send-without-draft clears the snapshot binding inputs, so the accepted workflow can remain unbound and later mint a duplicate tab. - Medium,
useAgentSession.ts:118:resyncDraft()drops version heartbeats received while its single in-flight request is pending. - Medium,
AgentPanelRoot.vue:365: the active tab's graph is paired with the globally bound draft store's version, which can belong to another workflow. - Medium,
agentNodeSelectionStore.ts:170:exit()is no longer idempotent and can clear the user's selection when selection mode is already inactive. - Medium,
DockedAgentPanel.vue:62: one transient chunk-load failure permanently sets module-scopedloadFailed, preventing remount retry until a full page reload. - Low,
AgentPanelRoot.vue:271: cloud-workflow ID refresh failures were downgraded fromreportErrortoconsole.warn, making stale identity-map failures invisible to Sentry and RUM.
CI classification: the failing shard and e2e-status aggregate both trace to Keeps viewport settings when changing tabs, where the canvas snapshot does not restore after returning to Workflow A. The test file is not changed by this slice, but the slice does change WorkflowTabs.vue and its tab-selection behavior, so this cannot be classified as inherited from the available evidence. Treat it as PR-relevant until a green rerun or a root-cause disposition proves otherwise. The cancelled Cursor edge-case job is tooling capacity, while the consolidated exact-head Cursor review completed successfully.
Scope reviewed: the 43-file slice diff against base 80c1b35d468e6b42cf85f07cb95b0d035477043d, the post-f590895 commits, all 15 review threads, exact-head checks, and the Playwright report artifact for run 33507447589.
|
This slice is reference-only. Accepted work is routed to #16340, #16477, and #16488. Full context for agent readersPer Christian's main-target close ruling, #16316 (14 — panel shell and composition) is no longer a landing vehicle. It remains readable implementation and review provenance. Panel runtime, browser regression, and inset responsibilities are separated. If a genuinely unaccounted delta is found, reopen this source or file a bounded main-based carrier rather than reviving the stacked merge path. |
Slice 14 of the agent-v1 extraction ladder (stacked on #16314).
Extracts the panel shell and extension composition from the canonical agent panel (#13892): the real AgentPanelRoot (replacing slice 00's stub body) composing the landed services with the leaf UI (AgentPanel, ConversationView, PanelHeader, EmptyState, RunNoticeBanner, OnboardingCoach), the panel store at its canonical path (width/maximize/telemetry), the workflow-draft data path (draft store, schema and REST additions, session draft flow with 409/5xx handling), the tab-activity tracker service, the follower gate (default-off switch the panel requires), node-selection state (pure store; canvas consumers ride slice 16), and 28 agent locale keys plus 2 error-catalog entries. 25 files land byte-identical to canonical; deviations preserve chain review hardening and are itemized in the cut record.
User-facing consequence, stated plainly: the existing cloud/flag-gated topbar entry now opens the real panel in place of slice 00's stub - conversation, composer, history, onboarding, resize. The gate and its registration are unchanged; slice 17 still owns the remaining activation wiring. Node-selection mode is enterable from the composer but its banner/exit control rides slice 16 (successive stack lands 16 before rollout).
Known-inherited from the base branch: two unit-test failures in AgentMessage/MessageFeedback (present on #16213 before this branch existed) and the tabled screenshot family.
Review-audit deltas (salvage matrix): items found during the slicing and review audits that did not make it through the integration merge (#16198).
20 artifacts resolved by this slice (3 high severity):