Repository navigation
[agent-v1 09/18] feat(agent): transcript persistence - chat history store - #16206
CodeJuggernaut wants to merge 9 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1888 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-01T11:22:38.142Z",
"gitSha": "2d7ea4945c124fc1ea57296948cbb8a20b580668",
"branch": "nathaniel/agent-v1/09-transcript-persistence",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2121.959000000004,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.123999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 598.026,
"heapDeltaBytes": -967560,
"heapUsedBytes": 69027960,
"domNodes": -279,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 14.136,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2035.7399999999188,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.667000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.5289999999999,
"heapDeltaBytes": -12616980,
"heapUsedBytes": 57158672,
"domNodes": -282,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.362000000000004,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2124.3939999999952,
"styleRecalcs": 80,
"styleRecalcDurationMs": 51.856,
"layouts": 14,
"layoutDurationMs": 5.7330000000000005,
"taskDurationMs": 1136.345,
"heapDeltaBytes": -9211880,
"heapUsedBytes": 59763428,
"domNodes": -283,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 171.663,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1956.6449999999804,
"styleRecalcs": 76,
"styleRecalcDurationMs": 43.59,
"layouts": 14,
"layoutDurationMs": 5.059,
"taskDurationMs": 973.96,
"heapDeltaBytes": -9851076,
"heapUsedBytes": 60307504,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 157.29299999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1747.8270000000293,
"styleRecalcs": 30,
"styleRecalcDurationMs": 20.782000000000004,
"layouts": 6,
"layoutDurationMs": 1.454,
"taskDurationMs": 455.25499999999994,
"heapDeltaBytes": 4446364,
"heapUsedBytes": 74020556,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.394,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.0450000000565,
"styleRecalcs": 32,
"styleRecalcDurationMs": 20.915999999999997,
"layouts": 6,
"layoutDurationMs": 1.3770000000000002,
"taskDurationMs": 411.67300000000006,
"heapDeltaBytes": 4466376,
"heapUsedBytes": 74455640,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 14.708999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 718.5820000000263,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.306,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.08699999999993,
"heapDeltaBytes": 18413360,
"heapUsedBytes": 88257544,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 167.999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 735.2110000000494,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.493,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 509.32,
"heapDeltaBytes": 18430788,
"heapUsedBytes": 87768892,
"domNodes": 12,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 165.13699999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2070.7859999999982,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.875000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 764.6100000000001,
"heapDeltaBytes": -13787716,
"heapUsedBytes": 86855748,
"domNodes": -271,
"jsHeapTotalBytes": -823296,
"scriptDurationMs": 45.29999999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2047.3899999999503,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.8390000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 764.783,
"heapDeltaBytes": -13559456,
"heapUsedBytes": 86741052,
"domNodes": -272,
"jsHeapTotalBytes": -1609728,
"scriptDurationMs": 40.275000000000006,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2646.168999999986,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.413000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1798.914,
"heapDeltaBytes": -16742612,
"heapUsedBytes": 84643344,
"domNodes": -274,
"jsHeapTotalBytes": -860160,
"scriptDurationMs": 812.037,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2746.2699999999813,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.389999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1780.987,
"heapDeltaBytes": 27692996,
"heapUsedBytes": 93484184,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 838.617,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3982.8980000000342,
"styleRecalcs": 60,
"styleRecalcDurationMs": 12.339999999999996,
"layouts": 60,
"layoutDurationMs": 15.057999999999998,
"taskDurationMs": 1910.9060000000002,
"heapDeltaBytes": 8478692,
"heapUsedBytes": 75364112,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 824.71,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3833.472000000029,
"styleRecalcs": 60,
"styleRecalcDurationMs": 12.1,
"layouts": 60,
"layoutDurationMs": 14.399000000000001,
"taskDurationMs": 1858.7359999999999,
"heapDeltaBytes": 11715488,
"heapUsedBytes": 79177872,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 805.7829999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3182.3409999999512,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.149000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2066.3740000000003,
"heapDeltaBytes": 21942408,
"heapUsedBytes": 89144516,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1006.4009999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3186.0560000000078,
"styleRecalcs": 40,
"styleRecalcDurationMs": 9.478999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2164.643,
"heapDeltaBytes": 26482176,
"heapUsedBytes": 93061244,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1033.6680000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2012.9370000000222,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.9790000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 729.067,
"heapDeltaBytes": 21852176,
"heapUsedBytes": 87076508,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.357000000000006,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2010.6859999999642,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.882000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 659.7,
"heapDeltaBytes": 22126704,
"heapUsedBytes": 87756484,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.588,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 686.2979999999652,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.225999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.353,
"heapDeltaBytes": 14357112,
"heapUsedBytes": 86030004,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 150.80200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 634.535000000028,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.96,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.007,
"heapDeltaBytes": 14752988,
"heapUsedBytes": 87148184,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 143.16899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2053.674000000001,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.815999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.604,
"heapDeltaBytes": -12913844,
"heapUsedBytes": 58216312,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.411,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2049.205000000029,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.544,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 628.9429999999999,
"heapDeltaBytes": -10378144,
"heapUsedBytes": 61880836,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.401000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1807.0200000000227,
"styleRecalcs": 78,
"styleRecalcDurationMs": 45.973,
"layouts": 18,
"layoutDurationMs": 6.611999999999999,
"taskDurationMs": 947.218,
"heapDeltaBytes": 1005928,
"heapUsedBytes": 73070348,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 123.093,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1853.8760000000138,
"styleRecalcs": 81,
"styleRecalcDurationMs": 48.35399999999999,
"layouts": 18,
"layoutDurationMs": 6.864,
"taskDurationMs": 988.0659999999999,
"heapDeltaBytes": -11598716,
"heapUsedBytes": 60075792,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 121.683,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1466.3069999999152,
"styleRecalcs": 19,
"styleRecalcDurationMs": 32.598,
"layouts": 15,
"layoutDurationMs": 15.637000000000002,
"taskDurationMs": 1089.262,
"heapDeltaBytes": -3591324,
"heapUsedBytes": 93188856,
"domNodes": 13671,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 36.14899999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 131,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9174.093999999968,
"styleRecalcs": 246,
"styleRecalcDurationMs": 44.284000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6337.041,
"heapDeltaBytes": -10470804,
"heapUsedBytes": 89580332,
"domNodes": -270,
"jsHeapTotalBytes": -892928,
"scriptDurationMs": 2748.485,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8779.109000000062,
"styleRecalcs": 249,
"styleRecalcDurationMs": 46.172999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6114.559,
"heapDeltaBytes": 14129456,
"heapUsedBytes": 88418924,
"domNodes": -270,
"jsHeapTotalBytes": -634880,
"scriptDurationMs": 2623.741,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18916.14100000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18725.595,
"heapDeltaBytes": -34352188,
"heapUsedBytes": 175165448,
"domNodes": -6548,
"jsHeapTotalBytes": -8028160,
"scriptDurationMs": 363.126,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18771.121999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18504.86,
"heapDeltaBytes": -36300696,
"heapUsedBytes": 173799224,
"domNodes": -6548,
"jsHeapTotalBytes": -5361664,
"scriptDurationMs": 350.202,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 24554.088999999978,
"styleRecalcs": 180,
"styleRecalcDurationMs": 31.820000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 24468.077999999998,
"heapDeltaBytes": -25845228,
"heapUsedBytes": 183807800,
"domNodes": -6548,
"jsHeapTotalBytes": -2809856,
"scriptDurationMs": 1041.554,
"eventListeners": -7467,
"totalBlockingTimeMs": 174,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 23964.292,
"styleRecalcs": 180,
"styleRecalcDurationMs": 26.105999999999963,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23791.699999999997,
"heapDeltaBytes": -14507100,
"heapUsedBytes": 195598372,
"domNodes": -6548,
"jsHeapTotalBytes": 4210688,
"scriptDurationMs": 929.005,
"eventListeners": -7469,
"totalBlockingTimeMs": 388,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6935.85900000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.54500000000003,
"layouts": 20,
"layoutDurationMs": 31.68,
"taskDurationMs": 6900.640000000001,
"heapDeltaBytes": -18699424,
"heapUsedBytes": 183669504,
"domNodes": -6548,
"jsHeapTotalBytes": 17567744,
"scriptDurationMs": 134.503,
"eventListeners": -7469,
"totalBlockingTimeMs": 475,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6900.274999999965,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.09000000000005,
"layouts": 20,
"layoutDurationMs": 27.885999999999996,
"taskDurationMs": 6856.367,
"heapDeltaBytes": -48951796,
"heapUsedBytes": 161150392,
"domNodes": -6548,
"jsHeapTotalBytes": 1912832,
"scriptDurationMs": 132.99,
"eventListeners": -7469,
"totalBlockingTimeMs": 472,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 122.09699999993973,
"styleRecalcs": 6,
"styleRecalcDurationMs": 17.015,
"layouts": 2,
"layoutDurationMs": 0.8859999999999999,
"taskDurationMs": 90.87899999999999,
"heapDeltaBytes": 3243252,
"heapUsedBytes": 71667316,
"domNodes": 110,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 7.837000000000001,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 113.06999999999334,
"styleRecalcs": 6,
"styleRecalcDurationMs": 15.093,
"layouts": 2,
"layoutDurationMs": 0.9000000000000002,
"taskDurationMs": 78.45600000000002,
"heapDeltaBytes": 3229140,
"heapUsedBytes": 71201064,
"domNodes": 106,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.9060000000000015,
"eventListeners": 51,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## nathaniel/agent-v1/08-session-state #16206 +/- ##
=======================================================================
+ Coverage 83.25% 83.26% +0.01%
=======================================================================
Files 2022 2023 +1
Lines 117063 117099 +36
Branches 32470 33064 +594
=======================================================================
+ Hits 97460 97506 +46
+ Misses 19250 19249 -1
+ Partials 353 344 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 5 |
| 🟢 Low | 4 |
Panel: 8/8 reviewers contributed findings.
|
Automated fleet review (desktop operator, Christian-authorized)
Full context for agent readersDesign-review packet — FE PR #16206 (agent-v1 09/18, transcript persistence)Lane: pr16206-review (Class A, report-only — program/parallelization-middle-ground.md). 0. Code-fact header
Diff read directly via 1. What the PR actually doesAdds one Pinia store and its Vitest suite, nothing else:
Surface:
Imports of CRDT internals: zero. The diff contains no 2. Alignment with our design surfaces2.1 CRDT / stamps — N/A, and cleanly soOur stamp question (scalar-v1 vs the Lamport-merged integration candidate, comfy-multi-player main Rebase exposure to the integration candidate is likewise nil: both files are net-new paths 2.2 ADR-006 (
|
| Wire (authoritative) | ChatSession |
Consequence |
|---|---|---|
title (string, may be empty) |
title: string |
— |
preview (required; "shown when title is empty") |
absent | An untitled thread renders blank; the spec's mandated fallback is unrepresentable in the store's type. |
status: active | archived |
absent | Server-archived threads are indistinguishable from active ones; the local tombstone set is a second, divergent delete concept layered over a server one that already exists. |
updated_at (RFC3339 string) |
updatedAt: number (epoch ms) |
An unstated adapter must parse at the boundary. There is no parse/validate step and no test for one; a bad or empty value yields NaN, every >= comparison is false, and the row silently sinks to Earlier rather than erroring. last_message_at is explicitly "Empty when unset" in the spec — so the NaN path is reachable with legal server data if the caller ever maps that field. |
workflow_id, message_count, last_message_at, created_at |
absent | Fine to omit for this slice; noted for the adapter's shape. |
Also from the same spec block: the endpoint is keyset-paginated, newest-created first,
default limit 20. Two design consequences the store does not yet answer:
replaceAllis total replacement with no append/merge affordance. A "load more" caller that
callsreplaceAllper page collapses history to the last page; the caller must accumulate.
The store should own that, since it also owns the tombstone filter.- The store buckets by
updated_atwhile the server pages by created-at. Page boundaries and
displayed buckets are therefore not aligned — a thread updated today can sit on page 5, so
"Today" is only complete once every page is fetched. That is a product decision, not a bug,
but it is currently implicit.
This is drift of exactly the kind ADR-017 was written to kill on the doc-frame side (OpenAPI
authoritative, generated types, freshness CI). ADR-017's letter covers doc_update / doc_reset /
doc_ops_result only, so this is not an ADR-017 violation — but the same failure mode, on a
route whose schema is already authored and authoritative.
2.3 Local persistence of user content — new ground, no precedent to inherit
The FE currently uses useLocalStorage for exactly two keys, both pure UI layout
(Comfy.MenuPosition.Docked / .Floating). No existing FE key persists per-account user
content metadata. So Comfy.Agent.ChatTitles and Comfy.Agent.DeletedThreads are the first of
their class, and there is no established scoping convention for this slice to have followed —
which makes the scoping choice a design decision this slice is making, not one it inherits.
Both keys are browser-global: no workspace id, no user id, no rotation, no logout hook. ADR-006's
security posture is "tenant identity comes only from the authenticated caller"; here, chat titles
(user-authored content) and tombstones survive logout and are read by the next account on the same
browser profile. The nat-watch chamber already staged this as a privacy inline comment at
agentChatHistoryStore.ts:55-59 (READY-TO-POST, exact head 628c7147); this packet confirms
it against ADR-006 rather than restating it. Cross-account tombstone misapplication needs an id
collision and server ids look minted, so the leak (titles) is the live half, the misapply the
theoretical half.
ADR-008 is not implicated: it governs the CRDT substrate's durable ownership (agent-owned embedded
SQLite under ComfyUI's user dir), not FE presentation metadata. No conflict.
2.4 Structural growth bound — worth naming explicitly
rename writes an override for any id, including one with no session (the suite's
whitespace-rename case runs against an empty store). Neither map is ever pruned. The obvious prune
— drop overrides for ids absent from the server list — is unsafe precisely because the list is
paginated: absent-from-page-1 ≠ deleted. So unbounded key growth here is structural, a
consequence of overlay-plus-pagination, not an oversight to be patched later. It gets bounded only
when the server owns rename/delete. Per #79 (private alpha) I am not asking for a migration or any
back-compat path; the ask is that the growth bound be stated, not engineered.
The premise behind the overlay checks out: the ingest route table
(services/ingest/server/server.go:679-686) registers create/list threads, post/get/cancel
messages, and answer-ask — and no rename or delete route. The BE-3130 rationale in the code
comment is accurate as of this workspace's cloud checkout.
3. Risk classing
| Axis | Classing |
|---|---|
| Shipped vs dev-only | Not reachable today. Zero importers of agentChatHistoryStore across the entire main...09-transcript-persistence range (219 changed files scanned via the compare API at head 628c7147). No component, composable, or store references it. |
| Bundle impact | Zero at present. An unimported Pinia store module is tree-shaken out; it enters the bundle only when a later slice mounts it (~111 lines of source, no new dependency — useLocalStorage/useTimestamp are existing @vueuse/core usage). |
| Feature gating | None in this diff, and none needed yet — nothing mounts it. The gating obligation lands on the slice that adds the caller, and must satisfy the 2026-08-28 #frontend invariant (agent entry points stay feature-gated), coordinated with the /features pipeline in #16208. Flagging forward, not against this PR. |
| CI | 11 failing checks at head (e2e-status, mobile-chrome, 9 chromium shards). Strict subset of base #16204's 12 — set difference 16206 \ 16204 is empty; 16204 \ 16206 is playwright-tests (cloud). Zero new failures introduced. Unit/typecheck/lint green. |
| Blast radius if merged as-is | Dead code on a draft stack. The account-scoping and NaN paths cost nothing until a caller exists — which is also why fixing them now is cheap. |
| CRDT risk | None. See §2.1. |
4. Verdict — MERGE-AFTER-CHANGES
Direction is right and the slice is honestly scoped: a pure grouping function with a real
suite, an overlay explicitly justified by a missing backend route, and no reach into transcript,
turn, graph, or doc state. The dossier's warning that it must not become a second session
authority is respected — it holds no messages and no thread lifecycle.
Four changes, in severity order. All are pre-caller, so all are cheap now and expensive later:
- Scope the two localStorage keys to the authenticated workspace/user, and clear or rotate on
account change. ADR-006 tenancy; first-of-class persistence with no convention to inherit
(§2.3). This is the one item that is a genuine defect rather than a seam gap. Already staged as
a COMMENT inline by nat-watch — do not double-post. - Type the store's input off
AgentThreadSummaryrather than hand-declaring it, or state in
the file thatChatSessionis a deliberate view model and name the adapter that produces it —
including howupdated_at(RFC3339) becomesupdatedAt(epoch ms) and what happens when it
does not parse. A NaNupdatedAtcurrently sinks a row to Earlier in silence (§2.2). - Decide
previewandstatusnow, in the type. Emptytitleis a legal server value with a
spec-mandatedpreviewfallback, andarchivedis a server-side state that the local tombstone
set silently shadows. Both are unrepresentable inChatSessiontoday. - Give
replaceAlla pagination story — append/merge, or a comment stating that the caller
accumulates pages before calling it, plus a note that "Today" is complete only after full
pagination (§2.2).
Not asked for, deliberately: any migration or back-compat path (#79, private alpha); a timezone
policy beyond the local-day implementation shown; E2E coverage (no mount exists to drive — the
dossier's VAL-HISTORY-04 BLOCKED discipline is correct).
Minor, non-blocking: useTimestamp({ interval: 60_000 }) in a store scope installs an
app-lifetime 1/min tick once the store is first used; harmless, worth knowing before it lands in a
panel that stays mounted.
Not CONFLICTS-WITH-OUR-DESIGN. Nothing here contradicts an accepted ADR. §2.2 is drift against
an authoritative schema and §2.3 a tenancy gap — both correctable inside the slice's own shape.
5. Merge path
Does not fold into #97, and needs no packet of its own.
- Add tests on litegraph search box triggering events #97 is the ruling on FE chore(crdt): v2 integration candidate with package pin fix #16198, the v2 CRDT-follower integration candidate (trailer-strip
rewrite authorization; DEFAULT-IF-NO-ANSWER Option B, 2026-08-30 18:00Z). Slice 09 is CRDT-null
and shares no path with the adapter surface, so the chore(crdt): v2 integration candidate with package pin fix #16198 merge decision neither gates nor is
gated by it. Folding it in would only dilute a ruling that is already scoped. - Slice 09 rides Nathaniel's own stack (base [agent-v1 08/18] feat(agent): session and state coordination - thread, turn, cancellation #16204 → [agent-v1 07/18] feat(agent): control plane - REST client, event schemas, turn transport #16188 → main) and is squash-merged by him
per the PR's stated landing rule. Nothing in it requires a Christian ruling, so it is not
Class C — no enumerated-options packet is warranted (R5: no lane-created human-queue items). - The entire delivery is the already-staged nat-watch COMMENT review at
reports/nathaniel-watch/chamber/2026-08-29-pr16206.md(exact head628c7147, READY-TO-POST).
Items 2–4 above are new relative to that chamber draft; the operator's call is whether to fold
them into that same COMMENT before posting or let them ride to the slice that adds the caller.
Recommendation: fold item 2 in (it is the same one-line-of-code moment as item 1 and the
cheapest possible time to fix a wire-contract mismatch); leave 3 and 4 for the caller slice,
where they are decidable against real UI. - Cross-repo note, no action requested here: if
AgentThreadSummaryis meant to be projected into
FE types the way ADR-017 projects doc frames, that is a program-level decision about the agent
route family, not a slice-09 change.
6. Method / compliance
- COR-8 quarantine honored: reviewed the PR's code against our ADRs,
plans/technical-design.md,
and the authoritative cloud OpenAPI only. Nathaniel's Notion decision log (linked from the PR
body) and the Linear tickets were not opened. PR-body claims (extraction fidelity, blind
re-extraction, mutation verification) are recorded as author assertions, not verified here —
verifying them would require the quarantined snapshot. - R2: checked
reports/audit/verified-state.mdfirst. Its only overlapping row (Lamport-merged
comfy-multi-player main8636af3e) was consumed, not re-verified. The feat(crdt): make the debug panel a first-class instrument #16209 E2E-subset row is a
different PR and was not reused for [agent-v1 09/18] feat(agent): transcript persistence - chat history store #16206 — §3's subset claim is independently established. - R4: no worktree added;
gh pr diff+ compare API + existing workspace checkouts only. - Single-writer: this file is the only artifact written. Per the lane's explicit "touch no other
report", the new verified-state rows are staged below for the operator rather than appended
directly — sibling packets for [agent-v1 08/18] feat(agent): session and state coordination - thread, turn, cancellation #16204/[agent-v1 10/18] feat(agent): text and tool message renderers #16210/[agent-v1 11/18] feat(agent): message composites and media rendering #16211/[agent-v1 12/18] feat(agent): composer input and attachments #16213 may be running concurrently against
the same ledger.
Staged rows for reports/audit/verified-state.md (operator to append)
| Fact | Verified at (SHA/state) | Date (Z) | Lane/actor |
|---|---|---|---|
| FE #16206 diff is CRDT-null (no yjs/op_id/stamp/doc-frame refs) and both files are net-new paths absent from FE main | PR head 628c7147bf72; contents/...stores/agent?ref=main → 404 |
2026-08-29 | pr16206-review |
agentChatHistoryStore has zero importers across main...nathaniel/agent-v1/09-transcript-persistence (219 files) — dead code, tree-shaken, zero bundle impact |
compare API @ 628c7147bf72 |
2026-08-29 | pr16206-review |
#16206 failing-check set is a strict subset of base #16204's (11 ⊂ 12; only playwright-tests (cloud) extra on base) — zero new failures |
gh pr checks both PRs @ 628c7147bf72 / 1b129dff |
2026-08-29 | pr16206-review |
| Ingest exposes no thread rename/delete route (create/list threads, post/get/cancel messages, answer-ask only) — BE-3130 overlay premise confirmed | cloud/services/ingest/server/server.go:679-686, workspace checkout |
2026-08-29 | pr16206-review |
AgentThreadSummary (9 required fields, updated_at RFC3339 string, preview fallback, status active/archived) is the authoritative history-sidebar row |
cloud/services/ingest/openapi.yaml:12251 |
2026-08-29 | pr16206-review |
FE persists only 2 useLocalStorage keys, both UI layout — no precedent for per-account content metadata in browser storage |
FE checkout src/, 2026-08-29 |
2026-08-29 | pr16206-review |
Merge-readiness scorecard
Slice 09 merge-readiness scorecard
PR: Comfy-Org/ComfyUI_frontend#16206 — transcript persistence
Observed: 2026-08-30 at head 628c7147bf722f8867c21a4404199a4a6d4ab700
Overall verdict: NEEDS-CHANGES — all four review items remain absent from the unchanged PR head; the PR is also draft, red, and waiting for slices 03–08.
Score: 2.5/7 (PASS or accepted discretion = 1; PARTIAL = 0.5; FAIL/BLOCKED = 0)
03 -> 04 -> 05 -> 06 -> 07 -> 08 -> [09] -> 10 -> 11 -> 12 -> main
^
waits for every left-hand slice
| gate | status | evidence |
|---|---|---|
| Review verdict | FAIL (0/1) | The review packet says MERGE-AFTER-CHANGES. None of its four items is on live head 628c7147: (1) account/workspace-scope local storage, (2) use a named AgentThreadSummary adapter with timestamp validation, (3) retain preview/archive state, and (4) define paginated accumulation. All four exist only in the detached, verified patch series. |
| Flag-off safety | PASS (1/1) | The slice audit is CLEAN: this is a dormant Pinia store with no global registration, mount, CSS, route, or listener. It satisfies issue #149's user-facing-strict standard without a discretionary waiver. |
| CI on current head | FAIL (0/1) | Live gh pr checks at 628c7147: 89 pass, 11 fail, 22 skip. Red: e2e-status, mobile Chrome, and Chromium shards 2, 3, 4, 6, 7, 8, 10, 14, and 15. The review showed this set is inherited from slice 08, but inherited red is still not green. |
| Conflict with declared base | PASS (1/1) | GitHub reports MERGEABLE against nathaniel/agent-v1/08-session-state@1b129dff; no merge conflict. mergeStateStatus=BLOCKED is policy/check state. |
| Draft and retarget-to-main readiness | BLOCKED (0/1) | Still draft. FEH-4 requires bottom-up restacking after the reconciled candidate and slices 03–08. Direct retarget to main would bypass its predecessor and is not ready. |
| Test coverage | PARTIAL (0.5/1) | The PR has one focused store suite covering grouping/order, rename, tombstones, active removal, local-day behavior, and persistence recreation. Unit/type/lint were green in the review. The history UI is not mounted at this slice, so browser coverage for list rendering, rename/delete/refresh, pagination, and account switching is correctly unproven. |
| Open blockers | BLOCKED (0/1) | Apply the four review fixes; green current-head CI; preserve owner control of draft state; then wait for slices 03–08, including parallel rp-1 packets for 03–07. The G1 Linear matrix also leaves this slice's union-preview history interactions unverified. |
Merge decision
Do not merge or retarget now. Reproduce the four prepared fixes when slice 09 is restacked onto the
landed slice 08, then run the store suite, composed history UI tests, and full CI.
Provenance and glossary
Sources: live GitHub metadata/checks, internal review and patch packets, mr-1, FEH-4, and the current
G1 Linear checkpoint. No quarantined Nathaniel design document or Linear design narrative was read.
- History overlay — browser-local title and deletion metadata layered over server thread rows.
- Pagination — fetching thread history in pages rather than as one complete list.
- Declared base — slice 08, the branch GitHub currently compares this PR against.
rp-1— the separate review lane for slices 03–07.
1b129df to
e425af1
Compare
3c6c4f9 to
ca644f2
Compare
faf10c8 to
bf2ca92
Compare
- thread listing with recency grouping over the server's titles - rename overlay and delete tombstones cover the endpoints the server does not expose yet
DEFECT-FIX T1 (agentChatHistoryStore.test.ts): the persistence property was unpinned - all nine shipped tests stayed green with useLocalStorage swapped for a plain ref. New pin walks a rename and a tombstone across the pinia re-instantiation boundary in the sibling idiom (agentRunModeStore's save / nextTick / createPinia round-trip). Receipt: mutant-red - the ref-swap turns exactly the new pin red while the nine shipped tests stay green. DEFECT-FIX T2: the newest-first assertion could not fail - the input literal was already sorted. The literal now leads with earlyToday so input order differs from expected order; expected values unchanged, timezone-independent. Receipt: mutant-red - removing the sort turns the today-bucket assertion red. T3 (director ruling, honest minimum): the spring-forward test name claimed DST discrimination it does not have (the transition postdates the computed boundary in every timezone); renamed to what it proves. startOfLocalDay's DST behavior at the yesterday boundary stays unpinned - recorded in the round delivery and boarded to the chain tail with the TZ-mechanism gap. Notes - Store blob 5ce2253 untouched (hash-verified before and after).
ca644f2 to
80f67f2
Compare
(cherry picked from commit 323b682)
|
Superseded — closing per Christian's direction.
Full context for agent readersProgram pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs. |
…ate' into hub-09-cascade # Conflicts: # src/workbench/extensions/agent/stores/agent/agentChatHistoryStore.test.ts # src/workbench/extensions/agent/stores/agent/agentChatHistoryStore.ts
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 9 prior finding(s) across 1 round(s) (9 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 8 |
| 🟢 Low | 1 |
Panel: 5/8 reviewers contributed findings.
Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gpt-5.6-sol-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error)
The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:
src/lib/litegraph/src/linkDeduplication.ts:219— 🟠 High — Termination of the rewrittenwhiledepends on every failing pass either incrementingsuccessfulPassesor growingskipped, but whenmovedis emptyblocked.length ? blocked : movedadds nothing andcontinuerepeats the identical pass forever — reachable once every remaining link is already skipped or aligned andupdateEndpointsstill rejects the unchangedremovals. The oldfor (let pass = 0; pass < Math.max(1, referencedNames.size); pass++)+breakcould not spin; bound the loop by total attempts, orbreakwhenmoved.length === 0 && !result.ok. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
src/lib/litegraph/src/linkDeduplication.ts:168— 🟡 Medium — The loop bound changed fromMath.max(1, referencedNames.size)towhile (successfulPasses < referencedNames.size), so a node whose referenced input names have all disappeared (emptyreferencedNames) never enters the body and theremovalscollected fromlinks_to_removeare never disconnected — those links stay registered and dangling after configure. TheMath.max(1, ...)in the old bound existed precisely to guarantee that one pass. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
src/workbench/extensions/agent/crdt/docFrameClient.ts:105— 🟡 Medium —atob()throwsInvalidCharacterErroron malformed base64, andparseServerDocFrameruns inside theapicustom-event listener installed byDocFrameClient, so a truncated relay frame or a hostileupdate_b64escapes as an uncaught error out of the socket dispatch instead of being dropped like every other unparseable payload. Wrap the decode in try/catch and returnnull. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, gemini-3.1-pro adversarial, kimi-k3-max adversarial).
src/workbench/extensions/agent/crdt/ecsFollowerAdapter.ts:244— 🟡 Medium —applyQueuedFrameclears the session's pending node/widget/link effects at line 221 and only then callssession.mutations.batch(...), whose boolean is discarded. If validation fails (e.g. aconnectreferencing a missing node) the Yjs update is already integrated into the follower doc while the ECS stores never receive that frame's effects, andapplyFramestill reports success — a silent, permanent divergence until adoc_reset. Read the result and either re-queue the effects or trigger a resync. Raised by 2 of 8 reviewers (kimi-k3-max adversarial, kimi-k3-max edge-case).
src/workbench/extensions/agent/composables/agent/useAgentSession.ts:52— 🟡 Medium —Comfy.Agent.ThreadIdis origin-global andstart()rehydrates it for whatever account is active. UnlikeagentChatHistoryStore, which this PR now scopes by user/workspace and clears whenstorageScopechanges, nothing scopes this key or resets the conversation store at that boundary — an in-place account or workspace switch leaves the previous account's thread id persisted and its transcript on screen. Scope the key the same way and reset the conversation at the same boundary so the fix is complete. Raised by 1 of 8 reviewers (kimi-k3-max adversarial).
src/workbench/extensions/agent/crdt/layoutFollowerBridge.ts:190— 🟡 Medium —lastSeqis advanced beforeapplyRemoteUpdateruns, so ifY.applyUpdatethrows on corrupt bytes the sequence tracker has already moved past a frame that never integrated; the gap detector then treats the next frame as contiguous and the missed content is silently lost until an explicitdoc_reset. AdvancelastSeqonly after the apply succeeds. Raised by 1 of 8 reviewers (kimi-k3-max adversarial).
src/workbench/extensions/agent/components/agent/message/ReplyAssetGroup.vue:83— 🟡 Medium — This watcher auto-fetches any URL an LLM reply classified as a 3D asset and hands it togenerateModelThumbnail, which fetches that arbitrary origin, parses it through Three.js/WebGL, and persists the render viapersistThumbnail(assetName, blob)under a name taken straight from the untrusted URL (classifyAssetUrlreads it from?filename=, so../../evil.glbis reachable). Restrict auto-generation to first-party API URLs and sanitize the persisted name. Raised by 1 of 8 reviewers (kimi-k3-max adversarial).
apps/website/src/lib/markdown-twin.ts:32— 🟡 Medium — PuttingHEADERinDROPPED_TAGSremoves every<header>, including ones nested inside<main>that carry a page's H1, eyebrow, and introduction — that content disappears from the generated twin, and the test fixture only exercises a<header>-free<main>, so nothing catches it. Drop page-level banners only (e.g. a<header>outside<main>) rather than the tag wholesale. Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).
apps/website/src/lib/markdown-twin.ts:125— 🟡 Medium — An anchor may validly contain block content, andinline()inserts\n\naround descendant<div>/<p>elements, so this line wraps text containing blank lines in[...];.trim()strips only the edges and a Markdown link cannot span a blank line, so card-style links (title + description inside the<a>) render as malformed text and lose their destination. Collapse interior whitespace in the link text before wrapping. Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).
src/platform/workflow/templates/composables/useTemplateWorkflows.ts:159— 🟢 Low — This reverts theresponse.okguard, so a non-2xx template response is fed straight intor.json(): an HTML error page from a stale pinned template package now surfaces as a genericSyntaxErrorinstead of the descriptive "not served by this install (status)" error that distinguished a bad pin from a bad template, and a JSON error body is handed toapp.loadGraphDataas if it were a workflow. The guard was independent of the seeding feature being reverted and is worth keeping. Raised by 2 of 8 reviewers (kimi-k3-max adversarial, kimi-k3-max edge-case).
christian-byrne
left a comment
There was a problem hiding this comment.
Re-review at e1163eef: one medium finding.
Prior round: all 9 threads are resolved; 3 fixes remain present and 6 were explicitly dispositioned as non-blocking. Review scope was this slice against nathaniel/agent-v1/08-session-state@7f63109b; findings from the wider stacked chain were excluded.
Full context for agent readers
Prior-thread follow-through
| Prior thread | Status at current head | Evidence |
|---|---|---|
titleFor overlay contract |
Resolved, intentionally non-blocking | The API still deliberately returns only the custom-title overlay; the caller falls back separately. |
replaceAll stale active ID |
Addressed | replaceAll now clears activeId when the retained list no longer contains it; the regression test covers absent and retained IDs. |
| Malformed persisted shapes | Addressed | Both local-storage values now use validating serializers, with malformed-shape coverage. |
| Account/workspace storage isolation | Addressed, with one follow-up finding below | Keys now include resolved user and workspace identity, and in-memory history clears on scope rotation. |
| Deleting the open session | Resolved by the later integration seam | onDeleteHistory now calls onNewChat() when the deleted ID is the open thread, which clears persisted session state. |
| Prototype-key hardening | Resolved, intentionally non-blocking | Server-generated thread IDs remain the stated contract; no new regression was introduced. |
| Storage-write failure semantics | Resolved, intentionally non-blocking | The local tombstone remains best-effort pending a server-backed lifecycle. |
| Overlay/tombstone growth | Resolved, intentionally non-blocking | Lifecycle pruning remains deferred to server-backed rename/delete behavior. |
| Cross-tab tombstone visibility | Resolved, intentionally non-blocking | The accepted behavior remains temporary visibility until the next refresh. |
New-delta review
Reviewed all 7 changed files (+297/−44) against the declared stacked base. The transcript extraction preserves sequence ordering, stable turn identity, row-ID reconciliation, and the existing conversation hydration behavior. The only new actionable issue is attached inline.
CI at this head is green for the slice-relevant test, lint-and-format, and e2e-status checks. This was a static review; I did not claim a new local runtime test.
| watch( | ||
| storageScope, | ||
| () => { | ||
| sessions.value = [] |
There was a problem hiding this comment.
issue: The scope watcher clears the old account's sessions, but no consumer observes that scope change to fetch the new account's history. AgentPanelRoot calls refreshHistory() only on mount and after selecting a row; the store test even pins the post-switch state as empty. This is observable on the API-key auth path, where clearStoredApiKey() changes identity without reloading the page: after another key signs in, the panel remains mounted and history stays empty until a remount. Could the identity/workspace boundary also trigger a fresh listThreads() after the scoped refs rotate?
|
This slice is reference-only. Accepted work is routed to #17324 and #16406. Full context for agent readersPer Christian's main-target close ruling, #16206 (09 — transcript persistence) is no longer a landing vehicle. It remains readable implementation and review provenance. Runtime and permanent-test responsibilities are separated. If a genuinely unaccounted delta is found, reopen this source or file a bounded main-based carrier rather than reviving the stacked merge path. |
Merge after: #16204 (08) - stacked on its branch per the successive-stack chain.
Decisions: Agent V1 Decision Log
Landing strategy: SQUASH-MERGE ONLY - owner order 2026-08-28 (branch-history containment; do not merge-commit).
Summary
Slice 09 of the agent-v1 chain: the transcript data model's past-chat persistence seam - the chat-history store (session grouping, rename overlay, delete tombstones) with its suite. The row's normalization and message-identity clauses landed with slices 07/08; this slice carries persistence. Census vs merge-base: 2 files, +254.
Changes
agentChatHistoryStoreand its test, extracted from the reviewed integration snapshot; one review-driven fix round added test pins only.Review Focus
Linear tickets
Review-audit deltas (salvage matrix): items found during the slicing and review audits that did not make it through the integration merge (#16198).
The audit found no review artifacts missing from main in this territory; the diff is the reviewed transcript-persistence delta vs the integration copy.