Repository navigation
[agent-v1 10/18] feat(agent): text and tool message renderers - #16210
CodeJuggernaut wants to merge 14 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1890 passed, 0 failed📊 Browser Reports
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-01T11:22:36.082Z",
"gitSha": "f636cdc88624caa653ada1b8703b467e0389fa05",
"branch": "nathaniel/agent-v1/10-message-renderers",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2102.5750000000016,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.001000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 716.9040000000001,
"heapDeltaBytes": -1595552,
"heapUsedBytes": 61467772,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 14.196999999999997,
"eventListeners": -189,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2088.5489999999436,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.127999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 562.229,
"heapDeltaBytes": -12409988,
"heapUsedBytes": 57697384,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.970000000000004,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1835.5409999999779,
"styleRecalcs": 74,
"styleRecalcDurationMs": 37.829,
"layouts": 14,
"layoutDurationMs": 4.552,
"taskDurationMs": 932.855,
"heapDeltaBytes": -9158996,
"heapUsedBytes": 60448672,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 158.812,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.0610000000597,
"styleRecalcs": 79,
"styleRecalcDurationMs": 40.275000000000006,
"layouts": 14,
"layoutDurationMs": 4.502,
"taskDurationMs": 899.829,
"heapDeltaBytes": -10178524,
"heapUsedBytes": 59705624,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 157.289,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.607999999952,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.854000000000003,
"layouts": 6,
"layoutDurationMs": 1.0430000000000001,
"taskDurationMs": 405.602,
"heapDeltaBytes": 3807996,
"heapUsedBytes": 68125164,
"domNodes": 77,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 14.776000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.6879999999346,
"styleRecalcs": 33,
"styleRecalcDurationMs": 19.886999999999997,
"layouts": 6,
"layoutDurationMs": 1.2309999999999999,
"taskDurationMs": 411.33900000000006,
"heapDeltaBytes": 4432348,
"heapUsedBytes": 73999788,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 14.479999999999997,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 709.8159999999893,
"styleRecalcs": 13,
"styleRecalcDurationMs": 10.493,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.553,
"heapDeltaBytes": 18356940,
"heapUsedBytes": 87964648,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 165.999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 664.248999999927,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.345,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.60800000000006,
"heapDeltaBytes": 18690212,
"heapUsedBytes": 87668116,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 160.67700000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2062.1260000000348,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.375,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 681.847,
"heapDeltaBytes": -13043628,
"heapUsedBytes": 87046344,
"domNodes": -270,
"jsHeapTotalBytes": -1609728,
"scriptDurationMs": 38.083000000000006,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2088.0200000000286,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.618999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 692.8539999999999,
"heapDeltaBytes": -13541844,
"heapUsedBytes": 86686716,
"domNodes": -267,
"jsHeapTotalBytes": -1609728,
"scriptDurationMs": 35.841,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2439.8969999999736,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.769999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1703.994,
"heapDeltaBytes": 22823976,
"heapUsedBytes": 88991180,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 831.1460000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2192.2649999999066,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.606000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1578.9110000000003,
"heapDeltaBytes": 17651076,
"heapUsedBytes": 83652948,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 779.538,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3690.620000000024,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.056,
"layouts": 60,
"layoutDurationMs": 12.254000000000001,
"taskDurationMs": 1791.4080000000001,
"heapDeltaBytes": 8022132,
"heapUsedBytes": 75297304,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 783.885,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3504.485000000045,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.374,
"layouts": 60,
"layoutDurationMs": 11.342,
"taskDurationMs": 1622.7160000000001,
"heapDeltaBytes": 11694628,
"heapUsedBytes": 79442500,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 746.08,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3166.763000000003,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.013999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1997.1509999999998,
"heapDeltaBytes": 21039592,
"heapUsedBytes": 90645796,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 975.366,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3032.6630000000705,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.642,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1844.679,
"heapDeltaBytes": 21163564,
"heapUsedBytes": 88520200,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 914.524,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2054.2560000000094,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.881,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 620.817,
"heapDeltaBytes": -14818368,
"heapUsedBytes": 86891144,
"domNodes": -268,
"jsHeapTotalBytes": -823296,
"scriptDurationMs": 34.556000000000004,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2030.033000000003,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.4689999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 647.965,
"heapDeltaBytes": -14571000,
"heapUsedBytes": 87620712,
"domNodes": -271,
"jsHeapTotalBytes": -1085440,
"scriptDurationMs": 39.04299999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 646.681000000001,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.602999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.635,
"heapDeltaBytes": 14812712,
"heapUsedBytes": 86991564,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 152.604,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.5630000000037,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.431000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.61499999999995,
"heapDeltaBytes": 13686392,
"heapUsedBytes": 85703772,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 144.333,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.10300000002,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.125,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.264,
"heapDeltaBytes": 8430080,
"heapUsedBytes": 73670312,
"domNodes": -296,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.536,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2020.6450000000586,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.719999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.737,
"heapDeltaBytes": 730276,
"heapUsedBytes": 72754948,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.380000000000003,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.2790000000055,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.580000000000005,
"layouts": 18,
"layoutDurationMs": 5.114999999999999,
"taskDurationMs": 911.4100000000001,
"heapDeltaBytes": -12647160,
"heapUsedBytes": 58359240,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 118.197,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.93300000004,
"styleRecalcs": 78,
"styleRecalcDurationMs": 35.57,
"layouts": 18,
"layoutDurationMs": 4.818999999999999,
"taskDurationMs": 829.7719999999999,
"heapDeltaBytes": -12225920,
"heapUsedBytes": 59859080,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 110.67899999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.777000000001,
"styleRecalcs": 16,
"styleRecalcDurationMs": 31.433000000000003,
"layouts": 12,
"layoutDurationMs": 15.252999999999998,
"taskDurationMs": 989.5660000000001,
"heapDeltaBytes": -7353952,
"heapUsedBytes": 85915864,
"domNodes": 13671,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.124,
"eventListeners": 2381,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9360.853000000021,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.225,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6196.284,
"heapDeltaBytes": 9543244,
"heapUsedBytes": 84638388,
"domNodes": -270,
"jsHeapTotalBytes": 118784,
"scriptDurationMs": 2725.536,
"eventListeners": -165,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8841.301999999927,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.885,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5987.105,
"heapDeltaBytes": 10092468,
"heapUsedBytes": 85122332,
"domNodes": -269,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 2678.513,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17491.032000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16892.556,
"heapDeltaBytes": -36909692,
"heapUsedBytes": 174750556,
"domNodes": -6548,
"jsHeapTotalBytes": 2039808,
"scriptDurationMs": 285.13700000000006,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17114.458000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16699.491,
"heapDeltaBytes": -34313132,
"heapUsedBytes": 175709432,
"domNodes": -6548,
"jsHeapTotalBytes": -6307840,
"scriptDurationMs": 288.47999999999996,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21038.456,
"styleRecalcs": 161,
"styleRecalcDurationMs": 20.27000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20754.595999999998,
"heapDeltaBytes": -44804020,
"heapUsedBytes": 162466704,
"domNodes": -6548,
"jsHeapTotalBytes": -8306688,
"scriptDurationMs": 905.038,
"eventListeners": -7469,
"totalBlockingTimeMs": 140,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21319.428000000014,
"styleRecalcs": 166,
"styleRecalcDurationMs": 17.836999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20937.605,
"heapDeltaBytes": -37429628,
"heapUsedBytes": 166403108,
"domNodes": -6548,
"jsHeapTotalBytes": -5050368,
"scriptDurationMs": 913.177,
"eventListeners": -7471,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6299.547000000019,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.61100000000005,
"layouts": 20,
"layoutDurationMs": 23.54500000000001,
"taskDurationMs": 6162.152,
"heapDeltaBytes": -29544816,
"heapUsedBytes": 180254416,
"domNodes": -6548,
"jsHeapTotalBytes": 10309632,
"scriptDurationMs": 111.78099999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 367,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6360.381000000075,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.86399999999999,
"layouts": 20,
"layoutDurationMs": 23.94,
"taskDurationMs": 6248.344999999999,
"heapDeltaBytes": -33464220,
"heapUsedBytes": 175631176,
"domNodes": -6548,
"jsHeapTotalBytes": 5615616,
"scriptDurationMs": 163.235,
"eventListeners": -7469,
"totalBlockingTimeMs": 419,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 106.02300000005016,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.81,
"layouts": 3,
"layoutDurationMs": 1.005,
"taskDurationMs": 78.24499999999999,
"heapDeltaBytes": 3243408,
"heapUsedBytes": 70846312,
"domNodes": 110,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.442000000000002,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 106.65199999994002,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.408000000000001,
"layouts": 2,
"layoutDurationMs": 0.8320000000000001,
"taskDurationMs": 75.621,
"heapDeltaBytes": 3155504,
"heapUsedBytes": 70819952,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.562000000000001,
"eventListeners": 51,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## nathaniel/agent-v1/09-transcript-persistence #16210 +/- ##
================================================================================
- Coverage 83.26% 83.26% -0.01%
================================================================================
Files 2023 2025 +2
Lines 117099 117133 +34
Branches 33064 33076 +12
================================================================================
+ Hits 97506 97527 +21
- Misses 19249 19262 +13
Partials 344 344
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 7 |
| 🟢 Low | 2 |
Panel: 8/8 reviewers contributed findings.
|
Automated fleet review (desktop operator, Christian-authorized)
Full context for agent readersPR #16210 — design-review packet (slice 10/18, message renderers)Lane: pr16210-review (Class A, report-only). Date: 2026-08-29. VERDICT: MERGE-AFTER-CHANGES (4 enumerated below; none are CRDT-design conflicts). 1. What the PR actually doesPure presentational leaf slice. Adds three message-rendering surfaces and one lookup service under
Stores/surfaces touched: none. No Pinia store, no router, no extension registration, no CRDT internals imported: zero. Full import census across the four source files: The author's own claim that these components have zero importers at this tip is consistent with 2. Alignment with our ADRsNo contact surface with the CRDT design. Checked against
scalar-v1 vs Lamport stamps — not applicable. The Rebase risk is textual, not semantic. Four of the eleven files are the highest-churn shared One design-doc adjacency, resolved in the PR's favour. Inherited ADR-017 drift (flag, do not block this PR). ADR-017 makes generated OpenAPI types the 3. Risk classingShipped surface, currently inert. Not dev-only: the files live under Feature-gating: absent in this PR, and correctly so. The agent panel gate is a separate concern Bundle impact: the one material risk. Duplicate dependency tree. Security: adequate. Correctness carry-over (already staged, do not duplicate). The stale-highlight race — Not blocking, worth noting: 4. VerdictMERGE-AFTER-CHANGES
Not conditions, but endorsed as-is: the Explicitly NOT a verdict of CONFLICTS-WITH-OUR-DESIGN. The PR neither implements nor contradicts Merge pathFolds into the existing slice-chain path (#16204 → #16206 → #16210 → #16211 → #16213); no separate Two items it introduces are not slice-local and should be attached to the unruled #97
Recommendation only — the operator files it (R5). Verified-state candidates (NOT appended by this lane)Single-writer discipline says I own only this file; five review lanes are running concurrently and
SourcesOur design only, per COR-8 quarantine: Merge-readiness scorecardSlice 10 merge-readiness scorecardPR: Comfy-Org/ComfyUI_frontend#16210 — text and tool message renderers
Merge decisionDo not merge or retarget now. Apply/recreate the patch series on the eventual restack, ensure the Provenance and glossarySources: live GitHub metadata/checks, internal review and patch packets, mr-1, FEH-4, and the current
|
628c714 to
3c6c4f9
Compare
16fe0e9 to
023fb92
Compare
3c6c4f9 to
ca644f2
Compare
023fb92 to
6eae48b
Compare
ca644f2 to
80f67f2
Compare
- code blocks with lazy shiki highlighting and a plain escaped fallback (shiki joins the workspace catalog) - tool-call cards and grouping with reasoning and duration rows - the tool glyph map pairing each tool's label key and icon - renderer strings land with their consumers; the tool-grouping spec for the message container follows with that component
6eae48b to
84b33db
Compare
|
Superseded — closing per Christian's direction.
Full context for agent readersProgram pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs. |
…-persistence' into hub-10-cascade # Conflicts: # browser_tests/tests/agent/agentPanel.spec.ts # pnpm-lock.yaml # pnpm-workspace.yaml # src/locales/en/main.json # src/workbench/extensions/agent/components/agent/AgentPanelRoot.vue # src/workbench/extensions/agent/components/agent/message/CodeBlock.test.ts # src/workbench/extensions/agent/components/agent/message/CodeBlock.vue # src/workbench/extensions/agent/components/agent/message/ToolCallCard.vue # src/workbench/extensions/agent/components/agent/message/ToolCallGroup.test.ts # src/workbench/extensions/agent/components/agent/message/ToolCallGroup.vue
…nderers' into hub-10-cascade
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 10 prior finding(s) across 1 round(s) (10 never answered).
Found 4 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟢 Low | 3 |
Panel: 3/8 reviewers contributed findings.
Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gemini-3.1-pro:adversarial (error), gpt-5.6-sol-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gpt-5.6-sol-max:edge-case (error)
| const OPEN_STORAGE_KEY = 'Comfy.AgentPanel.open' | ||
|
|
||
| export const useAgentPanelStore = /* @__PURE__ */ defineStore( | ||
| 'agentPanel', |
There was a problem hiding this comment.
🟠 High — This file registers defineStore('agentPanel', ...) with a gate-only shape while stores/agent/agentPanelStore.ts already owns that id with the full panel shape (width, setWidth, toggleMaximize, and the open/close telemetry). Pinia keys by id, so whichever setup runs first wins for every consumer regardless of which module imported it — the exact failure stores/agent/agentPanelStoreId.test.ts was added to pin, where width is undefined, visibleCanvasViewport computes NaN into ds.scale/ds.offset, and toggleMaximize throws. It is only latent because the sole importer, components/agent/AgentPanelRoot.vue, is dead code this same PR knip-ignores; delete both rather than shipping two definitions of one store id.
Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
| ) | ||
| const thoughtSeconds = computed(() => { | ||
| const ms = thoughts.value.reduce( | ||
| (sum, thought) => sum + (thought.durationMs ?? 0), |
There was a problem hiding this comment.
🟢 Low — thoughtSeconds copies the ?? 0 fold and ms > 0 threshold from totalSeconds, so a group mixing timed and untimed parts presents a partial subtotal as the duration for all of them, while a set of genuinely-zero durations takes the untimed branch even though each row still renders 0.0s. Test the individual durationMs values for undefined instead of thresholding the sum — the same applies to the per-row aggregation in rows.
Re-raised from round 1, never answered by the author; originally raised by 2 of 8 reviewers (gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max edge-case).
| open.value = stayOpen | ||
| isActive, | ||
| (activeNow) => { | ||
| open.value = activeNow |
There was a problem hiding this comment.
🟢 Low — Splitting the failure reopen into its own watch(failed, ...) fixed that half, but this watcher still assigns open on every isActive transition, so a group the user expanded mid-turn snaps shut the moment the turn goes inactive. Track a user-override flag and skip the assignment once the user has toggled the group by hand.
Re-raised from round 1, never answered by the author; originally raised by 3 of 8 reviewers (claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).
| type="button" | ||
| class="text-agent-fg-subtle hover:bg-agent-surface hover:text-agent-fg border-agent-border-strong flex items-center gap-1 rounded-sm border px-2 py-0.5 font-mono text-xs transition-colors" | ||
| class="hover:bg-background hover:text-foreground border-border flex items-center gap-1 rounded-sm border px-2 py-0.5 font-mono text-xs text-muted-foreground transition-colors" | ||
| @click="copy(code)" |
There was a problem hiding this comment.
🟢 Low — copy(code) is a floating promise and VueUse does not catch internally, so a rejected navigator.clipboard.writeText (document not focused, permission denied, non-secure context) escapes to the global unhandled-rejection handler while copied never flips, leaving the user with no indication the copy failed. Handle the rejection, surface a failure state, and report it via reportError().
Re-raised from round 1, never answered by the author; originally raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial).
christian-byrne
left a comment
There was a problem hiding this comment.
One additional coverage regression found. Prior round: 7 addressed, 1 partially addressed, 2 deferred. Four new Cursor threads remain open, including the duplicate Pinia store-id blocker.
Full context for agent readers
Reviewed exact head afa5a9b4be against stacked base nathaniel/agent-v1/09-transcript-persistence only. The functional CI suite on this head is green; six Cursor model jobs were cancelled, while the consolidated Cursor review completed and opened four threads.
Prior-thread follow-through
| Prior thread | Status at current head | Evidence |
|---|---|---|
| Mixed thought/tool summary | Addressed | Tool summaries now take precedence when tools exist; mixed-row test asserts Ran 2 tool calls. |
| Open-state watcher | Partially addressed | Failure transition now reopens, but completion still overwrites a user's manual expansion; re-raised in current thread. |
| Multiple thought durations | Addressed | All thought durations are summed; regression test covers 500 ms + 800 ms. |
| Streaming thought activity | Addressed | running now checks every activity part; regression test omits the active prop. |
| Unbounded Shiki work | Addressed | Highlighting is bypassed above 50,000 characters and covered by a regression test. |
| Stale highlighted snapshot | Addressed | Rendered markup is keyed to code/language and debounce has maxWait: 500. |
| Vacuous fallback test | Addressed | Test now waits for the rejected Shiki call before asserting fallback. |
| Undefined agent utilities | Addressed | Components use live semantic tokens; shimmer is defined in agentPanel.css; undefined collapse animation utilities were removed. |
| Clipboard rejection | Deferred, still open | No rejection handling was added; re-raised in current thread. |
| Partial timing subtotal | Deferred, still open | Missing timings are still folded to zero; re-raised in current thread. |
Current unresolved review state
- High: duplicate
defineStore('agentPanel')modules can return the wrong store shape: thread. - Low: incomplete timing labels: thread.
- Low: manual expansion overwritten at completion: thread.
- Low: clipboard rejection is unhandled: thread.
- Additional inline finding below: this slice removes four behavior-level E2E tests and does not restore them until slice 17.
| test.describe('In-App Agent panel', { tag: '@cloud' }, () => { | ||
| test.use({ connectWebSocketToServer: false }) | ||
|
|
||
| test.describe('In-App Agent panel shell', { tag: '@cloud' }, () => { |
There was a problem hiding this comment.
issue: This rewrite drops four existing behavior-level tests: full chat/WebSocket rendering, composer sizing, menu sizing/scrollbar styling, and stop-edit-resubmit. The mocks remain present but are only suppressed in Knip, and the tests do not return until slice 17, so every intermediate slice can regress these live behaviors while CI stays green. Please keep the existing cases in this slice (or move their coverage into an immediately adjacent carrier) instead of narrowing the suite to shell open/close.
|
This slice is reference-only. Accepted work is routed to #16385 and #16406. Full context for agent readersPer Christian's main-target close ruling, #16210 (10 — text and tool renderers) is no longer a landing vehicle. It remains readable implementation and review provenance. Runtime and permanent-test responsibilities are separated. If a genuinely unaccounted delta is found, reopen this source or file a bounded main-based carrier rather than reviving the stacked merge path. |
Merge after: #16206 (09) - stacked on its branch per the successive-stack chain.
Decisions: Agent V1 Decision Log
Landing strategy: SQUASH-MERGE ONLY - owner order 2026-08-28 (branch-history containment; do not merge-commit).
Summary
Slice 10 of the agent-v1 chain: the message-rendering leaves - code blocks with lazy shiki highlighting, tool-call cards and groups, and the tool-glyph service. No composites, no session logic, no CRDT. Census vs merge-base: 11 files, +731/-1.
Changes
CodeBlock(async shiki highlight with plain-escaped first paint, debounced re-highlight under streaming, graceful fallback, DOMPurify before injection),ToolCallGroup+ToolCallCard(collapsible grouped tool calls with count badges and durations), theagentToolGlyphservice (tool-name to icon/label mapping with a prototype-safe lookup), 11 locale keys consumed in-slice, and the shiki dependency added via the pnpm catalog (lock delta screened shiki-only, +87 lines).Review Focus
ToolCallGroup.test.tsreduced by 48 lines (+1 collapsed import) - its trailing describe rendersAgentMessage, which lands with the composites slice; the removed assertions are duplicates of coverage that lives in the retained half and inAgentMessage.test.ts, so no uniqueToolCallGroupcoverage is lost. The composites slice restores the block verbatim.CodeBlock.test.tsinherited from the snapshot,ToolCallCard's missing test (the snapshot ships none), and missing axe checks - all boarded for the post-chain fix round.agent-*Tailwind utilities these components use have no backing theme variables until the agent CSS substrate lands; Tailwind emits nothing for them, which is invisible to typecheck and tests. The slice that first mounts these components must landagentTheme.css+agentPanel.css+ thestyle.cssimport in the same slice.Linear tickets
Review-audit deltas (salvage matrix): items found during the slicing and review audits that did not make it through the integration merge (#16198).
No missing-artifact rows in this territory; the diff is the reviewed renderer delta vs the integration copy, plus the thinking-shimmer restoration.