Skip to content

[agent-v1 10/18] feat(agent): text and tool message renderers - #16210

Closed
CodeJuggernaut wants to merge 14 commits into
nathaniel/agent-v1/09-transcript-persistencefrom
nathaniel/agent-v1/10-message-renderers
Closed

CodeJuggernaut wants to merge 14 commits into
nathaniel/agent-v1/09-transcript-persistencefrom
nathaniel/agent-v1/10-message-renderers

Conversation

@CodeJuggernaut

@CodeJuggernaut CodeJuggernaut commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Merge after: #16206 (09) - stacked on its branch per the successive-stack chain.
Decisions: Agent V1 Decision Log
Landing strategy: SQUASH-MERGE ONLY - owner order 2026-08-28 (branch-history containment; do not merge-commit).

Summary

Slice 10 of the agent-v1 chain: the message-rendering leaves - code blocks with lazy shiki highlighting, tool-call cards and groups, and the tool-glyph service. No composites, no session logic, no CRDT. Census vs merge-base: 11 files, +731/-1.

Changes

  • What: CodeBlock (async shiki highlight with plain-escaped first paint, debounced re-highlight under streaming, graceful fallback, DOMPurify before injection), ToolCallGroup + ToolCallCard (collapsible grouped tool calls with count badges and durations), the agentToolGlyph service (tool-name to icon/label mapping with a prototype-safe lookup), 11 locale keys consumed in-slice, and the shiki dependency added via the pnpm catalog (lock delta screened shiki-only, +87 lines).

Review Focus

  • Extraction fidelity: 6 of 7 content files hash-exact against the integration snapshot. The one seam: ToolCallGroup.test.ts reduced by 48 lines (+1 collapsed import) - its trailing describe renders AgentMessage, which lands with the composites slice; the removed assertions are duplicates of coverage that lives in the retained half and in AgentMessage.test.ts, so no unique ToolCallGroup coverage is lost. The composites slice restores the block verbatim.
  • Dual blind cuts converged byte-identically on 5 of the content files - independent extraction receipt.
  • These components have zero importers at this tip: the slice is inert in the running app until the composites slice mounts them, so there is no live regression surface.
  • Review panel returned Ship it from both reviewers with zero fix rounds - a first for the chain. Non-blocking findings are deferred with named owners rather than fixed here (the files are extraction-fenced): a timing-hollow failure-path test in CodeBlock.test.ts inherited from the snapshot, ToolCallCard's missing test (the snapshot ships none), and missing axe checks - all boarded for the post-chain fix round.
  • Known ordering constraint, boarded: the agent-* Tailwind utilities these components use have no backing theme variables until the agent CSS substrate lands; Tailwind emits nothing for them, which is invisible to typecheck and tests. The slice that first mounts these components must land agentTheme.css + agentPanel.css + the style.css import in the same slice.
  • Draft until the chain's review flow completes.

Linear tickets

  • FE-1301 - stream live tool calls, fold on finish
  • FE-1303 - replace thinking with tool-call summary
  • FE-1315 - render new tool-call icons
  • FE-1295 - unify user/agent message font size
  • FE-1321 - normalize font sizes
  • FE-1312 - restyle tool-call list (icon and font halves only; humanized names are NOT in this diff)

Review-audit deltas (salvage matrix): items found during the slicing and review audits that did not make it through the integration merge (#16198).

No missing-artifact rows in this territory; the diff is the reviewed renderer delta vs the integration copy, plus the thinking-shimmer restoration.

@coderabbitai

coderabbitai Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 13d57245-8f8b-4679-b2ef-e35fe21ed553

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 29, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1890 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1869 / ❌ 0 / ⚠️ 0 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/01/2026, 11:10:24 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.3 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 56.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 138ms TBT · 81.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.9 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.1 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 88ms TBT · 156.8 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 393ms TBT · 169.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 7
canvas-idle: task duration 640ms
canvas-idle: script duration 13ms
canvas-idle: TBT 0ms
canvas-idle: heap used 56.8 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -172
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 39ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 916ms
canvas-mouse-sweep: script duration 158ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 57.3 MB
canvas-mouse-sweep: DOM nodes -279
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 19ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 33
canvas-zoom-sweep: task duration 408ms
canvas-zoom-sweep: script duration 15ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 67.8 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 463ms
dom-widget-clipping: script duration 163ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 83.7 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 687ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.8 MB
large-graph-idle: DOM nodes -269
large-graph-idle: event listeners -153
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1641ms
large-graph-pan: script duration 805ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.3 MB
large-graph-pan: DOM nodes -135
large-graph-pan: event listeners 6
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1707ms
large-graph-zoom: script duration 765ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.8 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1921ms
legacy-node-drag: script duration 945ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 85.4 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 634ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.2 MB
minimap-idle: DOM nodes -270
minimap-idle: event listeners -154
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 445ms
subgraph-dom-widget-clipping: script duration 148ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.3 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 523ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.8 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -231
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 38ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 871ms
subgraph-mouse-sweep: script duration 114ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 56.4 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 31ms
subgraph-transition-enter: layout count 12
subgraph-transition-enter: style recalc count 16
subgraph-transition-enter: task duration 990ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 138ms
subgraph-transition-enter: heap used 81.9 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 6092ms
viewport-pan-sweep: script duration 2702ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 80.9 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -166
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16796ms
vue-large-graph-idle: script duration 287ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.1 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 164
vue-large-graph-pan: task duration 20846ms
vue-large-graph-pan: script duration 909ms
vue-large-graph-pan: TBT 88ms
vue-large-graph-pan: heap used 156.8 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 81ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6205ms
vue-node-resize-workload: script duration 138ms
vue-node-resize-workload: TBT 393ms
vue-node-resize-workload: heap used 169.7 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 13ms
workflow-execution: layout count 3
workflow-execution: style recalc count 7
workflow-execution: task duration 77ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 67.6 MB
workflow-execution: DOM nodes 109
workflow-execution: event listeners 50
Raw data
{
  "timestamp": "2026-09-01T11:22:36.082Z",
  "gitSha": "f636cdc88624caa653ada1b8703b467e0389fa05",
  "branch": "nathaniel/agent-v1/10-message-renderers",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2102.5750000000016,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.001000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 716.9040000000001,
      "heapDeltaBytes": -1595552,
      "heapUsedBytes": 61467772,
      "domNodes": -280,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 14.196999999999997,
      "eventListeners": -189,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2088.5489999999436,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.127999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 562.229,
      "heapDeltaBytes": -12409988,
      "heapUsedBytes": 57697384,
      "domNodes": -281,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 10.970000000000004,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1835.5409999999779,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 37.829,
      "layouts": 14,
      "layoutDurationMs": 4.552,
      "taskDurationMs": 932.855,
      "heapDeltaBytes": -9158996,
      "heapUsedBytes": 60448672,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 158.812,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1890.0610000000597,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 40.275000000000006,
      "layouts": 14,
      "layoutDurationMs": 4.502,
      "taskDurationMs": 899.829,
      "heapDeltaBytes": -10178524,
      "heapUsedBytes": 59705624,
      "domNodes": -278,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 157.289,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1740.607999999952,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.854000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.0430000000000001,
      "taskDurationMs": 405.602,
      "heapDeltaBytes": 3807996,
      "heapUsedBytes": 68125164,
      "domNodes": 77,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 14.776000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.6879999999346,
      "styleRecalcs": 33,
      "styleRecalcDurationMs": 19.886999999999997,
      "layouts": 6,
      "layoutDurationMs": 1.2309999999999999,
      "taskDurationMs": 411.33900000000006,
      "heapDeltaBytes": 4432348,
      "heapUsedBytes": 73999788,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 14.479999999999997,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 709.8159999999893,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 10.493,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 477.553,
      "heapDeltaBytes": 18356940,
      "heapUsedBytes": 87964648,
      "domNodes": 22,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 165.999,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 664.248999999927,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.345,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.60800000000006,
      "heapDeltaBytes": 18690212,
      "heapUsedBytes": 87668116,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 160.67700000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2062.1260000000348,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.375,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 681.847,
      "heapDeltaBytes": -13043628,
      "heapUsedBytes": 87046344,
      "domNodes": -270,
      "jsHeapTotalBytes": -1609728,
      "scriptDurationMs": 38.083000000000006,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2088.0200000000286,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 8.618999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 692.8539999999999,
      "heapDeltaBytes": -13541844,
      "heapUsedBytes": 86686716,
      "domNodes": -267,
      "jsHeapTotalBytes": -1609728,
      "scriptDurationMs": 35.841,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2439.8969999999736,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.769999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1703.994,
      "heapDeltaBytes": 22823976,
      "heapUsedBytes": 88991180,
      "domNodes": -272,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 831.1460000000001,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2192.2649999999066,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.606000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1578.9110000000003,
      "heapDeltaBytes": 17651076,
      "heapUsedBytes": 83652948,
      "domNodes": 2,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 779.538,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3690.620000000024,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 10.056,
      "layouts": 60,
      "layoutDurationMs": 12.254000000000001,
      "taskDurationMs": 1791.4080000000001,
      "heapDeltaBytes": 8022132,
      "heapUsedBytes": 75297304,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 783.885,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3504.485000000045,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.374,
      "layouts": 60,
      "layoutDurationMs": 11.342,
      "taskDurationMs": 1622.7160000000001,
      "heapDeltaBytes": 11694628,
      "heapUsedBytes": 79442500,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 746.08,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3166.763000000003,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.013999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1997.1509999999998,
      "heapDeltaBytes": 21039592,
      "heapUsedBytes": 90645796,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 975.366,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3032.6630000000705,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.642,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1844.679,
      "heapDeltaBytes": 21163564,
      "heapUsedBytes": 88520200,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 914.524,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2054.2560000000094,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.881,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 620.817,
      "heapDeltaBytes": -14818368,
      "heapUsedBytes": 86891144,
      "domNodes": -268,
      "jsHeapTotalBytes": -823296,
      "scriptDurationMs": 34.556000000000004,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.033000000003,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.4689999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 647.965,
      "heapDeltaBytes": -14571000,
      "heapUsedBytes": 87620712,
      "domNodes": -271,
      "jsHeapTotalBytes": -1085440,
      "scriptDurationMs": 39.04299999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 646.681000000001,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.602999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 454.635,
      "heapDeltaBytes": 14812712,
      "heapUsedBytes": 86991564,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 152.604,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.5630000000037,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.431000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.61499999999995,
      "heapDeltaBytes": 13686392,
      "heapUsedBytes": 85703772,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 144.333,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.10300000002,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.125,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.264,
      "heapDeltaBytes": 8430080,
      "heapUsedBytes": 73670312,
      "domNodes": -296,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 9.536,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.6450000000586,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.719999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 518.737,
      "heapDeltaBytes": 730276,
      "heapUsedBytes": 72754948,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 9.380000000000003,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1732.2790000000055,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 40.580000000000005,
      "layouts": 18,
      "layoutDurationMs": 5.114999999999999,
      "taskDurationMs": 911.4100000000001,
      "heapDeltaBytes": -12647160,
      "heapUsedBytes": 58359240,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 118.197,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1716.93300000004,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 35.57,
      "layouts": 18,
      "layoutDurationMs": 4.818999999999999,
      "taskDurationMs": 829.7719999999999,
      "heapDeltaBytes": -12225920,
      "heapUsedBytes": 59859080,
      "domNodes": -297,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 110.67899999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.777000000001,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 31.433000000000003,
      "layouts": 12,
      "layoutDurationMs": 15.252999999999998,
      "taskDurationMs": 989.5660000000001,
      "heapDeltaBytes": -7353952,
      "heapUsedBytes": 85915864,
      "domNodes": 13671,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 31.124,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 138,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9360.853000000021,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.225,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6196.284,
      "heapDeltaBytes": 9543244,
      "heapUsedBytes": 84638388,
      "domNodes": -270,
      "jsHeapTotalBytes": 118784,
      "scriptDurationMs": 2725.536,
      "eventListeners": -165,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8841.301999999927,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 35.885,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5987.105,
      "heapDeltaBytes": 10092468,
      "heapUsedBytes": 85122332,
      "domNodes": -269,
      "jsHeapTotalBytes": -143360,
      "scriptDurationMs": 2678.513,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17491.032000000017,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16892.556,
      "heapDeltaBytes": -36909692,
      "heapUsedBytes": 174750556,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2039808,
      "scriptDurationMs": 285.13700000000006,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17114.458000000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16699.491,
      "heapDeltaBytes": -34313132,
      "heapUsedBytes": 175709432,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6307840,
      "scriptDurationMs": 288.47999999999996,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21038.456,
      "styleRecalcs": 161,
      "styleRecalcDurationMs": 20.27000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20754.595999999998,
      "heapDeltaBytes": -44804020,
      "heapUsedBytes": 162466704,
      "domNodes": -6548,
      "jsHeapTotalBytes": -8306688,
      "scriptDurationMs": 905.038,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21319.428000000014,
      "styleRecalcs": 166,
      "styleRecalcDurationMs": 17.836999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20937.605,
      "heapDeltaBytes": -37429628,
      "heapUsedBytes": 166403108,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5050368,
      "scriptDurationMs": 913.177,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 36,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6299.547000000019,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 80.61100000000005,
      "layouts": 20,
      "layoutDurationMs": 23.54500000000001,
      "taskDurationMs": 6162.152,
      "heapDeltaBytes": -29544816,
      "heapUsedBytes": 180254416,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10309632,
      "scriptDurationMs": 111.78099999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 367,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6360.381000000075,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.86399999999999,
      "layouts": 20,
      "layoutDurationMs": 23.94,
      "taskDurationMs": 6248.344999999999,
      "heapDeltaBytes": -33464220,
      "heapUsedBytes": 175631176,
      "domNodes": -6548,
      "jsHeapTotalBytes": 5615616,
      "scriptDurationMs": 163.235,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 419,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 106.02300000005016,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 11.81,
      "layouts": 3,
      "layoutDurationMs": 1.005,
      "taskDurationMs": 78.24499999999999,
      "heapDeltaBytes": 3243408,
      "heapUsedBytes": 70846312,
      "domNodes": 110,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.442000000000002,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 106.65199999994002,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.408000000000001,
      "layouts": 2,
      "layoutDurationMs": 0.8320000000000001,
      "taskDurationMs": 75.621,
      "heapDeltaBytes": 3155504,
      "heapUsedBytes": 70819952,
      "domNodes": 108,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.562000000000001,
      "eventListeners": 51,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48047 70504 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.7% 391
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.3% 300
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/LGraph.ts 78.4% 258
src/scripts/app.ts 71.5% 251
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@codecov

codecov Bot commented Aug 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.79245% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...tensions/agent/components/agent/AgentPanelRoot.vue 0.00% 7 Missing ⚠️
@@                               Coverage Diff                                @@
##           nathaniel/agent-v1/09-transcript-persistence   #16210      +/-   ##
================================================================================
- Coverage                                         83.26%   83.26%   -0.01%     
================================================================================
  Files                                              2023     2025       +2     
  Lines                                            117099   117133      +34     
  Branches                                          33064    33076      +12     
================================================================================
+ Hits                                              97506    97527      +21     
- Misses                                            19249    19262      +13     
  Partials                                            344      344              
Flag Coverage Δ
e2e 66.64% <ø> (-0.02%) ⬇️
unit 76.50% <86.79%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sions/agent/components/agent/message/CodeBlock.vue 100.00% <100.00%> (+3.84%) ⬆️
...ns/agent/components/agent/message/ToolCallCard.vue 100.00% <100.00%> (ø)
...s/agent/components/agent/message/ToolCallGroup.vue 100.00% <100.00%> (ø)
...rkbench/extensions/agent/stores/agentPanelStore.ts 100.00% <100.00%> (ø)
...tensions/agent/components/agent/AgentPanelRoot.vue 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 29, 2026
@christian-byrne christian-byrne added the cursor-review Trigger multi-model Cursor agent review on this PR label Aug 30, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 10 finding(s).

Severity Count
🟠 High 1
🟡 Medium 7
🟢 Low 2

Panel: 8/8 reviewers contributed findings.

@christian-byrne

christian-byrne commented Aug 30, 2026 •

Copy link
Copy Markdown
Contributor

Automated fleet review (desktop operator, Christian-authorized)

  • NEEDS-CHANGES.
  • Apply four review conditions.
  • Chain and CI blocked.
Full context for agent readers

PR #16210 — design-review packet (slice 10/18, message renderers)

Lane: pr16210-review (Class A, report-only). Date: 2026-08-29.
Target: Comfy-Org/ComfyUI_frontend#16210
— [agent-v1 10/18] feat(agent): text and tool message renderers, DRAFT, author CodeJuggernaut.
Verified head: 16fe0e90639ea01d92df11b74160daaf0c4be9bf (unchanged since the 2026-08-29T03:00:29Z
nathaniel-watch pass — updatedAt 01:29:43Z predates it, so per R2 the CI/E2E facts recorded in
reports/nathaniel-watch/chamber/2026-08-29-pr16210.md are not re-verified here).
Base: nathaniel/agent-v1/09-transcript-persistence (stacked on #16206). Mergeable on that base.
Census: 11 files, +731/−1.

VERDICT: MERGE-AFTER-CHANGES (4 enumerated below; none are CRDT-design conflicts).
Merge path: folds into the existing slice-chain path — no separate packet needed for the PR
itself.
Two cross-cutting items it introduces (shiki dependency, agent CSS-substrate ordering)
should be attached to the unruled #97 slice-merge-path decision rather than tracked per-slice.


1. What the PR actually does

Pure presentational leaf slice. Adds three message-rendering surfaces and one lookup service under
the existing src/workbench/extensions/agent/ tree, plus a dependency and 11 locale keys.

Path Kind
components/agent/message/CodeBlock.vue (+89) new — fenced code block, lazy shiki highlight
components/agent/message/ToolCallCard.vue (+53) new — one tool row (glyph, label, ×count, duration)
components/agent/message/ToolCallGroup.vue (+157) new — reka-ui collapsible grouping tool + thinking rows
services/agent/agentToolGlyph.ts (+40) new — tool-name → {labelKey, icon} map, hasOwn-guarded
CodeBlock.test.ts / ToolCallGroup.test.ts / agentToolGlyph.test.ts new — component + unit tests
src/locales/en/main.json +11 keys under agent.
package.json, pnpm-workspace.yaml, pnpm-lock.yaml new dep: shiki pinned 4.3.0 via catalog

Stores/surfaces touched: none. No Pinia store, no router, no extension registration, no
docFrameClient, no schema file. The only cross-module dependency is a type-only import of
PartState / ToolPart / ActivityPart from services/agent/agentMessageParts — verified present
on the base branch (1224 bytes @ nathaniel/agent-v1/09-transcript-persistence), lands in slice 09.

CRDT internals imported: zero. Full import census across the four source files:
@vueuse/core, dompurify, vue, vue-i18n, @comfyorg/tailwind-utils, reka-ui, dynamic
import('shiki'), and the two relative services/agent/* paths above. No Yjs, no doc-frame, no
stamp/clock, no ops, no ECS, no websocket.

The author's own claim that these components have zero importers at this tip is consistent with
the diff: nothing in the 11 files imports ToolCallGroup or CodeBlock, and no existing file is
modified to mount them. The slice is inert in the running app until the composites slice lands.

2. Alignment with our ADRs

No contact surface with the CRDT design. Checked against decisions/:

ADR Contact Note
ADR-007 (op-based CRDT v1) none no ops, no replication path in the diff
ADR-016 (incarnation-namespaced stamps) none no stamp, clock, or site-id field is read or written
ADR-009 / ADR-010 (FE follower render-mutations seam / Yjs-backed ECS) none components render an HTTP/SSE transcript, not graph state
ADR-015 (target-graph addressing, offscreen queues) none no graph addressing
ADR-011 (branch/distribution) none leaf slice, no branch-strategy claim

scalar-v1 vs Lamport stamps — not applicable. The comfy-multi-player main @8636af3e Lamport
merge (verified-state row, 2026-08-29) changes stamp comparison semantics in the CRDT layer. This
PR reads no stamp of either shape. Rebasing it onto the integration candidate carries zero
semantic risk from its own files
.

Rebase risk is textual, not semantic. Four of the eleven files are the highest-churn shared
files in the repo — pnpm-lock.yaml, package.json, pnpm-workspace.yaml, src/locales/en/main.json.
Lock conflicts are the expensive kind to resolve by hand. This is the same conflict class already
recorded for the stack (the six conflicting paths vs main noted at 03:00:29Z), not a new one.

One design-doc adjacency, resolved in the PR's favour. plans/technical-design.md:35,296 records
client-requested target:"new_tab" as never built and superseded by a server-pushed
agent_active_tab event
. The glyph map here treats new_tab / switch_tab as server-reported
tool call names
, not as a client request field — that is the server-authoritative form our
supersession points at, so it aligns rather than conflicts. Worth stating explicitly because the
string collision invites the opposite reading.

Inherited ADR-017 drift (flag, do not block this PR). ADR-017 makes generated OpenAPI types the
authority and calls out that hand-maintained copies "allow spelling and shape drift."
agentMessageParts.ts is hand-written and lands in slice 09, not here. But this PR is the first
surface to make its un-generated wire fields (durationMs, ok) user-visible — ToolCallGroup
sums durationMs into "Ran 3 tool calls for 2.0 seconds". If those fields are not in the generated
/api/agent projection, the drift now has a visible failure mode (silently untimed labels). The fix
belongs on slice 09 / the typegen lane, not on #16210.

3. Risk classing

Shipped surface, currently inert. Not dev-only: the files live under src/workbench/extensions/agent/
and compile into the production build. They are unreachable at runtime only because nothing mounts
them yet — that is an absence of a caller, not a gate.

Feature-gating: absent in this PR, and correctly so. The agent panel gate is a separate concern
(#16208 replaces the PostHog gate with authenticated /features). These leaves inherit whatever gate
the mounting composite sits behind. No gating change is needed here.

Bundle impact: the one material risk. CodeBlock.vue:22 does await import('shiki'), whose root
entry (shiki → dist/index.mjs) is shiki's full bundle — every bundled grammar and theme,
reachable as lazy sub-imports. Sizes at the pinned version: @shikijs/langs@4.3.0 8.07 MB
unpacked, @shikijs/themes@4.3.0 1.46 MB, @shikijs/engine-oniguruma@4.3.0 0.64 MB. The
component uses exactly one theme (github-dark) and whatever language the model emits. The repo has
ci-binary-size-validation.yaml, ci-size-data.yaml, and ci-perf-report.yaml — this is a gated,
measurable concern, not a speculative one.

Duplicate dependency tree. shiki is not declared in main's package.json or catalog, but
shiki@4.3.1 is already resolved transitively (via @astrojs/internal-helpers and
@astrojs/language-server, i.e. the dev-side Astro toolchain). Pinning the catalog to 4.3.0
therefore adds a second complete tree: the diff carries duplicate lock entries for shiki,
@shikijs/core, engine-javascript, engine-oniguruma, langs, primitive, themes, and types
— eight packages duplicated where a 4.3.1 pin would have deduped to one.

Security: adequate. v-html is fed only DOMPurify.sanitize(shiki output); knownTool uses
Object.hasOwn so a tool literally named constructor cannot resolve off Object.prototype
(tested). No untrusted URL, download, or binding surface in this slice — unlike #16211.

Correctness carry-over (already staged, do not duplicate). The stale-highlight race —
highlighted retains the previous code while the header and Copy button already show the new props
— is written up as a READY-TO-POST inline comment in
reports/nathaniel-watch/chamber/2026-08-29-pr16210.md. This packet endorses it and does not restate
it as a new finding.

Not blocking, worth noting: ToolCallGroup.vue:154-161 drives open from a watch on
isActive || failed, so a user who manually collapses an active group has it forced back open on the
next state flip. Minor UX, matches the tested intent.

4. Verdict

MERGE-AFTER-CHANGES

  1. Scope the shiki import. Replace import('shiki') with a scoped entry — shiki/bundle/web, or
    createHighlighterCore from shiki/core with an explicit lang/theme set. As written the build
    graph acquires ~10 MB of grammar/theme assets for one theme. Blocking because the repo gates on
    binary size and the cost is structural, not incidental.
  2. Pin the catalog to 4.3.1, not 4.3.0. Dedupes against the shiki@4.3.1 already resolved
    through the Astro toolchain and removes eight duplicated lock entries. One-line change.
  3. Reuse the existing copy strings. g.copy ("Copy") and g.copied ("Copied") already exist
    on main; the PR adds agent.copy / agent.copied ("Copied!") as near-duplicates. Drop the two
    new keys and consume g.* unless the trailing ! is a deliberate design call.
  4. Promote the agent CSS-substrate ordering constraint from "boarded" to a merge gate. The author
    correctly identifies that the agent-* Tailwind utilities, agent-shimmer-text, and
    animate-agent-collapsible-* have no backing theme variables until agentTheme.css /
    agentPanel.css land, and that Tailwind silently emits nothing — invisible to typecheck and to
    every test in this PR. A constraint that no automated check can catch should not be tracked as a
    deferred note. It needs to be an explicit blocking condition on whichever slice first mounts these
    components.

Not conditions, but endorsed as-is: the hasOwn glyph lookup, DOMPurify-before-v-html, the
role="list" / role="listitem" structure, and the wrench-plus-humanized-name fallback for unmapped
tools — the last of which keeps the glyph service vocabulary-agnostic and is the right shape for a
tool list our design has not frozen.

Explicitly NOT a verdict of CONFLICTS-WITH-OUR-DESIGN. The PR neither implements nor contradicts
any CRDT ADR. Its four required changes are dependency hygiene, i18n hygiene, and a build-ordering
gate — all reviewable by the frontend team without reference to the CRDT design.

Merge path

Folds into the existing slice-chain path (#16204 → #16206 → #16210 → #16211 → #16213); no separate
packet for the PR.
It has no independent merge story: inert leaf, stacked base, squash-merge-only
per the owner's 2026-08-28 order.

Two items it introduces are not slice-local and should be attached to the unruled #97
slice-merge-path decision (default B, required by 2026-08-30 18:00Z) rather than raised per-slice:

  • shiki becomes a first-party runtime dependency of the frontend. That is a program-level
    dependency decision, not a slice-10 detail, and it lands wherever the chain lands.
  • The agent CSS substrate must land in or before the first mounting slice. Cross-slice ordering
    constraint spanning at least slices 10, 11, and the composites slice.

Recommendation only — the operator files it (R5).


Verified-state candidates (NOT appended by this lane)

Single-writer discipline says I own only this file; five review lanes are running concurrently and
all would append to reports/audit/verified-state.md at once. Handing these to the operator to merge
instead of racing on the ledger. All anchored to FE main and PR head 16fe0e90:

Fact Anchor
PR #16210 imports zero CRDT modules; touches no store, schema, or extension registration 16fe0e90 (full import census, 4 source files)
shiki absent from FE main package.json + catalog; shiki@4.3.1 present transitively via @astrojs/internal-helpers / @astrojs/language-server FE main pnpm-lock.yaml
shiki@4.3.0 root entry is the full bundle: @shikijs/langs 8.07 MB, @shikijs/themes 1.46 MB unpacked npm registry, 2026-08-29
g.copy = "Copy" and g.copied = "Copied" already exist in src/locales/en/main.json FE main
ThinkingPart.durationMs and ToolPart.{ok,durationMs} are hand-written, not generated (ADR-017 relevance) agentMessageParts.ts @ nathaniel/agent-v1/09-transcript-persistence

Sources

Our design only, per COR-8 quarantine: plans/technical-design.md, decisions/ADR-007, ADR-009,
ADR-010, ADR-011, ADR-015, ADR-016, ADR-017, reports/audit/verified-state.md,
reports/nathaniel-watch/chamber/2026-08-29-pr16210.md, reports/nathaniel-watch/log.md.
The PR's own code and diff were read directly. Nathaniel's Notion decision log (linked from the PR
body) was not opened.


Merge-readiness scorecard

Slice 10 merge-readiness scorecard

PR: Comfy-Org/ComfyUI_frontend#16210 — text and tool message renderers
Observed: 2026-08-30 at head 16fe0e90639ea01d92df11b74160daaf0c4be9bf
Overall verdict: NEEDS-CHANGES — all four review conditions remain absent from the unchanged PR head; the PR is also draft, red, and waiting for slices 03–09.
Score: 2.5/7 (PASS or accepted discretion = 1; PARTIAL = 0.5; FAIL/BLOCKED = 0)

03 -> 04 -> 05 -> 06 -> 07 -> 08 -> 09 -> [10] -> 11 -> 12 -> main
                                          ^
                                leaf renderers, not yet mountable
gate status evidence
Review verdict FAIL (0/1) The review packet says MERGE-AFTER-CHANGES. The unchanged live head has none of: (1) scoped Shiki import, (2) Shiki 4.3.1 dedupe, (3) reuse of g.copy/g.copied, or (4) an explicit CSS-substrate merge gate. All are prepared only in the detached patch series; item 4 still requires the mounting path to load both style sheets.
Flag-off safety PASS (1/1) The slice audit is CLEAN: unmounted renderer leaves and a pure glyph helper remain below the async panel gate; the dependency and locale changes add no behavior. Issue #149 discretion is unnecessary.
CI on current head FAIL (0/1) Live gh pr checks at 16fe0e90: 96 pass, 11 fail, 17 skip. Red: e2e-status, mobile Chrome, and Chromium shards 2, 3, 4, 6, 7, 8, 10, 14, and 15. This matches the inherited slice-09 failure set, but the head is not green.
Conflict with declared base PASS (1/1) GitHub reports MERGEABLE against nathaniel/agent-v1/09-transcript-persistence@628c7147; no current-base merge conflict. mergeStateStatus=BLOCKED is policy/check state.
Draft and retarget-to-main readiness BLOCKED (0/1) Still draft. FEH-4 requires restacking only after candidate plus slices 03–09. It cannot be retargeted straight to main, and its CSS ordering condition must remain intact through the later mounting slice.
Test coverage PARTIAL (0.5/1) Three focused suites cover code-block fallback/highlighting, tool grouping, and own-property-safe glyph lookup. The prepared fixes pass 3 files/20 tests, but those commits are not the PR head. No browser test mounts these leaves; stale async highlighting, copy behavior, and real composed CSS remain release gaps.
Open blockers BLOCKED (0/1) Apply the four review conditions, retain CSS substrate ordering, green CI, preserve owner draft control, and wait for slices 03–09. rp-1 independently owns 03–07 review packets; union-preview renderer behavior remains unverified in the Linear matrix.

Merge decision

Do not merge or retarget now. Apply/recreate the patch series on the eventual restack, ensure the
mounting slice loads the complete CSS substrate, and require focused plus composed-browser coverage.

Provenance and glossary

Sources: live GitHub metadata/checks, internal review and patch packets, mr-1, FEH-4, and the current
G1 Linear checkpoint. No quarantined Nathaniel design document or Linear design narrative was read.

  • Shiki — the syntax-highlighting dependency used by code blocks.
  • CSS substrate — the theme variables, classes, and keyframes required by these renderers.
  • Leaf renderer — a component with no live importer/mount at this slice.
  • rp-1 — the separate review lane for slices 03–07.

@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/09-transcript-persistence branch from 628c714 to 3c6c4f9 Compare August 30, 2026 14:48
@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/10-message-renderers branch from 16fe0e9 to 023fb92 Compare August 30, 2026 14:50
@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/09-transcript-persistence branch from 3c6c4f9 to ca644f2 Compare August 30, 2026 16:48
@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/10-message-renderers branch from 023fb92 to 6eae48b Compare August 30, 2026 16:56
@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/09-transcript-persistence branch from ca644f2 to 80f67f2 Compare August 30, 2026 17:41
CodeJuggernaut and others added 2 commits August 30, 2026 17:41
- code blocks with lazy shiki highlighting and a plain escaped
  fallback (shiki joins the workspace catalog)
- tool-call cards and grouping with reasoning and duration rows
- the tool glyph map pairing each tool's label key and icon
- renderer strings land with their consumers; the tool-grouping
  spec for the message container follows with that component
@christian-byrne
christian-byrne force-pushed the nathaniel/agent-v1/10-message-renderers branch from 6eae48b to 84b33db Compare August 30, 2026 17:43
@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR and removed cursor-review Trigger multi-model Cursor agent review on this PR labels Aug 31, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor

Superseded — closing per Christian's direction.

Full context for agent readers

Program pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs.

CodeJuggernaut and others added 4 commits August 31, 2026 12:02
…-persistence' into hub-10-cascade

# Conflicts:
#	browser_tests/tests/agent/agentPanel.spec.ts
#	pnpm-lock.yaml
#	pnpm-workspace.yaml
#	src/locales/en/main.json
#	src/workbench/extensions/agent/components/agent/AgentPanelRoot.vue
#	src/workbench/extensions/agent/components/agent/message/CodeBlock.test.ts
#	src/workbench/extensions/agent/components/agent/message/CodeBlock.vue
#	src/workbench/extensions/agent/components/agent/message/ToolCallCard.vue
#	src/workbench/extensions/agent/components/agent/message/ToolCallGroup.test.ts
#	src/workbench/extensions/agent/components/agent/message/ToolCallGroup.vue
@github-actions github-actions Bot removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 31, 2026
@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 31, 2026
@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR and removed cursor-review Trigger multi-model Cursor agent review on this PR labels Sep 2, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Round 2 — ledger: 10 prior finding(s) across 1 round(s) (10 never answered).

Found 4 finding(s).

Severity Count
🟠 High 1
🟢 Low 3

Panel: 3/8 reviewers contributed findings.

Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gemini-3.1-pro:adversarial (error), gpt-5.6-sol-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gpt-5.6-sol-max:edge-case (error)

const OPEN_STORAGE_KEY = 'Comfy.AgentPanel.open'

export const useAgentPanelStore = /* @__PURE__ */ defineStore(
'agentPanel',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 High — This file registers defineStore('agentPanel', ...) with a gate-only shape while stores/agent/agentPanelStore.ts already owns that id with the full panel shape (width, setWidth, toggleMaximize, and the open/close telemetry). Pinia keys by id, so whichever setup runs first wins for every consumer regardless of which module imported it — the exact failure stores/agent/agentPanelStoreId.test.ts was added to pin, where width is undefined, visibleCanvasViewport computes NaN into ds.scale/ds.offset, and toggleMaximize throws. It is only latent because the sole importer, components/agent/AgentPanelRoot.vue, is dead code this same PR knip-ignores; delete both rather than shipping two definitions of one store id.

Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

)
const thoughtSeconds = computed(() => {
const ms = thoughts.value.reduce(
(sum, thought) => sum + (thought.durationMs ?? 0),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — thoughtSeconds copies the ?? 0 fold and ms > 0 threshold from totalSeconds, so a group mixing timed and untimed parts presents a partial subtotal as the duration for all of them, while a set of genuinely-zero durations takes the untimed branch even though each row still renders 0.0s. Test the individual durationMs values for undefined instead of thresholding the sum — the same applies to the per-row aggregation in rows.

Re-raised from round 1, never answered by the author; originally raised by 2 of 8 reviewers (gpt-5.6-sol-max edge-case, claude-opus-5-thinking-max edge-case).

open.value = stayOpen
isActive,
(activeNow) => {
open.value = activeNow

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — Splitting the failure reopen into its own watch(failed, ...) fixed that half, but this watcher still assigns open on every isActive transition, so a group the user expanded mid-turn snaps shut the moment the turn goes inactive. Track a user-override flag and skip the assignment once the user has toggled the group by hand.

Re-raised from round 1, never answered by the author; originally raised by 3 of 8 reviewers (claude-opus-5-thinking-max edge-case, gpt-5.6-sol-max edge-case, kimi-k3-max edge-case).

type="button"
class="text-agent-fg-subtle hover:bg-agent-surface hover:text-agent-fg border-agent-border-strong flex items-center gap-1 rounded-sm border px-2 py-0.5 font-mono text-xs transition-colors"
class="hover:bg-background hover:text-foreground border-border flex items-center gap-1 rounded-sm border px-2 py-0.5 font-mono text-xs text-muted-foreground transition-colors"
@click="copy(code)"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — copy(code) is a floating promise and VueUse does not catch internally, so a rejected navigator.clipboard.writeText (document not focused, permission denied, non-secure context) escapes to the global unhandled-rejection handler while copied never flips, leaving the user with no indication the copy failed. Handle the rejection, surface a failure state, and report it via reportError().

Re-raised from round 1, never answered by the author; originally raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, claude-opus-5-thinking-max adversarial).

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One additional coverage regression found. Prior round: 7 addressed, 1 partially addressed, 2 deferred. Four new Cursor threads remain open, including the duplicate Pinia store-id blocker.

Full context for agent readers

Reviewed exact head afa5a9b4be against stacked base nathaniel/agent-v1/09-transcript-persistence only. The functional CI suite on this head is green; six Cursor model jobs were cancelled, while the consolidated Cursor review completed and opened four threads.

Prior-thread follow-through

Prior thread Status at current head Evidence
Mixed thought/tool summary Addressed Tool summaries now take precedence when tools exist; mixed-row test asserts Ran 2 tool calls.
Open-state watcher Partially addressed Failure transition now reopens, but completion still overwrites a user's manual expansion; re-raised in current thread.
Multiple thought durations Addressed All thought durations are summed; regression test covers 500 ms + 800 ms.
Streaming thought activity Addressed running now checks every activity part; regression test omits the active prop.
Unbounded Shiki work Addressed Highlighting is bypassed above 50,000 characters and covered by a regression test.
Stale highlighted snapshot Addressed Rendered markup is keyed to code/language and debounce has maxWait: 500.
Vacuous fallback test Addressed Test now waits for the rejected Shiki call before asserting fallback.
Undefined agent utilities Addressed Components use live semantic tokens; shimmer is defined in agentPanel.css; undefined collapse animation utilities were removed.
Clipboard rejection Deferred, still open No rejection handling was added; re-raised in current thread.
Partial timing subtotal Deferred, still open Missing timings are still folded to zero; re-raised in current thread.

Current unresolved review state

  • High: duplicate defineStore('agentPanel') modules can return the wrong store shape: thread.
  • Low: incomplete timing labels: thread.
  • Low: manual expansion overwritten at completion: thread.
  • Low: clipboard rejection is unhandled: thread.
  • Additional inline finding below: this slice removes four behavior-level E2E tests and does not restore them until slice 17.

test.describe('In-App Agent panel', { tag: '@cloud' }, () => {
test.use({ connectWebSocketToServer: false })

test.describe('In-App Agent panel shell', { tag: '@cloud' }, () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: This rewrite drops four existing behavior-level tests: full chat/WebSocket rendering, composer sizing, menu sizing/scrollbar styling, and stop-edit-resubmit. The mocks remain present but are only suppressed in Knip, and the tests do not return until slice 17, so every intermediate slice can regress these live behaviors while CI stays green. Please keep the existing cases in this slice (or move their coverage into an immediately adjacent carrier) instead of narrowing the suite to shell open/close.

@christian-byrne

Copy link
Copy Markdown
Contributor

This slice is reference-only. Accepted work is routed to #16385 and #16406.

Full context for agent readers

Per Christian's main-target close ruling, #16210 (10 — text and tool renderers) is no longer a landing vehicle. It remains readable implementation and review provenance. Runtime and permanent-test responsibilities are separated. If a genuinely unaccounted delta is found, reopen this source or file a bounded main-based carrier rather than reviving the stacked merge path.

Decision record.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components cursor-review Trigger multi-model Cursor agent review on this PR risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants