Repository navigation
[agent-v1 03/18] feat(canvas): selection interaction mode + navigation primitives - #16186
CodeJuggernaut wants to merge 15 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1890 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.63 MB gzipDetailsSummary
Category Glance App Entry Points — 3.78 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.4 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 124 kBTop-level views, pages, and routed surfaces
Status: 17 added Panels & Settings — 621 kBConfiguration panels, inspectors, and settings screens
Status: 27 added User & Accounts — 27.5 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 115 kBReusable component library chunks
Status: 15 added Data & Services — 3.58 MBStores, services, APIs, and repositories
Status: 17 added Utilities & Hooks — 556 kBHelpers, composables, and utility bundles
Status: 37 added Vendor & Third-Party — 18.1 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 16.2 MBBundles that do not match a named category
Status: 294 added ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-30T16:01:22.444Z",
"gitSha": "108ffea32e20b95f6d0bf232791c6776d9a3e1a1",
"branch": "nathaniel/agent-v1/03-canvas-primitives",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2034.5209999999838,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.593000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 503.749,
"heapDeltaBytes": 10542516,
"heapUsedBytes": 79817436,
"domNodes": -282,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.316,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2055.1940000000286,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.749999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.2730000000001,
"heapDeltaBytes": -12515552,
"heapUsedBytes": 57237444,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.347999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1817.9180000000201,
"styleRecalcs": 74,
"styleRecalcDurationMs": 36.234,
"layouts": 12,
"layoutDurationMs": 3.4079999999999995,
"taskDurationMs": 883.0349999999999,
"heapDeltaBytes": -9432912,
"heapUsedBytes": 59906108,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 155.718,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1853.1810000000632,
"styleRecalcs": 76,
"styleRecalcDurationMs": 37.11000000000001,
"layouts": 12,
"layoutDurationMs": 3.443,
"taskDurationMs": 884.7479999999999,
"heapDeltaBytes": -11313560,
"heapUsedBytes": 58191256,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 157.477,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.7089999999757,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.308,
"layouts": 6,
"layoutDurationMs": 0.607,
"taskDurationMs": 375.776,
"heapDeltaBytes": 4485876,
"heapUsedBytes": 74568956,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.285999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1664.3760000000611,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.895,
"layouts": 6,
"layoutDurationMs": 0.6779999999999999,
"taskDurationMs": 365.91200000000003,
"heapDeltaBytes": 4433992,
"heapUsedBytes": 74256328,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 11.315999999999999,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 762.2989999999845,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.242999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.2540000000001,
"heapDeltaBytes": 18835016,
"heapUsedBytes": 87622980,
"domNodes": 14,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 177.44600000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 656.1970000000201,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.301999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.24600000000004,
"heapDeltaBytes": 18211584,
"heapUsedBytes": 87994992,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 161.303,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2067.8379999999947,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.454,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 684.9300000000002,
"heapDeltaBytes": -10741360,
"heapUsedBytes": 85153820,
"domNodes": -272,
"jsHeapTotalBytes": 4714496,
"scriptDurationMs": 41.373999999999995,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2042.6190000000588,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.497000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 605.874,
"heapDeltaBytes": -13144016,
"heapUsedBytes": 86790068,
"domNodes": -271,
"jsHeapTotalBytes": -1576960,
"scriptDurationMs": 35.481,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2325.2970000000346,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.858,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1659.8739999999998,
"heapDeltaBytes": 20837340,
"heapUsedBytes": 86574824,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 805.8879999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2364.7909999999683,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.828000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1731.5010000000002,
"heapDeltaBytes": 26884160,
"heapUsedBytes": 92172924,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 861.696,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3532.711000000006,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.955999999999996,
"layouts": 60,
"layoutDurationMs": 7.398,
"taskDurationMs": 1688.6800000000003,
"heapDeltaBytes": 10215400,
"heapUsedBytes": 76314796,
"domNodes": -281,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 748.555,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3587.841000000026,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.909999999999995,
"layouts": 60,
"layoutDurationMs": 7.3999999999999995,
"taskDurationMs": 1697.6840000000002,
"heapDeltaBytes": 7753012,
"heapUsedBytes": 75086364,
"domNodes": -11,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 762.801,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3095.0670000000287,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.973999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1969.339,
"heapDeltaBytes": 22171072,
"heapUsedBytes": 89783084,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 987.506,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3116.8069999999943,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.774999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1896.801,
"heapDeltaBytes": 17896864,
"heapUsedBytes": 84644820,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 924.431,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2014.2109999999889,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.8810000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.8809999999999,
"heapDeltaBytes": 22104412,
"heapUsedBytes": 87331744,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.394000000000005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2008.7570000000596,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.6759999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 574.958,
"heapDeltaBytes": 22145152,
"heapUsedBytes": 87999920,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.68300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.2860000000114,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.627999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 415.83699999999993,
"heapDeltaBytes": 14088304,
"heapUsedBytes": 85586524,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 143.774,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.9139999999325,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.077,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.92199999999997,
"heapDeltaBytes": 14309056,
"heapUsedBytes": 86362324,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 142.986,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.6610000000042,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.918999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.4189999999999,
"heapDeltaBytes": 4106956,
"heapUsedBytes": 69063388,
"domNodes": -295,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.938000000000001,
"eventListeners": -235,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2015.498999999977,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.798999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.991,
"heapDeltaBytes": -7004536,
"heapUsedBytes": 64857160,
"domNodes": -295,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.003000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1734.0849999999932,
"styleRecalcs": 75,
"styleRecalcDurationMs": 37.205999999999996,
"layouts": 16,
"layoutDurationMs": 4.531000000000001,
"taskDurationMs": 870.6740000000001,
"heapDeltaBytes": -12035900,
"heapUsedBytes": 59404512,
"domNodes": -297,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 119.21400000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.0279999999539,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.822,
"layouts": 16,
"layoutDurationMs": 4.926,
"taskDurationMs": 872.5480000000001,
"heapDeltaBytes": -11007108,
"heapUsedBytes": 60502228,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 113.338,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.2370000000374,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.521000000000008,
"layouts": 13,
"layoutDurationMs": 14.389000000000003,
"taskDurationMs": 954.8969999999999,
"heapDeltaBytes": 192732,
"heapUsedBytes": 96792764,
"domNodes": 13671,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 30.802999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 136,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8568.720999999983,
"styleRecalcs": 246,
"styleRecalcDurationMs": 34.571000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5813.165,
"heapDeltaBytes": -11324044,
"heapUsedBytes": 88906184,
"domNodes": -270,
"jsHeapTotalBytes": -1875968,
"scriptDurationMs": 2601.188,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8525.80599999999,
"styleRecalcs": 247,
"styleRecalcDurationMs": 35.115,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5849.909000000001,
"heapDeltaBytes": -14917124,
"heapUsedBytes": 85068852,
"domNodes": -269,
"jsHeapTotalBytes": -1351680,
"scriptDurationMs": 2648.5399999999995,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17688.641000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16933.633,
"heapDeltaBytes": -35630312,
"heapUsedBytes": 173949176,
"domNodes": -6548,
"jsHeapTotalBytes": -5226496,
"scriptDurationMs": 355.0489999999999,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17524.505999999972,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16967.545000000002,
"heapDeltaBytes": -33314756,
"heapUsedBytes": 173725444,
"domNodes": -6548,
"jsHeapTotalBytes": -10371072,
"scriptDurationMs": 316.02599999999995,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21020.77700000001,
"styleRecalcs": 170,
"styleRecalcDurationMs": 19.332999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20714.175,
"heapDeltaBytes": -25424232,
"heapUsedBytes": 175642616,
"domNodes": -6548,
"jsHeapTotalBytes": 1298432,
"scriptDurationMs": 935.7610000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 127,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21143.939000000046,
"styleRecalcs": 166,
"styleRecalcDurationMs": 18.440000000000012,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20782.091,
"heapDeltaBytes": -36172392,
"heapUsedBytes": 166163004,
"domNodes": -6548,
"jsHeapTotalBytes": 3706880,
"scriptDurationMs": 971.023,
"eventListeners": -7467,
"totalBlockingTimeMs": 191,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6426.210000000026,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.19900000000003,
"layouts": 20,
"layoutDurationMs": 23.069000000000006,
"taskDurationMs": 6254.349,
"heapDeltaBytes": -33697096,
"heapUsedBytes": 174754824,
"domNodes": -5057,
"jsHeapTotalBytes": 5369856,
"scriptDurationMs": 113.99000000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 458,
"frameDurationMs": 18.33666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6279.5699999999215,
"styleRecalcs": 20,
"styleRecalcDurationMs": 98.22400000000003,
"layouts": 20,
"layoutDurationMs": 32.129000000000005,
"taskDurationMs": 6151.36,
"heapDeltaBytes": -33901352,
"heapUsedBytes": 174782764,
"domNodes": -6548,
"jsHeapTotalBytes": 4804608,
"scriptDurationMs": 136.374,
"eventListeners": -7469,
"totalBlockingTimeMs": 438,
"frameDurationMs": 18.33333333333327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 447.8070000000116,
"styleRecalcs": 12,
"styleRecalcDurationMs": 18.605,
"layouts": 2,
"layoutDurationMs": 0.36200000000000004,
"taskDurationMs": 99.94400000000002,
"heapDeltaBytes": 5071528,
"heapUsedBytes": 72525316,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.022,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 99.71499999994649,
"styleRecalcs": 7,
"styleRecalcDurationMs": 10.003000000000002,
"layouts": 1,
"layoutDurationMs": 0.2769999999999999,
"taskDurationMs": 64.478,
"heapDeltaBytes": 3140468,
"heapUsedBytes": 70090268,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.531000000000001,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## nathaniel/agent-v1/02b-crdt-write-leg #16186 +/- ##
=========================================================================
+ Coverage 82.80% 82.83% +0.03%
=========================================================================
Files 1972 1973 +1
Lines 113989 114109 +120
Branches 31570 31643 +73
=========================================================================
+ Hits 94391 94526 +135
+ Misses 19249 19237 -12
+ Partials 349 346 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 6 |
| 🟢 Low | 3 |
Panel: 7/8 reviewers contributed findings.
Reviewers that did not contribute: gpt-5.6-sol-max:edge-case (error)
|
Automated fleet review (desktop operator, Christian-authorized)
Full context for agent readersPR #16186 — design-review packet (slice 03/18, canvas primitives)Subject: Comfy-Org/ComfyUI_frontend#16186 Verdict: MERGE-AFTER-CHANGES (2 cheap correctness items; the Vue-nodes limitation remains a 1. What the PR actually doesThis slice adds a default-off
[nathaniel-pr-rationale: #16186] The PR says gesture-time mode snapshots prevent a mid-gesture The slice explicitly leaves Vue-nodes click, drag, link, resize, and widget-conversion paths 2. Alignment with our ADRs and CRDT recut
CRDT-internals audit: clean. The diff contains no import or changed path under 3. Flag-off safety — CLEANThe shared canvas code is reachable with 4. Test coverage and CIThe slice has unusually broad unit coverage: click/marquee behavior, command and mutation choke The missing regression is the defect above: no test starts a click/classic marquee/live marquee 5. VerdictMERGE-AFTER-CHANGES
Downstream gate, not a third change in this slice: do not arm picking under Vue nodes until the SourcesDirect PR diff and checks at the exact head; Glossary
|
d0f7be6 to
a021317
Compare
40875f0 to
7afee7d
Compare
e4a26ea to
1e2a212
Compare
3517440 to
5cf0cb7
Compare
1e2a212 to
5e7b61c
Compare
5cf0cb7 to
5ddf80a
Compare
|
Gate 6 FE-1756 blocker fixed.
Full context for agent readersCommit Evidence: 10 affected unit tests passed across |
de369ab to
73194ad
Compare
…aming - selectOnly canvas state with interaction gates and an isSelectOnly guard consumed by paste, delete, duplicate, and rename paths - guard editing commands (pin, mute, bypass), undo/redo, the legacy clear button, and the selection toolbox while picking is active - visibleCanvasViewport and fitGraphToView primitives; animateToBounds gains a viewport option consumed by focus and fit-to-view - behavioral pins travel with every guarded surface
- _processPrimaryButton short-circuits in select-only mode (mirrors the read_only precedent): node clicks select, empty canvas marquee-selects; alt-drag clone, reroute and link drags, the link-marker menu, and group interactions stay off - command guards added: ClearWorkflow, Collapse, Resize, the four MoveSelectedNodes (guarded in the shared helper), GroupSelectedNodes, FitGroupToContents, ConvertToSubgraph, UnpackSubgraph - workflow-lifecycle commands stay deliberately unguarded (a workflow swap exits picking rather than editing the picked canvas) - recorded in the isSelectOnly doc comment - the selection toolbox re-evaluates when the mode flips (fail-closed on entry, recompute on exit) - picking no longer reorders nodes (select-only returns before bringToFront) and no longer opens a graph change on drag start - animateToBounds rejects NaN/negative viewports and gains offset-viewport centering coverage; focusNodeInstance re-reads the canvas after the graph switch - tests: negative and positive counterfactuals for every guard, mode transition coverage, updateState's deliberate unguardedness pinned
- the select-only short-circuit's empty-canvas arm mirrors the default behavior it bypassed: the panning setting pans, the select setting marquee-selects - both marquee reconcilers select additively while picking - a marquee that misses an already-picked node no longer unpicks it; behavior outside the mode is unchanged - guards added for GroupSelectedNodes, ConvertToSubgraph, UnpackSubgraph test coverage, plus ToggleWidgetPromotion, SetDescription, and SetSearchAliases - the isSelectOnly doc names both guard layers (call-site helper and the in-library pointer gates) and keeps the exclusion list truthful - focusNodeInstance's canvas-gone-across-await branch pinned; the defence-in-depth drag-start tests labeled as such; the group-resize test discriminates the marquee from the resize path
- addNodeOnGraph refuses in select-only mode: the one choke point the search popover, node/model libraries, bookmarks, ghost-drops, and job menu all traverse - both marquee reconcilers run on the mode captured at gesture start, so a flip mid-drag cannot turn a picking marquee into a replacing one - live-select counts only selects that actually landed, ending the per-pointermove churn when the marquee holds an unselectable item - the isSelectOnly doc enumerates all four guard layers (call sites, in-library pointer gates, tracker-level undo/redo, addNodeOnGraph) and names the deferred Vue-nodes pointer paths instead of overclaiming - tests: select-arm wiring and mode-flip gesture coverage, outside-mode live-select counterfactual, pan-release and double-click suppression assertions, the addNodeOnGraph guard pair
- file drops, canvas drops, workflow insert, media-asset adds, drag-to- canvas, search box toggle, and createNode all refuse silently while the canvas is select-only - processSelect takes the gesture's picking snapshot as a required param, so the short-circuit pan click and node-drag arm cannot read a flipped mode; picks made while picking survive additive churn - app.test spreads the real litegraphUtil exports into its module mock so the new drop guard actually executes under test
- the node-press click arm resolves on the gesture-start picking snapshot like the pan and marquee arms; processSelect's picking param stays optional-with-live-default by design for non-gesture callers - replaceNodesInPlace refuses while picking, closing the missing-nodes Errors panel bypass (covers replaceGroup and replaceAllGroups) - handleMeshFile refuses before uploading, not after - the drop-handler refusal clears dragOverNode so no stale highlight or drop target survives - media-asset adds refuse first-statement, before the unsupported-type toast, so refusal is uniformly silent - the useCanvasDrop guard remains without a dedicated suite; disclosed here per the round's carve-out
|
Superseded — closing per Christian's direction.
Full context for agent readersProgram pivot 2026-08-31: the 17-slice stack targeting the v1 integration branch is superseded by the #16198 v2 merge to main @f954e479. Per program/reorientation-plan.md, all remaining value (tests, QA artifacts, invariant checks, refactors) ports to main-based successor PRs. Pre-close dossier cross-check completed for this PR; unique unsalvaged content (if any) was filed as a salvage row in the program todo before close. This closed PR remains a readable source; review/QA deliverables are posted only on open successor PRs. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 10 prior finding(s) across 1 round(s) (10 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 2 |
| 🟡 Medium | 7 |
| 🟢 Low | 1 |
Panel: 1/8 reviewers contributed findings.
Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), gemini-3.1-pro:adversarial (error), gpt-5.6-sol-max:adversarial (error), kimi-k3-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gemini-3.1-pro:edge-case (error), kimi-k3-max:edge-case (error)
The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:
src/platform/workflow/core/services/workflowService.ts:90— 🟡 Medium —queueWorkflowLoadserializes every workflow open/close/default load through the single module-levelworkflowLoadTailwith no timeout or abort, andworkflow.load()is a network fetch. If one load hangs, the tail never settles: every subsequent load queues behind it forever andcloseWorkflow's drain loop (await observedOpenTail) blocks on the same promise, wedging tab switching for the rest of the session. Add a timeout/abort to the queued load, or a way to detach a poisoned tail. Raised by 2 of 8 reviewers (gemini-3.1-pro adversarial, kimi-k3-max adversarial).
src/lib/litegraph/src/linkDeduplication.ts:219— 🟡 Medium — Replacing the oldbreakwithcontinuemakes termination depend on every failed pass adding at least one entry toskipped, butblocked.length ? blocked : movedadds nothing whenmovedis empty (blockedis derived frommoved). A pass that fails fromremovalsalone — or any pass after every remaining link has already been skipped — grows neitherskippednorsuccessfulPasses, so thewhilere-runs the identical failing pass forever and hangs graph configure. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
src/platform/workflow/templates/composables/useTemplateWorkflows.ts:159— 🟡 Medium — This rewrite drops the!response.okguard along with the comment explaining why it existed (an install pinning an older template package serves an error page here). A non-OK response whose body happens to parse as JSON — e.g. FastAPI's{"detail": ...}on a 404/500 — is handed toapp.loadGraphData, which callsclean()and wipes the user's unsaved canvas beforeconfigure()fails, andloadWorkflowTemplateignores thefalsereturn so the failure reports as success. Restore the status check and propagate theloadGraphDataboolean. Raised by 2 of 8 reviewers (kimi-k3-max adversarial, gemini-3.1-pro edge-case).
src/workbench/extensions/agent/crdt/docFrameClient.ts:145— 🟡 Medium —parseDocOpFailurereturns null for arrays and for any object lacking top-levelop_id/code/message, soparseServerDocFramestripsfailedbefore it reachestoOpsResultView— whosenormalizeFailurewas written specifically to handle the array form and the newer{index, op, code, message}form. The two layers disagree: for those shapes the sender never seesfailure.op_id, so an identified rejection with empty applied/skipped lists degrades to the anonymous-failure path and can be swallowed by a stale credit instead of settling its batch. Raised by 1 of 8 reviewers (gemini-3.1-pro edge-case).
apps/website/src/lib/markdown-twin.ts:32— 🟡 Medium — Conversion is already scoped todocument.querySelector('main'), so site chrome sits outside the root and droppingHEADERcan only remove real page content: any page whose<main>opens with a<header>(the supported-models index and the cloud pack detail pages do) loses its H1 and introduction from the advertised twin. Restrict the drop to top-level chrome rather than every nested<header>. Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).
apps/website/src/pages/p/supported-models/[slug].astro:184— 🟢 Low —fetch()resolves for HTTP 404/500, so a missing or failing.mdendpoint has its error-page body copied to the clipboard while the success checkmark is still shown. Checkresponse.okbefore reading the text and reporting success. Raised by 1 of 8 reviewers (gpt-5.6-sol-max edge-case).
| useExtensionService().registerExtension({ | ||
| name: 'Comfy.AgentPanel', | ||
| beforeLoadGraph() { | ||
| notifyMintPortsBeforeGraphLoad() |
There was a problem hiding this comment.
🟠 High — beforeLoadGraph increments the mint session's teardown depth, but afterConfigureGraph is the only decrement — and app.test.ts in this PR pins that both after-hooks are skipped when graph.configure throws (loadApiJson and the A1111 early-return path have the same shape). One failed workflow load therefore leaves teardownDepth >= 1 permanently, so shouldMint suppresses every human-edit mint for the rest of the session and the local canvas silently diverges from the bound doc; the recovery types/comfy.ts documents ("reset at the next load's beforeLoadGraph") is not implemented, since beginGraphTeardown only increments and endGraphTeardown clamps at 0. Raised by 2 of 8 reviewers (kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).
| @@ -349,7 +394,7 @@ export function useAgentCrdtFollower(workflowId: Ref<string | null>) { | |||
| lastFrameType.value = event.type | |||
| if (event instanceof CustomEvent && typeof event.detail?.seq === 'number') | |||
| lastSeq = Math.max(lastSeq, event.detail.seq) | |||
There was a problem hiding this comment.
🟠 High — lastSeq is composable-scoped and only ever grows (Math.max), yet it now feeds baseVersion: () => lastSeq for every minted op's base_version/stamp. Neither onDocReset (which resets updatesApplied and knownDocNodeIds) nor the workflow-switch watch clears it, so after a lineage break or a switch to a different workflow this tab stamps human ops with the previous document's high-water sequence — and because base_version is the primary LWW key, those ops beat every concurrent agent/other-tab write on the new doc. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| * guarded despite the resemblance: it destroys the current canvas in place, | ||
| * which is an edit, not a swap. | ||
| * | ||
| * KNOWN UNGUARDED (deferred to the mode-owner slice, which arms the mode |
There was a problem hiding this comment.
🟡 Medium — The KNOWN UNGUARDED list omits legacy DOM-widget overlays: DomWidget only drops hit-testing when widgetState.readonly (driven by canvas.read_only), and nothing maps selectOnly onto it, so during picking a user can still focus and type into a multiline-text/DOM widget and mutate the picked graph — while the equivalent canvas-drawn widget is blocked by the new _processNodeClick early return. Either gate the DOM widget layer on isSelectOnly, or add it to this list so the mode owner does not trust the list as complete. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
| }) | ||
| const mintWiring = attachMintPortWiring({ | ||
| isEnabled: () => writeDeps.isEnabled() && writeDeps.userId() !== null, | ||
| isDocBound: () => subscribedWorkflowId.value !== null, |
There was a problem hiding this comment.
🟡 Medium — isDocBound (and the sender's workflowId) read subscribedWorkflowId, which is set on subscribe intent and never cleared when the binding fails: onSubscribed with ok:false only schedules a retry, and both retry exhaustion and onSchemaError call disarmCoordinationFreeIds() without clearing it. After a server refusal or a schema rejection the mint gate stays open and human edits keep sending doc_ops for a doc the follower has already given up on, contradicting the onSchemaError comment that "nothing should mint against it". Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
|
This slice is reference-only. Accepted work is routed to #16198 and #16401. Full context for agent readersPer Christian's main-target close ruling, #16186 (03 — canvas selection and navigation) is no longer a landing vehicle. It remains readable implementation and review provenance. Broad selection-mode blocking was deliberately rejected. If a genuinely unaccounted delta is found, reopen this source or file a bounded main-based carrier rather than reviving the stacked merge path. |
browser_tests carried 10 `test.fixme(true, 'Activates after slice PR 1618x merges')` gates. All four gating PRs (#16184, #16185, #16186, #16187) were closed unmerged on 2026-09-14, along with the rest of the agent-v1 03-17 slice series, so the activation condition can never be met and the tests have never executed. None of them depend on unmerged source: they are written entirely against fixtures that exist on main (nodeOps, canvasOps, topbar, mockCloudBoot, Load3DFixtures). Removing the gates so CI reports their real state; any that fail become `test.fail()` pins with a tracking issue, per the repo's existing known-defect convention. Also drops the stale slice-PR comments, renames `slice03CanvasPrimitives.spec.ts` to `agentCanvasPrimitives.spec.ts`, and retitles the two describe blocks that named a slice number.
…-Org#18840) ## Problem `browser_tests` carried 10 tests parked behind `test.fixme(true, 'Activates after slice PR 1618x merges')`. All four gating PRs were closed unmerged on 2026-09-14, so their activation condition could never be met. | File | Tests | Gate | |---|---:|---| | `browser_tests/tests/topbar/workflowTabs.spec.ts` | 4 | Comfy-Org#16184 — closed unmerged | | `browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts` | 4 | Comfy-Org#16186 — closed unmerged | | `browser_tests/tests/billingFacadeConsumers.spec.ts` | 1 | Comfy-Org#16185 — closed unmerged | | `browser_tests/tests/load3d/load3dViewer.spec.ts` | 1 | Comfy-Org#16187 — closed unmerged | ## Change - Remove all 10 gates and the stale slice-PR comments. - Rename `slice03CanvasPrimitives.spec.ts` to `agentCanvasPrimitives.spec.ts` and remove slice numbering from its suite names. - Move reusable canvas operations into their fixture owners and make the centering and fit tests establish that a viewport change is required before checking the result. - Make the full-screen Load3D viewer respect the right workspace inset published by the Agent panel. - Preserve the widest active inset publisher during graph/linear host switches. - Keep Agent usable as a viewport-width overlay when the dock cannot fit, while publishing zero workspace inset so portaled dialogs retain positive width. Production changes span `ViewerControls.vue`, `load3dViewerDialog.ts`, `useWorkspaceInset.ts`, `load3d.ts`, `DockedAgentPanel.vue`, and `agentPanelStore.ts`, with focused component/composable and cloud browser coverage. ## First-run results 8 of the 10 tests passed on their first run. The two failures were fixed rather than pinned: - **Load3D workspace geometry:** the full-screen viewer was centered and sized against the whole viewport, so it rendered beneath the Agent dock. The cloud case now opens the real Agent panel and checks both docked and 400px overlay geometry in `load3dAgentUpdate.spec.ts` through `load3dAgentFixture`. - **Canvas primitive oracle:** `graph.serialize()` includes viewport state in `extra.ds`, so comparing the whole serialization incorrectly treated `centerOnNode()` doing its job as graph mutation. The test now compares graph data without viewport state. The centering test first shifts the viewport 400×250 away and proves the node is off-center. The fit test first zooms to 3× and proves a node is outside the canvas. Both then assert the requested operation changes the viewport; the centering test also verifies that graph data is unchanged. - Fixes Comfy-Org#18918 --------- Co-authored-by: Amp <amp@ampcode.com>
Merge after: #16145 (02b) - stacked on its branch; retargets to main as the stack lands.
Decisions: Agent V1 Decision Log
Summary
Slice 03 of the agent-v1 chain: the select-only picking mode + command guard, and the navigation primitives (fit-to-view, focus, viewport). Test-led per the chain rule; census vs merge-base: 36 files, +2039/-26.
Changes
Review Focus
Linear tickets