Repository navigation
test(agent): tighten canvas primitive selection and drag assertions - #17328
Conversation
The four specs in slice03CanvasPrimitives.spec.ts were disabled with test.fixme gated on slice PR #16186 merging. That PR remains an open draft and is no longer the landing target for this surface, so the gate could never fire. Every helper the specs use already exists on main (nodeOps.getSerializedGraph/getSelectedGraphNodesCount, NodeReference.centerOnNode/getPosition/click, canvasOps.getOffset/getNodeGeometry/expectSlotsTrackedNode, fitToViewInstant), so the specs run against main directly now.
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-12T08:51:47.437Z",
"gitSha": "6d312d1b7aa7ab7bd86daa31ce7ffacf0584171b",
"branch": "christian-byrne/lane-phs-26-0847",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.3759999999747,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.5649999999999995,
"layouts": 11,
"layoutDurationMs": 2.804,
"taskDurationMs": 426.278,
"heapDeltaBytes": 1199376,
"heapUsedBytes": 68836648,
"domNodes": -162,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.317,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2039.2040000000407,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.468000000000001,
"layouts": 11,
"layoutDurationMs": 3.1990000000000003,
"taskDurationMs": 636.697,
"heapDeltaBytes": -9839640,
"heapUsedBytes": 65622628,
"domNodes": -162,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 14.049,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1761.5069999999946,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.865000000000002,
"layouts": 11,
"layoutDurationMs": 3.2,
"taskDurationMs": 812.596,
"heapDeltaBytes": 2829916,
"heapUsedBytes": 70510196,
"domNodes": -162,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 164.12,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.0489999999436,
"styleRecalcs": 73,
"styleRecalcDurationMs": 15.450999999999999,
"layouts": 11,
"layoutDurationMs": 2.9619999999999997,
"taskDurationMs": 895.685,
"heapDeltaBytes": 427404,
"heapUsedBytes": 68352620,
"domNodes": -162,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 157.71600000000004,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186912,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1704.3370000000095,
"styleRecalcs": 19,
"styleRecalcDurationMs": 7.516000000000001,
"layouts": 13,
"layoutDurationMs": 2.9659999999999997,
"taskDurationMs": 425.415,
"heapDeltaBytes": -2776460,
"heapUsedBytes": 72253688,
"domNodes": 47,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 13.046999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.76800000004,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.926,
"layouts": 12,
"layoutDurationMs": 3.3989999999999996,
"taskDurationMs": 378.40200000000004,
"heapDeltaBytes": 20287864,
"heapUsedBytes": 88058524,
"domNodes": 47,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.716,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 675.3579999999602,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.795,
"layouts": 11,
"layoutDurationMs": 3.49,
"taskDurationMs": 497.0679999999999,
"heapDeltaBytes": 802396,
"heapUsedBytes": 68902348,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 169.713,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 676.9649999999956,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.213000000000001,
"layouts": 11,
"layoutDurationMs": 3.2369999999999997,
"taskDurationMs": 489.46900000000005,
"heapDeltaBytes": 1162152,
"heapUsedBytes": 68913044,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 170.61100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1242.4500000000194,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 945.7339999999998,
"heapDeltaBytes": -11572100,
"heapUsedBytes": 81607172,
"domNodes": -192,
"jsHeapTotalBytes": 20979712,
"scriptDurationMs": 74.099,
"eventListeners": -106,
"totalBlockingTimeMs": 549,
"frameDurationMs": 33.335135135135125,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1257.9700000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 968.439,
"heapDeltaBytes": -11460584,
"heapUsedBytes": 81586112,
"domNodes": -192,
"jsHeapTotalBytes": 19668992,
"scriptDurationMs": 71.13699999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 568,
"frameDurationMs": 33.78108108108107,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.8239999999932,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.4319999999996,
"heapDeltaBytes": -4659748,
"heapUsedBytes": 76315664,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 156.742,
"eventListeners": 0,
"totalBlockingTimeMs": 212,
"frameDurationMs": 24.99705882352943,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 842.4620000000687,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 511.1650000000001,
"heapDeltaBytes": -4405044,
"heapUsedBytes": 76621340,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 164.42200000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 225,
"frameDurationMs": 24.99999999999997,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10531.597999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9610.217,
"heapDeltaBytes": -8649124,
"heapUsedBytes": 71464836,
"domNodes": -258,
"jsHeapTotalBytes": -1183744,
"scriptDurationMs": 7763.073,
"eventListeners": -68,
"totalBlockingTimeMs": 1097,
"frameDurationMs": 31.06360946745562,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10439.816999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9553.794,
"heapDeltaBytes": 16591816,
"heapUsedBytes": 96609224,
"domNodes": -258,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 7715.655,
"eventListeners": -68,
"totalBlockingTimeMs": 843,
"frameDurationMs": 31.1,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9329.960000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8521.149,
"heapDeltaBytes": 7054072,
"heapUsedBytes": 86521404,
"domNodes": -258,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 7111.3099999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 684,
"frameDurationMs": 32.23598615916955,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10105.511999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9274.687,
"heapDeltaBytes": -5234800,
"heapUsedBytes": 73352596,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7491.117,
"eventListeners": 0,
"totalBlockingTimeMs": 819,
"frameDurationMs": 30.98036809815951,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 249.3589999999699,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.743000000000002,
"layouts": 11,
"layoutDurationMs": 3.2199999999999998,
"taskDurationMs": 209.098,
"heapDeltaBytes": -8872680,
"heapUsedBytes": 85041432,
"domNodes": 917,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.747000000000002,
"eventListeners": 195,
"totalBlockingTimeMs": 24,
"frameDurationMs": 20.5153846153846,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 247.07200000000284,
"styleRecalcs": 25,
"styleRecalcDurationMs": 18.101,
"layouts": 12,
"layoutDurationMs": 3.7839999999999994,
"taskDurationMs": 204.40499999999997,
"heapDeltaBytes": -8606712,
"heapUsedBytes": 84580564,
"domNodes": 917,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.232000000000001,
"eventListeners": 195,
"totalBlockingTimeMs": 5,
"frameDurationMs": 22.224999999999984,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2025.0050000000215,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.021,
"layouts": 8,
"layoutDurationMs": 2.7929999999999997,
"taskDurationMs": 489.6240000000001,
"heapDeltaBytes": -2754292,
"heapUsedBytes": 80115192,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 35.73,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2039.3480000000181,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.078000000000001,
"layouts": 9,
"layoutDurationMs": 2.858,
"taskDurationMs": 514.2,
"heapDeltaBytes": -2257936,
"heapUsedBytes": 81205396,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 37.337,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2660.747000000015,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.509999999999999,
"layouts": 9,
"layoutDurationMs": 2.616,
"taskDurationMs": 1741.497,
"heapDeltaBytes": -1532884,
"heapUsedBytes": 82873292,
"domNodes": -278,
"jsHeapTotalBytes": 5070848,
"scriptDurationMs": 843.304,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666249999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2256.6759999999704,
"styleRecalcs": 69,
"styleRecalcDurationMs": 7.316,
"layouts": 8,
"layoutDurationMs": 2.3560000000000003,
"taskDurationMs": 1511.28,
"heapDeltaBytes": -559400,
"heapUsedBytes": 83609548,
"domNodes": -258,
"jsHeapTotalBytes": 5332992,
"scriptDurationMs": 817.877,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.044696969696975,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3587.9869999999983,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.189,
"layouts": 66,
"layoutDurationMs": 11.683,
"taskDurationMs": 1672.5890000000002,
"heapDeltaBytes": -17461312,
"heapUsedBytes": 67770936,
"domNodes": -234,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 803.732,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665581395348834,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3520.754000000011,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.549000000000001,
"layouts": 65,
"layoutDurationMs": 11.332000000000003,
"taskDurationMs": 1600.5190000000002,
"heapDeltaBytes": 5649412,
"heapUsedBytes": 91498536,
"domNodes": -234,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 768.1510000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.745238095238093,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2996.880000000033,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.137000000000002,
"layouts": 7,
"layoutDurationMs": 2.414,
"taskDurationMs": 1956.1929999999998,
"heapDeltaBytes": 12253832,
"heapUsedBytes": 99441840,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 963.312,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.948587570621466,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3206.7520000000513,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.2410000000000005,
"layouts": 4,
"layoutDurationMs": 1.475,
"taskDurationMs": 2059.728,
"heapDeltaBytes": -10178184,
"heapUsedBytes": 77827352,
"domNodes": 0,
"jsHeapTotalBytes": 8253440,
"scriptDurationMs": 1032.765,
"eventListeners": 182,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.200534759358288,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2074.2440000000215,
"styleRecalcs": 7,
"styleRecalcDurationMs": 3.9570000000000003,
"layouts": 7,
"layoutDurationMs": 2.2720000000000007,
"taskDurationMs": 641.48,
"heapDeltaBytes": 16000064,
"heapUsedBytes": 93655640,
"domNodes": -258,
"jsHeapTotalBytes": 913408,
"scriptDurationMs": 36.096999999999994,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666935483870965,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2046.369000000027,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.955000000000001,
"layouts": 8,
"layoutDurationMs": 2.361,
"taskDurationMs": 609.104,
"heapDeltaBytes": -620616,
"heapUsedBytes": 86301128,
"domNodes": -258,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 33.791,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 583.9789999999994,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.047,
"layouts": 10,
"layoutDurationMs": 2.7419999999999995,
"taskDurationMs": 377.394,
"heapDeltaBytes": 21274108,
"heapUsedBytes": 89270560,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 143.906,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 596.7200000000048,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.745000000000001,
"layouts": 11,
"layoutDurationMs": 2.777,
"taskDurationMs": 446.77,
"heapDeltaBytes": 280768,
"heapUsedBytes": 77697360,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 140.6,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2043.3760000000234,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.199000000000001,
"layouts": 12,
"layoutDurationMs": 3.7999999999999994,
"taskDurationMs": 575.5920000000001,
"heapDeltaBytes": -6436284,
"heapUsedBytes": 70439564,
"domNodes": -180,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 9.074000000000002,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2011.6160000000036,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.0889999999999995,
"layouts": 12,
"layoutDurationMs": 4.071,
"taskDurationMs": 417.04499999999996,
"heapDeltaBytes": 2198644,
"heapUsedBytes": 70483964,
"domNodes": -180,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8.928,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.4050000000193,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.598,
"layouts": 11,
"layoutDurationMs": 3.01,
"taskDurationMs": 872.922,
"heapDeltaBytes": 749352,
"heapUsedBytes": 69157908,
"domNodes": -192,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 112.246,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.6770000000324,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.118999999999996,
"layouts": 10,
"layoutDurationMs": 3.0449999999999995,
"taskDurationMs": 724.703,
"heapDeltaBytes": -3756092,
"heapUsedBytes": 64866488,
"domNodes": -192,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 113.38999999999999,
"eventListeners": -112,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1452.291999999943,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.396,
"layouts": 5,
"layoutDurationMs": 17.588,
"taskDurationMs": 909.418,
"heapDeltaBytes": 38385488,
"heapUsedBytes": 117596404,
"domNodes": 15956,
"jsHeapTotalBytes": 16130048,
"scriptDurationMs": 30.88699999999999,
"eventListeners": 3244,
"totalBlockingTimeMs": 163,
"frameDurationMs": 19.81891891891891,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10232.574,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.95,
"layouts": 9,
"layoutDurationMs": 2.757,
"taskDurationMs": 6186.852,
"heapDeltaBytes": -15808412,
"heapUsedBytes": 82678852,
"domNodes": -258,
"jsHeapTotalBytes": 4026368,
"scriptDurationMs": 2810.524,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.720424836601307,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9238.636000000042,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.081,
"layouts": 7,
"layoutDurationMs": 8.277,
"taskDurationMs": 5812.679,
"heapDeltaBytes": -11671756,
"heapUsedBytes": 86752940,
"domNodes": -258,
"jsHeapTotalBytes": 3239936,
"scriptDurationMs": 2669.883,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72649727767695,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23307.683999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22910.949,
"heapDeltaBytes": -10778872,
"heapUsedBytes": 289951856,
"domNodes": -3330,
"jsHeapTotalBytes": 14143488,
"scriptDurationMs": 319.32000000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.17086206896551,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16736.752000000022,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15708.543000000001,
"heapDeltaBytes": -9192800,
"heapUsedBytes": 288911200,
"domNodes": -3330,
"jsHeapTotalBytes": 6750208,
"scriptDurationMs": 275.134,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.8993091537133,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-pan",
"durationMs": 28756.077000000005,
"styleRecalcs": 181,
"styleRecalcDurationMs": 18.081000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28376.012000000002,
"heapDeltaBytes": -4563832,
"heapUsedBytes": 272094844,
"domNodes": -3330,
"jsHeapTotalBytes": 10211328,
"scriptDurationMs": 899.12,
"eventListeners": -651,
"totalBlockingTimeMs": 15,
"frameDurationMs": 53.26962962962963,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27995.575999999914,
"styleRecalcs": 180,
"styleRecalcDurationMs": 16.881000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27616.211000000003,
"heapDeltaBytes": -19846344,
"heapUsedBytes": 276113724,
"domNodes": -3330,
"jsHeapTotalBytes": 11259904,
"scriptDurationMs": 903.842,
"eventListeners": -651,
"totalBlockingTimeMs": 9,
"frameDurationMs": 52.928166351606805,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8009.552999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.88200000000003,
"layouts": 20,
"layoutDurationMs": 21.848999999999993,
"taskDurationMs": 7865.659,
"heapDeltaBytes": -4442668,
"heapUsedBytes": 245458932,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 122.489,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 43.95439560439561,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 8125.197000000071,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.25799999999998,
"layouts": 20,
"layoutDurationMs": 22.279000000000007,
"taskDurationMs": 7977.752999999999,
"heapDeltaBytes": 29152192,
"heapUsedBytes": 280226852,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 117.996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 45.343016759776546,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11597.512999999935,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11341.992,
"heapDeltaBytes": 185052,
"heapUsedBytes": 262542840,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 160.12199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.39761904761904,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11417.966999999975,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11188.583999999999,
"heapDeltaBytes": 4302896,
"heapUsedBytes": 263242112,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.93800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.230584192439856,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 139.487000000031,
"styleRecalcs": 10,
"styleRecalcDurationMs": 15.221000000000002,
"layouts": 10,
"layoutDurationMs": 4.215,
"taskDurationMs": 111.51000000000002,
"heapDeltaBytes": 4767668,
"heapUsedBytes": 71415760,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.265,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 461.15500000007614,
"styleRecalcs": 12,
"styleRecalcDurationMs": 11.997,
"layouts": 12,
"layoutDurationMs": 3.7030000000000003,
"taskDurationMs": 112.58900000000003,
"heapDeltaBytes": 6586972,
"heapUsedBytes": 73302428,
"domNodes": 95,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.905000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 546.8869999999697,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.349,
"layouts": 76,
"layoutDurationMs": 15.805,
"taskDurationMs": 494.314,
"heapDeltaBytes": 12530996,
"heapUsedBytes": 84364592,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 238.724,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 537.3479999999518,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.012,
"layouts": 76,
"layoutDurationMs": 16.262,
"taskDurationMs": 491.354,
"heapDeltaBytes": 12144212,
"heapUsedBytes": 85680300,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 234.572,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 621.0569999999507,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.453,
"layouts": 76,
"layoutDurationMs": 15.032,
"taskDurationMs": 594.117,
"heapDeltaBytes": 20504636,
"heapUsedBytes": 192946440,
"domNodes": 4,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 225.846,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668421052631594,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 587.8079999999954,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.915,
"layouts": 76,
"layoutDurationMs": 14.299,
"taskDurationMs": 543.541,
"heapDeltaBytes": 502176,
"heapUsedBytes": 131577348,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 209.354,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668571428571443,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2264 passed, 0 failed📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ae3afc4705a12efcaecde072e5299be0befc4767
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests.
@@ Coverage Diff @@
## main #17328 +/- ##
==========================================
- Coverage 86.09% 76.89% -9.20%
==========================================
Files 3651 2443 -1208
Lines 174174 151168 -23006
Branches 48040 31225 -16815
==========================================
- Hits 149949 116248 -33701
- Misses 22215 34745 +12530
+ Partials 2010 175 -1835
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested
I found two newly enabled tests whose assertions do not observe the behavior named by the test. Both still pass if their action is replaced with a no-op, so they need behavioral assertions before they provide regression coverage.
|
|
||
| const before = await comfyPage.nodeOps.getSerializedGraph() | ||
| delete before.extra?.ds | ||
| await node.centerOnNode() |
There was a problem hiding this comment.
This assertion no longer observes whether the node was focused. centerOnNode() changes canvas.ds.offset; after extra.ds is removed from both serializations, replacing this call with a no-op still passes. Please keep the semantic graph comparison and also assert that the node reaches the canvas center, or assert the expected viewport offset.
There was a problem hiding this comment.
Fixed on main by #18840 and #19679, which this branch now includes through the merge in c7ff635. In agentCanvasPrimitives.spec.ts the focus test pans the node off-centre, asserts that it starts more than 100px away, and then asserts that the node centre lands on the canvas centre. A no-op centerOnNode() now fails.
| .toEqual(before) | ||
| }) | ||
|
|
||
| test('fits the complete graph when a node is selected', async ({ |
There was a problem hiding this comment.
A no-op fitToViewInstant() still passes this check because the default canvas offset is already [0, 0], and both values are finite. Please arrange a displaced view and assert that the complete graph is fitted, for example by checking that every node bound, including an unselected node, is inside the resulting viewport.
DrJKL
left a comment
There was a problem hiding this comment.
The two existing P1 findings still stand. This targeted Playwright pass found four more issues that have no anchorable added line because the PR activates previously skipped test bodies by removing their fixme gates.
Additional findings
-
[P2] The selection test checks cardinality, not identity. The test clicks a known node but only waits for the selected count to become one. Selecting a different node still passes.
nodeOps.getSelectedNodeIds()already exposes the stronger fact, so this should assert that the selected ID isnode.id. -
[P2] The drag test does not prove that only the target node moved correctly.
expectSlotsTrackedNode()accepts any movement over one pixel and derives each slot expectation from whatever delta occurred. A wrong drag distance or collateral movement of another node still passes. Please assert the target's expected delta, selected IDs, and one non-target node's unchanged geometry while retaining the slot check. -
[P3] Use the existing node drag helper.
NodeReference.dragBy()already starts from the node title, converts coordinates, and delegates toCanvasHelper.dragAndDrop(). Replace thegetPosition()plus rawdragAndDrop()recipe withawait node.dragBy({ x: 40, y: 20 }). -
[P3] Restore canvas view after each test. This describe now runs focus, fit, and drag operations but has no
afterEach. The browser-test rulebook requirescomfyPage.canvasOps.resetView()after tests that change canvas view.
Existing findings confirmed
- P1 focus assertion: deleting
extra.dsremoves the only observed viewport state, so a no-opcenterOnNode()passes. - P1 fit assertion: checking only that the default offset is finite lets a no-op or selection-only fit pass.
Coverage
I reviewed the changed spec at this head against all 23 repository Playwright rules and checks A through H. The helper inventory covered 94 methods across CanvasHelper, NodeOperationsHelper, and the node and slot references. The interaction table had 18 rows. Rulebook items 8 and 14 produced findings. Checks B through G and the other numbered rules were clear or not applicable.
| // main. They were originally gated behind slice PR 16186 | ||
| // (https://github.com/Comfy-Org/ComfyUI_frontend/pull/16186), which stayed an | ||
| // open draft and is no longer the landing target for this surface, so the gate | ||
| // could never fire. They run against main directly now; all helpers they use |
There was a problem hiding this comment.
[P3] The PR-history rationale above explains why these tests now run, but the helper inventory from here through line 13 only repeats calls visible immediately below and will drift as the tests change. Please keep the non-obvious rationale and delete the API checklist.
DrJKL
left a comment
There was a problem hiding this comment.
Concrete fixes for the four body-only findings in review 5185758938 are below. The helper-header cleanup is attached inline.
This uses the existing NodeOperationsHelper.getSelectedNodeIds() (browser_tests/fixtures/helpers/NodeOperationsHelper.ts:44-50), NodeOperationsHelper.getNodeRefById() (:112-114), CanvasHelper.resetView() (browser_tests/fixtures/helpers/CanvasHelper.ts:25-31), CanvasHelper.getNodeGeometry() (:223-235), CanvasHelper.expectSlotsTrackedNode() (:237-256), and NodeReference.dragBy() (browser_tests/fixtures/utils/litegraphUtils.ts:324-342).
diff --git a/browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts b/browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts
--- a/browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts
+++ b/browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts
@@ -15,6 +15,10 @@ test.describe(
'Agent canvas primitives from slice 03',
{ tag: '@agent' },
() => {
+ test.afterEach(async ({ comfyPage }) => {
+ await comfyPage.canvasOps.resetView()
+ })
+
test('select-only preserves the semantic workflow graph', async ({
comfyPage
}) => {
@@ -26,8 +30,8 @@ test.describe(
await node.click('title')
await expect
- .poll(() => comfyPage.nodeOps.getSelectedGraphNodesCount())
- .toBe(1)
+ .poll(() => comfyPage.nodeOps.getSelectedNodeIds())
+ .toEqual([node.id])
await expect
.poll(() => comfyPage.nodeOps.getSerializedGraph())
.toEqual(before)
@@ -72,14 +76,30 @@ test.describe(
expect(node).not.toBeNull()
if (!node) return
+ const graph = await comfyPage.nodeOps.getSerializedGraph()
+ const untouchedNodeData = graph.nodes.find(({ id }) => id !== node.id)
+ expect(untouchedNodeData).toBeDefined()
+ if (!untouchedNodeData) return
+ const untouchedNode = await comfyPage.nodeOps.getNodeRefById(
+ untouchedNodeData.id
+ )
+
const before = await comfyPage.canvasOps.getNodeGeometry(node.id)
- const position = await node.getPosition()
- await comfyPage.canvasOps.dragAndDrop(position, {
- x: position.x + 40,
- y: position.y + 20
- })
+ const untouchedBefore = await comfyPage.canvasOps.getNodeGeometry(
+ untouchedNode.id
+ )
+ await node.dragBy({ x: 40, y: 20 })
const after = await comfyPage.canvasOps.getNodeGeometry(node.id)
+ const untouchedAfter = await comfyPage.canvasOps.getNodeGeometry(
+ untouchedNode.id
+ )
+ await expect
+ .poll(() => comfyPage.nodeOps.getSelectedNodeIds())
+ .toEqual([node.id])
+ expect(after.pos[0]).toBeCloseTo(before.pos[0] + 40, 0)
+ expect(after.pos[1]).toBeCloseTo(before.pos[1] + 20, 0)
+ expect(untouchedAfter.pos).toEqual(untouchedBefore.pos)
comfyPage.canvasOps.expectSlotsTrackedNode(after, before)
})
}| // These cases cover canvas selection / navigation behaviour that exists on | ||
| // main. They were originally gated behind slice PR 16186 | ||
| // (https://github.com/Comfy-Org/ComfyUI_frontend/pull/16186), which stayed an | ||
| // open draft and is no longer the landing target for this surface, so the gate | ||
| // could never fire. They run against main directly now; all helpers they use | ||
| // (nodeOps.getSerializedGraph/getSelectedGraphNodesCount, NodeReference | ||
| // centerOnNode/getPosition/click, canvasOps.getOffset/getNodeGeometry/ | ||
| // expectSlotsTrackedNode, fitToViewInstant) already exist on main. |
There was a problem hiding this comment.
Follow-up to the helper-list finding. This keeps the historical context without maintaining an API inventory:
| // These cases cover canvas selection / navigation behaviour that exists on | |
| // main. They were originally gated behind slice PR 16186 | |
| // (https://github.com/Comfy-Org/ComfyUI_frontend/pull/16186), which stayed an | |
| // open draft and is no longer the landing target for this surface, so the gate | |
| // could never fire. They run against main directly now; all helpers they use | |
| // (nodeOps.getSerializedGraph/getSelectedGraphNodesCount, NodeReference | |
| // centerOnNode/getPosition/click, canvasOps.getOffset/getNodeGeometry/ | |
| // expectSlotsTrackedNode, fitToViewInstant) already exist on main. | |
| // These cases were previously gated behind draft PR #16186, which is no longer | |
| // the landing target for this surface. |
There was a problem hiding this comment.
Superseded: the file this suggestion targeted no longer exists on the branch after the merge in c7ff635. The body fixes from this review landed as follows: dragBy and the header removal came from main, and selection identity and the target-only drag check are in 38b5b2a. I withdrew the afterEach reset because each comfyPage test clears storage and reloads the app in ComfyPage.setup(), so viewport state cannot leak between tests.
… primitives Check the clicked node is the one selected rather than only counting selections, and prove the drag leaves every other node unchanged. Drop two explanatory comments; the assertion messages already state intent. Amp-Thread-ID: https://ampcode.com/threads/T-01a0895f-b42f-7795-ac16-e5af94254062
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 6 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 38b5b2a | Docs | View more details | Give us feedback! |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: approved at 38b5b2a.
At the maintainer's request I pushed the two commits being approved, c7ff635 (merge of main) and 38b5b2a (assertion tightening). No independent reviewer has looked at them.
The original change, un-gating the slice03 canvas primitive specs, landed separately in #18840 and #19679. The merge takes main's deletion of slice03CanvasPrimitives.spec.ts. What remains is a +10/-5 change to agentCanvasPrimitives.spec.ts. The select-only test now checks which node is selected, not just how many. The drag test now proves every other node is unchanged. Two explanatory comments are gone because the assertion messages already say the same thing.
Review record
- P1, focus test passed with a no-op
centerOnNode()(r3975254557): fixed on main by #18840. Reply: r4246095282. - P1, fit test only checked that the offset is finite (r3975254559): fixed on main by #18840. Reply: r4246095538.
- P2, selection identity (review 5185758938 body): fixed in 38b5b2a.
getSelectedNodeIds()must equal[node.id]. - P2, drag target-only proof (review 5185758938 body): fixed in 38b5b2a. Every other serialized node must be unchanged after
dragBy. - P3, reuse
NodeReference.dragBy(review 5185758938 body): fixed on main by #18840. - P3,
afterEachresetView(review 5185758938 body): withdrawn.ComfyPage.setup()clears storage and reloads the app for every test, so viewport state cannot leak between tests. Reply: r4246095901. - P3, redundant header comment (r3995547971): main removed the header. The two remaining explanatory comments were removed in 38b5b2a. Reply: r4246095746.
- Proposed-fix review (5185959151): superseded by the items above.
- CodeRabbit: approved at the new head with no findings.
Checks at 38b5b2a: pnpm typecheck:browser, oxlint, and oxfmt --check pass on the changed spec. playwright test --project=chromium --list finds 4 tests.
Hosted CI: CI: Tests E2E passed. Chromium shard 1/16, which contains this spec, ran 141 tests: 141 passed, 0 flaky. Cloud shard 1/4 first failed in the unrelated agentAttachmentUpload.spec.ts with "Route is already handled". That spec runs only in the cloud project, which this change does not touch, and it passed on rerun. The red entries in the check list come from a duplicate run that was cancelled at push time. Each of those check names has a later successful run.
Tightens two agent canvas primitive e2e assertions that pass for a wrong implementation.
The original goal of this PR, running the slice03 canvas primitive specs against main, landed separately in #18840 (rename to
agentCanvasPrimitives.spec.ts) and #19679. Merging main brought those in and dropped the oldslice03CanvasPrimitives.spec.ts. What remains here are the review findings that still applied to the landed file.getSelectedNodeIds()equals[node.id]instead of counting selected nodes, so selecting the wrong node fails.Checks:
pnpm typecheck:browser,oxlint,oxfmt --check,playwright test --project=chromium --list(4 tests). The runtime assertions are covered by the e2e CI shards.