Repository navigation
test: cover offset canvas viewport framing - #16357
Conversation
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Comment |
|
TL;DR: exact head No blocking finding in self-review. The change is test-only and avoids the Full context for agent readersReviewed the exact one-file diff against Verification:
Semantic-transplant source provenance: frozen slice PR #16186 test behavior, evaluated against current frontend |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1888 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.63 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.78 kB (baseline 3.78 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.4 MB (baseline 1.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.5 kB (baseline 27.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 115 kB (baseline 115 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.57 MB (baseline 3.57 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 555 kB (baseline 555 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.2 MB (baseline 16.2 MB) • ⚪ 0 BBundles that do not match a named category Status: 294 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-31T05:45:28.768Z",
"gitSha": "f441618b72203daf21f12f5c669d939eb8a8b955",
"branch": "christian-byrne/prlc2-focus-canvas-baselines",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2052.940999999919,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.67,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.2389999999999,
"heapDeltaBytes": -13651416,
"heapUsedBytes": 56265536,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.120999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2071.674999999914,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.059000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 603.803,
"heapDeltaBytes": -2865968,
"heapUsedBytes": 66852552,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.966999999999999,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2043.9830000000256,
"styleRecalcs": 82,
"styleRecalcDurationMs": 46.945,
"layouts": 14,
"layoutDurationMs": 5.09,
"taskDurationMs": 1066.0880000000002,
"heapDeltaBytes": -8956720,
"heapUsedBytes": 61031600,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 180.291,
"eventListeners": -159,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1852.975000000015,
"styleRecalcs": 74,
"styleRecalcDurationMs": 43.047999999999995,
"layouts": 14,
"layoutDurationMs": 4.523,
"taskDurationMs": 961.0119999999998,
"heapDeltaBytes": -8651668,
"heapUsedBytes": 61283788,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 162.34400000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1671.0440000000517,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.826,
"layouts": 6,
"layoutDurationMs": 1.053,
"taskDurationMs": 372.746,
"heapDeltaBytes": 4431200,
"heapUsedBytes": 74598348,
"domNodes": 78,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.342,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.7530000001298,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.997,
"layouts": 6,
"layoutDurationMs": 1.028,
"taskDurationMs": 380.769,
"heapDeltaBytes": 4421776,
"heapUsedBytes": 73911764,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.606000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 677.6830000000018,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.7829999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.244,
"heapDeltaBytes": 17828948,
"heapUsedBytes": 88007684,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 158.25799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 710.2460000000974,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.099000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.54,
"heapDeltaBytes": 18336972,
"heapUsedBytes": 87646536,
"domNodes": 14,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 164.881,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2049.1409999999632,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.1579999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 638.44,
"heapDeltaBytes": -13662620,
"heapUsedBytes": 86542512,
"domNodes": -268,
"jsHeapTotalBytes": -1085440,
"scriptDurationMs": 37.826,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2036.9180000000142,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.822000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 643.719,
"heapDeltaBytes": -13520788,
"heapUsedBytes": 86388128,
"domNodes": -266,
"jsHeapTotalBytes": -2396160,
"scriptDurationMs": 34.695,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2346.5270000000373,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.510000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1662.9110000000003,
"heapDeltaBytes": 18906860,
"heapUsedBytes": 84320400,
"domNodes": -272,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 796.7429999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2524.599999999964,
"styleRecalcs": 63,
"styleRecalcDurationMs": 9.343,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1688.9059999999997,
"heapDeltaBytes": 25241656,
"heapUsedBytes": 91085004,
"domNodes": 2,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 812.711,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3711.6920000000846,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.952,
"layouts": 60,
"layoutDurationMs": 12.053,
"taskDurationMs": 1777.145,
"heapDeltaBytes": 10358328,
"heapUsedBytes": 75125060,
"domNodes": -279,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 768.681,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3719.03999999995,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.816999999999997,
"layouts": 60,
"layoutDurationMs": 12.766,
"taskDurationMs": 1795.228,
"heapDeltaBytes": 11708136,
"heapUsedBytes": 79152120,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 783.529,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3121.5550000000576,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.0459999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2008.9900000000002,
"heapDeltaBytes": 27767620,
"heapUsedBytes": 95459648,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 996.0339999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3167.8309999999783,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.076000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2005.5149999999999,
"heapDeltaBytes": 23117724,
"heapUsedBytes": 89441752,
"domNodes": -278,
"jsHeapTotalBytes": 2514944,
"scriptDurationMs": 967.0799999999999,
"eventListeners": -1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2000.7269999999835,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.0539999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.752,
"heapDeltaBytes": 21763612,
"heapUsedBytes": 87608744,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.285,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2054.960999999821,
"styleRecalcs": 4,
"styleRecalcDurationMs": 6.0939999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.4830000000001,
"heapDeltaBytes": 9716108,
"heapUsedBytes": 86228520,
"domNodes": -275,
"jsHeapTotalBytes": -2170880,
"scriptDurationMs": 33.389999999999986,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 627.8179999999338,
"styleRecalcs": 44,
"styleRecalcDurationMs": 10.671,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.92500000000007,
"heapDeltaBytes": 13965192,
"heapUsedBytes": 85613512,
"domNodes": 14,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 139.92499999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 609.7909999998592,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.367999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 424.25100000000003,
"heapDeltaBytes": 14796088,
"heapUsedBytes": 87048236,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.377,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.3930000000128,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.184000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.6700000000001,
"heapDeltaBytes": -10892464,
"heapUsedBytes": 61231076,
"domNodes": -294,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.761000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2017.955000000029,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.572999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.59,
"heapDeltaBytes": -1868048,
"heapUsedBytes": 69619972,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.934,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1754.246999999964,
"styleRecalcs": 78,
"styleRecalcDurationMs": 38.578,
"layouts": 18,
"layoutDurationMs": 5.8950000000000005,
"taskDurationMs": 846.7580000000002,
"heapDeltaBytes": -13096844,
"heapUsedBytes": 58944404,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 113.958,
"eventListeners": -203,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1779.301999999916,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.382999999999996,
"layouts": 18,
"layoutDurationMs": 5.401,
"taskDurationMs": 897.0749999999999,
"heapDeltaBytes": -12986364,
"heapUsedBytes": 58595124,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 115.642,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1428.154999999947,
"styleRecalcs": 18,
"styleRecalcDurationMs": 32.779,
"layouts": 14,
"layoutDurationMs": 16.252,
"taskDurationMs": 1037.601,
"heapDeltaBytes": -7514068,
"heapUsedBytes": 86756324,
"domNodes": 13671,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 31.003000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9140.782999999941,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.082,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6064.939,
"heapDeltaBytes": 9905752,
"heapUsedBytes": 85072400,
"domNodes": -273,
"jsHeapTotalBytes": 118784,
"scriptDurationMs": 2707.143,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9260.540000000106,
"styleRecalcs": 247,
"styleRecalcDurationMs": 39.083000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6176.245,
"heapDeltaBytes": 14161192,
"heapUsedBytes": 89189032,
"domNodes": -271,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 2711.614,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17947.63499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17123.322,
"heapDeltaBytes": -37552176,
"heapUsedBytes": 175905788,
"domNodes": -6548,
"jsHeapTotalBytes": -6733824,
"scriptDurationMs": 288.146,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18407.275000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17549.703,
"heapDeltaBytes": -44204588,
"heapUsedBytes": 168877456,
"domNodes": -6548,
"jsHeapTotalBytes": -8306688,
"scriptDurationMs": 287.98799999999994,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22077.077999999914,
"styleRecalcs": 168,
"styleRecalcDurationMs": 21.849000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21854.076,
"heapDeltaBytes": -49466192,
"heapUsedBytes": 176035672,
"domNodes": -6548,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 975.3199999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 98,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21725.44599999992,
"styleRecalcs": 171,
"styleRecalcDurationMs": 19.257999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21446.533000000003,
"heapDeltaBytes": -36655604,
"heapUsedBytes": 176647628,
"domNodes": -6548,
"jsHeapTotalBytes": -9879552,
"scriptDurationMs": 914.979,
"eventListeners": -7467,
"totalBlockingTimeMs": 127,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6532.314000000042,
"styleRecalcs": 20,
"styleRecalcDurationMs": 103.40500000000003,
"layouts": 20,
"layoutDurationMs": 27.838,
"taskDurationMs": 6429.579999999999,
"heapDeltaBytes": -39549272,
"heapUsedBytes": 173652456,
"domNodes": -6548,
"jsHeapTotalBytes": 606208,
"scriptDurationMs": 114.65400000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 705,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6420.431000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.69199999999998,
"layouts": 20,
"layoutDurationMs": 23.011000000000003,
"taskDurationMs": 6283.372,
"heapDeltaBytes": -27828620,
"heapUsedBytes": 174495896,
"domNodes": -6548,
"jsHeapTotalBytes": 10489856,
"scriptDurationMs": 111.495,
"eventListeners": -7471,
"totalBlockingTimeMs": 476,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 118.8640000000305,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.266000000000002,
"layouts": 2,
"layoutDurationMs": 0.7750000000000001,
"taskDurationMs": 80.08200000000001,
"heapDeltaBytes": 3162664,
"heapUsedBytes": 71234164,
"domNodes": 109,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.545999999999998,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 104.27599999979975,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.434999999999999,
"layouts": 2,
"layoutDurationMs": 1.5399999999999996,
"taskDurationMs": 76.36300000000001,
"heapDeltaBytes": 3120392,
"heapUsedBytes": 70737464,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.886000000000002,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16357 +/- ##
==========================================
+ Coverage 81.25% 83.25% +1.99%
==========================================
Files 2402 2022 -380
Lines 123442 116938 -6504
Branches 34492 33011 -1481
==========================================
- Hits 100300 97352 -2948
+ Misses 22543 19233 -3310
+ Partials 599 353 -246
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Full context for agent readersThe added cases pin offset viewport framing without changing runtime behavior. CI is green at head 1ffcdfb. The review checked the PR diff against |
|
Salvage cross-check for Source grounding: |
Summary
Adds permanent regression coverage for canvas framing inside offset viewports, preserving the focus/canvas semantic-transplant behavior from the retired slice stack on current
main.Changes
Review Focus
Please verify the expected screen-center calculations for width- and height-constrained viewports. This is test-only and intentionally does not overlap the navigation-store refactor in #16342.
Screenshots (if applicable)
Not applicable; test-only change.
EVX re-audit mapping
Historical offset-framing coverage from
949abe26,511b87ed, andff9ea5e5is terminally carried here at1ffcdfb43fc9for #16386. The generic inset/occlusion implementation remainsNEEDS-REDESIGNunder the existingport-3disposition; this PR does not implement that redesign or any post-agent-edit fit behavior.