Skip to content

test: un-gate 10 e2e tests behind abandoned agent-v1 slice PRs - #18838

Closed
christian-byrne wants to merge 1 commit into
Comfy-Org:mainfrom
christian-byrne:test/ungate-abandoned-slice-fixmes
Closed

christian-byrne wants to merge 1 commit into
Comfy-Org:mainfrom
christian-byrne:test/ungate-abandoned-slice-fixmes

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Problem

browser_tests carries 10 tests parked behind test.fixme(true, 'Activates after slice PR 1618x merges'). All four gating PRs were closed unmerged on 2026-09-14 — along with the rest of the agent-v1 03–17 slice series (only 00/18 #16071 and 01/18 #16075 ever landed). The activation condition can never be met, so these are not pending tests, they are dead ones. They have never executed.

File Tests Gate
browser_tests/tests/topbar/workflowTabs.spec.ts 4 #16184 — closed unmerged
browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts 4 #16186 — closed unmerged
browser_tests/tests/billingFacadeConsumers.spec.ts 1 #16185 — closed unmerged
browser_tests/tests/load3d/load3dViewer.spec.ts 1 #16187 — closed unmerged

Surfaced by the disabled-test inventory: 10 of the repo's 17 never-executing tests are this one cause.

Change

Remove the 10 gates. None of these tests depend on unmerged source — they are written entirely against fixtures that exist on main today (nodeOps, canvasOps, menu.topbar, mockCloudBoot, Load3DFixtures). They were authored test-led ahead of a slicing plan that was abandoned, not ahead of missing APIs.

Also removes the stale slice-PR comments, renames slice03CanvasPrimitives.spec.ts → agentCanvasPrimitives.spec.ts, and retitles the two describe blocks that named a slice number.

Expected outcome

This PR is a measurement. CI is the first run these tests have ever had, so some may fail. Anything that fails is a real, previously-invisible defect — it gets converted to a test.fail() pin with a tracking issue (the repo's existing "pin the bug, don't hide it" convention), not re-hidden behind fixme. Anything that passes is coverage we get back for free.

No source changes.

browser_tests carried 10 `test.fixme(true, 'Activates after slice PR
1618x merges')` gates. All four gating PRs (Comfy-Org#16184, Comfy-Org#16185, Comfy-Org#16186,
Comfy-Org#16187) were closed unmerged on 2026-09-14, along with the rest of the
agent-v1 03-17 slice series, so the activation condition can never be
met and the tests have never executed.

None of them depend on unmerged source: they are written entirely
against fixtures that exist on main (nodeOps, canvasOps, topbar,
mockCloudBoot, Load3DFixtures). Removing the gates so CI reports their
real state; any that fail become `test.fail()` pins with a tracking
issue, per the repo's existing known-defect convention.

Also drops the stale slice-PR comments, renames
`slice03CanvasPrimitives.spec.ts` to `agentCanvasPrimitives.spec.ts`,
and retitles the two describe blocks that named a slice number.
@christian-byrne
christian-byrne requested a review from a team September 25, 2026 11:40
@github-actions

github-actions Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built

Details

⏰ Completed at: 09/25/2026, 11:41:27 AM UTC

Links

🎭 Playwright: ⏳ Running...

⚡ Performance

⏳ Performance tests in progress…

@coderabbitai

coderabbitai Bot commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 3921d423-f672-468e-937e-987a096b93d5

📥 Commits

Reviewing files that changed from the base of the PR and between 4c04e82 and 3578569.

📒 Files selected for processing (5)
  • browser_tests/tests/agent/agentCanvasPrimitives.spec.ts
  • browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts
  • browser_tests/tests/billingFacadeConsumers.spec.ts
  • browser_tests/tests/load3d/load3dViewer.spec.ts
  • browser_tests/tests/topbar/workflowTabs.spec.ts
 _____________________________
< Lint today, shine tomorrow. >
 -----------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Superseded by #18840 — same commit, pushed to an upstream branch so the e2e workflows actually run (fork PRs leave them skipped-but-green, and this PR is a CI measurement).

@christian-byrne
christian-byrne deleted the test/ungate-abandoned-slice-fixmes branch September 25, 2026 11:44
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-billing Agent admission limits, credits, subscriptions or paywalls agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration labels Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-billing Agent admission limits, credits, subscriptions or paywalls agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants