Repository navigation
test: un-gate 10 e2e tests behind abandoned agent-v1 slice PRs - #18838
Closed
christian-byrne wants to merge 1 commit into
Closed
christian-byrne wants to merge 1 commit into
christian-byrne wants to merge 1 commit into
Conversation
browser_tests carried 10 `test.fixme(true, 'Activates after slice PR 1618x merges')` gates. All four gating PRs (Comfy-Org#16184, Comfy-Org#16185, Comfy-Org#16186, Comfy-Org#16187) were closed unmerged on 2026-09-14, along with the rest of the agent-v1 03-17 slice series, so the activation condition can never be met and the tests have never executed. None of them depend on unmerged source: they are written entirely against fixtures that exist on main (nodeOps, canvasOps, topbar, mockCloudBoot, Load3DFixtures). Removing the gates so CI reports their real state; any that fail become `test.fail()` pins with a tracking issue, per the repo's existing known-defect convention. Also drops the stale slice-PR comments, renames `slice03CanvasPrimitives.spec.ts` to `agentCanvasPrimitives.spec.ts`, and retitles the two describe blocks that named a slice number.
Contributor
🎨 Storybook: ✅ Built🎭 Playwright: ⏳ Running...⚡ Performance
|
Contributor
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Sep 25, 2026
Contributor
Author
|
Superseded by #18840 — same commit, pushed to an upstream branch so the e2e workflows actually run (fork PRs leave them skipped-but-green, and this PR is a CI measurement). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
browser_testscarries 10 tests parked behindtest.fixme(true, 'Activates after slice PR 1618x merges'). All four gating PRs were closed unmerged on 2026-09-14 — along with the rest of theagent-v103–17 slice series (only 00/18 #16071 and 01/18 #16075 ever landed). The activation condition can never be met, so these are not pending tests, they are dead ones. They have never executed.browser_tests/tests/topbar/workflowTabs.spec.tsbrowser_tests/tests/agent/slice03CanvasPrimitives.spec.tsbrowser_tests/tests/billingFacadeConsumers.spec.tsbrowser_tests/tests/load3d/load3dViewer.spec.tsSurfaced by the disabled-test inventory: 10 of the repo's 17 never-executing tests are this one cause.
Change
Remove the 10 gates. None of these tests depend on unmerged source — they are written entirely against fixtures that exist on
maintoday (nodeOps,canvasOps,menu.topbar,mockCloudBoot,Load3DFixtures). They were authored test-led ahead of a slicing plan that was abandoned, not ahead of missing APIs.Also removes the stale slice-PR comments, renames
slice03CanvasPrimitives.spec.ts→agentCanvasPrimitives.spec.ts, and retitles the twodescribeblocks that named a slice number.Expected outcome
This PR is a measurement. CI is the first run these tests have ever had, so some may fail. Anything that fails is a real, previously-invisible defect — it gets converted to a
test.fail()pin with a tracking issue (the repo's existing "pin the bug, don't hide it" convention), not re-hidden behindfixme. Anything that passes is coverage we get back for free.No source changes.