Repository navigation
test(agent): run slice03 canvas primitive specs against main - #16951
christian-byrne wants to merge 1 commit into
Conversation
The four specs in slice03CanvasPrimitives.spec.ts were disabled with test.fixme gated on slice PR Comfy-Org#16186 merging. That PR remains an open draft and is no longer the landing target for this surface, so the gate could never fire. Every helper the specs use already exists on main (nodeOps.getSerializedGraph/getSelectedGraphNodesCount, NodeReference.centerOnNode/getPosition/click, canvasOps.getOffset/getNodeGeometry/expectSlotsTrackedNode, fitToViewInstant), so the specs run against main directly now.
|
Warning Review limit reachedNext included review available in 5 minutes. View limit detailsLimit details: You’ve used all 4 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
🎨 Storybook: ✅ Built🎭 Playwright: ❌ 1914 passed, 1 failed❌ Failed Tests📊 Browser Reports
📦 Bundle: 9.69 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 124 kB (baseline 124 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 17 unchanged Panels & Settings — 621 kB (baseline 621 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27.8 kB (baseline 27.8 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 117 kB (baseline 117 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.6 MB (baseline 3.6 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 559 kB (baseline 559 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 18.1 MB (baseline 18.1 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 16.4 MB (baseline 16.4 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-04T09:09:23.228Z",
"gitSha": "5201516fdcc3e4f48a05fe08013b76ec4a08bfc0",
"branch": "lane-phs-26-0847",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2181.4960000000383,
"styleRecalcs": 7,
"styleRecalcDurationMs": 9.048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 817.0029999999999,
"heapDeltaBytes": -1585164,
"heapUsedBytes": 68237600,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 17.447,
"eventListeners": -182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2030.3899999998976,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.859,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.021,
"heapDeltaBytes": 184476,
"heapUsedBytes": 70170196,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 13.009000000000004,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1953.8390000000163,
"styleRecalcs": 80,
"styleRecalcDurationMs": 47.745,
"layouts": 14,
"layoutDurationMs": 4.859,
"taskDurationMs": 1018.683,
"heapDeltaBytes": -6422640,
"heapUsedBytes": 64061752,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 170.87,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1906.2300000000505,
"styleRecalcs": 77,
"styleRecalcDurationMs": 42.726,
"layouts": 14,
"layoutDurationMs": 4.743,
"taskDurationMs": 990.621,
"heapDeltaBytes": 7665200,
"heapUsedBytes": 78090916,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 172.465,
"eventListeners": -180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1752.2030000000086,
"styleRecalcs": 32,
"styleRecalcDurationMs": 21.677000000000003,
"layouts": 6,
"layoutDurationMs": 1.3579999999999999,
"taskDurationMs": 448.18199999999996,
"heapDeltaBytes": 4752088,
"heapUsedBytes": 75298440,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 16.23,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1682.6379999999972,
"styleRecalcs": 29,
"styleRecalcDurationMs": 18.178,
"layouts": 6,
"layoutDurationMs": 1.2249999999999999,
"taskDurationMs": 394.77599999999995,
"heapDeltaBytes": 5109552,
"heapUsedBytes": 75621476,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 12.323,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 737.0569999999361,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.044999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 521.3399999999999,
"heapDeltaBytes": -7849984,
"heapUsedBytes": 62813036,
"domNodes": 18,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 175.44400000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 741.3060000001224,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.614000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 507.54299999999995,
"heapDeltaBytes": -7833584,
"heapUsedBytes": 63019892,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 176.65900000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2060.864000000038,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.628,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 816.714,
"heapDeltaBytes": -15414992,
"heapUsedBytes": 86792628,
"domNodes": -271,
"jsHeapTotalBytes": -65536,
"scriptDurationMs": 48.01899999999999,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2019.5209999999406,
"styleRecalcs": 2,
"styleRecalcDurationMs": 3.2569999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 709.4200000000001,
"heapDeltaBytes": 23044068,
"heapUsedBytes": 88311872,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 43.791,
"eventListeners": -150,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2933.3520000000135,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.137999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1847.5520000000001,
"heapDeltaBytes": 23549128,
"heapUsedBytes": 89571640,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 898.3169999999999,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2715.2719999999135,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.476000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1842.373,
"heapDeltaBytes": 27656564,
"heapUsedBytes": 93266328,
"domNodes": -274,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 909.05,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4069.6620000001076,
"styleRecalcs": 60,
"styleRecalcDurationMs": 11.327999999999998,
"layouts": 60,
"layoutDurationMs": 13.607999999999999,
"taskDurationMs": 1963.238,
"heapDeltaBytes": 8483500,
"heapUsedBytes": 76106828,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 854.936,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3690.311000000065,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.292,
"layouts": 60,
"layoutDurationMs": 12.839,
"taskDurationMs": 1782.904,
"heapDeltaBytes": 8493572,
"heapUsedBytes": 75799296,
"domNodes": -11,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 792.808,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3425.6229999998595,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.595000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2251.7039999999997,
"heapDeltaBytes": 26305204,
"heapUsedBytes": 93751520,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1121.571,
"eventListeners": 190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3192.8550000000087,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.428000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2148.618,
"heapDeltaBytes": 26506940,
"heapUsedBytes": 93817408,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 1064.961,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2035.7269999999517,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.1459999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 758.392,
"heapDeltaBytes": 22630824,
"heapUsedBytes": 88189704,
"domNodes": -271,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 50.212999999999994,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2032.216999999946,
"styleRecalcs": 3,
"styleRecalcDurationMs": 4.771000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.99,
"heapDeltaBytes": 22226204,
"heapUsedBytes": 88258220,
"domNodes": -270,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.331,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 673.1400000001031,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.798000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.66299999999995,
"heapDeltaBytes": 14840984,
"heapUsedBytes": 87456720,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 146.55300000000003,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 623.4709999998813,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.219000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 432.691,
"heapDeltaBytes": 15175480,
"heapUsedBytes": 88105852,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 145.65800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2035.5289999999968,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.468,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 656.282,
"heapDeltaBytes": -14026360,
"heapUsedBytes": 58899596,
"domNodes": -298,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 13.955999999999996,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.506999999905,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.734,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 617.3979999999999,
"heapDeltaBytes": -13612536,
"heapUsedBytes": 59328952,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 11.498000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1807.4219999998604,
"styleRecalcs": 79,
"styleRecalcDurationMs": 45.43600000000001,
"layouts": 18,
"layoutDurationMs": 5.906,
"taskDurationMs": 962.985,
"heapDeltaBytes": -16146216,
"heapUsedBytes": 56847448,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 122.85199999999999,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1770.9350000000086,
"styleRecalcs": 76,
"styleRecalcDurationMs": 41.765,
"layouts": 18,
"layoutDurationMs": 6.1419999999999995,
"taskDurationMs": 942.4879999999999,
"heapDeltaBytes": -14417472,
"heapUsedBytes": 58441348,
"domNodes": -297,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 124.876,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1433.3959999999024,
"styleRecalcs": 19,
"styleRecalcDurationMs": 34.775,
"layouts": 15,
"layoutDurationMs": 17.439999999999998,
"taskDurationMs": 1050.7049999999997,
"heapDeltaBytes": -9211008,
"heapUsedBytes": 82450632,
"domNodes": 13751,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 35.63699999999999,
"eventListeners": 2387,
"totalBlockingTimeMs": 155,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10797.440999999935,
"styleRecalcs": 247,
"styleRecalcDurationMs": 40.17999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6786.330999999999,
"heapDeltaBytes": -8310292,
"heapUsedBytes": 93377888,
"domNodes": -269,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 3009.919,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9638.828000000103,
"styleRecalcs": 249,
"styleRecalcDurationMs": 37.479,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6409.063000000001,
"heapDeltaBytes": 18409288,
"heapUsedBytes": 94913600,
"domNodes": -266,
"jsHeapTotalBytes": -434176,
"scriptDurationMs": 2968.1939999999995,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18479.0660000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18011.231000000003,
"heapDeltaBytes": -39243844,
"heapUsedBytes": 177774480,
"domNodes": -6548,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 352.236,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18053.599000000075,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17457.478000000003,
"heapDeltaBytes": -34109520,
"heapUsedBytes": 176480780,
"domNodes": -6548,
"jsHeapTotalBytes": -4907008,
"scriptDurationMs": 318.3550000000001,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 23112.203000000136,
"styleRecalcs": 173,
"styleRecalcDurationMs": 25.943999999999967,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22908.427,
"heapDeltaBytes": -32251644,
"heapUsedBytes": 171753732,
"domNodes": -6548,
"jsHeapTotalBytes": -5693440,
"scriptDurationMs": 999.2429999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 206,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-large-graph-pan",
"durationMs": 22436.770999999906,
"styleRecalcs": 172,
"styleRecalcDurationMs": 22.493999999999957,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22196.448,
"heapDeltaBytes": -37057652,
"heapUsedBytes": 170868332,
"domNodes": -6548,
"jsHeapTotalBytes": -3657728,
"scriptDurationMs": 1014.648,
"eventListeners": -7469,
"totalBlockingTimeMs": 61,
"frameDurationMs": 18.33666666666674,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6533.43400000017,
"styleRecalcs": 20,
"styleRecalcDurationMs": 102.48600000000002,
"layouts": 20,
"layoutDurationMs": 40.08999999999999,
"taskDurationMs": 6491.248,
"heapDeltaBytes": -38078936,
"heapUsedBytes": 171125448,
"domNodes": -6548,
"jsHeapTotalBytes": 4947968,
"scriptDurationMs": 123.79599999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 461,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6468.980000000101,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.88800000000002,
"layouts": 20,
"layoutDurationMs": 26.503000000000014,
"taskDurationMs": 6387.924,
"heapDeltaBytes": -25972480,
"heapUsedBytes": 179377752,
"domNodes": -6548,
"jsHeapTotalBytes": 15966208,
"scriptDurationMs": 126.36199999999998,
"eventListeners": -7469,
"totalBlockingTimeMs": 445,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9196.541000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8984.836000000001,
"heapDeltaBytes": 21813524,
"heapUsedBytes": 175845956,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 166.32400000000004,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9153.295000000071,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8894.228,
"heapDeltaBytes": 4770868,
"heapUsedBytes": 176777560,
"domNodes": 0,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 183.01200000000006,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 504.00200000012774,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.339,
"layouts": 5,
"layoutDurationMs": 3.289,
"taskDurationMs": 160.78599999999997,
"heapDeltaBytes": 5121564,
"heapUsedBytes": 73062920,
"domNodes": 149,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 19.060999999999996,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 109.20499999997446,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.282999999999998,
"layouts": 2,
"layoutDurationMs": 1.356,
"taskDurationMs": 76.97800000000002,
"heapDeltaBytes": 2989576,
"heapUsedBytes": 71908232,
"domNodes": 128,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.370000000000004,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #16951 +/- ##
==========================================
+ Coverage 81.22% 82.79% +1.57%
==========================================
Files 2464 2046 -418
Lines 126965 119487 -7478
Branches 32036 30209 -1827
==========================================
- Hits 103130 98933 -4197
+ Misses 23320 20374 -2946
+ Partials 515 180 -335
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Superseded by canvas primitive tests against main (org-hosted branch so it can be rebased). Full context for agent readersThe org-hosted replacement is rebased onto current main and excludes viewport state from the semantic graph assertion that failed in end-to-end CI. |
What
Enables the four agent e2e specs in
browser_tests/tests/agent/slice03CanvasPrimitives.spec.tsthat weretest.fixme-gated on slice PR #16186 merging, and re-points the file header at main.Why
#16186 (
[agent-v1 03/18]canvas primitives slice) remains an open draft, untouched since 2026-09-02, and is no longer the landing target for this surface — so the stated activation condition ("after slice PR 16186 merges") cannot fire, and four tests stay permanently dormant.Per-test decision: every assertion in all four specs depends only on helpers that already exist on main —
nodeOps.getFirstNodeRef/getSerializedGraph/getSelectedGraphNodesCount(browser_tests/fixtures/helpers/NodeOperationsHelper.ts)NodeReference.centerOnNode()/getPosition()/click('title')(browser_tests/fixtures/utils/litegraphUtils.ts)canvasOps.getOffset/getNodeGeometry/expectSlotsTrackedNode(browser_tests/fixtures/helpers/CanvasHelper.ts)fitToViewInstant(browser_tests/fixtures/utils/fitToView.ts)No spec body calls any API introduced by #16186 (its select-only mode / viewport-occlusion primitives), so the gate is wrong rather than early: the specs run against main directly.
Evidence
git fetch origin nathaniel/agent-v1/03-canvas-primitives && git diff --stat origin/main...FETCH_HEAD— slice PR addsLGraphCanvasselect-only mode,DragAndScaleviewport insets, CRDT follower, etc.; none of it is referenced by the spec's imports or bodies.grepconfirms all four helper surfaces above exist at main9ff3fd7f0e.playwright test browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts --list --project=chromium— 4 tests collected, 0 skipped.eslint,oxlint,oxfmt --checkon the changed file — all clean.CI (the 16-shard e2e job with a real backend) is the arbiter of the runtime assertions; a failure there would be a real main-reachable behaviour finding, not a gate issue.