Repository navigation
[agent-v1 04/18] workflow tab restyle and path-based active identity - #16184
CodeJuggernaut wants to merge 8 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ❌ 1882 passed, 2 failed · 2 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle: 9.63 MB gzipDetailsSummary
Category Glance App Entry Points — 3.78 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.4 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 124 kBTop-level views, pages, and routed surfaces
Status: 17 added Panels & Settings — 621 kBConfiguration panels, inspectors, and settings screens
Status: 27 added User & Accounts — 27.5 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 115 kBReusable component library chunks
Status: 15 added Data & Services — 3.58 MBStores, services, APIs, and repositories
Status: 17 added Utilities & Hooks — 556 kBHelpers, composables, and utility bundles
Status: 37 added Vendor & Third-Party — 18.1 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 16.2 MBBundles that do not match a named category
Status: 294 added ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-30T17:09:11.875Z",
"gitSha": "58f771ebe6272339e859b0a7b6b1f85506d8f57c",
"branch": "nathaniel/agent-v1/04-workflowtabs-pair",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.8580000000047,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.16,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.00399999999996,
"heapDeltaBytes": -4900752,
"heapUsedBytes": 64492856,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.552,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2027.6829999999109,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.915,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.943,
"heapDeltaBytes": -11699000,
"heapUsedBytes": 57223448,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.458000000000003,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2018.367000000012,
"styleRecalcs": 80,
"styleRecalcDurationMs": 45.00000000000001,
"layouts": 14,
"layoutDurationMs": 4.215,
"taskDurationMs": 996.6930000000001,
"heapDeltaBytes": -10626824,
"heapUsedBytes": 59095776,
"domNodes": -282,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 165.83800000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1878.58499999993,
"styleRecalcs": 77,
"styleRecalcDurationMs": 38.694,
"layouts": 14,
"layoutDurationMs": 4.0089999999999995,
"taskDurationMs": 866.013,
"heapDeltaBytes": -8908436,
"heapUsedBytes": 60824904,
"domNodes": -284,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 156.42700000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.2580000000066,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.406999999999996,
"layouts": 6,
"layoutDurationMs": 0.934,
"taskDurationMs": 346.25100000000003,
"heapDeltaBytes": 4658480,
"heapUsedBytes": 74459456,
"domNodes": 77,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 10.322000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1683.6819999999761,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.600000000000005,
"layouts": 6,
"layoutDurationMs": 0.763,
"taskDurationMs": 346.806,
"heapDeltaBytes": 4433136,
"heapUsedBytes": 74358556,
"domNodes": 76,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 9.454999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 647.8360000000407,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.774999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.33000000000004,
"heapDeltaBytes": 18542960,
"heapUsedBytes": 88034748,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 160.659,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 636.2159999999903,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.948000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.49899999999997,
"heapDeltaBytes": 18162776,
"heapUsedBytes": 87614636,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 159.76,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2041.908000000035,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.7760000000000025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.81,
"heapDeltaBytes": 11767300,
"heapUsedBytes": 86832828,
"domNodes": -272,
"jsHeapTotalBytes": -2400256,
"scriptDurationMs": 35.369,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2052.116999999953,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.1870000000001,
"heapDeltaBytes": -13992892,
"heapUsedBytes": 86330780,
"domNodes": -270,
"jsHeapTotalBytes": -790528,
"scriptDurationMs": 29.446,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2207.0679999999925,
"styleRecalcs": 67,
"styleRecalcDurationMs": 12.107000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1580.5240000000001,
"heapDeltaBytes": 23501168,
"heapUsedBytes": 88788868,
"domNodes": -270,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 796.71,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2152.5040000000217,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.006000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1552.8560000000002,
"heapDeltaBytes": 19027520,
"heapUsedBytes": 84236912,
"domNodes": -272,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 771.54,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3486.919999999998,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.846,
"layouts": 60,
"layoutDurationMs": 6.916,
"taskDurationMs": 1649.6149999999998,
"heapDeltaBytes": 9783280,
"heapUsedBytes": 76430188,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 758.887,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3426.9279999999753,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.471,
"layouts": 60,
"layoutDurationMs": 6.912999999999999,
"taskDurationMs": 1631.3809999999999,
"heapDeltaBytes": 8793504,
"heapUsedBytes": 75946132,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 758.1439999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3113.5060000000294,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.6839999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1933.476,
"heapDeltaBytes": 25491984,
"heapUsedBytes": 92518876,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 981.003,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3075.4180000000133,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.561000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1854.129,
"heapDeltaBytes": 18674440,
"heapUsedBytes": 85070484,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 930.872,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2054.9419999999827,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.920000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 590.4459999999999,
"heapDeltaBytes": 10835436,
"heapUsedBytes": 86953700,
"domNodes": -271,
"jsHeapTotalBytes": -1875968,
"scriptDurationMs": 30.956999999999997,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2039.2519999999195,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.596000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.862,
"heapDeltaBytes": -15057456,
"heapUsedBytes": 86941308,
"domNodes": -269,
"jsHeapTotalBytes": -1052672,
"scriptDurationMs": 30.092999999999996,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.4130000000318,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.095999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.371,
"heapDeltaBytes": 14355148,
"heapUsedBytes": 86202572,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 151.941,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.1110000000554,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.578000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411,
"heapDeltaBytes": 14979072,
"heapUsedBytes": 87254444,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 147.617,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.8539999999716,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.8,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.977,
"heapDeltaBytes": -12836256,
"heapUsedBytes": 58354900,
"domNodes": -293,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.100000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2040.5319999999847,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.454,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.183,
"heapDeltaBytes": -10117780,
"heapUsedBytes": 61900296,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.046000000000002,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1723.951999999997,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.187999999999995,
"layouts": 18,
"layoutDurationMs": 4.370000000000001,
"taskDurationMs": 781.197,
"heapDeltaBytes": -11778160,
"heapUsedBytes": 60033664,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 103.23400000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1700.4850000000715,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.617,
"layouts": 18,
"layoutDurationMs": 3.902,
"taskDurationMs": 769.017,
"heapDeltaBytes": -12760296,
"heapUsedBytes": 59161972,
"domNodes": -296,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 100.708,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.0409999999265,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.544999999999998,
"layouts": 14,
"layoutDurationMs": 14.479,
"taskDurationMs": 902.3159999999999,
"heapDeltaBytes": 21872144,
"heapUsedBytes": 104356532,
"domNodes": 13671,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.348,
"eventListeners": 2381,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8319.356999999967,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.748000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5608.508000000001,
"heapDeltaBytes": 12763156,
"heapUsedBytes": 88419712,
"domNodes": -269,
"jsHeapTotalBytes": -864256,
"scriptDurationMs": 2585.317,
"eventListeners": -169,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8269.326999999976,
"styleRecalcs": 248,
"styleRecalcDurationMs": 33.455,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5492.253,
"heapDeltaBytes": 23636368,
"heapUsedBytes": 88534468,
"domNodes": -267,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2561.018,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16550.91699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15559.559,
"heapDeltaBytes": -38234348,
"heapUsedBytes": 174847448,
"domNodes": -6548,
"jsHeapTotalBytes": -9584640,
"scriptDurationMs": 260.276,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16492.563999999904,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15505.714,
"heapDeltaBytes": -36148584,
"heapUsedBytes": 173927192,
"domNodes": -6548,
"jsHeapTotalBytes": 1609728,
"scriptDurationMs": 268.27700000000004,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20674.402999999984,
"styleRecalcs": 175,
"styleRecalcDurationMs": 16.87500000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20263.207000000002,
"heapDeltaBytes": -43017580,
"heapUsedBytes": 166247716,
"domNodes": -6548,
"jsHeapTotalBytes": -6381568,
"scriptDurationMs": 880.2959999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 35,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20070.922999999995,
"styleRecalcs": 166,
"styleRecalcDurationMs": 19.47500000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19683.921,
"heapDeltaBytes": -32273636,
"heapUsedBytes": 177630124,
"domNodes": -6548,
"jsHeapTotalBytes": -9682944,
"scriptDurationMs": 912.8179999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 116,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5957.161999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.61800000000002,
"layouts": 20,
"layoutDurationMs": 20.017000000000007,
"taskDurationMs": 5867.965,
"heapDeltaBytes": -36994100,
"heapUsedBytes": 172814488,
"domNodes": -6556,
"jsHeapTotalBytes": 3584000,
"scriptDurationMs": 101.76199999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 368,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5891.87000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.74800000000005,
"layouts": 20,
"layoutDurationMs": 20.08599999999999,
"taskDurationMs": 5776.198000000001,
"heapDeltaBytes": -7922512,
"heapUsedBytes": 181209292,
"domNodes": -6548,
"jsHeapTotalBytes": 19087360,
"scriptDurationMs": 105.24,
"eventListeners": -7469,
"totalBlockingTimeMs": 289,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 117.46400000004087,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.778,
"layouts": 3,
"layoutDurationMs": 0.6799999999999999,
"taskDurationMs": 83.31600000000002,
"heapDeltaBytes": 3253648,
"heapUsedBytes": 70931680,
"domNodes": 112,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.899000000000003,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 98.01400000003468,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.116000000000001,
"layouts": 1,
"layoutDurationMs": 0.6500000000000001,
"taskDurationMs": 65.65099999999998,
"heapDeltaBytes": 3124564,
"heapUsedBytes": 70895176,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.895999999999998,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## nathaniel/agent-v1/03-canvas-primitives #16184 +/- ##
===========================================================================
+ Coverage 82.83% 82.85% +0.01%
===========================================================================
Files 1973 1973
Lines 114109 114119 +10
Branches 31643 31647 +4
===========================================================================
+ Hits 94526 94553 +27
+ Misses 19237 19217 -20
- Partials 346 349 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Updating Playwright Expectations |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 7 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 4 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
|
Automated fleet review (desktop operator, Christian-authorized)
Full context for agent readersPR #16184 — design-review packet (slice 04/18, workflow tabs)Subject: Comfy-Org/ComfyUI_frontend#16184 Verdict: MERGE-OK-AS-IS. The global tab restyle is an intentional, tested user-facing flag-off 1. What the PR actually does
The root now uses [nathaniel-pr-rationale: #16184] The PR identifies the opaque dirty-indicator backdrop as interim 2. Alignment with our ADRs and CRDT recut
CRDT-internals audit: clean. No import or changed path under 3. Flag-off safety — accepted LEAK
BBC #149 says to evaluate tab sizing as a user-facing regression and use Desktop discretion. The 4. Test coverage and CIUnit tests cover active, inactive, null-active, persisted, modified, execution-status, and close At review time GitHub reports 100 passing and 23 skipped checks, with no failures. A later 5. VerdictMERGE-OK-AS-ISNo required code changes. Preserve normal stack order and the later strip cleanup described in the SourcesDirect PR diff and checks at the exact head; Glossary
|
d015c5f to
4d56e4e
Compare
3517440 to
5cf0cb7
Compare
Addresses review feedback: #16184 (comment)
4d56e4e to
3d24a8e
Compare
5cf0cb7 to
5ddf80a
Compare
de369ab to
73194ad
Compare
Addresses review feedback: #16184 (comment)
8bd5ad5 to
5fb3fbe
Compare
|
Closing: superseded by merged CRDT v2 (#16198) — salvage continues as main-based PRs.
Full context for agent readersThis PR is part of the pre-#16198 agent-v1 slice series superseded by the merged v2 foundation on main (f954e47). Per program policy all verification/QA/test content from this series is transplanted to main-based successor PRs as permanent CI tests; deliverables route only to OPEN successor PRs. Closed PRs remain readable sources. Completes the slc-1 close set flagged partially-done in bbc #165 read-back manifest reports/pr-lifecycle/bbc165-state-readback.json. |
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Round 2 — ledger: 7 prior finding(s) across 1 round(s) (7 never answered).
Found 10 finding(s).
| Severity | Count |
|---|---|
| 🟠 High | 1 |
| 🟡 Medium | 5 |
| 🟢 Low | 3 |
| ⚪ Nit | 1 |
Panel: 5/8 reviewers contributed findings.
Reviewers that did not contribute: claude-opus-5-thinking-max:adversarial (error), claude-opus-5-thinking-max:edge-case (error), gpt-5.6-sol-max:edge-case (error)
The finding(s) below could not be anchored to a line the reviewed diff carries, so they are reported here instead of inline:
src/lib/litegraph/src/linkDeduplication.ts:219— 🟠 High — Replacing the boundedfor (pass < size)loop withwhile (successfulPasses < referencedNames.size)makes termination depend on every failed pass growingskipped. Whenmovedis empty — every link already skipped, or none matching a remaining input slot —blockedis empty too, so this line iterates nothing,successfulPassesnever increments, andcontinuere-computes the identical failing batch forever, hanging the tab during graph configure. Make the failure branch always consume progress, or reinstate a hard pass cap. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).
src/platform/workflow/core/services/workflowService.ts:465— 🟡 Medium —pendingWorkflowLoadsByPathis keyed byworkflow.pathcaptured at enqueue time, but a rename mutatespathin place, so this lookup misses an in-flight load still registered under the old path. Closing an inactive workflow then skips both the await and the drain, the tab is removed, and the queued load later settles and makes the closed workflow active — a canvas with no tab. Key the pending-load map by workflow identity, as the adjacentclosingWorkflowCountsalready does for exactly this reason. Raised by 2 of 8 reviewers (kimi-k3-max adversarial, kimi-k3-max edge-case).
src/platform/workflow/core/services/workflowService.ts:85— 🟡 Medium — Every load now serializes on the module-levelworkflowLoadTailand nothing bounds a load's duration, so oneworkflow.load()whose fetch never settles permanently wedges all lateropenWorkflow/loadDefaultWorkflowcalls — andcloseWorkflow's drain awaits the same tail, so tab open and close both stop working for the rest of the session with no recovery path. Add a timeout/abort so a stalled load rejects and releases the queue. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).
src/scripts/app.ts:2119— 🟡 Medium — These invocations don't match the documented extension contract thatloadGraphDatauses:beforeConfigureGraph(graphData, missingNodeTypes)andafterConfigureGraph(missingNodeTypes). The A1111 path passes(this.rootGraph, parameters)and(parameters, undefined, rootGraph), andloadApiJsonpasses(this.rootGraph, apiData)and(apiData, undefined, rootGraph), so an extension that treats the firstafterConfigureGraphargument as astring[]of missing node types (or the firstbeforeConfigureGraphargument as workflow JSON) now receives a raw string or anLGraphon these two import paths. Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).
src/workbench/extensions/agent/crdt/docFrameClient.ts:141— 🟡 Medium —parseDocOpFailurerejects arrays outright and requires a top-level stringop_id/code/message, yetopSender.normalizeFailureexists specifically to recover the array form and the newer{index, op: {op_id}, code, message}shape. Once the host emits either, this parser stripsfailedbeforetoOpsResultViewever sees it, so an identified rejection degrades to an anonymous failure that the sender's stale-credit guard can swallow, timing the batch out into a resend instead of settling it. Widen this parser to the same shapes the sender already normalizes. Raised by 3 of 8 reviewers (gemini-3.1-pro adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case).
src/platform/workflow/templates/composables/useTemplateWorkflows.ts:159— 🟢 Low — This revert also drops theresponse.okguard, so a non-2xx body is parsed unconditionally: an install pinning an older template package now reports a bad pin as an opaque JSONSyntaxErrorinstead of the previous "not served by this install (status)" message, and a JSON error body reachesapp.loadGraphDataas if it were a template. The status check is orthogonal to the input-seeding feature being reverted — keep it. Raised by 4 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, gemini-3.1-pro edge-case, kimi-k3-max edge-case).
apps/website/src/pages/p/supported-models/[slug].astro:184— 🟢 Low —copyLlmsMarkdownnever checksresponse.ok, andfetchresolves for 404/500, so a missing or failed markdown twin copies the HTML error page to the user's clipboard and still shows the ✓ confirmation. Bail out when!response.ok. Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).
src/workbench/extensions/agent/composables/useAgentDockMount.ts:26— 🟢 Low — This outer async import has no failure handling, unlike the nestedAgentPanelRootimport insideDockedAgentPanel.vue, which reports throughreportErrorand renders a fallback. If theDockedAgentPanelchunk itself is unavailable (ad blocker, stale deploy) the load rejects with no telemetry and no fallback UI whileisOpenstays true, so the panel cannot recover without a page reload. Handle and report the loader failure at this boundary too. Raised by 1 of 8 reviewers (gpt-5.6-sol-max adversarial).
apps/website/src/lib/markdown-twin.ts:308— ⚪ Nit —canonicalandlangare interpolated raw into the YAML front matter whiletitle/descriptiongo throughJSON.stringify; a value containing:, a leading#, or a newline would break the field or inject extra front-matter keys into the twin that agents parse. Both come from the site's own built HTML today, so this is defense in depth — quote them the same way as the other fields. Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial).
| if (!option) return | ||
|
|
||
| try { | ||
| await workflowService.openWorkflow(option.workflow) |
There was a problem hiding this comment.
🟡 Medium — openWorkflow now resolves false on the common configure-failure path (it shows its own error dialog rather than throwing) and when the workflow is mid-close, but only the catch branch bumps selectionRevision. PrimeVue has already optimistically moved its internal selection by then, so the tab strip highlights a workflow that never opened while workflowStore.activeWorkflow and the canvas stay on the retained one. Handle the === false outcome the same way as the throw. Raised by 3 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).
|
This slice is reference-only. Accepted work is routed to merged #16198 and current main. Full context for agent readersPer Christian's main-target close ruling, #16184 (04 — workflow tabs) is no longer a landing vehicle. It remains readable implementation and review provenance. The audit found no unique accepted residual. If a genuinely unaccounted delta is found, reopen this source or file a bounded main-based carrier rather than reviving the stacked merge path. |
browser_tests carried 10 `test.fixme(true, 'Activates after slice PR 1618x merges')` gates. All four gating PRs (#16184, #16185, #16186, #16187) were closed unmerged on 2026-09-14, along with the rest of the agent-v1 03-17 slice series, so the activation condition can never be met and the tests have never executed. None of them depend on unmerged source: they are written entirely against fixtures that exist on main (nodeOps, canvasOps, topbar, mockCloudBoot, Load3DFixtures). Removing the gates so CI reports their real state; any that fail become `test.fail()` pins with a tracking issue, per the repo's existing known-defect convention. Also drops the stale slice-PR comments, renames `slice03CanvasPrimitives.spec.ts` to `agentCanvasPrimitives.spec.ts`, and retitles the two describe blocks that named a slice number.
…-Org#18840) ## Problem `browser_tests` carried 10 tests parked behind `test.fixme(true, 'Activates after slice PR 1618x merges')`. All four gating PRs were closed unmerged on 2026-09-14, so their activation condition could never be met. | File | Tests | Gate | |---|---:|---| | `browser_tests/tests/topbar/workflowTabs.spec.ts` | 4 | Comfy-Org#16184 — closed unmerged | | `browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts` | 4 | Comfy-Org#16186 — closed unmerged | | `browser_tests/tests/billingFacadeConsumers.spec.ts` | 1 | Comfy-Org#16185 — closed unmerged | | `browser_tests/tests/load3d/load3dViewer.spec.ts` | 1 | Comfy-Org#16187 — closed unmerged | ## Change - Remove all 10 gates and the stale slice-PR comments. - Rename `slice03CanvasPrimitives.spec.ts` to `agentCanvasPrimitives.spec.ts` and remove slice numbering from its suite names. - Move reusable canvas operations into their fixture owners and make the centering and fit tests establish that a viewport change is required before checking the result. - Make the full-screen Load3D viewer respect the right workspace inset published by the Agent panel. - Preserve the widest active inset publisher during graph/linear host switches. - Keep Agent usable as a viewport-width overlay when the dock cannot fit, while publishing zero workspace inset so portaled dialogs retain positive width. Production changes span `ViewerControls.vue`, `load3dViewerDialog.ts`, `useWorkspaceInset.ts`, `load3d.ts`, `DockedAgentPanel.vue`, and `agentPanelStore.ts`, with focused component/composable and cloud browser coverage. ## First-run results 8 of the 10 tests passed on their first run. The two failures were fixed rather than pinned: - **Load3D workspace geometry:** the full-screen viewer was centered and sized against the whole viewport, so it rendered beneath the Agent dock. The cloud case now opens the real Agent panel and checks both docked and 400px overlay geometry in `load3dAgentUpdate.spec.ts` through `load3dAgentFixture`. - **Canvas primitive oracle:** `graph.serialize()` includes viewport state in `extra.ds`, so comparing the whole serialization incorrectly treated `centerOnNode()` doing its job as graph mutation. The test now compares graph data without viewport state. The centering test first shifts the viewport 400×250 away and proves the node is off-center. The fit test first zooms to 3× and proves a node is outside the canvas. Both then assert the requested operation changes the viewport; the centering test also verifies that graph data is unchanged. - Fixes Comfy-Org#18918 --------- Co-authored-by: Amp <amp@ampcode.com>
`browser_tests` carried 10 tests parked behind `test.fixme(true, 'Activates after slice PR 1618x merges')`. All four gating PRs were closed unmerged on 2026-09-14, so their activation condition could never be met. | File | Tests | Gate | |---|---:|---| | `browser_tests/tests/topbar/workflowTabs.spec.ts` | 4 | #16184 — closed unmerged | | `browser_tests/tests/agent/slice03CanvasPrimitives.spec.ts` | 4 | | `browser_tests/tests/billingFacadeConsumers.spec.ts` | 1 | #16185 — closed unmerged | | `browser_tests/tests/load3d/load3dViewer.spec.ts` | 1 | #16187 — closed unmerged | - Remove all 10 gates and the stale slice-PR comments. - Rename `slice03CanvasPrimitives.spec.ts` to `agentCanvasPrimitives.spec.ts` and remove slice numbering from its suite names. - Move reusable canvas operations into their fixture owners and make the centering and fit tests establish that a viewport change is required before checking the result. - Make the full-screen Load3D viewer respect the right workspace inset published by the Agent panel. - Preserve the widest active inset publisher during graph/linear host switches. - Keep Agent usable as a viewport-width overlay when the dock cannot fit, while publishing zero workspace inset so portaled dialogs retain positive width. Production changes span `ViewerControls.vue`, `load3dViewerDialog.ts`, `useWorkspaceInset.ts`, `load3d.ts`, `DockedAgentPanel.vue`, and `agentPanelStore.ts`, with focused component/composable and cloud browser coverage. 8 of the 10 tests passed on their first run. The two failures were fixed rather than pinned: - **Load3D workspace geometry:** the full-screen viewer was centered and sized against the whole viewport, so it rendered beneath the Agent dock. The cloud case now opens the real Agent panel and checks both docked and 400px overlay geometry in `load3dAgentUpdate.spec.ts` through `load3dAgentFixture`. - **Canvas primitive oracle:** `graph.serialize()` includes viewport state in `extra.ds`, so comparing the whole serialization incorrectly treated `centerOnNode()` doing its job as graph mutation. The test now compares graph data without viewport state. The centering test first shifts the viewport 400×250 away and proves the node is off-center. The fit test first zooms to 3× and proves a node is outside the canvas. Both then assert the requested operation changes the viewport; the centering test also verifies that graph data is unchanged. - Fixes #18918
Merge after: #16186 (03) - stacked on its branch. Draft until the fence half lands; retargets to main as the stack merges.
Decisions: Agent V1 Decision Log
Summary
Slice 04 of the agent-v1 chain, applied half: WorkflowTab restyle and active-identity refactor. The fence half (WorkflowTabs strip changes) is deliberately deferred until slice 00 merges and lands as a follow-up commit on this branch.
Changes
pi pi-times->icon-[lucide--x](retires a PrimeVue usage); the unsaved indicator changes from a bullet glyph to an 8px circle with pinned colors (white on the active tab, muted otherwise - the tab strip surface is theme-fixed#353535, so the colors are deliberately theme-invariant); tab width grows (wider padding - fewer tabs fit before overflow scrolling); tab height rides--workflow-tabs-heightwithbox-border(Preflight is off in this app, so the explicit box model is load-bearing); the indicator slot reserves a 20px square, matching the pre-slice hit target.isActiveTabnow delegates toworkflowStore.isActive(path comparison). This is a refactor onto the store predicate, not a behavior change -keyis derived frompath, so the two comparisons are equivalent for every real workflow.data-testid="close-workflow-button"(long-standing hook, zero in-repo consumers; tests reach the button via itsClosearia-label). Test-hygiene follow-ups (spy clearing, status-map reset scope) ride the fence half.Review Focus
Linear tickets