Skip to content

Fix ECS migration expected test failures - #15654

Closed
DrJKL wants to merge 2 commits into
fix/ecs-review-findingsfrom
audit/ecs-test-fails
Closed

DrJKL wants to merge 2 commits into
fix/ecs-review-findingsfrom
audit/ecs-test-fails

Conversation

@DrJKL

@DrJKL DrJKL commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Re-inventories the remaining expected test failures from the ECS migration and fixes the cases owned by ECS compatibility and lifecycle behavior.

Changes

  • What: Restores enumerable LLink topology facades, handles dropped inputs during link-slot realignment, and re-keys promoted subgraph widgets after node insertion.
  • What: Converts 12 resolved expected failures to normal tests; retains five out-of-scope cases covering unsupported topology resurrection and pre-existing badge ordering parity.

Review Focus

Please focus on the atomic removal/move behavior during input-slot realignment and promoted-widget value preservation while replacing provisional node IDs.

Fixes #15565

@github-actions

github-actions Bot commented Aug 22, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/25/2026, 05:49:49 AM UTC

Links

🎭 Playwright: ✅ 1999 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1978 / ❌ 0 / ⚠️ 0 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle: 9.35 MB gzip

Details

Summary

  • Raw size: 39.6 MB
  • Gzip: 9.35 MB
  • Brotli: 6.55 MB
  • Bundles: 444 current • 444 added
    Baseline artifact not found; showing current bundle sizes only.

Category Glance
Vendor & Third-Party 18.1 MB · Other 15.1 MB · Data & Services 3.5 MB · Graph Workspace 1.4 MB · Panels & Settings 591 kB · Utilities & Hooks 549 kB · + 5 more

App Entry Points — 3.71 kB

Main entry bundles and manifests

File Size Gzip Brotli
assets/index-DKaeRdL_.js (new) 3.71 kB 1.86 kB 1.62 kB

Status: 1 added

Graph Workspace — 1.4 MB

Graph editor runtime, canvas, workflow orchestration

File Size Gzip Brotli
assets/GraphView-DwBL8O6f.js (new) 1.39 MB 305 kB 229 kB
assets/WidgetCompositor-ckH8Irbu.js (new) 8.17 kB 2.76 kB 2.46 kB
assets/workflow-B3xkz5Kx.js (new) 1.01 kB 508 B 420 B

Status: 3 added

Views & Navigation — 124 kB

Top-level views, pages, and routed surfaces

File Size Gzip Brotli
assets/CloudSurveyView-C3pTw5qV.js (new) 25 kB 6.24 kB 5.51 kB
assets/CloudLayoutView-DiKYAuQU.js (new) 21.8 kB 6.56 kB 5.73 kB
assets/OAuthConsentView-D7kYOfdK.js (new) 15.5 kB 4.25 kB 3.71 kB
assets/UserCheckView-qIJq5-lQ.js (new) 8.75 kB 2.19 kB 1.91 kB
assets/CloudLoginView-DLE3bzsJ.js (new) 8.74 kB 2.55 kB 2.25 kB
assets/useCloudAuthPage-CTLFsv52.js (new) 7.08 kB 2.52 kB 2.2 kB
assets/CloudSignupView-BW8oBd7I.js (new) 6.96 kB 2.28 kB 2 kB
assets/WidgetTextPreview-B2Vzb0b-.js (new) 6.07 kB 2.13 kB 1.9 kB
assets/CloudSubscriptionRedirectView-BZ-Pb7_k.js (new) 6.05 kB 2.25 kB 1.96 kB
assets/UserSelectView-CM0HdDfp.js (new) 5.49 kB 1.96 kB 1.72 kB
assets/CloudForgotPasswordView-BgW17F_f.js (new) 4.97 kB 1.72 kB 1.49 kB
assets/CloudAuthTimeoutView-BYSa4RW5.js (new) 4.43 kB 1.54 kB 1.33 kB
assets/OAuthLayoutView-BEUUA9jA.js (new) 1.31 kB 700 B 589 B
assets/CloudSorryContactSupportView-kNDO55x3.js (new) 1.14 kB 579 B 504 B
assets/video-split-screen-CNFWB03A.js (new) 595 B 362 B 299 B
assets/layout-2AgNSWNo.js (new) 403 B 252 B 207 B
assets/WidgetTextPreview-BL7rON1l.js (new) 131 B 100 B 90 B

Status: 17 added

Panels & Settings — 591 kB

Configuration panels, inspectors, and settings screens

File Size Gzip Brotli
assets/KeybindingPanel-610dzgXY.js (new) 49.4 kB 9.95 kB 8.8 kB
assets/settings-Du8MHruG.js (new) 39.6 kB 9.66 kB 7.93 kB
assets/CreditsPanel-BtHO2vIF.js (new) 36.7 kB 8.91 kB 7.8 kB
assets/settings-mkYpqm8E.js (new) 35.2 kB 8.6 kB 7.24 kB
assets/SecretsPanel-SgV1mRZZ.js (new) 33.7 kB 7.88 kB 6.9 kB
assets/settings-C7eLoO4D.js (new) 33.4 kB 8.43 kB 6.89 kB
assets/settings-l9qo4SWq.js (new) 32.9 kB 8.46 kB 7.02 kB
assets/settings-D401de9y.js (new) 31.3 kB 8.71 kB 7.3 kB
assets/settings-h_rkpPt_.js (new) 30.7 kB 8.34 kB 7.28 kB
assets/settings-DYxqUlrV.js (new) 29.5 kB 8.01 kB 6.86 kB
assets/settings-CZVBM34C.js (new) 29.5 kB 8.25 kB 7.17 kB
assets/settings-DFOMjiGL.js (new) 29.4 kB 8.14 kB 7.15 kB
assets/settings-BG4gNbcb.js (new) 28.6 kB 7.93 kB 6.86 kB
assets/settings-x8-cO3Ea.js (new) 28.5 kB 8.38 kB 6.96 kB
assets/settings-DgUyMtWZ.js (new) 27.1 kB 7.7 kB 6.38 kB
assets/settings-DCXleDrM.js (new) 25.1 kB 8.14 kB 6.55 kB
assets/settings-C_Ly-sWO.js (new) 24.5 kB 7.96 kB 6.2 kB
assets/AboutPanel-Ch7L0pv_.js (new) 11.2 kB 3.12 kB 2.8 kB
assets/ExtensionPanel-dQ45_byJ.js (new) 9.19 kB 2.5 kB 2.22 kB
assets/settings-DfIaePVP.js (new) 7.08 kB 1.87 kB 1.59 kB
assets/ServerConfigPanel-BKjrAyKP.js (new) 6.09 kB 1.94 kB 1.72 kB
assets/UserPanel-BU9T3Oyd.js (new) 5.73 kB 1.78 kB 1.54 kB
assets/refreshRemoteConfig-CxCUGYmX.js (new) 4.24 kB 1.51 kB 1.33 kB
assets/remoteConfig-B7jDucs7.js (new) 1.51 kB 697 B 585 B
assets/cloudRemoteConfig-CUDTVWMB.js (new) 951 B 512 B 422 B
assets/CreditsPanel-zmU6TBUo.js (new) 116 B 95 B 93 B
assets/refreshRemoteConfig-DKBv4Jt0.js (new) 110 B 89 B 87 B

Status: 27 added

User & Accounts — 27.5 kB

Authentication, profile, and account management bundles

File Size Gzip Brotli
assets/SignUpForm-DXGTuG2A.js (new) 13.3 kB 4.52 kB 3.92 kB
assets/PasswordFields-CfatEeDM.js (new) 4.93 kB 1.46 kB 1.29 kB
assets/auth-BkxC1LIt.js (new) 3.48 kB 1.21 kB 1.01 kB
assets/UpdatePasswordContent-C0XPH4EL.js (new) 1.85 kB 840 B 733 B
assets/WorkspaceProfilePic-fQ5PxnHG.js (new) 1.6 kB 829 B 721 B
assets/oauthState-DmjrcfWa.js (new) 1.17 kB 478 B 406 B
assets/authClasses-CGLCAoTJ.js (new) 679 B 422 B 334 B
assets/profiler-DTaQ-5S5.js (new) 178 B 141 B 128 B
assets/authStore-BMV5EVpk.js (new) 128 B 107 B 102 B
assets/workspaceAuthStore-DZZPRipG.js (new) 108 B 99 B 112 B
assets/auth-BeinvvhH.js (new) 105 B 96 B 80 B

Status: 11 added

Editors & Dialogs — 125 kB

Modals, dialogs, drawers, and in-app editors

File Size Gzip Brotli
assets/ComfyHubPublishDialog-CwxtS-Ae.js (new) 90.1 kB 19.3 kB 16.5 kB
assets/useShareDialog-DVGn7spT.js (new) 23.9 kB 5.7 kB 5.03 kB
assets/feedbackDialog-jFGyQJWz.js (new) 4.45 kB 1.87 kB 1.59 kB
assets/useRangeEditor-ayIPjCQo.js (new) 3.29 kB 1.14 kB 1.04 kB
assets/SubscriptionInactiveMemberDialog-BrvI_NG_.js (new) 2.48 kB 997 B 851 B
assets/useLayerEditor-lc7kASAQ.js (new) 1.01 kB 492 B 402 B
assets/ComfyHubPublishDialog-BtLblG59.js (new) 143 B 105 B 91 B
assets/useSubscriptionDialog-B58KlAlL.js (new) 108 B 102 B 98 B

Status: 8 added

UI Components — 112 kB

Reusable component library chunks

File Size Gzip Brotli
assets/useMoreOptionsMenu-D1O-wyTd.js (new) 45 kB 10.8 kB 9.35 kB
assets/ComfyQueueButton-B_TYkXyk.js (new) 14.6 kB 3.97 kB 3.52 kB
assets/useTerminalTabs-DZOmC3-y.js (new) 11.8 kB 3.69 kB 3.27 kB
assets/InviteMembersForm-CGM6FdWc.js (new) 8.23 kB 2.74 kB 2.43 kB
assets/TopbarBadge-CJOCElDc.js (new) 7.65 kB 1.83 kB 1.62 kB
assets/ScrubableNumberInput-B_ro9sfO.js (new) 6.49 kB 2.17 kB 1.92 kB
assets/WidgetInputNumberInput-DBTIotZ1.js (new) 5.83 kB 2.07 kB 1.84 kB
assets/Button-D2pl4KJe.js (new) 4.64 kB 1.62 kB 1.42 kB
assets/SubscribeButton-DDfW711o.js (new) 2.15 kB 969 B 849 B
assets/WidgetButton-AtrL9JNP.js (new) 1.91 kB 887 B 773 B
assets/Input-B5ScUGO7.js (new) 1.76 kB 872 B 768 B
assets/UserAvatar-CeRcwZsX.js (new) 1.24 kB 639 B 554 B
assets/cloudFeedbackTopbarButton-LSdYQ23D.js (new) 705 B 422 B 362 B
assets/ComfyQueueButton-B_u1SZ1Y.js (new) 128 B 99 B 93 B
assets/toggle-group-DEWGipqL.js (new) 40 B 60 B 44 B

Status: 15 added

Data & Services — 3.5 MB

Stores, services, APIs, and repositories

File Size Gzip Brotli
assets/settingStore-CQzxRv8G.js (new) 3.18 MB 746 kB 562 kB
assets/api-OCwlRCAJ.js (new) 179 kB 40.4 kB 33.9 kB
assets/load3dService-BojOsr8Z.js (new) 87 kB 20.4 kB 17.6 kB
assets/workflowShareService-dZYRPCVz.js (new) 16.5 kB 4.91 kB 4.35 kB
assets/keybindingService-DiI_gTyn.js (new) 6.95 kB 1.75 kB 1.51 kB
assets/releaseStore-zIbW0-po.js (new) 6.72 kB 2.04 kB 1.77 kB
assets/dialogStore-NiMHW0V4.js (new) 5.35 kB 1.64 kB 1.44 kB
assets/extensionStore-aEPy6J6V.js (new) 4.93 kB 1.74 kB 1.47 kB
assets/userStore-C4y3Bmqz.js (new) 2.38 kB 897 B 795 B
assets/serverConfigStore-B_zwQQFs.js (new) 2.3 kB 775 B 687 B
assets/audioService-BJO69rke.js (new) 1.71 kB 830 B 725 B
assets/toastStore-B_waOwkM.js (new) 841 B 395 B 343 B
assets/dialogService-F0sXbz53.js (new) 98 B 97 B 81 B
assets/releaseStore-CgD-3EJ_.js (new) 95 B 86 B 92 B
assets/settingStore-EjqNGHRu.js (new) 95 B 86 B 82 B
assets/assetsStore-CDFtqsjl.js (new) 94 B 92 B 85 B
assets/api-Gve4ehZW.js (new) 62 B 74 B 66 B

Status: 17 added

Utilities & Hooks — 549 kB

Helpers, composables, and utility bundles

File Size Gzip Brotli
assets/useConflictDetection-FNtu3RyY.js (new) 236 kB 53.1 kB 43.2 kB
assets/useLayerEditorSession-DySFguNC.js (new) 158 kB 40.8 kB 34.3 kB
assets/useLoad3d-DEBIW0rf.js (new) 26.2 kB 5.91 kB 5.25 kB
assets/useLoad3dViewer-C6OCdrWb.js (new) 21.2 kB 4.98 kB 4.36 kB
assets/useImageQuiet-Mi1SqE9H.js (new) 19.1 kB 6.12 kB 5.27 kB
assets/formatUtil-p5n45ie5.js (new) 16.4 kB 5.58 kB 4.89 kB
assets/useImageCrop-Cc6sI3J7.js (new) 14.9 kB 3.42 kB 2.98 kB
assets/useDowngradeToPersonal-DLCEQNXy.js (new) 10.9 kB 2.73 kB 2.36 kB
assets/useFeatureFlags-CdXEhQux.js (new) 7.25 kB 2.05 kB 1.76 kB
assets/curveUtils-CMFtfKRr.js (new) 3.79 kB 1.26 kB 1.11 kB
assets/useTransformState-pmtqgF1X.js (new) 3.54 kB 1.55 kB 1.29 kB
assets/useCompositorLayers-6DA-dvZo.js (new) 2.94 kB 900 B 800 B
assets/useSurveyEligibility-BchrBOs2.js (new) 2.89 kB 1.11 kB 918 B
assets/useExternalLink-DEU0jLFW.js (new) 2.85 kB 1.07 kB 922 B
assets/assetPreviewUtil-DahW8gnw.js (new) 2.35 kB 970 B 845 B
assets/useFeatureUsageTracker-BvTg_wRf.js (new) 2.07 kB 910 B 772 B
assets/downloadUtil-BXBzIs3W.js (new) 2.04 kB 907 B 727 B
assets/useTypeformEmbed-CDWSPG2-.js (new) 2.02 kB 1.03 kB 851 B
assets/useUpstreamValue-DESC5vOx.js (new) 1.97 kB 750 B 670 B
assets/useWorkspaceTierLabel-d3EZM0RR.js (new) 1.97 kB 843 B 714 B
assets/markdownRendererUtil-SWQwG4-s.js (new) 1.53 kB 797 B 690 B
assets/useErrorHandling-pk06q9dn.js (new) 1.49 kB 615 B 530 B
assets/hdrFormatUtil-CnRXb_Cj.js (new) 1.03 kB 485 B 390 B
assets/histogramUtil-nwm_kqcs.js (new) 921 B 539 B 457 B
assets/useModalLiftedZIndex-COrVuqHm.js (new) 908 B 552 B 513 B
assets/subscriptionCheckoutUtil-vckJRVQK.js (new) 877 B 524 B 433 B
assets/useTextFileContent-CbVf32VM.js (new) 841 B 425 B 376 B
assets/useClickDragGuard-C9dEHod_.js (new) 773 B 372 B 333 B
assets/useSessionCookie-CqhXme6g.js (new) 652 B 337 B 291 B
assets/_plugin-vue_export-helper-DEKQMRQ4.js (new) 365 B 255 B 216 B
assets/envUtil-D9umgS8T.js (new) 333 B 213 B 178 B
assets/useLoad3d-CyfL3pcQ.js (new) 311 B 164 B 147 B
assets/SkeletonUtils-C-oSpD-2.js (new) 133 B 111 B 106 B
assets/useSessionCookie-CIjnW8Hj.js (new) 101 B 86 B 80 B
assets/useFeatureFlags-J-Lotsl_.js (new) 98 B 85 B 82 B
assets/useLoad3dViewer-DyJ1bIwx.js (new) 98 B 85 B 82 B
assets/useCurrentUser-B9x1546_.js (new) 94 B 95 B 85 B

Status: 37 added

Vendor & Third-Party — 18.1 MB

External libraries and shared vendor chunks

File Size Gzip Brotli
assets/vendor-three-c2E1ynp3.js (new) 7.14 MB 2.18 MB 1.03 MB
assets/vendor-other-B2Q0WDjS.js (new) 3.5 MB 739 kB 566 kB
assets/vendor-primevue-CsKlfmfR.js (new) 1.69 MB 305 kB 184 kB
assets/vendor-firebase-DZ9gHliD.js (new) 1.15 MB 233 kB 186 kB
assets/vendor-tiptap-CRth4-B-.js (new) 747 kB 184 kB 148 kB
assets/vendor-ag-psd-iN-PK2Jv.js (new) 545 kB 113 kB 91.2 kB
assets/vendor-reka-ui-cams7cKq.js (new) 530 kB 97.2 kB 74.4 kB
assets/vendor-datadog-CR3rU1mS.js (new) 528 kB 126 kB 102 kB
assets/vendor-chart-hciqepb7.js (new) 412 kB 100 kB 83 kB
assets/vendor-xterm-tvYwlZkL.js (new) 380 kB 75.9 kB 61.2 kB
assets/vendor-vue-core-yudC0Byk.js (new) 349 kB 87.4 kB 73.6 kB
assets/vendor-sentry-CwHvS6Tl.js (new) 239 kB 56.7 kB 47.5 kB
assets/vendor-yjs-C9OoToaE.js (new) 223 kB 50.3 kB 42.2 kB
assets/vendor-vueuse-Cvfp9Fqp.js (new) 150 kB 37.7 kB 32.3 kB
assets/vendor-markdown-CtxqRwKg.js (new) 139 kB 35.2 kB 30.7 kB
assets/vendor-i18n-BNoYHpCR.js (new) 128 kB 29 kB 24.8 kB
assets/vendor-axios-CyO1Ni1Z.js (new) 120 kB 32 kB 27.4 kB
assets/vendor-zod-CnLPxe5A.js (new) 106 kB 18.9 kB 16.1 kB

Status: 18 added

Other — 15.1 MB

Bundles that do not match a named category

File Size Gzip Brotli
assets/nodeDefs-IXaE-olj.js (new) 831 kB 142 kB 96.7 kB
assets/nodeDefs-Y9RB_xk3.js (new) 764 kB 129 kB 90.2 kB
assets/nodeDefs-xJ6pggp5.js (new) 754 kB 132 kB 92.6 kB
assets/nodeDefs-CFicUTmo.js (new) 694 kB 129 kB 89.1 kB
assets/nodeDefs-CmNrUoPo.js (new) 692 kB 122 kB 87 kB
assets/nodeDefs-hz-xEVPq.js (new) 667 kB 126 kB 88.4 kB
assets/nodeDefs-CfEPJyjr.js (new) 663 kB 124 kB 89.9 kB
assets/nodeDefs-CGgX8SXt.js (new) 655 kB 124 kB 90.2 kB
assets/nodeDefs-CsYdgaz8.js (new) 653 kB 120 kB 87.5 kB
assets/nodeDefs-BncRL9Uk.js (new) 649 kB 119 kB 87.1 kB
assets/nodeDefs-BfK2LUB3.js (new) 645 kB 119 kB 86.3 kB
assets/nodeDefs-B7TAg0KD.js (new) 615 kB 110 kB 80.8 kB
assets/nodeDefs-CHdCiUi9.js (new) 598 kB 123 kB 86.1 kB
assets/nodeDefs-0gUf91t0.js (new) 593 kB 122 kB 84.6 kB
assets/main-CKmVj4zY.js (new) 327 kB 80.8 kB 62.7 kB
assets/main-DaGZRSMp.js (new) 293 kB 73.3 kB 58.2 kB
assets/main-Taul6BdU.js (new) 278 kB 72.6 kB 57.4 kB
assets/main-CLErxWfg.js (new) 268 kB 71.8 kB 56.4 kB
assets/main-CbtsiqE0.js (new) 259 kB 69.6 kB 55.7 kB
assets/main-ogL_MKvh.js (new) 244 kB 70.4 kB 58.1 kB
assets/main-q7jMFlte.js (new) 242 kB 69.3 kB 55.3 kB
assets/main-DsTCcZdY.js (new) 236 kB 68.6 kB 56.5 kB
assets/main-CQi69RKt.js (new) 233 kB 68.7 kB 57.1 kB
assets/main-c_2kbrOv.js (new) 231 kB 67.7 kB 56.3 kB
assets/main-2f63z6YA.js (new) 227 kB 66.5 kB 55.8 kB
assets/main-DZ2QvWFv.js (new) 209 kB 60.8 kB 51 kB
assets/main-DI-xbEq2.js (new) 205 kB 67.5 kB 53.4 kB
assets/main-1JY4fjcO.js (new) 203 kB 67.1 kB 52.9 kB
assets/core-BO2kK8fE.js (new) 116 kB 30.3 kB 25.6 kB
assets/WorkspaceSettingsPanelContent-C0oxB_Si.js (new) 109 kB 21.4 kB 18 kB
assets/OBJLoader2WorkerModule-DTMpvldF.js (new) 109 kB 27.1 kB 21.9 kB
assets/WidgetSelect-CvQsNWEe.js (new) 88.7 kB 20.1 kB 17.2 kB
assets/WidgetVideoEdit-uWppAjMw.js (new) 72.7 kB 17.2 kB 15.1 kB
assets/Load3D-BWfCExfF.js (new) 72.1 kB 11.9 kB 10.2 kB
assets/CameraInfo-DXt8selA.js (new) 67 kB 14.5 kB 12.8 kB
assets/SubscriptionTransitionPreviewWorkspace-EYB_lSwZ.js (new) 66.4 kB 13.4 kB 11.7 kB
assets/Preview3d-R6OpKqL1.js (new) 52.6 kB 8.59 kB 7.5 kB
assets/main-cDwYx7qV.js (new) 47.6 kB 13.7 kB 11.9 kB
assets/Viewport3d-DS5chpin.js (new) 47.5 kB 10.1 kB 8.92 kB
assets/SubscriptionRequiredDialogContentUnified-B-Ev8N7i.js (new) 42.7 kB 9.39 kB 8.18 kB
assets/LayerEditorContent-OWHdhkFs.js (new) 42.5 kB 9.62 kB 8.44 kB
assets/nodeDefs-CLM_11a3.js (new) 41.8 kB 10.8 kB 9.29 kB
assets/WidgetBoundingBoxes-VN4730Gc.js (new) 33.7 kB 9.16 kB 8.12 kB
assets/WidgetPainter-ocSy_C8v.js (new) 32.6 kB 7.88 kB 6.96 kB
assets/Load3dViewerContent-BowO5ez5.js (new) 30.8 kB 6.28 kB 5.45 kB
assets/HdrViewerContent-B-cxgaDP.js (new) 29.8 kB 8.25 kB 7.28 kB
assets/ColorPicker-C61NmFNm.js (new) 29.2 kB 7.59 kB 6.68 kB
assets/SubscriptionRequiredDialogContent-DC9M49xr.js (new) 26.9 kB 6.35 kB 5.6 kB
assets/SubscriptionRequiredDialogContentWorkspace-D9V4QuOQ.js (new) 25.1 kB 5.81 kB 5.11 kB
assets/initHostTelemetry-B4XsZ6_L.js (new) 24.5 kB 5.82 kB 4.83 kB
assets/load3d-DwEziZk2.js (new) 22.2 kB 5.41 kB 4.67 kB
assets/SignInContent-Ceh_gqqu.js (new) 20.6 kB 5.17 kB 4.53 kB
assets/commands-BKN6fRVa.js (new) 18.6 kB 4 kB 3.09 kB
assets/DialogHeader-ZBXW696G.js (new) 17.5 kB 5.28 kB 4.6 kB
assets/commands-D2b4SpmW.js (new) 17.3 kB 3.69 kB 2.85 kB
assets/commands-gx4P-ybS.js (new) 17.3 kB 3.76 kB 2.96 kB
assets/commands-DrmQsqDP.js (new) 17.3 kB 3.59 kB 2.82 kB
assets/CurrentUserPopoverWorkspace-4rNwcPyf.js (new) 16.9 kB 3.95 kB 3.48 kB
assets/commands-lpkD8Jr0.js (new) 16.7 kB 3.79 kB 2.98 kB
assets/i18n-CiQF_Sqk.js (new) 16.7 kB 4.56 kB 3.82 kB
assets/WidgetRecordAudio-3dfprFuH.js (new) 16.6 kB 4.6 kB 4.09 kB
assets/commands-CGE1NEkE.js (new) 16.4 kB 3.54 kB 2.92 kB
assets/commands-Bym53ZK-.js (new) 15.9 kB 3.5 kB 2.87 kB
assets/commands-D_uHBcHD.js (new) 15.9 kB 3.42 kB 2.78 kB
assets/commands-DYFW3wAz.js (new) 15.8 kB 3.39 kB 2.78 kB
assets/commands-XyP6YuDv.js (new) 15.7 kB 3.65 kB 2.84 kB
assets/commands-B3vhE5a3.js (new) 15.5 kB 3.25 kB 2.68 kB
assets/commands-DM9rmOop.js (new) 15.4 kB 3.18 kB 2.69 kB
assets/commands-4qWg2NAn.js (new) 15 kB 3.59 kB 2.71 kB
assets/commands-9uJVV2DI.js (new) 14.8 kB 3.53 kB 2.64 kB
assets/WidgetInputNumber-AQ1zAMHS.js (new) 13.9 kB 3.63 kB 3.21 kB
assets/WidgetRange-BiPv3RIY.js (new) 13.7 kB 3.55 kB 3.13 kB
assets/WaveAudioPlayer-DZlggaGC.js (new) 12.8 kB 3.46 kB 3.03 kB
assets/WidgetCurve-QWsr10GO.js (new) 11.2 kB 3.48 kB 3.14 kB
assets/SelectValue-B4lA6vH9.js (new) 10.6 kB 2.61 kB 2.33 kB
assets/AudioPreviewPlayer-CvhDBqty.js (new) 10.6 kB 3.05 kB 2.72 kB
assets/meshy-C5eznzGL.js (new) 10.5 kB 4.72 kB 4.15 kB
assets/TeamWorkspacesDialogContent-EEJqO81l.js (new) 10.3 kB 2.96 kB 2.62 kB
assets/onboardingCloudRoutes-BCphGxJm.js (new) 9.49 kB 2.84 kB 2.44 kB
assets/ideogram-CPAcI9VN.js (new) 9.21 kB 4.28 kB 3.67 kB
assets/types-Bk23msdr.js (new) 9.16 kB 2.9 kB 2.37 kB
assets/Load3DConfiguration-Oxyb64sB.js (new) 8.91 kB 2.61 kB 2.31 kB
assets/comfy-logo-BxADqrWH.js (new) 8.6 kB 3.84 kB 3.24 kB
assets/WidgetImageCrop-Dguanz42.js (new) 8.49 kB 2.65 kB 2.34 kB
assets/SetMemberCreditLimitDialogContent-DOlJRiij.js (new) 8.47 kB 2.34 kB 2.06 kB
assets/nodeTemplates-CoN9L9IM.js (new) 8.32 kB 2.86 kB 2.51 kB
assets/WidgetImageCompare-DG_Aioqm.js (new) 8.13 kB 2.3 kB 2.02 kB
assets/Popover-D8H6LMcv.js (new) 8.13 kB 2.88 kB 2.55 kB
assets/WorkspaceSwitcherPopover-DeFCBkNG.js (new) 8.01 kB 2.38 kB 2.11 kB
assets/NightlySurveyController-Cg5u3V9Y.js (new) 7.5 kB 2.55 kB 2.25 kB
assets/CloudRunButtonWrapper-CupC9dvZ.js (new) 7.29 kB 2.29 kB 2.01 kB
assets/gemini-DxvHIIpm.js (new) 6.76 kB 1.18 kB 986 B
assets/commands-C9_85oGd.js (new) 6.53 kB 1.54 kB 1.31 kB
assets/WidgetWithControl-DDbYKMSR.js (new) 6.5 kB 2.66 kB 2.33 kB
assets/missingModelMetadata-BvE7VqNc.js (new) 6.45 kB 2.21 kB 1.93 kB
assets/AnimationControls-DbnihaQo.js (new) 6.1 kB 1.85 kB 1.64 kB
assets/CancelSubscriptionDialogContent-Dzk39HQj.js (new) 5.97 kB 1.99 kB 1.75 kB
assets/main-DU04XoiJ.js (new) 5.94 kB 1.92 kB 1.59 kB
assets/load3dPreviewExtensions-CxFPjPsz.js (new) 5.88 kB 1.81 kB 1.6 kB
assets/src-B6h0OJRf.js (new) 5.69 kB 1.61 kB 1.47 kB
assets/DowngradeRemoveMembersDialogContent-DN55l7Gj.js (new) 5.58 kB 1.89 kB 1.64 kB
assets/minimax-B3NM3ir2.js (new) 5.44 kB 2.48 kB 2.15 kB
assets/launchCancellationFlow-CfgeUAR2.js (new) 5.18 kB 1.78 kB 1.56 kB
assets/CreateWorkspaceDialogContent-BTtM4gHO.js (new) 5.12 kB 1.79 kB 1.55 kB
assets/CloudNotificationContent-DJ6Wu2_5.js (new) 5.05 kB 1.76 kB 1.51 kB
assets/ChangeMemberRoleDialogContent-Brg5oUGE.js (new) 4.97 kB 1.63 kB 1.43 kB
assets/InviteMemberDialogContent-DCWvy8Qr.js (new) 4.96 kB 1.64 kB 1.44 kB
assets/EditWorkspaceDialogContent-CLDScdgB.js (new) 4.93 kB 1.76 kB 1.52 kB
assets/PaletteSwatchRow-C3Qa2rWE.js (new) 4.86 kB 1.87 kB 1.66 kB
assets/WidgetTextarea-YFKFLBC8.js (new) 4.83 kB 1.88 kB 1.64 kB
assets/grain-DpjNtV4-.js (new) 4.83 kB 1.32 kB 975 B
assets/saveMesh-CBQi14qP.js (new) 4.76 kB 1.52 kB 1.34 kB
assets/brightness-contrast-D4ZrSTJK.js (new) 4.61 kB 1.56 kB 1.39 kB
assets/ValueControlPopover-BoKVyM_E.js (new) 4.49 kB 1.55 kB 1.38 kB
assets/ToggleGroupItem-CBJ1C7BI.js (new) 4.14 kB 1.41 kB 1.24 kB
assets/ApiNodesSignInContent-BMtGWI4h.js (new) 4.08 kB 1.31 kB 1.15 kB
assets/reportError-gkwW-D2R.js (new) 4.02 kB 1.72 kB 1.46 kB
assets/Slider-BUwrwxtc.js (new) 3.91 kB 1.43 kB 1.24 kB
assets/DeleteWorkspaceDialogContent-iKy4crFc.js (new) 3.84 kB 1.44 kB 1.24 kB
assets/WidgetBoundingBox-CzsfZDb9.js (new) 3.76 kB 1.03 kB 898 B
assets/RemoveMemberDialogContent-CaimzrgG.js (new) 3.76 kB 1.38 kB 1.19 kB
assets/WidgetGalleria-B33HqfsC.js (new) 3.75 kB 1.45 kB 1.29 kB
assets/RevokeInviteDialogContent-XHN73GMV.js (new) 3.67 kB 1.39 kB 1.21 kB
assets/LeaveWorkspaceDialogContent-BvH__syY.js (new) 3.67 kB 1.38 kB 1.19 kB
assets/tencent-DcxX2XL4.js (new) 3.63 kB 1.69 kB 1.49 kB
assets/WidgetToggleSwitch-Dx17CWfl.js (new) 3.56 kB 1.3 kB 1.15 kB
assets/hitpaw-C0NOpgD2.js (new) 3.51 kB 1.75 kB 1.5 kB
assets/InviteMemberUpsellDialogContent-uDIJSQX4.js (new) 3.47 kB 1.24 kB 1.09 kB
assets/sora-CahMvg3l.js (new) 3.46 kB 1.81 kB 1.56 kB
assets/workspaceCheckoutTelemetry-CWAiZiWH.js (new) 3.4 kB 1.52 kB 1.32 kB
assets/GlobalToast-BckQD7fC.js (new) 3.25 kB 1.3 kB 1.11 kB
assets/Media3DTop-B1VlWljB.js (new) 3.21 kB 1.26 kB 1.11 kB
assets/openai-cmoqR7c6.js (new) 3.21 kB 1.55 kB 1.38 kB
assets/get-video-components-Ft-NLDFC.js (new) 3.09 kB 1.37 kB 1.21 kB
assets/pixverse-CHKZYPBx.js (new) 3.08 kB 1.48 kB 1.28 kB
assets/kling-2U9Sap30.js (new) 3.08 kB 1.14 kB 973 B
assets/image-invert-CvSik4TT.js (new) 3.07 kB 1.03 kB 853 B
assets/WidgetMarkdown-MnoAi_GS.js (new) 3.07 kB 1.26 kB 1.09 kB
assets/WidgetInputText-DC_k1aL-.js (new) 3.04 kB 1.27 kB 1.14 kB
assets/MediaVideoTop-SN1RgDN7.js (new) 2.96 kB 1.19 kB 1.04 kB
assets/rodin-D99hR298.js (new) 2.93 kB 1.41 kB 1.23 kB
assets/load3dAdvanced-gv8jL-KE.js (new) 2.82 kB 1.1 kB 955 B
assets/ErrorPanelSurveyCta-DElLx_wI.js (new) 2.64 kB 1.14 kB 1.01 kB
assets/wan-B-4QUtRI.js (new) 2.62 kB 1.28 kB 1.13 kB
assets/loadExternalScript-Bah6Al85.js (new) 2.59 kB 913 B 744 B
assets/Switch-BmmAFla1.js (new) 2.49 kB 1.09 kB 969 B
assets/image-outpainting-DPutOHdl.js (new) 2.47 kB 1.13 kB 978 B
assets/image-outpaint-CuZDQ-s9.js (new) 2.46 kB 1.12 kB 976 B
assets/SubscribeToRun-Bon0Gtgl.js (new) 2.39 kB 1.04 kB 906 B
assets/tripo-BJxtNDyf.js (new) 2.38 kB 1.12 kB 989 B
assets/WidgetLayoutField-DrX6dxZ-.js (new) 2.38 kB 1.02 kB 936 B
assets/WidgetChart-Cbm6_FLG.js (new) 2.36 kB 999 B 864 B
assets/ltxv-CREe9jI1.js (new) 2.35 kB 1.2 kB 1.05 kB
assets/luma-CKtjQHSe.js (new) 2.32 kB 595 B 505 B
assets/image-inpaint-D-VnZoJS.js (new) 2.29 kB 1.07 kB 919 B
assets/vidu-DouVPJS-.js (new) 2.12 kB 1.02 kB 876 B
assets/rolldown-runtime-xtsTai4I.js (new) 2.07 kB 947 B 814 B
assets/TopBarHeader-CmY9ndnn.js (new) 2.01 kB 840 B 729 B
assets/video-inpaint-B0ovAfX_.js (new) 1.99 kB 957 B 823 B
assets/moonvalley-marey-DKF4OIv2.js (new) 1.98 kB 870 B 777 B
assets/image-to-layers-DCdlgpAV.js (new) 1.95 kB 868 B 705 B
assets/MediaImageTop-CAOzoh__.js (new) 1.95 kB 928 B 797 B
assets/claude-COhIiCXc.js (new) 1.85 kB 1.03 kB 895 B
assets/text-to-audio-DpKEmv6s.js (new) 1.84 kB 860 B 735 B
assets/TypeformEmbed-CzmaTPG-.js (new) 1.83 kB 811 B 711 B
assets/anthropic-BWmduUeu.js (new) 1.79 kB 1 kB 871 B
assets/wavespeed-Cf_Y-WE-.js (new) 1.78 kB 953 B 808 B
assets/MediaTextTop-Qo4dru8r.js (new) 1.77 kB 853 B 728 B
assets/pin-BBhiJ-Ro.js (new) 1.75 kB 981 B 849 B
assets/bria-01tswOT4.js (new) 1.74 kB 863 B 746 B
assets/auto-E0RPASnx.js (new) 1.7 kB 619 B 548 B
assets/video-interpolation-E1ZYZfjz.js (new) 1.7 kB 816 B 702 B
assets/WidgetColorPicker-Crv7bAJa.js (new) 1.69 kB 756 B 670 B
assets/voice-clone-CLECE4e1.js (new) 1.67 kB 878 B 709 B
assets/image-select-object-segmentation-pTwgE7RS.js (new) 1.66 kB 822 B 709 B
assets/Loader-C7rrUp-N.js (new) 1.64 kB 783 B 694 B
assets/WidgetColors-D9IUfc9A.js (new) 1.63 kB 805 B 710 B
assets/MediaAudioTop-lQ58D09J.js (new) 1.62 kB 807 B 667 B
assets/veo-CGwt9Auf.js (new) 1.62 kB 843 B 751 B
assets/stability-ai-GsPHcQLg.js (new) 1.61 kB 819 B 709 B
assets/bytedance-BAE74qy_.js (new) 1.61 kB 852 B 745 B
assets/pose-to-image-BvUGgc9H.js (new) 1.58 kB 819 B 689 B
assets/Textarea-CIOdLsAn.js (new) 1.56 kB 810 B 713 B
assets/image-collage-e-ttxsAp.js (new) 1.55 kB 613 B 493 B
assets/signInSchema-DptLg_mI.js (new) 1.55 kB 554 B 485 B
assets/webviewDetection-G_eepi8c.js (new) 1.52 kB 613 B 548 B
assets/image-to-3d-DZ2fsCrF.js (new) 1.52 kB 764 B 659 B
assets/menuBarStyles-8XlQj5r-.js (new) 1.52 kB 581 B 488 B
assets/pose-to-video-C6gVRnB7.js (new) 1.5 kB 785 B 667 B
assets/comfyCredits-QD6D3aQ0.js (new) 1.48 kB 530 B 462 B
assets/widgetPropFilter-C6CiCSHV.js (new) 1.47 kB 670 B 547 B
assets/VideoPlayOverlay-Pj8ipWNv.js (new) 1.46 kB 729 B 645 B
assets/image-vectorize-BPJBhZHU.js (new) 1.42 kB 683 B 594 B
assets/reve-D4nsQmOA.js (new) 1.41 kB 736 B 571 B
assets/video-upscale-DHzmQ_zv.js (new) 1.4 kB 698 B 598 B
assets/comfy-c-rvqaaLz6.js (new) 1.4 kB 795 B 689 B
assets/image-edit-D9ce-d34.js (new) 1.34 kB 701 B 609 B
assets/grok-Bn_ZS4mR.js (new) 1.34 kB 794 B 666 B
assets/runway-dTJ-BZlC.js (new) 1.34 kB 748 B 645 B
assets/depth-to-image-CVaRR23Y.js (new) 1.33 kB 718 B 616 B
assets/image-ai-edit-Bmy-5CCv.js (new) 1.33 kB 622 B 531 B
assets/canny-to-image-DcTSZY12.js (new) 1.32 kB 687 B 593 B
assets/video-select-object-segmentation-BXcZZs7A.js (new) 1.31 kB 688 B 570 B
assets/image-depth-DkhlVZog.js (new) 1.28 kB 681 B 590 B
assets/image-to-image-BqSVcceo.js (new) 1.26 kB 638 B 551 B
assets/depth-to-video-i-UPkQlp.js (new) 1.25 kB 682 B 587 B
assets/text-to-3d-CP_26bwF.js (new) 1.24 kB 650 B 565 B
assets/ButtonGroup-CbiAdmBE.js (new) 1.24 kB 643 B 561 B
assets/canny-to-video-Cn0VChNR.js (new) 1.24 kB 657 B 564 B
assets/ai-model-C8iGlxMz.js (new) 1.19 kB 575 B 501 B
assets/3d-decomp-RjA0gFmA.js (new) 1.19 kB 597 B 514 B
assets/nodeTypes-DB3gmLVM.js (new) 1.19 kB 492 B 424 B
assets/DialogClose-Qo-2__eP.js (new) 1.18 kB 610 B 545 B
assets/image-to-video-jztf067S.js (new) 1.18 kB 621 B 529 B
assets/mask-cDEa-6-s.js (new) 1.16 kB 500 B 436 B
assets/batch-images-node-zQB_peEw.js (new) 1.13 kB 597 B 508 B
assets/image-canny-B3ZrILNA.js (new) 1.13 kB 604 B 515 B
assets/canny-J_xT5t3B.js (new) 1.11 kB 595 B 514 B
assets/image-batch-DMOK_HMA.js (new) 1.11 kB 591 B 501 B
assets/cameraInfo-LS94PS-y.js (new) 1.1 kB 572 B 527 B
assets/recraft-DZ2oKkMO.js (new) 1.1 kB 556 B 484 B
assets/image-upscale-nq0-_m-2.js (new) 1.05 kB 558 B 473 B
assets/video-edit-DoAUmDnG.js (new) 1.04 kB 593 B 503 B
assets/MediaOtherTop-Bih2juu_.js (new) 1.02 kB 574 B 464 B
assets/extensions-blocks-Dl5rqs4I.js (new) 1.02 kB 543 B 460 B
assets/glow-QcBFWyCA.js (new) 1.02 kB 468 B 402 B
assets/template-rnD0AK7u.js (new) 993 B 498 B 426 B
assets/video-trim-DqUDHzQc.js (new) 977 B 509 B 437 B
assets/image-remove-background-Cg3Xau6F.js (new) 975 B 525 B 445 B
assets/frames-to-video-CZ7-VxFj.js (new) 955 B 535 B 448 B
assets/file-output-CQ0ZWFnN.js (new) 943 B 545 B 468 B
assets/image-compare-DdB4fbII.js (new) 943 B 537 B 460 B
assets/open-ai-chat-node-BaQlo11G.js (new) 942 B 518 B 440 B
assets/dial-JJKuN71R.js (new) 941 B 474 B 407 B
assets/cloudSessionCookie-Df5EWwFJ.js (new) 933 B 432 B 376 B
assets/cloudBadges-C89a1rAn.js (new) 922 B 514 B 458 B
assets/ComfyOrgHeader-DHnXyu2w.js (new) 906 B 496 B 432 B
assets/image-rotate-BZVAXcdZ.js (new) 899 B 499 B 431 B
assets/magnific-DyoOXzaM.js (new) 894 B 441 B 380 B
assets/image-captioning-DreocsxD.js (new) 891 B 489 B 416 B
assets/lora-loader-CqTfu1TX.js (new) 845 B 518 B 441 B
assets/load-3d-ChaXqnVx.js (new) 844 B 503 B 432 B
assets/save-3d-CYwbkXZ2.js (new) 838 B 499 B 427 B
assets/video-slice-RfomFSXB.js (new) 833 B 452 B 380 B
assets/load3dSerialize-BIPv2l0M.js (new) 832 B 393 B 336 B
assets/video-extract-frame-DpM1yIqF.js (new) 832 B 459 B 382 B
assets/channels-CWzr-AGk.js (new) 808 B 392 B 324 B
assets/text-to-image-CkeH6vgx.js (new) 763 B 468 B 389 B
assets/Load3DAdvanced-HWxVc8kV.js (new) 761 B 423 B 359 B
assets/bfl-D0kEkSSj.js (new) 745 B 454 B 384 B
assets/chromatic-aberration-AddZTK2j.js (new) 740 B 420 B 356 B
assets/image-blur-2EtiuWuI.js (new) 718 B 429 B 360 B
assets/quiver-DVpoQpQ5.js (new) 694 B 430 B 364 B
assets/image-shader-DWifxCrB.js (new) 685 B 398 B 336 B
assets/text-to-video-BecNw9zw.js (new) 685 B 436 B 365 B
assets/devFeatureFlagOverride-D9x6Noj0.js (new) 680 B 427 B 354 B
assets/video-enhance-BQCy6-3e.js (new) 671 B 412 B 344 B
assets/image-sharpen-BSWKHqeL.js (new) 662 B 414 B 351 B
assets/send-CCfAcvOS.js (new) 658 B 410 B 336 B
assets/video-captioning-DEya6ZKv.js (new) 628 B 390 B 329 B
assets/topaz-DRomf3uD.js (new) 618 B 389 B 337 B
assets/node-9_S0T5yn.js (new) 554 B 400 B 345 B
assets/subscriptionCancellationTelemetry-BF-Zq8Rx.js (new) 546 B 333 B 287 B
assets/load-video-CGUIEnct.js (new) 518 B 348 B 296 B
assets/widgetTypes-Cf58xZw1.js (new) 514 B 280 B 272 B
assets/save-video-BJqLQPeC.js (new) 512 B 348 B 292 B
assets/vRekaZIndex-DZQTlbbi.js (new) 505 B 330 B 280 B
assets/telemetry-IkzvF0TI.js (new) 499 B 299 B 243 B
assets/text-prompt-enhance-Bmq8gDVO.js (new) 492 B 339 B 280 B
assets/load-audio-epQbRZsp.js (new) 460 B 320 B 268 B
assets/save-audio-DZVtSVp_.js (new) 454 B 319 B 265 B
assets/nightlyBadges-CzdAK807.js (new) 411 B 272 B 229 B
assets/src-3i75gwLe.js (new) 407 B 290 B 244 B
assets/elevenlabs-BVR3dQ8G.js (new) 388 B 286 B 232 B
assets/play-BFqV6tIE.js (new) 369 B 256 B 225 B
assets/cloud-subscription-DJ2DFeD9.js (new) 223 B 154 B 133 B
assets/comfy-logo-single-B7u6lN8V.js (new) 217 B 154 B 117 B
assets/Load3dViewerContent-0MwdkhLE.js (new) 137 B 103 B 93 B
assets/WidgetBoundingBox-CWXOiORZ.js (new) 131 B 100 B 100 B
assets/missingModelMetadata-5DMJKoS9.js (new) 125 B 103 B 106 B
assets/Load3DAdvanced-oazRC6US.js (new) 122 B 97 B 90 B
assets/types-t0xJOOCt.js (new) 120 B 124 B 83 B
assets/WidgetLegacy-nnayMyCe.js (new) 117 B 106 B 102 B
assets/workflowDraftStoreV2-B_WA4G5R.js (new) 112 B 101 B 110 B
assets/CameraInfo-f5Y4BPDi.js (new) 110 B 93 B 92 B
assets/Load3D-Ca5sVtwW.js (new) 98 B 89 B 83 B
assets/i18n-lz7HCfuc.js (new) 97 B 92 B 95 B
assets/dist-Bp3Fn1Wt.js (new) 96 B 102 B 91 B
assets/startRecording-BOV6MsgY.js (new) 95 B 96 B 92 B
assets/changeTracker-DCAVwQfK.js (new) 91 B 93 B 88 B

Status: 290 added

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.4 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 6ms TBT · 72.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 227ms TBT · 89.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 125ms TBT · 99.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.3 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 163ms TBT · 176.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 489ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.0 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -154
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 40ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 78
canvas-mouse-sweep: task duration 1311ms
canvas-mouse-sweep: script duration 185ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 78.8 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -154
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 343ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 75.9 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 5ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 8
dom-widget-clipping: task duration 709ms
dom-widget-clipping: script duration 151ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 80.3 MB
dom-widget-clipping: DOM nodes 12
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 2
large-graph-idle: task duration 531ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 74.4 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -168
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 63
large-graph-pan: task duration 3001ms
large-graph-pan: script duration 1175ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 71.6 MB
large-graph-pan: DOM nodes 1
large-graph-pan: event listeners 10
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 2900ms
large-graph-zoom: script duration 1084ms
large-graph-zoom: TBT 6ms
large-graph-zoom: heap used 72.9 MB
large-graph-zoom: DOM nodes 24
large-graph-zoom: event listeners 12
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 4374ms
legacy-node-drag: script duration 1231ms
legacy-node-drag: TBT 227ms
legacy-node-drag: heap used 89.3 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 196
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 0ms
minimap-idle: layout count 0
minimap-idle: style recalc count 1
minimap-idle: task duration 487ms
minimap-idle: script duration 38ms
minimap-idle: TBT 0ms
minimap-idle: heap used 75.2 MB
minimap-idle: DOM nodes -277
minimap-idle: event listeners -75
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 499ms
subgraph-dom-widget-clipping: script duration 138ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 65.2 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 478ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 69.1 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -215
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 33ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 1074ms
subgraph-mouse-sweep: script duration 115ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 69.2 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -201
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 29ms
subgraph-transition-enter: layout count 13
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 913ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 125ms
subgraph-transition-enter: heap used 99.9 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 37ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 10552ms
viewport-pan-sweep: script duration 3980ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 68.4 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -138
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17143ms
vue-large-graph-idle: script duration 334ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.3 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 175
vue-large-graph-pan: task duration 21624ms
vue-large-graph-pan: script duration 1005ms
vue-large-graph-pan: TBT 163ms
vue-large-graph-pan: heap used 176.0 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7467
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 23ms
workflow-execution: layout count 3
workflow-execution: style recalc count 15
workflow-execution: task duration 120ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 72.5 MB
workflow-execution: DOM nodes 119
workflow-execution: event listeners 74
Raw data
{
  "timestamp": "2026-08-25T06:01:37.059Z",
  "gitSha": "2e415978dddd65c2a6358d58bf32ed64253cd8ec",
  "branch": "audit/ecs-test-fails",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2049.111000000011,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.352999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.409,
      "heapDeltaBytes": -8782508,
      "heapUsedBytes": 65936568,
      "domNodes": -281,
      "jsHeapTotalBytes": 3244032,
      "scriptDurationMs": 9.404,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2045.8770000000186,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 6.621000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.89400000000006,
      "heapDeltaBytes": -12271124,
      "heapUsedBytes": 61890128,
      "domNodes": -281,
      "jsHeapTotalBytes": 2719744,
      "scriptDurationMs": 8.613000000000003,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2372.852000000023,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 42.418,
      "layouts": 12,
      "layoutDurationMs": 3.681,
      "taskDurationMs": 1404.3000000000002,
      "heapDeltaBytes": 7470008,
      "heapUsedBytes": 81797976,
      "domNodes": -282,
      "jsHeapTotalBytes": 4554752,
      "scriptDurationMs": 199.353,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2233.8009999999713,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 37.938,
      "layouts": 12,
      "layoutDurationMs": 3.334,
      "taskDurationMs": 1218.129,
      "heapDeltaBytes": 8678228,
      "heapUsedBytes": 83542284,
      "domNodes": -282,
      "jsHeapTotalBytes": 4816896,
      "scriptDurationMs": 169.74399999999997,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.0940000000405,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 14.815000000000001,
      "layouts": 6,
      "layoutDurationMs": 0.658,
      "taskDurationMs": 343.37199999999996,
      "heapDeltaBytes": 4450892,
      "heapUsedBytes": 79542412,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.684,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1715.283999999997,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 14.623,
      "layouts": 6,
      "layoutDurationMs": 0.5720000000000001,
      "taskDurationMs": 343.37299999999993,
      "heapDeltaBytes": 4441412,
      "heapUsedBytes": 79623104,
      "domNodes": 75,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 10.546999999999997,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 983.7390000000141,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.647000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 717.0150000000001,
      "heapDeltaBytes": 11104724,
      "heapUsedBytes": 85922200,
      "domNodes": 12,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 154.04399999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 943.2160000000067,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.655999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 700.066,
      "heapDeltaBytes": 9444236,
      "heapUsedBytes": 82583928,
      "domNodes": 12,
      "jsHeapTotalBytes": 7864320,
      "scriptDurationMs": 148.073,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2043.374999999969,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.471,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.053,
      "heapDeltaBytes": -20397680,
      "heapUsedBytes": 78202040,
      "domNodes": -273,
      "jsHeapTotalBytes": -1961984,
      "scriptDurationMs": 36.85099999999999,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2032.974999999965,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.902000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 535.771,
      "heapDeltaBytes": -20581880,
      "heapUsedBytes": 77799592,
      "domNodes": -275,
      "jsHeapTotalBytes": -3010560,
      "scriptDurationMs": 37.94500000000001,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 4157.63800000002,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 9.474,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2981.695,
      "heapDeltaBytes": 13993356,
      "heapUsedBytes": 80037492,
      "domNodes": 2,
      "jsHeapTotalBytes": 5206016,
      "scriptDurationMs": 1157.346,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 4217.818999999963,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 8.750999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 3020.239,
      "heapDeltaBytes": 3751524,
      "heapUsedBytes": 70194516,
      "domNodes": 0,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 1191.891,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4826.885000000004,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.948999999999998,
      "layouts": 60,
      "layoutDurationMs": 7.784,
      "taskDurationMs": 2947.84,
      "heapDeltaBytes": 5492772,
      "heapUsedBytes": 77618420,
      "domNodes": 24,
      "jsHeapTotalBytes": 3932160,
      "scriptDurationMs": 1102.61,
      "eventListeners": 12,
      "totalBlockingTimeMs": 3,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4678.093999999987,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.899,
      "layouts": 60,
      "layoutDurationMs": 7.620000000000001,
      "taskDurationMs": 2852.5080000000003,
      "heapDeltaBytes": 3159696,
      "heapUsedBytes": 75194820,
      "domNodes": 24,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 1065.391,
      "eventListeners": 12,
      "totalBlockingTimeMs": 8,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 6003.799000000015,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.1469999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4378.874,
      "heapDeltaBytes": 24573452,
      "heapUsedBytes": 93794748,
      "domNodes": 0,
      "jsHeapTotalBytes": 6709248,
      "scriptDurationMs": 1227.762,
      "eventListeners": 196,
      "totalBlockingTimeMs": 231,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 6001.71499999999,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.955000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4369.59,
      "heapDeltaBytes": 24405096,
      "heapUsedBytes": 93551868,
      "domNodes": 0,
      "jsHeapTotalBytes": 5136384,
      "scriptDurationMs": 1233.435,
      "eventListeners": 196,
      "totalBlockingTimeMs": 222,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 1990.8230000000344,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.41100000000000164,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 489.1669999999999,
      "heapDeltaBytes": 12354024,
      "heapUsedBytes": 78476644,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 38.059999999999995,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2001.6910000000507,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 483.837,
      "heapDeltaBytes": 12629256,
      "heapUsedBytes": 79326316,
      "domNodes": -279,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 38.370000000000005,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 718.5210000000097,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.461,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.54200000000003,
      "heapDeltaBytes": -6604376,
      "heapUsedBytes": 69090580,
      "domNodes": 18,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 138.993,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 727.4649999999383,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.294,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 497.9939999999999,
      "heapDeltaBytes": -6086592,
      "heapUsedBytes": 67633716,
      "domNodes": 18,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 137.82599999999996,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2014.8019999999747,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.2829999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.65400000000005,
      "heapDeltaBytes": 1533292,
      "heapUsedBytes": 77627024,
      "domNodes": -295,
      "jsHeapTotalBytes": 3768320,
      "scriptDurationMs": 8.049,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2023.2640000000401,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.443,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 475.8399999999999,
      "heapDeltaBytes": -8797732,
      "heapUsedBytes": 67300024,
      "domNodes": -294,
      "jsHeapTotalBytes": 4816896,
      "scriptDurationMs": 8.123000000000001,
      "eventListeners": -199,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1819.008999999994,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 32.586999999999996,
      "layouts": 16,
      "layoutDurationMs": 3.908,
      "taskDurationMs": 1065.365,
      "heapDeltaBytes": -2730508,
      "heapUsedBytes": 72570408,
      "domNodes": -298,
      "jsHeapTotalBytes": 5341184,
      "scriptDurationMs": 113.398,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1793.2260000000042,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 33.599,
      "layouts": 16,
      "layoutDurationMs": 4.0969999999999995,
      "taskDurationMs": 1083.053,
      "heapDeltaBytes": -3179576,
      "heapUsedBytes": 72490936,
      "domNodes": -296,
      "jsHeapTotalBytes": 4816896,
      "scriptDurationMs": 115.72799999999998,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1416.8339999999944,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 29.356999999999996,
      "layouts": 13,
      "layoutDurationMs": 12.676,
      "taskDurationMs": 913.181,
      "heapDeltaBytes": 21810500,
      "heapUsedBytes": 104803000,
      "domNodes": 13671,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 30.38500000000001,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 125,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 14298.000000000002,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 36.47599999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10567.526999999998,
      "heapDeltaBytes": -26877592,
      "heapUsedBytes": 71571760,
      "domNodes": -272,
      "jsHeapTotalBytes": 3805184,
      "scriptDurationMs": 3989.8059999999996,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 14150.918000000047,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 37.48,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10536.432999999999,
      "heapDeltaBytes": -26707168,
      "heapUsedBytes": 71920848,
      "domNodes": -270,
      "jsHeapTotalBytes": 3543040,
      "scriptDurationMs": 3970.9089999999997,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333326,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18100.53599999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17125.267,
      "heapDeltaBytes": -24650416,
      "heapUsedBytes": 180536992,
      "domNodes": -6548,
      "jsHeapTotalBytes": 864256,
      "scriptDurationMs": 338.372,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18006.193999999938,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17161.273999999998,
      "heapDeltaBytes": -30077896,
      "heapUsedBytes": 180898008,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3747840,
      "scriptDurationMs": 328.805,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21781.929000000047,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 19.88000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21388.703999999998,
      "heapDeltaBytes": -26279292,
      "heapUsedBytes": 181373624,
      "domNodes": -6548,
      "jsHeapTotalBytes": -176128,
      "scriptDurationMs": 993.2170000000001,
      "eventListeners": -7465,
      "totalBlockingTimeMs": 159,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22277.56099999999,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 20.121,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21859.212,
      "heapDeltaBytes": -24469952,
      "heapUsedBytes": 187676656,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4882432,
      "scriptDurationMs": 1016.726,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 167,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 153.53600000003098,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 21.194000000000003,
      "layouts": 2,
      "layoutDurationMs": 0.7410000000000001,
      "taskDurationMs": 104.46099999999998,
      "heapDeltaBytes": 3835824,
      "heapUsedBytes": 75287620,
      "domNodes": 115,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.0120000000000005,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 463.4399999999914,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 23.953000000000003,
      "layouts": 3,
      "layoutDurationMs": 1.1430000000000002,
      "taskDurationMs": 135.579,
      "heapDeltaBytes": 6070500,
      "heapUsedBytes": 76654500,
      "domNodes": 123,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 7.679000000000002,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@coderabbitai

coderabbitai Bot commented Aug 22, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: a18db248-ddbe-4d41-942c-64656baa6f70

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Aug 22, 2026
@codecov

codecov Bot commented Aug 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/lib/litegraph/src/linkDeduplication.ts 66.66% 3 Missing ⚠️
src/lib/litegraph/src/subgraph/SubgraphNode.ts 93.75% 1 Missing ⚠️
@@                   Coverage Diff                    @@
##           fix/ecs-review-findings   #15654   +/-   ##
========================================================
  Coverage                    82.54%   82.54%           
========================================================
  Files                         1930     1930           
  Lines                       110106   110134   +28     
  Branches                     30165    30173    +8     
========================================================
+ Hits                         90885    90911   +26     
+ Misses                       18893    18886    -7     
- Partials                       328      337    +9     
Flag Coverage Δ
e2e 67.33% <89.65%> (-0.01%) ⬇️
unit 74.55% <93.75%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/LGraph.ts 78.34% <100.00%> (+0.03%) ⬆️
src/lib/litegraph/src/LLink.ts 69.61% <100.00%> (+0.68%) ⬆️
src/lib/litegraph/src/subgraph/SubgraphNode.ts 90.16% <93.75%> (+2.26%) ⬆️
src/lib/litegraph/src/linkDeduplication.ts 79.79% <66.66%> (-0.64%) ⬇️

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL added the refactor label Aug 23, 2026
@DrJKL
DrJKL force-pushed the audit/ecs-test-fails branch 2 times, most recently from 51903de to 97fc5d1 Compare August 24, 2026 01:27
@DrJKL
DrJKL marked this pull request as ready for review August 24, 2026 04:24
@dosubot dosubot Bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Aug 24, 2026
@DrJKL
DrJKL requested a review from a team August 24, 2026 17:49
@DrJKL
DrJKL force-pushed the audit/ecs-test-fails branch from f975b08 to 6fc9acb Compare August 24, 2026 17:49
@datadog-official

This comment has been minimized.

@DrJKL
DrJKL force-pushed the audit/ecs-test-fails branch 2 times, most recently from 0756b7a to 075aa6a Compare August 24, 2026 20:49
@DrJKL
DrJKL force-pushed the audit/ecs-test-fails branch from 075aa6a to 4069335 Compare August 24, 2026 23:38

@benjcooley benjcooley left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review summary

Severity Count
BLOCKER 1
SHOULD FIX 5
TRIVIAL 3

Three of the four production changes are sound; the fourth deletes links without tearing them down.

Blocking: realignInputLinkSlots now removes links by calling useLinkStore().updateEndpoints(scope, [], removals), which only displace()s the topology from the bucket. It skips everything LLink.disconnect() does — layoutStore.deleteLinkLayout, unregisterLinkTopology (so _graphScope and the useLinkStateStore entry survive), reroute pruning, and the onConnectionsChange(…, connected=false) callbacks on both endpoints. The reroute case is concrete: configure() prunes zero-link reroutes at LGraph.ts:2999-3003, before realignment at :3008, so a deleted link's reroutes persist at totalLinks === 0 — invisible but still box-selectable and still written back into the user's workflow. The same function already fires the connected=true callback for moves, so the removal path is inconsistent with its own neighbours.

Secondary: the !result.ok fallback deletes those links regardless of which validation error fired, so a duplicate-target between two moves (two serialized inputs sharing a name) also silently drops links that weren't blocking anything.

Verified as correct, for the record:

  • realignmentDataMap (LGraph.ts). The only real configure() override that mutates info.inputs is ComfyNode.configure (litegraphService.ts:473 / :580). It replaces data.inputs with node-definition-ordered entries, which LGraphNode.configure copies onto this.inputs — making the post-configure name→slot lookup self-consistent by construction, i.e. the old nodeDataMap was close to a no-op. The pre-configure snapshot is the only surviving record of the original name↔link pairing. Direction is right.
  • defineEnumerableTopologyFacade (LLink.ts). I went looking for fallout from making 7 accessors own-enumerable and found none: no extends LLink, no Object.keys/for…in/JSON.stringify/structuredClone/cloneDeep over real LLink instances (every such site works on asSerialisable() output), no Object.assign(<LLink>, …), and Pinia only stores link._state. LGraphNode.ts:1012 already uses the same per-instance-accessor pattern. Only issue is the unhoisted getOwnPropertyDescriptors call.
  • onAdded → rebuildInputWidgetBindings. Correct fix for #15565 — _convertToSubgraphImpl never calls configure() after this.add(subgraphNode), so this is the only place the UNASSIGNED_NODE_ID-keyed widget can be re-keyed. Flagged for cost and for the delete-on-failed-resolve edge, not correctness.

Note on CI: the six failing Playwright shards fail identically on the base branch (#15610), so they're inherited, not introduced here.

Test gaps: nothing covers what happens to reroutes or onConnectionsChange when realignment deletes a link, and the onAdded rebuild is only exercised through convert-to-subgraph, not through workflow load or paste — the two paths where it now runs on every subgraph node.

const destinationSlots = new Set(moved.map(({ slot }) => slot))
const removals = unmatched.filter(
(link) =>
graph.links.has(link.id) && destinationSlots.has(link.target_slot)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLOCKER — link removal here bypasses the disconnect lifecycle.

updateEndpoints(scope, [], removals) only calls displace() on the topology bucket. Everything else that LLink.disconnect() (LLink.ts:623-632) and LGraph._removeLink() (LGraph.ts:1824-1830) do is skipped:

  • layoutStore.deleteLinkLayout(id) — orphaned link layout + segment entries.
  • unregisterLinkTopology(link) — so link._graphScope stays set, its useLinkStateStore entry is never released, and linkByTopology still resolves the dead topology.
  • reroute pruning. This matters concretely: configure() runs its "drop reroutes that no live link passes through" loop at LGraph.ts:2999-3003, before realignInputLinkSlots at :3008. A link deleted here that had reroutes leaves them at totalLinks === 0 — invisible (they're only drawn via visibleReroutes accumulated during link rendering) but still box-selectable via getItemsInRect (LGraphCanvas.ts:4441) and still re-serialized into the user's workflow.
  • node.onConnectionsChange(INPUT, oldSlot, false, link, …) and the origin-side output notification. This same function already fires the connected=true callback for moves a few lines below, so the removal path is internally inconsistent — and per AGENTS.md onConnectionsChange is depended on by 40+ custom node repos for dynamic slot bookkeeping.

Keeping the removal inside the atomic batch is right (it's what makes the occupied-target validation pass), so don't swap to graph.removeLink. But after the batch succeeds, run the non-store half of teardown for each removed link: delete its layout, unregister its link state / _graphScope, prune now-empty reroutes, and fire the disconnect callback on both endpoints.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction — downgrading this from BLOCKER to SHOULD FIX. I went back and verified each consequence I asserted; two of them don't survive scrutiny and the reachability is much narrower than I implied. Details, so you can check my work:

Retracting the layout-leak claim. Link layouts are written only at render time (litegraphLinkAdapter.ts:341, inside renderLink), so nothing exists to leak during a fresh configure(). And on a re-configure of an already-rendered graph the omission is swamped by a pre-existing gap: layoutStore.handleClearGraph (layoutStore.ts:864-889) clears ynodes/contentSizes/ygroups/yreroutes but not linkLayouts/linkSegmentLayouts — only clearViewGeometry() does that, and it fires solely on a currentGraph reference change (GraphCanvas.vue:272,281). Stale link layouts already outlive every in-place workflow switch for all links. Not attributable to this PR.

Reachability: the deletion path can't fire for backend-registered nodes. ComfyNode.configure (litegraphService.ts:446 and :552) rebuilds data.inputs = [...definedInputs, ...extraInputs], and extraInputs (:470-472) keeps every serialized input whose name isn't a node-definition name. LGraphNode.configure then copies that onto this.inputs. So every serialized input name is present post-configure, unmatched is provably empty, and no link is deleted. Those two overrides are the only configure overrides in src/extensions, src/core, src/services.

That leaves two reachable cases: SubgraphNode (its configure discards the serialized inputs entirely, rebuilds from subgraph.inputNode.slots, then _internalConfigureAfterSlots filters on _subgraphSlot), and third-party classes registered directly via LiteGraph.registerNodeType that prune inputs. Note Subgraph extends LGraph (LGraph.ts:3160) and Subgraph.configure calls super.configure, so this also runs for nodes inside subgraph definitions.

Reroute orphan: confirmed, but milder than I said. The ordering holds — prune at LGraph.ts:3001-3005, realign at :3008. Reroute.linkIds is derived live (rerouteStore.buildMembershipIndex runs inside a computed over useLinkStore().graphTopologies), so the reroute genuinely drops to totalLinks === 0 rather than dangling on a dead id. It's never drawn (only reroutes walked during link rendering enter _visibleReroutes), but getItemsInRect (LGraphCanvas.ts:4441) iterates graph.reroutes.values() unconditionally, so it's an invisible box-selectable item; it's serialized, and pruned on the next load. Junk data, not breakage. Cheapest fix is moving the prune loop to after line 3008.

Link-state leak: confirmed as a leak, not as a bug. unregisterLinkState is skipped and useLinkStateStore has no bulk clear (only get/register/unregister), so the entry survives permanently. But _addLink → observeLinkId bumps lastLinkId past every loaded id before realign runs, so no newly minted link can reuse the freed id in-session, and the only reuse path (reloading the same JSON into the same graph id) re-triggers the same deletion. I could not construct a case where a surviving link inherits the stale color/_pos/data.

Also benign: leaving link._graphScope set can't cause a cross-delete — deleteLink and validateEndpointUpdates are both guarded by ownsPlacement (linkStore.ts:264-272), which fails once the topology is no longer the byId occupant.

What genuinely stands: the missing onConnectionsChange(…, false, …). disconnectInput fires it on both endpoints (LGraphNode.ts:3486-3500). dynamicWidgets.ts:611-617 consumes the false branch and — unlike the matchType handler directly above it at :306 — does not bail on app.configuringGraph, so it is live during load; it calls autogrowInputDisconnected (:500), which compacts the dynamic slot group. Deleting a link without it leaves an autogrow node holding a stale slot. That's a real behavioural gap, and it's inconsistent with this same function firing the connected=true callback for moves a few lines below.

So: worth fixing, and the reroute prune reorder is nearly free, but this isn't merge-blocking and I shouldn't have filed it as such.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One sharpening on reachability, since it's the crux of whether this matters.

Conditions 1 and 3 aren't independent constraints — they come free. In a saved file a link's target_slot equals the index of its input in the serialized inputs array, so if the input at index k is dropped, every later linked input shifts down and some link necessarily moves into slot k — exactly where the doomed link sits. The whole question is condition 2 (a serialized input name absent from node.inputs after configure()).

For first-party code, condition 2 is closed off in both directions:

  • widgetInputs.ts:577-595 is the one place that genuinely deletes named inputs during load, and it runs from onGraphConfigured → app.ts:917 triggerCallbackOnAllNodes → graph.onConfigure at LGraph.ts:3043, i.e. after realign at :3008.
  • widgetInputs.ts:599 onConfigure is gated on !app.configuringGraph (the depth counter set by the LGraph.prototype.configure wrapper at app.ts:903-911).
  • dynamicWidgets autogrow only adds during configure; its removal path is deferred to requestAnimationFrame (:606), and matchType returns early on app.configuringGraph (:312).

The gap worth knowing about: node.onConfigure fires at LGraphNode.ts:1192, inside the node-configure loop — before realign. Nothing gates third-party callbacks the way the first-party ones gate themselves, so an extension that calls removeInput from onConfigure or a nodeCreated hook puts an ordinary Comfy node into condition 2, and the link is deleted without the onConnectionsChange(…, false, …) that its own dynamic-input bookkeeping is waiting on. Per the entity-callback warning in AGENTS.md that's a known ecosystem pattern, and it's the case I'd actually design the teardown for.

Separately, worth a look while you're in here: SubgraphNode._internalConfigureAfterSlots:543 prunes with a raw this.inputs = this.inputs.filter(input => input._subgraphSlot) rather than removeInput, which is why an orphaned link is sitting at a live slot in the first place. That prune landed for a real report (#9977), so instance/definition divergence does happen — though the divergence attested there is duplicate names rather than absent ones, which can't trigger the deletion path.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 72613a372c: successful atomic removals now complete link teardown, increment graph version, notify both endpoints, and run reroute pruning after realignment.

removals.map((link) => link._state)
)
if (!result.ok) {
if (removals.length) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD FIX — the fallback deletes removals regardless of why the batch failed.

validateEndpointUpdates (linkStore.ts:275-327) can also return duplicate-target (two serialized inputs sharing a name both resolve to slots[0]), duplicate-topology, or unowned-topology. In those cases the unmatched links weren't blocking anything, yet they get deleted anyway — silent link loss during workflow load on an unrelated validation error.

Gate on the error code, and don't discard the retry's result:

if (result.error.code === 'occupied-target' && removals.length) {
  const removed = useLinkStore().updateEndpoints(
    graphScopeOf(graph),
    [],
    removals.map((link) => link._state)
  )
  if (!removed.ok) console.error('Failed to vacate blocked input slots', removed.error)
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 464cc93e57: the unconditional removal-only fallback was deleted. A rejected batch now logs and leaves all moves and removals unchanged.

}

for (let pass = 0; pass < referencedNames.size; pass++) {
for (let pass = 0; pass < Math.max(1, referencedNames.size); pass++) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD FIX — Math.max(1, …) is a no-op.

It only changes behaviour when referencedNames.size === 0, and in that case moved is built by iterating referencedNames, so it's necessarily empty and the loop breaks on the very next line. The unmatched/removals work added below sits after that break, so it isn't reached either.

It reads like it fixes something but changes nothing. Revert to referencedNames.size unless there's a case I'm missing.

Suggested change
for (let pass = 0; pass < Math.max(1, referencedNames.size); pass++) {
for (let pass = 0; pass < referencedNames.size; pass++) {

targetSlot: fields.target_slot
})
console.warn(
`Dropping competing link to occupied input ${fields.target_id}:${fields.target_slot}`,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRIVIAL — the production log string was reshaped to satisfy a loose test assertion.

linkDeduplication.conflictingOrigins.test.ts:87 asserts expect(warn.mock.calls.flat().join(' ')).toContain('3:0'). That failed only because the second argument is an object and join(' ') stringifies it as [object Object] — the ids were already there in targetNodeId / targetSlot. Better to fix the assertion than the message:

expect(warn).toHaveBeenCalledWith(
  expect.any(String),
  expect.objectContaining({ targetNodeId: toNodeId(3), targetSlot: 0 })
)

Related: LGraph.inputSlotRealign.test.ts:327 now hard-codes the full message text, which is a change-detector assertion. Also note fields.target_id is interpolated raw here while the dedup key above uses toNodeId(fields.target_id), so the two can disagree for string node ids.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superseded by #15689 — don't spend an edit on this. That PR rewrites this warn into reportDroppedLink (a single formatted string plus a trackLinkDedupDrop telemetry call) and replaces the assertion in linkDeduplication.conflictingOrigins.test.ts with an exact toHaveBeenCalledWith(...) rather than the loose toContain('3:0'). That's the fix I was asking for here, so this comment resolves itself in the rebase.

Worth flagging that the same test is a hard collision: both PRs convert it.fails('warns when a link is dropped in favour of a different origin') to it(...) and both rewrite the same assertion line, incompatibly. #15689's version should win.

For what it's worth, I checked and #15689 doesn't touch realignInputLinkSlots at all — its linkDeduplication.ts changes are confined to normalizeConfiguredTopology / remapLinkReferences / the new prune + telemetry helpers. So the realignment work in this PR, and my other two comments on it (the Math.max no-op at :165 and the unconditional removals deletion at :198), should survive the rebase unchanged and still need addressing.

}

function defineEnumerableTopologyFacade(link: LLink): void {
const descriptors = Object.getOwnPropertyDescriptors(LLink.prototype)

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD FIX — hoist this out of the constructor.

Object.getOwnPropertyDescriptors(LLink.prototype) materialises a descriptor object for every one of the ~48 prototype members and then throws away 41 of them — on every LLink construction. That's one per link on every workflow load (LGraph.ts:2847, :2888, :2990, plus once per subgraph definition) and one per user connect (LGraphNode.ts:3201, :3294, SubgraphInput.ts:92, …). Prototype descriptors are frozen after class definition, so this is pure waste:

const TOPOLOGY_DESCRIPTORS = (() => {
  const d = Object.getOwnPropertyDescriptors(LLink.prototype)
  return Object.fromEntries(
    (['id','type','origin_id','origin_slot','target_id','target_slot','parentId'] as const)
      .map((key) => [key, { ...d[key], enumerable: true }])
  )
})()

(evaluated after the class declaration, then Object.defineProperties(this, TOPOLOGY_DESCRIPTORS)).

The approach itself checks out — I looked for breakage from making these 7 own-enumerable and found none: no extends LLink anywhere, no Object.keys/for…in/JSON.stringify/structuredClone/cloneDeep over real LLink instances (every such site operates on asSerialisable()/serialize() output), no Object.assign(<LLink>, …), and Pinia only ever stores link._state, never the link. LGraphNode.ts:1012-1023 already uses the same per-instance-accessor trick, so the shape cost is an established pattern here.


override onAdded(_graph: LGraph): void {
this.invalidatePromotedViews()
this.rebuildInputWidgetBindings()

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD FIX — this wires previously-dead code into a hot lifecycle path, and it's redundant in two of the three callers.

rebuildInputWidgetBindings had zero callers on fix/ecs-review-findings. It has effectively never run in production, and it now runs for every SubgraphNode added to any graph.

It's genuinely needed for _convertToSubgraphImpl (LGraph.ts:2243 this.add(subgraphNode) is never followed by a configure(), so this is the only chance to re-key off UNASSIGNED_NODE_ID). But the two high-volume paths call configure() immediately after add():

  • LGraph.configure — LGraph.ts:2964 this.add(node, true) then :2971 node.configure(nodeData)
  • LGraphCanvas._deserializeItems — :4248 graph.add(node) then :4249 node.configure(info)

In both, configure() blows away this.inputs wholesale and re-runs _resolveInputWidget for every slot. So the full teardown + interior-link walk + registerWidget + _setConcreteSlots() + widget-promoted dispatch this does is thrown away microseconds later — per promoted input, per subgraph node, on every workflow load and every paste. The duplicate widget-promoted also double-fires createPromotionErrorReconciler.ts:74 (queueing a redundant dropOutOfScope/rescanHost microtask) and SubgraphEditor.vue:90.

The only thing onAdded actually needs to do is migrate the store entries whose id encodes the stale node id — no re-resolution required:

for (const input of this.inputs) {
  const stale = input.widgetId
  if (!stale) continue
  const fresh = widgetId(this.rootGraph.id, this.id, input.name)
  if (fresh === stale) continue
  const state = store.getWidget(stale)
  if (state) store.registerWidget(fresh, state, /* render state */)
  store.deleteWidget(stale)
  input.widgetId = fresh
}

}

const activeIds = new Set(this.inputs.map((input) => input.widgetId))
for (const { id } of previousBindings.values()) {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHOULD FIX — a failed re-resolve destroys the user's promoted value instead of leaving it alone.

_resolveInputWidget is best-effort: it returns without calling _setWidget when subgraphInput.linkIds is empty or every link.resolve() misses (the three console.warn paths at :627/:636/:641). The loop above also continues before calling it at all when input._subgraphSlot is missing — and input.widgetId has already been deleted by then.

In any of those cases input.widgetId is undefined, so the old id isn't in activeIds and this line deletes it. The promoted widget's value is gone permanently, rather than just staying where it was.

Only delete an old id when the input actually acquired a different one:

for (const [input, { id }] of previousBindings) {
  if (input.widgetId && input.widgetId !== id) store.deleteWidget(id)
}

// add before configure, otherwise configure cannot create links
this.add(node, true)
nodeDataMap.set(node.id, n_info)
realignmentDataMap.set(node.id, {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRIVIAL — the snapshot retains far more than it needs.

realignInputLinkSlots reads only nodeData.id and inputs[].name / inputs[].link, but this keeps a shallow copy of every node's entire serialized payload (including the widgets_values / properties references) plus a fresh object per input, alive until :3008. On a few-thousand-node workflow that's a second copy of the whole node array for what amounts to a name→link table.

A narrower structural param type on realignInputLinkSlots would let this be { id: node.id, inputs: n_info.inputs?.map(({ name, link }) => ({ name, link })) }.

The direction of this change is right, though — I checked the only real configure() override that touches info.inputs (ComfyNode.configure, litegraphService.ts:473 and :580). It replaces data.inputs with node-definition-ordered entries, which LGraphNode.configure then copies straight onto this.inputs, making the post-configure name→slot lookup self-consistent by construction — i.e. the old nodeDataMap was a near no-op. The pre-configure snapshot is the only surviving record of the original workflow's name↔link pairing.

this.addWidget('number', PROMOTED_INPUT, 0, () => {})
}
}
LiteGraph.registered_node_types[CONVERTIBLE_NODE_TYPE] = ConvertibleNode

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TRIVIAL — writing directly into LiteGraph.registered_node_types skips registerNodeType, which also sets .type, .title and the category registration. It works for this test, but the file already has a fixture for this (registerTestSubgraphNodeTypes) and LiteGraph.registerNodeType is used in the sibling realign specs.

Also: the if (!registered) guard means onTestFinished is only scheduled on the first call within a test. Fine as long as this helper is only ever called from a test body — it would silently leak the registration if someone moved it into beforeEach.

@DrJKL
DrJKL force-pushed the audit/ecs-test-fails branch from 4069335 to 8f1c609 Compare August 25, 2026 00:22
@benjcooley

Copy link
Copy Markdown
Collaborator

Verdict correction: no blockers.

I re-verified the one BLOCKER I filed and downgraded it to SHOULD FIX — full reasoning in the thread on linkDeduplication.ts. Short version: I retracted the orphaned-link-layout claim outright (link layouts are render-time only, and the omission is dominated by a pre-existing gap in layoutStore.handleClearGraph), the reroute and link-state consequences are real but cosmetic/leak-only, and the deletion path is provably unreachable for backend-registered nodes because ComfyNode.configure preserves every serialized input name via extraInputs (litegraphService.ts:470-472). What survives is the missing onConnectionsChange(…, false, …), which autogrow in dynamicWidgets.ts:611-617 does consume during load.

Revised counts:

Severity Count
BLOCKER 0
SHOULD FIX 6
TRIVIAL 3

The changes-requested state now rests on the SHOULD FIX items, not on anything merge-blocking. The two I'd most want addressed before merge are the unconditional removals deletion in the !result.ok fallback (it fires on duplicate-target too, where nothing was blocking) and the delete-on-failed-resolve in rebuildInputWidgetBindings. Math.max(1, referencedNames.size) is a no-op and should just be reverted.

Apologies for the overstated first pass.

@DrJKL
DrJKL force-pushed the audit/ecs-test-fails branch from 2831056 to cdedaca Compare August 25, 2026 05:48

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sequence gate only.

  • Current head reviewed.
  • Land #15689 first.
  • Rebase, preserve both contracts, re-request.
Full context for agent readers

Reviewed exact head cdedacaba87ea3d510cc40e8cb2981fc7366fdfb against its stacked base fix/ecs-review-findings, including implementation correctness, lifecycle/ecosystem regressions, tests, open review threads, workspace invariants, exceptions, roadmap, related open PRs, and the recorded ECS land order.

I found no independent blocking correctness defect in this delta. The seven own-enumerable LLink forwarding descriptors match the settled D-c6-01 compatibility contract. The remaining callback/cardinality concerns are non-blocking follow-ups already represented in the existing discussion.

Approval is not valid yet because DQ-27/xc-102 records a concrete overlap order: #15689 must land first after human approval. Then this stack must rebase while preserving #15689's authoritative-reference survivor, pruning, and telemetry semantics and replaying this PR's unmatched-link realignment behavior. The overlap is real in LGraph.inputSlotRealign.test.ts, linkDeduplication.conflictingOrigins.test.ts, and linkDeduplication.ts.

After that rebase, rerun the conflicting-origin, rejected-batch, and input-slot realignment detectors and request review on the resulting exact head.

christian-byrne added a commit that referenced this pull request Aug 26, 2026
Lands the 7-PR ECS stack (#15544 #15610 #15654 #15666 #15670 #15783 #15786) via merge vehicle.

Post-merge review follow-ups: #15929 (sub-issues #15930-#15938, #15946).

Co-authored-by: christian-byrne <cbyrne@comfy.org>
@christian-byrne

Copy link
Copy Markdown
Contributor

Landed in main via #15924 (squash e7d0d3e). Closing.

Full context for agent readers

This PR was part of the 7-PR ECS stack (#15544 #15610 #15654 #15666 #15670 #15783 #15786) merged as a single squash through vehicle PR #15924 (branch refactor/ecs-thermonuclear-cleanup-main = stack tip + main merge + CI fixes), per the stack-merge plan agreed between Christian and DrJKL on 2026-08-25.

@huang47 huang47 added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor risk:xhigh PR risk grade (advisory shadow check; grader-owned) size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subgraph instances added from the node search share one promoted widget value

5 participants