Skip to content

fix: realign links around unmatched inputs - #15772

Closed
christian-byrne wants to merge 1 commit into
feature/ecs-migrationfrom
fix/15581-realign-unmatched-inputs
Closed

christian-byrne wants to merge 1 commit into
feature/ecs-migrationfrom
fix/15581-realign-unmatched-inputs

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Keep valid sibling links aligned when a configured node renames or drops an input.

Changes

  • Include stale target-slot incumbents as removals in the atomic endpoint-update batch.
  • Promote the existing dropped-input, renamed-input, error-reporting, and rejected-batch characterisations to passing regression tests.

Testing

  • pnpm exec vitest run src/lib/litegraph/src/LGraph.inputSlotRealign.test.ts
  • pnpm typecheck
  • pnpm lint
  • pnpm format:check
  • pnpm knip
  • pnpm test:unit

E2E verification:

  1. Run pnpm dev and open a workflow saved with three linked custom-node inputs in the order in_c, in_a, in_b.
  2. Load a version of that custom node whose configure drops or renames in_c and exposes in_a, in_b in definition order.
  3. Confirm the stale in_c link is removed, while the other two links remain connected to in_a and in_b; re-save and reload and confirm the wiring remains unchanged.

Review focus

The endpoint moves and stale-incumbent removals are deliberately submitted in one updateEndpoints call so collision validation remains atomic.

Fixes #15581

@christian-byrne christian-byrne self-assigned this Aug 24, 2026
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8c2f2482-bb3e-4f40-ab0e-32e6bc46dcd2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 08/24/2026, 01:25:55 AM UTC

Links

🎭 Playwright: ✅ 1991 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1970 / ❌ 0 / ⚠️ 1 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 13ms TBT · 80.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 77.2 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 1ms TBT · 78.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.8 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 137ms TBT · 80.7 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.7 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.0 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 74ms TBT · 180.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.0 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 537ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.3 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 46ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 1347ms
canvas-mouse-sweep: script duration 179ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 71.2 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -155
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 413ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 69.9 MB
canvas-zoom-sweep: DOM nodes 74
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 9
dom-widget-clipping: task duration 431ms
dom-widget-clipping: script duration 32ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 59.2 MB
dom-widget-clipping: DOM nodes 14
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 624ms
large-graph-idle: script duration 45ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 67.1 MB
large-graph-idle: DOM nodes -276
large-graph-idle: event listeners -154
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 10ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 2791ms
large-graph-pan: script duration 1012ms
large-graph-pan: TBT 13ms
large-graph-pan: heap used 80.2 MB
large-graph-pan: DOM nodes -143
large-graph-pan: event listeners -87
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 8ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 2630ms
large-graph-zoom: script duration 911ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 77.2 MB
large-graph-zoom: DOM nodes -107
large-graph-zoom: event listeners -83
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 2154ms
legacy-node-drag: script duration 220ms
legacy-node-drag: TBT 1ms
legacy-node-drag: heap used 78.3 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 650ms
minimap-idle: script duration 42ms
minimap-idle: TBT 0ms
minimap-idle: heap used 67.4 MB
minimap-idle: DOM nodes -279
minimap-idle: event listeners -154
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 11ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 45
subgraph-dom-widget-clipping: task duration 583ms
subgraph-dom-widget-clipping: script duration 152ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.8 MB
subgraph-dom-widget-clipping: DOM nodes 16
subgraph-dom-widget-clipping: event listeners 9
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 531ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.2 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 41ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 1142ms
subgraph-mouse-sweep: script duration 126ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 67.8 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -216
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 13
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 927ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 137ms
subgraph-transition-enter: heap used 80.7 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 10100ms
viewport-pan-sweep: script duration 3538ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.7 MB
viewport-pan-sweep: DOM nodes -272
viewport-pan-sweep: event listeners -126
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17216ms
vue-large-graph-idle: script duration 358ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.0 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 174
vue-large-graph-pan: task duration 21508ms
vue-large-graph-pan: script duration 964ms
vue-large-graph-pan: TBT 74ms
vue-large-graph-pan: heap used 180.5 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 24ms
workflow-execution: layout count 4
workflow-execution: style recalc count 20
workflow-execution: task duration 141ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.0 MB
workflow-execution: DOM nodes 147
workflow-execution: event listeners 99
Raw data
{
  "timestamp": "2026-08-24T01:37:47.731Z",
  "gitSha": "50005be01c6bb8f1b51f86464fd9b51b9ff50ee7",
  "branch": "fix/15581-realign-unmatched-inputs",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2071.3719999999967,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.1480000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.9340000000001,
      "heapDeltaBytes": -614564,
      "heapUsedBytes": 68290560,
      "domNodes": -283,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 11.777000000000001,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2037.55799999999,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.114999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.83199999999994,
      "heapDeltaBytes": -11649080,
      "heapUsedBytes": 58161304,
      "domNodes": -279,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.097999999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2384.3729999999823,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 50.376000000000005,
      "layouts": 12,
      "layoutDurationMs": 3.9160000000000004,
      "taskDurationMs": 1483.401,
      "heapDeltaBytes": 4248420,
      "heapUsedBytes": 73226160,
      "domNodes": -279,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 199.564,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2272.360000000049,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 40.67700000000001,
      "layouts": 12,
      "layoutDurationMs": 3.0030000000000006,
      "taskDurationMs": 1210.484,
      "heapDeltaBytes": 7446204,
      "heapUsedBytes": 76171032,
      "domNodes": -283,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 157.504,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.4720000000307,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 18.129999999999995,
      "layouts": 6,
      "layoutDurationMs": 0.6849999999999999,
      "taskDurationMs": 465.21500000000003,
      "heapDeltaBytes": 3730076,
      "heapUsedBytes": 73063644,
      "domNodes": 72,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 16.399000000000004,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.2960000000812,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 18.660000000000004,
      "layouts": 6,
      "layoutDurationMs": 0.636,
      "taskDurationMs": 361.745,
      "heapDeltaBytes": 3778652,
      "heapUsedBytes": 73601972,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 10.996,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 719.4279999999935,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.3050000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 426.958,
      "heapDeltaBytes": -6746376,
      "heapUsedBytes": 62273820,
      "domNodes": 14,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 32.187,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 719.3009999999731,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.0009999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 434.96399999999994,
      "heapDeltaBytes": -6860768,
      "heapUsedBytes": 61835052,
      "domNodes": 14,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 32.204,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2051.9720000000348,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.627,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 664.477,
      "heapDeltaBytes": -21732760,
      "heapUsedBytes": 69144472,
      "domNodes": -278,
      "jsHeapTotalBytes": 3665920,
      "scriptDurationMs": 42.997,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2068.3709999999564,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 5.129,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 584.4250000000001,
      "heapDeltaBytes": -19098196,
      "heapUsedBytes": 71566680,
      "domNodes": -274,
      "jsHeapTotalBytes": -1052672,
      "scriptDurationMs": 46.294000000000004,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3659.710000000018,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 10.949,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2888.4590000000003,
      "heapDeltaBytes": -12618800,
      "heapUsedBytes": 78079136,
      "domNodes": -285,
      "jsHeapTotalBytes": 5201920,
      "scriptDurationMs": 1049.0049999999999,
      "eventListeners": -181,
      "totalBlockingTimeMs": 25,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3361.9200000000546,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 8.111999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2693.125,
      "heapDeltaBytes": 25546248,
      "heapUsedBytes": 90182216,
      "domNodes": 0,
      "jsHeapTotalBytes": 1273856,
      "scriptDurationMs": 974.415,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4464.718000000004,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.366999999999999,
      "layouts": 60,
      "layoutDurationMs": 7.529000000000001,
      "taskDurationMs": 2653.821,
      "heapDeltaBytes": -4281220,
      "heapUsedBytes": 67458200,
      "domNodes": -238,
      "jsHeapTotalBytes": -1613824,
      "scriptDurationMs": 918.862,
      "eventListeners": -177,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4529.678999999987,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.637000000000002,
      "layouts": 60,
      "layoutDurationMs": 7.859000000000002,
      "taskDurationMs": 2606.4149999999995,
      "heapDeltaBytes": 5713268,
      "heapUsedBytes": 94354124,
      "domNodes": 24,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 902.9399999999999,
      "eventListeners": 12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3363.4500000000003,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 4.943,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2200.301,
      "heapDeltaBytes": 16401024,
      "heapUsedBytes": 83593104,
      "domNodes": 0,
      "jsHeapTotalBytes": 2252800,
      "scriptDurationMs": 228.97,
      "eventListeners": 188,
      "totalBlockingTimeMs": 2,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3178.568000000041,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.318999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2106.823,
      "heapDeltaBytes": 13194532,
      "heapUsedBytes": 80661768,
      "domNodes": 0,
      "jsHeapTotalBytes": 1728512,
      "scriptDurationMs": 210.24899999999997,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.8089999999765,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 3.306,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 739.2319999999999,
      "heapDeltaBytes": -22588224,
      "heapUsedBytes": 69692004,
      "domNodes": -279,
      "jsHeapTotalBytes": 4452352,
      "scriptDurationMs": 43.82099999999999,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2054.7090000000026,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 2.541999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 561.6969999999999,
      "heapDeltaBytes": -20831824,
      "heapUsedBytes": 71606412,
      "domNodes": -279,
      "jsHeapTotalBytes": -1052672,
      "scriptDurationMs": 40.011,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 888.9899999999784,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 11.803,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 637.3259999999999,
      "heapDeltaBytes": 17562196,
      "heapUsedBytes": 87823776,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 161.98100000000002,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 742.4559999999474,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 10.297,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 528.583,
      "heapDeltaBytes": 18188032,
      "heapUsedBytes": 87915220,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 141.714,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2038.2930000000101,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 9.52,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 542.699,
      "heapDeltaBytes": -11233040,
      "heapUsedBytes": 58593768,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.629000000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2021.30800000009,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.047,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 519.1980000000001,
      "heapDeltaBytes": 1736964,
      "heapUsedBytes": 71941268,
      "domNodes": -296,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 9.334999999999999,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1967.318999999975,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 41.053,
      "layouts": 16,
      "layoutDurationMs": 4.7090000000000005,
      "taskDurationMs": 1194.275,
      "heapDeltaBytes": -6361020,
      "heapUsedBytes": 63317788,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 123.78599999999997,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1902.3140000000467,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 41.172,
      "layouts": 16,
      "layoutDurationMs": 4.786,
      "taskDurationMs": 1088.87,
      "heapDeltaBytes": 9024160,
      "heapUsedBytes": 78918320,
      "domNodes": -297,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 128.498,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1399.962999999957,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 31.551999999999996,
      "layouts": 13,
      "layoutDurationMs": 14.335,
      "taskDurationMs": 927.3289999999998,
      "heapDeltaBytes": -7489824,
      "heapUsedBytes": 84667288,
      "domNodes": 13671,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 30.044000000000008,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 137,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 14321.145999999999,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 43.088,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10841.978,
      "heapDeltaBytes": 2039988,
      "heapUsedBytes": 93222600,
      "domNodes": -273,
      "jsHeapTotalBytes": 7266304,
      "scriptDurationMs": 3839.2459999999996,
      "eventListeners": -123,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12439.47300000002,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 34.78,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9358.146999999999,
      "heapDeltaBytes": -5926772,
      "heapUsedBytes": 84396264,
      "domNodes": -271,
      "jsHeapTotalBytes": 1499136,
      "scriptDurationMs": 3236.5950000000003,
      "eventListeners": -129,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18659.805000000008,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18028.94,
      "heapDeltaBytes": -25980568,
      "heapUsedBytes": 179304520,
      "domNodes": -6548,
      "jsHeapTotalBytes": 5754880,
      "scriptDurationMs": 410.74699999999996,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 16978.29899999999,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16403.476,
      "heapDeltaBytes": -28880716,
      "heapUsedBytes": 177264608,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5705728,
      "scriptDurationMs": 304.311,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22354.698999999982,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 22.44299999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22056.357,
      "heapDeltaBytes": -23423716,
      "heapUsedBytes": 187867936,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4202496,
      "scriptDurationMs": 1011.3939999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 120,
      "frameDurationMs": 18.333333333333453,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21345.711999999934,
      "styleRecalcs": 174,
      "styleRecalcDurationMs": 17.91899999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20959.145,
      "heapDeltaBytes": -14454868,
      "heapUsedBytes": 190681864,
      "domNodes": -6548,
      "jsHeapTotalBytes": -344064,
      "scriptDurationMs": 915.6730000000001,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 28,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 533.7999999999283,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 27.083999999999996,
      "layouts": 4,
      "layoutDurationMs": 1.3680000000000003,
      "taskDurationMs": 157.619,
      "heapDeltaBytes": 6020696,
      "heapUsedBytes": 72545584,
      "domNodes": 150,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 10.711000000000002,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 473.27800000005027,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 21.845999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.2910000000000001,
      "taskDurationMs": 124.06499999999998,
      "heapDeltaBytes": 5553428,
      "heapUsedBytes": 72121496,
      "domNodes": 143,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.471,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Aug 24, 2026
@codecov

codecov Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                    Coverage Diff                    @@
##           feature/ecs-migration   #15772      +/-   ##
=========================================================
- Coverage                  82.35%   82.31%   -0.05%     
=========================================================
  Files                       1901     1900       -1     
  Lines                     107751   107656      -95     
  Branches                   33612    34040     +428     
=========================================================
- Hits                       88738    88614     -124     
- Misses                     18678    18706      +28     
- Partials                     335      336       +1     
Flag Coverage Δ
e2e 67.97% <100.00%> (+<0.01%) ⬆️
unit 73.93% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/linkDeduplication.ts 92.40% <100.00%> (+0.40%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-official

This comment has been minimized.

@christian-byrne

Copy link
Copy Markdown
Contributor Author
  • E2E still red after three attempts.
  • Christian owns the next diagnosis.
  • Do not rerun again without a cause.
Full context for agent readers

At head ea39f63414c51d8291506a34d1713eaab628f0dc, Actions run 32679654232 is attempt 3. playwright-tests (cloud) failed; e2e-status is the derivative failure. All 16 Chromium shards, mobile Chrome, mobile Safari, 0.5x, 2x, report merge, and coverage merge passed. Per the PR-hygiene stop rule, repeated failure on the same job is routed rather than rerun again.

@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing in favor of #15654 (DrJKL's provenance-based stale-link fix on the ECS branch).

Both PRs attack the same defect class — stale/dangling link references left around unmatched inputs after configure — but #15654 resolves it at the provenance layer: links are validated against the store's ownership records, so stale references are dropped where they're detected rather than realigned after the fact. This PR's broader deletion approach also removes links that the provenance check proves are still owned, and its env is red against the current branch head.

Verdict recorded in the workspace decision log as DQ-09: #15654 is strictly better (narrower blast radius, green CI, store-consistent). No unique coverage is lost by closing this — the realignment cases here are subsumed by #15654's validation pass.

@huang47 huang47 added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026 — with ChatGPT Codex Connector
@huang47 huang47 removed the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

risk:high PR risk grade (advisory shadow check; grader-owned) size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants