Repository navigation
fix: realign links around unmatched inputs - #15772
christian-byrne wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1991 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-24T01:37:47.731Z",
"gitSha": "50005be01c6bb8f1b51f86464fd9b51b9ff50ee7",
"branch": "fix/15581-realign-unmatched-inputs",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2071.3719999999967,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.1480000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.9340000000001,
"heapDeltaBytes": -614564,
"heapUsedBytes": 68290560,
"domNodes": -283,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 11.777000000000001,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2037.55799999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.114999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.83199999999994,
"heapDeltaBytes": -11649080,
"heapUsedBytes": 58161304,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.097999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2384.3729999999823,
"styleRecalcs": 79,
"styleRecalcDurationMs": 50.376000000000005,
"layouts": 12,
"layoutDurationMs": 3.9160000000000004,
"taskDurationMs": 1483.401,
"heapDeltaBytes": 4248420,
"heapUsedBytes": 73226160,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 199.564,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2272.360000000049,
"styleRecalcs": 79,
"styleRecalcDurationMs": 40.67700000000001,
"layouts": 12,
"layoutDurationMs": 3.0030000000000006,
"taskDurationMs": 1210.484,
"heapDeltaBytes": 7446204,
"heapUsedBytes": 76171032,
"domNodes": -283,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 157.504,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1756.4720000000307,
"styleRecalcs": 30,
"styleRecalcDurationMs": 18.129999999999995,
"layouts": 6,
"layoutDurationMs": 0.6849999999999999,
"taskDurationMs": 465.21500000000003,
"heapDeltaBytes": 3730076,
"heapUsedBytes": 73063644,
"domNodes": 72,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 16.399000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.2960000000812,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.660000000000004,
"layouts": 6,
"layoutDurationMs": 0.636,
"taskDurationMs": 361.745,
"heapDeltaBytes": 3778652,
"heapUsedBytes": 73601972,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 719.4279999999935,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.3050000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 426.958,
"heapDeltaBytes": -6746376,
"heapUsedBytes": 62273820,
"domNodes": 14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 32.187,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 719.3009999999731,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.0009999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 434.96399999999994,
"heapDeltaBytes": -6860768,
"heapUsedBytes": 61835052,
"domNodes": 14,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 32.204,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2051.9720000000348,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.627,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 664.477,
"heapDeltaBytes": -21732760,
"heapUsedBytes": 69144472,
"domNodes": -278,
"jsHeapTotalBytes": 3665920,
"scriptDurationMs": 42.997,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2068.3709999999564,
"styleRecalcs": 4,
"styleRecalcDurationMs": 5.129,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.4250000000001,
"heapDeltaBytes": -19098196,
"heapUsedBytes": 71566680,
"domNodes": -274,
"jsHeapTotalBytes": -1052672,
"scriptDurationMs": 46.294000000000004,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3659.710000000018,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.949,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2888.4590000000003,
"heapDeltaBytes": -12618800,
"heapUsedBytes": 78079136,
"domNodes": -285,
"jsHeapTotalBytes": 5201920,
"scriptDurationMs": 1049.0049999999999,
"eventListeners": -181,
"totalBlockingTimeMs": 25,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 3361.9200000000546,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.111999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2693.125,
"heapDeltaBytes": 25546248,
"heapUsedBytes": 90182216,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 974.415,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4464.718000000004,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.366999999999999,
"layouts": 60,
"layoutDurationMs": 7.529000000000001,
"taskDurationMs": 2653.821,
"heapDeltaBytes": -4281220,
"heapUsedBytes": 67458200,
"domNodes": -238,
"jsHeapTotalBytes": -1613824,
"scriptDurationMs": 918.862,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4529.678999999987,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.637000000000002,
"layouts": 60,
"layoutDurationMs": 7.859000000000002,
"taskDurationMs": 2606.4149999999995,
"heapDeltaBytes": 5713268,
"heapUsedBytes": 94354124,
"domNodes": 24,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 902.9399999999999,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3363.4500000000003,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.943,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2200.301,
"heapDeltaBytes": 16401024,
"heapUsedBytes": 83593104,
"domNodes": 0,
"jsHeapTotalBytes": 2252800,
"scriptDurationMs": 228.97,
"eventListeners": 188,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3178.568000000041,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.318999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2106.823,
"heapDeltaBytes": 13194532,
"heapUsedBytes": 80661768,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 210.24899999999997,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.8089999999765,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.306,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 739.2319999999999,
"heapDeltaBytes": -22588224,
"heapUsedBytes": 69692004,
"domNodes": -279,
"jsHeapTotalBytes": 4452352,
"scriptDurationMs": 43.82099999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2054.7090000000026,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.541999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 561.6969999999999,
"heapDeltaBytes": -20831824,
"heapUsedBytes": 71606412,
"domNodes": -279,
"jsHeapTotalBytes": -1052672,
"scriptDurationMs": 40.011,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 888.9899999999784,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.803,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 637.3259999999999,
"heapDeltaBytes": 17562196,
"heapUsedBytes": 87823776,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 161.98100000000002,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 742.4559999999474,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.297,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 528.583,
"heapDeltaBytes": 18188032,
"heapUsedBytes": 87915220,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 141.714,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.2930000000101,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.52,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.699,
"heapDeltaBytes": -11233040,
"heapUsedBytes": 58593768,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.629000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2021.30800000009,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.047,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.1980000000001,
"heapDeltaBytes": 1736964,
"heapUsedBytes": 71941268,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.334999999999999,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1967.318999999975,
"styleRecalcs": 77,
"styleRecalcDurationMs": 41.053,
"layouts": 16,
"layoutDurationMs": 4.7090000000000005,
"taskDurationMs": 1194.275,
"heapDeltaBytes": -6361020,
"heapUsedBytes": 63317788,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 123.78599999999997,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1902.3140000000467,
"styleRecalcs": 74,
"styleRecalcDurationMs": 41.172,
"layouts": 16,
"layoutDurationMs": 4.786,
"taskDurationMs": 1088.87,
"heapDeltaBytes": 9024160,
"heapUsedBytes": 78918320,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 128.498,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1399.962999999957,
"styleRecalcs": 18,
"styleRecalcDurationMs": 31.551999999999996,
"layouts": 13,
"layoutDurationMs": 14.335,
"taskDurationMs": 927.3289999999998,
"heapDeltaBytes": -7489824,
"heapUsedBytes": 84667288,
"domNodes": 13671,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.044000000000008,
"eventListeners": 2383,
"totalBlockingTimeMs": 137,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 14321.145999999999,
"styleRecalcs": 246,
"styleRecalcDurationMs": 43.088,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10841.978,
"heapDeltaBytes": 2039988,
"heapUsedBytes": 93222600,
"domNodes": -273,
"jsHeapTotalBytes": 7266304,
"scriptDurationMs": 3839.2459999999996,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 12439.47300000002,
"styleRecalcs": 246,
"styleRecalcDurationMs": 34.78,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9358.146999999999,
"heapDeltaBytes": -5926772,
"heapUsedBytes": 84396264,
"domNodes": -271,
"jsHeapTotalBytes": 1499136,
"scriptDurationMs": 3236.5950000000003,
"eventListeners": -129,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18659.805000000008,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18028.94,
"heapDeltaBytes": -25980568,
"heapUsedBytes": 179304520,
"domNodes": -6548,
"jsHeapTotalBytes": 5754880,
"scriptDurationMs": 410.74699999999996,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16978.29899999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16403.476,
"heapDeltaBytes": -28880716,
"heapUsedBytes": 177264608,
"domNodes": -6548,
"jsHeapTotalBytes": -5705728,
"scriptDurationMs": 304.311,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22354.698999999982,
"styleRecalcs": 174,
"styleRecalcDurationMs": 22.44299999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22056.357,
"heapDeltaBytes": -23423716,
"heapUsedBytes": 187867936,
"domNodes": -6548,
"jsHeapTotalBytes": -4202496,
"scriptDurationMs": 1011.3939999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 120,
"frameDurationMs": 18.333333333333453,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21345.711999999934,
"styleRecalcs": 174,
"styleRecalcDurationMs": 17.91899999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20959.145,
"heapDeltaBytes": -14454868,
"heapUsedBytes": 190681864,
"domNodes": -6548,
"jsHeapTotalBytes": -344064,
"scriptDurationMs": 915.6730000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 28,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 533.7999999999283,
"styleRecalcs": 20,
"styleRecalcDurationMs": 27.083999999999996,
"layouts": 4,
"layoutDurationMs": 1.3680000000000003,
"taskDurationMs": 157.619,
"heapDeltaBytes": 6020696,
"heapUsedBytes": 72545584,
"domNodes": 150,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.711000000000002,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 473.27800000005027,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.845999999999997,
"layouts": 3,
"layoutDurationMs": 1.2910000000000001,
"taskDurationMs": 124.06499999999998,
"heapDeltaBytes": 5553428,
"heapUsedBytes": 72121496,
"domNodes": 143,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.471,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## feature/ecs-migration #15772 +/- ##
=========================================================
- Coverage 82.35% 82.31% -0.05%
=========================================================
Files 1901 1900 -1
Lines 107751 107656 -95
Branches 33612 34040 +428
=========================================================
- Hits 88738 88614 -124
- Misses 18678 18706 +28
- Partials 335 336 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 30 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
Full context for agent readersAt head |
|
Closing in favor of #15654 (DrJKL's provenance-based stale-link fix on the ECS branch). Both PRs attack the same defect class — stale/dangling link references left around unmatched inputs after configure — but #15654 resolves it at the provenance layer: links are validated against the store's ownership records, so stale references are dropped where they're detected rather than realigned after the fact. This PR's broader deletion approach also removes links that the provenance check proves are still owned, and its env is red against the current branch head. Verdict recorded in the workspace decision log as DQ-09: #15654 is strictly better (narrower blast radius, green CI, store-consistent). No unique coverage is lost by closing this — the realignment cases here are subsumed by #15654's validation pass. |
Summary
Keep valid sibling links aligned when a configured node renames or drops an input.
Changes
Testing
pnpm exec vitest run src/lib/litegraph/src/LGraph.inputSlotRealign.test.tspnpm typecheckpnpm lintpnpm format:checkpnpm knippnpm test:unitE2E verification:
pnpm devand open a workflow saved with three linked custom-node inputs in the orderin_c,in_a,in_b.configuredrops or renamesin_cand exposesin_a,in_bin definition order.in_clink is removed, while the other two links remain connected toin_aandin_b; re-save and reload and confirm the wiring remains unchanged.Review focus
The endpoint moves and stale-incumbent removals are deliberately submitted in one
updateEndpointscall so collision validation remains atomic.Fixes #15581