Repository navigation
Conversation
🎭 Playwright: ✅ 1997 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.35 MB gzipDetailsSummary
Category Glance App Entry Points — 3.71 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.4 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 124 kBTop-level views, pages, and routed surfaces
Status: 17 added Panels & Settings — 591 kBConfiguration panels, inspectors, and settings screens
Status: 27 added User & Accounts — 27.5 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 125 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 112 kBReusable component library chunks
Status: 15 added Data & Services — 3.5 MBStores, services, APIs, and repositories
Status: 17 added Utilities & Hooks — 549 kBHelpers, composables, and utility bundles
Status: 37 added Vendor & Third-Party — 18.1 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 15.1 MBBundles that do not match a named category
Status: 290 added ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-25T06:02:13.020Z",
"gitSha": "5372422dacf41cdc90fc936837fbb9b8d3549622",
"branch": "refactor/ecs-thermonuclear-cleanup",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2050.003000000004,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.085000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.778,
"heapDeltaBytes": -12234504,
"heapUsedBytes": 62027196,
"domNodes": -280,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 13.833000000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2053.788000000054,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.592000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 518.5540000000001,
"heapDeltaBytes": -8669312,
"heapUsedBytes": 66104400,
"domNodes": -279,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 10.395999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2500.6520000000023,
"styleRecalcs": 80,
"styleRecalcDurationMs": 46.997,
"layouts": 12,
"layoutDurationMs": 3.6949999999999994,
"taskDurationMs": 1530.577,
"heapDeltaBytes": -18243128,
"heapUsedBytes": 56979464,
"domNodes": -282,
"jsHeapTotalBytes": 4816896,
"scriptDurationMs": 233.53199999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2242.313999999965,
"styleRecalcs": 78,
"styleRecalcDurationMs": 41.19499999999999,
"layouts": 12,
"layoutDurationMs": 3.6690000000000005,
"taskDurationMs": 1338.58,
"heapDeltaBytes": 7467228,
"heapUsedBytes": 82718996,
"domNodes": -281,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 203.099,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1764.4990000000007,
"styleRecalcs": 29,
"styleRecalcDurationMs": 23.327,
"layouts": 6,
"layoutDurationMs": 0.628,
"taskDurationMs": 436.035,
"heapDeltaBytes": 4426688,
"heapUsedBytes": 79568892,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 14.216000000000003,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1733.5259999999835,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.285000000000004,
"layouts": 6,
"layoutDurationMs": 0.7919999999999998,
"taskDurationMs": 392.71,
"heapDeltaBytes": 4302812,
"heapUsedBytes": 79581640,
"domNodes": 74,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.668,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 1070.8870000000275,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.859,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 791.482,
"heapDeltaBytes": 11170488,
"heapUsedBytes": 86410748,
"domNodes": 14,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 168.73300000000003,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 1041.8139999999312,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.944000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 783.829,
"heapDeltaBytes": 11139268,
"heapUsedBytes": 86287024,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 167.61200000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2024.6369999999843,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.0589999999999975,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.314,
"heapDeltaBytes": 12747168,
"heapUsedBytes": 78356156,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.604,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 1999.3220000000065,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 539.5589999999999,
"heapDeltaBytes": 13008672,
"heapUsedBytes": 78676184,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 43.216,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 4189.517999999964,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.5,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3282.8410000000003,
"heapDeltaBytes": 4870528,
"heapUsedBytes": 70865276,
"domNodes": -280,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 1268.1,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 4306.878999999981,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.766,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3640.425,
"heapDeltaBytes": -16864668,
"heapUsedBytes": 80815600,
"domNodes": -279,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 1374.734,
"eventListeners": -177,
"totalBlockingTimeMs": 5,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 5055.693000000019,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.898,
"layouts": 60,
"layoutDurationMs": 7.792999999999999,
"taskDurationMs": 3048.567,
"heapDeltaBytes": 4554696,
"heapUsedBytes": 76477308,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 1120.4610000000002,
"eventListeners": 12,
"totalBlockingTimeMs": 11,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 5063.372000000072,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.404000000000002,
"layouts": 60,
"layoutDurationMs": 7.743999999999999,
"taskDurationMs": 3069.358,
"heapDeltaBytes": 4183292,
"heapUsedBytes": 76143332,
"domNodes": 24,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 1124.283,
"eventListeners": 14,
"totalBlockingTimeMs": 13,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 6142.5930000000335,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4688.114,
"heapDeltaBytes": 24255580,
"heapUsedBytes": 93585152,
"domNodes": 0,
"jsHeapTotalBytes": 6447104,
"scriptDurationMs": 1342.257,
"eventListeners": 196,
"totalBlockingTimeMs": 432,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 6269.643999999971,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.831000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4921.96,
"heapDeltaBytes": 23634464,
"heapUsedBytes": 93324940,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 1415.195,
"eventListeners": 194,
"totalBlockingTimeMs": 582,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.829000000016,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.1479999999999,
"heapDeltaBytes": 12763616,
"heapUsedBytes": 78852944,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 42.803,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2003.6659999999529,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 512.953,
"heapDeltaBytes": 12602684,
"heapUsedBytes": 79337000,
"domNodes": -278,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.89300000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 746.6850000000136,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.932,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.649,
"heapDeltaBytes": -6089680,
"heapUsedBytes": 67671648,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.008,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 751.9779999998946,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.115,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 543.223,
"heapDeltaBytes": -6906556,
"heapUsedBytes": 69173116,
"domNodes": 16,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 150.604,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2016.362000000015,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.812,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.90999999999997,
"heapDeltaBytes": -4225684,
"heapUsedBytes": 69669912,
"domNodes": -296,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.737999999999998,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2053.967000000057,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.668,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.858,
"heapDeltaBytes": -4954152,
"heapUsedBytes": 68142188,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 10.045,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1924.9680000000353,
"styleRecalcs": 80,
"styleRecalcDurationMs": 42.234,
"layouts": 16,
"layoutDurationMs": 4.766,
"taskDurationMs": 1180.4430000000002,
"heapDeltaBytes": 6955008,
"heapUsedBytes": 83327572,
"domNodes": -295,
"jsHeapTotalBytes": 5079040,
"scriptDurationMs": 131.636,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1971.6429999999718,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.666,
"layouts": 16,
"layoutDurationMs": 4.574,
"taskDurationMs": 1179.462,
"heapDeltaBytes": -3731160,
"heapUsedBytes": 72539792,
"domNodes": -297,
"jsHeapTotalBytes": 4816896,
"scriptDurationMs": 128.018,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.3059999999768,
"styleRecalcs": 17,
"styleRecalcDurationMs": 31.504000000000005,
"layouts": 12,
"layoutDurationMs": 14.095,
"taskDurationMs": 970.8319999999999,
"heapDeltaBytes": 1830656,
"heapUsedBytes": 98601692,
"domNodes": 13671,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 32.49300000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 136,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 15521.546,
"styleRecalcs": 243,
"styleRecalcDurationMs": 33.541000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11682.226,
"heapDeltaBytes": -27012876,
"heapUsedBytes": 71972640,
"domNodes": -275,
"jsHeapTotalBytes": 3018752,
"scriptDurationMs": 4392.675,
"eventListeners": -119,
"totalBlockingTimeMs": 4,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 15810.685000000034,
"styleRecalcs": 244,
"styleRecalcDurationMs": 35.57200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11939.182,
"heapDeltaBytes": -27263276,
"heapUsedBytes": 71826840,
"domNodes": -275,
"jsHeapTotalBytes": 4067328,
"scriptDurationMs": 4420.09,
"eventListeners": -119,
"totalBlockingTimeMs": 6,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17930.938000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17057.463,
"heapDeltaBytes": -36049648,
"heapUsedBytes": 176975776,
"domNodes": -6548,
"jsHeapTotalBytes": -3784704,
"scriptDurationMs": 337.329,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17980.660999999942,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17210.374,
"heapDeltaBytes": -33002788,
"heapUsedBytes": 177997380,
"domNodes": -6548,
"jsHeapTotalBytes": -2129920,
"scriptDurationMs": 348.603,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21688.02199999999,
"styleRecalcs": 172,
"styleRecalcDurationMs": 19.146000000000026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21324.984999999997,
"heapDeltaBytes": -32212996,
"heapUsedBytes": 180815184,
"domNodes": -6548,
"jsHeapTotalBytes": -6668288,
"scriptDurationMs": 1030.987,
"eventListeners": -7469,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21722.684000000074,
"styleRecalcs": 176,
"styleRecalcDurationMs": 20.210999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21424.321,
"heapDeltaBytes": -20789616,
"heapUsedBytes": 192165696,
"domNodes": -6548,
"jsHeapTotalBytes": -6213632,
"scriptDurationMs": 1020.2850000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 7,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 126.93699999999808,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.142000000000003,
"layouts": 6,
"layoutDurationMs": 1.434,
"taskDurationMs": 97.76300000000002,
"heapDeltaBytes": 3554576,
"heapUsedBytes": 74993360,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.607000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 460.48800000005485,
"styleRecalcs": 13,
"styleRecalcDurationMs": 22.271000000000004,
"layouts": 3,
"layoutDurationMs": 0.772,
"taskDurationMs": 133.35400000000004,
"heapDeltaBytes": 5880816,
"heapUsedBytes": 77394536,
"domNodes": 119,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.226,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
} |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## fix/ecs-valid-review-findings #15786 +/- ##
=================================================================
+ Coverage 82.49% 82.57% +0.07%
=================================================================
Files 1931 1933 +2
Lines 110133 110260 +127
Branches 30633 30220 -413
=================================================================
+ Hits 90852 91044 +192
+ Misses 18946 18879 -67
- Partials 335 337 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 55 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dd7c07b to
7539561
Compare
This comment has been minimized.
This comment has been minimized.
7539561 to
15303ea
Compare
15303ea to
2690f71
Compare
benjcooley
left a comment
There was a problem hiding this comment.
Review Summary
Mostly a good refactor — the module splits are clean (no tests lost in the LGraphNode.test.ts three-way split, and processedWidgetRenderModel.ts is a faithful extraction), and leaning on updateEndpoints' validate-then-apply contract is the right call. The problems are all in what the atomicity rewrite dropped on the way through.
| Severity | Count |
|---|---|
| BLOCKER | 1 |
| SHOULD FIX | 3 |
| TRIVIAL | 2 |
BLOCKER — useNodeReplacement.ts:269: swapping nodeGraph.removeLink() for link.disconnect() drops the disconnectInput call, so neither endpoint of a dropped link gets onConnectionsChange, and graph.incrementVersion() never fires. Nodes downstream of a replaced placeholder keep stale connection state. The tests stub link.disconnect, so this is invisible to the suite.
SHOULD FIX
useNodeReplacement.ts:257— the new rollback restores ownership but notonRemoved(), which already ran. Failure leaves a live-but-torn-down node in the graph.linkDeduplication.ts:198—breakabandons all of a node's remaining moves, not just the conflicting one. The updated test documents a link now staying on the wrong input, which is the partial-landing behavior #15581 added.useNodeReplacement.test.ts:420— the endpoint-rejection rollback path named in the PR's own review focus has no coverage.
TRIVIAL — a dead node.order write after detach, and a shared try that lets a throwing onNodeAdded swallow the node:added dispatch.
Note this targets fix/ecs-valid-review-findings, not main.
| node.graph = null | ||
| node.order = order | ||
| nodeGraph._nodes_by_id[newNode.id] = newNode | ||
| for (const { link } of topology.removals) link.disconnect(nodeGraph) |
There was a problem hiding this comment.
BLOCKER
This replaces nodeGraph.removeLink(link.id) with a bare link.disconnect(). removeLink first calls getNodeById(link.target_id).disconnectInput(slot, false), which fires onConnectionsChange(INPUT, ...) on the target and onConnectionsChange(OUTPUT, ...) on the origin, plus graph.incrementVersion() and setDirtyCanvas. link.disconnect() does none of that.
So when a replacement drops a link, the node on the other end is never told. Concretely: placeholder's output 0 feeds another node's input, output_mapping doesn't cover slot 0, the link lands in removals — the downstream node keeps stale type/widget state. Real consumers of that callback in-tree: useErrorClearingHooks, useWatchWidget, useVideoSourceUrl, dynamicWidgets (Autogrow), and PrimitiveNode.onLastDisconnect. Plus the extension ecosystem, per AGENTS.md.
The test suite can't catch this — createMockLink stubs disconnect: vi.fn().
Either keep removeLink for the litegraph-side teardown, or fire onConnectionsChange on both endpoints (and bump graph version) alongside the disconnect loop.
There was a problem hiding this comment.
Correcting my own suggested fix above — the finding stands but "keep removeLink" would not work here.
By line 269 the swap has already happened: _nodes_by_id[newNode.id] = newNode runs on line 268, so removeLink's internal getNodeById(link.origin_id) now resolves to the new node. In the removes unmapped links without removing mapped links case the new node has no output at index 1, so disconnectInput would bail at if (!output) return false — no callbacks fired, and link_info.disconnect() never reached, leaking the link.
So the fix is one of:
- move the removal loop back above the node swap (where it was), so
removeLinkresolves the old node and its outputs; or - keep it here and fire
onConnectionsChangeexplicitly on the surviving endpoint (resolved from the plan, not fromgetNodeById) plusnodeGraph.incrementVersion().
The first is closer to the previous behavior; the second fits the "plan then apply" shape better since topology.removals already holds the LLink.
There was a problem hiding this comment.
Addressed in 577b079594: committed removals now increment graph version and notify both resolved endpoints after canonical topology removal.
| topology.removals.map(({ topology }) => topology) | ||
| ) | ||
| if (!topologyResult.ok) { | ||
| transferReplacementOwnership(newNode, node) |
There was a problem hiding this comment.
SHOULD FIX
The rollback only reverses the ownership transfer. node.onRemoved?.() already ran four lines up and is not undone, so the old node stays in the graph having been told it was removed — DOM widgets unregistered, subgraph listeners aborted (SubgraphNode.onRemoved calls _eventAbortController.abort()), etc. That node is now permanently inert.
Moving updateEndpoints above onRemoved() would make the failure genuinely recoverable, since it validates before it applies. Note the throw also aborts the whole replaceNodesInPlace loop, so one rejected batch kills the remaining replacements too.
There was a problem hiding this comment.
Addressed in 577b079594: endpoint validation and the atomic topology update now happen before onRemoved, so validation failure leaves the original node untouched.
| node.inputs[slot] | ||
| ) | ||
| } | ||
| console.error('Failed to realign input link slots', result.error) |
There was a problem hiding this comment.
SHOULD FIX
updateEndpoints already validates before applying, so there was nothing to roll back here — dropping the fallback is right. But replacing it with break abandons every remaining move for the node, not just the conflicting one, and also skips the remaining passes that exist to catch dynamic inputs.
The updated test shows the cost: movable used to land on slot 3 (destination, what the serialized data says) and now stays on slot 2 (third). That's a link wired to the wrong input after configure/paste — the partial-landing behavior #15581 added.
Suggest dropping the conflicting move from the batch and retrying, rather than bailing on the node.
| ).toEqual([toLinkId(20)]) | ||
| }) | ||
|
|
||
| it('does not mutate graph state when replacement preparation fails', () => { |
There was a problem hiding this comment.
SHOULD FIX
This covers failure before ownership transfer (onRemoved throws). The PR's stated review focus — "ownership rollback when endpoint updates fail" — is the !topologyResult.ok branch, and nothing exercises it. Worth a case that forces updateEndpoints to reject (e.g. a mapping where two old inputs collapse onto one new slot → duplicate-target) and asserts the graph is left intact.
| nodeGraph._nodes[idx] = newNode | ||
| newNode.graph = nodeGraph | ||
| node.graph = null | ||
| node.order = order |
There was a problem hiding this comment.
TRIVIAL
Dead write. node.graph is null on the previous line, so this writes to the wireExecutionOrders WeakMap for a node that's about to be discarded. The store entry is keyed by (scope, nodeId) and newNode.id === node.id, so order carries over on its own — the const order hoist at the top isn't needed either.
| nodeGraph.events.dispatch('node:added', { node: newNode }) | ||
| try { | ||
| nodeGraph.onNodeAdded?.(newNode) | ||
| nodeGraph.events.dispatch('node:added', { node: newNode }) |
There was a problem hiding this comment.
TRIVIAL
One try wraps both calls, so a throwing onNodeAdded also suppresses the node:added dispatch — and that event has real listeners (minimap, telemetry, error-clearing hooks). Separate try blocks, or move the dispatch into a finally.
There was a problem hiding this comment.
Addressed in 577b079594: onNodeAdded and node:added dispatch now run in independent guarded blocks, so one failure cannot suppress the other.
2690f71 to
f4e4dd6
Compare
f4e4dd6 to
bc81ac5
Compare
|
Landed in main via #15924 (squash e7d0d3e). Closing. Full context for agent readersThis PR was part of the 7-PR ECS stack (#15544 #15610 #15654 #15666 #15670 #15783 #15786) merged as a single squash through vehicle PR #15924 (branch refactor/ecs-thermonuclear-cleanup-main = stack tip + main merge + CI fixes), per the stack-merge plan agreed between Christian and DrJKL on 2026-08-25.
|
Summary
Hardens ECS migration boundaries identified by the thermonuclear review while reducing several oversized modules and test files.
Changes
LGraphNodetest responsibilities into focused modules.Review Focus