Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughChangesVue badge ordering
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR only aligns Vue badge display order with the legacy renderer while preserving badge derivation, visibility, and logo treatment; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1997 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.35 MB gzipDetailsSummary
Category Glance App Entry Points — 3.71 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.4 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 124 kBTop-level views, pages, and routed surfaces
Status: 17 added Panels & Settings — 591 kBConfiguration panels, inspectors, and settings screens
Status: 27 added User & Accounts — 27.5 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 125 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 112 kBReusable component library chunks
Status: 15 added Data & Services — 3.5 MBStores, services, APIs, and repositories
Status: 17 added Utilities & Hooks — 549 kBHelpers, composables, and utility bundles
Status: 37 added Vendor & Third-Party — 18.1 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 15.1 MBBundles that do not match a named category
Status: 290 added ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-25T06:15:55.647Z",
"gitSha": "e7fe55fb08bbf045e0c3c550370fce50f4d1ffae",
"branch": "fix/vue-badge-order",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2057.8760000000216,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.292,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.394,
"heapDeltaBytes": -13698676,
"heapUsedBytes": 60655996,
"domNodes": -279,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 10.672999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2084.8799999999983,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.0889999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 522.806,
"heapDeltaBytes": -10718668,
"heapUsedBytes": 63999836,
"domNodes": -285,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 9.316000000000004,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2471.9050000000493,
"styleRecalcs": 77,
"styleRecalcDurationMs": 44.196,
"layouts": 12,
"layoutDurationMs": 3.6139999999999994,
"taskDurationMs": 1530.2520000000002,
"heapDeltaBytes": 4930168,
"heapUsedBytes": 77008180,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 228.29200000000003,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2224.509000000012,
"styleRecalcs": 79,
"styleRecalcDurationMs": 41.975,
"layouts": 12,
"layoutDurationMs": 3.47,
"taskDurationMs": 1327.5600000000002,
"heapDeltaBytes": 3261908,
"heapUsedBytes": 78099960,
"domNodes": -280,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 200.109,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.6480000000306,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.790000000000003,
"layouts": 6,
"layoutDurationMs": 0.6310000000000001,
"taskDurationMs": 404.37,
"heapDeltaBytes": 4420468,
"heapUsedBytes": 78709656,
"domNodes": 74,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 13.808000000000005,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.6610000000164,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.351,
"layouts": 6,
"layoutDurationMs": 0.572,
"taskDurationMs": 367.777,
"heapDeltaBytes": 4351352,
"heapUsedBytes": 79698092,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.897,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 1051.8829999999753,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.1339999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 767.427,
"heapDeltaBytes": 11138556,
"heapUsedBytes": 86324324,
"domNodes": 12,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 163.78,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 1047.8110000000243,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.807000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 763.5110000000001,
"heapDeltaBytes": 11159904,
"heapUsedBytes": 86394332,
"domNodes": 14,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 161.988,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2037.3969999999986,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.1129999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.421,
"heapDeltaBytes": -20707780,
"heapUsedBytes": 78198896,
"domNodes": -278,
"jsHeapTotalBytes": -1961984,
"scriptDurationMs": 38.578,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2042.3680000000104,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.294,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.412,
"heapDeltaBytes": -21151000,
"heapUsedBytes": 77661464,
"domNodes": -273,
"jsHeapTotalBytes": -1961984,
"scriptDurationMs": 37.659,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 4256.203999999969,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.300000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3351.847,
"heapDeltaBytes": 14788320,
"heapUsedBytes": 80969908,
"domNodes": -277,
"jsHeapTotalBytes": 5992448,
"scriptDurationMs": 1323.137,
"eventListeners": -147,
"totalBlockingTimeMs": 16,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 4195.699999999988,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.197,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3297.408,
"heapDeltaBytes": 13613464,
"heapUsedBytes": 80434248,
"domNodes": 0,
"jsHeapTotalBytes": 4943872,
"scriptDurationMs": 1295.978,
"eventListeners": 12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 5140.471999999989,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.213000000000001,
"layouts": 60,
"layoutDurationMs": 8.074000000000002,
"taskDurationMs": 3095.152,
"heapDeltaBytes": 4230684,
"heapUsedBytes": 76299740,
"domNodes": 24,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 1144.1830000000002,
"eventListeners": 12,
"totalBlockingTimeMs": 21,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 4843.441999999982,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.982,
"layouts": 60,
"layoutDurationMs": 7.096,
"taskDurationMs": 2837.943,
"heapDeltaBytes": 4554852,
"heapUsedBytes": 76195560,
"domNodes": 24,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 1114.046,
"eventListeners": 12,
"totalBlockingTimeMs": 9,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 6184.050999999954,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.809999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4827.807,
"heapDeltaBytes": 24676124,
"heapUsedBytes": 93537616,
"domNodes": 0,
"jsHeapTotalBytes": 4874240,
"scriptDurationMs": 1358.568,
"eventListeners": 196,
"totalBlockingTimeMs": 553,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 6159.60199999995,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.070000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4722.681,
"heapDeltaBytes": 22737720,
"heapUsedBytes": 92817816,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 1337.8890000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 448,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.3580000000206,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 572.384,
"heapDeltaBytes": -23513916,
"heapUsedBytes": 78079328,
"domNodes": -279,
"jsHeapTotalBytes": -1699840,
"scriptDurationMs": 39.09599999999999,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2050.972999999999,
"styleRecalcs": 1,
"styleRecalcDurationMs": 1.197,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.8250000000002,
"heapDeltaBytes": -22814104,
"heapUsedBytes": 78456932,
"domNodes": -275,
"jsHeapTotalBytes": -1961984,
"scriptDurationMs": 40.076,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 791.2660000000074,
"styleRecalcs": 45,
"styleRecalcDurationMs": 10.789999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.201,
"heapDeltaBytes": -6485784,
"heapUsedBytes": 69297060,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 151.945,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 746.3030000000117,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.712,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 529.2439999999999,
"heapDeltaBytes": -6908252,
"heapUsedBytes": 69151260,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 147.934,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2004.6469999999772,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.018,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.37399999999997,
"heapDeltaBytes": -14366200,
"heapUsedBytes": 61824912,
"domNodes": -298,
"jsHeapTotalBytes": 3768320,
"scriptDurationMs": 8.170999999999998,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.7150000000247,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.312,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 505.05,
"heapDeltaBytes": -7262416,
"heapUsedBytes": 68734104,
"domNodes": -294,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 8.857999999999999,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1941.0579999999982,
"styleRecalcs": 80,
"styleRecalcDurationMs": 41.417,
"layouts": 16,
"layoutDurationMs": 4.096,
"taskDurationMs": 1174.371,
"heapDeltaBytes": -2881152,
"heapUsedBytes": 73162428,
"domNodes": -297,
"jsHeapTotalBytes": 5079040,
"scriptDurationMs": 134.119,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1907.2039999999788,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.804,
"layouts": 16,
"layoutDurationMs": 4.569,
"taskDurationMs": 1175.28,
"heapDeltaBytes": -2926884,
"heapUsedBytes": 73266240,
"domNodes": -297,
"jsHeapTotalBytes": 5865472,
"scriptDurationMs": 134.856,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.3789999999826,
"styleRecalcs": 20,
"styleRecalcDurationMs": 32.037,
"layouts": 15,
"layoutDurationMs": 14.417,
"taskDurationMs": 952.3939999999998,
"heapDeltaBytes": 21799496,
"heapUsedBytes": 104228356,
"domNodes": 13671,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 32.882999999999996,
"eventListeners": 2383,
"totalBlockingTimeMs": 148,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 16083.805999999982,
"styleRecalcs": 243,
"styleRecalcDurationMs": 36.26,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12140.746,
"heapDeltaBytes": -26558588,
"heapUsedBytes": 72224468,
"domNodes": -276,
"jsHeapTotalBytes": 3543040,
"scriptDurationMs": 4537,
"eventListeners": -119,
"totalBlockingTimeMs": 7,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 15395.074000000022,
"styleRecalcs": 244,
"styleRecalcDurationMs": 33.118,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11585.916000000001,
"heapDeltaBytes": -24807132,
"heapUsedBytes": 74208020,
"domNodes": -273,
"jsHeapTotalBytes": 4067328,
"scriptDurationMs": 4437.038,
"eventListeners": -121,
"totalBlockingTimeMs": 2,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18210.031000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17324.959,
"heapDeltaBytes": -39259708,
"heapUsedBytes": 175575140,
"domNodes": -6548,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 388.19000000000005,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18100.02099999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17296.103000000003,
"heapDeltaBytes": -45369512,
"heapUsedBytes": 176920964,
"domNodes": -6548,
"jsHeapTotalBytes": -921600,
"scriptDurationMs": 364.87800000000004,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22118.813999999988,
"styleRecalcs": 174,
"styleRecalcDurationMs": 19.97099999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21778.996,
"heapDeltaBytes": -41647104,
"heapUsedBytes": 171544260,
"domNodes": -6548,
"jsHeapTotalBytes": -5881856,
"scriptDurationMs": 1077.326,
"eventListeners": -7469,
"totalBlockingTimeMs": 217,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21223.398999999972,
"styleRecalcs": 168,
"styleRecalcDurationMs": 17.990000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20853.041999999998,
"heapDeltaBytes": -32591132,
"heapUsedBytes": 177210504,
"domNodes": -6548,
"jsHeapTotalBytes": -299008,
"scriptDurationMs": 1058.4520000000002,
"eventListeners": -7469,
"totalBlockingTimeMs": 72,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 461.8409999999358,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.424000000000003,
"layouts": 2,
"layoutDurationMs": 0.4609999999999999,
"taskDurationMs": 137.70000000000002,
"heapDeltaBytes": 5909360,
"heapUsedBytes": 77324816,
"domNodes": 126,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 8.695,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 185.33400000001166,
"styleRecalcs": 11,
"styleRecalcDurationMs": 19.144000000000002,
"layouts": 2,
"layoutDurationMs": 0.5950000000000001,
"taskDurationMs": 109.18500000000002,
"heapDeltaBytes": 3837524,
"heapUsedBytes": 74582760,
"domNodes": 112,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.252,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## fix/legacy-link-restoration #15670 +/- ##
===============================================================
+ Coverage 82.51% 82.55% +0.04%
===============================================================
Files 1931 1931
Lines 110186 110198 +12
Branches 30193 30201 +8
===============================================================
+ Hits 90919 90978 +59
+ Misses 18940 18883 -57
- Partials 327 337 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 🚀 New features to boost your workflow:
|
168b12b to
0f8f2d5
Compare
0f8f2d5 to
6ed3689
Compare
6ed3689 to
9e85d1d
Compare
9e85d1d to
5c4cd91
Compare
This comment has been minimized.
This comment has been minimized.
5c4cd91 to
dc52b84
Compare
dc52b84 to
34cde5f
Compare
34cde5f to
1e35655
Compare
1e35655 to
a0aa2db
Compare
benjcooley
left a comment
There was a problem hiding this comment.
Revised severity table after a re-check — I graded the parity-test finding too harshly.
| Severity | Count |
|---|---|
| BLOCKER | 0 |
| SHOULD FIX | 3 |
| TRIVIAL | 0 |
The test-helper issue is real but not blocking (details in the thread). Nothing in this PR breaks at runtime; the ordering fix itself is correct. Treat the three items as cleanup rather than gating.
benjcooley
left a comment
There was a problem hiding this comment.
The Comfy badge move resolves my main finding. Verified on 8b4fabec:
NodeBadges.vuenow orders core (17) → logo (33) → extension (40). That matches legacydrawBadges, which emits[core joined text with 🦊 last, credits]thennode.badges. The parity helper's#1 BETA 🦊is now the order the app actually renders, so the promoted test is honest.NodeBadges.test.tspins it at the DOM level rather than trusting the template — good call.@testing-library/vueanddata-testidboth match repo convention.- CI is fully green,
testincluded.
Two items from the original review are still open, both non-blocking:
CORE_JOIN_ORDER's doc ("Legacy canvas joins the core parts into a single badge in this order") and thebadgeData.ts"each renderer applies its own ordering" rationale are still stale now that Vue uses the same constant.computeBadgesstill emitslifecycle, id, sourcewhile both renderers re-sort toid, lifecycle, sourcevia their own Map. Emitting inCORE_JOIN_ORDERat the source would delete both.
Minor: the new test asserts the logo comes after core but not that it comes before extension — the "logo last" regression would still pass. One extra compareDocumentPosition against an extension badge would close that.
Approving; the above is cleanup at your discretion.
8b4fabe to
a588dce
Compare
a588dce to
fbd78de
Compare
benjcooley
left a comment
There was a problem hiding this comment.
Re-approving — my earlier approval was auto-dismissed by the rebase force-push, not by anything in the code.
Verified on fbd78dec: the badge code is byte-identical to 8b4fabec, which I already reviewed. Core → logo → extension ordering is intact, and the unit test job passes.
The two cleanup items from before are still open and still non-blocking: the stale CORE_JOIN_ORDER doc, and the duplicated reorder that computeBadges could do once at the source.
|
Landed in main via #15924 (squash e7d0d3e). Closing. Full context for agent readersThis PR was part of the 7-PR ECS stack (#15544 #15610 #15654 #15666 #15670 #15783 #15786) merged as a single squash through vehicle PR #15924 (branch refactor/ecs-thermonuclear-cleanup-main = stack tip + main merge + CI fixes), per the stack-merge plan agreed between Christian and DrJKL on 2026-08-25.
|
Summary
Aligns Vue node badge chip ordering with the legacy canvas renderer.
Changes
Review Focus
Please focus on keeping ordering renderer-local while preserving the existing separate Comfy logo treatment for core nodes.
Red-Green Verification
333404f143makes the ordering expectations fail.eab101efa8applies the Vue projection fix.