Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1997 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.35 MB gzipDetailsSummary
Category Glance App Entry Points — 3.71 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.4 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 124 kBTop-level views, pages, and routed surfaces
Status: 17 added Panels & Settings — 591 kBConfiguration panels, inspectors, and settings screens
Status: 27 added User & Accounts — 27.5 kBAuthentication, profile, and account management bundles
Status: 11 added Editors & Dialogs — 125 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 112 kBReusable component library chunks
Status: 15 added Data & Services — 3.5 MBStores, services, APIs, and repositories
Status: 17 added Utilities & Hooks — 549 kBHelpers, composables, and utility bundles
Status: 37 added Vendor & Third-Party — 18.1 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 15.1 MBBundles that do not match a named category
Status: 290 added ⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-08-25T06:02:01.106Z",
"gitSha": "352853ebd4ce05b1538e0bdfcce81affb5108304",
"branch": "fix/ecs-valid-review-findings",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2025.3889999999615,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.195,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.7679999999999,
"heapDeltaBytes": -2733996,
"heapUsedBytes": 72235344,
"domNodes": -279,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 8.792000000000002,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2021.833000000015,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.424999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.086,
"heapDeltaBytes": -715096,
"heapUsedBytes": 73588852,
"domNodes": -279,
"jsHeapTotalBytes": 3506176,
"scriptDurationMs": 8.95,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2498.1050000000096,
"styleRecalcs": 80,
"styleRecalcDurationMs": 48.014,
"layouts": 12,
"layoutDurationMs": 3.9330000000000007,
"taskDurationMs": 1495.3419999999999,
"heapDeltaBytes": -16810208,
"heapUsedBytes": 57943592,
"domNodes": -278,
"jsHeapTotalBytes": 6389760,
"scriptDurationMs": 238.5,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2244.5820000000367,
"styleRecalcs": 79,
"styleRecalcDurationMs": 43.19100000000001,
"layouts": 12,
"layoutDurationMs": 3.523,
"taskDurationMs": 1346.2830000000001,
"heapDeltaBytes": -5996632,
"heapUsedBytes": 69266224,
"domNodes": -279,
"jsHeapTotalBytes": 4292608,
"scriptDurationMs": 198.715,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1742.3799999999687,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.939000000000004,
"layouts": 6,
"layoutDurationMs": 0.5429999999999999,
"taskDurationMs": 394.495,
"heapDeltaBytes": 4507024,
"heapUsedBytes": 79720084,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.091999999999999,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.988000000024,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.481000000000005,
"layouts": 6,
"layoutDurationMs": 0.714,
"taskDurationMs": 367.43299999999994,
"heapDeltaBytes": 4376524,
"heapUsedBytes": 79741420,
"domNodes": 76,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.882,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 1016.601000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.187,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 756.601,
"heapDeltaBytes": 9536916,
"heapUsedBytes": 82545132,
"domNodes": 12,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 160.636,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 1033.3750000000919,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.439999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 772.182,
"heapDeltaBytes": 11143312,
"heapUsedBytes": 86277744,
"domNodes": 14,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 163.488,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2031.0739999999896,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.1989999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.118,
"heapDeltaBytes": -20471320,
"heapUsedBytes": 78209908,
"domNodes": -272,
"jsHeapTotalBytes": -3010560,
"scriptDurationMs": 36.874,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2045.8209999999326,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.8209999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.1479999999999,
"heapDeltaBytes": -20446496,
"heapUsedBytes": 78222432,
"domNodes": -274,
"jsHeapTotalBytes": -1961984,
"scriptDurationMs": 38.742,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 4183.325000000024,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.101,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3291.7049999999995,
"heapDeltaBytes": 13573700,
"heapUsedBytes": 80005716,
"domNodes": 0,
"jsHeapTotalBytes": 4943872,
"scriptDurationMs": 1283.9649999999997,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 4242.837999999892,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.898,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3349.4290000000005,
"heapDeltaBytes": -30179328,
"heapUsedBytes": 69168944,
"domNodes": -274,
"jsHeapTotalBytes": 3543040,
"scriptDurationMs": 1296.068,
"eventListeners": -149,
"totalBlockingTimeMs": 11,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 5020.3370000000405,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.646,
"layouts": 60,
"layoutDurationMs": 7.651,
"taskDurationMs": 3020.403,
"heapDeltaBytes": 3794460,
"heapUsedBytes": 75918232,
"domNodes": 24,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 1126.733,
"eventListeners": 12,
"totalBlockingTimeMs": 16,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 5050.16599999999,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.684000000000003,
"layouts": 60,
"layoutDurationMs": 7.686000000000001,
"taskDurationMs": 3013.8739999999993,
"heapDeltaBytes": 12823508,
"heapUsedBytes": 84706760,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 1107.319,
"eventListeners": 14,
"totalBlockingTimeMs": 11,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 6174.255999999958,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.896000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4793.849000000001,
"heapDeltaBytes": 23733844,
"heapUsedBytes": 93257668,
"domNodes": 0,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 1374.6970000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 510,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 6129.034000000047,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.558,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4713.672,
"heapDeltaBytes": 23170164,
"heapUsedBytes": 92846736,
"domNodes": 0,
"jsHeapTotalBytes": 5922816,
"scriptDurationMs": 1337.61,
"eventListeners": 196,
"totalBlockingTimeMs": 464,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2019.502999999986,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.9050000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.4819999999999,
"heapDeltaBytes": 13103712,
"heapUsedBytes": 79183272,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 42.25100000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2011.1560000000281,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.394,
"heapDeltaBytes": 12794180,
"heapUsedBytes": 79265216,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 42.21799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 733.9999999999804,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.152000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.385,
"heapDeltaBytes": -6920404,
"heapUsedBytes": 69162432,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 145.03199999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 744.0500000000156,
"styleRecalcs": 45,
"styleRecalcDurationMs": 9.607,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.0670000000001,
"heapDeltaBytes": -6281372,
"heapUsedBytes": 69088492,
"domNodes": 16,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 146.55499999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2022.625000000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.758999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.219,
"heapDeltaBytes": 1410776,
"heapUsedBytes": 77641680,
"domNodes": -294,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 8.287,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.7459999999464,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.107000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.73999999999995,
"heapDeltaBytes": 4062540,
"heapUsedBytes": 80325272,
"domNodes": -298,
"jsHeapTotalBytes": 4030464,
"scriptDurationMs": 8.087999999999997,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1906.0690000000022,
"styleRecalcs": 77,
"styleRecalcDurationMs": 39.044999999999995,
"layouts": 16,
"layoutDurationMs": 4.087000000000001,
"taskDurationMs": 1175.886,
"heapDeltaBytes": -3219916,
"heapUsedBytes": 72504408,
"domNodes": -297,
"jsHeapTotalBytes": 5603328,
"scriptDurationMs": 135.002,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1874.6170000000575,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.733,
"layouts": 16,
"layoutDurationMs": 4.718999999999999,
"taskDurationMs": 1153.991,
"heapDeltaBytes": -2811028,
"heapUsedBytes": 73264708,
"domNodes": -296,
"jsHeapTotalBytes": 6127616,
"scriptDurationMs": 132.08,
"eventListeners": -199,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.2890000000434,
"styleRecalcs": 20,
"styleRecalcDurationMs": 32.148999999999994,
"layouts": 15,
"layoutDurationMs": 14.610000000000001,
"taskDurationMs": 938.0070000000001,
"heapDeltaBytes": 66396,
"heapUsedBytes": 96740308,
"domNodes": 13671,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 33.456,
"eventListeners": 2383,
"totalBlockingTimeMs": 141,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 15602.641000000005,
"styleRecalcs": 243,
"styleRecalcDurationMs": 33.048,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11822.989,
"heapDeltaBytes": -25302284,
"heapUsedBytes": 74007092,
"domNodes": -275,
"jsHeapTotalBytes": 3805184,
"scriptDurationMs": 4495.811000000001,
"eventListeners": -119,
"totalBlockingTimeMs": 8,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 15588.060000000041,
"styleRecalcs": 243,
"styleRecalcDurationMs": 33.429,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11770.869,
"heapDeltaBytes": -25168132,
"heapUsedBytes": 74019432,
"domNodes": -276,
"jsHeapTotalBytes": 3805184,
"scriptDurationMs": 4425.138000000001,
"eventListeners": -119,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17895.681000000026,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16993.833000000002,
"heapDeltaBytes": -37623540,
"heapUsedBytes": 175754104,
"domNodes": -6548,
"jsHeapTotalBytes": -5619712,
"scriptDurationMs": 437.095,
"eventListeners": -7471,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17807.690999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17053.783000000003,
"heapDeltaBytes": -26129392,
"heapUsedBytes": 186817720,
"domNodes": -6548,
"jsHeapTotalBytes": -2998272,
"scriptDurationMs": 342.71899999999994,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21366.35700000005,
"styleRecalcs": 177,
"styleRecalcDurationMs": 18.413999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20943.821,
"heapDeltaBytes": -35527556,
"heapUsedBytes": 177457888,
"domNodes": -6548,
"jsHeapTotalBytes": -6930432,
"scriptDurationMs": 1012.609,
"eventListeners": -7467,
"totalBlockingTimeMs": 25,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21379.17300000004,
"styleRecalcs": 171,
"styleRecalcDurationMs": 17.752999999999965,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21041.432999999997,
"heapDeltaBytes": -18195052,
"heapUsedBytes": 191050644,
"domNodes": -6549,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 1004.2440000000001,
"eventListeners": -7471,
"totalBlockingTimeMs": 80,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 173.6999999999398,
"styleRecalcs": 11,
"styleRecalcDurationMs": 22.186999999999998,
"layouts": 8,
"layoutDurationMs": 2.2889999999999997,
"taskDurationMs": 121.919,
"heapDeltaBytes": 3776680,
"heapUsedBytes": 73136168,
"domNodes": 133,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.713999999999999,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 141.36099999996077,
"styleRecalcs": 10,
"styleRecalcDurationMs": 18.912,
"layouts": 2,
"layoutDurationMs": 0.639,
"taskDurationMs": 107.97200000000001,
"heapDeltaBytes": 3813228,
"heapUsedBytes": 75231456,
"domNodes": 111,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.635,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
}
]
} |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## fix/vue-badge-order #15783 +/- ##
====================================================
Coverage 82.55% 82.56%
====================================================
Files 1931 1931
Lines 110198 110259 +61
Branches 30201 30225 +24
====================================================
+ Hits 90978 91036 +58
- Misses 18883 18886 +3
Partials 337 337
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ab79eb8 to
9107eb7
Compare
This comment has been minimized.
This comment has been minimized.
0163ebd to
12d35cc
Compare
benjcooley
left a comment
There was a problem hiding this comment.
Review
| Severity | Count |
|---|---|
| BLOCKER | 1 |
| SHOULD FIX | 3 |
| TRIVIAL | 2 |
Blocker
The new unmapped-link sweep in replaceWithMapping keys off mapping presence, not off which side was actually considered. input_mapping and output_mapping are independently nullable, so a replacement that only remaps inputs (output_mapping: null) now deletes every downstream connection of the replaced node. Those links previously survived because the new node reuses the old id and slot indices. No test covers input-mapping-only with an output link attached, which is why CI is green.
Notes on the rest
The result-type change (replaceNodeInputs returning a discriminated result instead of []) is a clear improvement — the old if (this.inputs.includes(slotInfo)) return in removeInput was inferring failure from a side effect. Reordering replaceNodeInputs before reorderInPlace in reorderSubgraphInputs is correct; the rejected path now leaves both input orders untouched.
The same-id layout ownership fix is sound for the case it targets. The parseNodeId / toGroupId changes in mappers.ts are strictly better than the casts they replace.
One thing not flagged inline: LGraphNode.test.ts drops the defaults to a normal title case entirely. The replacement only covers NO_TITLE, so default-title behavior is now uncovered. If _state.titleMode is gone, the same assertion can be made through nodeDataStore.
| transferredLinkIds.add(link.id) | ||
| } | ||
| } | ||
| for (const link of [...nodeGraph.links.values()]) { |
There was a problem hiding this comment.
BLOCKER — this deletes every output link when output_mapping is null (and every input link when input_mapping is null).
NodeReplacement.input_mapping and output_mapping are independently nullable, and hasMapping is input_mapping != null || output_mapping != null — so a backend replacement that only renames an input (input_mapping: [...], output_mapping: null) skips generateDefaultMapping, leaves transferredLinkIds empty on the output side, and this loop drops all of the node's downstream connections. Before this PR those links survived, because newNode.id === node.id and the slot indices were unchanged.
Existing coverage misses it: should transfer input connections using input_mapping uses output_mapping: null but the placeholder has no output links.
Suggest only sweeping the side that actually has a mapping (or falling back to identity for the missing side), e.g. skip output links entirely when replacement.output_mapping == null, and likewise for inputs.
There was a problem hiding this comment.
Re-verified this after the rebase; it holds. Concrete repro, building on the existing should transfer input connections using input_mapping test — give that placeholder an output link (createMockLink(30, 1, 0, 5, 0) plus an outputs: [{ name: 'CONTROL_NET', links: [30] }] entry) and keep the same replacement payload:
hasMappingis true (input_mapping != null), sogenerateDefaultMappingnever runstransferredLinkIdsgets link 10 from the input pass; the output pass iteratesoutput_mapping ?? []and adds nothing- the sweep sees
link.origin_id === node.idfor link 30 and callsremoveLink(30)
Pre-PR that link was untouched and still resolved to the new node, since newNode.id = node.id and the output slot was unchanged. Worth noting replaceWithMapping never calls nodeGraph.remove(node) — it splices _nodes[idx] directly — so none of the unregisterAllLinkTopologies / detachNodeFromStores teardown paths run, and clearNodeOwnedStoreState only touches widget values and preview exposures. Nothing else was cleaning these up.
One fairness note: the whole operation is wrapped in changeTracker.beforeChange() / afterChange(), so the user can undo it. It is silently-wrong-result rather than unrecoverable — but still worth fixing before merge, since the user gets no signal that connections were dropped.
There was a problem hiding this comment.
Addressed in 577b079594: an unspecified mapping side now preserves its existing links, with regressions for both input-only and output-only mappings.
| ) | ||
| throw new Error(`Cannot replace node ${node.id}: ownership is invalid`) | ||
|
|
||
| const transferredLinkIds = new Set<LinkId>() |
There was a problem hiding this comment.
SHOULD FIX — this runs before the second ownership check. If node.onRemoved?.() mutates the graph, or transferReplacementOwnership returns false, line 216 throws ownership changed during removal, replaceNodesInPlace catches it and toasts an error — but the links are already gone and the node was never replaced. Move the sweep to after the ownership transfer succeeds.
Also: it scans all of nodeGraph.links per replaced node, so replacing N placeholders in a large graph is O(N x links). The node's own links are already reachable via inputLinkId / outputLinkIds.
| if (!newSpec) { | ||
| commitMutatedInputs(node, previous, inputLinks) | ||
| const result = commitMutatedInputs(node, previous, inputLinks) | ||
| if (!result.ok) return |
There was a problem hiding this comment.
SHOULD FIX — the rollback is partial. Lines 130-134 already removed the group widgets and called deleteWidget(widget.widgetId). commitMutatedInputs restores node.inputs, but returning here skips syncNodeWidgetOrder(node), so widgetValueStore's node widget order keeps ids for widgets that no longer exist.
Same shape at line 185 and in addAutogrowGroup (line 466), where the newly-created widgets stay on the node after the inputs are rolled back. Either sync the widget order on the failure path or restore the widgets too.
| :widget="widget.simplified" | ||
| :node-id | ||
| :node-type | ||
| :aria-invalid="widget.hasError || undefined" |
There was a problem hiding this comment.
SHOULD FIX — this is a fallthrough attr on a dynamic component, so it lands on the widget's root element, not the control. WidgetInputText's root is <WidgetLayoutField>, so aria-invalid ends up on the layout wrapper and screen readers never see the <InputText> as invalid. Components with inheritAttrs: false or multiple roots drop it entirely.
The updated test in NodeWidgets.test.ts asserts against .widget-stub, so it passes regardless. Consider passing hasError down as a prop and letting each widget put aria-invalid on its input element.
| owners.set(node.id, new WeakRef(node)) | ||
| } | ||
|
|
||
| function deleteNodeAttachmentOwner(graphId: UUID, node: LGraphNode): boolean { |
There was a problem hiding this comment.
TRIVIAL — nodeAttachmentOwners is a strong Map and only shrinks through detachNodeLayout / detachGraphLayouts. Any node dropped without going through those paths leaves a dead WeakRef entry (and its per-graph inner Map) behind for the life of the session. The owners.size === 0 cleanup only fires if every node in the graph detaches cleanly. Worth pruning dead refs opportunistically, or keying ownership off something already collectable.
| /** Installs {@link nodeBadges} as the legacy canvas's badge row source. */ | ||
| export function installNodeBadges(): void { | ||
| registerBadgeRowsProvider(nodeBadges) | ||
| export function installNodeBadges(): () => void { |
There was a problem hiding this comment.
TRIVIAL — nothing calls this disposer. useNodeBadge.ts:49 does installNodeBadges() and drops the return value, so the symbol/registration bookkeeping in nodeBadgeDraw.ts only exercises in tests. Either wire it into the extension's teardown or drop the disposal machinery.
12d35cc to
61ccb67
Compare
61ccb67 to
2d1ae5f
Compare
2d1ae5f to
e316715
Compare
e316715 to
c024528
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Two replacement failures remain.
Full context for agent readers
At this exact head, one-sided mappings still delete links from the untouched side, and destructive cleanup still runs before replacement ownership is secured. The patch is stable-patch-identical to the previously reviewed implementation, and both failures were re-verified against the current stacked base.
| transferredLinkIds.add(link.id) | ||
| } | ||
| } | ||
| for (const link of [...nodeGraph.links.values()]) { |
There was a problem hiding this comment.
issue: replacement can delete links it must preserve.
Full context for agent readers
If input_mapping is present while output_mapping is null, default mapping is suppressed, no output link enters transferredLinkIds, and this sweep removes every downstream link even though node identity and output slots are unchanged. The symmetric input-side case also applies. In addition, this cleanup occurs before onRemoved and transferReplacementOwnership; if ownership changes, replacement aborts after the original node's links have already been removed. Please preserve the unspecified side and defer destructive cleanup until ownership transfer cannot fail, with asymmetric-mapping and transfer-failure regressions that keep existing links attached.
There was a problem hiding this comment.
Addressed in 577b079594: unspecified-side links are preserved, and endpoint compatibility is preflighted before ownership or lifecycle mutation.
|
Landed in main via #15924 (squash e7d0d3e). Closing. Full context for agent readersThis PR was part of the 7-PR ECS stack (#15544 #15610 #15654 #15666 #15670 #15783 #15786) merged as a single squash through vehicle PR #15924 (branch refactor/ecs-thermonuclear-cleanup-main = stack tip + main merge + CI fixes), per the stack-merge plan agreed between Christian and DrJKL on 2026-08-25.
|
Summary
Addresses the remaining valid review findings from #14246 as a child of #15670.
Changes
Review Focus
Please focus on rejected endpoint-update behavior, same-ID layout attachment ownership, and replacement-link cleanup.