Skip to content

fix: preserve LLink spread topology - #15778

Closed
christian-byrne wants to merge 2 commits into
Comfy-Org:feature/ecs-migrationfrom
christian-byrne:cb__llink-spread-compat
Closed

christian-byrne wants to merge 2 commits into
Comfy-Org:feature/ecs-migrationfrom
christian-byrne:cb__llink-spread-compat

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Summary

Preserve legacy LLink spread-copy topology while keeping ECS store state authoritative.

Changes

  • What: Defines own-enumerable forwarding descriptors for the seven legacy topology properties (id, type, origin_id, origin_slot, target_id, target_slot, and parentId) and promotes the existing regression coverage.

Review Focus

The instance descriptors reuse the prototype accessors rather than storing duplicate topology values, so reads and writes continue to delegate to the link store.

The separate Custom-Scripts node insertion issue tracked by #15617 is outside this PR.

Fixes #15594

@christian-byrne christian-byrne self-assigned this Aug 24, 2026
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 24, 2026
@coderabbitai

coderabbitai Bot commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e2f89573-250d-47ae-9b33-e3ae1f9ff40b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 24, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: 🚧 Building...

🎭 Playwright: ✅ 1989 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1968 / ❌ 0 / ⚠️ 2 / ⏭️ 5)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.0 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.7 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.7 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 19ms TBT · 78.4 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.6 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 128ms TBT · 89.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 16ms TBT · 69.1 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.6 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 128ms TBT · 163.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 531ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 66.0 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -155
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 39ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 1219ms
canvas-mouse-sweep: script duration 162ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 63.7 MB
canvas-mouse-sweep: DOM nodes -283
canvas-mouse-sweep: event listeners -171
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 21ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 374ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 69.3 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 429ms
dom-widget-clipping: script duration 33ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 59.4 MB
dom-widget-clipping: DOM nodes 15
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 579ms
large-graph-idle: script duration 41ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 74.7 MB
large-graph-idle: DOM nodes -281
large-graph-idle: event listeners -184
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 2708ms
large-graph-pan: script duration 993ms
large-graph-pan: TBT 19ms
large-graph-pan: heap used 78.4 MB
large-graph-pan: DOM nodes -283
large-graph-pan: event listeners -181
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 7ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 66
large-graph-zoom: task duration 2637ms
large-graph-zoom: script duration 916ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 67.6 MB
large-graph-zoom: DOM nodes -106
large-graph-zoom: event listeners -69
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 2147ms
legacy-node-drag: script duration 209ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 66.9 MB
legacy-node-drag: DOM nodes -286
legacy-node-drag: event listeners 29
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 538ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 68.5 MB
minimap-idle: DOM nodes -138
minimap-idle: event listeners -90
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 508ms
subgraph-dom-widget-clipping: script duration 136ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.4 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 8
subgraph-idle: task duration 481ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.0 MB
subgraph-idle: DOM nodes -300
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 38ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 1106ms
subgraph-mouse-sweep: script duration 118ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 68.4 MB
subgraph-mouse-sweep: DOM nodes -295
subgraph-mouse-sweep: event listeners -217
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 14ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 14
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 937ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 128ms
subgraph-transition-enter: heap used 89.9 MB
subgraph-transition-enter: DOM nodes 13671
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 39ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 9608ms
viewport-pan-sweep: script duration 3350ms
viewport-pan-sweep: TBT 16ms
viewport-pan-sweep: heap used 69.1 MB
viewport-pan-sweep: DOM nodes -277
viewport-pan-sweep: event listeners -143
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16812ms
vue-large-graph-idle: script duration 335ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.6 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7473
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 176
vue-large-graph-pan: task duration 20781ms
vue-large-graph-pan: script duration 963ms
vue-large-graph-pan: TBT 128ms
vue-large-graph-pan: heap used 163.6 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7470
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 5
workflow-execution: style recalc count 9
workflow-execution: task duration 107ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 66.6 MB
workflow-execution: DOM nodes 122
workflow-execution: event listeners 37
Raw data
{
  "timestamp": "2026-08-24T08:55:06.520Z",
  "gitSha": "ee6f66f22bb31660f6c0e9c3b6c10d0419438160",
  "branch": "cb__llink-spread-compat",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2049.3670000000748,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.784000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 556.7679999999999,
      "heapDeltaBytes": 11581132,
      "heapUsedBytes": 80946260,
      "domNodes": -280,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 9.521,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-idle",
      "durationMs": 2054.5130000000427,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.223999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 504.237,
      "heapDeltaBytes": -11532392,
      "heapUsedBytes": 57520148,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.490000000000002,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2212.2220000001107,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 39.783,
      "layouts": 12,
      "layoutDurationMs": 3.477,
      "taskDurationMs": 1222.95,
      "heapDeltaBytes": 3682460,
      "heapUsedBytes": 72751920,
      "domNodes": -282,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 160.17000000000002,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2220.8650000000034,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 38.118,
      "layouts": 12,
      "layoutDurationMs": 3.214,
      "taskDurationMs": 1214.9019999999998,
      "heapDeltaBytes": -1382404,
      "heapUsedBytes": 60928916,
      "domNodes": -284,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 163.263,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1753.834999999981,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 17.026,
      "layouts": 6,
      "layoutDurationMs": 0.617,
      "taskDurationMs": 374.44500000000005,
      "heapDeltaBytes": 3621252,
      "heapUsedBytes": 72685676,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 12.23,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.724000000071,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 25.447999999999997,
      "layouts": 6,
      "layoutDurationMs": 0.8160000000000001,
      "taskDurationMs": 372.71199999999993,
      "heapDeltaBytes": 3703068,
      "heapUsedBytes": 72744600,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.831999999999999,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 734.8039999999401,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.167000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 431.077,
      "heapDeltaBytes": -6751068,
      "heapUsedBytes": 61991812,
      "domNodes": 14,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 32.300000000000004,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 723.2630000000881,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.3180000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 427.11199999999997,
      "heapDeltaBytes": -6991312,
      "heapUsedBytes": 62579700,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 32.835,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2053.914999999961,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.869999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 580.109,
      "heapDeltaBytes": -22025536,
      "heapUsedBytes": 68886876,
      "domNodes": -279,
      "jsHeapTotalBytes": 4190208,
      "scriptDurationMs": 43.05799999999999,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2039.3229999999676,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.642,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 578.8629999999999,
      "heapDeltaBytes": 4129768,
      "heapUsedBytes": 87826940,
      "domNodes": -282,
      "jsHeapTotalBytes": 3366912,
      "scriptDurationMs": 37.974,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3319.6069999999054,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.933000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2694.2839999999997,
      "heapDeltaBytes": -25202020,
      "heapUsedBytes": 66474012,
      "domNodes": -283,
      "jsHeapTotalBytes": 4452352,
      "scriptDurationMs": 987.379,
      "eventListeners": -181,
      "totalBlockingTimeMs": 23,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3386.2199999998666,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.218,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2722.431,
      "heapDeltaBytes": 7364636,
      "heapUsedBytes": 97962732,
      "domNodes": -283,
      "jsHeapTotalBytes": 5201920,
      "scriptDurationMs": 998.9300000000001,
      "eventListeners": -181,
      "totalBlockingTimeMs": 15,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4402.44000000007,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.081000000000001,
      "layouts": 60,
      "layoutDurationMs": 7.294,
      "taskDurationMs": 2579.786,
      "heapDeltaBytes": 8146096,
      "heapUsedBytes": 73742272,
      "domNodes": 24,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 900.531,
      "eventListeners": 12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4521.572000000106,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.437,
      "layouts": 60,
      "layoutDurationMs": 7.425999999999999,
      "taskDurationMs": 2694.507,
      "heapDeltaBytes": -4566740,
      "heapUsedBytes": 68003820,
      "domNodes": -235,
      "jsHeapTotalBytes": -1351680,
      "scriptDurationMs": 931.053,
      "eventListeners": -149,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3176.287000000002,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.152,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2148.2089999999994,
      "heapDeltaBytes": -2327008,
      "heapUsedBytes": 70317112,
      "domNodes": -285,
      "jsHeapTotalBytes": -303104,
      "scriptDurationMs": 213.67999999999998,
      "eventListeners": 29,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3221.9129999998586,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.309999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2146.12,
      "heapDeltaBytes": -2629636,
      "heapUsedBytes": 69983412,
      "domNodes": -286,
      "jsHeapTotalBytes": -1089536,
      "scriptDurationMs": 203.71599999999998,
      "eventListeners": 29,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "minimap-idle",
      "durationMs": 1992.6339999999527,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 507.966,
      "heapDeltaBytes": 9089948,
      "heapUsedBytes": 73820104,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 36.401999999999994,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2045.569000000114,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.264000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 569.0169999999999,
      "heapDeltaBytes": -22498924,
      "heapUsedBytes": 69873088,
      "domNodes": -276,
      "jsHeapTotalBytes": 4452352,
      "scriptDurationMs": 37.683,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 727.2969999999077,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.386999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 501.347,
      "heapDeltaBytes": 17490204,
      "heapUsedBytes": 87475260,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 135.804,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 742.3909999999978,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.319,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 514.946,
      "heapDeltaBytes": 17775616,
      "heapUsedBytes": 87514500,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 137.18000000000004,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.2319999998035,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.288000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.25299999999993,
      "heapDeltaBytes": 575876,
      "heapUsedBytes": 70474164,
      "domNodes": -302,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.527000000000001,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.9089999999742,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.144000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.28000000000003,
      "heapDeltaBytes": -7983924,
      "heapUsedBytes": 61727992,
      "domNodes": -298,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 7.6949999999999985,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1774.024000000054,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 37.278999999999996,
      "layouts": 16,
      "layoutDurationMs": 4.298,
      "taskDurationMs": 1102.2920000000001,
      "heapDeltaBytes": 12604072,
      "heapUsedBytes": 76619928,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 119.83699999999999,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1825.599000000011,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 38.414,
      "layouts": 16,
      "layoutDurationMs": 4.374,
      "taskDurationMs": 1108.722,
      "heapDeltaBytes": -2841344,
      "heapUsedBytes": 66844076,
      "domNodes": -295,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 116.699,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1417.4290000000838,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 31.740999999999993,
      "layouts": 14,
      "layoutDurationMs": 14.141999999999998,
      "taskDurationMs": 937.1039999999997,
      "heapDeltaBytes": -1900584,
      "heapUsedBytes": 94297616,
      "domNodes": 13671,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 29.960999999999995,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 128,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12469.99599999981,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 35.991,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9410.85,
      "heapDeltaBytes": -22968280,
      "heapUsedBytes": 67541544,
      "domNodes": -282,
      "jsHeapTotalBytes": 4714496,
      "scriptDurationMs": 3339.9030000000002,
      "eventListeners": -159,
      "totalBlockingTimeMs": 31,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 12572.908000000098,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 42.937000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9805.24,
      "heapDeltaBytes": -13425600,
      "heapUsedBytes": 77356380,
      "domNodes": -272,
      "jsHeapTotalBytes": 3858432,
      "scriptDurationMs": 3360.98,
      "eventListeners": -127,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333326,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17746.243999999933,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17012.173,
      "heapDeltaBytes": -42516716,
      "heapUsedBytes": 181260744,
      "domNodes": -6548,
      "jsHeapTotalBytes": 3923968,
      "scriptDurationMs": 344.84999999999997,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17117.23000000006,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16612.150999999998,
      "heapDeltaBytes": -34702176,
      "heapUsedBytes": 176514448,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6230016,
      "scriptDurationMs": 326.149,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21367.11300000002,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 18.960999999999977,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20990.113,
      "heapDeltaBytes": -36228076,
      "heapUsedBytes": 176854220,
      "domNodes": -6548,
      "jsHeapTotalBytes": -6619136,
      "scriptDurationMs": 980.8409999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 115,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20955.928999999967,
      "styleRecalcs": 178,
      "styleRecalcDurationMs": 18.64000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20572.04,
      "heapDeltaBytes": -59911936,
      "heapUsedBytes": 166184220,
      "domNodes": -6548,
      "jsHeapTotalBytes": -5378048,
      "scriptDurationMs": 945.9980000000002,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 141,
      "frameDurationMs": 17.773333333333238,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 142.60300000000825,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 16.262,
      "layouts": 7,
      "layoutDurationMs": 2.0010000000000003,
      "taskDurationMs": 114.779,
      "heapDeltaBytes": 3522708,
      "heapUsedBytes": 69923460,
      "domNodes": 131,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.588,
      "eventListeners": 25,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 133.52400000007947,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 18.154999999999998,
      "layouts": 3,
      "layoutDurationMs": 0.7720000000000001,
      "taskDurationMs": 99.85900000000001,
      "heapDeltaBytes": 3407192,
      "heapUsedBytes": 69837848,
      "domNodes": 112,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 4.772,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

@codecov

codecov Bot commented Aug 24, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@                   Coverage Diff                    @@
##             feature/ecs-migration   #15778   +/-   ##
========================================================
  Coverage                         ?   82.23%           
========================================================
  Files                            ?     1902           
  Lines                            ?   108065           
  Branches                         ?    34156           
========================================================
  Hits                             ?    88865           
  Misses                           ?    18858           
  Partials                         ?      342           
Flag Coverage Δ
unit 73.95% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/lib/litegraph/src/LLink.ts 69.03% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL added the refactor label Aug 24, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing as a duplicate of the enumerable-topology fix already contained in #15654 (DrJKL's provenance-based stale-link fix).

This PR preserved LLink spread topology by making the relevant properties enumerable; #15654 includes the same enumerable-topology correction as part of its provenance validation work, so merging both would be redundant. Recorded in the workspace decision log as part of DQ-09.

The registration-guard change stays alive separately in #15767 (decline unkeyable widget promotion), which will be rebased over #15654 once it lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants