Repository navigation
fix: serve cloud onboarding logo from a path nginx proxies - #14805
Conversation
CloudTemplate.vue referenced /icons/logo.svg, but public/icons/ isn't one of the paths Cloud's nginx-frontend proxies to the GCS asset bucket (only /assets/, /fonts/, /cursor/, /scripts/, /extensions/core/, /extensions/cloud/, plus a couple of exact-match files). Requests fall through to the SPA catch-all and get index.html back with a 200, so the logo silently breaks on nightly/testcloud/ stagingcloud/prod-cloud while working fine in local dev. Move the asset to public/assets/images/comfy-logo-wordmark.svg, matching the existing convention for other logo images in that directory (comfy-logo-single.svg, comfy-logo-mono.svg), and update the img src accordingly. Introduced by #14697.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1782 passed, 0 failed · 5 flaky📊 Browser Reports
📦 Bundle: 8.26 MB gzip 🔴 +20 BDetailsSummary
Category Glance App Entry Points — 3.64 kB (baseline 3.64 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.35 MB (baseline 1.35 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 2 unchanged Views & Navigation — 124 kB (baseline 124 kB) • 🔴 +66 BTop-level views, pages, and routed surfaces
Status: 1 added / 1 removed / 16 unchanged Panels & Settings — 552 kB (baseline 552 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 27 kB (baseline 27 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 10 unchanged Editors & Dialogs — 124 kB (baseline 124 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 7 unchanged UI Components — 72.1 kB (baseline 72.1 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.48 MB (baseline 3.48 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 17 unchanged Utilities & Hooks — 387 kB (baseline 387 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 15.7 MB (baseline 15.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 12.8 MB (baseline 12.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 283 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-08-05T14:42:09.310Z",
"gitSha": "80d57b9e7aeec6aeba1881579a131b75d88d678d",
"branch": "fix/cloud-logo-icon-path",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2142.8889999999683,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.294000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.858,
"heapDeltaBytes": 5624352,
"heapUsedBytes": 69667532,
"domNodes": 16,
"jsHeapTotalBytes": 24641536,
"scriptDurationMs": 18.664000000000005,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2001.6010000000506,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.536999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.32899999999995,
"heapDeltaBytes": 5326716,
"heapUsedBytes": 69388516,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 15.429000000000002,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1872.0199999999636,
"styleRecalcs": 74,
"styleRecalcDurationMs": 36.468,
"layouts": 12,
"layoutDurationMs": 3.5320000000000005,
"taskDurationMs": 878.745,
"heapDeltaBytes": -12581532,
"heapUsedBytes": 51572048,
"domNodes": -280,
"jsHeapTotalBytes": 23834624,
"scriptDurationMs": 121.094,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1854.991000000041,
"styleRecalcs": 76,
"styleRecalcDurationMs": 38.57000000000001,
"layouts": 12,
"layoutDurationMs": 3.505,
"taskDurationMs": 885.995,
"heapDeltaBytes": -11212412,
"heapUsedBytes": 52854548,
"domNodes": -283,
"jsHeapTotalBytes": 24621056,
"scriptDurationMs": 124.246,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.579999999998,
"styleRecalcs": 30,
"styleRecalcDurationMs": 16.479,
"layouts": 6,
"layoutDurationMs": 0.748,
"taskDurationMs": 377.05,
"heapDeltaBytes": 8073528,
"heapUsedBytes": 72075572,
"domNodes": 76,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 18.418999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1773.4209999999848,
"styleRecalcs": 33,
"styleRecalcDurationMs": 17.853,
"layouts": 6,
"layoutDurationMs": 0.7020000000000002,
"taskDurationMs": 395.034,
"heapDeltaBytes": 8290188,
"heapUsedBytes": 72535796,
"domNodes": 79,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 19.831000000000003,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 585.1989999999887,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.403000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.67400000000004,
"heapDeltaBytes": -10815116,
"heapUsedBytes": 53086676,
"domNodes": 14,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 59.78,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 577.0860000000084,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.407000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.53799999999995,
"heapDeltaBytes": -10971824,
"heapUsedBytes": 53188560,
"domNodes": 18,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 59.66199999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2028.7220000000161,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 675.9000000000001,
"heapDeltaBytes": 6770908,
"heapUsedBytes": 66177412,
"domNodes": -282,
"jsHeapTotalBytes": 3514368,
"scriptDurationMs": 102.65899999999999,
"eventListeners": -147,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2015.4999999999745,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.024000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 672.283,
"heapDeltaBytes": 1549700,
"heapUsedBytes": 61077360,
"domNodes": -282,
"jsHeapTotalBytes": 2990080,
"scriptDurationMs": 103.84599999999999,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2194.5690000000013,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.921000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1293.836,
"heapDeltaBytes": 3649172,
"heapUsedBytes": 64201716,
"domNodes": -285,
"jsHeapTotalBytes": 3969024,
"scriptDurationMs": 438.811,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2190.193000000022,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.700000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1324.466,
"heapDeltaBytes": 4643696,
"heapUsedBytes": 65003888,
"domNodes": -285,
"jsHeapTotalBytes": 2134016,
"scriptDurationMs": 444.793,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3181.377999999995,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.601000000000003,
"layouts": 60,
"layoutDurationMs": 7.393999999999999,
"taskDurationMs": 1478.939,
"heapDeltaBytes": 22896712,
"heapUsedBytes": 85405940,
"domNodes": 12,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 549.478,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3228.525999999988,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.893999999999998,
"layouts": 60,
"layoutDurationMs": 7.422999999999999,
"taskDurationMs": 1572.7769999999998,
"heapDeltaBytes": -310444,
"heapUsedBytes": 61675984,
"domNodes": -287,
"jsHeapTotalBytes": 7708672,
"scriptDurationMs": 558.096,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2044.6080000000393,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.931,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 688.898,
"heapDeltaBytes": 6787664,
"heapUsedBytes": 67352032,
"domNodes": -283,
"jsHeapTotalBytes": 2990080,
"scriptDurationMs": 104.244,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2016.4470000000847,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.150000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 676.91,
"heapDeltaBytes": 5946020,
"heapUsedBytes": 67036708,
"domNodes": -285,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 103.952,
"eventListeners": -179,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 574.4850000000383,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.14,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.733,
"heapDeltaBytes": -10874360,
"heapUsedBytes": 53484588,
"domNodes": 18,
"jsHeapTotalBytes": 26214400,
"scriptDurationMs": 120.93499999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.3550000000541,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.528,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.45400000000006,
"heapDeltaBytes": -10790440,
"heapUsedBytes": 53483604,
"domNodes": 22,
"jsHeapTotalBytes": 25952256,
"scriptDurationMs": 121.619,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1997.6369999999974,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.361,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.633,
"heapDeltaBytes": 5086620,
"heapUsedBytes": 69348284,
"domNodes": 20,
"jsHeapTotalBytes": 24903680,
"scriptDurationMs": 13.324999999999998,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2028.507999999988,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.809,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.741,
"heapDeltaBytes": -17757708,
"heapUsedBytes": 46344920,
"domNodes": -281,
"jsHeapTotalBytes": 23834624,
"scriptDurationMs": 13.195,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.5119999999747,
"styleRecalcs": 75,
"styleRecalcDurationMs": 34.531,
"layouts": 16,
"layoutDurationMs": 3.815,
"taskDurationMs": 798.5870000000001,
"heapDeltaBytes": -16584304,
"heapUsedBytes": 47538044,
"domNodes": -279,
"jsHeapTotalBytes": 23310336,
"scriptDurationMs": 90.322,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1711.1999999999625,
"styleRecalcs": 76,
"styleRecalcDurationMs": 35.58,
"layouts": 16,
"layoutDurationMs": 3.8979999999999997,
"taskDurationMs": 804.332,
"heapDeltaBytes": -16959424,
"heapUsedBytes": 47191760,
"domNodes": -278,
"jsHeapTotalBytes": 23310336,
"scriptDurationMs": 90.957,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.136000000065,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.606999999999996,
"layouts": 13,
"layoutDurationMs": 12.33,
"taskDurationMs": 928.3769999999998,
"heapDeltaBytes": 8904564,
"heapUsedBytes": 100536112,
"domNodes": 13673,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 35.529,
"eventListeners": 2375,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8599.671,
"styleRecalcs": 251,
"styleRecalcDurationMs": 39.064,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4821.705,
"heapDeltaBytes": 13954120,
"heapUsedBytes": 73876440,
"domNodes": -283,
"jsHeapTotalBytes": 5804032,
"scriptDurationMs": 1506.545,
"eventListeners": -133,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8364.866000000005,
"styleRecalcs": 250,
"styleRecalcDurationMs": 37.508,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4594.863,
"heapDeltaBytes": 8267436,
"heapUsedBytes": 67639916,
"domNodes": -281,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 1455.52,
"eventListeners": -163,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17164.76499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17124.377,
"heapDeltaBytes": -36767724,
"heapUsedBytes": 167706620,
"domNodes": -8312,
"jsHeapTotalBytes": -8069120,
"scriptDurationMs": 604.218,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17077.478000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17061.924000000003,
"heapDeltaBytes": -40343004,
"heapUsedBytes": 166770588,
"domNodes": -8312,
"jsHeapTotalBytes": -8593408,
"scriptDurationMs": 576.8180000000001,
"eventListeners": -16387,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20857.511999999984,
"styleRecalcs": 142,
"styleRecalcDurationMs": 16.312000000000047,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20761.269,
"heapDeltaBytes": -48892560,
"heapUsedBytes": 156361544,
"domNodes": -8312,
"jsHeapTotalBytes": -9379840,
"scriptDurationMs": 895.7220000000001,
"eventListeners": -16383,
"totalBlockingTimeMs": 204,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20744.49600000003,
"styleRecalcs": 141,
"styleRecalcDurationMs": 16.993000000000038,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20719.559,
"heapDeltaBytes": -40820708,
"heapUsedBytes": 176447476,
"domNodes": -8312,
"jsHeapTotalBytes": -8134656,
"scriptDurationMs": 909.116,
"eventListeners": -16383,
"totalBlockingTimeMs": 170,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 474.61599999996906,
"styleRecalcs": 14,
"styleRecalcDurationMs": 20.343,
"layouts": 2,
"layoutDurationMs": 0.4370000000000001,
"taskDurationMs": 124.458,
"heapDeltaBytes": 5318704,
"heapUsedBytes": 68278744,
"domNodes": 134,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.168,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 110.49200000002202,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.957,
"layouts": 2,
"layoutDurationMs": 1.2180000000000002,
"taskDurationMs": 75.676,
"heapDeltaBytes": 2982948,
"heapUsedBytes": 66006716,
"domNodes": 126,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 4.501000000000001,
"eventListeners": 25,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
}
]
} |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #14805 +/- ##
=======================================
Coverage 78.68% 78.68%
=======================================
Files 1801 1801
Lines 106948 106948
Branches 30649 30649
=======================================
Hits 84155 84155
Misses 22337 22337
Partials 456 456
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
The Comfy logo on the Cloud login/signup/forgot-password pages is broken on nightly, testcloud, stagingcloud, and prod-cloud — it only renders correctly in local dev.
Changes
CloudTemplate.vueloads the logo via'<img src="/icons/logo.svg">'. That asset lived atpublic/icons/logo.svg, a top-levelpublic/path that Cloud's nginx-frontend does not proxy through to the GCS asset bucket (nginx only proxies/assets/,/fonts/,/cursor/,/scripts/,/extensions/core/,/extensions/cloud/, plus the exact-match files/materialdesignicons.min.cssand/favicon.ico). The request falls through to the SPA catch-all and getsindex.htmlback with a 200, so the browser shows a broken image with no console error and no 404 — nothing to signal the failure. This was introduced by feat(cloud): align logo, content and terms on one edge #14697 (feat(cloud): align logo, content and terms on one edge #14697), which swapped an iconify class for this `` tag.public/assets/images/comfy-logo-wordmark.svg, a path nginx already proxies, matching the naming convention of the other logo assets already in that directory (comfy-logo-single.svg,comfy-logo-mono.svg).img srcinCloudTemplate.vueto point at the new path.Review Focus
apps/website/public/icons/logo.svgis a separate, unrelated asset for the standalone website app (different deployment, not served through Cloud's nginx-frontend) — intentionally left untouched.Screenshots (if applicable)
N/A — this is a one-line path fix; no visual change to verify beyond the logo now loading.
Generated by Claude Code