Repository navigation
[backport cloud/1.43] consolidated bug fixes from main / v1.44.16 - #11926
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🎨 Storybook: ✅ Built — View Storybook |
|
Acknowledged — CodeRabbit auto-skipped because the title contains No code action needed. Each cherry-pick is annotated with |
🎭 Playwright: ✅ 1037 passed, 0 failed · 3 flaky📊 Browser Reports
|
📦 Bundle Size
⚡ Performance Report
No baseline found — showing absolute values.
Raw data{
"timestamp": "2026-05-04T23:07:25.496Z",
"gitSha": "64e81dda0517f9444bcb670cd887aa4b9beb18e6",
"branch": "glary/cloud-1.43-batch-backport-fixes",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2000.1749999999845,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.672999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.204,
"heapDeltaBytes": 20113424,
"heapUsedBytes": 63449476,
"domNodes": 14,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 16.802999999999997,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2029.071999999985,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.657000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 394.65199999999993,
"heapDeltaBytes": 20782024,
"heapUsedBytes": 63970676,
"domNodes": 19,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 20.975,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2024.116000000049,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.047,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.7130000000001,
"heapDeltaBytes": 21117136,
"heapUsedBytes": 64083128,
"domNodes": 20,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 21.189,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2027.8509999999983,
"styleRecalcs": 82,
"styleRecalcDurationMs": 50.38400000000001,
"layouts": 12,
"layoutDurationMs": 3.482,
"taskDurationMs": 986.43,
"heapDeltaBytes": 16355280,
"heapUsedBytes": 59372804,
"domNodes": 68,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 131.266,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1854.957000000013,
"styleRecalcs": 77,
"styleRecalcDurationMs": 40.239999999999995,
"layouts": 12,
"layoutDurationMs": 3.753,
"taskDurationMs": 782.532,
"heapDeltaBytes": 16056040,
"heapUsedBytes": 58996328,
"domNodes": 60,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 133.768,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2026.707999999985,
"styleRecalcs": 84,
"styleRecalcDurationMs": 43.361000000000004,
"layouts": 12,
"layoutDurationMs": 3.4400000000000004,
"taskDurationMs": 935.516,
"heapDeltaBytes": 17053468,
"heapUsedBytes": 61248348,
"domNodes": 65,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 126.06499999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1744.8269999999866,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.838,
"layouts": 6,
"layoutDurationMs": 0.7329999999999999,
"taskDurationMs": 309.971,
"heapDeltaBytes": 25042836,
"heapUsedBytes": 68126580,
"domNodes": 78,
"jsHeapTotalBytes": 21233664,
"scriptDurationMs": 25.320000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1751.811000000032,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.375000000000004,
"layouts": 6,
"layoutDurationMs": 0.6480000000000001,
"taskDurationMs": 359.334,
"heapDeltaBytes": 15411648,
"heapUsedBytes": 66478768,
"domNodes": 79,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 29.91100000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.5799999999372,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.739,
"layouts": 6,
"layoutDurationMs": 0.6690000000000002,
"taskDurationMs": 303.587,
"heapDeltaBytes": 25013252,
"heapUsedBytes": 67811132,
"domNodes": 80,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 26.238999999999997,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 661.5759999999966,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.643,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.86999999999995,
"heapDeltaBytes": 7489944,
"heapUsedBytes": 50407632,
"domNodes": 20,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 70.65500000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 571.5749999999957,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.736,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 358.47799999999995,
"heapDeltaBytes": 7153792,
"heapUsedBytes": 49689572,
"domNodes": 22,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 65.093,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 560.1429999999255,
"styleRecalcs": 14,
"styleRecalcDurationMs": 9.145,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.936,
"heapDeltaBytes": -2236780,
"heapUsedBytes": 49717116,
"domNodes": 23,
"jsHeapTotalBytes": 16252928,
"scriptDurationMs": 65.77,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2034.5959999999934,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.734,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 601.1189999999999,
"heapDeltaBytes": 5307656,
"heapUsedBytes": 56175920,
"domNodes": -256,
"jsHeapTotalBytes": 15921152,
"scriptDurationMs": 104.84000000000002,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2053.7009999999896,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.790000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 714.3219999999999,
"heapDeltaBytes": 5019392,
"heapUsedBytes": 56543344,
"domNodes": -259,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 121.84400000000001,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2038.0040000000008,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.368000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.098,
"heapDeltaBytes": 4425576,
"heapUsedBytes": 55514260,
"domNodes": -257,
"jsHeapTotalBytes": 15659008,
"scriptDurationMs": 88.41799999999999,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2122.9739999999993,
"styleRecalcs": 69,
"styleRecalcDurationMs": 19.701,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1048.0739999999998,
"heapDeltaBytes": 18460252,
"heapUsedBytes": 71103016,
"domNodes": -260,
"jsHeapTotalBytes": 17960960,
"scriptDurationMs": 372.66900000000004,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2157.5050000000147,
"styleRecalcs": 69,
"styleRecalcDurationMs": 19.831999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1121.583,
"heapDeltaBytes": 18921392,
"heapUsedBytes": 71610960,
"domNodes": -259,
"jsHeapTotalBytes": 18223104,
"scriptDurationMs": 383.55899999999997,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2142.647000000011,
"styleRecalcs": 69,
"styleRecalcDurationMs": 17.974999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1007.004,
"heapDeltaBytes": 16727016,
"heapUsedBytes": 70670040,
"domNodes": -263,
"jsHeapTotalBytes": 18485248,
"scriptDurationMs": 361.75399999999996,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3164.478000000003,
"styleRecalcs": 64,
"styleRecalcDurationMs": 18.736,
"layouts": 60,
"layoutDurationMs": 8.337000000000002,
"taskDurationMs": 1377.6770000000001,
"heapDeltaBytes": 7409840,
"heapUsedBytes": 63209540,
"domNodes": -269,
"jsHeapTotalBytes": 16969728,
"scriptDurationMs": 509.1509999999999,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3184.278000000006,
"styleRecalcs": 66,
"styleRecalcDurationMs": 20.763,
"layouts": 60,
"layoutDurationMs": 8.55,
"taskDurationMs": 1377.635,
"heapDeltaBytes": 9097864,
"heapUsedBytes": 64567820,
"domNodes": -267,
"jsHeapTotalBytes": 15396864,
"scriptDurationMs": 505.412,
"eventListeners": -123,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-zoom",
"durationMs": 3168.011999999976,
"styleRecalcs": 65,
"styleRecalcDurationMs": 19.005000000000003,
"layouts": 60,
"layoutDurationMs": 7.931000000000001,
"taskDurationMs": 1334.889,
"heapDeltaBytes": 6970556,
"heapUsedBytes": 62810608,
"domNodes": -266,
"jsHeapTotalBytes": 17756160,
"scriptDurationMs": 498.15200000000004,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2017.0699999999897,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.274999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.0109999999999,
"heapDeltaBytes": 2534776,
"heapUsedBytes": 56953852,
"domNodes": -263,
"jsHeapTotalBytes": 16707584,
"scriptDurationMs": 80.698,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2036.4779999999882,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.111,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.719,
"heapDeltaBytes": 3496444,
"heapUsedBytes": 57982272,
"domNodes": -261,
"jsHeapTotalBytes": 15659008,
"scriptDurationMs": 84.077,
"eventListeners": -127,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2009.2280000000073,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.146999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.6189999999999,
"heapDeltaBytes": 4106424,
"heapUsedBytes": 56678692,
"domNodes": -259,
"jsHeapTotalBytes": 16183296,
"scriptDurationMs": 86.232,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 543.6080000000061,
"styleRecalcs": 49,
"styleRecalcDurationMs": 12.378,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 352.345,
"heapDeltaBytes": 6232504,
"heapUsedBytes": 49555352,
"domNodes": 23,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 126.34800000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 580.6860000000142,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.677000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 347.79,
"heapDeltaBytes": 6542956,
"heapUsedBytes": 49772000,
"domNodes": 22,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 126.41199999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 544.4710000000441,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.33,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 357.51800000000003,
"heapDeltaBytes": 6489436,
"heapUsedBytes": 49748544,
"domNodes": 22,
"jsHeapTotalBytes": 13369344,
"scriptDurationMs": 124.50500000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.7529999999845,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.468000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.256,
"heapDeltaBytes": 20392968,
"heapUsedBytes": 65736584,
"domNodes": 22,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 21.757000000000005,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1994.1189999999551,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.618000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.609,
"heapDeltaBytes": 20028128,
"heapUsedBytes": 63200352,
"domNodes": 20,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 22.83000000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2014.7139999999126,
"styleRecalcs": 11,
"styleRecalcDurationMs": 11.94,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 346.26399999999995,
"heapDeltaBytes": 19920912,
"heapUsedBytes": 63213304,
"domNodes": 22,
"jsHeapTotalBytes": 22544384,
"scriptDurationMs": 15.106999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2000.6759999999986,
"styleRecalcs": 88,
"styleRecalcDurationMs": 46.788999999999994,
"layouts": 16,
"layoutDurationMs": 4.632,
"taskDurationMs": 922.378,
"heapDeltaBytes": 11931192,
"heapUsedBytes": 55135636,
"domNodes": 74,
"jsHeapTotalBytes": 22806528,
"scriptDurationMs": 96.85400000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1990.3540000000248,
"styleRecalcs": 83,
"styleRecalcDurationMs": 53.321000000000005,
"layouts": 16,
"layoutDurationMs": 5.125,
"taskDurationMs": 955.766,
"heapDeltaBytes": 11925368,
"heapUsedBytes": 55151848,
"domNodes": 71,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 110.44,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1983.842999999979,
"styleRecalcs": 84,
"styleRecalcDurationMs": 47.723,
"layouts": 16,
"layoutDurationMs": 5.874,
"taskDurationMs": 877.8499999999999,
"heapDeltaBytes": 12351364,
"heapUsedBytes": 55548764,
"domNodes": 72,
"jsHeapTotalBytes": 23068672,
"scriptDurationMs": 93.32900000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8208.905000000015,
"styleRecalcs": 251,
"styleRecalcDurationMs": 56.68899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3628.4320000000002,
"heapDeltaBytes": 27972348,
"heapUsedBytes": 79086940,
"domNodes": -258,
"jsHeapTotalBytes": 18747392,
"scriptDurationMs": 1218.863,
"eventListeners": -109,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8139.9169999999685,
"styleRecalcs": 250,
"styleRecalcDurationMs": 56.345000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3658.0249999999996,
"heapDeltaBytes": 17536164,
"heapUsedBytes": 68646560,
"domNodes": -258,
"jsHeapTotalBytes": 20582400,
"scriptDurationMs": 1186.976,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8146.874000000025,
"styleRecalcs": 249,
"styleRecalcDurationMs": 53.94200000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3454.3920000000003,
"heapDeltaBytes": 23425516,
"heapUsedBytes": 76062076,
"domNodes": -259,
"jsHeapTotalBytes": 19271680,
"scriptDurationMs": 1146.204,
"eventListeners": -111,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12864.496000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12849.711,
"heapDeltaBytes": -30718324,
"heapUsedBytes": 165652148,
"domNodes": -8329,
"jsHeapTotalBytes": 25780224,
"scriptDurationMs": 608.6129999999999,
"eventListeners": -16462,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12689.571,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12676.051,
"heapDeltaBytes": -32240180,
"heapUsedBytes": 165978796,
"domNodes": -8329,
"jsHeapTotalBytes": 25780224,
"scriptDurationMs": 571.2349999999999,
"eventListeners": -16468,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 12148.168000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12137.535,
"heapDeltaBytes": -47319004,
"heapUsedBytes": 165638224,
"domNodes": -8329,
"jsHeapTotalBytes": 25255936,
"scriptDurationMs": 595.607,
"eventListeners": -16470,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15636.040000000037,
"styleRecalcs": 79,
"styleRecalcDurationMs": 20.11700000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15606.95,
"heapDeltaBytes": -33639856,
"heapUsedBytes": 159873904,
"domNodes": -8329,
"jsHeapTotalBytes": -2269184,
"scriptDurationMs": 896.541,
"eventListeners": -16456,
"totalBlockingTimeMs": 60,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 14819.174000000032,
"styleRecalcs": 71,
"styleRecalcDurationMs": 18.448999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14797.351999999999,
"heapDeltaBytes": -23897452,
"heapUsedBytes": 172083772,
"domNodes": -8329,
"jsHeapTotalBytes": 22810624,
"scriptDurationMs": 851.6139999999999,
"eventListeners": -16462,
"totalBlockingTimeMs": 86,
"frameDurationMs": 18.330000000000048,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 14492.467000000033,
"styleRecalcs": 66,
"styleRecalcDurationMs": 16.923999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14470.833,
"heapDeltaBytes": -24267852,
"heapUsedBytes": 176532744,
"domNodes": -8331,
"jsHeapTotalBytes": 14422016,
"scriptDurationMs": 795.6370000000001,
"eventListeners": -16466,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 442.69800000000714,
"styleRecalcs": 15,
"styleRecalcDurationMs": 25.605,
"layouts": 5,
"layoutDurationMs": 1.723,
"taskDurationMs": 125.75500000000001,
"heapDeltaBytes": 4610392,
"heapUsedBytes": 49491448,
"domNodes": 161,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 25.523999999999997,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 464.38399999999547,
"styleRecalcs": 18,
"styleRecalcDurationMs": 26.503,
"layouts": 5,
"layoutDurationMs": 1.3299999999999998,
"taskDurationMs": 129.258,
"heapDeltaBytes": 4489812,
"heapUsedBytes": 49361640,
"domNodes": 159,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 30.574000000000005,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 437.32599999998456,
"styleRecalcs": 19,
"styleRecalcDurationMs": 23.481999999999996,
"layouts": 5,
"layoutDurationMs": 1.3670000000000002,
"taskDurationMs": 118.22399999999999,
"heapDeltaBytes": 4514960,
"heapUsedBytes": 48884732,
"domNodes": 159,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 27.768,
"eventListeners": 71,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
} |
dbffda3 to
f4001fa
Compare
f4001fa to
4924e8a
Compare
CI failure triage and fixes pushedOriginal failures from CI run on
Fixes applied (rebased and force-pushed): For each problem commit, removed the broken test file/fixture (reverting that file to cloud/1.43 baseline). Runtime fixes in those commits are preserved. Concretely:
Local verification on the new HEAD (
CI hasn't auto-redispatched on the rebased branch — the GitHub App's force-push doesn't always retrigger workflows. A maintainer may need to push the "Run workflow" button or the workflows will pick up on the next branch push. Note also: the |
## Summary Auto-fit viewport to subgraph content on first entry so interior nodes are immediately visible. ## Changes - **What**: On cache miss in `restoreViewport()`, call `fitView()` via `requestAnimationFrame` instead of silently returning. Existing cache-hit path (revisiting a subgraph) is unchanged. ## Review Focus The `anyItemOverlapsRect` guard in `app.ts` (workflow load path) is intentionally **not** touched — it serves a different purpose (respecting `extra.ds` on workflow load). This fix only affects subgraph navigation transitions where there is no saved viewport to respect. Fixes #8173 ## Screenshots (if applicable) N/A — viewport positioning fix; before: empty canvas on subgraph entry, after: nodes visible. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10995-fix-auto-fit-to-view-on-first-subgraph-entry-33d6d73d365081f3a9b3cc2124979624) by [Unito](https://www.unito.io) (cherry picked from commit 577f373)
## Summary
Add `windowsHide: true` to the `execSync('git rev-parse HEAD')` call in
`vite.config.mts` to prevent a console window from flashing on Windows
during builds.
## Changes
- **What**: Pass `windowsHide: true` option to `execSync` when fetching
the git commit hash at build time. This suppresses the transient cmd.exe
popup that appears on Windows.
## Review Focus
Minimal, single-option change. `windowsHide` is a Node.js built-in
option for `child_process` methods — no-op on non-Windows platforms.
┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-11144-fix-vite-hide-git-rev-parse-window-on-Windows-33e6d73d365081ed9a14da5f47ccac4d)
by [Unito](https://www.unito.io)
Co-authored-by: Amp <amp@ampcode.com>
(cherry picked from commit 5c14bad)
…es (#11010) ## Summary Three issues caused GLSL preview to diverge from backend results: 1. Uniform source resolution always read widgets[0] instead of using link.origin_slot to select the correct widget. Added directValue fallback for widgets not registered in widgetValueStore. 2. Hex color strings (e.g. "#45edf5") were coerced to 0 by Number(). Added hexToInt to colorUtil and used it in toNumber coercion. 3. Custom size_mode was ignored — preview always used upstream image dimensions. Now checks size_mode widget first and respects "custom". ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11010-fix-resolve-incorrect-GLSL-live-preview-for-non-primitive-widget-types-33e6d73d36508101a76bfe8383c0c6ab) by [Unito](https://www.unito.io) (cherry picked from commit 6d4fc1b)
## Summary Cloned/pasted nodes in Node 2.0 (Vue renderer) mode now appear above the original node instead of behind it. ## Root Cause The legacy LiteGraph canvas renderer uses array ordering for z-ordering: nodes are stored in `graph._nodes` and drawn sequentially, so newly added nodes (appended to the end) are automatically drawn on top. There is no explicit z-index. The Vue renderer (Node 2.0) uses explicit CSS `z-index` for node ordering. New nodes default to `zIndex: 0` in `layoutMutations.ts`. When a node has been interacted with, `bringNodeToFront` raises its z-index. A cloned node at z-index 0 therefore appears behind any previously interacted node. The alt-click clone path in `LGraphNode.vue` already handles this correctly by calling `bringNodeToFront()` after cloning. However, the menu clone and keyboard paste paths go through `_deserializeItems` in `LGraphCanvas.ts`, which does not set z-index for new nodes. | Clone method | Legacy renderer | Vue renderer (before fix) | Vue renderer (after fix) | |---|---|---|---| | Alt-click drag | On top (array order) | On top (`bringNodeToFront` called) | On top | | Right-click menu Clone | On top (array order) | Behind original (z-index 0) | On top | | Ctrl+C / Ctrl+V | On top (array order) | Behind original (z-index 0) | On top | ## Steps to Reproduce 1. Enable Node 2.0 mode (Vue renderer) in settings 2. Add any node to the canvas 3. Click or drag the node (raises its z-index via `bringNodeToFront`) 4. Right-click the node and select "Clone" 5. **Expected**: Cloned node appears above the original, immediately draggable 6. **Actual**: Cloned node appears behind the original; user must move the original to access the clone ## Changes After `batchUpdateNodeBounds` in `_deserializeItems`, calls `bringNodeToFront` for each newly created node so they receive a z-index above all existing nodes. ## Side Effect Analysis Checked all call sites of `_deserializeItems`: 1. **Initial graph load / workflow open**: `loadGraphData` in `app.ts` does NOT call `_deserializeItems`. Workflow loading goes through `LGraph.configure()` which directly adds nodes and links. The layout store is initialized separately via `initializeFromLiteGraph`. No side effect. 2. **Paste from clipboard (Ctrl+V)**: Both `usePaste.ts` (line 52) and `pasteFromClipboard` (line 4080) call `_deserializeItems`. Pasted nodes appearing on top is the correct and desired behavior. No issue. 3. **Undo/Redo**: `ChangeTracker.updateState()` calls `app.loadGraphData()`, which does a full graph reconfigure -- it does NOT go through `_deserializeItems`. No side effect. 4. **Subgraph blueprint addition**: `litegraphService.ts` (line 906) calls `_deserializeItems` when adding subgraph blueprints from the node library. These are freshly placed nodes that should appear on top. Desired behavior. 5. **Alt-click clone in LGraphNode.vue**: This path calls `LGraphCanvas.cloneNodes()` -> `_deserializeItems()`, then separately calls `bringNodeToFront()` again on line 433 of `LGraphNode.vue`. The second call is now redundant (the node is already at max z-index), but harmless -- `bringNodeToFront` finds the current max, adds 1, and sets. The z-index will increment from N to N+1 on the second call. This is a minor redundancy, not a bug. 6. **Performance**: `bringNodeToFront` iterates all nodes in the layout store once per call (O(m)) to find max z-index. For n new nodes, the total cost is O(n*m). In practice, clone/paste operations involve a small number of nodes (typically 1-10), so this is negligible. For extremely large pastes (100+ nodes), each call also increments the max by 1, so z-indices will be sequential (which is actually a reasonable stacking order). 7. **layoutStore availability**: `layoutStore` is a module-level singleton (`new LayoutStoreImpl()`) -- not a Pinia store -- so it is always available. The `useLayoutMutations()` composable is a plain function returning an object of closures over `layoutStore`. It does not require Vue component context. No risk of runtime errors. 8. **Legacy renderer (non-Vue mode)**: When Node 2.0 mode is disabled, the layout store still exists but is not used for rendering. Calling `bringNodeToFront` will update z-index values in the Yjs document that are never read. This is harmless. ## Red-Green Verification | Commit | Result | Description | |---|---|---| | `6894b99` `test:` | RED | Test asserts cloned node z-index > original. Fails with `expected 0 to be greater than 5`. | | `3567469` `fix:` | GREEN | Calls `bringNodeToFront` for each new node in `_deserializeItems`. Test passes. | Fixes #10307 --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> (cherry picked from commit e729e5e)
) ## Summary Track GTM `subscription_success` when a workspace subscription completes synchronously in the dialog. The async billing-operation path already emitted telemetry; the missing gap was the immediate `subscribed` response. ## Changes - **What**: Add the missing GTM success emission to both synchronous workspace subscribe success branches while preserving the existing toast, billing refresh, and dialog close behavior. ## Review Focus Verify the synchronous `response.status === "subscribed"` workspace dialog paths are the only missing frontend success emissions, while the async billing-operation telemetry path remains unchanged. This PR intentionally stays minimal. It does not add new browser coverage yet; the previous component-level unit test was more implementation-coupled than this fix justified, and a better long-term test would be a higher-level workspace billing flow test once we have a cleaner harness. (cherry picked from commit 719ed16)
## Summary Prevent early `progress_text` websocket events from throwing before the graph canvas is initialized. ## Changes - **What**: Guard `handleProgressText()` until `canvasStore.canvas` exists, and add a regression test for a startup-time `progress_text` event arriving before `GraphCanvas` finishes initialization. ## Review Focus Confirm this is the right guard point for the startup race between `GraphView` websocket binding and `GraphCanvas` async setup, and that progress text behavior is unchanged once the canvas is ready. ## Validation - `pnpm exec eslint src/stores/executionStore.ts src/stores/executionStore.test.ts` - `pnpm exec vitest run src/stores/executionStore.test.ts -t "should ignore progress_text before the canvas is initialized"` - `pnpm test:unit -- --run src/stores/executionStore.test.ts` still reports one unrelated isolated-file failure in `nodeLocatorIdToExecutionId` on current `main` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11174-fix-guard-progress_text-before-canvas-init-3406d73d3650813dad23d511fb51add5) by [Unito](https://www.unito.io) (cherry picked from commit 2524846)
## Summary - Multiple SubgraphNode instances of the same blueprint share inner nodes, causing promoted widget values to collide — the last configured instance overwrites all previous values - Add per-instance value storage (`_instanceWidgetValues`) on SubgraphNode so each instance preserves its own promoted widget values independently - Restore `widgets_values` from serialized data into this per-instance map after promoted views are created during configure - Fixes #10146 ## Root Cause When loading a workflow with multiple SubgraphNode instances of the same blueprint: 1. `LGraph.configure()` creates ONE shared Subgraph per blueprint (line 2625) 2. Each SubgraphNode instance calls `configure(instanceData)` sequentially 3. `PromotedWidgetView.value` setter writes to the **shared inner node's widget** (`promotedWidgetView.ts:199`) 4. The last instance's `configure()` overwrites all previous instances' values **Regression**: Introduced by PR #8594 (WidgetValueStore, v1.41.3) which centralized widget state without per-instance scoping for shared blueprints. ## Fix - **SubgraphNode**: Add `_instanceWidgetValues` Map and `_pendingWidgetsValues` for configure-time restoration - **PromotedWidgetView getter**: Check instance map first before falling back to widget store / inner node - **PromotedWidgetView setter**: Write to instance map to avoid shared inner node mutation - **_internalConfigureAfterSlots**: Apply serialized `widgets_values` to per-instance map after promoted views are created ## Red-Green Verification | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: add failing tests for multi-instance subgraph widget value collision` | 🔴 Red | Proves widget values collide across instances | | `fix: store promoted widget values per SubgraphNode instance` | 🟢 Green | Per-instance storage prevents collision | ## Test Plan - [x] CI red on test-only commit - [x] CI green on fix commit - [x] Unit test: `preserves promoted widget values after configure with different widgets_values` - [x] All 253 existing subgraph tests pass - [ ] Manual: load workflow from issue image → verify 3 subgraph instances produce different results ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-10849-fix-store-promoted-widget-values-per-SubgraphNode-instance-3386d73d3650815a8544f54adcc0d504) by [Unito](https://www.unito.io) --------- Co-authored-by: dante <dante@danteui-MacStudio.local> (cherry picked from commit 6847c7b)
…1265) ## Summary followup #9520 mouseenter fires before load3d is created during async init (getLoad3dAsync), so the STATUS_MOUSE_ON_VIEWER flag is never set. This causes isActive() to return false after INITIAL_RENDER_DONE, stopping the animation loop from calling controlsManager.update() and making OrbitControls unresponsive on first open. Track hover state in the composable and sync it to load3d after creation. (cherry picked from commit 6fb90b2)
#11295) ## Summary When the properties panel is open, toggling focus mode on then off causes the panel to resize unexpectedly. The root cause is that `splitterRefreshKey` in `LiteGraphCanvasSplitterOverlay.vue` does not include `focusMode`, so the PrimeVue Splitter component instance is reused across focus mode transitions and restores stale panel sizes from localStorage. Fix: add `focusMode` to `splitterRefreshKey` so the Splitter is recreated when focus mode toggles. ## Red-Green Verification | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: add failing test for focus mode toggle resizing properties panel` | 🔴 Red | Proves the test catches the bug | | `fix: include focusMode in splitter refresh key to prevent panel resize` | 🟢 Green | Proves the fix resolves the bug | ## demo ### AS IS https://github.com/user-attachments/assets/95f6a9e3-e4c7-4aba-8e17-0eee11f70491 ### TO BE https://github.com/user-attachments/assets/595eafcd-6a80-443d-a6f3-bb7605ed0758 ## Test Plan - [ ] CI red on test-only commit - [ ] CI green on fix commit - [ ] E2E regression test added in `browser_tests/tests/focusMode.spec.ts` ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11295-fix-include-focusMode-in-splitter-refresh-key-to-prevent-panel-resize-3446d73d365081b7bc3ac65338e17a8f) by [Unito](https://www.unito.io) (cherry picked from commit e5c8148)
…9935) ## Summary Fix VHS unbatch output slot color not updating when slot types change via matchType resolution in Vue renderer. ## Changes - **What**: After `changeOutputType` mutates `output.type` on objects inside a `shallowReactive` array, spread-copy `this.outputs` to trigger the shallowReactive setter so `SlotConnectionDot` re-evaluates the slot color. ## Review Focus The fix adds `this.outputs = [...this.outputs]` after the matchType resolution loop in `withComfyMatchType`. This forces Vue's shallowReactive proxy to fire, since mutating a property on an object inside the array doesn't trigger the setter. The spread is placed after all outputs are updated to batch the reactivity trigger. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-9935-fix-trigger-Vue-reactivity-on-output-slot-type-changes-in-matchType-3246d73d365081c4a293f57931892c61) by [Unito](https://www.unito.io) (cherry picked from commit 2fea0aa)
## Summary Remove the black opacity/dimming overlay on image node hover and add shadows to action buttons for visibility against light backgrounds. ## Changes - **What**: Remove `opacity-50` dimming on hover in `DisplayCarousel.vue`, remove `transition-opacity hover:opacity-80` from grid thumbnails in `ImagePreview.vue`, add `shadow-md` to action buttons in `ImagePreview.vue`. Applies to Save Image, Load Image, Preview Image, and all nodes using these shared image components. ## Review Focus Button shadows (`shadow-md`) should provide sufficient contrast against light image backgrounds without needing the dimming overlay. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11296-fix-remove-hover-dimming-overlay-on-image-nodes-3446d73d36508193bb5cc27d431014fd) by [Unito](https://www.unito.io) (cherry picked from commit 4c7729e)
…11463) *PR Created by the Glary-Bot Agent* --- ## Summary Credits no longer showed in the current user popover on local/desktop builds. Root cause: the credits row in `CurrentUserPopoverLegacy.vue` was gated behind `isCloud && isActiveSubscription`, and `isCloud` is a compile-time constant that resolves to `false` on local (`DISTRIBUTION='localhost'`) — so the element never rendered and `fetchBalance()` never fired (no network request, no console logs). This fix decouples the credits balance row from the `isCloud` gate. Subscription-specific UI (subscribe button, partner nodes, plans & pricing, manage plan, upgrade-to-add-credits) remains gated by `isCloud` as intended by PR #9958. ## Changes - `CurrentUserPopoverLegacy.vue`: credits row `v-if` changed from `isCloud && isActiveSubscription` → `isActiveSubscription`. On non-cloud, `isActiveSubscription` resolves to `true` via `isSubscribedOrIsNotCloud` in `useSubscription.ts`, so credits display for logged-in users. - `CurrentUserPopoverLegacy.vue`: `upgrade-to-add-credits` button now requires `isCloud && isFreeTier` (subscription-tier concept only meaningful on cloud). The `add-credits` top-up button remains available everywhere. - `CurrentUserPopoverLegacy.test.ts`: updated non-cloud tests to assert credits balance is visible and add-credits button renders, while upgrade-to-add-credits and other subscription UI stay hidden. Mirrors the behavior of `CurrentUserPopoverWorkspace.vue`, which never had the `isCloud` gate on its credits row. ## Verification - `pnpm vitest run src/components/topbar/CurrentUserPopoverLegacy.test.ts`: **21/21 passing**, including new non-cloud assertions - `pnpm typecheck`: clean - `pnpm lint` / `pnpm format:check`: clean - Live frontend dev server renders on localhost with `__DISTRIBUTION__='localhost'` (the previously-failing scenario). Attached screenshot shows the app running on local distribution; the popover itself only appears for logged-in users, so its contents are exercised by the unit tests. Fixes FE-219 ## Screenshots  ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11463-fix-show-credits-in-legacy-user-popover-on-non-cloud-distributions-3486d73d365081c587d8ee7eae9a5c3d) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> (cherry picked from commit 4b5c15f)
…#11359) ## Summary Undo on a workflow with an interactive 3D/camera node (e.g. Qwen MultiAngle Camera) broke the interactive UI: it disappeared for Vue Nodes 2.0 and desynced for LiteGraph. Root cause: `initializeLoad3d` in `useLoad3d.ts` assigned `node.onRemoved`, `node.onResize`, and the other node lifecycle handlers by direct assignment, overwriting the cleanup chain that `addWidget()` had already appended during node construction (line `node.onRemoved = useChainCallback(node.onRemoved, () => widget.onRemove?.())` in `domWidget.ts`). When undo cleared the graph, `widget.onRemove` never ran, so the component widget stayed in `domWidgetStore` pointing at a detached element while new nodes registered fresh widgets at the same UUID keys. Fix: wrap all of those assignments with `useChainCallback` so earlier subscribers (widget registration, badge composables, extension nodeCreated hooks) continue to fire. - Fixes FE-214 (<https://linear.app/comfyorg/issue/FE-214/undo-breaks-and-desyncs-qwen-multiangle-camera-ui>) ## Red-Green Verification | Commit | CI Status | Purpose | |--------|-----------|---------| | `test: add failing test for FE-214 undo losing Load3D widget callback chain` | 🔴 Red | Proves the test catches the bug | | `fix: chain Load3D node lifecycle callbacks to preserve widget cleanup` | 🟢 Green | Proves the fix resolves the bug | ## Test Plan - [ ] CI red on test-only commit - [ ] CI green on fix commit - [ ] Manual: load Qwen MultiAngle Camera workflow, mutate camera, press Ctrl+Z, confirm interactive UI stays mounted and value reflects restored state (Vue Nodes 2.0 and LiteGraph) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11359-fix-chain-Load3D-node-lifecycle-callbacks-to-preserve-widget-cleanup-3466d73d365081e2b64de65c26ee6abf) by [Unito](https://www.unito.io) (cherry picked from commit feafdc0)
## Problem When a node with DOM widget overlays (e.g. CLIPTextEncode) is collapsed, the overlay elements can intercept pointer events intended for the canvas collapse toggler, making click-to-expand unreliable. ## Root Cause `updateWidgets()` runs during `onDrawForeground` (canvas render cycle) and sets `widgetState.visible = false` for collapsed nodes. `v-show` then hides the element with `display: none`. However, there is a timing gap between the canvas state change and Vue's DOM update — during this gap the widget overlay still intercepts pointer events. ## Fix Add `!widgetState.visible` to the `pointerEvents` condition in `composeStyle()`. This immediately sets `pointer-events: none` when the widget becomes invisible, preventing event interception before `v-show` applies `display: none`. Also restores click-to-expand in the E2E test, removing the programmatic `node.collapse()` workaround from PR #10967. - Fixes #11006 ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11063-fix-disable-pointer-events-on-non-visible-DOM-widget-overlays-33e6d73d36508179a83cd47121cf933f) by [Unito](https://www.unito.io) (cherry picked from commit 4cf160d)
…1240) ## Summary Fix collapsed node connection links rendering at wrong positions when entering a subgraph for the first time. `fitView()` (added in #10995) changes canvas scale/offset, invalidating cached slot positions for collapsed nodes. ## Changes - **What**: Schedule `requestSlotLayoutSyncForAllNodes()` on the next frame after `fitView()` in `restoreViewport()` so collapsed node slot positions are re-measured against the updated transform. Inner RAF guarded against mid-frame graph changes. - **Test coverage**: - Unit tests in `subgraphNavigationStore.viewport.test.ts` verify the RAF chain calls `requestSlotLayoutSyncForAllNodes` after `fitView`, and skip the re-sync when the active graph changes between frames. - E2E screenshot test (`@screenshot` tag) validates correct link rendering on first subgraph entry using a new fixture with a pre-collapsed inner node. ## Review Focus The nested `requestAnimationFrame` is intentional: the outer RAF runs `fitView()`, which updates `ds.scale`/`ds.offset` and triggers a CSS transform update on `TransformPane`. The inner RAF ensures the DOM has reflowed with the new transform before `requestSlotLayoutSyncForAllNodes()` measures `getBoundingClientRect()` on slot elements. --------- Co-authored-by: github-actions <github-actions@github.com> (cherry picked from commit 394e369)
…11779) ## Summary When inside a subgraph, the parent key handler intercepts the escape key before `processKey` is called, causing a stale ghost node to be added to the inner subgraph when the graph is changed to the parent. ## Changes - **What**: - move escape key handler to document, prevent propagating the event - add saftey net cancel in setGraph - tests ┆Issue is synchronized with this [Notion page](https://app.notion.com/p/PR-11779-fix-ensure-escape-key-graph-navigation-cancels-ghost-node-placement-3526d73d3650812292e4ca10d384f783) by [Unito](https://www.unito.io) (cherry picked from commit b8dfbfc)
(cherry picked from commit 975d5e5) Conflict: test file deleted on cloud/1.43; restored from PR.
(cherry picked from commit bd96bdf) Conflict: test file deleted on cloud/1.43; restored from PR.
(cherry picked from commit 818e549) Conflict: test file deleted on cloud/1.43; restored from PR.
*PR Created by the Glary-Bot Agent* --- ## Summary Deleting a workflow in the sidebar while search is active left the deleted workflow visible in the search results. Interacting with the stale entry (e.g. duplicate) caused undefined behavior. ## Root Cause `filteredWorkflows` in `BaseWorkflowsSidebarTab.vue` was a `ref` populated once per search event — a static snapshot that never reacted to store mutations. When `workflowStore.deleteWorkflow()` removed a workflow from `workflowLookup`, the search-panel's `filteredWorkflows` still held a stale reference. ## Fix Convert `filteredWorkflows` from a `ref` to a `computed` that reactively derives from `searchQuery` and `workflowStore.workflows`. This follows the same pattern already used by `filteredPersistedWorkflows` and `filteredBookmarkedWorkflows` in the same component. `handleSearch` is simplified to only manage tree expansion (its only remaining side effect). ## Test Plan Three e2e regression tests added to `workflowSearch.spec.ts`: - **Delete during search removes from results** — deletes a workflow while search is active, asserts it disappears - **Delete during search preserves siblings** — asserts all other matched workflows remain visible after one is deleted - **Clear search after delete shows correct browse view** — deletes during search, clears search, verifies browse view is consistent ## Screenshots   ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11425-fix-remove-deleted-workflow-from-search-results-in-sidebar-3476d73d365081f19ef6c6b9261a1ee9) by [Unito](https://www.unito.io) --------- Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> (cherry picked from commit 7d1d7c8)
(cherry picked from commit cf3006f) Conflict: file deleted on cloud/1.43; restored from PR.
(cherry picked from commit 125c11b) Conflict: file deleted on cloud/1.43; restored from PR.
4924e8a to
432f666
Compare
Merge conflicts resolvedRebased onto current Resolution:
New HEAD: Local verification: |
|
Updating Playwright Expectations |
christian-byrne
left a comment
There was a problem hiding this comment.
Read through all commits. Seems quite safe / clean
|
Thanks for the review @christian-byrne! |
*PR Created by the Glary-Bot Agent* --- ## Summary Small follow-up to #11926 picking up two Load3D bug fixes the strict pass identified as still missing on `cloud/1.43`. Skips one originally-shortlisted candidate (#11810) after verification — the bug doesn't exist on `cloud/1.43`. ## Picked | PR | Subject | User-visible bug | |---|---|---| | `#11825` | fix(load3d): snapshot original materials before reapplying materialMode | Wireframe / normal / depth modes don't restore the model's true original materials on reload | | `#11838` | fix(load3d): preserve unknown Model Config fields with spread | Future Model Config fields silently dropped on viewer dialog cancel/apply (Fixes #11346) | ## Skipped - **`#11810`** ("use capitalize for keybinding badges") — verified not applicable. The bug is `uppercase` Tailwind class on the Tag in `KeyComboDisplay.vue`. `cloud/1.43`'s file already uses neither `uppercase` nor `capitalize` — it just renders whatever `KeyComboImpl.getKeySequences()` returns directly, which is already canonical (`Ctrl`, `Alt`, `Shift`). No action needed. ## Conflict resolution notes - **`#11825`** — modify/delete on `SceneModelManager.test.ts` (deleted on cloud/1.43). Dropped the test additions; runtime fix in `SceneModelManager.ts` applied cleanly. - **`#11838`** — text conflict in `useLoad3dViewer.ts` because cloud/1.43 lacks gizmo support. Kept the spread fix (`...existingModelConfig` + `ModelConfig` typing) — that *is* the bug fix — and omitted the gizmo-related Model Config additions. ## Verification - ✅ `pnpm typecheck` clean - ✅ `pnpm typecheck:browser` clean - ✅ `pnpm knip` clean - ✅ `pnpm vitest run src/composables/useLoad3dViewer.test.ts` — 39/39 passed ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11975-backport-cloud-1-43-Load3D-fixes-follow-up-11825-11838-3576d73d365081428051cb75e1bb2318) by [Unito](https://www.unito.io) --------- Co-authored-by: Christian Byrne <cbyrne@comfy.org>
…ion (#11950) (#11996) *PR Created by the Glary-Bot Agent* --- ## Summary Two follow-up bug fixes that landed on `main` after the previous backport batches (#11926, #11975). ## Picked | PR | Subject | User-visible bug | |---|---|---| | `#11946` | fix: use resized QPO thumbnails (FE-538) | Floating QPO row thumbnails currently load full-size image/video assets while the canvas is being navigated; this swaps to `previewUrl` to use resized thumbnails. | | `#11950` | fix: highlight missing input slots on Vue nodes | Required-input validation highlighting was lost on Vue-rendered node input slots. Restores the error ring on the missing slot itself by wiring `useExecutionErrorStore` through `NodeSlots.vue` → `InputSlot`. | ## Conflict resolution notes - **#11946** — applied cleanly, no conflicts. - **#11950** — - `src/renderer/extensions/vueNodes/components/NodeSlots.vue`: cloud/1.43 imports `cn` from `@/utils/tailwindUtil`, main from `@comfyorg/tailwind-utils`. Kept cloud/1.43's import path; pulled in the new `useExecutionErrorStore` and `getLocatorIdFromNodeData` imports (both modules already exist on cloud/1.43). - `browser_tests/tests/vueNodes/nodeStates/error.spec.ts`: incoming version references helpers (`ErrorsTabHelper`, `cleanupFakeModel`) that don't exist on cloud/1.43. Restored cloud/1.43's version of the test file and removed the new `vue-node-required-input-missing-slot-error-chromium-linux.png` snapshot. The runtime fix in `NodeSlots.vue` lands; the new e2e regression test would need its helper deps backported separately. ## Verification - ✅ `pnpm typecheck` clean - ✅ `pnpm typecheck:browser` clean - ✅ `pnpm knip` clean - ✅ Targeted unit tests passing: `NodeSlots.test.ts` (9), `useErrorClearingHooks.test.ts` (24), `JobAssetsList.test.ts` (16) — 49/49 passed ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11996-backport-cloud-1-43-QPO-thumbnails-11946-Vue-node-slot-validation-11950-3576d73d365081e5b48bd3552cd34294) by [Unito](https://www.unito.io) --------- Co-authored-by: Benjamin Lu <benjaminlu1107@gmail.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
…ugh getDevOverride (#11384) (#11958) *PR Created by the Glary-Bot Agent* --- Cherry-pick of `4b7a02794` (PR #11384) from `main` onto `core/1.43`. This is **PR 2 of 2** in a sequential stack. **Stacked on top of #11957** (`fix: guard progress_text before canvas init`). **Merge #11957 first**, then this PR's base will retarget to `core/1.43`. ## Why Cloud reports of "Preview as Text" not displaying output when fed by API nodes traced back to two missing `progress_text` WebSocket fixes on `core/1.43`. The bundle PR #11926 picked these onto `cloud/1.43` but `core/1.43` was not in scope. This is the **primary fix** for the API-node Preview-as-Text symptom: `api.ts` was checking the **client** feature flags instead of **server** feature flags before parsing the new `progress_text` binary wire format (`[event_type][prompt_id_len][prompt_id][node_id_len][node_id][text]`). When the server advertised `supports_progress_text_metadata` (which v0.20.2 does) but the client check failed silently, the new wire format was parsed as the legacy format, mangling the bytes — which is exactly why API-node text outputs (which stream via `progress_text`) failed while Concatenate (which doesn't use `progress_text`) worked. Status confirmed via: - `git merge-base --is-ancestor 4b7a027 origin/main` → YES - `git merge-base --is-ancestor 4b7a027 origin/core/1.43` → NO (needs pick) ## Original PR Summary (#11384) > Route the `progress_text` binary parser's feature-flag check through `serverSupportsFeature()` so dev overrides via `localStorage` take effect. Replace `this.getClientFeatureFlags()?.supports_progress_text_metadata` with `this.serverSupportsFeature('supports_progress_text_metadata')` in the `case 3` binary message handler, consistent with all other feature-flag checks in the class. ## Files Changed - `src/scripts/api.ts` — 1 line: route the `progress_text` flag check through `serverSupportsFeature()` ## Verification **Local automated checks:** - `pnpm typecheck` → clean - `pnpm exec eslint src/scripts/api.ts` → 0 errors (file is in lint ignore list, expected) - `pnpm exec vitest run src/scripts/api.featureFlags.test.ts` → **15/15 passed** - Cherry-pick applied cleanly with no conflicts **Code review (Oracle):** 0 critical, 0 warning, 1 suggestion. Suggestion was about extending test coverage in `executionStore.test.ts` for an adjacent nullable branch — that file belongs to PR 1 (#11957) and the suggestion is out of scope for this 1-line API fix. Backports should not drift from main's test scope. **Manual / browser verification:** N/A for this change. The fix is a 1-line feature-flag routing correction with deterministic unit-test coverage. The behavior (binary-decoding `progress_text` event-type-3 frames) is the same code path already shipping in production via `main` (v1.44.16+) and `cloud/1.43` (via bundle PR #11926). End-to-end repro requires the cloud frontend pin to be bumped to a `core/1.43` build that includes this commit, which is the follow-up step outside this PR. ## Stack - Previous PR (#11957) → `core/1.43` - **This PR** → `glary/backport-core-1.43-11174-guard-progress-text` (merge that first, then retarget) ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11958-backport-core-1-43-fix-route-progress_text-feature-flag-check-through-getDevOverride--3576d73d365081d486b2d71ee8beb522) by [Unito](https://www.unito.io) Co-authored-by: GitHub Action <action@github.com>
) (#11957) *PR Created by the Glary-Bot Agent* --- Cherry-pick of `2524846f5` (PR #11174) from `main` onto `core/1.43`. This is **PR 1 of 2** in a sequential stack of `progress_text` WebSocket fixes that the `core/1.43` branch is missing. PR 2 (#11384, `route progress_text feature flag check through getDevOverride`) will stack on top of this branch. ## Why Cloud reports of "Preview as Text" not displaying output when fed by API nodes traced back to two missing `progress_text` WebSocket fixes on `core/1.43`. The bundle PR #11926 picked these onto `cloud/1.43` but `core/1.43` was not in scope and is still missing them. Status confirmed via: - `git merge-base --is-ancestor 2524846 origin/main` → YES - `git merge-base --is-ancestor 2524846 origin/core/1.43` → NO (needs pick) ## Original PR Summary (#11174) > Prevent early `progress_text` websocket events from throwing before the graph canvas is initialized. Guard `handleProgressText()` until `canvasStore.canvas` exists, and add a regression test for a startup-time `progress_text` event arriving before `GraphCanvas` finishes initialization. ## Files Changed - `src/stores/executionStore.ts` — null-guard canvas access at line 530 (`canvas?.graph?...`) - `src/stores/executionStore.test.ts` — regression test for pre-canvas-init event ## Verification **Local automated checks:** - `pnpm typecheck` → clean - `pnpm exec eslint src/stores/executionStore.ts src/stores/executionStore.test.ts` → 0 errors - `pnpm exec vitest run src/stores/executionStore.test.ts` → **40/40 passed** - `pnpm exec vitest run src/stores/executionStore.test.ts -t "progress_text"` → **2/2 targeted regression tests pass** - Cherry-pick applied cleanly with no conflicts **Code review (Oracle):** no critical or warning issues. Reviewer noted that early `progress_text` events are now silently dropped — this is the intended upstream behavior. **Manual / browser verification:** N/A for this change. The bug is a startup race where early `progress_text` binary WS frames (event type 3) hit `executionStore` before the `canvasStore.canvas` is set. The deterministic regression test in `executionStore.test.ts` simulates this race via mocked stores; reproducing it in a live browser would not be more meaningful and would not produce any visual diff. This is also a verbatim pick of a commit already shipping in production via `main` (v1.44.16+) and `cloud/1.43` (via bundle PR #11926). ## Stack - **This PR** → `core/1.43` - Next PR (#11384) → stacked on this branch's HEAD ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-11957-backport-core-1-43-fix-guard-progress_text-before-canvas-init-11174-3576d73d365081ddbcd0e19c487d39c2) by [Unito](https://www.unito.io) Co-authored-by: Dante <bunggl@naver.com>
… promoted widget values) (#11790) (#12098) *PR Created by the Glary-Bot Agent* --- ## Summary Backport of #11790 onto `cloud/1.43`. Reverts #10849 (per-instance promoted widget value storage) and its companion test-pinning PR #11697. **Why this is needed on `cloud/1.43`:** Glary-Bot's consolidated backport (#11926) cherry-picked #10849 into `cloud/1.43` on May 5 — four days *after* the same change was reverted on `main` in #11790. The audit didn't surface the upstream revert. As a result, `cloud/1.43` (1.43.16) currently ships the buggy #10849 implementation while `main` / nightly (1.45.1) doesn't. This is the cause of the Hub `rob_realistic_2k_images_quick_variations` model/vae/clip mixup regression reported in `#bug-dump`; the same template renders correctly on nightly. After this lands, `cloud/1.43` and `main` will be on the same code path for promoted-widget serialization. The replacement fix (#11811 with `_pendingWidgetsValuesReplay`) will land separately on `main` and can be backported afterward. ## Changes Mirrors the upstream revert of #10849 + #11697: - Removes `_instanceWidgetValues` map, `_pendingWidgetsValues` hydration, and the `widgets_values` write path in `SubgraphNode.serialize()` - Removes `sourceSerialize` field on `PromotedWidgetView` - Removes the multi-instance Vitest suite (`SubgraphNode.multiInstance.test.ts`) and the multi-instance E2E test + workflow asset ## Conflict Resolution Two conflicts surfaced (vs the original revert, which conflict-resolved against #11579 on `main`): 1. **`browser_tests/tests/subgraph/subgraphSerialization.spec.ts`** — `cloud/1.43` does not have the #11579 expanded test coverage (`Duplicate ID Remapping`, `Legacy Prefixed proxyWidget Normalization`) that the original revert preserved. Took the `cloud/1.43` HEAD structure and removed only the now-unreachable multi-instance test, its helper `getPromotedHostWidgetValues`, and the unused `ComfyPage` import. 2. **`src/lib/litegraph/src/subgraph/SubgraphNode.multiInstance.test.ts`** — `modify/delete` (file was present on `cloud/1.43`'s #10849 backport, deleted by the revert). Resolved by removing the file, matching the revert. ## Verification **Static analysis & tests:** - `pnpm typecheck` — clean - `pnpm typecheck:browser` — clean - `pnpm exec eslint` on all changed files — clean - `pnpm test:unit -- --run subgraph` — 506 tests passing across 34 suites (`SubgraphNode.test.ts`, `promotedWidgetView.test.ts`, `subgraphNodePromotion.test.ts`, etc.) **Manual verification (Playwright + local dev server):** - Started ComfyUI backend (`--cpu --port 8188`) and `pnpm dev` frontend; loaded the page successfully. - Loaded `subgraph-with-multiple-promoted-widgets.json` — subgraph node hydrated with 2 promoted widgets. - Set distinct values on each promoted widget (`first-promoted-value`, `second-promoted-value`), serialized via `app.graph.serialize()`, and reloaded via `app.loadGraphData(...)`. Both values round-tripped correctly to the right widget slots — confirming the revert restores the working single-instance path that nightly currently ships. - Hub-fetched template (`rob_realistic_2k_images_quick_variations`) could not be reproduced locally — `comfy.org/workflows/...` API returns 404 to anonymous curl from the sandbox, and the Hub UI flow needs auth wired up. The team has already confirmed this template renders correctly on nightly, which ships this same revert. ## Note on Oracle Review Oracle flagged the multi-instance regression and the cloud/1.43 forward-compat trade-off as "critical." These describe the *intended* behavior of this revert — the team has consciously chosen the legacy clobber path over #10849's broken per-instance code while the replacement (#11811) is finalized on `main`. Both findings are accepted trade-offs, not blockers. ┆Issue is synchronized with this [Notion page](https://www.notion.so/PR-12098-backport-cloud-1-43-revert-roll-back-10849-11697-per-instance-promoted-widget-va-35b6d73d36508109a715fc9d3428a294) by [Unito](https://www.unito.io) Co-authored-by: Alexander Brown <drjkl@comfy.org>
PR Created by the Glary-Bot Agent
Summary
Consolidated backport of bug fixes from
origin/main(which feedsv1.44.16) ontocloud/1.43. Cherry-picks every applicablefix:commit identified in the prior backport-gap audit socloud/1.43doesn't keep falling further behind.pnpm typecheckclean,pnpm knipclean,pnpm lint0 errors (warning count 2976 vs cloud/1.43 baseline 2877 — delta is from new test files brought in by the picks, not new lint errors),pnpm test:unit7842 passed / 8 skipped.This is a single consolidated PR per request — not a per-fix backport stream. Each commit has the original SHA recorded via
cherry picked from commit ...so individual reverts remain possible.Picked fixes (35)
App / runtime stability
#10995auto fit-to-view on first subgraph entry#11240re-sync collapsed node slot positions after subgraph fitView#10849store promoted widget values per SubgraphNode instance#10361place cloned node above original in Vue renderer#9935trigger Vue reactivity on output slot type changes in matchType#11541stop duplicate node creation when dropping image on Vue nodes#11779ensure escape key/graph navigation cancels ghost node placement#11063disable pointer events on non-visible DOM widget overlays#11295include focusMode in splitter refresh key to prevent panel resize#11487render edit pencil icon correctly in properties panel header#11296remove hover dimming overlay on image nodes#11542keep finished badge fully opaque in ProgressToastItem#11713search bar layout and autocomplete clipping on Desktop at small sizes#11570dedupe keybinding modifier display#11144fix(vite): hide git rev-parse window on WindowsCloud / subscription / workspace
#11130track workspace subscription success on immediate subscribe#11622dedupe pending checkout attempt construction#11463show credits in legacy user popover on non-cloud distributions#11636enable Chrome password autofill on signup form#11520fix(manager): migrate 4 endpoints GET→POST for CSRF hardening (security)#11425remove deleted workflow from search results in sidebarAssets / blueprints
#11700route context menu Download through downloadMultipleAssets#11502render asset fixtures in AssetBrowserModal stories#11759hide blueprint node id in search#11573translate blueprint labelTelemetry / progress / feature flags
#11174guard progress_text before canvas init#11384route progress_text feature flag check through getDevOverride#11417reset file input value after selection to allow same-file reuploadLoad3D
#11265fix(load3d): restore missed hover state when viewer init is async#11546load3d used wrong i18n key, add test#11359chain Load3D node lifecycle callbacks to preserve widget cleanupGLSL preview
#11010resolve incorrect GLSL live preview for non-primitive widget types#11517add GLSL live update when custom size is changedMisc
#10374consolidate--color-coral-redvariables into--color-coral#11283reduce noise in coverage Slack notificationsDropped commits (14) — need separate manual backport
These cherry-picks pulled in code that depends on infrastructure not present on
cloud/1.43, or required permissions a bot account does not hold. Individual backport tickets recommended:.github/workflows/release-biweekly-comfyui.yaml— bot lacksworkflowspermission. Also depends on prerequisite #11223 (patch-release support) not on cloud/1.43. Needs human-authored backport.ChangeTracker.prepareForSaveAPI added by #10816 / #11328 (refactors not on cloud/1.43)formatToISOWithSecondsand other utils indateTimeUtil.tsnot on cloud/1.43parseIsoDateSafefrom #11358useMediaAssetActions.test.tsrequiringdownloadAssetsAPI not on cloud/1.43useMediaAssetActionstest infrastructureuseMediaAssetActionstest infrastructureFormDropdownMenuItemPropstype,useWidgetSelectItemsnot on cloud/1.43useWidgetSelectItemsinfrastructureSceneModelManager.test.tsreferencingModelAdapterinfrastructure not on cloud/1.43 (memory-leak fix — manual backport recommended)LoaderManager.tsrewritten on main withModelAdapternot on cloud/1.43Conflict resolution notes
Most picks applied cleanly. Conflicts encountered:
-X theirs(cloud/1.43 just doesn't have those test files yet).src/components/searchbox/v2/NodeSearchListItem.test.ts— pulled in by fix: hide blueprint node id in search #11759 but referencedComfyNodeDefImplshape only on main. Removed the test file from the backport commit so the runtime fix lands; test should be rewritten/backported separately if desired.browser_tests/tests/vueNodes/glslPreview.spec.tsandbrowser_tests/tests/subgraph/subgraphBreadcrumb.spec.ts— pulled in by fix: add GLSL live update when custom size is changed #11517 / fix: translate blueprint label #11573 but reference helpers (@e2e/fixtures/helpers/ExecutionHelper,SubgraphBreadcrumbHelper) not on cloud/1.43. Removed the spec files from the respective backport commits; runtime fixes preserved.Out-of-scope review note
Code review flagged a behavioral concern in
subgraphNavigationStore.ts:142-153,173-177(restoreViewport()may auto-fit on first root-graph load even when the workflow already had a viewport). This is pre-existing onmain(the cherry-picked code is identical toorigin/mainfor that file region) — not introduced by this PR. Filing a separate ticket is recommended; not in scope for a backport batch.How to validate locally
┆Issue is synchronized with this Notion page by Unito